Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consult the environment variable when setting the max users frames in code origin probes #7881

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Consult the environment variable when setting the max users frames in code origin probes #7881

merged 3 commits into from
Nov 5, 2024

Conversation

evanchooly
Copy link
Contributor

@evanchooly evanchooly commented Nov 4, 2024 •
edited by jira bot
Loading

What Does This Do

Update the code origin code to check for an environment variable when configuring the maximum number of user frames to include in a code origin probe's output.

Jira ticket: DEBUG-2727

@pr-commenter
Copy link

pr-commenter bot commented Nov 4, 2024 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1730752490 1730752903
end_time 2024-11-04T20:36:19 2024-11-04T20:43:12
git_branch master evanchooly/DEBUG-2727
git_commit_sha f49ac98 ce240a9
start_time 2024-11-04T20:34:52 2024-11-04T20:41:45
See matching parameters
Baseline Candidate
ci_job_id 694764986 694764986
ci_pipeline_id 48196158 48196158
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
git_commit_date 1730751686 1730751686

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 5 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:basic better
[-19.031µs; -6.411µs] or [-6.048%; -2.037%]		 unsure
[-24.998µs; -3.135µs] or [-7.183%; -0.901%]		 same unstable
[-55.787µs; +60.736µs] or [-7.467%; +8.130%]		 same
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-17953.443ns; +19552.966ns] or [-6.032%; +6.570%]		 unstable
[-32035.116ns; +30553.422ns] or [-9.416%; +8.980%]		 unstable
[-46187.464ns; +47682.925ns] or [-12.960%; +13.380%]		 unstable
[-134.409µs; +148.047µs] or [-16.768%; +18.470%]		 same
scenario:loop unsure
[-65.943µs; -55.710µs] or [-0.588%; -0.497%]		 unsure
[-102.189µs; -8.987µs] or [-0.887%; -0.078%]		 same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (340.222 µs) : 312, 369
.   : milestone, 340,
basic (347.999 µs) : 337, 359
.   : milestone, 348,
loop (11.517 ms) : 11480, 11555
.   : milestone, 11517,
section candidate
noprobe (339.481 µs) : 309, 370
.   : milestone, 339,
basic (333.933 µs) : 324, 344
.   : milestone, 334,
loop (11.462 ms) : 11413, 11510
.   : milestone, 11462,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 340.222 µs [311.527 µs, 368.916 µs]
basic 347.999 µs [336.918 µs, 359.08 µs]
loop 11.517 ms [11.48 ms, 11.555 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 339.481 µs [308.744 µs, 370.217 µs]
basic 333.933 µs [323.789 µs, 344.077 µs]
loop 11.462 ms [11.413 ms, 11.51 ms]

@evanchooly evanchooly marked this pull request as ready for review November 4, 2024 20:39
@evanchooly evanchooly requested review from a team as code owners November 4, 2024 20:39
@evanchooly evanchooly requested review from jpbempel and PerfectSlayer and removed request for a team November 4, 2024 20:39
@pr-commenter
Copy link

pr-commenter bot commented Nov 4, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/DEBUG-2727
git_commit_date 1730748321 1730751686
git_commit_sha f49ac98 ce240a9
release_version 1.43.0-SNAPSHOT~f49ac98c70 1.43.0-SNAPSHOT~ce240a966c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730754308 1730754308
ci_job_id 694764974 694764974
ci_pipeline_id 48196158 48196158
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~ce240a966c, baseline=1.43.0-SNAPSHOT~f49ac98c70

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1087239
Total [baseline] (10.401 s) : 0, 10401300
Agent [candidate] (1.083 s) : 0, 1083111
Total [candidate] (10.406 s) : 0, 10405820
section appsec
Agent [baseline] (1.215 s) : 0, 1214824
Total [baseline] (10.74 s) : 0, 10739817
Agent [candidate] (1.221 s) : 0, 1220991
Total [candidate] (10.701 s) : 0, 10701095
section iast
Agent [baseline] (1.208 s) : 0, 1208223
Total [baseline] (10.943 s) : 0, 10942899
Agent [candidate] (1.226 s) : 0, 1226209
Total [candidate] (11.023 s) : 0, 11023417
section profiling
Agent [baseline] (1.28 s) : 0, 1279532
Total [baseline] (10.779 s) : 0, 10779318
Agent [candidate] (1.282 s) : 0, 1281958
Total [candidate] (10.722 s) : 0, 10721594
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.087 s -
Agent appsec 1.215 s 127.585 ms (11.7%)
Agent iast 1.208 s 120.984 ms (11.1%)
Agent profiling 1.28 s 192.294 ms (17.7%)
Total tracing 10.401 s -
Total appsec 10.74 s 338.516 ms (3.3%)
Total iast 10.943 s 541.598 ms (5.2%)
Total profiling 10.779 s 378.018 ms (3.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent appsec 1.221 s 137.88 ms (12.7%)
Agent iast 1.226 s 143.097 ms (13.2%)
Agent profiling 1.282 s 198.847 ms (18.4%)
Total tracing 10.406 s -
Total appsec 10.701 s 295.276 ms (2.8%)
Total iast 11.023 s 617.597 ms (5.9%)
Total profiling 10.722 s 315.774 ms (3.0%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~ce240a966c, baseline=1.43.0-SNAPSHOT~f49ac98c70

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.644 ms) : 0, 692644
BytebuddyAgent [candidate] (687.377 ms) : 0, 687377
GlobalTracer [baseline] (316.188 ms) : 0, 316188
GlobalTracer [candidate] (315.822 ms) : 0, 315822
AppSec [baseline] (54.175 ms) : 0, 54175
AppSec [candidate] (54.319 ms) : 0, 54319
Remote Config [baseline] (662.832 µs) : 0, 663
Remote Config [candidate] (664.276 µs) : 0, 664
Telemetry [baseline] (9.757 ms) : 0, 9757
Telemetry [candidate] (11.218 ms) : 0, 11218
section appsec
BytebuddyAgent [baseline] (704.193 ms) : 0, 704193
BytebuddyAgent [candidate] (708.987 ms) : 0, 708987
GlobalTracer [baseline] (312.935 ms) : 0, 312935
GlobalTracer [candidate] (314.122 ms) : 0, 314122
AppSec [baseline] (165.206 ms) : 0, 165206
AppSec [candidate] (165.189 ms) : 0, 165189
IAST [baseline] (19.438 ms) : 0, 19438
IAST [candidate] (20.885 ms) : 0, 20885
Remote Config [baseline] (639.789 µs) : 0, 640
Remote Config [candidate] (641.863 µs) : 0, 642
Telemetry [baseline] (8.433 ms) : 0, 8433
Telemetry [candidate] (7.819 ms) : 0, 7819
section iast
BytebuddyAgent [baseline] (803.281 ms) : 0, 803281
BytebuddyAgent [candidate] (816.346 ms) : 0, 816346
GlobalTracer [baseline] (304.911 ms) : 0, 304911
GlobalTracer [candidate] (308.824 ms) : 0, 308824
AppSec [baseline] (56.861 ms) : 0, 56861
AppSec [candidate] (57.912 ms) : 0, 57912
IAST [baseline] (21.337 ms) : 0, 21337
IAST [candidate] (20.958 ms) : 0, 20958
Remote Config [baseline] (617.223 µs) : 0, 617
Remote Config [candidate] (628.585 µs) : 0, 629
Telemetry [baseline] (7.454 ms) : 0, 7454
Telemetry [candidate] (7.574 ms) : 0, 7574
section profiling
BytebuddyAgent [baseline] (680.447 ms) : 0, 680447
BytebuddyAgent [candidate] (683.009 ms) : 0, 683009
GlobalTracer [baseline] (400.219 ms) : 0, 400219
GlobalTracer [candidate] (399.241 ms) : 0, 399241
AppSec [baseline] (54.632 ms) : 0, 54632
AppSec [candidate] (54.674 ms) : 0, 54674
Remote Config [baseline] (682.962 µs) : 0, 683
Remote Config [candidate] (681.968 µs) : 0, 682
Telemetry [baseline] (12.084 ms) : 0, 12084
Telemetry [candidate] (10.088 ms) : 0, 10088
ProfilingAgent [baseline] (92.472 ms) : 0, 92472
ProfilingAgent [candidate] (95.174 ms) : 0, 95174
Profiling [baseline] (92.496 ms) : 0, 92496
Profiling [candidate] (95.199 ms) : 0, 95199
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~ce240a966c, baseline=1.43.0-SNAPSHOT~f49ac98c70

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1085337
Total [baseline] (8.598 s) : 0, 8598009
Agent [candidate] (1.09 s) : 0, 1089901
Total [candidate] (8.63 s) : 0, 8629680
section iast
Agent [baseline] (1.21 s) : 0, 1210293
Total [baseline] (9.163 s) : 0, 9163411
Agent [candidate] (1.207 s) : 0, 1207222
Total [candidate] (9.167 s) : 0, 9166715
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.209 s) : 0, 1208983
Total [baseline] (9.14 s) : 0, 9139789
Agent [candidate] (1.208 s) : 0, 1208478
Total [candidate] (9.127 s) : 0, 9127409
section iast_TELEMETRY_OFF
Agent [baseline] (1.211 s) : 0, 1210995
Total [baseline] (9.169 s) : 0, 9168648
Agent [candidate] (1.208 s) : 0, 1208293
Total [candidate] (9.164 s) : 0, 9164254
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent iast 1.21 s 124.956 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.209 s 123.646 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.211 s 125.658 ms (11.6%)
Total tracing 8.598 s -
Total iast 9.163 s 565.402 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.14 s 541.78 ms (6.3%)
Total iast_TELEMETRY_OFF 9.169 s 570.639 ms (6.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.09 s -
Agent iast 1.207 s 117.321 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.208 s 118.577 ms (10.9%)
Agent iast_TELEMETRY_OFF 1.208 s 118.392 ms (10.9%)
Total tracing 8.63 s -
Total iast 9.167 s 537.035 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.127 s 497.729 ms (5.8%)
Total iast_TELEMETRY_OFF 9.164 s 534.574 ms (6.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~ce240a966c, baseline=1.43.0-SNAPSHOT~f49ac98c70

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.358 ms) : 0, 689358
BytebuddyAgent [candidate] (693.767 ms) : 0, 693767
GlobalTracer [baseline] (316.77 ms) : 0, 316770
GlobalTracer [candidate] (317.907 ms) : 0, 317907
AppSec [baseline] (54.144 ms) : 0, 54144
AppSec [candidate] (54.496 ms) : 0, 54496
Remote Config [baseline] (671.679 µs) : 0, 672
Remote Config [candidate] (662.071 µs) : 0, 662
Telemetry [baseline] (10.602 ms) : 0, 10602
Telemetry [candidate] (9.162 ms) : 0, 9162
section iast
BytebuddyAgent [baseline] (803.159 ms) : 0, 803159
BytebuddyAgent [candidate] (802.625 ms) : 0, 802625
GlobalTracer [baseline] (306.329 ms) : 0, 306329
GlobalTracer [candidate] (304.762 ms) : 0, 304762
AppSec [baseline] (56.265 ms) : 0, 56265
AppSec [candidate] (57.222 ms) : 0, 57222
IAST [baseline] (22.596 ms) : 0, 22596
IAST [candidate] (20.713 ms) : 0, 20713
Remote Config [baseline] (637.676 µs) : 0, 638
Remote Config [candidate] (625.926 µs) : 0, 626
Telemetry [baseline] (7.548 ms) : 0, 7548
Telemetry [candidate] (7.523 ms) : 0, 7523
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (803.869 ms) : 0, 803869
BytebuddyAgent [candidate] (802.996 ms) : 0, 802996
GlobalTracer [baseline] (305.114 ms) : 0, 305114
GlobalTracer [candidate] (304.865 ms) : 0, 304865
AppSec [baseline] (57.314 ms) : 0, 57314
AppSec [candidate] (56.534 ms) : 0, 56534
IAST [baseline] (20.771 ms) : 0, 20771
IAST [candidate] (22.137 ms) : 0, 22137
Remote Config [baseline] (625.174 µs) : 0, 625
Remote Config [candidate] (614.626 µs) : 0, 615
Telemetry [baseline] (7.509 ms) : 0, 7509
Telemetry [candidate] (7.558 ms) : 0, 7558
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.224 ms) : 0, 804224
BytebuddyAgent [candidate] (801.914 ms) : 0, 801914
GlobalTracer [baseline] (306.41 ms) : 0, 306410
GlobalTracer [candidate] (305.927 ms) : 0, 305927
AppSec [baseline] (57.925 ms) : 0, 57925
AppSec [candidate] (58.197 ms) : 0, 58197
IAST [baseline] (20.507 ms) : 0, 20507
IAST [candidate] (20.367 ms) : 0, 20367
Remote Config [baseline] (631.256 µs) : 0, 631
Remote Config [candidate] (616.595 µs) : 0, 617
Telemetry [baseline] (7.489 ms) : 0, 7489
Telemetry [candidate] (7.474 ms) : 0, 7474
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-04T20:35:22 2024-11-04T20:42:18
git_branch master evanchooly/DEBUG-2727
git_commit_date 1730748321 1730751686
git_commit_sha f49ac98 ce240a9
release_version 1.43.0-SNAPSHOT~f49ac98c70 1.43.0-SNAPSHOT~ce240a966c
start_time 2024-11-04T20:35:09 2024-11-04T20:42:05
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730753290 1730753290
ci_job_id 694764976 694764976
ci_pipeline_id 48196158 48196158
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~ce240a966c, baseline=1.43.0-SNAPSHOT~f49ac98c70
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.347 ms) : 1327, 1368
.   : milestone, 1347,
appsec (1.737 ms) : 1711, 1762
.   : milestone, 1737,
appsec_no_iast (1.737 ms) : 1712, 1762
.   : milestone, 1737,
iast (1.487 ms) : 1464, 1509
.   : milestone, 1487,
profiling (1.511 ms) : 1488, 1534
.   : milestone, 1511,
tracing (1.468 ms) : 1442, 1493
.   : milestone, 1468,
section candidate
no_agent (1.347 ms) : 1327, 1367
.   : milestone, 1347,
appsec (1.733 ms) : 1708, 1757
.   : milestone, 1733,
appsec_no_iast (1.745 ms) : 1721, 1769
.   : milestone, 1745,
iast (1.485 ms) : 1462, 1508
.   : milestone, 1485,
profiling (1.504 ms) : 1481, 1527
.   : milestone, 1504,
tracing (1.489 ms) : 1465, 1513
.   : milestone, 1489,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.327 ms, 1.368 ms] -
appsec 1.737 ms [1.711 ms, 1.762 ms] 389.125 µs (28.9%)
appsec_no_iast 1.737 ms [1.712 ms, 1.762 ms] 389.44 µs (28.9%)
iast 1.487 ms [1.464 ms, 1.509 ms] 139.194 µs (10.3%)
profiling 1.511 ms [1.488 ms, 1.534 ms] 163.434 µs (12.1%)
tracing 1.468 ms [1.442 ms, 1.493 ms] 120.207 µs (8.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.327 ms, 1.367 ms] -
appsec 1.733 ms [1.708 ms, 1.757 ms] 385.58 µs (28.6%)
appsec_no_iast 1.745 ms [1.721 ms, 1.769 ms] 398.098 µs (29.6%)
iast 1.485 ms [1.462 ms, 1.508 ms] 137.827 µs (10.2%)
profiling 1.504 ms [1.481 ms, 1.527 ms] 157.135 µs (11.7%)
tracing 1.489 ms [1.465 ms, 1.513 ms] 142.196 µs (10.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~ce240a966c, baseline=1.43.0-SNAPSHOT~f49ac98c70
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.151 µs) : 356, 396
.   : milestone, 376,
iast (499.717 µs) : 478, 521
.   : milestone, 500,
iast_FULL (644.259 µs) : 623, 666
.   : milestone, 644,
iast_GLOBAL (513.153 µs) : 492, 534
.   : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (493.323 µs) : 472, 515
.   : milestone, 493,
iast_INACTIVE (456.35 µs) : 435, 478
.   : milestone, 456,
iast_TELEMETRY_OFF (486.15 µs) : 464, 508
.   : milestone, 486,
tracing (455.634 µs) : 435, 477
.   : milestone, 456,
section candidate
no_agent (368.845 µs) : 349, 389
.   : milestone, 369,
iast (486.128 µs) : 465, 507
.   : milestone, 486,
iast_FULL (646.976 µs) : 625, 669
.   : milestone, 647,
iast_GLOBAL (518.544 µs) : 497, 540
.   : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (492.098 µs) : 471, 513
.   : milestone, 492,
iast_INACTIVE (455.34 µs) : 434, 477
.   : milestone, 455,
iast_TELEMETRY_OFF (480.136 µs) : 459, 502
.   : milestone, 480,
tracing (455.261 µs) : 434, 476
.   : milestone, 455,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.151 µs [356.208 µs, 396.093 µs] -
iast 499.717 µs [477.959 µs, 521.474 µs] 123.566 µs (32.9%)
iast_FULL 644.259 µs [622.947 µs, 665.572 µs] 268.109 µs (71.3%)
iast_GLOBAL 513.153 µs [491.998 µs, 534.308 µs] 137.002 µs (36.4%)
iast_HARDCODED_SECRET_DISABLED 493.323 µs [471.897 µs, 514.748 µs] 117.172 µs (31.2%)
iast_INACTIVE 456.35 µs [434.918 µs, 477.781 µs] 80.199 µs (21.3%)
iast_TELEMETRY_OFF 486.15 µs [464.294 µs, 508.006 µs] 109.999 µs (29.2%)
tracing 455.634 µs [434.605 µs, 476.663 µs] 79.484 µs (21.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.845 µs [348.974 µs, 388.716 µs] -
iast 486.128 µs [465.078 µs, 507.178 µs] 117.283 µs (31.8%)
iast_FULL 646.976 µs [625.305 µs, 668.647 µs] 278.131 µs (75.4%)
iast_GLOBAL 518.544 µs [497.4 µs, 539.688 µs] 149.699 µs (40.6%)
iast_HARDCODED_SECRET_DISABLED 492.098 µs [470.831 µs, 513.364 µs] 123.253 µs (33.4%)
iast_INACTIVE 455.34 µs [433.588 µs, 477.092 µs] 86.495 µs (23.5%)
iast_TELEMETRY_OFF 480.136 µs [458.693 µs, 501.579 µs] 111.291 µs (30.2%)
tracing 455.261 µs [434.248 µs, 476.273 µs] 86.416 µs (23.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/DEBUG-2727
git_commit_date 1730748321 1730751686
git_commit_sha f49ac98 ce240a9
release_version 1.43.0-SNAPSHOT~f49ac98c70 1.43.0-SNAPSHOT~ce240a966c
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1730753811 1730753811
ci_job_id 694764978 694764978
ci_pipeline_id 48196158 48196158
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~ce240a966c, baseline=1.43.0-SNAPSHOT~f49ac98c70
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.348 ms) : 2306, 2390
.   : milestone, 2348,
iast (2.083 ms) : 2031, 2136
.   : milestone, 2083,
iast_GLOBAL (2.133 ms) : 2081, 2186
.   : milestone, 2133,
profiling (2.394 ms) : 2150, 2638
.   : milestone, 2394,
tracing (1.922 ms) : 1882, 1962
.   : milestone, 1922,
section candidate
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.347 ms) : 2306, 2389
.   : milestone, 2347,
iast (2.085 ms) : 2033, 2138
.   : milestone, 2085,
iast_GLOBAL (2.137 ms) : 2083, 2190
.   : milestone, 2137,
profiling (1.949 ms) : 1907, 1990
.   : milestone, 1949,
tracing (1.944 ms) : 1903, 1985
.   : milestone, 1944,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 2.348 ms [2.306 ms, 2.39 ms] 879.64 µs (59.9%)
iast 2.083 ms [2.031 ms, 2.136 ms] 614.844 µs (41.9%)
iast_GLOBAL 2.133 ms [2.081 ms, 2.186 ms] 664.836 µs (45.3%)
profiling 2.394 ms [2.15 ms, 2.638 ms] 925.29 µs (63.0%)
tracing 1.922 ms [1.882 ms, 1.962 ms] 453.81 µs (30.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.459 ms, 1.482 ms] -
appsec 2.347 ms [2.306 ms, 2.389 ms] 877.02 µs (59.6%)
iast 2.085 ms [2.033 ms, 2.138 ms] 614.796 µs (41.8%)
iast_GLOBAL 2.137 ms [2.083 ms, 2.19 ms] 666.399 µs (45.3%)
profiling 1.949 ms [1.907 ms, 1.99 ms] 478.541 µs (32.5%)
tracing 1.944 ms [1.903 ms, 1.985 ms] 473.838 µs (32.2%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~ce240a966c, baseline=1.43.0-SNAPSHOT~f49ac98c70
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.299 s) : 15299000, 15299000
.   : milestone, 15299000,
appsec (15.184 s) : 15184000, 15184000
.   : milestone, 15184000,
iast (18.692 s) : 18692000, 18692000
.   : milestone, 18692000,
iast_GLOBAL (18.169 s) : 18169000, 18169000
.   : milestone, 18169000,
profiling (15.15 s) : 15150000, 15150000
.   : milestone, 15150000,
tracing (15.189 s) : 15189000, 15189000
.   : milestone, 15189000,
section candidate
no_agent (15.477 s) : 15477000, 15477000
.   : milestone, 15477000,
appsec (15.314 s) : 15314000, 15314000
.   : milestone, 15314000,
iast (18.97 s) : 18970000, 18970000
.   : milestone, 18970000,
iast_GLOBAL (18.17 s) : 18170000, 18170000
.   : milestone, 18170000,
profiling (15.256 s) : 15256000, 15256000
.   : milestone, 15256000,
tracing (15.418 s) : 15418000, 15418000
.   : milestone, 15418000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.299 s [15.299 s, 15.299 s] -
appsec 15.184 s [15.184 s, 15.184 s] -115.0 ms (-0.8%)
iast 18.692 s [18.692 s, 18.692 s] 3.393 s (22.2%)
iast_GLOBAL 18.169 s [18.169 s, 18.169 s] 2.87 s (18.8%)
profiling 15.15 s [15.15 s, 15.15 s] -149.0 ms (-1.0%)
tracing 15.189 s [15.189 s, 15.189 s] -110.0 ms (-0.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.477 s [15.477 s, 15.477 s] -
appsec 15.314 s [15.314 s, 15.314 s] -163.0 ms (-1.1%)
iast 18.97 s [18.97 s, 18.97 s] 3.493 s (22.6%)
iast_GLOBAL 18.17 s [18.17 s, 18.17 s] 2.693 s (17.4%)
profiling 15.256 s [15.256 s, 15.256 s] -221.0 ms (-1.4%)
tracing 15.418 s [15.418 s, 15.418 s] -59.0 ms (-0.4%)

PerfectSlayer
PerfectSlayer approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from Core/Platform POV

@evanchooly evanchooly merged commit 768ce77 into master Nov 5, 2024
102 checks passed
@evanchooly evanchooly deleted the evanchooly/DEBUG-2727 branch November 5, 2024 15:04
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbempel jpbempel jpbempel approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: enhancement
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
3 participants
@evanchooly @PerfectSlayer @jpbempel