-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not force-disable TLAB allocation events on JDK 8 #7878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~91bfec8385, baseline=1.42.0-SNAPSHOT~9846976b21
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1094410
Total [baseline] (10.423 s) : 0, 10423139
Agent [candidate] (1.095 s) : 0, 1095467
Total [candidate] (10.421 s) : 0, 10421389
section appsec
Agent [baseline] (1.218 s) : 0, 1218411
Total [baseline] (10.773 s) : 0, 10772997
Agent [candidate] (1.219 s) : 0, 1218532
Total [candidate] (10.714 s) : 0, 10713680
section iast
Agent [baseline] (1.211 s) : 0, 1210720
Total [baseline] (10.934 s) : 0, 10933527
Agent [candidate] (1.21 s) : 0, 1209799
Total [candidate] (10.914 s) : 0, 10914375
section profiling
Agent [baseline] (1.282 s) : 0, 1281828
Total [baseline] (10.833 s) : 0, 10832864
Agent [candidate] (1.301 s) : 0, 1301090
Total [candidate] (10.852 s) : 0, 10851841
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~91bfec8385, baseline=1.42.0-SNAPSHOT~9846976b21
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.791 ms) : 0, 695791
BytebuddyAgent [candidate] (694.346 ms) : 0, 694346
GlobalTracer [baseline] (320.179 ms) : 0, 320179
GlobalTracer [candidate] (320.281 ms) : 0, 320281
AppSec [baseline] (54.763 ms) : 0, 54763
AppSec [candidate] (54.876 ms) : 0, 54876
Remote Config [baseline] (661.206 µs) : 0, 661
Remote Config [candidate] (673.173 µs) : 0, 673
Telemetry [baseline] (9.134 ms) : 0, 9134
Telemetry [candidate] (11.405 ms) : 0, 11405
section appsec
BytebuddyAgent [baseline] (705.577 ms) : 0, 705577
BytebuddyAgent [candidate] (705.879 ms) : 0, 705879
GlobalTracer [baseline] (314.004 ms) : 0, 314004
GlobalTracer [candidate] (314.476 ms) : 0, 314476
AppSec [baseline] (166.803 ms) : 0, 166803
AppSec [candidate] (164.188 ms) : 0, 164188
Remote Config [baseline] (644.902 µs) : 0, 645
Remote Config [candidate] (636.859 µs) : 0, 637
Telemetry [baseline] (7.85 ms) : 0, 7850
Telemetry [candidate] (8.843 ms) : 0, 8843
IAST [baseline] (19.58 ms) : 0, 19580
IAST [candidate] (21.472 ms) : 0, 21472
section iast
BytebuddyAgent [baseline] (804.929 ms) : 0, 804929
BytebuddyAgent [candidate] (803.762 ms) : 0, 803762
GlobalTracer [baseline] (305.819 ms) : 0, 305819
GlobalTracer [candidate] (305.758 ms) : 0, 305758
AppSec [baseline] (57.523 ms) : 0, 57523
AppSec [candidate] (57.807 ms) : 0, 57807
Remote Config [baseline] (610.819 µs) : 0, 611
Remote Config [candidate] (616.966 µs) : 0, 617
Telemetry [baseline] (7.399 ms) : 0, 7399
Telemetry [candidate] (7.541 ms) : 0, 7541
IAST [baseline] (20.675 ms) : 0, 20675
IAST [candidate] (20.529 ms) : 0, 20529
section profiling
ProfilingAgent [baseline] (92.311 ms) : 0, 92311
ProfilingAgent [candidate] (93.864 ms) : 0, 93864
BytebuddyAgent [baseline] (681.757 ms) : 0, 681757
BytebuddyAgent [candidate] (692.549 ms) : 0, 692549
GlobalTracer [baseline] (400.545 ms) : 0, 400545
GlobalTracer [candidate] (405.812 ms) : 0, 405812
AppSec [baseline] (54.501 ms) : 0, 54501
AppSec [candidate] (55.256 ms) : 0, 55256
Remote Config [baseline] (675.763 µs) : 0, 676
Remote Config [candidate] (700.421 µs) : 0, 700
Telemetry [baseline] (12.878 ms) : 0, 12878
Telemetry [candidate] (13.077 ms) : 0, 13077
Profiling [baseline] (92.335 ms) : 0, 92335
Profiling [candidate] (93.887 ms) : 0, 93887
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~91bfec8385, baseline=1.42.0-SNAPSHOT~9846976b21
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1082723
Total [baseline] (8.614 s) : 0, 8614417
Agent [candidate] (1.091 s) : 0, 1091023
Total [candidate] (8.638 s) : 0, 8637601
section iast
Agent [baseline] (1.222 s) : 0, 1222447
Total [baseline] (9.196 s) : 0, 9195514
Agent [candidate] (1.21 s) : 0, 1210379
Total [candidate] (9.196 s) : 0, 9195986
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.21 s) : 0, 1210124
Total [baseline] (9.115 s) : 0, 9115198
Agent [candidate] (1.21 s) : 0, 1209772
Total [candidate] (9.156 s) : 0, 9155523
section iast_TELEMETRY_OFF
Agent [baseline] (1.206 s) : 0, 1205886
Total [baseline] (9.129 s) : 0, 9128878
Agent [candidate] (1.209 s) : 0, 1209175
Total [candidate] (9.135 s) : 0, 9134802
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~91bfec8385, baseline=1.42.0-SNAPSHOT~9846976b21
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.891 ms) : 0, 686891
BytebuddyAgent [candidate] (694.525 ms) : 0, 694525
GlobalTracer [baseline] (316.592 ms) : 0, 316592
GlobalTracer [candidate] (317.711 ms) : 0, 317711
AppSec [baseline] (54.22 ms) : 0, 54220
AppSec [candidate] (54.349 ms) : 0, 54349
Remote Config [baseline] (661.147 µs) : 0, 661
Remote Config [candidate] (672.631 µs) : 0, 673
Telemetry [baseline] (10.615 ms) : 0, 10615
Telemetry [candidate] (9.867 ms) : 0, 9867
section iast
BytebuddyAgent [baseline] (814.62 ms) : 0, 814620
BytebuddyAgent [candidate] (804.527 ms) : 0, 804527
GlobalTracer [baseline] (306.756 ms) : 0, 306756
GlobalTracer [candidate] (305.727 ms) : 0, 305727
AppSec [baseline] (55.586 ms) : 0, 55586
AppSec [candidate] (57.498 ms) : 0, 57498
IAST [baseline] (23.312 ms) : 0, 23312
IAST [candidate] (20.683 ms) : 0, 20683
Remote Config [baseline] (621.901 µs) : 0, 622
Remote Config [candidate] (624.266 µs) : 0, 624
Telemetry [baseline] (7.578 ms) : 0, 7578
Telemetry [candidate] (7.497 ms) : 0, 7497
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (803.85 ms) : 0, 803850
BytebuddyAgent [candidate] (803.426 ms) : 0, 803426
GlobalTracer [baseline] (306.211 ms) : 0, 306211
GlobalTracer [candidate] (306.228 ms) : 0, 306228
AppSec [baseline] (57.51 ms) : 0, 57510
AppSec [candidate] (57.576 ms) : 0, 57576
IAST [baseline] (20.542 ms) : 0, 20542
IAST [candidate] (20.584 ms) : 0, 20584
Remote Config [baseline] (626.698 µs) : 0, 627
Remote Config [candidate] (618.218 µs) : 0, 618
Telemetry [baseline] (7.578 ms) : 0, 7578
Telemetry [candidate] (7.538 ms) : 0, 7538
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.535 ms) : 0, 800535
BytebuddyAgent [candidate] (802.119 ms) : 0, 802119
GlobalTracer [baseline] (305.86 ms) : 0, 305860
GlobalTracer [candidate] (306.905 ms) : 0, 306905
AppSec [baseline] (55.962 ms) : 0, 55962
AppSec [candidate] (58.027 ms) : 0, 58027
IAST [baseline] (21.819 ms) : 0, 21819
IAST [candidate] (20.342 ms) : 0, 20342
Remote Config [baseline] (600.099 µs) : 0, 600
Remote Config [candidate] (607.071 µs) : 0, 607
Telemetry [baseline] (7.347 ms) : 0, 7347
Telemetry [candidate] (7.347 ms) : 0, 7347
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 7 metrics, 21 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~91bfec8385, baseline=1.42.0-SNAPSHOT~9846976b21
dateFormat X
axisFormat %s
section baseline
no_agent (1.703 ms) : 1678, 1729
. : milestone, 1703,
appsec (2.167 ms) : 2136, 2198
. : milestone, 2167,
appsec_no_iast (2.181 ms) : 2150, 2212
. : milestone, 2181,
iast (1.903 ms) : 1873, 1934
. : milestone, 1903,
profiling (1.95 ms) : 1917, 1983
. : milestone, 1950,
tracing (1.877 ms) : 1846, 1909
. : milestone, 1877,
section candidate
no_agent (1.704 ms) : 1679, 1729
. : milestone, 1704,
appsec (2.206 ms) : 2174, 2238
. : milestone, 2206,
appsec_no_iast (2.191 ms) : 2160, 2222
. : milestone, 2191,
iast (1.893 ms) : 1863, 1924
. : milestone, 1893,
profiling (1.911 ms) : 1877, 1945
. : milestone, 1911,
tracing (1.885 ms) : 1854, 1917
. : milestone, 1885,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~91bfec8385, baseline=1.42.0-SNAPSHOT~9846976b21
dateFormat X
axisFormat %s
section baseline
no_agent (449.445 µs) : 421, 478
. : milestone, 449,
iast (589.775 µs) : 557, 622
. : milestone, 590,
iast_FULL (832.15 µs) : 799, 865
. : milestone, 832,
iast_GLOBAL (623.721 µs) : 591, 657
. : milestone, 624,
iast_HARDCODED_SECRET_DISABLED (591.126 µs) : 558, 624
. : milestone, 591,
iast_INACTIVE (537.102 µs) : 506, 568
. : milestone, 537,
iast_TELEMETRY_OFF (580.394 µs) : 548, 613
. : milestone, 580,
tracing (535.399 µs) : 505, 565
. : milestone, 535,
section candidate
no_agent (446.733 µs) : 418, 476
. : milestone, 447,
iast (585.25 µs) : 553, 618
. : milestone, 585,
iast_FULL (831.963 µs) : 799, 865
. : milestone, 832,
iast_GLOBAL (624.848 µs) : 592, 657
. : milestone, 625,
iast_HARDCODED_SECRET_DISABLED (584.992 µs) : 552, 618
. : milestone, 585,
iast_INACTIVE (540.869 µs) : 509, 572
. : milestone, 541,
iast_TELEMETRY_OFF (586.525 µs) : 554, 619
. : milestone, 587,
tracing (542.969 µs) : 513, 573
. : milestone, 543,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~91bfec8385, baseline=1.42.0-SNAPSHOT~9846976b21
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (2.353 ms) : 2311, 2395
. : milestone, 2353,
iast (2.078 ms) : 2026, 2129
. : milestone, 2078,
iast_GLOBAL (2.128 ms) : 2075, 2180
. : milestone, 2128,
profiling (1.952 ms) : 1911, 1994
. : milestone, 1952,
tracing (1.922 ms) : 1882, 1963
. : milestone, 1922,
section candidate
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (2.336 ms) : 2295, 2377
. : milestone, 2336,
iast (2.091 ms) : 2038, 2144
. : milestone, 2091,
iast_GLOBAL (2.118 ms) : 2066, 2170
. : milestone, 2118,
profiling (1.948 ms) : 1905, 1991
. : milestone, 1948,
tracing (1.93 ms) : 1890, 1970
. : milestone, 1930,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~91bfec8385, baseline=1.42.0-SNAPSHOT~9846976b21
dateFormat X
axisFormat %s
section baseline
no_agent (15.45 s) : 15450000, 15450000
. : milestone, 15450000,
appsec (15.388 s) : 15388000, 15388000
. : milestone, 15388000,
iast (19.075 s) : 19075000, 19075000
. : milestone, 19075000,
iast_GLOBAL (18.23 s) : 18230000, 18230000
. : milestone, 18230000,
profiling (15.249 s) : 15249000, 15249000
. : milestone, 15249000,
tracing (15.148 s) : 15148000, 15148000
. : milestone, 15148000,
section candidate
no_agent (15.744 s) : 15744000, 15744000
. : milestone, 15744000,
appsec (15.266 s) : 15266000, 15266000
. : milestone, 15266000,
iast (19.018 s) : 19018000, 19018000
. : milestone, 19018000,
iast_GLOBAL (18.31 s) : 18310000, 18310000
. : milestone, 18310000,
profiling (15.188 s) : 15188000, 15188000
. : milestone, 15188000,
tracing (15.132 s) : 15132000, 15132000
. : milestone, 15132000,
|
richardstartin
approved these changes
Nov 4, 2024
MattAlp
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adjusts the DatadogProfiler configuration code not to force-disable TLAB allocation events on JDK 8
Motivation
Currently it is not possible to run DD Java profiler and have allocation profiling at the same time, even with manually enabled TLAB allocation events. The reason is that Java profiler incorrectly assumes that it can provide the allocation profiling feature and proactively disables the TLAB allocation events, which can be particularly expensive, depending on the application.
The change is to make Java profiler aware of the fact that on Java 8 it can not provide the allocation profiling feature.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: PROF-10847