Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lettuce 6.5 #7876

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Support lettuce 6.5 #7876

merged 1 commit into from
Nov 4, 2024

Conversation

amarziali
Copy link
Collaborator

What Does This Do

Add support for lettuce 6.5 and extend testing.

Avoid using name while using toString (generally works ok on previous versions since commandKeyword are enums and toString is not overridden)

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner November 4, 2024 10:17
@amarziali amarziali added the inst: lettuce Lettuce instrumentation label Nov 4, 2024
@amarziali amarziali enabled auto-merge (squash) November 4, 2024 10:27
@amarziali amarziali merged commit 9055dd5 into master Nov 4, 2024
97 of 100 checks passed
@amarziali amarziali deleted the andrea.marziali/lettuce-6.5 branch November 4, 2024 10:45
@github-actions github-actions bot added this to the 1.42.0 milestone Nov 4, 2024
Copy link
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I also did a bit of research and found a small caveat. This won't work for versions from 5.0.0.Beta to 5.1.0.M1 because StringCommandType.toString was only added in the latter version.

image

Which is just a few very old releases:

5.0.0.Beta1
5.0.0.M2
5.0.0.RC1
5.0.0.RC2
5.0.0.RELEASE
5.0.1.RELEASE
5.0.2.RELEASE
5.0.3.RELEASE
5.0.4.RELEASE
5.0.5.RELEASE

And even if someone still uses it, the only problem will be that instead of a string command name it will use the auto-generated StringCommandType.toString, which doesn't seem to be a big problem at all.

@amarziali
Copy link
Collaborator Author

@ygree thanks. I imagined that the toString generally delegates to name. I think that's acceptable to live with this caveats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inst: lettuce Lettuce instrumentation type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants