-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delay queue time rate limiting until event is committed #7867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
force-pushed
the
rgs/defer-queue-rate-limiting
branch
from
October 31, 2024 15:10
f419d6d
to
d01b560
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~d01b560747, baseline=1.42.0-SNAPSHOT~497e7c8bca
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.095 s) : 0, 1095309
Total [baseline] (8.649 s) : 0, 8648950
Agent [candidate] (1.082 s) : 0, 1081927
Total [candidate] (8.597 s) : 0, 8597211
section iast
Agent [baseline] (1.208 s) : 0, 1207968
Total [baseline] (9.205 s) : 0, 9204659
Agent [candidate] (1.206 s) : 0, 1206165
Total [candidate] (9.173 s) : 0, 9173216
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.215 s) : 0, 1215221
Total [baseline] (9.136 s) : 0, 9136100
Agent [candidate] (1.209 s) : 0, 1209452
Total [candidate] (9.147 s) : 0, 9146876
section iast_TELEMETRY_OFF
Agent [baseline] (1.214 s) : 0, 1214454
Total [baseline] (9.215 s) : 0, 9214886
Agent [candidate] (1.205 s) : 0, 1205327
Total [candidate] (9.152 s) : 0, 9152411
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~d01b560747, baseline=1.42.0-SNAPSHOT~497e7c8bca
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.043 ms) : 0, 695043
BytebuddyAgent [candidate] (687.193 ms) : 0, 687193
GlobalTracer [baseline] (319.626 ms) : 0, 319626
GlobalTracer [candidate] (316.027 ms) : 0, 316027
AppSec [baseline] (54.498 ms) : 0, 54498
AppSec [candidate] (54.435 ms) : 0, 54435
Remote Config [baseline] (674.565 µs) : 0, 675
Remote Config [candidate] (666.323 µs) : 0, 666
Telemetry [baseline] (11.512 ms) : 0, 11512
Telemetry [candidate] (9.771 ms) : 0, 9771
section iast
BytebuddyAgent [baseline] (802.393 ms) : 0, 802393
BytebuddyAgent [candidate] (802.272 ms) : 0, 802272
GlobalTracer [baseline] (305.286 ms) : 0, 305286
GlobalTracer [candidate] (304.289 ms) : 0, 304289
AppSec [baseline] (56.307 ms) : 0, 56307
AppSec [candidate] (57.326 ms) : 0, 57326
IAST [baseline] (21.251 ms) : 0, 21251
IAST [candidate] (20.482 ms) : 0, 20482
Remote Config [baseline] (1.375 ms) : 0, 1375
Remote Config [candidate] (614.257 µs) : 0, 614
Telemetry [baseline] (7.464 ms) : 0, 7464
Telemetry [candidate] (7.326 ms) : 0, 7326
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.469 ms) : 0, 807469
BytebuddyAgent [candidate] (804.047 ms) : 0, 804047
GlobalTracer [baseline] (306.426 ms) : 0, 306426
GlobalTracer [candidate] (304.486 ms) : 0, 304486
AppSec [baseline] (58.486 ms) : 0, 58486
AppSec [candidate] (57.36 ms) : 0, 57360
IAST [baseline] (20.663 ms) : 0, 20663
IAST [candidate] (21.58 ms) : 0, 21580
Remote Config [baseline] (615.512 µs) : 0, 616
Remote Config [candidate] (617.075 µs) : 0, 617
Telemetry [baseline] (7.643 ms) : 0, 7643
Telemetry [candidate] (7.506 ms) : 0, 7506
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (806.324 ms) : 0, 806324
BytebuddyAgent [candidate] (799.265 ms) : 0, 799265
GlobalTracer [baseline] (306.978 ms) : 0, 306978
GlobalTracer [candidate] (305.801 ms) : 0, 305801
AppSec [baseline] (58.058 ms) : 0, 58058
AppSec [candidate] (57.303 ms) : 0, 57303
IAST [baseline] (21.092 ms) : 0, 21092
IAST [candidate] (20.291 ms) : 0, 20291
Remote Config [baseline] (602.159 µs) : 0, 602
Remote Config [candidate] (607.566 µs) : 0, 608
Telemetry [baseline] (7.473 ms) : 0, 7473
Telemetry [candidate] (8.219 ms) : 0, 8219
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~d01b560747, baseline=1.42.0-SNAPSHOT~497e7c8bca
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1091153
Total [baseline] (10.463 s) : 0, 10462875
Agent [candidate] (1.086 s) : 0, 1086429
Total [candidate] (10.434 s) : 0, 10434088
section appsec
Agent [baseline] (1.216 s) : 0, 1215707
Total [baseline] (10.676 s) : 0, 10676082
Agent [candidate] (1.221 s) : 0, 1220540
Total [candidate] (10.712 s) : 0, 10712076
section iast
Agent [baseline] (1.218 s) : 0, 1217803
Total [baseline] (10.938 s) : 0, 10937777
Agent [candidate] (1.211 s) : 0, 1211373
Total [candidate] (10.969 s) : 0, 10968703
section profiling
Agent [baseline] (1.289 s) : 0, 1288793
Total [baseline] (10.779 s) : 0, 10779359
Agent [candidate] (1.278 s) : 0, 1277633
Total [candidate] (10.723 s) : 0, 10723294
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~d01b560747, baseline=1.42.0-SNAPSHOT~497e7c8bca
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.222 ms) : 0, 693222
BytebuddyAgent [candidate] (689.069 ms) : 0, 689069
GlobalTracer [baseline] (319.376 ms) : 0, 319376
GlobalTracer [candidate] (318.439 ms) : 0, 318439
AppSec [baseline] (54.136 ms) : 0, 54136
AppSec [candidate] (55.151 ms) : 0, 55151
Remote Config [baseline] (664.78 µs) : 0, 665
Remote Config [candidate] (676.392 µs) : 0, 676
Telemetry [baseline] (9.846 ms) : 0, 9846
Telemetry [candidate] (9.28 ms) : 0, 9280
section appsec
BytebuddyAgent [baseline] (703.459 ms) : 0, 703459
BytebuddyAgent [candidate] (706.808 ms) : 0, 706808
GlobalTracer [baseline] (313.577 ms) : 0, 313577
GlobalTracer [candidate] (314.626 ms) : 0, 314626
AppSec [baseline] (165.692 ms) : 0, 165692
AppSec [candidate] (166.056 ms) : 0, 166056
IAST [baseline] (19.492 ms) : 0, 19492
IAST [candidate] (20.201 ms) : 0, 20201
Remote Config [baseline] (645.398 µs) : 0, 645
Remote Config [candidate] (646.98 µs) : 0, 647
Telemetry [baseline] (8.828 ms) : 0, 8828
Telemetry [candidate] (8.451 ms) : 0, 8451
section iast
BytebuddyAgent [baseline] (809.509 ms) : 0, 809509
BytebuddyAgent [candidate] (805.211 ms) : 0, 805211
GlobalTracer [baseline] (307.468 ms) : 0, 307468
GlobalTracer [candidate] (305.308 ms) : 0, 305308
AppSec [baseline] (57.956 ms) : 0, 57956
AppSec [candidate] (56.65 ms) : 0, 56650
IAST [baseline] (20.834 ms) : 0, 20834
IAST [candidate] (22.25 ms) : 0, 22250
Remote Config [baseline] (618.538 µs) : 0, 619
Remote Config [candidate] (608.931 µs) : 0, 609
Telemetry [baseline] (7.535 ms) : 0, 7535
Telemetry [candidate] (7.502 ms) : 0, 7502
section profiling
BytebuddyAgent [baseline] (686.424 ms) : 0, 686424
BytebuddyAgent [candidate] (679.295 ms) : 0, 679295
GlobalTracer [baseline] (402.588 ms) : 0, 402588
GlobalTracer [candidate] (399.518 ms) : 0, 399518
AppSec [baseline] (54.619 ms) : 0, 54619
AppSec [candidate] (54.483 ms) : 0, 54483
Remote Config [baseline] (682.419 µs) : 0, 682
Remote Config [candidate] (666.78 µs) : 0, 667
Telemetry [baseline] (12.05 ms) : 0, 12050
Telemetry [candidate] (12.956 ms) : 0, 12956
ProfilingAgent [baseline] (93.145 ms) : 0, 93145
ProfilingAgent [candidate] (91.747 ms) : 0, 91747
Profiling [baseline] (93.168 ms) : 0, 93168
Profiling [candidate] (91.77 ms) : 0, 91770
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~d01b560747, baseline=1.42.0-SNAPSHOT~497e7c8bca
dateFormat X
axisFormat %s
section baseline
no_agent (373.942 µs) : 354, 394
. : milestone, 374,
iast (491.134 µs) : 470, 512
. : milestone, 491,
iast_FULL (642.901 µs) : 622, 664
. : milestone, 643,
iast_GLOBAL (512.816 µs) : 492, 534
. : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (491.656 µs) : 470, 513
. : milestone, 492,
iast_INACTIVE (454.671 µs) : 434, 476
. : milestone, 455,
iast_TELEMETRY_OFF (473.342 µs) : 452, 494
. : milestone, 473,
tracing (445.384 µs) : 425, 466
. : milestone, 445,
section candidate
no_agent (369.3 µs) : 350, 389
. : milestone, 369,
iast (492.407 µs) : 471, 514
. : milestone, 492,
iast_FULL (649.318 µs) : 628, 671
. : milestone, 649,
iast_GLOBAL (518.236 µs) : 496, 540
. : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (495.73 µs) : 474, 517
. : milestone, 496,
iast_INACTIVE (451.939 µs) : 431, 473
. : milestone, 452,
iast_TELEMETRY_OFF (482.182 µs) : 460, 504
. : milestone, 482,
tracing (450.824 µs) : 430, 472
. : milestone, 451,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~d01b560747, baseline=1.42.0-SNAPSHOT~497e7c8bca
dateFormat X
axisFormat %s
section baseline
no_agent (1.368 ms) : 1349, 1388
. : milestone, 1368,
appsec (1.732 ms) : 1707, 1757
. : milestone, 1732,
appsec_no_iast (1.749 ms) : 1724, 1774
. : milestone, 1749,
iast (1.487 ms) : 1465, 1510
. : milestone, 1487,
profiling (1.482 ms) : 1459, 1505
. : milestone, 1482,
tracing (1.477 ms) : 1453, 1502
. : milestone, 1477,
section candidate
no_agent (1.349 ms) : 1330, 1369
. : milestone, 1349,
appsec (1.743 ms) : 1720, 1766
. : milestone, 1743,
appsec_no_iast (1.746 ms) : 1723, 1770
. : milestone, 1746,
iast (1.483 ms) : 1460, 1505
. : milestone, 1483,
profiling (1.475 ms) : 1452, 1498
. : milestone, 1475,
tracing (1.486 ms) : 1463, 1510
. : milestone, 1486,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~d01b560747, baseline=1.42.0-SNAPSHOT~497e7c8bca
dateFormat X
axisFormat %s
section baseline
no_agent (1.46 ms) : 1448, 1471
. : milestone, 1460,
appsec (2.315 ms) : 2274, 2356
. : milestone, 2315,
iast (2.065 ms) : 2013, 2118
. : milestone, 2065,
iast_GLOBAL (2.116 ms) : 2063, 2169
. : milestone, 2116,
profiling (1.925 ms) : 1882, 1968
. : milestone, 1925,
tracing (1.913 ms) : 1874, 1953
. : milestone, 1913,
section candidate
no_agent (1.462 ms) : 1450, 1473
. : milestone, 1462,
appsec (2.32 ms) : 2278, 2361
. : milestone, 2320,
iast (2.068 ms) : 2016, 2120
. : milestone, 2068,
iast_GLOBAL (2.106 ms) : 2055, 2158
. : milestone, 2106,
profiling (1.923 ms) : 1881, 1966
. : milestone, 1923,
tracing (1.905 ms) : 1865, 1944
. : milestone, 1905,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~d01b560747, baseline=1.42.0-SNAPSHOT~497e7c8bca
dateFormat X
axisFormat %s
section baseline
no_agent (15.128 s) : 15128000, 15128000
. : milestone, 15128000,
appsec (15.26 s) : 15260000, 15260000
. : milestone, 15260000,
iast (18.733 s) : 18733000, 18733000
. : milestone, 18733000,
iast_GLOBAL (17.936 s) : 17936000, 17936000
. : milestone, 17936000,
profiling (15.074 s) : 15074000, 15074000
. : milestone, 15074000,
tracing (15.308 s) : 15308000, 15308000
. : milestone, 15308000,
section candidate
no_agent (14.847 s) : 14847000, 14847000
. : milestone, 14847000,
appsec (15.203 s) : 15203000, 15203000
. : milestone, 15203000,
iast (18.884 s) : 18884000, 18884000
. : milestone, 18884000,
iast_GLOBAL (17.917 s) : 17917000, 17917000
. : milestone, 17917000,
profiling (15.469 s) : 15469000, 15469000
. : milestone, 15469000,
tracing (15.116 s) : 15116000, 15116000
. : milestone, 15116000,
|
jbachorik
reviewed
Oct 31, 2024
.../src/main/java/datadog/trace/bootstrap/instrumentation/java/concurrent/QueueTimerHelper.java
Outdated
Show resolved
Hide resolved
MattAlp
approved these changes
Oct 31, 2024
jbachorik
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Applies rate limiting to the known outliers, not to every queue transaction.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]