Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _dd.dbm_trace_injected tag to SQL Server prepared statements #7863

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Add _dd.dbm_trace_injected tag to SQL Server prepared statements #7863

merged 2 commits into from
Oct 31, 2024

Conversation

nenadnoveljic
Copy link
Contributor

@nenadnoveljic nenadnoveljic commented Oct 30, 2024 •
edited
Loading

What Does This Do

Add _dd.dbm_trace_injected tag to PreperedStatement advisor for SQL Server.

Motivation

Full mode APM/DBM support for prepared statements.

image

image

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@nenadnoveljic nenadnoveljic changed the title Add DBM_TRACE_INJECTED tag to SQL Server prepared statements Add _dd.dbm_trace_injected tag to SQL Server prepared statements Oct 30, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 30, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nenadnoveljic/sqlserver-prepared-statements
git_commit_date 1730315410 1730316066
git_commit_sha 104a441 50a4b5e
release_version 1.42.0-SNAPSHOT~104a441d0a 1.42.0-SNAPSHOT~50a4b5ec23
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730318318 1730318318
ci_job_id 690635229 690635229
ci_pipeline_id 47892644 47892644
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~50a4b5ec23, baseline=1.42.0-SNAPSHOT~104a441d0a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076460
Total [baseline] (8.569 s) : 0, 8569005
Agent [candidate] (1.079 s) : 0, 1078745
Total [candidate] (8.555 s) : 0, 8554531
section iast
Agent [baseline] (1.211 s) : 0, 1210582
Total [baseline] (9.105 s) : 0, 9105218
Agent [candidate] (1.209 s) : 0, 1208985
Total [candidate] (9.115 s) : 0, 9114567
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.199 s) : 0, 1198585
Total [baseline] (9.075 s) : 0, 9075254
Agent [candidate] (1.199 s) : 0, 1198779
Total [candidate] (9.084 s) : 0, 9083825
section iast_TELEMETRY_OFF
Agent [baseline] (1.196 s) : 0, 1195872
Total [baseline] (9.082 s) : 0, 9082031
Agent [candidate] (1.215 s) : 0, 1215004
Total [candidate] (9.136 s) : 0, 9136401
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.211 s 134.121 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.199 s 122.124 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.196 s 119.411 ms (11.1%)
Total tracing 8.569 s -
Total iast 9.105 s 536.213 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.075 s 506.249 ms (5.9%)
Total iast_TELEMETRY_OFF 9.082 s 513.026 ms (6.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent iast 1.209 s 130.24 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.199 s 120.035 ms (11.1%)
Agent iast_TELEMETRY_OFF 1.215 s 136.259 ms (12.6%)
Total tracing 8.555 s -
Total iast 9.115 s 560.036 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.084 s 529.294 ms (6.2%)
Total iast_TELEMETRY_OFF 9.136 s 581.87 ms (6.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~50a4b5ec23, baseline=1.42.0-SNAPSHOT~104a441d0a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.856 ms) : 0, 683856
BytebuddyAgent [candidate] (686.602 ms) : 0, 686602
GlobalTracer [baseline] (313.26 ms) : 0, 313260
GlobalTracer [candidate] (313.975 ms) : 0, 313975
AppSec [baseline] (54.0 ms) : 0, 54000
AppSec [candidate] (54.092 ms) : 0, 54092
Remote Config [baseline] (653.229 µs) : 0, 653
Remote Config [candidate] (665.236 µs) : 0, 665
Telemetry [baseline] (11.126 ms) : 0, 11126
Telemetry [candidate] (9.789 ms) : 0, 9789
section iast
BytebuddyAgent [baseline] (807.31 ms) : 0, 807310
BytebuddyAgent [candidate] (806.128 ms) : 0, 806128
GlobalTracer [baseline] (304.252 ms) : 0, 304252
GlobalTracer [candidate] (304.58 ms) : 0, 304580
AppSec [baseline] (56.019 ms) : 0, 56019
AppSec [candidate] (55.428 ms) : 0, 55428
IAST [baseline] (21.355 ms) : 0, 21355
IAST [candidate] (21.241 ms) : 0, 21241
Remote Config [baseline] (591.912 µs) : 0, 592
Remote Config [candidate] (590.844 µs) : 0, 591
Telemetry [baseline] (7.34 ms) : 0, 7340
Telemetry [candidate] (7.272 ms) : 0, 7272
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.775 ms) : 0, 798775
BytebuddyAgent [candidate] (798.481 ms) : 0, 798481
GlobalTracer [baseline] (301.39 ms) : 0, 301390
GlobalTracer [candidate] (302.056 ms) : 0, 302056
AppSec [baseline] (57.003 ms) : 0, 57003
AppSec [candidate] (56.976 ms) : 0, 56976
IAST [baseline] (19.907 ms) : 0, 19907
IAST [candidate] (19.688 ms) : 0, 19688
Remote Config [baseline] (596.239 µs) : 0, 596
Remote Config [candidate] (595.793 µs) : 0, 596
Telemetry [baseline] (7.381 ms) : 0, 7381
Telemetry [candidate] (7.392 ms) : 0, 7392
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.152 ms) : 0, 796152
BytebuddyAgent [candidate] (809.297 ms) : 0, 809297
GlobalTracer [baseline] (301.513 ms) : 0, 301513
GlobalTracer [candidate] (306.873 ms) : 0, 306873
AppSec [baseline] (56.653 ms) : 0, 56653
AppSec [candidate] (56.44 ms) : 0, 56440
IAST [baseline] (20.12 ms) : 0, 20120
IAST [candidate] (19.823 ms) : 0, 19823
Remote Config [baseline] (590.871 µs) : 0, 591
Remote Config [candidate] (612.589 µs) : 0, 613
Telemetry [baseline] (7.27 ms) : 0, 7270
Telemetry [candidate] (8.188 ms) : 0, 8188
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~50a4b5ec23, baseline=1.42.0-SNAPSHOT~104a441d0a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1074297
Total [baseline] (10.439 s) : 0, 10438692
Agent [candidate] (1.082 s) : 0, 1082400
Total [candidate] (10.446 s) : 0, 10446398
section appsec
Agent [baseline] (1.215 s) : 0, 1214518
Total [baseline] (10.627 s) : 0, 10627212
Agent [candidate] (1.214 s) : 0, 1213985
Total [candidate] (10.608 s) : 0, 10608174
section iast
Agent [baseline] (1.203 s) : 0, 1203343
Total [baseline] (10.92 s) : 0, 10919917
Agent [candidate] (1.204 s) : 0, 1204354
Total [candidate] (10.81 s) : 0, 10810348
section profiling
Agent [baseline] (1.271 s) : 0, 1271184
Total [baseline] (10.714 s) : 0, 10714090
Agent [candidate] (1.282 s) : 0, 1281656
Total [candidate] (10.76 s) : 0, 10760143
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent appsec 1.215 s 140.221 ms (13.1%)
Agent iast 1.203 s 129.046 ms (12.0%)
Agent profiling 1.271 s 196.888 ms (18.3%)
Total tracing 10.439 s -
Total appsec 10.627 s 188.52 ms (1.8%)
Total iast 10.92 s 481.226 ms (4.6%)
Total profiling 10.714 s 275.398 ms (2.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent appsec 1.214 s 131.586 ms (12.2%)
Agent iast 1.204 s 121.955 ms (11.3%)
Agent profiling 1.282 s 199.256 ms (18.4%)
Total tracing 10.446 s -
Total appsec 10.608 s 161.776 ms (1.5%)
Total iast 10.81 s 363.949 ms (3.5%)
Total profiling 10.76 s 313.745 ms (3.0%) 
gantt
    title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~50a4b5ec23, baseline=1.42.0-SNAPSHOT~104a441d0a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.191 ms) : 0, 684191
BytebuddyAgent [candidate] (688.951 ms) : 0, 688951
GlobalTracer [baseline] (313.125 ms) : 0, 313125
GlobalTracer [candidate] (315.203 ms) : 0, 315203
AppSec [baseline] (53.694 ms) : 0, 53694
AppSec [candidate] (54.15 ms) : 0, 54150
Remote Config [baseline] (671.695 µs) : 0, 672
Remote Config [candidate] (667.569 µs) : 0, 668
Telemetry [baseline] (9.051 ms) : 0, 9051
Telemetry [candidate] (9.763 ms) : 0, 9763
section appsec
BytebuddyAgent [baseline] (705.721 ms) : 0, 705721
BytebuddyAgent [candidate] (704.43 ms) : 0, 704430
GlobalTracer [baseline] (311.749 ms) : 0, 311749
GlobalTracer [candidate] (312.502 ms) : 0, 312502
AppSec [baseline] (165.886 ms) : 0, 165886
AppSec [candidate] (165.155 ms) : 0, 165155
IAST [baseline] (18.381 ms) : 0, 18381
IAST [candidate] (19.935 ms) : 0, 19935
Remote Config [baseline] (639.999 µs) : 0, 640
Remote Config [candidate] (634.321 µs) : 0, 634
Telemetry [baseline] (7.679 ms) : 0, 7679
Telemetry [candidate] (7.645 ms) : 0, 7645
section iast
BytebuddyAgent [baseline] (802.956 ms) : 0, 802956
BytebuddyAgent [candidate] (803.428 ms) : 0, 803428
GlobalTracer [baseline] (301.95 ms) : 0, 301950
GlobalTracer [candidate] (303.101 ms) : 0, 303101
AppSec [baseline] (56.21 ms) : 0, 56210
AppSec [candidate] (56.696 ms) : 0, 56696
IAST [baseline] (20.617 ms) : 0, 20617
IAST [candidate] (19.647 ms) : 0, 19647
Remote Config [baseline] (597.591 µs) : 0, 598
Remote Config [candidate] (594.855 µs) : 0, 595
Telemetry [baseline] (7.361 ms) : 0, 7361
Telemetry [candidate] (7.236 ms) : 0, 7236
section profiling
BytebuddyAgent [baseline] (678.704 ms) : 0, 678704
BytebuddyAgent [candidate] (684.186 ms) : 0, 684186
GlobalTracer [baseline] (396.063 ms) : 0, 396063
GlobalTracer [candidate] (399.438 ms) : 0, 399438
AppSec [baseline] (54.266 ms) : 0, 54266
AppSec [candidate] (54.297 ms) : 0, 54297
Remote Config [baseline] (658.387 µs) : 0, 658
Remote Config [candidate] (662.958 µs) : 0, 663
Telemetry [baseline] (14.694 ms) : 0, 14694
Telemetry [candidate] (13.901 ms) : 0, 13901
ProfilingAgent [baseline] (88.203 ms) : 0, 88203
ProfilingAgent [candidate] (90.185 ms) : 0, 90185
Profiling [baseline] (88.226 ms) : 0, 88226
Profiling [candidate] (90.209 ms) : 0, 90209
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-30T19:28:58 2024-10-30T19:35:52
git_branch master nenadnoveljic/sqlserver-prepared-statements
git_commit_date 1730315410 1730316066
git_commit_sha 104a441 50a4b5e
release_version 1.42.0-SNAPSHOT~104a441d0a 1.42.0-SNAPSHOT~50a4b5ec23
start_time 2024-10-30T19:28:45 2024-10-30T19:35:39
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730317302 1730317302
ci_job_id 690635230 690635230
ci_pipeline_id 47892644 47892644
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~50a4b5ec23, baseline=1.42.0-SNAPSHOT~104a441d0a
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.464 µs) : 353, 392
.   : milestone, 372,
iast (488.937 µs) : 467, 511
.   : milestone, 489,
iast_FULL (641.053 µs) : 620, 662
.   : milestone, 641,
iast_GLOBAL (512.146 µs) : 491, 533
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (483.169 µs) : 462, 504
.   : milestone, 483,
iast_INACTIVE (442.829 µs) : 422, 463
.   : milestone, 443,
iast_TELEMETRY_OFF (477.681 µs) : 456, 499
.   : milestone, 478,
tracing (446.084 µs) : 425, 467
.   : milestone, 446,
section candidate
no_agent (364.591 µs) : 345, 385
.   : milestone, 365,
iast (484.523 µs) : 463, 506
.   : milestone, 485,
iast_FULL (643.723 µs) : 622, 665
.   : milestone, 644,
iast_GLOBAL (515.294 µs) : 494, 537
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (479.42 µs) : 458, 501
.   : milestone, 479,
iast_INACTIVE (451.492 µs) : 431, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (476.859 µs) : 456, 498
.   : milestone, 477,
tracing (438.416 µs) : 418, 459
.   : milestone, 438,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.464 µs [352.889 µs, 392.039 µs] -
iast 488.937 µs [467.077 µs, 510.796 µs] 116.472 µs (31.3%)
iast_FULL 641.053 µs [619.678 µs, 662.428 µs] 268.589 µs (72.1%)
iast_GLOBAL 512.146 µs [491.144 µs, 533.149 µs] 139.682 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED 483.169 µs [462.132 µs, 504.206 µs] 110.705 µs (29.7%)
iast_INACTIVE 442.829 µs [422.366 µs, 463.291 µs] 70.365 µs (18.9%)
iast_TELEMETRY_OFF 477.681 µs [456.335 µs, 499.027 µs] 105.217 µs (28.2%)
tracing 446.084 µs [424.699 µs, 467.469 µs] 73.62 µs (19.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.591 µs [344.5 µs, 384.681 µs] -
iast 484.523 µs [463.353 µs, 505.692 µs] 119.932 µs (32.9%)
iast_FULL 643.723 µs [622.341 µs, 665.104 µs] 279.132 µs (76.6%)
iast_GLOBAL 515.294 µs [493.606 µs, 536.982 µs] 150.704 µs (41.3%)
iast_HARDCODED_SECRET_DISABLED 479.42 µs [458.258 µs, 500.582 µs] 114.829 µs (31.5%)
iast_INACTIVE 451.492 µs [430.571 µs, 472.413 µs] 86.901 µs (23.8%)
iast_TELEMETRY_OFF 476.859 µs [455.999 µs, 497.719 µs] 112.269 µs (30.8%)
tracing 438.416 µs [418.083 µs, 458.748 µs] 73.825 µs (20.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~50a4b5ec23, baseline=1.42.0-SNAPSHOT~104a441d0a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.311 ms) : 1291, 1330
.   : milestone, 1311,
appsec (1.723 ms) : 1700, 1747
.   : milestone, 1723,
appsec_no_iast (1.742 ms) : 1718, 1765
.   : milestone, 1742,
iast (1.478 ms) : 1455, 1500
.   : milestone, 1478,
profiling (1.48 ms) : 1456, 1503
.   : milestone, 1480,
tracing (1.464 ms) : 1438, 1490
.   : milestone, 1464,
section candidate
no_agent (1.345 ms) : 1326, 1364
.   : milestone, 1345,
appsec (1.723 ms) : 1698, 1748
.   : milestone, 1723,
appsec_no_iast (1.727 ms) : 1703, 1751
.   : milestone, 1727,
iast (1.482 ms) : 1459, 1505
.   : milestone, 1482,
profiling (1.481 ms) : 1458, 1503
.   : milestone, 1481,
tracing (1.487 ms) : 1462, 1511
.   : milestone, 1487,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.311 ms [1.291 ms, 1.33 ms] -
appsec 1.723 ms [1.7 ms, 1.747 ms] 412.682 µs (31.5%)
appsec_no_iast 1.742 ms [1.718 ms, 1.765 ms] 430.985 µs (32.9%)
iast 1.478 ms [1.455 ms, 1.5 ms] 167.02 µs (12.7%)
profiling 1.48 ms [1.456 ms, 1.503 ms] 168.974 µs (12.9%)
tracing 1.464 ms [1.438 ms, 1.49 ms] 153.359 µs (11.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.326 ms, 1.364 ms] -
appsec 1.723 ms [1.698 ms, 1.748 ms] 378.036 µs (28.1%)
appsec_no_iast 1.727 ms [1.703 ms, 1.751 ms] 382.499 µs (28.4%)
iast 1.482 ms [1.459 ms, 1.505 ms] 137.259 µs (10.2%)
profiling 1.481 ms [1.458 ms, 1.503 ms] 135.897 µs (10.1%)
tracing 1.487 ms [1.462 ms, 1.511 ms] 141.904 µs (10.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nenadnoveljic/sqlserver-prepared-statements
git_commit_date 1730315410 1730316066
git_commit_sha 104a441 50a4b5e
release_version 1.42.0-SNAPSHOT~104a441d0a 1.42.0-SNAPSHOT~50a4b5ec23
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1730317974 1730317974
ci_job_id 690635231 690635231
ci_pipeline_id 47892644 47892644
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~50a4b5ec23, baseline=1.42.0-SNAPSHOT~104a441d0a
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.284 s) : 15284000, 15284000
.   : milestone, 15284000,
appsec (15.227 s) : 15227000, 15227000
.   : milestone, 15227000,
iast (18.83 s) : 18830000, 18830000
.   : milestone, 18830000,
iast_GLOBAL (18.125 s) : 18125000, 18125000
.   : milestone, 18125000,
profiling (15.68 s) : 15680000, 15680000
.   : milestone, 15680000,
tracing (15.512 s) : 15512000, 15512000
.   : milestone, 15512000,
section candidate
no_agent (15.16 s) : 15160000, 15160000
.   : milestone, 15160000,
appsec (15.058 s) : 15058000, 15058000
.   : milestone, 15058000,
iast (19.122 s) : 19122000, 19122000
.   : milestone, 19122000,
iast_GLOBAL (18.063 s) : 18063000, 18063000
.   : milestone, 18063000,
profiling (15.537 s) : 15537000, 15537000
.   : milestone, 15537000,
tracing (15.062 s) : 15062000, 15062000
.   : milestone, 15062000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.284 s [15.284 s, 15.284 s] -
appsec 15.227 s [15.227 s, 15.227 s] -57.0 ms (-0.4%)
iast 18.83 s [18.83 s, 18.83 s] 3.546 s (23.2%)
iast_GLOBAL 18.125 s [18.125 s, 18.125 s] 2.841 s (18.6%)
profiling 15.68 s [15.68 s, 15.68 s] 396.0 ms (2.6%)
tracing 15.512 s [15.512 s, 15.512 s] 228.0 ms (1.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.16 s [15.16 s, 15.16 s] -
appsec 15.058 s [15.058 s, 15.058 s] -102.0 ms (-0.7%)
iast 19.122 s [19.122 s, 19.122 s] 3.962 s (26.1%)
iast_GLOBAL 18.063 s [18.063 s, 18.063 s] 2.903 s (19.1%)
profiling 15.537 s [15.537 s, 15.537 s] 377.0 ms (2.5%)
tracing 15.062 s [15.062 s, 15.062 s] -98.0 ms (-0.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~50a4b5ec23, baseline=1.42.0-SNAPSHOT~104a441d0a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.466 ms) : 1455, 1478
.   : milestone, 1466,
appsec (2.325 ms) : 2284, 2366
.   : milestone, 2325,
iast (2.064 ms) : 2012, 2115
.   : milestone, 2064,
iast_GLOBAL (2.112 ms) : 2060, 2165
.   : milestone, 2112,
profiling (1.951 ms) : 1908, 1995
.   : milestone, 1951,
tracing (1.921 ms) : 1881, 1961
.   : milestone, 1921,
section candidate
no_agent (1.46 ms) : 1449, 1472
.   : milestone, 1460,
appsec (2.327 ms) : 2286, 2368
.   : milestone, 2327,
iast (2.063 ms) : 2011, 2115
.   : milestone, 2063,
iast_GLOBAL (2.104 ms) : 2053, 2156
.   : milestone, 2104,
profiling (1.933 ms) : 1891, 1974
.   : milestone, 1933,
tracing (1.908 ms) : 1869, 1948
.   : milestone, 1908,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.478 ms] -
appsec 2.325 ms [2.284 ms, 2.366 ms] 858.514 µs (58.6%)
iast 2.064 ms [2.012 ms, 2.115 ms] 597.514 µs (40.8%)
iast_GLOBAL 2.112 ms [2.06 ms, 2.165 ms] 645.999 µs (44.1%)
profiling 1.951 ms [1.908 ms, 1.995 ms] 484.815 µs (33.1%)
tracing 1.921 ms [1.881 ms, 1.961 ms] 454.694 µs (31.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.472 ms] -
appsec 2.327 ms [2.286 ms, 2.368 ms] 867.079 µs (59.4%)
iast 2.063 ms [2.011 ms, 2.115 ms] 603.096 µs (41.3%)
iast_GLOBAL 2.104 ms [2.053 ms, 2.156 ms] 644.217 µs (44.1%)
profiling 1.933 ms [1.891 ms, 1.974 ms] 472.372 µs (32.4%)
tracing 1.908 ms [1.869 ms, 1.948 ms] 448.258 µs (30.7%)

@nenadnoveljic nenadnoveljic marked this pull request as ready for review October 30, 2024 19:20
@nenadnoveljic nenadnoveljic requested a review from a team as a code owner October 30, 2024 19:20
@nenadnoveljic nenadnoveljic force-pushed the nenadnoveljic/sqlserver-prepared-statements branch from d4da01b to 50a4b5e Compare October 30, 2024 19:21
@smola smola added the comp: database Database Monitoring label Oct 31, 2024
@nenadnoveljic nenadnoveljic merged commit 802208e into master Oct 31, 2024
101 checks passed
@nenadnoveljic nenadnoveljic deleted the nenadnoveljic/sqlserver-prepared-statements branch October 31, 2024 15:57
@github-actions github-actions bot added this to the 1.42.0 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vandonr vandonr vandonr approved these changes

@dougqh dougqh dougqh approved these changes

Assignees
No one assigned
Labels
comp: database Database Monitoring
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nenadnoveljic @dougqh @vandonr @smola