-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix skippable tests request in headless mode #7860
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/skippable-tests-module-fix
Oct 30, 2024
Merged
Fix skippable tests request in headless mode #7860
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/skippable-tests-module-fix
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
type: bug
comp: ci visibility
Continuous Integration Visibility
labels
Oct 30, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~6320dbd3f2, baseline=1.42.0-SNAPSHOT~944d4e6d67
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.591 s) : 0, 1591265
Total [baseline] (11.916 s) : 0, 11916485
Agent [candidate] (1.594 s) : 0, 1594092
Total [candidate] (11.894 s) : 0, 11894438
section iast
Agent [baseline] (1.754 s) : 0, 1753758
Total [baseline] (12.795 s) : 0, 12794521
Agent [candidate] (1.762 s) : 0, 1761999
Total [candidate] (12.817 s) : 0, 12817267
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.754 s) : 0, 1754282
Total [baseline] (12.728 s) : 0, 12727936
Agent [candidate] (1.761 s) : 0, 1761193
Total [candidate] (12.755 s) : 0, 12754573
section iast_TELEMETRY_OFF
Agent [baseline] (1.75 s) : 0, 1750265
Total [baseline] (12.783 s) : 0, 12782591
Agent [candidate] (1.75 s) : 0, 1750157
Total [candidate] (12.812 s) : 0, 12811965
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~6320dbd3f2, baseline=1.42.0-SNAPSHOT~944d4e6d67
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (1.017 s) : 0, 1016997
BytebuddyAgent [candidate] (1.018 s) : 0, 1017928
GlobalTracer [baseline] (466.195 ms) : 0, 466195
GlobalTracer [candidate] (467.086 ms) : 0, 467086
AppSec [baseline] (75.63 ms) : 0, 75630
AppSec [candidate] (75.715 ms) : 0, 75715
Remote Config [baseline] (823.692 µs) : 0, 824
Remote Config [candidate] (839.636 µs) : 0, 840
Telemetry [baseline] (11.299 ms) : 0, 11299
Telemetry [candidate] (12.129 ms) : 0, 12129
section iast
BytebuddyAgent [baseline] (1.176 s) : 0, 1175983
BytebuddyAgent [candidate] (1.182 s) : 0, 1182347
GlobalTracer [baseline] (442.623 ms) : 0, 442623
GlobalTracer [candidate] (444.374 ms) : 0, 444374
AppSec [baseline] (77.765 ms) : 0, 77765
AppSec [candidate] (76.676 ms) : 0, 76676
Remote Config [baseline] (747.963 µs) : 0, 748
Remote Config [candidate] (810.376 µs) : 0, 810
Telemetry [baseline] (9.522 ms) : 0, 9522
Telemetry [candidate] (9.67 ms) : 0, 9670
IAST [baseline] (26.881 ms) : 0, 26881
IAST [candidate] (27.698 ms) : 0, 27698
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.177 s) : 0, 1176677
BytebuddyAgent [candidate] (1.181 s) : 0, 1180782
GlobalTracer [baseline] (443.884 ms) : 0, 443884
GlobalTracer [candidate] (444.798 ms) : 0, 444798
AppSec [baseline] (77.077 ms) : 0, 77077
AppSec [candidate] (76.195 ms) : 0, 76195
Remote Config [baseline] (738.573 µs) : 0, 739
Remote Config [candidate] (779.32 µs) : 0, 779
Telemetry [baseline] (9.346 ms) : 0, 9346
Telemetry [candidate] (9.601 ms) : 0, 9601
IAST [baseline] (26.334 ms) : 0, 26334
IAST [candidate] (28.645 ms) : 0, 28645
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.173 s) : 0, 1172613
BytebuddyAgent [candidate] (1.172 s) : 0, 1172270
GlobalTracer [baseline] (442.895 ms) : 0, 442895
GlobalTracer [candidate] (443.062 ms) : 0, 443062
AppSec [baseline] (78.715 ms) : 0, 78715
AppSec [candidate] (77.682 ms) : 0, 77682
Remote Config [baseline] (749.035 µs) : 0, 749
Remote Config [candidate] (762.344 µs) : 0, 762
Telemetry [baseline] (9.458 ms) : 0, 9458
Telemetry [candidate] (10.321 ms) : 0, 10321
IAST [baseline] (25.563 ms) : 0, 25563
IAST [candidate] (25.741 ms) : 0, 25741
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~6320dbd3f2, baseline=1.42.0-SNAPSHOT~944d4e6d67
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.592 s) : 0, 1591551
Total [baseline] (14.405 s) : 0, 14404659
Agent [candidate] (1.584 s) : 0, 1583954
Total [candidate] (14.356 s) : 0, 14356341
section appsec
Agent [baseline] (1.79 s) : 0, 1790010
Total [baseline] (14.572 s) : 0, 14572212
Agent [candidate] (1.79 s) : 0, 1790423
Total [candidate] (14.55 s) : 0, 14549609
section iast
Agent [baseline] (1.763 s) : 0, 1762918
Total [baseline] (15.011 s) : 0, 15011255
Agent [candidate] (1.755 s) : 0, 1755480
Total [candidate] (15.066 s) : 0, 15065582
section profiling
Agent [baseline] (1.913 s) : 0, 1912741
Total [baseline] (14.695 s) : 0, 14695473
Agent [candidate] (1.911 s) : 0, 1910529
Total [candidate] (14.745 s) : 0, 14744756
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~6320dbd3f2, baseline=1.42.0-SNAPSHOT~944d4e6d67
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (1.017 s) : 0, 1016743
BytebuddyAgent [candidate] (1.013 s) : 0, 1013097
GlobalTracer [baseline] (466.371 ms) : 0, 466371
GlobalTracer [candidate] (464.661 ms) : 0, 464661
AppSec [baseline] (75.754 ms) : 0, 75754
AppSec [candidate] (75.3 ms) : 0, 75300
Remote Config [baseline] (835.43 µs) : 0, 835
Remote Config [candidate] (816.127 µs) : 0, 816
Telemetry [baseline] (11.521 ms) : 0, 11521
Telemetry [candidate] (9.737 ms) : 0, 9737
section appsec
BytebuddyAgent [baseline] (1.04 s) : 0, 1040327
BytebuddyAgent [candidate] (1.041 s) : 0, 1041410
GlobalTracer [baseline] (460.866 ms) : 0, 460866
GlobalTracer [candidate] (461.425 ms) : 0, 461425
AppSec [baseline] (245.833 ms) : 0, 245833
AppSec [candidate] (243.208 ms) : 0, 243208
Remote Config [baseline] (792.671 µs) : 0, 793
Remote Config [candidate] (802.786 µs) : 0, 803
Telemetry [baseline] (9.885 ms) : 0, 9885
Telemetry [candidate] (10.365 ms) : 0, 10365
IAST [baseline] (24.106 ms) : 0, 24106
IAST [candidate] (25.75 ms) : 0, 25750
section iast
BytebuddyAgent [baseline] (1.182 s) : 0, 1182282
BytebuddyAgent [candidate] (1.177 s) : 0, 1176904
GlobalTracer [baseline] (445.227 ms) : 0, 445227
GlobalTracer [candidate] (442.856 ms) : 0, 442856
AppSec [baseline] (76.609 ms) : 0, 76609
AppSec [candidate] (75.906 ms) : 0, 75906
Remote Config [baseline] (776.208 µs) : 0, 776
Remote Config [candidate] (782.104 µs) : 0, 782
Telemetry [baseline] (10.513 ms) : 0, 10513
Telemetry [candidate] (9.637 ms) : 0, 9637
IAST [baseline] (27.182 ms) : 0, 27182
IAST [candidate] (29.022 ms) : 0, 29022
section profiling
BytebuddyAgent [baseline] (1.006 s) : 0, 1005612
BytebuddyAgent [candidate] (1.007 s) : 0, 1007230
GlobalTracer [baseline] (594.179 ms) : 0, 594179
GlobalTracer [candidate] (594.048 ms) : 0, 594048
AppSec [baseline] (76.36 ms) : 0, 76360
AppSec [candidate] (76.321 ms) : 0, 76321
Remote Config [baseline] (825.292 µs) : 0, 825
Remote Config [candidate] (836.887 µs) : 0, 837
Telemetry [baseline] (12.314 ms) : 0, 12314
Telemetry [candidate] (11.724 ms) : 0, 11724
ProfilingAgent [baseline] (165.636 ms) : 0, 165636
ProfilingAgent [candidate] (162.546 ms) : 0, 162546
Profiling [baseline] (165.691 ms) : 0, 165691
Profiling [candidate] (162.601 ms) : 0, 162601
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~6320dbd3f2, baseline=1.42.0-SNAPSHOT~944d4e6d67
dateFormat X
axisFormat %s
section baseline
no_agent (1.33 ms) : 1310, 1350
. : milestone, 1330,
appsec (1.716 ms) : 1692, 1741
. : milestone, 1716,
appsec_no_iast (1.723 ms) : 1699, 1748
. : milestone, 1723,
iast (1.477 ms) : 1454, 1500
. : milestone, 1477,
profiling (1.483 ms) : 1460, 1505
. : milestone, 1483,
tracing (1.468 ms) : 1444, 1491
. : milestone, 1468,
section candidate
no_agent (1.348 ms) : 1329, 1368
. : milestone, 1348,
appsec (1.73 ms) : 1704, 1755
. : milestone, 1730,
appsec_no_iast (1.737 ms) : 1714, 1761
. : milestone, 1737,
iast (1.466 ms) : 1443, 1489
. : milestone, 1466,
profiling (1.494 ms) : 1469, 1518
. : milestone, 1494,
tracing (1.456 ms) : 1433, 1480
. : milestone, 1456,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~6320dbd3f2, baseline=1.42.0-SNAPSHOT~944d4e6d67
dateFormat X
axisFormat %s
section baseline
no_agent (373.998 µs) : 348, 400
. : milestone, 374,
iast (488.291 µs) : 467, 510
. : milestone, 488,
iast_FULL (637.529 µs) : 616, 659
. : milestone, 638,
iast_GLOBAL (507.095 µs) : 486, 529
. : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (477.262 µs) : 456, 498
. : milestone, 477,
iast_INACTIVE (445.112 µs) : 424, 466
. : milestone, 445,
iast_TELEMETRY_OFF (474.556 µs) : 453, 496
. : milestone, 475,
tracing (442.94 µs) : 422, 464
. : milestone, 443,
section candidate
no_agent (370.152 µs) : 349, 391
. : milestone, 370,
iast (479.567 µs) : 458, 501
. : milestone, 480,
iast_FULL (637.354 µs) : 616, 659
. : milestone, 637,
iast_GLOBAL (513.759 µs) : 491, 536
. : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (478.67 µs) : 458, 500
. : milestone, 479,
iast_INACTIVE (438.25 µs) : 418, 459
. : milestone, 438,
iast_TELEMETRY_OFF (470.82 µs) : 449, 492
. : milestone, 471,
tracing (441.365 µs) : 421, 462
. : milestone, 441,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~6320dbd3f2, baseline=1.42.0-SNAPSHOT~944d4e6d67
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (2.344 ms) : 2302, 2385
. : milestone, 2344,
iast (2.09 ms) : 2037, 2143
. : milestone, 2090,
iast_GLOBAL (2.129 ms) : 2076, 2181
. : milestone, 2129,
profiling (1.963 ms) : 1921, 2006
. : milestone, 1963,
tracing (1.923 ms) : 1883, 1963
. : milestone, 1923,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.366 ms) : 2325, 2408
. : milestone, 2366,
iast (2.093 ms) : 2041, 2146
. : milestone, 2093,
iast_GLOBAL (2.127 ms) : 2075, 2179
. : milestone, 2127,
profiling (1.941 ms) : 1899, 1983
. : milestone, 1941,
tracing (1.941 ms) : 1901, 1981
. : milestone, 1941,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~6320dbd3f2, baseline=1.42.0-SNAPSHOT~944d4e6d67
dateFormat X
axisFormat %s
section baseline
no_agent (15.436 s) : 15436000, 15436000
. : milestone, 15436000,
appsec (15.217 s) : 15217000, 15217000
. : milestone, 15217000,
iast (18.922 s) : 18922000, 18922000
. : milestone, 18922000,
iast_GLOBAL (18.283 s) : 18283000, 18283000
. : milestone, 18283000,
profiling (15.488 s) : 15488000, 15488000
. : milestone, 15488000,
tracing (14.988 s) : 14988000, 14988000
. : milestone, 14988000,
section candidate
no_agent (15.401 s) : 15401000, 15401000
. : milestone, 15401000,
appsec (15.124 s) : 15124000, 15124000
. : milestone, 15124000,
iast (18.595 s) : 18595000, 18595000
. : milestone, 18595000,
iast_GLOBAL (18.395 s) : 18395000, 18395000
. : milestone, 18395000,
profiling (15.12 s) : 15120000, 15120000
. : milestone, 15120000,
tracing (15.411 s) : 15411000, 15411000
. : milestone, 15411000,
|
juan-fernandez
approved these changes
Oct 30, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/skippable-tests-module-fix
branch
October 30, 2024 13:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fixes parsing ITR skippable tests response when requesting tests for a specific module.
Additional Notes
In "normal" operation mode (when the build system is instrumented) skippable tests for all modules are requested (module name is omitted in the request).
In "headless" operation mode (build system is not instrumented) skippable tests are requested for a specific module, the one which is instrumented.
When tests for a specific module are requested, the backend does not include
configurations
object in the response JSON.The code processing the response has to account for this.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-1164