Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Where conversion for CodeOrigin probes #7858

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Fix Where conversion for CodeOrigin probes #7858

merged 2 commits into from
Oct 30, 2024

Conversation

jpbempel
Copy link
Member

What Does This Do

Conversion must create a Where instance with no SourceLine (null)

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@jpbempel
Fix Where conversion for CodeOrigin probes
3f9f6a7 
Conversion must create a Where instance with no SourceLine (null)
@jpbempel jpbempel requested a review from a team as a code owner October 30, 2024 09:05
@jpbempel jpbempel requested review from ojung and evanchooly and removed request for a team October 30, 2024 09:05
@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Oct 30, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 30, 2024 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1730281867 1730282243
end_time 2024-10-30T09:52:22 2024-10-30T09:58:37
git_branch master jpbempel/fix-codeorigin-probe
git_commit_sha 944d4e6 99f3ec9
start_time 2024-10-30T09:51:08 2024-10-30T09:57:24
See matching parameters
Baseline Candidate
ci_job_id 689420533 689420533
ci_pipeline_id 47808730 47808730
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1730281315 1730281315

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-43.378µs; +16.875µs] or [-15.958%; +6.208%]		 unstable
[-60.085µs; +27.376µs] or [-19.320%; +8.803%]		 unstable
[-74.983µs; +34.661µs] or [-22.961%; +10.614%]		 unstable
[-126.003µs; +90.922µs] or [-20.308%; +14.654%]		 same
scenario:basic same same same unstable
[-66.305µs; +35.524µs] or [-12.080%; +6.472%]		 unstable
[-91.574op/s; +226.527op/s] or [-3.571%; +8.835%]
scenario:loop unsure
[+32.000µs; +53.282µs] or [+0.315%; +0.525%]		 unsure
[+11.091µs; +81.381µs] or [+0.108%; +0.789%]		 same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (310.993 µs) : 257, 365
.   : milestone, 311,
basic (300.747 µs) : 289, 313
.   : milestone, 301,
loop (10.314 ms) : 10281, 10348
.   : milestone, 10314,
section candidate
noprobe (294.638 µs) : 270, 319
.   : milestone, 295,
basic (297.237 µs) : 289, 306
.   : milestone, 297,
loop (10.361 ms) : 10329, 10393
.   : milestone, 10361,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 310.993 µs [257.234 µs, 364.752 µs]
basic 300.747 µs [288.623 µs, 312.872 µs]
loop 10.314 ms [10.281 ms, 10.348 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 294.638 µs [270.342 µs, 318.935 µs]
basic 297.237 µs [288.501 µs, 305.972 µs]
loop 10.361 ms [10.329 ms, 10.393 ms]

@pr-commenter
Copy link

pr-commenter bot commented Oct 30, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-codeorigin-probe
git_commit_date 1730279388 1730281315
git_commit_sha 944d4e6 99f3ec9
release_version 1.42.0-SNAPSHOT~944d4e6d67 1.42.0-SNAPSHOT~99f3ec9935
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730284308 1730284308
ci_job_id 689420527 689420527
ci_pipeline_id 47808730 47808730
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~99f3ec9935, baseline=1.42.0-SNAPSHOT~944d4e6d67

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.583 s) : 0, 1583214
Total [baseline] (11.953 s) : 0, 11952595
Agent [candidate] (1.584 s) : 0, 1584404
Total [candidate] (11.933 s) : 0, 11932966
section iast
Agent [baseline] (1.754 s) : 0, 1754409
Total [baseline] (12.768 s) : 0, 12767789
Agent [candidate] (1.754 s) : 0, 1753819
Total [candidate] (12.796 s) : 0, 12795861
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.758 s) : 0, 1757811
Total [baseline] (12.738 s) : 0, 12737543
Agent [candidate] (1.76 s) : 0, 1760348
Total [candidate] (12.77 s) : 0, 12770085
section iast_TELEMETRY_OFF
Agent [baseline] (1.748 s) : 0, 1747888
Total [baseline] (12.846 s) : 0, 12846459
Agent [candidate] (1.746 s) : 0, 1746149
Total [candidate] (12.803 s) : 0, 12803359
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.583 s -
Agent iast 1.754 s 171.196 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.758 s 174.597 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.748 s 164.674 ms (10.4%)
Total tracing 11.953 s -
Total iast 12.768 s 815.194 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 12.738 s 784.948 ms (6.6%)
Total iast_TELEMETRY_OFF 12.846 s 893.864 ms (7.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.584 s -
Agent iast 1.754 s 169.415 ms (10.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.76 s 175.945 ms (11.1%)
Agent iast_TELEMETRY_OFF 1.746 s 161.745 ms (10.2%)
Total tracing 11.933 s -
Total iast 12.796 s 862.895 ms (7.2%)
Total iast_HARDCODED_SECRET_DISABLED 12.77 s 837.119 ms (7.0%)
Total iast_TELEMETRY_OFF 12.803 s 870.394 ms (7.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~99f3ec9935, baseline=1.42.0-SNAPSHOT~944d4e6d67

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (1.013 s) : 0, 1012817
BytebuddyAgent [candidate] (1.013 s) : 0, 1012885
GlobalTracer [baseline] (463.394 ms) : 0, 463394
GlobalTracer [candidate] (462.826 ms) : 0, 462826
AppSec [baseline] (75.366 ms) : 0, 75366
AppSec [candidate] (75.472 ms) : 0, 75472
Remote Config [baseline] (815.149 µs) : 0, 815
Remote Config [candidate] (821.341 µs) : 0, 821
Telemetry [baseline] (10.593 ms) : 0, 10593
Telemetry [candidate] (12.11 ms) : 0, 12110
section iast
BytebuddyAgent [baseline] (1.177 s) : 0, 1176720
BytebuddyAgent [candidate] (1.177 s) : 0, 1176593
GlobalTracer [baseline] (442.853 ms) : 0, 442853
GlobalTracer [candidate] (442.622 ms) : 0, 442622
AppSec [baseline] (77.113 ms) : 0, 77113
AppSec [candidate] (77.996 ms) : 0, 77996
Remote Config [baseline] (766.837 µs) : 0, 767
Remote Config [candidate] (759.539 µs) : 0, 760
Telemetry [baseline] (9.589 ms) : 0, 9589
Telemetry [candidate] (9.541 ms) : 0, 9541
IAST [baseline] (27.114 ms) : 0, 27114
IAST [candidate] (25.98 ms) : 0, 25980
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.178 s) : 0, 1178473
BytebuddyAgent [candidate] (1.181 s) : 0, 1180544
GlobalTracer [baseline] (444.207 ms) : 0, 444207
GlobalTracer [candidate] (444.366 ms) : 0, 444366
AppSec [baseline] (76.742 ms) : 0, 76742
AppSec [candidate] (76.741 ms) : 0, 76741
Remote Config [baseline] (756.07 µs) : 0, 756
Remote Config [candidate] (791.606 µs) : 0, 792
Telemetry [baseline] (9.579 ms) : 0, 9579
Telemetry [candidate] (9.649 ms) : 0, 9649
IAST [baseline] (27.8 ms) : 0, 27800
IAST [candidate] (27.884 ms) : 0, 27884
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.171 s) : 0, 1170730
BytebuddyAgent [candidate] (1.17 s) : 0, 1170046
GlobalTracer [baseline] (442.212 ms) : 0, 442212
GlobalTracer [candidate] (441.933 ms) : 0, 441933
AppSec [baseline] (77.793 ms) : 0, 77793
AppSec [candidate] (77.839 ms) : 0, 77839
Remote Config [baseline] (826.396 µs) : 0, 826
Remote Config [candidate] (752.841 µs) : 0, 753
Telemetry [baseline] (9.364 ms) : 0, 9364
Telemetry [candidate] (9.45 ms) : 0, 9450
IAST [baseline] (26.75 ms) : 0, 26750
IAST [candidate] (25.86 ms) : 0, 25860
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~99f3ec9935, baseline=1.42.0-SNAPSHOT~944d4e6d67

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.59 s) : 0, 1590215
Total [baseline] (14.486 s) : 0, 14486225
Agent [candidate] (1.585 s) : 0, 1585302
Total [candidate] (14.503 s) : 0, 14502641
section appsec
Agent [baseline] (1.793 s) : 0, 1792680
Total [baseline] (14.715 s) : 0, 14715303
Agent [candidate] (1.787 s) : 0, 1786525
Total [candidate] (14.759 s) : 0, 14758880
section iast
Agent [baseline] (1.757 s) : 0, 1756812
Total [baseline] (15.047 s) : 0, 15047236
Agent [candidate] (1.762 s) : 0, 1761926
Total [candidate] (15.01 s) : 0, 15009659
section profiling
Agent [baseline] (1.91 s) : 0, 1910155
Total [baseline] (14.793 s) : 0, 14792568
Agent [candidate] (1.92 s) : 0, 1919621
Total [candidate] (14.732 s) : 0, 14732115
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.59 s -
Agent appsec 1.793 s 202.466 ms (12.7%)
Agent iast 1.757 s 166.598 ms (10.5%)
Agent profiling 1.91 s 319.94 ms (20.1%)
Total tracing 14.486 s -
Total appsec 14.715 s 229.078 ms (1.6%)
Total iast 15.047 s 561.011 ms (3.9%)
Total profiling 14.793 s 306.344 ms (2.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.585 s -
Agent appsec 1.787 s 201.223 ms (12.7%)
Agent iast 1.762 s 176.625 ms (11.1%)
Agent profiling 1.92 s 334.319 ms (21.1%)
Total tracing 14.503 s -
Total appsec 14.759 s 256.239 ms (1.8%)
Total iast 15.01 s 507.018 ms (3.5%)
Total profiling 14.732 s 229.474 ms (1.6%) 
gantt
    title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~99f3ec9935, baseline=1.42.0-SNAPSHOT~944d4e6d67

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (1.017 s) : 0, 1016611
BytebuddyAgent [candidate] (1.012 s) : 0, 1012378
GlobalTracer [baseline] (465.49 ms) : 0, 465490
GlobalTracer [candidate] (464.255 ms) : 0, 464255
AppSec [baseline] (75.628 ms) : 0, 75628
AppSec [candidate] (75.393 ms) : 0, 75393
Remote Config [baseline] (823.173 µs) : 0, 823
Remote Config [candidate] (820.988 µs) : 0, 821
Telemetry [baseline] (11.351 ms) : 0, 11351
Telemetry [candidate] (12.117 ms) : 0, 12117
section appsec
BytebuddyAgent [baseline] (1.041 s) : 0, 1040769
BytebuddyAgent [candidate] (1.038 s) : 0, 1037878
GlobalTracer [baseline] (462.383 ms) : 0, 462383
GlobalTracer [candidate] (460.071 ms) : 0, 460071
AppSec [baseline] (244.619 ms) : 0, 244619
AppSec [candidate] (244.91 ms) : 0, 244910
Remote Config [baseline] (808.708 µs) : 0, 809
Remote Config [candidate] (782.062 µs) : 0, 782
Telemetry [baseline] (10.761 ms) : 0, 10761
Telemetry [candidate] (10.163 ms) : 0, 10163
IAST [baseline] (26.141 ms) : 0, 26141
IAST [candidate] (24.879 ms) : 0, 24879
section iast
BytebuddyAgent [baseline] (1.177 s) : 0, 1176590
BytebuddyAgent [candidate] (1.182 s) : 0, 1181567
GlobalTracer [baseline] (445.32 ms) : 0, 445320
GlobalTracer [candidate] (444.786 ms) : 0, 444786
AppSec [baseline] (77.305 ms) : 0, 77305
AppSec [candidate] (76.888 ms) : 0, 76888
Remote Config [baseline] (772.204 µs) : 0, 772
Remote Config [candidate] (777.583 µs) : 0, 778
Telemetry [baseline] (9.504 ms) : 0, 9504
Telemetry [candidate] (9.652 ms) : 0, 9652
IAST [baseline] (27.048 ms) : 0, 27048
IAST [candidate] (27.828 ms) : 0, 27828
section profiling
BytebuddyAgent [baseline] (1.006 s) : 0, 1005671
BytebuddyAgent [candidate] (1.009 s) : 0, 1009311
GlobalTracer [baseline] (592.3 ms) : 0, 592300
GlobalTracer [candidate] (595.14 ms) : 0, 595140
AppSec [baseline] (76.042 ms) : 0, 76042
AppSec [candidate] (76.43 ms) : 0, 76430
Remote Config [baseline] (820.882 µs) : 0, 821
Remote Config [candidate] (827.329 µs) : 0, 827
Telemetry [baseline] (11.521 ms) : 0, 11521
Telemetry [candidate] (11.675 ms) : 0, 11675
ProfilingAgent [baseline] (166.074 ms) : 0, 166074
ProfilingAgent [candidate] (168.236 ms) : 0, 168236
Profiling [baseline] (166.128 ms) : 0, 166128
Profiling [candidate] (168.29 ms) : 0, 168290
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-30T09:50:38 2024-10-30T09:59:46
git_branch master jpbempel/fix-codeorigin-probe
git_commit_date 1730279388 1730281315
git_commit_sha 944d4e6 99f3ec9
release_version 1.42.0-SNAPSHOT~944d4e6d67 1.42.0-SNAPSHOT~99f3ec9935
start_time 2024-10-30T09:50:21 2024-10-30T09:59:30
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730282852 1730282852
ci_job_id 689420528 689420528
ci_pipeline_id 47808730 47808730
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 6 metrics, 21 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+80.331µs; +151.314µs] or [+4.230%; +7.968%]		 unstable
[-544.184op/s; +250.066op/s] or [-21.767%; +10.003%]		 2.015ms 2352.941op/s 1.899ms 2500.000op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~99f3ec9935, baseline=1.42.0-SNAPSHOT~944d4e6d67
    dateFormat X
    axisFormat %s
section baseline
no_agent (453.309 µs) : 424, 482
.   : milestone, 453,
iast (587.891 µs) : 556, 619
.   : milestone, 588,
iast_FULL (835.909 µs) : 803, 869
.   : milestone, 836,
iast_GLOBAL (625.812 µs) : 594, 657
.   : milestone, 626,
iast_HARDCODED_SECRET_DISABLED (592.472 µs) : 560, 625
.   : milestone, 592,
iast_INACTIVE (547.054 µs) : 517, 578
.   : milestone, 547,
iast_TELEMETRY_OFF (580.661 µs) : 548, 613
.   : milestone, 581,
tracing (529.53 µs) : 499, 560
.   : milestone, 530,
section candidate
no_agent (450.899 µs) : 422, 480
.   : milestone, 451,
iast (590.5 µs) : 558, 623
.   : milestone, 591,
iast_FULL (836.15 µs) : 803, 869
.   : milestone, 836,
iast_GLOBAL (628.364 µs) : 595, 661
.   : milestone, 628,
iast_HARDCODED_SECRET_DISABLED (592.34 µs) : 559, 625
.   : milestone, 592,
iast_INACTIVE (547.575 µs) : 516, 580
.   : milestone, 548,
iast_TELEMETRY_OFF (584.228 µs) : 551, 617
.   : milestone, 584,
tracing (539.903 µs) : 510, 570
.   : milestone, 540,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 453.309 µs [424.156 µs, 482.461 µs] -
iast 587.891 µs [556.426 µs, 619.357 µs] 134.583 µs (29.7%)
iast_FULL 835.909 µs [802.903 µs, 868.916 µs] 382.601 µs (84.4%)
iast_GLOBAL 625.812 µs [594.244 µs, 657.381 µs] 172.503 µs (38.1%)
iast_HARDCODED_SECRET_DISABLED 592.472 µs [560.224 µs, 624.72 µs] 139.163 µs (30.7%)
iast_INACTIVE 547.054 µs [516.576 µs, 577.531 µs] 93.745 µs (20.7%)
iast_TELEMETRY_OFF 580.661 µs [548.171 µs, 613.151 µs] 127.352 µs (28.1%)
tracing 529.53 µs [499.009 µs, 560.051 µs] 76.222 µs (16.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 450.899 µs [421.906 µs, 479.893 µs] -
iast 590.5 µs [557.713 µs, 623.287 µs] 139.601 µs (31.0%)
iast_FULL 836.15 µs [803.006 µs, 869.295 µs] 385.251 µs (85.4%)
iast_GLOBAL 628.364 µs [595.294 µs, 661.434 µs] 177.465 µs (39.4%)
iast_HARDCODED_SECRET_DISABLED 592.34 µs [559.41 µs, 625.27 µs] 141.441 µs (31.4%)
iast_INACTIVE 547.575 µs [515.645 µs, 579.505 µs] 96.676 µs (21.4%)
iast_TELEMETRY_OFF 584.228 µs [551.379 µs, 617.077 µs] 133.329 µs (29.6%)
tracing 539.903 µs [509.745 µs, 570.062 µs] 89.004 µs (19.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~99f3ec9935, baseline=1.42.0-SNAPSHOT~944d4e6d67
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.696 ms) : 1671, 1721
.   : milestone, 1696,
appsec (2.215 ms) : 2183, 2247
.   : milestone, 2215,
appsec_no_iast (2.188 ms) : 2156, 2220
.   : milestone, 2188,
iast (1.855 ms) : 1826, 1885
.   : milestone, 1855,
profiling (1.899 ms) : 1868, 1930
.   : milestone, 1899,
tracing (1.872 ms) : 1841, 1903
.   : milestone, 1872,
section candidate
no_agent (1.703 ms) : 1678, 1727
.   : milestone, 1703,
appsec (2.18 ms) : 2148, 2211
.   : milestone, 2180,
appsec_no_iast (2.206 ms) : 2174, 2238
.   : milestone, 2206,
iast (1.896 ms) : 1866, 1926
.   : milestone, 1896,
profiling (2.015 ms) : 1980, 2050
.   : milestone, 2015,
tracing (1.875 ms) : 1844, 1906
.   : milestone, 1875,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.696 ms [1.671 ms, 1.721 ms] -
appsec 2.215 ms [2.183 ms, 2.247 ms] 519.046 µs (30.6%)
appsec_no_iast 2.188 ms [2.156 ms, 2.22 ms] 491.689 µs (29.0%)
iast 1.855 ms [1.826 ms, 1.885 ms] 159.154 µs (9.4%)
profiling 1.899 ms [1.868 ms, 1.93 ms] 202.816 µs (12.0%)
tracing 1.872 ms [1.841 ms, 1.903 ms] 176.202 µs (10.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.703 ms [1.678 ms, 1.727 ms] -
appsec 2.18 ms [2.148 ms, 2.211 ms] 477.123 µs (28.0%)
appsec_no_iast 2.206 ms [2.174 ms, 2.238 ms] 503.015 µs (29.5%)
iast 1.896 ms [1.866 ms, 1.926 ms] 192.908 µs (11.3%)
profiling 2.015 ms [1.98 ms, 2.05 ms] 312.167 µs (18.3%)
tracing 1.875 ms [1.844 ms, 1.906 ms] 172.481 µs (10.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-codeorigin-probe
git_commit_date 1730279388 1730281315
git_commit_sha 944d4e6 99f3ec9
release_version 1.42.0-SNAPSHOT~944d4e6d67 1.42.0-SNAPSHOT~99f3ec9935
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1730283222 1730283222
ci_job_id 689420529 689420529
ci_pipeline_id 47808730 47808730
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~99f3ec9935, baseline=1.42.0-SNAPSHOT~944d4e6d67
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1474
.   : milestone, 1462,
appsec (2.327 ms) : 2286, 2368
.   : milestone, 2327,
iast (2.059 ms) : 2008, 2110
.   : milestone, 2059,
iast_GLOBAL (2.119 ms) : 2067, 2172
.   : milestone, 2119,
profiling (1.927 ms) : 1885, 1969
.   : milestone, 1927,
tracing (1.911 ms) : 1872, 1951
.   : milestone, 1911,
section candidate
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.332 ms) : 2291, 2373
.   : milestone, 2332,
iast (2.074 ms) : 2022, 2126
.   : milestone, 2074,
iast_GLOBAL (2.121 ms) : 2068, 2173
.   : milestone, 2121,
profiling (1.944 ms) : 1902, 1985
.   : milestone, 1944,
tracing (1.921 ms) : 1881, 1961
.   : milestone, 1921,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.474 ms] -
appsec 2.327 ms [2.286 ms, 2.368 ms] 864.693 µs (59.1%)
iast 2.059 ms [2.008 ms, 2.11 ms] 596.486 µs (40.8%)
iast_GLOBAL 2.119 ms [2.067 ms, 2.172 ms] 657.001 µs (44.9%)
profiling 1.927 ms [1.885 ms, 1.969 ms] 464.456 µs (31.8%)
tracing 1.911 ms [1.872 ms, 1.951 ms] 449.051 µs (30.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.45 ms, 1.473 ms] -
appsec 2.332 ms [2.291 ms, 2.373 ms] 870.408 µs (59.5%)
iast 2.074 ms [2.022 ms, 2.126 ms] 612.512 µs (41.9%)
iast_GLOBAL 2.121 ms [2.068 ms, 2.173 ms] 659.015 µs (45.1%)
profiling 1.944 ms [1.902 ms, 1.985 ms] 481.79 µs (33.0%)
tracing 1.921 ms [1.881 ms, 1.961 ms] 459.417 µs (31.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~99f3ec9935, baseline=1.42.0-SNAPSHOT~944d4e6d67
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.161 s) : 15161000, 15161000
.   : milestone, 15161000,
appsec (15.095 s) : 15095000, 15095000
.   : milestone, 15095000,
iast (18.883 s) : 18883000, 18883000
.   : milestone, 18883000,
iast_GLOBAL (17.828 s) : 17828000, 17828000
.   : milestone, 17828000,
profiling (15.106 s) : 15106000, 15106000
.   : milestone, 15106000,
tracing (15.371 s) : 15371000, 15371000
.   : milestone, 15371000,
section candidate
no_agent (15.11 s) : 15110000, 15110000
.   : milestone, 15110000,
appsec (15.233 s) : 15233000, 15233000
.   : milestone, 15233000,
iast (18.88 s) : 18880000, 18880000
.   : milestone, 18880000,
iast_GLOBAL (17.813 s) : 17813000, 17813000
.   : milestone, 17813000,
profiling (15.138 s) : 15138000, 15138000
.   : milestone, 15138000,
tracing (15.453 s) : 15453000, 15453000
.   : milestone, 15453000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.161 s [15.161 s, 15.161 s] -
appsec 15.095 s [15.095 s, 15.095 s] -66.0 ms (-0.4%)
iast 18.883 s [18.883 s, 18.883 s] 3.722 s (24.5%)
iast_GLOBAL 17.828 s [17.828 s, 17.828 s] 2.667 s (17.6%)
profiling 15.106 s [15.106 s, 15.106 s] -55.0 ms (-0.4%)
tracing 15.371 s [15.371 s, 15.371 s] 210.0 ms (1.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.11 s [15.11 s, 15.11 s] -
appsec 15.233 s [15.233 s, 15.233 s] 123.0 ms (0.8%)
iast 18.88 s [18.88 s, 18.88 s] 3.77 s (25.0%)
iast_GLOBAL 17.813 s [17.813 s, 17.813 s] 2.703 s (17.9%)
profiling 15.138 s [15.138 s, 15.138 s] 28.0 ms (0.2%)
tracing 15.453 s [15.453 s, 15.453 s] 343.0 ms (2.3%)

@jpbempel jpbempel merged commit b1a470b into master Oct 30, 2024
105 checks passed
@jpbempel jpbempel deleted the jpbempel/fix-codeorigin-probe branch October 30, 2024 13:12
@github-actions github-actions bot added this to the 1.42.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanchooly evanchooly evanchooly approved these changes

@ojung ojung Awaiting requested review from ojung ojung is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @evanchooly