Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed remote config update operation #7856

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Fixed remote config update operation #7856

merged 1 commit into from
Oct 30, 2024
+7 −6

Conversation

ValentinZakharov
Copy link
Contributor

What Does This Do

Remote config merge set metadata in all cases.

Motivation

After updating remote config, tracer doesn't report _dd.appsec.event_rules.version because of missing metadata.

Additional Notes

Issue found with test from PR-3256

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@ValentinZakharov ValentinZakharov self-assigned this Oct 29, 2024
@ValentinZakharov ValentinZakharov marked this pull request as ready for review October 29, 2024 23:20
@ValentinZakharov ValentinZakharov requested a review from a team as a code owner October 29, 2024 23:20
@pr-commenter
Copy link

pr-commenter bot commented Oct 29, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master vzakharov/merge_rc_fix
git_commit_date 1730221895 1730241711
git_commit_sha e3d43d5 e21732b
release_version 1.42.0-SNAPSHOT~e3d43d52e4 1.42.0-SNAPSHOT~e21732b34a
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730244139 1730244139
ci_job_id 689155719 689155719
ci_pipeline_id 47785868 47785868
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~e21732b34a, baseline=1.42.0-SNAPSHOT~e3d43d52e4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1084891
Total [baseline] (8.605 s) : 0, 8604587
Agent [candidate] (1.084 s) : 0, 1084028
Total [candidate] (8.587 s) : 0, 8586610
section iast
Agent [baseline] (1.224 s) : 0, 1223855
Total [baseline] (9.138 s) : 0, 9137955
Agent [candidate] (1.208 s) : 0, 1207519
Total [candidate] (9.184 s) : 0, 9184358
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.206 s) : 0, 1206393
Total [baseline] (9.114 s) : 0, 9114462
Agent [candidate] (1.206 s) : 0, 1206336
Total [candidate] (9.114 s) : 0, 9114069
section iast_TELEMETRY_OFF
Agent [baseline] (1.206 s) : 0, 1206049
Total [baseline] (9.159 s) : 0, 9158536
Agent [candidate] (1.213 s) : 0, 1213366
Total [candidate] (9.12 s) : 0, 9120269
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent iast 1.224 s 138.964 ms (12.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.206 s 121.503 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.206 s 121.158 ms (11.2%)
Total tracing 8.605 s -
Total iast 9.138 s 533.368 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.114 s 509.875 ms (5.9%)
Total iast_TELEMETRY_OFF 9.159 s 553.948 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent iast 1.208 s 123.491 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.206 s 122.309 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.213 s 129.338 ms (11.9%)
Total tracing 8.587 s -
Total iast 9.184 s 597.747 ms (7.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.114 s 527.459 ms (6.1%)
Total iast_TELEMETRY_OFF 9.12 s 533.659 ms (6.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~e21732b34a, baseline=1.42.0-SNAPSHOT~e3d43d52e4

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.827 ms) : 0, 689827
BytebuddyAgent [candidate] (688.711 ms) : 0, 688711
GlobalTracer [baseline] (316.703 ms) : 0, 316703
GlobalTracer [candidate] (316.814 ms) : 0, 316814
AppSec [baseline] (54.012 ms) : 0, 54012
AppSec [candidate] (54.187 ms) : 0, 54187
Remote Config [baseline] (665.826 µs) : 0, 666
Remote Config [candidate] (661.923 µs) : 0, 662
Telemetry [baseline] (9.886 ms) : 0, 9886
Telemetry [candidate] (9.858 ms) : 0, 9858
section iast
BytebuddyAgent [baseline] (815.485 ms) : 0, 815485
BytebuddyAgent [candidate] (803.034 ms) : 0, 803034
GlobalTracer [baseline] (308.154 ms) : 0, 308154
GlobalTracer [candidate] (305.101 ms) : 0, 305101
AppSec [baseline] (57.106 ms) : 0, 57106
AppSec [candidate] (56.855 ms) : 0, 56855
IAST [baseline] (20.211 ms) : 0, 20211
IAST [candidate] (20.731 ms) : 0, 20731
Remote Config [baseline] (611.658 µs) : 0, 612
Remote Config [candidate] (606.902 µs) : 0, 607
Telemetry [baseline] (8.307 ms) : 0, 8307
Telemetry [candidate] (7.399 ms) : 0, 7399
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (802.475 ms) : 0, 802475
BytebuddyAgent [candidate] (802.752 ms) : 0, 802752
GlobalTracer [baseline] (304.467 ms) : 0, 304467
GlobalTracer [candidate] (304.385 ms) : 0, 304385
AppSec [baseline] (56.889 ms) : 0, 56889
AppSec [candidate] (57.435 ms) : 0, 57435
IAST [baseline] (20.722 ms) : 0, 20722
IAST [candidate] (19.93 ms) : 0, 19930
Remote Config [baseline] (611.453 µs) : 0, 611
Remote Config [candidate] (611.965 µs) : 0, 612
Telemetry [baseline] (7.421 ms) : 0, 7421
Telemetry [candidate] (7.421 ms) : 0, 7421
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (801.395 ms) : 0, 801395
BytebuddyAgent [candidate] (807.101 ms) : 0, 807101
GlobalTracer [baseline] (304.942 ms) : 0, 304942
GlobalTracer [candidate] (306.588 ms) : 0, 306588
AppSec [baseline] (57.155 ms) : 0, 57155
AppSec [candidate] (57.186 ms) : 0, 57186
IAST [baseline] (20.717 ms) : 0, 20717
IAST [candidate] (20.641 ms) : 0, 20641
Remote Config [baseline] (615.199 µs) : 0, 615
Remote Config [candidate] (604.513 µs) : 0, 605
Telemetry [baseline] (7.415 ms) : 0, 7415
Telemetry [candidate] (7.353 ms) : 0, 7353
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~e21732b34a, baseline=1.42.0-SNAPSHOT~e3d43d52e4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083866
Total [baseline] (10.41 s) : 0, 10409511
Agent [candidate] (1.084 s) : 0, 1084457
Total [candidate] (10.526 s) : 0, 10525679
section appsec
Agent [baseline] (1.215 s) : 0, 1215333
Total [baseline] (10.67 s) : 0, 10669520
Agent [candidate] (1.214 s) : 0, 1213524
Total [candidate] (10.687 s) : 0, 10686919
section iast
Agent [baseline] (1.208 s) : 0, 1208065
Total [baseline] (10.925 s) : 0, 10925182
Agent [candidate] (1.208 s) : 0, 1208422
Total [candidate] (11.041 s) : 0, 11040758
section profiling
Agent [baseline] (1.282 s) : 0, 1281911
Total [baseline] (10.866 s) : 0, 10866095
Agent [candidate] (1.28 s) : 0, 1280201
Total [candidate] (10.74 s) : 0, 10739769
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent appsec 1.215 s 131.467 ms (12.1%)
Agent iast 1.208 s 124.198 ms (11.5%)
Agent profiling 1.282 s 198.044 ms (18.3%)
Total tracing 10.41 s -
Total appsec 10.67 s 260.009 ms (2.5%)
Total iast 10.925 s 515.671 ms (5.0%)
Total profiling 10.866 s 456.584 ms (4.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent appsec 1.214 s 129.068 ms (11.9%)
Agent iast 1.208 s 123.965 ms (11.4%)
Agent profiling 1.28 s 195.744 ms (18.0%)
Total tracing 10.526 s -
Total appsec 10.687 s 161.24 ms (1.5%)
Total iast 11.041 s 515.08 ms (4.9%)
Total profiling 10.74 s 214.091 ms (2.0%) 
gantt
    title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~e21732b34a, baseline=1.42.0-SNAPSHOT~e3d43d52e4

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.425 ms) : 0, 688425
BytebuddyAgent [candidate] (688.331 ms) : 0, 688331
GlobalTracer [baseline] (316.196 ms) : 0, 316196
GlobalTracer [candidate] (316.991 ms) : 0, 316991
AppSec [baseline] (54.218 ms) : 0, 54218
AppSec [candidate] (54.247 ms) : 0, 54247
Remote Config [baseline] (679.995 µs) : 0, 680
Remote Config [candidate] (669.014 µs) : 0, 669
Telemetry [baseline] (10.558 ms) : 0, 10558
Telemetry [candidate] (10.449 ms) : 0, 10449
section appsec
BytebuddyAgent [baseline] (704.296 ms) : 0, 704296
BytebuddyAgent [candidate] (703.255 ms) : 0, 703255
GlobalTracer [baseline] (313.435 ms) : 0, 313435
GlobalTracer [candidate] (313.051 ms) : 0, 313051
AppSec [baseline] (165.186 ms) : 0, 165186
AppSec [candidate] (164.226 ms) : 0, 164226
IAST [baseline] (19.934 ms) : 0, 19934
IAST [candidate] (21.659 ms) : 0, 21659
Remote Config [baseline] (640.227 µs) : 0, 640
Remote Config [candidate] (644.423 µs) : 0, 644
Telemetry [baseline] (8.044 ms) : 0, 8044
Telemetry [candidate] (7.754 ms) : 0, 7754
section iast
BytebuddyAgent [baseline] (804.611 ms) : 0, 804611
BytebuddyAgent [candidate] (802.945 ms) : 0, 802945
GlobalTracer [baseline] (304.737 ms) : 0, 304737
GlobalTracer [candidate] (305.398 ms) : 0, 305398
AppSec [baseline] (56.536 ms) : 0, 56536
AppSec [candidate] (58.011 ms) : 0, 58011
IAST [baseline] (20.46 ms) : 0, 20460
IAST [candidate] (20.164 ms) : 0, 20164
Remote Config [baseline] (601.181 µs) : 0, 601
Remote Config [candidate] (608.531 µs) : 0, 609
Telemetry [baseline] (7.331 ms) : 0, 7331
Telemetry [candidate] (7.474 ms) : 0, 7474
section profiling
BytebuddyAgent [baseline] (682.109 ms) : 0, 682109
BytebuddyAgent [candidate] (682.088 ms) : 0, 682088
GlobalTracer [baseline] (400.716 ms) : 0, 400716
GlobalTracer [candidate] (399.767 ms) : 0, 399767
AppSec [baseline] (54.764 ms) : 0, 54764
AppSec [candidate] (54.579 ms) : 0, 54579
Remote Config [baseline] (661.698 µs) : 0, 662
Remote Config [candidate] (667.481 µs) : 0, 667
Telemetry [baseline] (11.975 ms) : 0, 11975
Telemetry [candidate] (14.107 ms) : 0, 14107
ProfilingAgent [baseline] (92.67 ms) : 0, 92670
ProfilingAgent [candidate] (89.975 ms) : 0, 89975
Profiling [baseline] (92.693 ms) : 0, 92693
Profiling [candidate] (89.999 ms) : 0, 89999
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-29T22:52:31 2024-10-29T22:59:27
git_branch master vzakharov/merge_rc_fix
git_commit_date 1730221895 1730241711
git_commit_sha e3d43d5 e21732b
release_version 1.42.0-SNAPSHOT~e3d43d52e4 1.42.0-SNAPSHOT~e21732b34a
start_time 2024-10-29T22:52:18 2024-10-29T22:59:13
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730243117 1730243117
ci_job_id 689155720 689155720
ci_pipeline_id 47785868 47785868
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~e21732b34a, baseline=1.42.0-SNAPSHOT~e3d43d52e4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.345 ms) : 1325, 1364
.   : milestone, 1345,
appsec (1.742 ms) : 1717, 1767
.   : milestone, 1742,
appsec_no_iast (1.743 ms) : 1719, 1766
.   : milestone, 1743,
iast (1.515 ms) : 1494, 1537
.   : milestone, 1515,
profiling (1.485 ms) : 1462, 1508
.   : milestone, 1485,
tracing (1.463 ms) : 1438, 1487
.   : milestone, 1463,
section candidate
no_agent (1.338 ms) : 1319, 1357
.   : milestone, 1338,
appsec (1.727 ms) : 1702, 1751
.   : milestone, 1727,
appsec_no_iast (1.717 ms) : 1692, 1742
.   : milestone, 1717,
iast (1.476 ms) : 1453, 1498
.   : milestone, 1476,
profiling (1.483 ms) : 1461, 1506
.   : milestone, 1483,
tracing (1.487 ms) : 1463, 1512
.   : milestone, 1487,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.325 ms, 1.364 ms] -
appsec 1.742 ms [1.717 ms, 1.767 ms] 396.735 µs (29.5%)
appsec_no_iast 1.743 ms [1.719 ms, 1.766 ms] 397.664 µs (29.6%)
iast 1.515 ms [1.494 ms, 1.537 ms] 170.49 µs (12.7%)
profiling 1.485 ms [1.462 ms, 1.508 ms] 140.018 µs (10.4%)
tracing 1.463 ms [1.438 ms, 1.487 ms] 117.721 µs (8.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.338 ms [1.319 ms, 1.357 ms] -
appsec 1.727 ms [1.702 ms, 1.751 ms] 389.159 µs (29.1%)
appsec_no_iast 1.717 ms [1.692 ms, 1.742 ms] 379.429 µs (28.4%)
iast 1.476 ms [1.453 ms, 1.498 ms] 138.107 µs (10.3%)
profiling 1.483 ms [1.461 ms, 1.506 ms] 145.675 µs (10.9%)
tracing 1.487 ms [1.463 ms, 1.512 ms] 149.61 µs (11.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~e21732b34a, baseline=1.42.0-SNAPSHOT~e3d43d52e4
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.1 µs) : 355, 394
.   : milestone, 374,
iast (489.891 µs) : 469, 511
.   : milestone, 490,
iast_FULL (645.25 µs) : 624, 667
.   : milestone, 645,
iast_GLOBAL (531.717 µs) : 508, 555
.   : milestone, 532,
iast_HARDCODED_SECRET_DISABLED (490.142 µs) : 469, 511
.   : milestone, 490,
iast_INACTIVE (452.634 µs) : 431, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (474.491 µs) : 453, 496
.   : milestone, 474,
tracing (445.23 µs) : 425, 466
.   : milestone, 445,
section candidate
no_agent (377.549 µs) : 358, 397
.   : milestone, 378,
iast (490.433 µs) : 469, 512
.   : milestone, 490,
iast_FULL (647.857 µs) : 626, 669
.   : milestone, 648,
iast_GLOBAL (518.945 µs) : 497, 541
.   : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (489.863 µs) : 468, 511
.   : milestone, 490,
iast_INACTIVE (452.77 µs) : 432, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (480.788 µs) : 459, 503
.   : milestone, 481,
tracing (447.753 µs) : 427, 468
.   : milestone, 448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.1 µs [354.54 µs, 393.66 µs] -
iast 489.891 µs [468.579 µs, 511.202 µs] 115.791 µs (31.0%)
iast_FULL 645.25 µs [623.808 µs, 666.693 µs] 271.15 µs (72.5%)
iast_GLOBAL 531.717 µs [508.088 µs, 555.347 µs] 157.617 µs (42.1%)
iast_HARDCODED_SECRET_DISABLED 490.142 µs [469.321 µs, 510.964 µs] 116.043 µs (31.0%)
iast_INACTIVE 452.634 µs [431.447 µs, 473.821 µs] 78.534 µs (21.0%)
iast_TELEMETRY_OFF 474.491 µs [453.407 µs, 495.575 µs] 100.391 µs (26.8%)
tracing 445.23 µs [424.755 µs, 465.705 µs] 71.13 µs (19.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.549 µs [357.949 µs, 397.148 µs] -
iast 490.433 µs [468.83 µs, 512.035 µs] 112.884 µs (29.9%)
iast_FULL 647.857 µs [626.435 µs, 669.278 µs] 270.308 µs (71.6%)
iast_GLOBAL 518.945 µs [496.836 µs, 541.054 µs] 141.396 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED 489.863 µs [468.366 µs, 511.359 µs] 112.314 µs (29.7%)
iast_INACTIVE 452.77 µs [431.648 µs, 473.893 µs] 75.222 µs (19.9%)
iast_TELEMETRY_OFF 480.788 µs [458.872 µs, 502.703 µs] 103.239 µs (27.3%)
tracing 447.753 µs [427.04 µs, 468.466 µs] 70.205 µs (18.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master vzakharov/merge_rc_fix
git_commit_date 1730221895 1730241711
git_commit_sha e3d43d5 e21732b
release_version 1.42.0-SNAPSHOT~e3d43d52e4 1.42.0-SNAPSHOT~e21732b34a
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1730243664 1730243664
ci_job_id 689155721 689155721
ci_pipeline_id 47785868 47785868
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~e21732b34a, baseline=1.42.0-SNAPSHOT~e3d43d52e4
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.01 s) : 15010000, 15010000
.   : milestone, 15010000,
appsec (15.13 s) : 15130000, 15130000
.   : milestone, 15130000,
iast (18.897 s) : 18897000, 18897000
.   : milestone, 18897000,
iast_GLOBAL (17.784 s) : 17784000, 17784000
.   : milestone, 17784000,
profiling (15.254 s) : 15254000, 15254000
.   : milestone, 15254000,
tracing (15.424 s) : 15424000, 15424000
.   : milestone, 15424000,
section candidate
no_agent (15.036 s) : 15036000, 15036000
.   : milestone, 15036000,
appsec (15.309 s) : 15309000, 15309000
.   : milestone, 15309000,
iast (18.401 s) : 18401000, 18401000
.   : milestone, 18401000,
iast_GLOBAL (17.838 s) : 17838000, 17838000
.   : milestone, 17838000,
profiling (15.214 s) : 15214000, 15214000
.   : milestone, 15214000,
tracing (15.131 s) : 15131000, 15131000
.   : milestone, 15131000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.01 s [15.01 s, 15.01 s] -
appsec 15.13 s [15.13 s, 15.13 s] 120.0 ms (0.8%)
iast 18.897 s [18.897 s, 18.897 s] 3.887 s (25.9%)
iast_GLOBAL 17.784 s [17.784 s, 17.784 s] 2.774 s (18.5%)
profiling 15.254 s [15.254 s, 15.254 s] 244.0 ms (1.6%)
tracing 15.424 s [15.424 s, 15.424 s] 414.0 ms (2.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.036 s [15.036 s, 15.036 s] -
appsec 15.309 s [15.309 s, 15.309 s] 273.0 ms (1.8%)
iast 18.401 s [18.401 s, 18.401 s] 3.365 s (22.4%)
iast_GLOBAL 17.838 s [17.838 s, 17.838 s] 2.802 s (18.6%)
profiling 15.214 s [15.214 s, 15.214 s] 178.0 ms (1.2%)
tracing 15.131 s [15.131 s, 15.131 s] 95.0 ms (0.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~e21732b34a, baseline=1.42.0-SNAPSHOT~e3d43d52e4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1474
.   : milestone, 1462,
appsec (2.325 ms) : 2284, 2366
.   : milestone, 2325,
iast (2.062 ms) : 2010, 2115
.   : milestone, 2062,
iast_GLOBAL (2.111 ms) : 2059, 2163
.   : milestone, 2111,
profiling (1.928 ms) : 1886, 1970
.   : milestone, 1928,
tracing (1.899 ms) : 1860, 1939
.   : milestone, 1899,
section candidate
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.317 ms) : 2276, 2358
.   : milestone, 2317,
iast (2.063 ms) : 2012, 2115
.   : milestone, 2063,
iast_GLOBAL (2.102 ms) : 2050, 2153
.   : milestone, 2102,
profiling (1.937 ms) : 1894, 1979
.   : milestone, 1937,
tracing (1.903 ms) : 1864, 1942
.   : milestone, 1903,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.474 ms] -
appsec 2.325 ms [2.284 ms, 2.366 ms] 862.331 µs (59.0%)
iast 2.062 ms [2.01 ms, 2.115 ms] 599.948 µs (41.0%)
iast_GLOBAL 2.111 ms [2.059 ms, 2.163 ms] 648.463 µs (44.3%)
profiling 1.928 ms [1.886 ms, 1.97 ms] 465.948 µs (31.9%)
tracing 1.899 ms [1.86 ms, 1.939 ms] 436.886 µs (29.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.448 ms, 1.471 ms] -
appsec 2.317 ms [2.276 ms, 2.358 ms] 857.332 µs (58.7%)
iast 2.063 ms [2.012 ms, 2.115 ms] 603.604 µs (41.4%)
iast_GLOBAL 2.102 ms [2.05 ms, 2.153 ms] 641.886 µs (44.0%)
profiling 1.937 ms [1.894 ms, 1.979 ms] 476.844 µs (32.7%)
tracing 1.903 ms [1.864 ms, 1.942 ms] 443.303 µs (30.4%)

@ValentinZakharov ValentinZakharov merged commit 944d4e6 into master Oct 30, 2024
106 checks passed
@ValentinZakharov ValentinZakharov deleted the vzakharov/merge_rc_fix branch October 30, 2024 09:09
@github-actions github-actions bot added this to the 1.42.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariovido Mariovido Mariovido approved these changes

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 is a code owner automatically assigned from DataDog/asm-java

Assignees

@ValentinZakharov ValentinZakharov

Labels
comp: remote config Configuration at Runtime type: bug
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ValentinZakharov @Mariovido