Add Jakarta WebService Instrumentation #7854

jordan-wong · 2024-10-29T19:56:43Z

What Does This Do

Adds instrumentation for Jakarta WebServices annotation. Instrumentation is identical to Javax WebServices since the library is the same, but in a different namespace.

Motivation

Some customers use Jakarta WebServices annotation jakarta.jws.WebService . Currently we only support the Javax version WebServices annotation javax.jws.WebService. We want to add support for both annotations.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

datadog-datadog-prod-us1 · 2024-10-29T20:02:33Z

...s-annotations/src/main/java/datadog/trace/instrumentation/jakartaws/WebServiceDecorator.java

+  public static final CharSequence JAKARTA_WS_ENDPOINT =
+      UTF8BytesString.create("jakarta-ws-endpoint");
+
+  private WebServiceDecorator() {}


⚪ Code Quality Violation

Consider adding super() or this() to your constructor (...read more)

In Java, it is suggested to call super() in an extended class. This rule will report a violation if both a call to super() and an overloaded constructor are absent.

...tations/src/main/java/datadog/trace/instrumentation/jakartaws/WebServiceInstrumentation.java

...s-annotations/src/main/java/datadog/trace/instrumentation/jakartaws/WebServiceDecorator.java

dd-java-agent/instrumentation/jakarta-ws-annotations/src/test/groovy/WebServiceTest.groovy

pr-commenter · 2024-10-29T20:39:08Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	add-jakarta-webservice-instrumentation
git_commit_date	1730315410	1730317602
git_commit_sha	`104a441`	`09ae5cc`
release_version	1.42.0-SNAPSHOT~104a441d0a	1.42.0-SNAPSHOT~09ae5cc1bc

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1730319922	1730319922
ci_job_id	690678276	690678276
ci_pipeline_id	47895489	47895489
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~09ae5cc1bc, baseline=1.42.0-SNAPSHOT~104a441d0a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087543
Total [baseline] (8.584 s) : 0, 8584301
Agent [candidate] (1.086 s) : 0, 1086409
Total [candidate] (8.589 s) : 0, 8588984
section iast
Agent [baseline] (1.206 s) : 0, 1206394
Total [baseline] (9.144 s) : 0, 9143711
Agent [candidate] (1.212 s) : 0, 1212054
Total [candidate] (9.193 s) : 0, 9192865
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.205 s) : 0, 1205313
Total [baseline] (9.102 s) : 0, 9102007
Agent [candidate] (1.21 s) : 0, 1209868
Total [candidate] (9.143 s) : 0, 9142945
section iast_TELEMETRY_OFF
Agent [baseline] (1.214 s) : 0, 1214133
Total [baseline] (9.113 s) : 0, 9112584
Agent [candidate] (1.206 s) : 0, 1205560
Total [candidate] (9.13 s) : 0, 9129740

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.088 s	-
Agent	iast	1.206 s	118.852 ms (10.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.205 s	117.77 ms (10.8%)
Agent	iast_TELEMETRY_OFF	1.214 s	126.59 ms (11.6%)
Total	tracing	8.584 s	-
Total	iast	9.144 s	559.41 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.102 s	517.706 ms (6.0%)
Total	iast_TELEMETRY_OFF	9.113 s	528.283 ms (6.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.086 s	-
Agent	iast	1.212 s	125.645 ms (11.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.21 s	123.459 ms (11.4%)
Agent	iast_TELEMETRY_OFF	1.206 s	119.151 ms (11.0%)
Total	tracing	8.589 s	-
Total	iast	9.193 s	603.881 ms (7.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.143 s	553.961 ms (6.4%)
Total	iast_TELEMETRY_OFF	9.13 s	540.756 ms (6.3%)

gantt
    title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~09ae5cc1bc, baseline=1.42.0-SNAPSHOT~104a441d0a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.861 ms) : 0, 691861
BytebuddyAgent [candidate] (689.448 ms) : 0, 689448
GlobalTracer [baseline] (317.603 ms) : 0, 317603
GlobalTracer [candidate] (317.369 ms) : 0, 317369
AppSec [baseline] (54.389 ms) : 0, 54389
AppSec [candidate] (54.075 ms) : 0, 54075
Remote Config [baseline] (671.192 µs) : 0, 671
Remote Config [candidate] (660.815 µs) : 0, 661
Telemetry [baseline] (9.198 ms) : 0, 9198
Telemetry [candidate] (11.095 ms) : 0, 11095
section iast
BytebuddyAgent [baseline] (802.893 ms) : 0, 802893
BytebuddyAgent [candidate] (806.466 ms) : 0, 806466
GlobalTracer [baseline] (304.23 ms) : 0, 304230
GlobalTracer [candidate] (305.946 ms) : 0, 305946
AppSec [baseline] (57.649 ms) : 0, 57649
AppSec [candidate] (56.21 ms) : 0, 56210
IAST [baseline] (19.829 ms) : 0, 19829
IAST [candidate] (20.701 ms) : 0, 20701
Remote Config [baseline] (605.083 µs) : 0, 605
Remote Config [candidate] (619.66 µs) : 0, 620
Telemetry [baseline] (7.418 ms) : 0, 7418
Telemetry [candidate] (8.245 ms) : 0, 8245
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.26 ms) : 0, 801260
BytebuddyAgent [candidate] (803.927 ms) : 0, 803927
GlobalTracer [baseline] (304.232 ms) : 0, 304232
GlobalTracer [candidate] (306.314 ms) : 0, 306314
AppSec [baseline] (57.319 ms) : 0, 57319
AppSec [candidate] (57.758 ms) : 0, 57758
IAST [baseline] (20.655 ms) : 0, 20655
IAST [candidate] (19.918 ms) : 0, 19918
Remote Config [baseline] (608.049 µs) : 0, 608
Remote Config [candidate] (632.311 µs) : 0, 632
Telemetry [baseline] (7.514 ms) : 0, 7514
Telemetry [candidate] (7.514 ms) : 0, 7514
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (807.177 ms) : 0, 807177
BytebuddyAgent [candidate] (800.758 ms) : 0, 800758
GlobalTracer [baseline] (306.902 ms) : 0, 306902
GlobalTracer [candidate] (305.249 ms) : 0, 305249
AppSec [baseline] (56.53 ms) : 0, 56530
AppSec [candidate] (56.491 ms) : 0, 56491
IAST [baseline] (21.612 ms) : 0, 21612
IAST [candidate] (21.319 ms) : 0, 21319
Remote Config [baseline] (601.838 µs) : 0, 602
Remote Config [candidate] (599.336 µs) : 0, 599
Telemetry [baseline] (7.423 ms) : 0, 7423
Telemetry [candidate] (7.353 ms) : 0, 7353

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~09ae5cc1bc, baseline=1.42.0-SNAPSHOT~104a441d0a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1097749
Total [baseline] (10.644 s) : 0, 10643645
Agent [candidate] (1.092 s) : 0, 1091766
Total [candidate] (10.462 s) : 0, 10461921
section appsec
Agent [baseline] (1.217 s) : 0, 1217047
Total [baseline] (10.697 s) : 0, 10696875
Agent [candidate] (1.218 s) : 0, 1217771
Total [candidate] (10.66 s) : 0, 10660277
section iast
Agent [baseline] (1.215 s) : 0, 1214522
Total [baseline] (10.954 s) : 0, 10954395
Agent [candidate] (1.211 s) : 0, 1210702
Total [candidate] (10.957 s) : 0, 10956754
section profiling
Agent [baseline] (1.283 s) : 0, 1282626
Total [baseline] (10.818 s) : 0, 10818342
Agent [candidate] (1.285 s) : 0, 1284705
Total [candidate] (10.788 s) : 0, 10787620

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.098 s	-
Agent	appsec	1.217 s	119.298 ms (10.9%)
Agent	iast	1.215 s	116.773 ms (10.6%)
Agent	profiling	1.283 s	184.877 ms (16.8%)
Total	tracing	10.644 s	-
Total	appsec	10.697 s	53.23 ms (0.5%)
Total	iast	10.954 s	310.75 ms (2.9%)
Total	profiling	10.818 s	174.696 ms (1.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.092 s	-
Agent	appsec	1.218 s	126.006 ms (11.5%)
Agent	iast	1.211 s	118.936 ms (10.9%)
Agent	profiling	1.285 s	192.939 ms (17.7%)
Total	tracing	10.462 s	-
Total	appsec	10.66 s	198.356 ms (1.9%)
Total	iast	10.957 s	494.833 ms (4.7%)
Total	profiling	10.788 s	325.699 ms (3.1%)

gantt
    title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~09ae5cc1bc, baseline=1.42.0-SNAPSHOT~104a441d0a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (697.371 ms) : 0, 697371
BytebuddyAgent [candidate] (693.374 ms) : 0, 693374
GlobalTracer [baseline] (320.024 ms) : 0, 320024
GlobalTracer [candidate] (319.201 ms) : 0, 319201
AppSec [baseline] (54.867 ms) : 0, 54867
AppSec [candidate] (54.813 ms) : 0, 54813
Remote Config [baseline] (682.056 µs) : 0, 682
Remote Config [candidate] (669.227 µs) : 0, 669
Telemetry [baseline] (10.871 ms) : 0, 10871
Telemetry [candidate] (9.858 ms) : 0, 9858
section appsec
BytebuddyAgent [baseline] (705.19 ms) : 0, 705190
BytebuddyAgent [candidate] (705.457 ms) : 0, 705457
GlobalTracer [baseline] (313.312 ms) : 0, 313312
GlobalTracer [candidate] (314.079 ms) : 0, 314079
AppSec [baseline] (165.5 ms) : 0, 165500
AppSec [candidate] (166.405 ms) : 0, 166405
Remote Config [baseline] (644.401 µs) : 0, 644
Remote Config [candidate] (639.42 µs) : 0, 639
Telemetry [baseline] (8.152 ms) : 0, 8152
Telemetry [candidate] (8.112 ms) : 0, 8112
IAST [baseline] (20.981 ms) : 0, 20981
IAST [candidate] (18.623 ms) : 0, 18623
section iast
BytebuddyAgent [baseline] (808.702 ms) : 0, 808702
BytebuddyAgent [candidate] (805.104 ms) : 0, 805104
GlobalTracer [baseline] (306.582 ms) : 0, 306582
GlobalTracer [candidate] (306.491 ms) : 0, 306491
AppSec [baseline] (56.923 ms) : 0, 56923
AppSec [candidate] (56.662 ms) : 0, 56662
Remote Config [baseline] (605.893 µs) : 0, 606
Remote Config [candidate] (607.964 µs) : 0, 608
Telemetry [baseline] (7.382 ms) : 0, 7382
Telemetry [candidate] (7.368 ms) : 0, 7368
IAST [baseline] (20.49 ms) : 0, 20490
IAST [candidate] (20.637 ms) : 0, 20637
section profiling
ProfilingAgent [baseline] (92.37 ms) : 0, 92370
ProfilingAgent [candidate] (92.848 ms) : 0, 92848
BytebuddyAgent [baseline] (682.884 ms) : 0, 682884
BytebuddyAgent [candidate] (683.784 ms) : 0, 683784
GlobalTracer [baseline] (400.9 ms) : 0, 400900
GlobalTracer [candidate] (401.25 ms) : 0, 401250
AppSec [baseline] (54.633 ms) : 0, 54633
AppSec [candidate] (54.995 ms) : 0, 54995
Remote Config [baseline] (670.932 µs) : 0, 671
Remote Config [candidate] (1.409 ms) : 0, 1409
Telemetry [baseline] (12.059 ms) : 0, 12059
Telemetry [candidate] (11.417 ms) : 0, 11417
Profiling [baseline] (92.393 ms) : 0, 92393
Profiling [candidate] (92.873 ms) : 0, 92873

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-10-30T19:57:41	2024-10-30T20:04:37
git_branch	master	add-jakarta-webservice-instrumentation
git_commit_date	1730315410	1730317602
git_commit_sha	`104a441`	`09ae5cc`
release_version	1.42.0-SNAPSHOT~104a441d0a	1.42.0-SNAPSHOT~09ae5cc1bc
start_time	2024-10-30T19:57:28	2024-10-30T20:04:24

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1730319029	1730319029
ci_job_id	690678277	690678277
ci_pipeline_id	47895489	47895489
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~09ae5cc1bc, baseline=1.42.0-SNAPSHOT~104a441d0a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1325, 1362
.   : milestone, 1343,
appsec (1.729 ms) : 1704, 1753
.   : milestone, 1729,
appsec_no_iast (1.737 ms) : 1713, 1761
.   : milestone, 1737,
iast (1.494 ms) : 1472, 1517
.   : milestone, 1494,
profiling (1.501 ms) : 1478, 1525
.   : milestone, 1501,
tracing (1.473 ms) : 1448, 1498
.   : milestone, 1473,
section candidate
no_agent (1.337 ms) : 1318, 1356
.   : milestone, 1337,
appsec (1.733 ms) : 1709, 1758
.   : milestone, 1733,
appsec_no_iast (1.763 ms) : 1739, 1787
.   : milestone, 1763,
iast (1.51 ms) : 1488, 1532
.   : milestone, 1510,
profiling (1.482 ms) : 1459, 1505
.   : milestone, 1482,
tracing (1.477 ms) : 1452, 1502
.   : milestone, 1477,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.343 ms [1.325 ms, 1.362 ms]	-
appsec	1.729 ms [1.704 ms, 1.753 ms]	385.12 µs (28.7%)
appsec_no_iast	1.737 ms [1.713 ms, 1.761 ms]	393.843 µs (29.3%)
iast	1.494 ms [1.472 ms, 1.517 ms]	150.606 µs (11.2%)
profiling	1.501 ms [1.478 ms, 1.525 ms]	157.831 µs (11.7%)
tracing	1.473 ms [1.448 ms, 1.498 ms]	129.475 µs (9.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.337 ms [1.318 ms, 1.356 ms]	-
appsec	1.733 ms [1.709 ms, 1.758 ms]	396.252 µs (29.6%)
appsec_no_iast	1.763 ms [1.739 ms, 1.787 ms]	425.605 µs (31.8%)
iast	1.51 ms [1.488 ms, 1.532 ms]	172.53 µs (12.9%)
profiling	1.482 ms [1.459 ms, 1.505 ms]	145.087 µs (10.9%)
tracing	1.477 ms [1.452 ms, 1.502 ms]	139.624 µs (10.4%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~09ae5cc1bc, baseline=1.42.0-SNAPSHOT~104a441d0a
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.5 µs) : 355, 394
.   : milestone, 375,
iast (485.81 µs) : 464, 507
.   : milestone, 486,
iast_FULL (652.078 µs) : 631, 674
.   : milestone, 652,
iast_GLOBAL (533.985 µs) : 511, 557
.   : milestone, 534,
iast_HARDCODED_SECRET_DISABLED (499.184 µs) : 478, 521
.   : milestone, 499,
iast_INACTIVE (452.742 µs) : 431, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (475.716 µs) : 455, 497
.   : milestone, 476,
tracing (444.158 µs) : 424, 464
.   : milestone, 444,
section candidate
no_agent (379.293 µs) : 360, 399
.   : milestone, 379,
iast (492.726 µs) : 471, 515
.   : milestone, 493,
iast_FULL (650.788 µs) : 629, 673
.   : milestone, 651,
iast_GLOBAL (521.078 µs) : 499, 543
.   : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (490.577 µs) : 469, 512
.   : milestone, 491,
iast_INACTIVE (469.393 µs) : 448, 491
.   : milestone, 469,
iast_TELEMETRY_OFF (481.58 µs) : 460, 503
.   : milestone, 482,
tracing (444.654 µs) : 424, 465
.   : milestone, 445,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	374.5 µs [354.785 µs, 394.215 µs]	-
iast	485.81 µs [464.487 µs, 507.132 µs]	111.31 µs (29.7%)
iast_FULL	652.078 µs [630.622 µs, 673.533 µs]	277.578 µs (74.1%)
iast_GLOBAL	533.985 µs [511.072 µs, 556.898 µs]	159.485 µs (42.6%)
iast_HARDCODED_SECRET_DISABLED	499.184 µs [477.576 µs, 520.793 µs]	124.684 µs (33.3%)
iast_INACTIVE	452.742 µs [431.082 µs, 474.402 µs]	78.242 µs (20.9%)
iast_TELEMETRY_OFF	475.716 µs [454.691 µs, 496.741 µs]	101.216 µs (27.0%)
tracing	444.158 µs [423.909 µs, 464.407 µs]	69.658 µs (18.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	379.293 µs [359.513 µs, 399.072 µs]	-
iast	492.726 µs [470.524 µs, 514.929 µs]	113.434 µs (29.9%)
iast_FULL	650.788 µs [629.042 µs, 672.535 µs]	271.496 µs (71.6%)
iast_GLOBAL	521.078 µs [499.375 µs, 542.78 µs]	141.785 µs (37.4%)
iast_HARDCODED_SECRET_DISABLED	490.577 µs [469.109 µs, 512.046 µs]	111.285 µs (29.3%)
iast_INACTIVE	469.393 µs [447.954 µs, 490.832 µs]	90.101 µs (23.8%)
iast_TELEMETRY_OFF	481.58 µs [460.135 µs, 503.025 µs]	102.287 µs (27.0%)
tracing	444.654 µs [424.117 µs, 465.192 µs]	65.362 µs (17.2%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	add-jakarta-webservice-instrumentation
git_commit_date	1730315410	1730317602
git_commit_sha	`104a441`	`09ae5cc`
release_version	1.42.0-SNAPSHOT~104a441d0a	1.42.0-SNAPSHOT~09ae5cc1bc

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1730319417	1730319417
ci_job_id	690678278	690678278
ci_pipeline_id	47895489	47895489
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~09ae5cc1bc, baseline=1.42.0-SNAPSHOT~104a441d0a
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.322 s) : 15322000, 15322000
.   : milestone, 15322000,
appsec (15.229 s) : 15229000, 15229000
.   : milestone, 15229000,
iast (18.668 s) : 18668000, 18668000
.   : milestone, 18668000,
iast_GLOBAL (17.982 s) : 17982000, 17982000
.   : milestone, 17982000,
profiling (15.252 s) : 15252000, 15252000
.   : milestone, 15252000,
tracing (15.156 s) : 15156000, 15156000
.   : milestone, 15156000,
section candidate
no_agent (14.959 s) : 14959000, 14959000
.   : milestone, 14959000,
appsec (15.16 s) : 15160000, 15160000
.   : milestone, 15160000,
iast (18.828 s) : 18828000, 18828000
.   : milestone, 18828000,
iast_GLOBAL (18.049 s) : 18049000, 18049000
.   : milestone, 18049000,
profiling (15.134 s) : 15134000, 15134000
.   : milestone, 15134000,
tracing (15.19 s) : 15190000, 15190000
.   : milestone, 15190000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.322 s [15.322 s, 15.322 s]	-
appsec	15.229 s [15.229 s, 15.229 s]	-93.0 ms (-0.6%)
iast	18.668 s [18.668 s, 18.668 s]	3.346 s (21.8%)
iast_GLOBAL	17.982 s [17.982 s, 17.982 s]	2.66 s (17.4%)
profiling	15.252 s [15.252 s, 15.252 s]	-70.0 ms (-0.5%)
tracing	15.156 s [15.156 s, 15.156 s]	-166.0 ms (-1.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.959 s [14.959 s, 14.959 s]	-
appsec	15.16 s [15.16 s, 15.16 s]	201.0 ms (1.3%)
iast	18.828 s [18.828 s, 18.828 s]	3.869 s (25.9%)
iast_GLOBAL	18.049 s [18.049 s, 18.049 s]	3.09 s (20.7%)
profiling	15.134 s [15.134 s, 15.134 s]	175.0 ms (1.2%)
tracing	15.19 s [15.19 s, 15.19 s]	231.0 ms (1.5%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~09ae5cc1bc, baseline=1.42.0-SNAPSHOT~104a441d0a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1447, 1470
.   : milestone, 1459,
appsec (2.323 ms) : 2282, 2364
.   : milestone, 2323,
iast (2.057 ms) : 2006, 2109
.   : milestone, 2057,
iast_GLOBAL (2.115 ms) : 2063, 2168
.   : milestone, 2115,
profiling (1.938 ms) : 1896, 1981
.   : milestone, 1938,
tracing (1.899 ms) : 1860, 1939
.   : milestone, 1899,
section candidate
no_agent (1.457 ms) : 1446, 1469
.   : milestone, 1457,
appsec (2.307 ms) : 2267, 2348
.   : milestone, 2307,
iast (2.056 ms) : 2005, 2107
.   : milestone, 2056,
iast_GLOBAL (2.11 ms) : 2058, 2163
.   : milestone, 2110,
profiling (1.915 ms) : 1874, 1955
.   : milestone, 1915,
tracing (1.914 ms) : 1873, 1954
.   : milestone, 1914,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.459 ms [1.447 ms, 1.47 ms]	-
appsec	2.323 ms [2.282 ms, 2.364 ms]	864.129 µs (59.2%)
iast	2.057 ms [2.006 ms, 2.109 ms]	598.574 µs (41.0%)
iast_GLOBAL	2.115 ms [2.063 ms, 2.168 ms]	656.712 µs (45.0%)
profiling	1.938 ms [1.896 ms, 1.981 ms]	479.611 µs (32.9%)
tracing	1.899 ms [1.86 ms, 1.939 ms]	440.693 µs (30.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.457 ms [1.446 ms, 1.469 ms]	-
appsec	2.307 ms [2.267 ms, 2.348 ms]	850.001 µs (58.3%)
iast	2.056 ms [2.005 ms, 2.107 ms]	599.156 µs (41.1%)
iast_GLOBAL	2.11 ms [2.058 ms, 2.163 ms]	653.349 µs (44.8%)
profiling	1.915 ms [1.874 ms, 1.955 ms]	457.666 µs (31.4%)
tracing	1.914 ms [1.873 ms, 1.954 ms]	456.45 µs (31.3%)

nayeem-kamal

LGTM 👍

jordan-wong · 2024-11-11T16:23:53Z

dd-java-agent/instrumentation/jakarta-ws-annotations/build.gradle

+  // todo correct version non rs
+  compileOnly group: 'jakarta.jws', name: 'jakarta.jws-api', version: '3.0.0'
+
+  //todo also make jakarta


need to remove comment

formatting

d25059a

jordan-wong requested review from a team as code owners October 29, 2024 19:56

jordan-wong requested a review from nayeem-kamal October 29, 2024 19:56

datadog-datadog-prod-us1 bot reviewed Oct 29, 2024

View reviewed changes

nayeem-kamal reviewed Oct 29, 2024

View reviewed changes

jordan-wong changed the title ~~formatting~~ Add Jakarta WebService Instrumentation Oct 29, 2024

Rename method jax -> jakarta, remove unecessary enable config

24790e4

jordan-wong requested a review from nayeem-kamal October 30, 2024 18:29

jordan-wong added the inst: jax-ws JAX-WS instrumentation label Oct 30, 2024

merge master

09ae5cc

nayeem-kamal approved these changes Oct 31, 2024

View reviewed changes

jordan-wong merged commit 16a53f2 into master Oct 31, 2024
101 checks passed

jordan-wong deleted the add-jakarta-webservice-instrumentation branch October 31, 2024 17:42

github-actions bot added this to the 1.42.0 milestone Oct 31, 2024

jordan-wong commented Nov 11, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Jakarta WebService Instrumentation #7854

Add Jakarta WebService Instrumentation #7854

jordan-wong commented Oct 29, 2024 •

edited

Loading

datadog-datadog-prod-us1 bot Oct 29, 2024

pr-commenter bot commented Oct 29, 2024 •

edited

Loading

nayeem-kamal left a comment

jordan-wong Nov 11, 2024

Add Jakarta WebService Instrumentation #7854

Add Jakarta WebService Instrumentation #7854

Conversation

jordan-wong commented Oct 29, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

datadog-datadog-prod-us1 bot Oct 29, 2024

Choose a reason for hiding this comment

⚪ Code Quality Violation

pr-commenter bot commented Oct 29, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

nayeem-kamal left a comment

Choose a reason for hiding this comment

jordan-wong Nov 11, 2024

Choose a reason for hiding this comment

jordan-wong commented Oct 29, 2024 •

edited

Loading

pr-commenter bot commented Oct 29, 2024 •

edited

Loading