Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compression support for SymDB paylods #7851

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Add compression support for SymDB paylods #7851

merged 4 commits into from
Oct 31, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Oct 29, 2024 •
edited by jira bot
Loading

What Does This Do

Add support of SymDB payload compresion using gzip. an option is still available to disable compression.
The usual factor of compression is 40:1 which is very effective for json payload and therefore reaching the 50MB limitation is very unlikely.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-3074

@jpbempel
Add compression support for SymDB paylods
9ca9476 
Add support of SymDB payload compresion using gzip. an option is still
available to disable compression.
The usual factor of compression is 40:1 which is very effective for
json payload and therefore reaching the 50MB limitation is very
unlikely.
@jpbempel jpbempel requested review from a team as code owners October 29, 2024 15:34
@jpbempel jpbempel requested review from shatzi and smola and removed request for a team October 29, 2024 15:34
@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Oct 29, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 29, 2024 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1730366901 1730367289
end_time 2024-10-31T09:29:36 2024-10-31T09:36:04
git_branch master jpbempel/compress-symdb-payloads
git_commit_sha 104a441 51013d5
start_time 2024-10-31T09:28:22 2024-10-31T09:34:50
See matching parameters
Baseline Candidate
ci_job_id 691126103 691126103
ci_pipeline_id 47931801 47931801
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1730366278 1730366278

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-29.446µs; +24.014µs] or [-11.146%; +9.089%]		 unstable
[-42.569µs; +34.490µs] or [-13.937%; +11.292%]		 unstable
[-57.707µs; +46.709µs] or [-17.913%; +14.499%]		 unstable
[-124.339µs; +104.128µs] or [-20.542%; +17.203%]		 same
scenario:basic same same same unstable
[-87.291µs; +11.428µs] or [-15.549%; +2.036%]		 unstable
[-81.838op/s; +216.791op/s] or [-3.192%; +8.455%]
scenario:loop unsure
[+40.079µs; +47.882µs] or [+0.372%; +0.445%]		 unsure
[+27.381µs; +85.698µs] or [+0.250%; +0.783%]		 same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (305.441 µs) : 265, 346
.   : milestone, 305,
basic (304.42 µs) : 294, 315
.   : milestone, 304,
loop (10.939 ms) : 10911, 10966
.   : milestone, 10939,
section candidate
noprobe (301.402 µs) : 269, 334
.   : milestone, 301,
basic (296.53 µs) : 287, 306
.   : milestone, 297,
loop (10.995 ms) : 10968, 11022
.   : milestone, 10995,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 305.441 µs [264.578 µs, 346.304 µs]
basic 304.42 µs [293.63 µs, 315.211 µs]
loop 10.939 ms [10.911 ms, 10.966 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 301.402 µs [269.284 µs, 333.52 µs]
basic 296.53 µs [286.783 µs, 306.276 µs]
loop 10.995 ms [10.968 ms, 11.022 ms]

@pr-commenter
Copy link

pr-commenter bot commented Oct 29, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/compress-symdb-payloads
git_commit_date 1730315410 1730366278
git_commit_sha 104a441 51013d5
release_version 1.42.0-SNAPSHOT~104a441d0a 1.42.0-SNAPSHOT~51013d5de1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730368739 1730368739
ci_job_id 691126097 691126097
ci_pipeline_id 47931801 47931801
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~51013d5de1, baseline=1.42.0-SNAPSHOT~104a441d0a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1086533
Total [baseline] (10.476 s) : 0, 10476182
Agent [candidate] (1.086 s) : 0, 1086283
Total [candidate] (10.416 s) : 0, 10415514
section appsec
Agent [baseline] (1.22 s) : 0, 1220169
Total [baseline] (10.694 s) : 0, 10693690
Agent [candidate] (1.222 s) : 0, 1221962
Total [candidate] (10.682 s) : 0, 10682159
section iast
Agent [baseline] (1.208 s) : 0, 1207540
Total [baseline] (10.909 s) : 0, 10908735
Agent [candidate] (1.211 s) : 0, 1211147
Total [candidate] (10.967 s) : 0, 10967389
section profiling
Agent [baseline] (1.278 s) : 0, 1278421
Total [baseline] (10.789 s) : 0, 10789120
Agent [candidate] (1.282 s) : 0, 1282476
Total [candidate] (10.782 s) : 0, 10781646
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.087 s -
Agent appsec 1.22 s 133.636 ms (12.3%)
Agent iast 1.208 s 121.007 ms (11.1%)
Agent profiling 1.278 s 191.888 ms (17.7%)
Total tracing 10.476 s -
Total appsec 10.694 s 217.508 ms (2.1%)
Total iast 10.909 s 432.553 ms (4.1%)
Total profiling 10.789 s 312.938 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent appsec 1.222 s 135.679 ms (12.5%)
Agent iast 1.211 s 124.864 ms (11.5%)
Agent profiling 1.282 s 196.192 ms (18.1%)
Total tracing 10.416 s -
Total appsec 10.682 s 266.645 ms (2.6%)
Total iast 10.967 s 551.875 ms (5.3%)
Total profiling 10.782 s 366.132 ms (3.5%) 
gantt
    title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~51013d5de1, baseline=1.42.0-SNAPSHOT~104a441d0a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.222 ms) : 0, 689222
BytebuddyAgent [candidate] (689.214 ms) : 0, 689214
GlobalTracer [baseline] (317.187 ms) : 0, 317187
GlobalTracer [candidate] (316.896 ms) : 0, 316896
AppSec [baseline] (54.248 ms) : 0, 54248
AppSec [candidate] (55.102 ms) : 0, 55102
Remote Config [baseline] (678.288 µs) : 0, 678
Remote Config [candidate] (660.163 µs) : 0, 660
Telemetry [baseline] (11.407 ms) : 0, 11407
Telemetry [candidate] (10.635 ms) : 0, 10635
section appsec
BytebuddyAgent [baseline] (706.918 ms) : 0, 706918
BytebuddyAgent [candidate] (708.212 ms) : 0, 708212
GlobalTracer [baseline] (314.074 ms) : 0, 314074
GlobalTracer [candidate] (314.277 ms) : 0, 314277
AppSec [baseline] (166.296 ms) : 0, 166296
AppSec [candidate] (167.251 ms) : 0, 167251
Remote Config [baseline] (648.768 µs) : 0, 649
Remote Config [candidate] (647.693 µs) : 0, 648
Telemetry [baseline] (8.53 ms) : 0, 8530
Telemetry [candidate] (7.768 ms) : 0, 7768
IAST [baseline] (19.864 ms) : 0, 19864
IAST [candidate] (19.951 ms) : 0, 19951
section iast
BytebuddyAgent [baseline] (803.73 ms) : 0, 803730
BytebuddyAgent [candidate] (805.377 ms) : 0, 805377
GlobalTracer [baseline] (304.65 ms) : 0, 304650
GlobalTracer [candidate] (305.052 ms) : 0, 305052
AppSec [baseline] (57.546 ms) : 0, 57546
AppSec [candidate] (58.339 ms) : 0, 58339
Remote Config [baseline] (604.473 µs) : 0, 604
Remote Config [candidate] (623.108 µs) : 0, 623
Telemetry [baseline] (7.327 ms) : 0, 7327
Telemetry [candidate] (7.552 ms) : 0, 7552
IAST [baseline] (19.916 ms) : 0, 19916
IAST [candidate] (20.453 ms) : 0, 20453
section profiling
ProfilingAgent [baseline] (92.068 ms) : 0, 92068
ProfilingAgent [candidate] (92.913 ms) : 0, 92913
BytebuddyAgent [baseline] (681.138 ms) : 0, 681138
BytebuddyAgent [candidate] (682.477 ms) : 0, 682477
GlobalTracer [baseline] (399.227 ms) : 0, 399227
GlobalTracer [candidate] (399.916 ms) : 0, 399916
AppSec [baseline] (54.448 ms) : 0, 54448
AppSec [candidate] (55.44 ms) : 0, 55440
Remote Config [baseline] (663.605 µs) : 0, 664
Remote Config [candidate] (668.819 µs) : 0, 669
Telemetry [baseline] (11.901 ms) : 0, 11901
Telemetry [candidate] (12.063 ms) : 0, 12063
Profiling [baseline] (92.092 ms) : 0, 92092
Profiling [candidate] (92.936 ms) : 0, 92936
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~51013d5de1, baseline=1.42.0-SNAPSHOT~104a441d0a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1089282
Total [baseline] (8.625 s) : 0, 8624941
Agent [candidate] (1.086 s) : 0, 1086482
Total [candidate] (8.596 s) : 0, 8596449
section iast
Agent [baseline] (1.207 s) : 0, 1207223
Total [baseline] (9.146 s) : 0, 9146122
Agent [candidate] (1.209 s) : 0, 1208829
Total [candidate] (9.17 s) : 0, 9170063
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.215 s) : 0, 1214505
Total [baseline] (9.106 s) : 0, 9106440
Agent [candidate] (1.21 s) : 0, 1209611
Total [candidate] (9.134 s) : 0, 9134225
section iast_TELEMETRY_OFF
Agent [baseline] (1.205 s) : 0, 1204719
Total [baseline] (9.13 s) : 0, 9130007
Agent [candidate] (1.213 s) : 0, 1213371
Total [candidate] (9.142 s) : 0, 9141858
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.089 s -
Agent iast 1.207 s 117.94 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.215 s 125.223 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.205 s 115.437 ms (10.6%)
Total tracing 8.625 s -
Total iast 9.146 s 521.181 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.106 s 481.5 ms (5.6%)
Total iast_TELEMETRY_OFF 9.13 s 505.066 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent iast 1.209 s 122.347 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.21 s 123.129 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.213 s 126.889 ms (11.7%)
Total tracing 8.596 s -
Total iast 9.17 s 573.614 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.134 s 537.776 ms (6.3%)
Total iast_TELEMETRY_OFF 9.142 s 545.409 ms (6.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~51013d5de1, baseline=1.42.0-SNAPSHOT~104a441d0a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.095 ms) : 0, 693095
BytebuddyAgent [candidate] (689.23 ms) : 0, 689230
GlobalTracer [baseline] (316.766 ms) : 0, 316766
GlobalTracer [candidate] (316.563 ms) : 0, 316563
AppSec [baseline] (54.362 ms) : 0, 54362
AppSec [candidate] (55.083 ms) : 0, 55083
Remote Config [baseline] (666.362 µs) : 0, 666
Remote Config [candidate] (672.037 µs) : 0, 672
Telemetry [baseline] (10.543 ms) : 0, 10543
Telemetry [candidate] (11.156 ms) : 0, 11156
section iast
BytebuddyAgent [baseline] (803.625 ms) : 0, 803625
BytebuddyAgent [candidate] (803.924 ms) : 0, 803924
GlobalTracer [baseline] (303.911 ms) : 0, 303911
GlobalTracer [candidate] (305.288 ms) : 0, 305288
AppSec [baseline] (56.289 ms) : 0, 56289
AppSec [candidate] (58.027 ms) : 0, 58027
IAST [baseline] (21.745 ms) : 0, 21745
IAST [candidate] (19.796 ms) : 0, 19796
Remote Config [baseline] (611.372 µs) : 0, 611
Remote Config [candidate] (610.363 µs) : 0, 610
Telemetry [baseline] (7.285 ms) : 0, 7285
Telemetry [candidate] (7.349 ms) : 0, 7349
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (810.158 ms) : 0, 810158
BytebuddyAgent [candidate] (804.58 ms) : 0, 804580
GlobalTracer [baseline] (304.712 ms) : 0, 304712
GlobalTracer [candidate] (304.709 ms) : 0, 304709
AppSec [baseline] (57.765 ms) : 0, 57765
AppSec [candidate] (57.449 ms) : 0, 57449
IAST [baseline] (19.995 ms) : 0, 19995
IAST [candidate] (20.961 ms) : 0, 20961
Remote Config [baseline] (621.989 µs) : 0, 622
Remote Config [candidate] (625.263 µs) : 0, 625
Telemetry [baseline] (7.4 ms) : 0, 7400
Telemetry [candidate] (7.478 ms) : 0, 7478
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.758 ms) : 0, 800758
BytebuddyAgent [candidate] (807.082 ms) : 0, 807082
GlobalTracer [baseline] (305.29 ms) : 0, 305290
GlobalTracer [candidate] (306.796 ms) : 0, 306796
AppSec [baseline] (57.577 ms) : 0, 57577
AppSec [candidate] (57.363 ms) : 0, 57363
IAST [baseline] (19.434 ms) : 0, 19434
IAST [candidate] (20.363 ms) : 0, 20363
Remote Config [baseline] (592.552 µs) : 0, 593
Remote Config [candidate] (596.669 µs) : 0, 597
Telemetry [baseline] (7.306 ms) : 0, 7306
Telemetry [candidate] (7.321 ms) : 0, 7321
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-31T09:29:22 2024-10-31T09:36:19
git_branch master jpbempel/compress-symdb-payloads
git_commit_date 1730315410 1730366278
git_commit_sha 104a441 51013d5
release_version 1.42.0-SNAPSHOT~104a441d0a 1.42.0-SNAPSHOT~51013d5de1
start_time 2024-10-31T09:29:08 2024-10-31T09:36:06
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730367732 1730367732
ci_job_id 691126098 691126098
ci_pipeline_id 47931801 47931801
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~51013d5de1, baseline=1.42.0-SNAPSHOT~104a441d0a
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.305 µs) : 356, 397
.   : milestone, 376,
iast (491.292 µs) : 470, 512
.   : milestone, 491,
iast_FULL (649.873 µs) : 628, 672
.   : milestone, 650,
iast_GLOBAL (525.007 µs) : 504, 546
.   : milestone, 525,
iast_HARDCODED_SECRET_DISABLED (498.104 µs) : 476, 520
.   : milestone, 498,
iast_INACTIVE (458.969 µs) : 437, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (489.646 µs) : 468, 511
.   : milestone, 490,
tracing (448.773 µs) : 428, 469
.   : milestone, 449,
section candidate
no_agent (374.963 µs) : 355, 395
.   : milestone, 375,
iast (493.703 µs) : 472, 515
.   : milestone, 494,
iast_FULL (649.598 µs) : 628, 671
.   : milestone, 650,
iast_GLOBAL (527.588 µs) : 505, 550
.   : milestone, 528,
iast_HARDCODED_SECRET_DISABLED (492.334 µs) : 471, 513
.   : milestone, 492,
iast_INACTIVE (458.022 µs) : 437, 479
.   : milestone, 458,
iast_TELEMETRY_OFF (483.735 µs) : 463, 505
.   : milestone, 484,
tracing (460.624 µs) : 440, 482
.   : milestone, 461,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.305 µs [355.795 µs, 396.816 µs] -
iast 491.292 µs [470.129 µs, 512.456 µs] 114.987 µs (30.6%)
iast_FULL 649.873 µs [628.16 µs, 671.586 µs] 273.568 µs (72.7%)
iast_GLOBAL 525.007 µs [503.588 µs, 546.425 µs] 148.702 µs (39.5%)
iast_HARDCODED_SECRET_DISABLED 498.104 µs [476.45 µs, 519.758 µs] 121.799 µs (32.4%)
iast_INACTIVE 458.969 µs [437.47 µs, 480.469 µs] 82.664 µs (22.0%)
iast_TELEMETRY_OFF 489.646 µs [468.247 µs, 511.046 µs] 113.341 µs (30.1%)
tracing 448.773 µs [428.482 µs, 469.065 µs] 72.468 µs (19.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.963 µs [354.743 µs, 395.183 µs] -
iast 493.703 µs [472.266 µs, 515.14 µs] 118.74 µs (31.7%)
iast_FULL 649.598 µs [628.3 µs, 670.897 µs] 274.635 µs (73.2%)
iast_GLOBAL 527.588 µs [505.165 µs, 550.01 µs] 152.624 µs (40.7%)
iast_HARDCODED_SECRET_DISABLED 492.334 µs [471.193 µs, 513.474 µs] 117.37 µs (31.3%)
iast_INACTIVE 458.022 µs [437.052 µs, 478.993 µs] 83.059 µs (22.2%)
iast_TELEMETRY_OFF 483.735 µs [462.587 µs, 504.883 µs] 108.772 µs (29.0%)
tracing 460.624 µs [439.616 µs, 481.631 µs] 85.661 µs (22.8%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~51013d5de1, baseline=1.42.0-SNAPSHOT~104a441d0a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.354 ms) : 1335, 1373
.   : milestone, 1354,
appsec (1.725 ms) : 1701, 1749
.   : milestone, 1725,
appsec_no_iast (1.727 ms) : 1703, 1752
.   : milestone, 1727,
iast (1.502 ms) : 1479, 1525
.   : milestone, 1502,
profiling (1.532 ms) : 1508, 1556
.   : milestone, 1532,
tracing (1.497 ms) : 1469, 1524
.   : milestone, 1497,
section candidate
no_agent (1.36 ms) : 1340, 1380
.   : milestone, 1360,
appsec (1.748 ms) : 1725, 1772
.   : milestone, 1748,
appsec_no_iast (1.752 ms) : 1725, 1778
.   : milestone, 1752,
iast (1.496 ms) : 1474, 1519
.   : milestone, 1496,
profiling (1.521 ms) : 1499, 1543
.   : milestone, 1521,
tracing (1.48 ms) : 1455, 1505
.   : milestone, 1480,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.373 ms] -
appsec 1.725 ms [1.701 ms, 1.749 ms] 371.04 µs (27.4%)
appsec_no_iast 1.727 ms [1.703 ms, 1.752 ms] 373.425 µs (27.6%)
iast 1.502 ms [1.479 ms, 1.525 ms] 148.308 µs (11.0%)
profiling 1.532 ms [1.508 ms, 1.556 ms] 178.547 µs (13.2%)
tracing 1.497 ms [1.469 ms, 1.524 ms] 142.645 µs (10.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.34 ms, 1.38 ms] -
appsec 1.748 ms [1.725 ms, 1.772 ms] 387.825 µs (28.5%)
appsec_no_iast 1.752 ms [1.725 ms, 1.778 ms] 391.339 µs (28.8%)
iast 1.496 ms [1.474 ms, 1.519 ms] 135.73 µs (10.0%)
profiling 1.521 ms [1.499 ms, 1.543 ms] 160.396 µs (11.8%)
tracing 1.48 ms [1.455 ms, 1.505 ms] 119.684 µs (8.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/compress-symdb-payloads
git_commit_date 1730315410 1730366278
git_commit_sha 104a441 51013d5
release_version 1.42.0-SNAPSHOT~104a441d0a 1.42.0-SNAPSHOT~51013d5de1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1730368255 1730368255
ci_job_id 691126099 691126099
ci_pipeline_id 47931801 47931801
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~51013d5de1, baseline=1.42.0-SNAPSHOT~104a441d0a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
.   : milestone, 1482,
appsec (2.352 ms) : 2311, 2394
.   : milestone, 2352,
iast (2.095 ms) : 2043, 2148
.   : milestone, 2095,
iast_GLOBAL (2.128 ms) : 2075, 2180
.   : milestone, 2128,
profiling (1.955 ms) : 1912, 1998
.   : milestone, 1955,
tracing (1.935 ms) : 1895, 1976
.   : milestone, 1935,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.35 ms) : 2308, 2393
.   : milestone, 2350,
iast (2.092 ms) : 2040, 2144
.   : milestone, 2092,
iast_GLOBAL (2.131 ms) : 2078, 2183
.   : milestone, 2131,
profiling (1.949 ms) : 1908, 1991
.   : milestone, 1949,
tracing (1.919 ms) : 1880, 1959
.   : milestone, 1919,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.482 ms [1.47 ms, 1.493 ms] -
appsec 2.352 ms [2.311 ms, 2.394 ms] 870.424 µs (58.7%)
iast 2.095 ms [2.043 ms, 2.148 ms] 613.466 µs (41.4%)
iast_GLOBAL 2.128 ms [2.075 ms, 2.18 ms] 645.98 µs (43.6%)
profiling 1.955 ms [1.912 ms, 1.998 ms] 473.0 µs (31.9%)
tracing 1.935 ms [1.895 ms, 1.976 ms] 453.789 µs (30.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.459 ms, 1.482 ms] -
appsec 2.35 ms [2.308 ms, 2.393 ms] 879.745 µs (59.8%)
iast 2.092 ms [2.04 ms, 2.144 ms] 621.229 µs (42.2%)
iast_GLOBAL 2.131 ms [2.078 ms, 2.183 ms] 660.217 µs (44.9%)
profiling 1.949 ms [1.908 ms, 1.991 ms] 478.795 µs (32.6%)
tracing 1.919 ms [1.88 ms, 1.959 ms] 448.872 µs (30.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~51013d5de1, baseline=1.42.0-SNAPSHOT~104a441d0a
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.73 s) : 15730000, 15730000
.   : milestone, 15730000,
appsec (15.352 s) : 15352000, 15352000
.   : milestone, 15352000,
iast (18.922 s) : 18922000, 18922000
.   : milestone, 18922000,
iast_GLOBAL (18.026 s) : 18026000, 18026000
.   : milestone, 18026000,
profiling (15.798 s) : 15798000, 15798000
.   : milestone, 15798000,
tracing (15.207 s) : 15207000, 15207000
.   : milestone, 15207000,
section candidate
no_agent (15.754 s) : 15754000, 15754000
.   : milestone, 15754000,
appsec (15.291 s) : 15291000, 15291000
.   : milestone, 15291000,
iast (19.194 s) : 19194000, 19194000
.   : milestone, 19194000,
iast_GLOBAL (17.913 s) : 17913000, 17913000
.   : milestone, 17913000,
profiling (15.554 s) : 15554000, 15554000
.   : milestone, 15554000,
tracing (15.221 s) : 15221000, 15221000
.   : milestone, 15221000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.73 s [15.73 s, 15.73 s] -
appsec 15.352 s [15.352 s, 15.352 s] -378.0 ms (-2.4%)
iast 18.922 s [18.922 s, 18.922 s] 3.192 s (20.3%)
iast_GLOBAL 18.026 s [18.026 s, 18.026 s] 2.296 s (14.6%)
profiling 15.798 s [15.798 s, 15.798 s] 68.0 ms (0.4%)
tracing 15.207 s [15.207 s, 15.207 s] -523.0 ms (-3.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.754 s [15.754 s, 15.754 s] -
appsec 15.291 s [15.291 s, 15.291 s] -463.0 ms (-2.9%)
iast 19.194 s [19.194 s, 19.194 s] 3.44 s (21.8%)
iast_GLOBAL 17.913 s [17.913 s, 17.913 s] 2.159 s (13.7%)
profiling 15.554 s [15.554 s, 15.554 s] -200.0 ms (-1.3%)
tracing 15.221 s [15.221 s, 15.221 s] -533.0 ms (-3.4%)

evanchooly
evanchooly approved these changes Oct 31, 2024
View reviewed changes
dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/sink/SymbolSink.java
if (isCompressed) {
payload = compressPayload(jsonBytes);
}
if (payload == null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two ifs are a bit confusing. will compressPayload ever return a null even if compressed is true?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compressPayload returns null on IOException

@jpbempel jpbempel merged commit f0b47c0 into master Oct 31, 2024
100 of 103 checks passed
@jpbempel jpbempel deleted the jpbempel/compress-symdb-payloads branch October 31, 2024 16:39
@github-actions github-actions bot added this to the 1.42.0 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanchooly evanchooly evanchooly approved these changes

@shatzi shatzi Awaiting requested review from shatzi shatzi is a code owner automatically assigned from DataDog/debugger-java

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @evanchooly