Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DBM_TRACE_INJECTED tag to SQL Server #7849

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Add DBM_TRACE_INJECTED tag to SQL Server #7849

merged 3 commits into from
Oct 29, 2024

Conversation

nenadnoveljic
Copy link
Contributor

@nenadnoveljic nenadnoveljic commented Oct 29, 2024 •
edited
Loading

What Does This Do

Add _dd.dbm_trace_injected tag to SQL Server spans.

Motivation

Front end uses the tag to display the DBM information in APM trace panel.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@nenadnoveljic nenadnoveljic added the comp: database Database Monitoring label Oct 29, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 29, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nenadnoveljic/dbm-trace-injected-sqlserver
git_commit_date 1730205460 1730218957
git_commit_sha 9d6a07b 74e7b48
release_version 1.42.0-SNAPSHOT~9d6a07b28b 1.42.0-SNAPSHOT~74e7b48bc7
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730221343 1730221343
ci_job_id 688496370 688496370
ci_pipeline_id 47740647 47740647
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~74e7b48bc7, baseline=1.42.0-SNAPSHOT~9d6a07b28b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1084957
Total [baseline] (8.624 s) : 0, 8623744
Agent [candidate] (1.09 s) : 0, 1090363
Total [candidate] (8.687 s) : 0, 8686806
section iast
Agent [baseline] (1.214 s) : 0, 1214353
Total [baseline] (9.194 s) : 0, 9193894
Agent [candidate] (1.224 s) : 0, 1224308
Total [candidate] (9.176 s) : 0, 9175763
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.208 s) : 0, 1208078
Total [baseline] (9.134 s) : 0, 9134330
Agent [candidate] (1.216 s) : 0, 1216303
Total [candidate] (9.224 s) : 0, 9223651
section iast_TELEMETRY_OFF
Agent [baseline] (1.203 s) : 0, 1203278
Total [baseline] (9.173 s) : 0, 9173227
Agent [candidate] (1.205 s) : 0, 1204699
Total [candidate] (9.204 s) : 0, 9204138
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent iast 1.214 s 129.396 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.208 s 123.121 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.203 s 118.321 ms (10.9%)
Total tracing 8.624 s -
Total iast 9.194 s 570.15 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.134 s 510.586 ms (5.9%)
Total iast_TELEMETRY_OFF 9.173 s 549.483 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.09 s -
Agent iast 1.224 s 133.945 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.216 s 125.94 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.205 s 114.336 ms (10.5%)
Total tracing 8.687 s -
Total iast 9.176 s 488.957 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.224 s 536.845 ms (6.2%)
Total iast_TELEMETRY_OFF 9.204 s 517.332 ms (6.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~74e7b48bc7, baseline=1.42.0-SNAPSHOT~9d6a07b28b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.819 ms) : 0, 688819
BytebuddyAgent [candidate] (693.075 ms) : 0, 693075
GlobalTracer [baseline] (317.974 ms) : 0, 317974
GlobalTracer [candidate] (318.847 ms) : 0, 318847
AppSec [baseline] (54.433 ms) : 0, 54433
AppSec [candidate] (55.446 ms) : 0, 55446
Remote Config [baseline] (686.17 µs) : 0, 686
Remote Config [candidate] (681.429 µs) : 0, 681
Telemetry [baseline] (9.259 ms) : 0, 9259
Telemetry [candidate] (8.454 ms) : 0, 8454
section iast
BytebuddyAgent [baseline] (808.461 ms) : 0, 808461
BytebuddyAgent [candidate] (814.774 ms) : 0, 814774
GlobalTracer [baseline] (306.33 ms) : 0, 306330
GlobalTracer [candidate] (308.377 ms) : 0, 308377
AppSec [baseline] (57.588 ms) : 0, 57588
AppSec [candidate] (58.131 ms) : 0, 58131
IAST [baseline] (20.02 ms) : 0, 20020
IAST [candidate] (20.976 ms) : 0, 20976
Remote Config [baseline] (616.181 µs) : 0, 616
Remote Config [candidate] (617.277 µs) : 0, 617
Telemetry [baseline] (7.452 ms) : 0, 7452
Telemetry [candidate] (7.479 ms) : 0, 7479
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (803.785 ms) : 0, 803785
BytebuddyAgent [candidate] (808.641 ms) : 0, 808641
GlobalTracer [baseline] (304.896 ms) : 0, 304896
GlobalTracer [candidate] (306.4 ms) : 0, 306400
AppSec [baseline] (56.85 ms) : 0, 56850
AppSec [candidate] (58.846 ms) : 0, 58846
IAST [baseline] (20.703 ms) : 0, 20703
IAST [candidate] (20.28 ms) : 0, 20280
Remote Config [baseline] (610.001 µs) : 0, 610
Remote Config [candidate] (631.828 µs) : 0, 632
Telemetry [baseline] (7.421 ms) : 0, 7421
Telemetry [candidate] (7.625 ms) : 0, 7625
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.455 ms) : 0, 799455
BytebuddyAgent [candidate] (799.656 ms) : 0, 799656
GlobalTracer [baseline] (304.171 ms) : 0, 304171
GlobalTracer [candidate] (305.265 ms) : 0, 305265
AppSec [baseline] (58.093 ms) : 0, 58093
AppSec [candidate] (58.311 ms) : 0, 58311
IAST [baseline] (19.737 ms) : 0, 19737
IAST [candidate] (19.708 ms) : 0, 19708
Remote Config [baseline] (612.035 µs) : 0, 612
Remote Config [candidate] (612.058 µs) : 0, 612
Telemetry [baseline] (7.407 ms) : 0, 7407
Telemetry [candidate] (7.353 ms) : 0, 7353
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~74e7b48bc7, baseline=1.42.0-SNAPSHOT~9d6a07b28b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1093213
Total [baseline] (10.511 s) : 0, 10510763
Agent [candidate] (1.084 s) : 0, 1084348
Total [candidate] (10.438 s) : 0, 10437736
section appsec
Agent [baseline] (1.216 s) : 0, 1215628
Total [baseline] (10.666 s) : 0, 10665707
Agent [candidate] (1.22 s) : 0, 1220396
Total [candidate] (10.694 s) : 0, 10693990
section iast
Agent [baseline] (1.208 s) : 0, 1208447
Total [baseline] (10.976 s) : 0, 10976473
Agent [candidate] (1.208 s) : 0, 1208376
Total [candidate] (10.952 s) : 0, 10952403
section profiling
Agent [baseline] (1.28 s) : 0, 1280070
Total [baseline] (10.781 s) : 0, 10781003
Agent [candidate] (1.281 s) : 0, 1280675
Total [candidate] (10.787 s) : 0, 10786712
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.093 s -
Agent appsec 1.216 s 122.415 ms (11.2%)
Agent iast 1.208 s 115.233 ms (10.5%)
Agent profiling 1.28 s 186.856 ms (17.1%)
Total tracing 10.511 s -
Total appsec 10.666 s 154.944 ms (1.5%)
Total iast 10.976 s 465.71 ms (4.4%)
Total profiling 10.781 s 270.24 ms (2.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent appsec 1.22 s 136.049 ms (12.5%)
Agent iast 1.208 s 124.029 ms (11.4%)
Agent profiling 1.281 s 196.328 ms (18.1%)
Total tracing 10.438 s -
Total appsec 10.694 s 256.254 ms (2.5%)
Total iast 10.952 s 514.667 ms (4.9%)
Total profiling 10.787 s 348.976 ms (3.3%) 
gantt
    title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~74e7b48bc7, baseline=1.42.0-SNAPSHOT~9d6a07b28b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.067 ms) : 0, 695067
BytebuddyAgent [candidate] (687.849 ms) : 0, 687849
GlobalTracer [baseline] (318.398 ms) : 0, 318398
GlobalTracer [candidate] (316.909 ms) : 0, 316909
AppSec [baseline] (54.447 ms) : 0, 54447
AppSec [candidate] (55.262 ms) : 0, 55262
Remote Config [baseline] (697.069 µs) : 0, 697
Remote Config [candidate] (660.917 µs) : 0, 661
Telemetry [baseline] (10.635 ms) : 0, 10635
Telemetry [candidate] (9.836 ms) : 0, 9836
section appsec
BytebuddyAgent [baseline] (703.621 ms) : 0, 703621
BytebuddyAgent [candidate] (706.685 ms) : 0, 706685
GlobalTracer [baseline] (313.306 ms) : 0, 313306
GlobalTracer [candidate] (314.539 ms) : 0, 314539
AppSec [baseline] (165.945 ms) : 0, 165945
AppSec [candidate] (165.53 ms) : 0, 165530
IAST [baseline] (19.358 ms) : 0, 19358
IAST [candidate] (20.784 ms) : 0, 20784
Remote Config [baseline] (641.18 µs) : 0, 641
Remote Config [candidate] (637.727 µs) : 0, 638
Telemetry [baseline] (8.692 ms) : 0, 8692
Telemetry [candidate] (8.778 ms) : 0, 8778
section iast
BytebuddyAgent [baseline] (804.508 ms) : 0, 804508
BytebuddyAgent [candidate] (803.02 ms) : 0, 803020
GlobalTracer [baseline] (304.913 ms) : 0, 304913
GlobalTracer [candidate] (305.279 ms) : 0, 305279
AppSec [baseline] (56.585 ms) : 0, 56585
AppSec [candidate] (56.607 ms) : 0, 56607
IAST [baseline] (20.631 ms) : 0, 20631
IAST [candidate] (21.611 ms) : 0, 21611
Remote Config [baseline] (617.998 µs) : 0, 618
Remote Config [candidate] (691.84 µs) : 0, 692
Telemetry [baseline] (7.389 ms) : 0, 7389
Telemetry [candidate] (7.346 ms) : 0, 7346
section profiling
BytebuddyAgent [baseline] (681.337 ms) : 0, 681337
BytebuddyAgent [candidate] (681.439 ms) : 0, 681439
GlobalTracer [baseline] (400.296 ms) : 0, 400296
GlobalTracer [candidate] (399.543 ms) : 0, 399543
AppSec [baseline] (54.557 ms) : 0, 54557
AppSec [candidate] (55.407 ms) : 0, 55407
Remote Config [baseline] (666.159 µs) : 0, 666
Remote Config [candidate] (665.449 µs) : 0, 665
Telemetry [baseline] (12.558 ms) : 0, 12558
Telemetry [candidate] (13.366 ms) : 0, 13366
ProfilingAgent [baseline] (91.666 ms) : 0, 91666
ProfilingAgent [candidate] (91.238 ms) : 0, 91238
Profiling [baseline] (91.69 ms) : 0, 91690
Profiling [candidate] (91.261 ms) : 0, 91261
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-29T16:34:47 2024-10-29T16:41:43
git_branch master nenadnoveljic/dbm-trace-injected-sqlserver
git_commit_date 1730205460 1730218957
git_commit_sha 9d6a07b 74e7b48
release_version 1.42.0-SNAPSHOT~9d6a07b28b 1.42.0-SNAPSHOT~74e7b48bc7
start_time 2024-10-29T16:34:34 2024-10-29T16:41:29
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730220454 1730220454
ci_job_id 688496373 688496373
ci_pipeline_id 47740647 47740647
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~74e7b48bc7, baseline=1.42.0-SNAPSHOT~9d6a07b28b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.365 ms) : 1344, 1386
.   : milestone, 1365,
appsec (1.721 ms) : 1695, 1746
.   : milestone, 1721,
appsec_no_iast (1.738 ms) : 1714, 1762
.   : milestone, 1738,
iast (1.485 ms) : 1462, 1507
.   : milestone, 1485,
profiling (1.482 ms) : 1460, 1504
.   : milestone, 1482,
tracing (1.471 ms) : 1447, 1495
.   : milestone, 1471,
section candidate
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.75 ms) : 1726, 1775
.   : milestone, 1750,
appsec_no_iast (1.726 ms) : 1701, 1751
.   : milestone, 1726,
iast (1.495 ms) : 1472, 1517
.   : milestone, 1495,
profiling (1.481 ms) : 1458, 1504
.   : milestone, 1481,
tracing (1.484 ms) : 1460, 1508
.   : milestone, 1484,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.365 ms [1.344 ms, 1.386 ms] -
appsec 1.721 ms [1.695 ms, 1.746 ms] 355.237 µs (26.0%)
appsec_no_iast 1.738 ms [1.714 ms, 1.762 ms] 372.155 µs (27.3%)
iast 1.485 ms [1.462 ms, 1.507 ms] 119.16 µs (8.7%)
profiling 1.482 ms [1.46 ms, 1.504 ms] 116.438 µs (8.5%)
tracing 1.471 ms [1.447 ms, 1.495 ms] 105.719 µs (7.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.362 ms] -
appsec 1.75 ms [1.726 ms, 1.775 ms] 407.407 µs (30.3%)
appsec_no_iast 1.726 ms [1.701 ms, 1.751 ms] 383.329 µs (28.5%)
iast 1.495 ms [1.472 ms, 1.517 ms] 152.112 µs (11.3%)
profiling 1.481 ms [1.458 ms, 1.504 ms] 138.287 µs (10.3%)
tracing 1.484 ms [1.46 ms, 1.508 ms] 140.857 µs (10.5%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~74e7b48bc7, baseline=1.42.0-SNAPSHOT~9d6a07b28b
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.623 µs) : 360, 399
.   : milestone, 380,
iast (491.707 µs) : 470, 513
.   : milestone, 492,
iast_FULL (653.977 µs) : 633, 675
.   : milestone, 654,
iast_GLOBAL (524.425 µs) : 502, 547
.   : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (496.352 µs) : 475, 518
.   : milestone, 496,
iast_INACTIVE (456.235 µs) : 435, 478
.   : milestone, 456,
iast_TELEMETRY_OFF (478.157 µs) : 457, 499
.   : milestone, 478,
tracing (450.786 µs) : 430, 472
.   : milestone, 451,
section candidate
no_agent (368.713 µs) : 349, 388
.   : milestone, 369,
iast (494.337 µs) : 473, 516
.   : milestone, 494,
iast_FULL (645.308 µs) : 624, 667
.   : milestone, 645,
iast_GLOBAL (512.545 µs) : 491, 534
.   : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (497.919 µs) : 476, 520
.   : milestone, 498,
iast_INACTIVE (452.075 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (478.036 µs) : 457, 499
.   : milestone, 478,
tracing (446.835 µs) : 426, 467
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.623 µs [360.314 µs, 398.932 µs] -
iast 491.707 µs [470.198 µs, 513.216 µs] 112.084 µs (29.5%)
iast_FULL 653.977 µs [632.635 µs, 675.319 µs] 274.354 µs (72.3%)
iast_GLOBAL 524.425 µs [502.185 µs, 546.665 µs] 144.802 µs (38.1%)
iast_HARDCODED_SECRET_DISABLED 496.352 µs [474.656 µs, 518.048 µs] 116.729 µs (30.7%)
iast_INACTIVE 456.235 µs [434.905 µs, 477.565 µs] 76.612 µs (20.2%)
iast_TELEMETRY_OFF 478.157 µs [456.964 µs, 499.35 µs] 98.534 µs (26.0%)
tracing 450.786 µs [429.719 µs, 471.853 µs] 71.163 µs (18.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.713 µs [349.073 µs, 388.353 µs] -
iast 494.337 µs [472.666 µs, 516.008 µs] 125.624 µs (34.1%)
iast_FULL 645.308 µs [623.98 µs, 666.636 µs] 276.594 µs (75.0%)
iast_GLOBAL 512.545 µs [491.313 µs, 533.778 µs] 143.832 µs (39.0%)
iast_HARDCODED_SECRET_DISABLED 497.919 µs [476.33 µs, 519.507 µs] 129.205 µs (35.0%)
iast_INACTIVE 452.075 µs [430.766 µs, 473.383 µs] 83.361 µs (22.6%)
iast_TELEMETRY_OFF 478.036 µs [456.691 µs, 499.381 µs] 109.322 µs (29.6%)
tracing 446.835 µs [426.177 µs, 467.494 µs] 78.122 µs (21.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nenadnoveljic/dbm-trace-injected-sqlserver
git_commit_date 1730205460 1730218957
git_commit_sha 9d6a07b 74e7b48
release_version 1.42.0-SNAPSHOT~9d6a07b28b 1.42.0-SNAPSHOT~74e7b48bc7
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1730220866 1730220866
ci_job_id 688496375 688496375
ci_pipeline_id 47740647 47740647
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~74e7b48bc7, baseline=1.42.0-SNAPSHOT~9d6a07b28b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1479
.   : milestone, 1467,
appsec (2.324 ms) : 2282, 2365
.   : milestone, 2324,
iast (2.073 ms) : 2020, 2125
.   : milestone, 2073,
iast_GLOBAL (2.114 ms) : 2062, 2166
.   : milestone, 2114,
profiling (1.934 ms) : 1891, 1978
.   : milestone, 1934,
tracing (1.914 ms) : 1874, 1954
.   : milestone, 1914,
section candidate
no_agent (1.466 ms) : 1455, 1478
.   : milestone, 1466,
appsec (2.335 ms) : 2294, 2376
.   : milestone, 2335,
iast (2.078 ms) : 2026, 2130
.   : milestone, 2078,
iast_GLOBAL (2.103 ms) : 2051, 2155
.   : milestone, 2103,
profiling (1.932 ms) : 1891, 1973
.   : milestone, 1932,
tracing (1.916 ms) : 1876, 1955
.   : milestone, 1916,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.479 ms] -
appsec 2.324 ms [2.282 ms, 2.365 ms] 856.583 µs (58.4%)
iast 2.073 ms [2.02 ms, 2.125 ms] 605.523 µs (41.3%)
iast_GLOBAL 2.114 ms [2.062 ms, 2.166 ms] 646.958 µs (44.1%)
profiling 1.934 ms [1.891 ms, 1.978 ms] 467.232 µs (31.8%)
tracing 1.914 ms [1.874 ms, 1.954 ms] 446.566 µs (30.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.478 ms] -
appsec 2.335 ms [2.294 ms, 2.376 ms] 869.18 µs (59.3%)
iast 2.078 ms [2.026 ms, 2.13 ms] 611.796 µs (41.7%)
iast_GLOBAL 2.103 ms [2.051 ms, 2.155 ms] 636.819 µs (43.4%)
profiling 1.932 ms [1.891 ms, 1.973 ms] 466.119 µs (31.8%)
tracing 1.916 ms [1.876 ms, 1.955 ms] 449.433 µs (30.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~74e7b48bc7, baseline=1.42.0-SNAPSHOT~9d6a07b28b
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.032 s) : 15032000, 15032000
.   : milestone, 15032000,
appsec (15.057 s) : 15057000, 15057000
.   : milestone, 15057000,
iast (18.61 s) : 18610000, 18610000
.   : milestone, 18610000,
iast_GLOBAL (18.002 s) : 18002000, 18002000
.   : milestone, 18002000,
profiling (15.106 s) : 15106000, 15106000
.   : milestone, 15106000,
tracing (15.276 s) : 15276000, 15276000
.   : milestone, 15276000,
section candidate
no_agent (15.052 s) : 15052000, 15052000
.   : milestone, 15052000,
appsec (15.411 s) : 15411000, 15411000
.   : milestone, 15411000,
iast (19.013 s) : 19013000, 19013000
.   : milestone, 19013000,
iast_GLOBAL (17.947 s) : 17947000, 17947000
.   : milestone, 17947000,
profiling (15.006 s) : 15006000, 15006000
.   : milestone, 15006000,
tracing (15.27 s) : 15270000, 15270000
.   : milestone, 15270000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.032 s [15.032 s, 15.032 s] -
appsec 15.057 s [15.057 s, 15.057 s] 25.0 ms (0.2%)
iast 18.61 s [18.61 s, 18.61 s] 3.578 s (23.8%)
iast_GLOBAL 18.002 s [18.002 s, 18.002 s] 2.97 s (19.8%)
profiling 15.106 s [15.106 s, 15.106 s] 74.0 ms (0.5%)
tracing 15.276 s [15.276 s, 15.276 s] 244.0 ms (1.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.052 s [15.052 s, 15.052 s] -
appsec 15.411 s [15.411 s, 15.411 s] 359.0 ms (2.4%)
iast 19.013 s [19.013 s, 19.013 s] 3.961 s (26.3%)
iast_GLOBAL 17.947 s [17.947 s, 17.947 s] 2.895 s (19.2%)
profiling 15.006 s [15.006 s, 15.006 s] -46.0 ms (-0.3%)
tracing 15.27 s [15.27 s, 15.27 s] 218.0 ms (1.4%)

@nenadnoveljic
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 29, 2024

❌ MergeQueue

This PR is a draft

If you need support, contact us on Slack #devflow with those details!

@nenadnoveljic nenadnoveljic marked this pull request as ready for review October 29, 2024 17:10
@nenadnoveljic nenadnoveljic requested a review from a team as a code owner October 29, 2024 17:10
@nenadnoveljic nenadnoveljic merged commit e3d43d5 into master Oct 29, 2024
104 checks passed
@nenadnoveljic nenadnoveljic deleted the nenadnoveljic/dbm-trace-injected-sqlserver branch October 29, 2024 17:11
@github-actions github-actions bot added this to the 1.42.0 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vandonr vandonr Awaiting requested review from vandonr

Assignees
No one assigned
Labels
comp: database Database Monitoring
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nenadnoveljic @vandonr