-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated ASM rules to 1.13.2 #7844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~1687fe574f, baseline=1.42.0-SNAPSHOT~b2332408b0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084352
Total [baseline] (8.602 s) : 0, 8601614
Agent [candidate] (1.089 s) : 0, 1089197
Total [candidate] (8.628 s) : 0, 8628042
section iast
Agent [baseline] (1.205 s) : 0, 1204943
Total [baseline] (9.107 s) : 0, 9106572
Agent [candidate] (1.205 s) : 0, 1204782
Total [candidate] (9.147 s) : 0, 9146718
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.213 s) : 0, 1213150
Total [baseline] (9.096 s) : 0, 9096217
Agent [candidate] (1.205 s) : 0, 1204813
Total [candidate] (9.116 s) : 0, 9115649
section iast_TELEMETRY_OFF
Agent [baseline] (1.203 s) : 0, 1202544
Total [baseline] (9.131 s) : 0, 9130815
Agent [candidate] (1.202 s) : 0, 1202387
Total [candidate] (9.118 s) : 0, 9118209
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~1687fe574f, baseline=1.42.0-SNAPSHOT~b2332408b0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.758 ms) : 0, 688758
BytebuddyAgent [candidate] (692.506 ms) : 0, 692506
GlobalTracer [baseline] (316.101 ms) : 0, 316101
GlobalTracer [candidate] (317.385 ms) : 0, 317385
AppSec [baseline] (55.012 ms) : 0, 55012
AppSec [candidate] (54.782 ms) : 0, 54782
Remote Config [baseline] (669.976 µs) : 0, 670
Remote Config [candidate] (671.698 µs) : 0, 672
Telemetry [baseline] (10.051 ms) : 0, 10051
Telemetry [candidate] (10.006 ms) : 0, 10006
section iast
BytebuddyAgent [baseline] (802.072 ms) : 0, 802072
BytebuddyAgent [candidate] (801.945 ms) : 0, 801945
GlobalTracer [baseline] (302.945 ms) : 0, 302945
GlobalTracer [candidate] (303.547 ms) : 0, 303547
AppSec [baseline] (57.368 ms) : 0, 57368
AppSec [candidate] (57.34 ms) : 0, 57340
Remote Config [baseline] (612.043 µs) : 0, 612
Remote Config [candidate] (620.346 µs) : 0, 620
Telemetry [baseline] (7.411 ms) : 0, 7411
Telemetry [candidate] (7.486 ms) : 0, 7486
IAST [baseline] (20.803 ms) : 0, 20803
IAST [candidate] (20.071 ms) : 0, 20071
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.468 ms) : 0, 807468
BytebuddyAgent [candidate] (801.559 ms) : 0, 801559
GlobalTracer [baseline] (305.328 ms) : 0, 305328
GlobalTracer [candidate] (303.705 ms) : 0, 303705
AppSec [baseline] (58.3 ms) : 0, 58300
AppSec [candidate] (57.066 ms) : 0, 57066
Remote Config [baseline] (620.627 µs) : 0, 621
Remote Config [candidate] (681.764 µs) : 0, 682
Telemetry [baseline] (7.552 ms) : 0, 7552
Telemetry [candidate] (7.477 ms) : 0, 7477
IAST [baseline] (20.044 ms) : 0, 20044
IAST [candidate] (20.601 ms) : 0, 20601
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.365 ms) : 0, 799365
BytebuddyAgent [candidate] (799.642 ms) : 0, 799642
GlobalTracer [baseline] (303.522 ms) : 0, 303522
GlobalTracer [candidate] (303.498 ms) : 0, 303498
AppSec [baseline] (58.313 ms) : 0, 58313
AppSec [candidate] (57.834 ms) : 0, 57834
Remote Config [baseline] (603.066 µs) : 0, 603
Remote Config [candidate] (599.455 µs) : 0, 599
Telemetry [baseline] (7.361 ms) : 0, 7361
Telemetry [candidate] (7.377 ms) : 0, 7377
IAST [baseline] (19.654 ms) : 0, 19654
IAST [candidate] (19.679 ms) : 0, 19679
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~1687fe574f, baseline=1.42.0-SNAPSHOT~b2332408b0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1089498
Total [baseline] (10.458 s) : 0, 10457926
Agent [candidate] (1.093 s) : 0, 1093019
Total [candidate] (10.376 s) : 0, 10376075
section appsec
Agent [baseline] (1.219 s) : 0, 1219117
Total [baseline] (10.729 s) : 0, 10728945
Agent [candidate] (1.224 s) : 0, 1223868
Total [candidate] (10.689 s) : 0, 10689008
section iast
Agent [baseline] (1.207 s) : 0, 1207187
Total [baseline] (10.904 s) : 0, 10904261
Agent [candidate] (1.211 s) : 0, 1211278
Total [candidate] (10.932 s) : 0, 10931579
section profiling
Agent [baseline] (1.29 s) : 0, 1289946
Total [baseline] (10.737 s) : 0, 10736780
Agent [candidate] (1.285 s) : 0, 1285277
Total [candidate] (10.845 s) : 0, 10844772
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~1687fe574f, baseline=1.42.0-SNAPSHOT~b2332408b0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.29 ms) : 0, 691290
BytebuddyAgent [candidate] (693.281 ms) : 0, 693281
GlobalTracer [baseline] (316.842 ms) : 0, 316842
GlobalTracer [candidate] (317.731 ms) : 0, 317731
AppSec [baseline] (55.443 ms) : 0, 55443
AppSec [candidate] (54.696 ms) : 0, 54696
Remote Config [baseline] (672.542 µs) : 0, 673
Remote Config [candidate] (672.3 µs) : 0, 672
Telemetry [baseline] (11.42 ms) : 0, 11420
Telemetry [candidate] (12.772 ms) : 0, 12772
section appsec
BytebuddyAgent [baseline] (706.292 ms) : 0, 706292
BytebuddyAgent [candidate] (710.222 ms) : 0, 710222
GlobalTracer [baseline] (313.476 ms) : 0, 313476
GlobalTracer [candidate] (314.642 ms) : 0, 314642
AppSec [baseline] (167.961 ms) : 0, 167961
AppSec [candidate] (166.271 ms) : 0, 166271
Remote Config [baseline] (639.166 µs) : 0, 639
Remote Config [candidate] (647.527 µs) : 0, 648
Telemetry [baseline] (7.73 ms) : 0, 7730
Telemetry [candidate] (8.497 ms) : 0, 8497
IAST [baseline] (18.537 ms) : 0, 18537
IAST [candidate] (19.472 ms) : 0, 19472
section iast
BytebuddyAgent [baseline] (803.557 ms) : 0, 803557
BytebuddyAgent [candidate] (806.404 ms) : 0, 806404
GlobalTracer [baseline] (303.726 ms) : 0, 303726
GlobalTracer [candidate] (305.174 ms) : 0, 305174
AppSec [baseline] (58.195 ms) : 0, 58195
AppSec [candidate] (57.903 ms) : 0, 57903
Remote Config [baseline] (605.921 µs) : 0, 606
Remote Config [candidate] (602.292 µs) : 0, 602
Telemetry [baseline] (7.413 ms) : 0, 7413
Telemetry [candidate] (7.481 ms) : 0, 7481
IAST [baseline] (19.97 ms) : 0, 19970
IAST [candidate] (19.907 ms) : 0, 19907
section profiling
BytebuddyAgent [baseline] (687.76 ms) : 0, 687760
BytebuddyAgent [candidate] (685.023 ms) : 0, 685023
GlobalTracer [baseline] (401.563 ms) : 0, 401563
GlobalTracer [candidate] (400.784 ms) : 0, 400784
AppSec [baseline] (56.09 ms) : 0, 56090
AppSec [candidate] (54.896 ms) : 0, 54896
Remote Config [baseline] (676.049 µs) : 0, 676
Remote Config [candidate] (668.436 µs) : 0, 668
Telemetry [baseline] (12.93 ms) : 0, 12930
Telemetry [candidate] (12.857 ms) : 0, 12857
ProfilingAgent [baseline] (91.773 ms) : 0, 91773
ProfilingAgent [candidate] (91.906 ms) : 0, 91906
Profiling [baseline] (91.797 ms) : 0, 91797
Profiling [candidate] (91.929 ms) : 0, 91929
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~1687fe574f, baseline=1.42.0-SNAPSHOT~b2332408b0
dateFormat X
axisFormat %s
section baseline
no_agent (1.342 ms) : 1323, 1361
. : milestone, 1342,
appsec (1.72 ms) : 1694, 1745
. : milestone, 1720,
appsec_no_iast (1.711 ms) : 1687, 1736
. : milestone, 1711,
iast (1.477 ms) : 1454, 1499
. : milestone, 1477,
profiling (1.469 ms) : 1446, 1492
. : milestone, 1469,
tracing (1.452 ms) : 1428, 1477
. : milestone, 1452,
section candidate
no_agent (1.353 ms) : 1334, 1373
. : milestone, 1353,
appsec (1.725 ms) : 1700, 1749
. : milestone, 1725,
appsec_no_iast (1.74 ms) : 1716, 1764
. : milestone, 1740,
iast (1.486 ms) : 1463, 1509
. : milestone, 1486,
profiling (1.471 ms) : 1449, 1494
. : milestone, 1471,
tracing (1.471 ms) : 1447, 1495
. : milestone, 1471,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~1687fe574f, baseline=1.42.0-SNAPSHOT~b2332408b0
dateFormat X
axisFormat %s
section baseline
no_agent (365.788 µs) : 346, 386
. : milestone, 366,
iast (485.736 µs) : 465, 507
. : milestone, 486,
iast_FULL (646.064 µs) : 625, 667
. : milestone, 646,
iast_GLOBAL (515.122 µs) : 493, 537
. : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (482.933 µs) : 462, 504
. : milestone, 483,
iast_INACTIVE (440.924 µs) : 420, 461
. : milestone, 441,
iast_TELEMETRY_OFF (469.658 µs) : 449, 490
. : milestone, 470,
tracing (445.507 µs) : 425, 466
. : milestone, 446,
section candidate
no_agent (376.315 µs) : 356, 397
. : milestone, 376,
iast (483.702 µs) : 463, 505
. : milestone, 484,
iast_FULL (642.699 µs) : 621, 664
. : milestone, 643,
iast_GLOBAL (514.579 µs) : 493, 536
. : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (488.527 µs) : 467, 510
. : milestone, 489,
iast_INACTIVE (445.687 µs) : 425, 466
. : milestone, 446,
iast_TELEMETRY_OFF (481.764 µs) : 460, 503
. : milestone, 482,
tracing (441.039 µs) : 421, 461
. : milestone, 441,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~1687fe574f, baseline=1.42.0-SNAPSHOT~b2332408b0
dateFormat X
axisFormat %s
section baseline
no_agent (15.49 s) : 15490000, 15490000
. : milestone, 15490000,
appsec (15.018 s) : 15018000, 15018000
. : milestone, 15018000,
iast (18.779 s) : 18779000, 18779000
. : milestone, 18779000,
iast_GLOBAL (17.905 s) : 17905000, 17905000
. : milestone, 17905000,
profiling (15.119 s) : 15119000, 15119000
. : milestone, 15119000,
tracing (15.077 s) : 15077000, 15077000
. : milestone, 15077000,
section candidate
no_agent (15.058 s) : 15058000, 15058000
. : milestone, 15058000,
appsec (15.21 s) : 15210000, 15210000
. : milestone, 15210000,
iast (19.05 s) : 19050000, 19050000
. : milestone, 19050000,
iast_GLOBAL (18.036 s) : 18036000, 18036000
. : milestone, 18036000,
profiling (15.512 s) : 15512000, 15512000
. : milestone, 15512000,
tracing (15.204 s) : 15204000, 15204000
. : milestone, 15204000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~1687fe574f, baseline=1.42.0-SNAPSHOT~b2332408b0
dateFormat X
axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1473
. : milestone, 1462,
appsec (2.323 ms) : 2282, 2364
. : milestone, 2323,
iast (2.061 ms) : 2010, 2113
. : milestone, 2061,
iast_GLOBAL (2.116 ms) : 2063, 2169
. : milestone, 2116,
profiling (1.946 ms) : 1903, 1989
. : milestone, 1946,
tracing (1.913 ms) : 1873, 1953
. : milestone, 1913,
section candidate
no_agent (1.46 ms) : 1448, 1471
. : milestone, 1460,
appsec (2.324 ms) : 2282, 2365
. : milestone, 2324,
iast (2.071 ms) : 2019, 2124
. : milestone, 2071,
iast_GLOBAL (2.106 ms) : 2054, 2159
. : milestone, 2106,
profiling (1.937 ms) : 1894, 1979
. : milestone, 1937,
tracing (1.908 ms) : 1868, 1948
. : milestone, 1908,
|
Mariovido
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Updated ASM rules to version
1.13.2
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-55618