Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for session tracking in jetty #7837

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Add support for session tracking in jetty #7837

merged 6 commits into from
Nov 14, 2024

Conversation

manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Oct 25, 2024 •
edited by jira bot
Loading

What Does This Do

Adds support for session tracking in all versions of jetty.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: APPSEC-55559

@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review October 25, 2024 14:43
@manuel-alvarez-alvarez manuel-alvarez-alvarez added comp: asm waf Application Security Management (WAF) inst: jetty Jetty instrumentation labels Oct 25, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 25, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/appsec-extend-session-tracking
git_commit_date 1731578914 1731586279
git_commit_sha e7571fd 8bb3b3f
release_version 1.43.0-SNAPSHOT~e7571fd2ee 1.43.0-SNAPSHOT~8bb3b3f028
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731588598 1731588598
ci_job_id 706832351 706832351
ci_pipeline_id 49004003 49004003
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~8bb3b3f028, baseline=1.43.0-SNAPSHOT~e7571fd2ee

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079760
Total [baseline] (8.572 s) : 0, 8572498
Agent [candidate] (1.09 s) : 0, 1089718
Total [candidate] (8.592 s) : 0, 8591998
section iast
Agent [baseline] (1.207 s) : 0, 1207155
Total [baseline] (9.164 s) : 0, 9164485
Agent [candidate] (1.208 s) : 0, 1207861
Total [candidate] (9.139 s) : 0, 9138881
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.218 s) : 0, 1217872
Total [baseline] (9.112 s) : 0, 9112076
Agent [candidate] (1.212 s) : 0, 1212105
Total [candidate] (9.112 s) : 0, 9111856
section iast_TELEMETRY_OFF
Agent [baseline] (1.205 s) : 0, 1205224
Total [baseline] (9.138 s) : 0, 9138115
Agent [candidate] (1.204 s) : 0, 1203667
Total [candidate] (9.146 s) : 0, 9145927
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.207 s 127.395 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.218 s 138.113 ms (12.8%)
Agent iast_TELEMETRY_OFF 1.205 s 125.464 ms (11.6%)
Total tracing 8.572 s -
Total iast 9.164 s 591.987 ms (6.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.112 s 539.578 ms (6.3%)
Total iast_TELEMETRY_OFF 9.138 s 565.617 ms (6.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.09 s -
Agent iast 1.208 s 118.144 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.212 s 122.387 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.204 s 113.95 ms (10.5%)
Total tracing 8.592 s -
Total iast 9.139 s 546.883 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.112 s 519.858 ms (6.1%)
Total iast_TELEMETRY_OFF 9.146 s 553.929 ms (6.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~8bb3b3f028, baseline=1.43.0-SNAPSHOT~e7571fd2ee

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.648 ms) : 0, 686648
BytebuddyAgent [candidate] (692.321 ms) : 0, 692321
GlobalTracer [baseline] (315.278 ms) : 0, 315278
GlobalTracer [candidate] (315.727 ms) : 0, 315727
AppSec [baseline] (54.224 ms) : 0, 54224
AppSec [candidate] (54.45 ms) : 0, 54450
Remote Config [baseline] (682.409 µs) : 0, 682
Remote Config [candidate] (676.945 µs) : 0, 677
Telemetry [baseline] (9.224 ms) : 0, 9224
Telemetry [candidate] (12.698 ms) : 0, 12698
section iast
BytebuddyAgent [baseline] (803.12 ms) : 0, 803120
BytebuddyAgent [candidate] (803.207 ms) : 0, 803207
GlobalTracer [baseline] (303.831 ms) : 0, 303831
GlobalTracer [candidate] (304.326 ms) : 0, 304326
AppSec [baseline] (56.701 ms) : 0, 56701
AppSec [candidate] (56.248 ms) : 0, 56248
Remote Config [baseline] (630.398 µs) : 0, 630
Remote Config [candidate] (624.384 µs) : 0, 624
Telemetry [baseline] (7.499 ms) : 0, 7499
Telemetry [candidate] (7.445 ms) : 0, 7445
IAST [baseline] (21.586 ms) : 0, 21586
IAST [candidate] (22.258 ms) : 0, 22258
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (809.687 ms) : 0, 809687
BytebuddyAgent [candidate] (806.291 ms) : 0, 806291
GlobalTracer [baseline] (307.172 ms) : 0, 307172
GlobalTracer [candidate] (305.285 ms) : 0, 305285
AppSec [baseline] (57.319 ms) : 0, 57319
AppSec [candidate] (56.868 ms) : 0, 56868
Remote Config [baseline] (610.172 µs) : 0, 610
Remote Config [candidate] (613.824 µs) : 0, 614
Telemetry [baseline] (7.581 ms) : 0, 7581
Telemetry [candidate] (7.487 ms) : 0, 7487
IAST [baseline] (21.593 ms) : 0, 21593
IAST [candidate] (21.735 ms) : 0, 21735
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.303 ms) : 0, 800303
BytebuddyAgent [candidate] (799.858 ms) : 0, 799858
GlobalTracer [baseline] (304.109 ms) : 0, 304109
GlobalTracer [candidate] (303.541 ms) : 0, 303541
AppSec [baseline] (56.848 ms) : 0, 56848
AppSec [candidate] (57.98 ms) : 0, 57980
Remote Config [baseline] (598.174 µs) : 0, 598
Remote Config [candidate] (623.131 µs) : 0, 623
Telemetry [baseline] (7.398 ms) : 0, 7398
Telemetry [candidate] (7.449 ms) : 0, 7449
IAST [baseline] (22.213 ms) : 0, 22213
IAST [candidate] (20.456 ms) : 0, 20456
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~8bb3b3f028, baseline=1.43.0-SNAPSHOT~e7571fd2ee

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1088935
Total [baseline] (10.414 s) : 0, 10413840
Agent [candidate] (1.084 s) : 0, 1083754
Total [candidate] (10.478 s) : 0, 10478286
section appsec
Agent [baseline] (1.215 s) : 0, 1214771
Total [baseline] (10.615 s) : 0, 10615168
Agent [candidate] (1.215 s) : 0, 1214763
Total [candidate] (10.629 s) : 0, 10629154
section iast
Agent [baseline] (1.207 s) : 0, 1206873
Total [baseline] (10.952 s) : 0, 10951518
Agent [candidate] (1.21 s) : 0, 1209572
Total [candidate] (10.941 s) : 0, 10940537
section profiling
Agent [baseline] (1.278 s) : 0, 1277990
Total [baseline] (10.781 s) : 0, 10781345
Agent [candidate] (1.28 s) : 0, 1280500
Total [candidate] (10.754 s) : 0, 10753656
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.089 s -
Agent appsec 1.215 s 125.836 ms (11.6%)
Agent iast 1.207 s 117.938 ms (10.8%)
Agent profiling 1.278 s 189.055 ms (17.4%)
Total tracing 10.414 s -
Total appsec 10.615 s 201.328 ms (1.9%)
Total iast 10.952 s 537.677 ms (5.2%)
Total profiling 10.781 s 367.504 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent appsec 1.215 s 131.008 ms (12.1%)
Agent iast 1.21 s 125.818 ms (11.6%)
Agent profiling 1.28 s 196.745 ms (18.2%)
Total tracing 10.478 s -
Total appsec 10.629 s 150.868 ms (1.4%)
Total iast 10.941 s 462.252 ms (4.4%)
Total profiling 10.754 s 275.371 ms (2.6%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~8bb3b3f028, baseline=1.43.0-SNAPSHOT~e7571fd2ee

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.375 ms) : 0, 692375
BytebuddyAgent [candidate] (687.693 ms) : 0, 687693
GlobalTracer [baseline] (317.772 ms) : 0, 317772
GlobalTracer [candidate] (316.322 ms) : 0, 316322
AppSec [baseline] (54.385 ms) : 0, 54385
AppSec [candidate] (54.552 ms) : 0, 54552
Remote Config [baseline] (677.162 µs) : 0, 677
Remote Config [candidate] (674.326 µs) : 0, 674
Telemetry [baseline] (9.928 ms) : 0, 9928
Telemetry [candidate] (10.745 ms) : 0, 10745
section appsec
BytebuddyAgent [baseline] (702.809 ms) : 0, 702809
BytebuddyAgent [candidate] (704.096 ms) : 0, 704096
GlobalTracer [baseline] (312.874 ms) : 0, 312874
GlobalTracer [candidate] (312.452 ms) : 0, 312452
AppSec [baseline] (166.435 ms) : 0, 166435
AppSec [candidate] (165.942 ms) : 0, 165942
Remote Config [baseline] (633.147 µs) : 0, 633
Remote Config [candidate] (640.464 µs) : 0, 640
Telemetry [baseline] (7.399 ms) : 0, 7399
Telemetry [candidate] (7.781 ms) : 0, 7781
IAST [baseline] (21.859 ms) : 0, 21859
IAST [candidate] (20.238 ms) : 0, 20238
section iast
BytebuddyAgent [baseline] (802.389 ms) : 0, 802389
BytebuddyAgent [candidate] (804.176 ms) : 0, 804176
GlobalTracer [baseline] (304.125 ms) : 0, 304125
GlobalTracer [candidate] (304.42 ms) : 0, 304420
AppSec [baseline] (57.785 ms) : 0, 57785
AppSec [candidate] (57.287 ms) : 0, 57287
Remote Config [baseline] (619.292 µs) : 0, 619
Remote Config [candidate] (626.635 µs) : 0, 627
Telemetry [baseline] (7.471 ms) : 0, 7471
Telemetry [candidate] (7.53 ms) : 0, 7530
IAST [baseline] (20.811 ms) : 0, 20811
IAST [candidate] (21.793 ms) : 0, 21793
section profiling
BytebuddyAgent [baseline] (680.512 ms) : 0, 680512
BytebuddyAgent [candidate] (681.88 ms) : 0, 681880
GlobalTracer [baseline] (398.67 ms) : 0, 398670
GlobalTracer [candidate] (399.581 ms) : 0, 399581
AppSec [baseline] (54.771 ms) : 0, 54771
AppSec [candidate] (54.714 ms) : 0, 54714
Remote Config [baseline] (687.689 µs) : 0, 688
Remote Config [candidate] (660.711 µs) : 0, 661
Telemetry [baseline] (11.312 ms) : 0, 11312
Telemetry [candidate] (9.227 ms) : 0, 9227
ProfilingAgent [baseline] (93.045 ms) : 0, 93045
ProfilingAgent [candidate] (95.412 ms) : 0, 95412
Profiling [baseline] (93.068 ms) : 0, 93068
Profiling [candidate] (95.435 ms) : 0, 95435
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-14T12:20:15 2024-11-14T12:27:10
git_branch master malvarez/appsec-extend-session-tracking
git_commit_date 1731578914 1731586279
git_commit_sha e7571fd 8bb3b3f
release_version 1.43.0-SNAPSHOT~e7571fd2ee 1.43.0-SNAPSHOT~8bb3b3f028
start_time 2024-11-14T12:20:02 2024-11-14T12:26:57
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731587578 1731587578
ci_job_id 706832352 706832352
ci_pipeline_id 49004003 49004003
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-98.880µs; -49.159µs] or [-6.391%; -3.177%]		 unstable
[-495.476op/s; +723.396op/s] or [-16.722%; +24.415%]		 1.473ms 3076.923op/s 1.547ms 2962.963op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~8bb3b3f028, baseline=1.43.0-SNAPSHOT~e7571fd2ee
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.332 ms) : 1313, 1351
.   : milestone, 1332,
appsec (1.744 ms) : 1720, 1767
.   : milestone, 1744,
appsec_no_iast (1.731 ms) : 1707, 1755
.   : milestone, 1731,
iast (1.484 ms) : 1462, 1506
.   : milestone, 1484,
profiling (1.547 ms) : 1524, 1571
.   : milestone, 1547,
tracing (1.463 ms) : 1439, 1487
.   : milestone, 1463,
section candidate
no_agent (1.337 ms) : 1318, 1356
.   : milestone, 1337,
appsec (1.726 ms) : 1702, 1749
.   : milestone, 1726,
appsec_no_iast (1.747 ms) : 1723, 1771
.   : milestone, 1747,
iast (1.479 ms) : 1457, 1502
.   : milestone, 1479,
profiling (1.473 ms) : 1451, 1496
.   : milestone, 1473,
tracing (1.458 ms) : 1433, 1482
.   : milestone, 1458,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.313 ms, 1.351 ms] -
appsec 1.744 ms [1.72 ms, 1.767 ms] 411.263 µs (30.9%)
appsec_no_iast 1.731 ms [1.707 ms, 1.755 ms] 398.551 µs (29.9%)
iast 1.484 ms [1.462 ms, 1.506 ms] 151.659 µs (11.4%)
profiling 1.547 ms [1.524 ms, 1.571 ms] 214.977 µs (16.1%)
tracing 1.463 ms [1.439 ms, 1.487 ms] 130.819 µs (9.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.318 ms, 1.356 ms] -
appsec 1.726 ms [1.702 ms, 1.749 ms] 388.275 µs (29.0%)
appsec_no_iast 1.747 ms [1.723 ms, 1.771 ms] 409.747 µs (30.6%)
iast 1.479 ms [1.457 ms, 1.502 ms] 142.033 µs (10.6%)
profiling 1.473 ms [1.451 ms, 1.496 ms] 135.856 µs (10.2%)
tracing 1.458 ms [1.433 ms, 1.482 ms] 120.131 µs (9.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~8bb3b3f028, baseline=1.43.0-SNAPSHOT~e7571fd2ee
    dateFormat X
    axisFormat %s
section baseline
no_agent (364.11 µs) : 344, 384
.   : milestone, 364,
iast (479.135 µs) : 458, 500
.   : milestone, 479,
iast_FULL (637.714 µs) : 616, 659
.   : milestone, 638,
iast_GLOBAL (514.635 µs) : 492, 537
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (481.15 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (453.655 µs) : 433, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (479.558 µs) : 458, 501
.   : milestone, 480,
tracing (434.58 µs) : 414, 455
.   : milestone, 435,
section candidate
no_agent (369.082 µs) : 349, 389
.   : milestone, 369,
iast (480.627 µs) : 459, 502
.   : milestone, 481,
iast_FULL (638.258 µs) : 617, 659
.   : milestone, 638,
iast_GLOBAL (511.022 µs) : 489, 533
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (485.562 µs) : 465, 507
.   : milestone, 486,
iast_INACTIVE (447.807 µs) : 427, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (477.984 µs) : 457, 499
.   : milestone, 478,
tracing (445.234 µs) : 424, 466
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.11 µs [344.096 µs, 384.123 µs] -
iast 479.135 µs [458.174 µs, 500.097 µs] 115.026 µs (31.6%)
iast_FULL 637.714 µs [616.499 µs, 658.929 µs] 273.604 µs (75.1%)
iast_GLOBAL 514.635 µs [492.36 µs, 536.909 µs] 150.525 µs (41.3%)
iast_HARDCODED_SECRET_DISABLED 481.15 µs [459.869 µs, 502.431 µs] 117.04 µs (32.1%)
iast_INACTIVE 453.655 µs [432.665 µs, 474.645 µs] 89.545 µs (24.6%)
iast_TELEMETRY_OFF 479.558 µs [457.702 µs, 501.415 µs] 115.449 µs (31.7%)
tracing 434.58 µs [414.248 µs, 454.911 µs] 70.47 µs (19.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.082 µs [348.988 µs, 389.175 µs] -
iast 480.627 µs [459.41 µs, 501.844 µs] 111.546 µs (30.2%)
iast_FULL 638.258 µs [617.069 µs, 659.447 µs] 269.177 µs (72.9%)
iast_GLOBAL 511.022 µs [488.794 µs, 533.249 µs] 141.94 µs (38.5%)
iast_HARDCODED_SECRET_DISABLED 485.562 µs [464.522 µs, 506.602 µs] 116.48 µs (31.6%)
iast_INACTIVE 447.807 µs [426.525 µs, 469.088 µs] 78.725 µs (21.3%)
iast_TELEMETRY_OFF 477.984 µs [456.604 µs, 499.364 µs] 108.902 µs (29.5%)
tracing 445.234 µs [423.999 µs, 466.47 µs] 76.153 µs (20.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/appsec-extend-session-tracking
git_commit_date 1731578914 1731586279
git_commit_sha e7571fd 8bb3b3f
release_version 1.43.0-SNAPSHOT~e7571fd2ee 1.43.0-SNAPSHOT~8bb3b3f028
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1731588239 1731588239
ci_job_id 706832353 706832353
ci_pipeline_id 49004003 49004003
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~8bb3b3f028, baseline=1.43.0-SNAPSHOT~e7571fd2ee
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.329 ms) : 2288, 2371
.   : milestone, 2329,
iast (2.057 ms) : 2006, 2109
.   : milestone, 2057,
iast_GLOBAL (2.119 ms) : 2066, 2172
.   : milestone, 2119,
profiling (1.934 ms) : 1892, 1976
.   : milestone, 1934,
tracing (1.913 ms) : 1873, 1953
.   : milestone, 1913,
section candidate
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.323 ms) : 2281, 2364
.   : milestone, 2323,
iast (2.084 ms) : 2031, 2137
.   : milestone, 2084,
iast_GLOBAL (2.117 ms) : 2064, 2169
.   : milestone, 2117,
profiling (1.925 ms) : 1884, 1966
.   : milestone, 1925,
tracing (1.907 ms) : 1867, 1947
.   : milestone, 1907,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 2.329 ms [2.288 ms, 2.371 ms] 861.037 µs (58.6%)
iast 2.057 ms [2.006 ms, 2.109 ms] 588.927 µs (40.1%)
iast_GLOBAL 2.119 ms [2.066 ms, 2.172 ms] 650.231 µs (44.3%)
profiling 1.934 ms [1.892 ms, 1.976 ms] 465.818 µs (31.7%)
tracing 1.913 ms [1.873 ms, 1.953 ms] 444.419 µs (30.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.452 ms, 1.475 ms] -
appsec 2.323 ms [2.281 ms, 2.364 ms] 859.119 µs (58.7%)
iast 2.084 ms [2.031 ms, 2.137 ms] 620.807 µs (42.4%)
iast_GLOBAL 2.117 ms [2.064 ms, 2.169 ms] 653.107 µs (44.6%)
profiling 1.925 ms [1.884 ms, 1.966 ms] 461.425 µs (31.5%)
tracing 1.907 ms [1.867 ms, 1.947 ms] 443.559 µs (30.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~8bb3b3f028, baseline=1.43.0-SNAPSHOT~e7571fd2ee
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.991 s) : 14991000, 14991000
.   : milestone, 14991000,
appsec (15.199 s) : 15199000, 15199000
.   : milestone, 15199000,
iast (18.867 s) : 18867000, 18867000
.   : milestone, 18867000,
iast_GLOBAL (18.271 s) : 18271000, 18271000
.   : milestone, 18271000,
profiling (15.154 s) : 15154000, 15154000
.   : milestone, 15154000,
tracing (14.925 s) : 14925000, 14925000
.   : milestone, 14925000,
section candidate
no_agent (15.109 s) : 15109000, 15109000
.   : milestone, 15109000,
appsec (15.158 s) : 15158000, 15158000
.   : milestone, 15158000,
iast (18.335 s) : 18335000, 18335000
.   : milestone, 18335000,
iast_GLOBAL (18.59 s) : 18590000, 18590000
.   : milestone, 18590000,
profiling (15.101 s) : 15101000, 15101000
.   : milestone, 15101000,
tracing (15.018 s) : 15018000, 15018000
.   : milestone, 15018000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.991 s [14.991 s, 14.991 s] -
appsec 15.199 s [15.199 s, 15.199 s] 208.0 ms (1.4%)
iast 18.867 s [18.867 s, 18.867 s] 3.876 s (25.9%)
iast_GLOBAL 18.271 s [18.271 s, 18.271 s] 3.28 s (21.9%)
profiling 15.154 s [15.154 s, 15.154 s] 163.0 ms (1.1%)
tracing 14.925 s [14.925 s, 14.925 s] -66.0 ms (-0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.109 s [15.109 s, 15.109 s] -
appsec 15.158 s [15.158 s, 15.158 s] 49.0 ms (0.3%)
iast 18.335 s [18.335 s, 18.335 s] 3.226 s (21.4%)
iast_GLOBAL 18.59 s [18.59 s, 18.59 s] 3.481 s (23.0%)
profiling 15.101 s [15.101 s, 15.101 s] -8.0 ms (-0.1%)
tracing 15.018 s [15.018 s, 15.018 s] -91.0 ms (-0.6%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/appsec-extend-session-tracking branch from 3de3db6 to 4bc4b4f Compare October 25, 2024 15:54
jandro996
jandro996 reviewed Oct 28, 2024
View reviewed changes
...2/src/main/java17/datadog/trace/instrumentation/jetty12/ResolveRequestedSessionIdAdvice.java Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not merge until #7516 it is merged in master 😄

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/appsec-extend-session-tracking branch from 4bc4b4f to 875aa7c Compare October 28, 2024 08:48
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/appsec-extend-session-tracking branch from 510789e to 4e74c0e Compare November 14, 2024 09:43
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/appsec-extend-session-tracking branch from 4e74c0e to 8bb3b3f Compare November 14, 2024 12:11
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 8c26b74 into master Nov 14, 2024
102 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/appsec-extend-session-tracking branch November 14, 2024 14:07
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandro996 jandro996 jandro996 approved these changes

@amarziali amarziali amarziali approved these changes

@smola smola smola approved these changes

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) inst: jetty Jetty instrumentation
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
4 participants
@manuel-alvarez-alvarez @smola @amarziali @jandro996