-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to libddwaf 1.20.1 (libddwaf-java 11.1.0) #7828
Merged
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinZakharov
added
type: enhancement
comp: asm waf
Application Security Management (WAF)
labels
Oct 23, 2024
Mariovido
approved these changes
Oct 23, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~c46b282bf7, baseline=1.42.0-SNAPSHOT~48a5921560
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076429
Total [baseline] (10.395 s) : 0, 10395288
Agent [candidate] (1.077 s) : 0, 1076505
Total [candidate] (10.385 s) : 0, 10384791
section appsec
Agent [baseline] (1.22 s) : 0, 1220415
Total [baseline] (10.667 s) : 0, 10666778
Agent [candidate] (1.214 s) : 0, 1214477
Total [candidate] (10.639 s) : 0, 10639497
section iast
Agent [baseline] (1.211 s) : 0, 1211465
Total [baseline] (10.951 s) : 0, 10950570
Agent [candidate] (1.202 s) : 0, 1202389
Total [candidate] (10.848 s) : 0, 10848183
section profiling
Agent [baseline] (1.274 s) : 0, 1273681
Total [baseline] (10.721 s) : 0, 10720744
Agent [candidate] (1.272 s) : 0, 1272394
Total [candidate] (10.629 s) : 0, 10629498
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~c46b282bf7, baseline=1.42.0-SNAPSHOT~48a5921560
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.382 ms) : 0, 685382
BytebuddyAgent [candidate] (686.182 ms) : 0, 686182
GlobalTracer [baseline] (312.762 ms) : 0, 312762
GlobalTracer [candidate] (312.717 ms) : 0, 312717
AppSec [baseline] (53.767 ms) : 0, 53767
AppSec [candidate] (53.704 ms) : 0, 53704
Remote Config [baseline] (676.839 µs) : 0, 677
Remote Config [candidate] (656.232 µs) : 0, 656
Telemetry [baseline] (10.195 ms) : 0, 10195
Telemetry [candidate] (9.573 ms) : 0, 9573
section appsec
BytebuddyAgent [baseline] (711.02 ms) : 0, 711020
BytebuddyAgent [candidate] (706.139 ms) : 0, 706139
GlobalTracer [baseline] (312.483 ms) : 0, 312483
GlobalTracer [candidate] (309.831 ms) : 0, 309831
AppSec [baseline] (165.142 ms) : 0, 165142
AppSec [candidate] (166.783 ms) : 0, 166783
Remote Config [baseline] (638.827 µs) : 0, 639
Remote Config [candidate] (625.746 µs) : 0, 626
Telemetry [baseline] (7.705 ms) : 0, 7705
Telemetry [candidate] (7.387 ms) : 0, 7387
IAST [baseline] (19.274 ms) : 0, 19274
IAST [candidate] (19.995 ms) : 0, 19995
section iast
BytebuddyAgent [baseline] (808.269 ms) : 0, 808269
BytebuddyAgent [candidate] (801.826 ms) : 0, 801826
GlobalTracer [baseline] (304.226 ms) : 0, 304226
GlobalTracer [candidate] (301.77 ms) : 0, 301770
AppSec [baseline] (56.701 ms) : 0, 56701
AppSec [candidate] (56.997 ms) : 0, 56997
Remote Config [baseline] (586.909 µs) : 0, 587
Remote Config [candidate] (601.109 µs) : 0, 601
Telemetry [baseline] (6.949 ms) : 0, 6949
Telemetry [candidate] (7.068 ms) : 0, 7068
IAST [baseline] (20.959 ms) : 0, 20959
IAST [candidate] (20.433 ms) : 0, 20433
section profiling
ProfilingAgent [baseline] (88.789 ms) : 0, 88789
ProfilingAgent [candidate] (90.1 ms) : 0, 90100
BytebuddyAgent [baseline] (682.155 ms) : 0, 682155
BytebuddyAgent [candidate] (679.804 ms) : 0, 679804
GlobalTracer [baseline] (395.429 ms) : 0, 395429
GlobalTracer [candidate] (396.089 ms) : 0, 396089
AppSec [baseline] (54.246 ms) : 0, 54246
AppSec [candidate] (54.231 ms) : 0, 54231
Remote Config [baseline] (644.208 µs) : 0, 644
Remote Config [candidate] (648.692 µs) : 0, 649
Telemetry [baseline] (13.571 ms) : 0, 13571
Telemetry [candidate] (12.897 ms) : 0, 12897
Profiling [baseline] (88.813 ms) : 0, 88813
Profiling [candidate] (90.123 ms) : 0, 90123
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~c46b282bf7, baseline=1.42.0-SNAPSHOT~48a5921560
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1074905
Total [baseline] (8.581 s) : 0, 8580536
Agent [candidate] (1.082 s) : 0, 1081855
Total [candidate] (8.623 s) : 0, 8622798
section iast
Agent [baseline] (1.203 s) : 0, 1202685
Total [baseline] (9.086 s) : 0, 9086057
Agent [candidate] (1.208 s) : 0, 1208273
Total [candidate] (9.126 s) : 0, 9126050
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.202 s) : 0, 1201891
Total [baseline] (9.102 s) : 0, 9101910
Agent [candidate] (1.201 s) : 0, 1200628
Total [candidate] (9.079 s) : 0, 9078561
section iast_TELEMETRY_OFF
Agent [baseline] (1.206 s) : 0, 1205639
Total [baseline] (9.121 s) : 0, 9120690
Agent [candidate] (1.198 s) : 0, 1197641
Total [candidate] (9.102 s) : 0, 9102241
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~c46b282bf7, baseline=1.42.0-SNAPSHOT~48a5921560
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.76 ms) : 0, 684760
BytebuddyAgent [candidate] (689.174 ms) : 0, 689174
GlobalTracer [baseline] (312.028 ms) : 0, 312028
GlobalTracer [candidate] (314.431 ms) : 0, 314431
AppSec [baseline] (53.642 ms) : 0, 53642
AppSec [candidate] (53.675 ms) : 0, 53675
Remote Config [baseline] (666.322 µs) : 0, 666
Remote Config [candidate] (670.642 µs) : 0, 671
Telemetry [baseline] (10.178 ms) : 0, 10178
Telemetry [candidate] (10.168 ms) : 0, 10168
section iast
BytebuddyAgent [baseline] (801.838 ms) : 0, 801838
BytebuddyAgent [candidate] (806.173 ms) : 0, 806173
GlobalTracer [baseline] (301.814 ms) : 0, 301814
GlobalTracer [candidate] (303.261 ms) : 0, 303261
AppSec [baseline] (57.343 ms) : 0, 57343
AppSec [candidate] (56.554 ms) : 0, 56554
Remote Config [baseline] (597.636 µs) : 0, 598
Remote Config [candidate] (590.066 µs) : 0, 590
Telemetry [baseline] (7.03 ms) : 0, 7030
Telemetry [candidate] (6.982 ms) : 0, 6982
IAST [baseline] (20.373 ms) : 0, 20373
IAST [candidate] (20.967 ms) : 0, 20967
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.435 ms) : 0, 800435
BytebuddyAgent [candidate] (799.869 ms) : 0, 799869
GlobalTracer [baseline] (302.003 ms) : 0, 302003
GlobalTracer [candidate] (301.71 ms) : 0, 301710
AppSec [baseline] (56.265 ms) : 0, 56265
AppSec [candidate] (56.616 ms) : 0, 56616
Remote Config [baseline] (593.046 µs) : 0, 593
Remote Config [candidate] (604.954 µs) : 0, 605
Telemetry [baseline] (7.086 ms) : 0, 7086
Telemetry [candidate] (7.052 ms) : 0, 7052
IAST [baseline] (21.863 ms) : 0, 21863
IAST [candidate] (21.109 ms) : 0, 21109
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (802.884 ms) : 0, 802884
BytebuddyAgent [candidate] (797.147 ms) : 0, 797147
GlobalTracer [baseline] (303.487 ms) : 0, 303487
GlobalTracer [candidate] (302.095 ms) : 0, 302095
AppSec [baseline] (56.919 ms) : 0, 56919
AppSec [candidate] (57.389 ms) : 0, 57389
Remote Config [baseline] (599.844 µs) : 0, 600
Remote Config [candidate] (592.312 µs) : 0, 592
Telemetry [baseline] (6.979 ms) : 0, 6979
Telemetry [candidate] (6.92 ms) : 0, 6920
IAST [baseline] (21.03 ms) : 0, 21030
IAST [candidate] (19.84 ms) : 0, 19840
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~c46b282bf7, baseline=1.42.0-SNAPSHOT~48a5921560
dateFormat X
axisFormat %s
section baseline
no_agent (372.267 µs) : 353, 392
. : milestone, 372,
iast (485.604 µs) : 464, 507
. : milestone, 486,
iast_FULL (560.997 µs) : 540, 582
. : milestone, 561,
iast_GLOBAL (511.158 µs) : 490, 532
. : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (485.397 µs) : 464, 506
. : milestone, 485,
iast_INACTIVE (445.391 µs) : 425, 466
. : milestone, 445,
iast_TELEMETRY_OFF (477.581 µs) : 455, 500
. : milestone, 478,
tracing (448.061 µs) : 427, 469
. : milestone, 448,
section candidate
no_agent (376.611 µs) : 357, 396
. : milestone, 377,
iast (483.39 µs) : 462, 505
. : milestone, 483,
iast_FULL (557.255 µs) : 536, 578
. : milestone, 557,
iast_GLOBAL (511.562 µs) : 490, 533
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (485.807 µs) : 464, 507
. : milestone, 486,
iast_INACTIVE (449.894 µs) : 428, 472
. : milestone, 450,
iast_TELEMETRY_OFF (473.63 µs) : 452, 495
. : milestone, 474,
tracing (442.859 µs) : 423, 463
. : milestone, 443,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~c46b282bf7, baseline=1.42.0-SNAPSHOT~48a5921560
dateFormat X
axisFormat %s
section baseline
no_agent (1.344 ms) : 1325, 1363
. : milestone, 1344,
appsec (1.731 ms) : 1707, 1756
. : milestone, 1731,
appsec_no_iast (1.735 ms) : 1712, 1759
. : milestone, 1735,
iast (1.478 ms) : 1456, 1500
. : milestone, 1478,
profiling (1.521 ms) : 1497, 1545
. : milestone, 1521,
tracing (1.47 ms) : 1445, 1494
. : milestone, 1470,
section candidate
no_agent (1.349 ms) : 1329, 1368
. : milestone, 1349,
appsec (1.717 ms) : 1693, 1741
. : milestone, 1717,
appsec_no_iast (1.705 ms) : 1680, 1729
. : milestone, 1705,
iast (1.476 ms) : 1454, 1498
. : milestone, 1476,
profiling (1.483 ms) : 1461, 1506
. : milestone, 1483,
tracing (1.473 ms) : 1448, 1498
. : milestone, 1473,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~c46b282bf7, baseline=1.42.0-SNAPSHOT~48a5921560
dateFormat X
axisFormat %s
section baseline
no_agent (15.475 s) : 15475000, 15475000
. : milestone, 15475000,
appsec (15.234 s) : 15234000, 15234000
. : milestone, 15234000,
iast (19.187 s) : 19187000, 19187000
. : milestone, 19187000,
iast_GLOBAL (17.8 s) : 17800000, 17800000
. : milestone, 17800000,
profiling (15.238 s) : 15238000, 15238000
. : milestone, 15238000,
tracing (15.136 s) : 15136000, 15136000
. : milestone, 15136000,
section candidate
no_agent (15.146 s) : 15146000, 15146000
. : milestone, 15146000,
appsec (14.962 s) : 14962000, 14962000
. : milestone, 14962000,
iast (18.762 s) : 18762000, 18762000
. : milestone, 18762000,
iast_GLOBAL (17.926 s) : 17926000, 17926000
. : milestone, 17926000,
profiling (14.982 s) : 14982000, 14982000
. : milestone, 14982000,
tracing (15.15 s) : 15150000, 15150000
. : milestone, 15150000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~c46b282bf7, baseline=1.42.0-SNAPSHOT~48a5921560
dateFormat X
axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1475
. : milestone, 1463,
appsec (2.336 ms) : 2294, 2377
. : milestone, 2336,
iast (2.074 ms) : 2022, 2126
. : milestone, 2074,
iast_GLOBAL (2.108 ms) : 2056, 2161
. : milestone, 2108,
profiling (1.937 ms) : 1895, 1978
. : milestone, 1937,
tracing (1.911 ms) : 1871, 1951
. : milestone, 1911,
section candidate
no_agent (1.46 ms) : 1449, 1472
. : milestone, 1460,
appsec (2.318 ms) : 2277, 2359
. : milestone, 2318,
iast (2.06 ms) : 2009, 2112
. : milestone, 2060,
iast_GLOBAL (2.121 ms) : 2068, 2174
. : milestone, 2121,
profiling (1.959 ms) : 1915, 2003
. : milestone, 1959,
tracing (1.913 ms) : 1873, 1952
. : milestone, 1913,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Upgrade to libddwaf 1.20.1 (libddwaf-java 11.1.0)
Motivation
New version of libddwaf been released. It brings new functionality for ASM
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-55347