Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwrap netty writetask #7822

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Unwrap netty writetask #7822

merged 1 commit into from
Oct 22, 2024

Conversation

richardstartin
Copy link
Member

What Does This Do

Makes netty WriteTask (tasks submitted externally to the event loop) unwrappable so that the message type is reported as the task type, which makes it clearer which of these tasks is waiting the longest. For example, in reactor-netty, this will report tasks as "...HttpRequest" or "...Http2HeadersFrame" and so on.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@richardstartin richardstartin requested a review from a team as a code owner October 22, 2024 10:35
@richardstartin richardstartin requested a review from a team October 22, 2024 10:40
@pr-commenter
Copy link

pr-commenter bot commented Oct 22, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/unwrap-netty-writetask
git_commit_date 1729584822 1729593315
git_commit_sha d446c85 fd2ce3c
release_version 1.42.0-SNAPSHOT~d446c8523f 1.41.0-SNAPSHOT~fd2ce3c320
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729595615 1729595615
ci_job_id 679706557 679706557
ci_pipeline_id 47127870 47127870
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 50 metrics, 10 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast:AppSec better
[-7.328ms; -3.594ms] or [-12.779%; -6.267%]		 51.882ms 57.343ms
scenario:startup:petclinic:profiling:ProfilingAgent worse
[+2.391ms; +7.921ms] or [+2.588%; +8.572%]		 97.560ms 92.404ms
scenario:startup:petclinic:profiling:Profiling worse
[+2.391ms; +7.921ms] or [+2.587%; +8.570%]		 97.583ms 92.427ms
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~fd2ce3c320, baseline=1.42.0-SNAPSHOT~d446c8523f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1091981
Total [baseline] (8.589 s) : 0, 8589396
Agent [candidate] (1.077 s) : 0, 1076777
Total [candidate] (8.562 s) : 0, 8561655
section iast
Agent [baseline] (1.201 s) : 0, 1201186
Total [baseline] (9.134 s) : 0, 9133772
Agent [candidate] (1.198 s) : 0, 1197680
Total [candidate] (9.069 s) : 0, 9069456
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.204 s) : 0, 1204489
Total [baseline] (9.096 s) : 0, 9096250
Agent [candidate] (1.208 s) : 0, 1208056
Total [candidate] (9.093 s) : 0, 9093434
section iast_TELEMETRY_OFF
Agent [baseline] (1.208 s) : 0, 1207938
Total [baseline] (9.134 s) : 0, 9133582
Agent [candidate] (1.211 s) : 0, 1211165
Total [candidate] (9.144 s) : 0, 9144411
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent iast 1.201 s 109.204 ms (10.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.204 s 112.508 ms (10.3%)
Agent iast_TELEMETRY_OFF 1.208 s 115.956 ms (10.6%)
Total tracing 8.589 s -
Total iast 9.134 s 544.376 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.096 s 506.854 ms (5.9%)
Total iast_TELEMETRY_OFF 9.134 s 544.185 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent iast 1.198 s 120.904 ms (11.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.208 s 131.279 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.211 s 134.389 ms (12.5%)
Total tracing 8.562 s -
Total iast 9.069 s 507.801 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.093 s 531.779 ms (6.2%)
Total iast_TELEMETRY_OFF 9.144 s 582.756 ms (6.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~fd2ce3c320, baseline=1.42.0-SNAPSHOT~d446c8523f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.709 ms) : 0, 695709
BytebuddyAgent [candidate] (687.554 ms) : 0, 687554
GlobalTracer [baseline] (316.502 ms) : 0, 316502
GlobalTracer [candidate] (312.975 ms) : 0, 312975
AppSec [baseline] (54.712 ms) : 0, 54712
AppSec [candidate] (54.053 ms) : 0, 54053
Remote Config [baseline] (673.211 µs) : 0, 673
Remote Config [candidate] (669.466 µs) : 0, 669
Telemetry [baseline] (10.414 ms) : 0, 10414
Telemetry [candidate] (7.649 ms) : 0, 7649
section iast
BytebuddyAgent [baseline] (800.298 ms) : 0, 800298
BytebuddyAgent [candidate] (797.138 ms) : 0, 797138
GlobalTracer [baseline] (301.888 ms) : 0, 301888
GlobalTracer [candidate] (300.081 ms) : 0, 300081
AppSec [baseline] (57.343 ms) : 0, 57343
AppSec [candidate] (51.882 ms) : 0, 51882
Remote Config [baseline] (587.552 µs) : 0, 588
Remote Config [candidate] (597.983 µs) : 0, 598
Telemetry [baseline] (7.037 ms) : 0, 7037
Telemetry [candidate] (6.999 ms) : 0, 6999
IAST [baseline] (20.262 ms) : 0, 20262
IAST [candidate] (27.169 ms) : 0, 27169
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (802.048 ms) : 0, 802048
BytebuddyAgent [candidate] (804.882 ms) : 0, 804882
GlobalTracer [baseline] (302.46 ms) : 0, 302460
GlobalTracer [candidate] (302.455 ms) : 0, 302455
AppSec [baseline] (58.134 ms) : 0, 58134
AppSec [candidate] (55.322 ms) : 0, 55322
Remote Config [baseline] (594.586 µs) : 0, 595
Remote Config [candidate] (618.268 µs) : 0, 618
Telemetry [baseline] (7.086 ms) : 0, 7086
Telemetry [candidate] (7.108 ms) : 0, 7108
IAST [baseline] (20.388 ms) : 0, 20388
IAST [candidate] (23.659 ms) : 0, 23659
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.291 ms) : 0, 804291
BytebuddyAgent [candidate] (806.701 ms) : 0, 806701
GlobalTracer [baseline] (303.848 ms) : 0, 303848
GlobalTracer [candidate] (303.508 ms) : 0, 303508
AppSec [baseline] (56.203 ms) : 0, 56203
AppSec [candidate] (53.135 ms) : 0, 53135
Remote Config [baseline] (614.757 µs) : 0, 615
Remote Config [candidate] (608.103 µs) : 0, 608
Telemetry [baseline] (7.09 ms) : 0, 7090
Telemetry [candidate] (7.02 ms) : 0, 7020
IAST [baseline] (22.026 ms) : 0, 22026
IAST [candidate] (26.136 ms) : 0, 26136
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~fd2ce3c320, baseline=1.42.0-SNAPSHOT~d446c8523f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080810
Total [baseline] (10.374 s) : 0, 10374402
Agent [candidate] (1.071 s) : 0, 1070640
Total [candidate] (10.443 s) : 0, 10442889
section appsec
Agent [baseline] (1.211 s) : 0, 1211325
Total [baseline] (10.581 s) : 0, 10581225
Agent [candidate] (1.201 s) : 0, 1201091
Total [candidate] (10.602 s) : 0, 10602346
section iast
Agent [baseline] (1.21 s) : 0, 1210450
Total [baseline] (10.859 s) : 0, 10859083
Agent [candidate] (1.198 s) : 0, 1198152
Total [candidate] (10.855 s) : 0, 10855057
section profiling
Agent [baseline] (1.274 s) : 0, 1274234
Total [baseline] (10.671 s) : 0, 10671255
Agent [candidate] (1.285 s) : 0, 1285445
Total [candidate] (10.617 s) : 0, 10617097
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent appsec 1.211 s 130.515 ms (12.1%)
Agent iast 1.21 s 129.64 ms (12.0%)
Agent profiling 1.274 s 193.424 ms (17.9%)
Total tracing 10.374 s -
Total appsec 10.581 s 206.823 ms (2.0%)
Total iast 10.859 s 484.681 ms (4.7%)
Total profiling 10.671 s 296.853 ms (2.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.201 s 130.451 ms (12.2%)
Agent iast 1.198 s 127.512 ms (11.9%)
Agent profiling 1.285 s 214.806 ms (20.1%)
Total tracing 10.443 s -
Total appsec 10.602 s 159.456 ms (1.5%)
Total iast 10.855 s 412.168 ms (3.9%)
Total profiling 10.617 s 174.208 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~fd2ce3c320, baseline=1.42.0-SNAPSHOT~d446c8523f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.776 ms) : 0, 687776
BytebuddyAgent [candidate] (682.961 ms) : 0, 682961
GlobalTracer [baseline] (313.995 ms) : 0, 313995
GlobalTracer [candidate] (311.569 ms) : 0, 311569
AppSec [baseline] (54.031 ms) : 0, 54031
AppSec [candidate] (54.043 ms) : 0, 54043
Remote Config [baseline] (670.876 µs) : 0, 671
Remote Config [candidate] (665.786 µs) : 0, 666
Telemetry [baseline] (10.549 ms) : 0, 10549
Telemetry [candidate] (7.627 ms) : 0, 7627
section appsec
BytebuddyAgent [baseline] (703.416 ms) : 0, 703416
BytebuddyAgent [candidate] (698.08 ms) : 0, 698080
GlobalTracer [baseline] (310.019 ms) : 0, 310019
GlobalTracer [candidate] (306.866 ms) : 0, 306866
AppSec [baseline] (166.554 ms) : 0, 166554
AppSec [candidate] (162.158 ms) : 0, 162158
Remote Config [baseline] (636.158 µs) : 0, 636
Remote Config [candidate] (648.046 µs) : 0, 648
Telemetry [baseline] (7.011 ms) : 0, 7011
Telemetry [candidate] (9.593 ms) : 0, 9593
IAST [baseline] (19.906 ms) : 0, 19906
IAST [candidate] (19.997 ms) : 0, 19997
section iast
BytebuddyAgent [baseline] (808.161 ms) : 0, 808161
BytebuddyAgent [candidate] (797.614 ms) : 0, 797614
GlobalTracer [baseline] (302.604 ms) : 0, 302604
GlobalTracer [candidate] (300.072 ms) : 0, 300072
AppSec [baseline] (55.967 ms) : 0, 55967
AppSec [candidate] (53.396 ms) : 0, 53396
Remote Config [baseline] (603.019 µs) : 0, 603
Remote Config [candidate] (610.09 µs) : 0, 610
Telemetry [baseline] (7.088 ms) : 0, 7088
Telemetry [candidate] (7.053 ms) : 0, 7053
IAST [baseline] (22.126 ms) : 0, 22126
IAST [candidate] (25.609 ms) : 0, 25609
section profiling
BytebuddyAgent [baseline] (680.165 ms) : 0, 680165
BytebuddyAgent [candidate] (686.216 ms) : 0, 686216
GlobalTracer [baseline] (396.743 ms) : 0, 396743
GlobalTracer [candidate] (398.598 ms) : 0, 398598
AppSec [baseline] (54.291 ms) : 0, 54291
AppSec [candidate] (55.438 ms) : 0, 55438
Remote Config [baseline] (653.208 µs) : 0, 653
Remote Config [candidate] (681.321 µs) : 0, 681
Telemetry [baseline] (11.102 ms) : 0, 11102
Telemetry [candidate] (7.577 ms) : 0, 7577
ProfilingAgent [baseline] (92.404 ms) : 0, 92404
ProfilingAgent [candidate] (97.56 ms) : 0, 97560
Profiling [baseline] (92.427 ms) : 0, 92427
Profiling [candidate] (97.583 ms) : 0, 97583
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-22T10:46:16 2024-10-22T10:53:10
git_branch master rgs/unwrap-netty-writetask
git_commit_date 1729584822 1729593315
git_commit_sha d446c85 fd2ce3c
release_version 1.42.0-SNAPSHOT~d446c8523f 1.41.0-SNAPSHOT~fd2ce3c320
start_time 2024-10-22T10:46:02 2024-10-22T10:52:56
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729594737 1729594737
ci_job_id 679706558 679706558
ci_pipeline_id 47127870 47127870
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~fd2ce3c320, baseline=1.42.0-SNAPSHOT~d446c8523f
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.5 µs) : 357, 396
.   : milestone, 376,
iast (494.374 µs) : 473, 515
.   : milestone, 494,
iast_FULL (566.621 µs) : 545, 588
.   : milestone, 567,
iast_GLOBAL (524.082 µs) : 503, 546
.   : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (493.429 µs) : 472, 514
.   : milestone, 493,
iast_INACTIVE (458.381 µs) : 437, 480
.   : milestone, 458,
iast_TELEMETRY_OFF (486.916 µs) : 465, 509
.   : milestone, 487,
tracing (451.912 µs) : 431, 473
.   : milestone, 452,
section candidate
no_agent (376.499 µs) : 356, 397
.   : milestone, 376,
iast (483.678 µs) : 463, 505
.   : milestone, 484,
iast_FULL (565.903 µs) : 545, 587
.   : milestone, 566,
iast_GLOBAL (515.316 µs) : 494, 537
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (497.924 µs) : 476, 519
.   : milestone, 498,
iast_INACTIVE (452.105 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (485.327 µs) : 464, 507
.   : milestone, 485,
tracing (451.631 µs) : 431, 473
.   : milestone, 452,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.5 µs [356.861 µs, 396.139 µs] -
iast 494.374 µs [473.345 µs, 515.404 µs] 117.875 µs (31.3%)
iast_FULL 566.621 µs [544.847 µs, 588.396 µs] 190.122 µs (50.5%)
iast_GLOBAL 524.082 µs [502.504 µs, 545.66 µs] 147.582 µs (39.2%)
iast_HARDCODED_SECRET_DISABLED 493.429 µs [472.377 µs, 514.481 µs] 116.929 µs (31.1%)
iast_INACTIVE 458.381 µs [437.073 µs, 479.689 µs] 81.881 µs (21.7%)
iast_TELEMETRY_OFF 486.916 µs [464.929 µs, 508.904 µs] 110.416 µs (29.3%)
tracing 451.912 µs [430.742 µs, 473.082 µs] 75.412 µs (20.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.499 µs [355.751 µs, 397.248 µs] -
iast 483.678 µs [462.505 µs, 504.852 µs] 107.179 µs (28.5%)
iast_FULL 565.903 µs [544.72 µs, 587.085 µs] 189.404 µs (50.3%)
iast_GLOBAL 515.316 µs [494.035 µs, 536.597 µs] 138.817 µs (36.9%)
iast_HARDCODED_SECRET_DISABLED 497.924 µs [476.495 µs, 519.352 µs] 121.425 µs (32.3%)
iast_INACTIVE 452.105 µs [430.902 µs, 473.309 µs] 75.606 µs (20.1%)
iast_TELEMETRY_OFF 485.327 µs [463.969 µs, 506.684 µs] 108.827 µs (28.9%)
tracing 451.631 µs [430.657 µs, 472.604 µs] 75.131 µs (20.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~fd2ce3c320, baseline=1.42.0-SNAPSHOT~d446c8523f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.342 ms) : 1321, 1362
.   : milestone, 1342,
appsec (1.723 ms) : 1698, 1747
.   : milestone, 1723,
appsec_no_iast (1.752 ms) : 1729, 1776
.   : milestone, 1752,
iast (1.491 ms) : 1469, 1514
.   : milestone, 1491,
profiling (1.502 ms) : 1477, 1528
.   : milestone, 1502,
tracing (1.465 ms) : 1440, 1490
.   : milestone, 1465,
section candidate
no_agent (1.358 ms) : 1338, 1377
.   : milestone, 1358,
appsec (1.732 ms) : 1708, 1756
.   : milestone, 1732,
appsec_no_iast (1.705 ms) : 1681, 1730
.   : milestone, 1705,
iast (1.477 ms) : 1454, 1499
.   : milestone, 1477,
profiling (1.484 ms) : 1459, 1508
.   : milestone, 1484,
tracing (1.469 ms) : 1442, 1496
.   : milestone, 1469,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.321 ms, 1.362 ms] -
appsec 1.723 ms [1.698 ms, 1.747 ms] 380.613 µs (28.4%)
appsec_no_iast 1.752 ms [1.729 ms, 1.776 ms] 410.578 µs (30.6%)
iast 1.491 ms [1.469 ms, 1.514 ms] 149.41 µs (11.1%)
profiling 1.502 ms [1.477 ms, 1.528 ms] 160.187 µs (11.9%)
tracing 1.465 ms [1.44 ms, 1.49 ms] 122.983 µs (9.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.358 ms [1.338 ms, 1.377 ms] -
appsec 1.732 ms [1.708 ms, 1.756 ms] 374.162 µs (27.6%)
appsec_no_iast 1.705 ms [1.681 ms, 1.73 ms] 347.359 µs (25.6%)
iast 1.477 ms [1.454 ms, 1.499 ms] 118.935 µs (8.8%)
profiling 1.484 ms [1.459 ms, 1.508 ms] 125.823 µs (9.3%)
tracing 1.469 ms [1.442 ms, 1.496 ms] 111.03 µs (8.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/unwrap-netty-writetask
git_commit_date 1729584822 1729593315
git_commit_sha d446c85 fd2ce3c
release_version 1.42.0-SNAPSHOT~d446c8523f 1.41.0-SNAPSHOT~fd2ce3c320
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1729595282 1729595282
ci_job_id 679706560 679706560
ci_pipeline_id 47127870 47127870
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~fd2ce3c320, baseline=1.42.0-SNAPSHOT~d446c8523f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.32 ms) : 2279, 2361
.   : milestone, 2320,
iast (2.076 ms) : 2024, 2128
.   : milestone, 2076,
iast_GLOBAL (2.109 ms) : 2057, 2161
.   : milestone, 2109,
profiling (1.941 ms) : 1899, 1983
.   : milestone, 1941,
tracing (1.913 ms) : 1873, 1952
.   : milestone, 1913,
section candidate
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.324 ms) : 2283, 2366
.   : milestone, 2324,
iast (2.071 ms) : 2019, 2123
.   : milestone, 2071,
iast_GLOBAL (2.117 ms) : 2065, 2169
.   : milestone, 2117,
profiling (1.939 ms) : 1896, 1981
.   : milestone, 1939,
tracing (1.914 ms) : 1875, 1954
.   : milestone, 1914,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.45 ms, 1.473 ms] -
appsec 2.32 ms [2.279 ms, 2.361 ms] 858.235 µs (58.7%)
iast 2.076 ms [2.024 ms, 2.128 ms] 614.833 µs (42.1%)
iast_GLOBAL 2.109 ms [2.057 ms, 2.161 ms] 647.631 µs (44.3%)
profiling 1.941 ms [1.899 ms, 1.983 ms] 479.48 µs (32.8%)
tracing 1.913 ms [1.873 ms, 1.952 ms] 451.003 µs (30.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.324 ms [2.283 ms, 2.366 ms] 857.472 µs (58.5%)
iast 2.071 ms [2.019 ms, 2.123 ms] 604.065 µs (41.2%)
iast_GLOBAL 2.117 ms [2.065 ms, 2.169 ms] 650.245 µs (44.3%)
profiling 1.939 ms [1.896 ms, 1.981 ms] 471.941 µs (32.2%)
tracing 1.914 ms [1.875 ms, 1.954 ms] 447.536 µs (30.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~fd2ce3c320, baseline=1.42.0-SNAPSHOT~d446c8523f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.138 s) : 15138000, 15138000
.   : milestone, 15138000,
appsec (15.226 s) : 15226000, 15226000
.   : milestone, 15226000,
iast (18.726 s) : 18726000, 18726000
.   : milestone, 18726000,
iast_GLOBAL (18.204 s) : 18204000, 18204000
.   : milestone, 18204000,
profiling (15.218 s) : 15218000, 15218000
.   : milestone, 15218000,
tracing (15.238 s) : 15238000, 15238000
.   : milestone, 15238000,
section candidate
no_agent (14.974 s) : 14974000, 14974000
.   : milestone, 14974000,
appsec (15.352 s) : 15352000, 15352000
.   : milestone, 15352000,
iast (19.114 s) : 19114000, 19114000
.   : milestone, 19114000,
iast_GLOBAL (17.919 s) : 17919000, 17919000
.   : milestone, 17919000,
profiling (15.535 s) : 15535000, 15535000
.   : milestone, 15535000,
tracing (15.15 s) : 15150000, 15150000
.   : milestone, 15150000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.138 s [15.138 s, 15.138 s] -
appsec 15.226 s [15.226 s, 15.226 s] 88.0 ms (0.6%)
iast 18.726 s [18.726 s, 18.726 s] 3.588 s (23.7%)
iast_GLOBAL 18.204 s [18.204 s, 18.204 s] 3.066 s (20.3%)
profiling 15.218 s [15.218 s, 15.218 s] 80.0 ms (0.5%)
tracing 15.238 s [15.238 s, 15.238 s] 100.0 ms (0.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.974 s [14.974 s, 14.974 s] -
appsec 15.352 s [15.352 s, 15.352 s] 378.0 ms (2.5%)
iast 19.114 s [19.114 s, 19.114 s] 4.14 s (27.6%)
iast_GLOBAL 17.919 s [17.919 s, 17.919 s] 2.945 s (19.7%)
profiling 15.535 s [15.535 s, 15.535 s] 561.0 ms (3.7%)
tracing 15.15 s [15.15 s, 15.15 s] 176.0 ms (1.2%)

@richardstartin richardstartin merged commit 1508cef into master Oct 22, 2024
100 of 102 checks passed
@richardstartin richardstartin deleted the rgs/unwrap-netty-writetask branch October 22, 2024 11:57
@github-actions github-actions bot added this to the 1.42.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

Assignees
No one assigned
Labels
comp: profiling Profiling
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@richardstartin @amarziali