Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce aggregated smap events (enabled by default) #7820

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Introduce aggregated smap events (enabled by default) #7820

merged 6 commits into from
Oct 23, 2024

Conversation

MattAlp
Copy link
Contributor

@MattAlp MattAlp commented Oct 21, 2024 •
edited by jira bot
Loading

What Does This Do

This introduces a new event type that records smap events aggregated by NMT category rather than individual smap events for every single map reported by the OS. This feature is enabled by default but can be overridden for customers interested in seeing granular info.

Motivation

Due to the usually-high number of maps created by the JVM, recording every single smap entry tends to bloat uploaded profile sizes. We currently only make use of the RSS property from the individual smap events, rather than everything scraped, so this feature restricts collection to only the data needed (unless overridden).

Additional Notes

We may want to follow fast with a PSS property as well. Will squash and merge on approval.

Contributor Checklist

Jira ticket: PROF-10767

@MattAlp MattAlp added type: enhancement tag: performance Performance related changes comp: profiling Profiling labels Oct 21, 2024
@MattAlp MattAlp requested review from a team as code owners October 21, 2024 21:06
@MattAlp MattAlp requested a review from smola October 21, 2024 21:06
@pr-commenter
Copy link

pr-commenter bot commented Oct 21, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mattalp/aggregate-smap-events-by-default
git_commit_date 1729584822 1729595654
git_commit_sha d446c85 bd3b827
release_version 1.42.0-SNAPSHOT~d446c8523f 1.42.0-SNAPSHOT~bd3b827fae
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729598120 1729598120
ci_job_id 679739995 679739995
ci_pipeline_id 47130035 47130035
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~bd3b827fae, baseline=1.42.0-SNAPSHOT~d446c8523f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080697
Total [baseline] (8.574 s) : 0, 8574277
Agent [candidate] (1.079 s) : 0, 1079105
Total [candidate] (8.575 s) : 0, 8575295
section iast
Agent [baseline] (1.207 s) : 0, 1206929
Total [baseline] (9.109 s) : 0, 9109120
Agent [candidate] (1.2 s) : 0, 1200170
Total [candidate] (9.11 s) : 0, 9110498
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.2 s) : 0, 1199724
Total [baseline] (9.091 s) : 0, 9090605
Agent [candidate] (1.202 s) : 0, 1201713
Total [candidate] (9.124 s) : 0, 9123639
section iast_TELEMETRY_OFF
Agent [baseline] (1.215 s) : 0, 1215300
Total [baseline] (9.131 s) : 0, 9130555
Agent [candidate] (1.201 s) : 0, 1201294
Total [candidate] (9.122 s) : 0, 9121791
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.207 s 126.232 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.2 s 119.027 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.215 s 134.602 ms (12.5%)
Total tracing 8.574 s -
Total iast 9.109 s 534.844 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.091 s 516.329 ms (6.0%)
Total iast_TELEMETRY_OFF 9.131 s 556.279 ms (6.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent iast 1.2 s 121.064 ms (11.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.202 s 122.607 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.201 s 122.189 ms (11.3%)
Total tracing 8.575 s -
Total iast 9.11 s 535.202 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.124 s 548.344 ms (6.4%)
Total iast_TELEMETRY_OFF 9.122 s 546.495 ms (6.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~bd3b827fae, baseline=1.42.0-SNAPSHOT~d446c8523f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.516 ms) : 0, 689516
BytebuddyAgent [candidate] (685.918 ms) : 0, 685918
GlobalTracer [baseline] (314.237 ms) : 0, 314237
GlobalTracer [candidate] (313.613 ms) : 0, 313613
AppSec [baseline] (54.316 ms) : 0, 54316
AppSec [candidate] (54.219 ms) : 0, 54219
Remote Config [baseline] (669.754 µs) : 0, 670
Remote Config [candidate] (672.183 µs) : 0, 672
Telemetry [baseline] (8.172 ms) : 0, 8172
Telemetry [candidate] (10.975 ms) : 0, 10975
section iast
BytebuddyAgent [baseline] (805.062 ms) : 0, 805062
BytebuddyAgent [candidate] (798.906 ms) : 0, 798906
GlobalTracer [baseline] (302.832 ms) : 0, 302832
GlobalTracer [candidate] (301.735 ms) : 0, 301735
AppSec [baseline] (56.389 ms) : 0, 56389
AppSec [candidate] (57.777 ms) : 0, 57777
Remote Config [baseline] (597.181 µs) : 0, 597
Remote Config [candidate] (598.195 µs) : 0, 598
Telemetry [baseline] (7.927 ms) : 0, 7927
Telemetry [candidate] (7.107 ms) : 0, 7107
IAST [baseline] (20.35 ms) : 0, 20350
IAST [candidate] (20.345 ms) : 0, 20345
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.749 ms) : 0, 798749
BytebuddyAgent [candidate] (800.221 ms) : 0, 800221
GlobalTracer [baseline] (301.097 ms) : 0, 301097
GlobalTracer [candidate] (301.9 ms) : 0, 301900
AppSec [baseline] (57.937 ms) : 0, 57937
AppSec [candidate] (56.812 ms) : 0, 56812
Remote Config [baseline] (606.8 µs) : 0, 607
Remote Config [candidate] (608.479 µs) : 0, 608
Telemetry [baseline] (7.153 ms) : 0, 7153
Telemetry [candidate] (7.098 ms) : 0, 7098
IAST [baseline] (20.423 ms) : 0, 20423
IAST [candidate] (21.376 ms) : 0, 21376
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (809.007 ms) : 0, 809007
BytebuddyAgent [candidate] (799.831 ms) : 0, 799831
GlobalTracer [baseline] (305.35 ms) : 0, 305350
GlobalTracer [candidate] (302.66 ms) : 0, 302660
AppSec [baseline] (58.694 ms) : 0, 58694
AppSec [candidate] (56.011 ms) : 0, 56011
Remote Config [baseline] (630.133 µs) : 0, 630
Remote Config [candidate] (592.562 µs) : 0, 593
Telemetry [baseline] (7.151 ms) : 0, 7151
Telemetry [candidate] (7.727 ms) : 0, 7727
IAST [baseline] (20.579 ms) : 0, 20579
IAST [candidate] (20.703 ms) : 0, 20703
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~bd3b827fae, baseline=1.42.0-SNAPSHOT~d446c8523f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.1 s) : 0, 1100170
Total [baseline] (10.473 s) : 0, 10473074
Agent [candidate] (1.076 s) : 0, 1075748
Total [candidate] (10.342 s) : 0, 10342482
section appsec
Agent [baseline] (1.21 s) : 0, 1210007
Total [baseline] (10.682 s) : 0, 10681751
Agent [candidate] (1.213 s) : 0, 1212560
Total [candidate] (10.654 s) : 0, 10653683
section iast
Agent [baseline] (1.21 s) : 0, 1209908
Total [baseline] (10.911 s) : 0, 10911210
Agent [candidate] (1.213 s) : 0, 1212590
Total [candidate] (10.902 s) : 0, 10901607
section profiling
Agent [baseline] (1.271 s) : 0, 1270693
Total [baseline] (10.674 s) : 0, 10674206
Agent [candidate] (1.272 s) : 0, 1272268
Total [candidate] (10.744 s) : 0, 10743504
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.1 s -
Agent appsec 1.21 s 109.837 ms (10.0%)
Agent iast 1.21 s 109.738 ms (10.0%)
Agent profiling 1.271 s 170.523 ms (15.5%)
Total tracing 10.473 s -
Total appsec 10.682 s 208.678 ms (2.0%)
Total iast 10.911 s 438.136 ms (4.2%)
Total profiling 10.674 s 201.133 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.213 s 136.812 ms (12.7%)
Agent iast 1.213 s 136.842 ms (12.7%)
Agent profiling 1.272 s 196.52 ms (18.3%)
Total tracing 10.342 s -
Total appsec 10.654 s 311.2 ms (3.0%)
Total iast 10.902 s 559.125 ms (5.4%)
Total profiling 10.744 s 401.022 ms (3.9%) 
gantt
    title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~bd3b827fae, baseline=1.42.0-SNAPSHOT~d446c8523f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (701.039 ms) : 0, 701039
BytebuddyAgent [candidate] (686.422 ms) : 0, 686422
GlobalTracer [baseline] (319.366 ms) : 0, 319366
GlobalTracer [candidate] (312.747 ms) : 0, 312747
AppSec [baseline] (55.233 ms) : 0, 55233
AppSec [candidate] (54.093 ms) : 0, 54093
Remote Config [baseline] (691.388 µs) : 0, 691
Remote Config [candidate] (660.091 µs) : 0, 660
Telemetry [baseline] (9.858 ms) : 0, 9858
Telemetry [candidate] (8.155 ms) : 0, 8155
section appsec
BytebuddyAgent [baseline] (701.86 ms) : 0, 701860
BytebuddyAgent [candidate] (704.306 ms) : 0, 704306
GlobalTracer [baseline] (310.97 ms) : 0, 310970
GlobalTracer [candidate] (310.647 ms) : 0, 310647
AppSec [baseline] (165.427 ms) : 0, 165427
AppSec [candidate] (166.218 ms) : 0, 166218
Remote Config [baseline] (638.421 µs) : 0, 638
Remote Config [candidate] (638.133 µs) : 0, 638
Telemetry [baseline] (7.05 ms) : 0, 7050
Telemetry [candidate] (7.78 ms) : 0, 7780
IAST [baseline] (20.793 ms) : 0, 20793
IAST [candidate] (18.392 ms) : 0, 18392
section iast
BytebuddyAgent [baseline] (805.959 ms) : 0, 805959
BytebuddyAgent [candidate] (808.484 ms) : 0, 808484
GlobalTracer [baseline] (303.885 ms) : 0, 303885
GlobalTracer [candidate] (304.274 ms) : 0, 304274
AppSec [baseline] (57.706 ms) : 0, 57706
AppSec [candidate] (57.55 ms) : 0, 57550
Remote Config [baseline] (622.191 µs) : 0, 622
Remote Config [candidate] (605.953 µs) : 0, 606
Telemetry [baseline] (7.169 ms) : 0, 7169
Telemetry [candidate] (7.113 ms) : 0, 7113
IAST [baseline] (20.795 ms) : 0, 20795
IAST [candidate] (20.72 ms) : 0, 20720
section profiling
ProfilingAgent [baseline] (92.263 ms) : 0, 92263
ProfilingAgent [candidate] (92.15 ms) : 0, 92150
BytebuddyAgent [baseline] (677.849 ms) : 0, 677849
BytebuddyAgent [candidate] (678.495 ms) : 0, 678495
GlobalTracer [baseline] (395.864 ms) : 0, 395864
GlobalTracer [candidate] (395.989 ms) : 0, 395989
AppSec [baseline] (54.404 ms) : 0, 54404
AppSec [candidate] (54.555 ms) : 0, 54555
Remote Config [baseline] (647.957 µs) : 0, 648
Remote Config [candidate] (649.685 µs) : 0, 650
Telemetry [baseline] (10.979 ms) : 0, 10979
Telemetry [candidate] (11.654 ms) : 0, 11654
Profiling [baseline] (92.286 ms) : 0, 92286
Profiling [candidate] (92.173 ms) : 0, 92173
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-22T11:25:45 2024-10-22T11:32:37
git_branch master mattalp/aggregate-smap-events-by-default
git_commit_date 1729584822 1729595654
git_commit_sha d446c85 bd3b827
release_version 1.42.0-SNAPSHOT~d446c8523f 1.42.0-SNAPSHOT~bd3b827fae
start_time 2024-10-22T11:25:32 2024-10-22T11:32:24
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729597104 1729597104
ci_job_id 679739996 679739996
ci_pipeline_id 47130035 47130035
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~bd3b827fae, baseline=1.42.0-SNAPSHOT~d446c8523f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.338 ms) : 1318, 1358
.   : milestone, 1338,
appsec (1.732 ms) : 1709, 1756
.   : milestone, 1732,
appsec_no_iast (1.744 ms) : 1721, 1768
.   : milestone, 1744,
iast (1.473 ms) : 1450, 1496
.   : milestone, 1473,
profiling (1.518 ms) : 1494, 1543
.   : milestone, 1518,
tracing (1.471 ms) : 1447, 1495
.   : milestone, 1471,
section candidate
no_agent (1.348 ms) : 1329, 1367
.   : milestone, 1348,
appsec (1.71 ms) : 1686, 1734
.   : milestone, 1710,
appsec_no_iast (1.721 ms) : 1697, 1745
.   : milestone, 1721,
iast (1.475 ms) : 1452, 1498
.   : milestone, 1475,
profiling (1.544 ms) : 1521, 1568
.   : milestone, 1544,
tracing (1.452 ms) : 1428, 1477
.   : milestone, 1452,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.338 ms [1.318 ms, 1.358 ms] -
appsec 1.732 ms [1.709 ms, 1.756 ms] 394.254 µs (29.5%)
appsec_no_iast 1.744 ms [1.721 ms, 1.768 ms] 406.425 µs (30.4%)
iast 1.473 ms [1.45 ms, 1.496 ms] 134.682 µs (10.1%)
profiling 1.518 ms [1.494 ms, 1.543 ms] 180.259 µs (13.5%)
tracing 1.471 ms [1.447 ms, 1.495 ms] 132.932 µs (9.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.329 ms, 1.367 ms] -
appsec 1.71 ms [1.686 ms, 1.734 ms] 362.513 µs (26.9%)
appsec_no_iast 1.721 ms [1.697 ms, 1.745 ms] 373.158 µs (27.7%)
iast 1.475 ms [1.452 ms, 1.498 ms] 127.349 µs (9.4%)
profiling 1.544 ms [1.521 ms, 1.568 ms] 196.404 µs (14.6%)
tracing 1.452 ms [1.428 ms, 1.477 ms] 104.305 µs (7.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~bd3b827fae, baseline=1.42.0-SNAPSHOT~d446c8523f
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.022 µs) : 353, 395
.   : milestone, 374,
iast (494.463 µs) : 472, 517
.   : milestone, 494,
iast_FULL (562.409 µs) : 541, 584
.   : milestone, 562,
iast_GLOBAL (514.059 µs) : 492, 536
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (484.686 µs) : 464, 506
.   : milestone, 485,
iast_INACTIVE (453.687 µs) : 432, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (473.092 µs) : 452, 494
.   : milestone, 473,
tracing (446.727 µs) : 426, 467
.   : milestone, 447,
section candidate
no_agent (371.68 µs) : 352, 391
.   : milestone, 372,
iast (490.746 µs) : 469, 513
.   : milestone, 491,
iast_FULL (553.655 µs) : 532, 575
.   : milestone, 554,
iast_GLOBAL (510.368 µs) : 489, 531
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (485.78 µs) : 464, 507
.   : milestone, 486,
iast_INACTIVE (447.431 µs) : 427, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (481.167 µs) : 459, 503
.   : milestone, 481,
tracing (439.859 µs) : 420, 460
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.022 µs [352.849 µs, 395.194 µs] -
iast 494.463 µs [472.3 µs, 516.626 µs] 120.441 µs (32.2%)
iast_FULL 562.409 µs [541.175 µs, 583.643 µs] 188.387 µs (50.4%)
iast_GLOBAL 514.059 µs [492.252 µs, 535.866 µs] 140.037 µs (37.4%)
iast_HARDCODED_SECRET_DISABLED 484.686 µs [463.591 µs, 505.781 µs] 110.664 µs (29.6%)
iast_INACTIVE 453.687 µs [432.351 µs, 475.023 µs] 79.665 µs (21.3%)
iast_TELEMETRY_OFF 473.092 µs [451.742 µs, 494.443 µs] 99.071 µs (26.5%)
tracing 446.727 µs [426.131 µs, 467.323 µs] 72.705 µs (19.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.68 µs [352.139 µs, 391.222 µs] -
iast 490.746 µs [468.833 µs, 512.659 µs] 119.066 µs (32.0%)
iast_FULL 553.655 µs [532.478 µs, 574.832 µs] 181.974 µs (49.0%)
iast_GLOBAL 510.368 µs [489.303 µs, 531.433 µs] 138.687 µs (37.3%)
iast_HARDCODED_SECRET_DISABLED 485.78 µs [464.106 µs, 507.454 µs] 114.1 µs (30.7%)
iast_INACTIVE 447.431 µs [426.966 µs, 467.896 µs] 75.75 µs (20.4%)
iast_TELEMETRY_OFF 481.167 µs [459.493 µs, 502.84 µs] 109.486 µs (29.5%)
tracing 439.859 µs [419.549 µs, 460.169 µs] 68.179 µs (18.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mattalp/aggregate-smap-events-by-default
git_commit_date 1729584822 1729595654
git_commit_sha d446c85 bd3b827
release_version 1.42.0-SNAPSHOT~d446c8523f 1.42.0-SNAPSHOT~bd3b827fae
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1729597656 1729597656
ci_job_id 679739997 679739997
ci_pipeline_id 47130035 47130035
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~bd3b827fae, baseline=1.42.0-SNAPSHOT~d446c8523f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.456 ms) : 1445, 1468
.   : milestone, 1456,
appsec (2.316 ms) : 2275, 2357
.   : milestone, 2316,
iast (2.059 ms) : 2007, 2110
.   : milestone, 2059,
iast_GLOBAL (2.112 ms) : 2060, 2164
.   : milestone, 2112,
profiling (1.926 ms) : 1883, 1968
.   : milestone, 1926,
tracing (1.904 ms) : 1865, 1944
.   : milestone, 1904,
section candidate
no_agent (1.462 ms) : 1451, 1474
.   : milestone, 1462,
appsec (2.312 ms) : 2271, 2353
.   : milestone, 2312,
iast (2.068 ms) : 2015, 2120
.   : milestone, 2068,
iast_GLOBAL (2.118 ms) : 2066, 2171
.   : milestone, 2118,
profiling (1.932 ms) : 1889, 1975
.   : milestone, 1932,
tracing (1.902 ms) : 1863, 1942
.   : milestone, 1902,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.445 ms, 1.468 ms] -
appsec 2.316 ms [2.275 ms, 2.357 ms] 859.667 µs (59.0%)
iast 2.059 ms [2.007 ms, 2.11 ms] 602.625 µs (41.4%)
iast_GLOBAL 2.112 ms [2.06 ms, 2.164 ms] 655.792 µs (45.0%)
profiling 1.926 ms [1.883 ms, 1.968 ms] 469.407 µs (32.2%)
tracing 1.904 ms [1.865 ms, 1.944 ms] 447.96 µs (30.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.474 ms] -
appsec 2.312 ms [2.271 ms, 2.353 ms] 849.525 µs (58.1%)
iast 2.068 ms [2.015 ms, 2.12 ms] 605.505 µs (41.4%)
iast_GLOBAL 2.118 ms [2.066 ms, 2.171 ms] 656.016 µs (44.9%)
profiling 1.932 ms [1.889 ms, 1.975 ms] 469.835 µs (32.1%)
tracing 1.902 ms [1.863 ms, 1.942 ms] 440.198 µs (30.1%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~bd3b827fae, baseline=1.42.0-SNAPSHOT~d446c8523f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.395 s) : 15395000, 15395000
.   : milestone, 15395000,
appsec (15.45 s) : 15450000, 15450000
.   : milestone, 15450000,
iast (18.84 s) : 18840000, 18840000
.   : milestone, 18840000,
iast_GLOBAL (17.951 s) : 17951000, 17951000
.   : milestone, 17951000,
profiling (15.077 s) : 15077000, 15077000
.   : milestone, 15077000,
tracing (15.127 s) : 15127000, 15127000
.   : milestone, 15127000,
section candidate
no_agent (15.052 s) : 15052000, 15052000
.   : milestone, 15052000,
appsec (15.116 s) : 15116000, 15116000
.   : milestone, 15116000,
iast (18.89 s) : 18890000, 18890000
.   : milestone, 18890000,
iast_GLOBAL (18.089 s) : 18089000, 18089000
.   : milestone, 18089000,
profiling (15.081 s) : 15081000, 15081000
.   : milestone, 15081000,
tracing (15.361 s) : 15361000, 15361000
.   : milestone, 15361000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.395 s [15.395 s, 15.395 s] -
appsec 15.45 s [15.45 s, 15.45 s] 55.0 ms (0.4%)
iast 18.84 s [18.84 s, 18.84 s] 3.445 s (22.4%)
iast_GLOBAL 17.951 s [17.951 s, 17.951 s] 2.556 s (16.6%)
profiling 15.077 s [15.077 s, 15.077 s] -318.0 ms (-2.1%)
tracing 15.127 s [15.127 s, 15.127 s] -268.0 ms (-1.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.052 s [15.052 s, 15.052 s] -
appsec 15.116 s [15.116 s, 15.116 s] 64.0 ms (0.4%)
iast 18.89 s [18.89 s, 18.89 s] 3.838 s (25.5%)
iast_GLOBAL 18.089 s [18.089 s, 18.089 s] 3.037 s (20.2%)
profiling 15.081 s [15.081 s, 15.081 s] 29.0 ms (0.2%)
tracing 15.361 s [15.361 s, 15.361 s] 309.0 ms (2.1%)

@richardstartin
Copy link
Member

Looks good, except there are some System.out.printlns you'll need to remove.

@MattAlp MattAlp merged commit 2153fe5 into master Oct 23, 2024
104 checks passed
@MattAlp MattAlp deleted the mattalp/aggregate-smap-events-by-default branch October 23, 2024 14:24
@github-actions github-actions bot added this to the 1.42.0 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datadog-datadog-prod-us1 datadog-datadog-prod-us1[bot] datadog-datadog-prod-us1[bot] left review comments

@richardstartin richardstartin richardstartin approved these changes

@jbachorik jbachorik jbachorik approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: profiling Profiling tag: performance Performance related changes type: enhancement
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MattAlp @richardstartin @jbachorik