-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code coverage percentage reporting for Android projects #7815
Merged
nikita-tkachenko-datadog
merged 2 commits into
master
from
nikita-tkachenko/android-code-coverage
Oct 23, 2024
Merged
Fix code coverage percentage reporting for Android projects #7815
nikita-tkachenko-datadog
merged 2 commits into
master
from
nikita-tkachenko/android-code-coverage
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
type: bug
comp: ci visibility
Continuous Integration Visibility
labels
Oct 21, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~c9e1416925, baseline=1.42.0-SNAPSHOT~f687c2d038
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078618
Total [baseline] (8.552 s) : 0, 8551589
Agent [candidate] (1.076 s) : 0, 1076398
Total [candidate] (8.567 s) : 0, 8567221
section iast
Agent [baseline] (1.208 s) : 0, 1208203
Total [baseline] (9.121 s) : 0, 9121127
Agent [candidate] (1.208 s) : 0, 1207508
Total [candidate] (9.102 s) : 0, 9101898
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.205 s) : 0, 1205111
Total [baseline] (9.101 s) : 0, 9100816
Agent [candidate] (1.205 s) : 0, 1204694
Total [candidate] (9.118 s) : 0, 9118041
section iast_TELEMETRY_OFF
Agent [baseline] (1.196 s) : 0, 1196097
Total [baseline] (9.121 s) : 0, 9121264
Agent [candidate] (1.198 s) : 0, 1197845
Total [candidate] (9.144 s) : 0, 9144264
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~c9e1416925, baseline=1.42.0-SNAPSHOT~f687c2d038
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.21 ms) : 0, 687210
BytebuddyAgent [candidate] (685.021 ms) : 0, 685021
GlobalTracer [baseline] (313.087 ms) : 0, 313087
GlobalTracer [candidate] (312.916 ms) : 0, 312916
AppSec [baseline] (54.242 ms) : 0, 54242
AppSec [candidate] (53.774 ms) : 0, 53774
Remote Config [baseline] (683.88 µs) : 0, 684
Remote Config [candidate] (676.569 µs) : 0, 677
Telemetry [baseline] (9.678 ms) : 0, 9678
Telemetry [candidate] (10.269 ms) : 0, 10269
section iast
BytebuddyAgent [baseline] (805.31 ms) : 0, 805310
BytebuddyAgent [candidate] (805.061 ms) : 0, 805061
GlobalTracer [baseline] (303.714 ms) : 0, 303714
GlobalTracer [candidate] (303.252 ms) : 0, 303252
AppSec [baseline] (55.941 ms) : 0, 55941
AppSec [candidate] (56.859 ms) : 0, 56859
IAST [baseline] (21.811 ms) : 0, 21811
IAST [candidate] (20.922 ms) : 0, 20922
Remote Config [baseline] (612.062 µs) : 0, 612
Remote Config [candidate] (601.129 µs) : 0, 601
Telemetry [baseline] (7.057 ms) : 0, 7057
Telemetry [candidate] (7.031 ms) : 0, 7031
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (803.71 ms) : 0, 803710
BytebuddyAgent [candidate] (802.275 ms) : 0, 802275
GlobalTracer [baseline] (302.054 ms) : 0, 302054
GlobalTracer [candidate] (302.548 ms) : 0, 302548
AppSec [baseline] (57.358 ms) : 0, 57358
AppSec [candidate] (57.03 ms) : 0, 57030
IAST [baseline] (20.483 ms) : 0, 20483
IAST [candidate] (21.319 ms) : 0, 21319
Remote Config [baseline] (605.822 µs) : 0, 606
Remote Config [candidate] (610.435 µs) : 0, 610
Telemetry [baseline] (7.108 ms) : 0, 7108
Telemetry [candidate] (7.156 ms) : 0, 7156
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (795.54 ms) : 0, 795540
BytebuddyAgent [candidate] (796.695 ms) : 0, 796695
GlobalTracer [baseline] (301.265 ms) : 0, 301265
GlobalTracer [candidate] (301.906 ms) : 0, 301906
AppSec [baseline] (57.945 ms) : 0, 57945
AppSec [candidate] (57.74 ms) : 0, 57740
IAST [baseline] (20.056 ms) : 0, 20056
IAST [candidate] (20.145 ms) : 0, 20145
Remote Config [baseline] (613.64 µs) : 0, 614
Remote Config [candidate] (618.041 µs) : 0, 618
Telemetry [baseline] (7.021 ms) : 0, 7021
Telemetry [candidate] (7.055 ms) : 0, 7055
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~c9e1416925, baseline=1.42.0-SNAPSHOT~f687c2d038
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1074801
Total [baseline] (10.473 s) : 0, 10472625
Agent [candidate] (1.076 s) : 0, 1075767
Total [candidate] (10.443 s) : 0, 10443044
section appsec
Agent [baseline] (1.213 s) : 0, 1213075
Total [baseline] (10.605 s) : 0, 10604539
Agent [candidate] (1.212 s) : 0, 1212446
Total [candidate] (10.64 s) : 0, 10640105
section iast
Agent [baseline] (1.201 s) : 0, 1201294
Total [baseline] (10.863 s) : 0, 10862804
Agent [candidate] (1.21 s) : 0, 1209583
Total [candidate] (10.917 s) : 0, 10917147
section profiling
Agent [baseline] (1.271 s) : 0, 1270771
Total [baseline] (10.675 s) : 0, 10675327
Agent [candidate] (1.274 s) : 0, 1274351
Total [candidate] (10.691 s) : 0, 10691356
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~c9e1416925, baseline=1.42.0-SNAPSHOT~f687c2d038
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.657 ms) : 0, 684657
BytebuddyAgent [candidate] (686.155 ms) : 0, 686155
GlobalTracer [baseline] (313.142 ms) : 0, 313142
GlobalTracer [candidate] (313.175 ms) : 0, 313175
AppSec [baseline] (53.83 ms) : 0, 53830
AppSec [candidate] (53.852 ms) : 0, 53852
Remote Config [baseline] (667.595 µs) : 0, 668
Remote Config [candidate] (670.575 µs) : 0, 671
Telemetry [baseline] (8.849 ms) : 0, 8849
Telemetry [candidate] (8.233 ms) : 0, 8233
section appsec
BytebuddyAgent [baseline] (704.562 ms) : 0, 704562
BytebuddyAgent [candidate] (702.768 ms) : 0, 702768
GlobalTracer [baseline] (311.349 ms) : 0, 311349
GlobalTracer [candidate] (311.035 ms) : 0, 311035
AppSec [baseline] (164.67 ms) : 0, 164670
AppSec [candidate] (165.989 ms) : 0, 165989
Remote Config [baseline] (640.744 µs) : 0, 641
Remote Config [candidate] (636.302 µs) : 0, 636
Telemetry [baseline] (7.793 ms) : 0, 7793
Telemetry [candidate] (7.482 ms) : 0, 7482
IAST [baseline] (20.729 ms) : 0, 20729
IAST [candidate] (21.741 ms) : 0, 21741
section iast
BytebuddyAgent [baseline] (799.599 ms) : 0, 799599
BytebuddyAgent [candidate] (806.108 ms) : 0, 806108
GlobalTracer [baseline] (302.327 ms) : 0, 302327
GlobalTracer [candidate] (303.678 ms) : 0, 303678
AppSec [baseline] (56.253 ms) : 0, 56253
AppSec [candidate] (57.731 ms) : 0, 57731
Remote Config [baseline] (596.627 µs) : 0, 597
Remote Config [candidate] (617.84 µs) : 0, 618
Telemetry [baseline] (7.846 ms) : 0, 7846
Telemetry [candidate] (7.14 ms) : 0, 7140
IAST [baseline] (21.007 ms) : 0, 21007
IAST [candidate] (20.559 ms) : 0, 20559
section profiling
ProfilingAgent [baseline] (89.87 ms) : 0, 89870
ProfilingAgent [candidate] (92.512 ms) : 0, 92512
BytebuddyAgent [baseline] (678.007 ms) : 0, 678007
BytebuddyAgent [candidate] (679.704 ms) : 0, 679704
GlobalTracer [baseline] (396.295 ms) : 0, 396295
GlobalTracer [candidate] (396.476 ms) : 0, 396476
AppSec [baseline] (54.289 ms) : 0, 54289
AppSec [candidate] (54.676 ms) : 0, 54676
Remote Config [baseline] (650.347 µs) : 0, 650
Remote Config [candidate] (650.516 µs) : 0, 651
Telemetry [baseline] (13.007 ms) : 0, 13007
Telemetry [candidate] (11.588 ms) : 0, 11588
Profiling [baseline] (89.894 ms) : 0, 89894
Profiling [candidate] (92.535 ms) : 0, 92535
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~c9e1416925, baseline=1.42.0-SNAPSHOT~f687c2d038
dateFormat X
axisFormat %s
section baseline
no_agent (378.97 µs) : 359, 399
. : milestone, 379,
iast (486.636 µs) : 465, 508
. : milestone, 487,
iast_FULL (557.088 µs) : 536, 579
. : milestone, 557,
iast_GLOBAL (517.653 µs) : 495, 540
. : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (489.658 µs) : 469, 511
. : milestone, 490,
iast_INACTIVE (451.565 µs) : 431, 473
. : milestone, 452,
iast_TELEMETRY_OFF (477.325 µs) : 456, 499
. : milestone, 477,
tracing (453.637 µs) : 433, 474
. : milestone, 454,
section candidate
no_agent (380.236 µs) : 360, 400
. : milestone, 380,
iast (491.486 µs) : 470, 513
. : milestone, 491,
iast_FULL (553.856 µs) : 533, 575
. : milestone, 554,
iast_GLOBAL (513.685 µs) : 492, 535
. : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (491.064 µs) : 470, 512
. : milestone, 491,
iast_INACTIVE (453.684 µs) : 433, 475
. : milestone, 454,
iast_TELEMETRY_OFF (480.092 µs) : 459, 502
. : milestone, 480,
tracing (445.447 µs) : 425, 466
. : milestone, 445,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~c9e1416925, baseline=1.42.0-SNAPSHOT~f687c2d038
dateFormat X
axisFormat %s
section baseline
no_agent (1.342 ms) : 1322, 1361
. : milestone, 1342,
appsec (1.724 ms) : 1701, 1747
. : milestone, 1724,
appsec_no_iast (1.718 ms) : 1694, 1742
. : milestone, 1718,
iast (1.471 ms) : 1448, 1494
. : milestone, 1471,
profiling (1.488 ms) : 1466, 1511
. : milestone, 1488,
tracing (1.472 ms) : 1448, 1496
. : milestone, 1472,
section candidate
no_agent (1.353 ms) : 1334, 1373
. : milestone, 1353,
appsec (1.718 ms) : 1693, 1742
. : milestone, 1718,
appsec_no_iast (1.75 ms) : 1725, 1774
. : milestone, 1750,
iast (1.494 ms) : 1471, 1517
. : milestone, 1494,
profiling (1.486 ms) : 1463, 1509
. : milestone, 1486,
tracing (1.46 ms) : 1435, 1484
. : milestone, 1460,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~c9e1416925, baseline=1.42.0-SNAPSHOT~f687c2d038
dateFormat X
axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1477
. : milestone, 1465,
appsec (2.312 ms) : 2272, 2353
. : milestone, 2312,
iast (2.065 ms) : 2014, 2117
. : milestone, 2065,
iast_GLOBAL (2.111 ms) : 2058, 2164
. : milestone, 2111,
profiling (1.949 ms) : 1907, 1991
. : milestone, 1949,
tracing (1.91 ms) : 1871, 1949
. : milestone, 1910,
section candidate
no_agent (1.466 ms) : 1454, 1478
. : milestone, 1466,
appsec (2.335 ms) : 2294, 2376
. : milestone, 2335,
iast (2.072 ms) : 2020, 2124
. : milestone, 2072,
iast_GLOBAL (2.114 ms) : 2062, 2167
. : milestone, 2114,
profiling (1.934 ms) : 1892, 1977
. : milestone, 1934,
tracing (1.916 ms) : 1876, 1955
. : milestone, 1916,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~c9e1416925, baseline=1.42.0-SNAPSHOT~f687c2d038
dateFormat X
axisFormat %s
section baseline
no_agent (15.071 s) : 15071000, 15071000
. : milestone, 15071000,
appsec (15.152 s) : 15152000, 15152000
. : milestone, 15152000,
iast (18.942 s) : 18942000, 18942000
. : milestone, 18942000,
iast_GLOBAL (18.029 s) : 18029000, 18029000
. : milestone, 18029000,
profiling (15.744 s) : 15744000, 15744000
. : milestone, 15744000,
tracing (15.293 s) : 15293000, 15293000
. : milestone, 15293000,
section candidate
no_agent (15.554 s) : 15554000, 15554000
. : milestone, 15554000,
appsec (15.23 s) : 15230000, 15230000
. : milestone, 15230000,
iast (19.087 s) : 19087000, 19087000
. : milestone, 19087000,
iast_GLOBAL (18.198 s) : 18198000, 18198000
. : milestone, 18198000,
profiling (15.203 s) : 15203000, 15203000
. : milestone, 15203000,
tracing (15.149 s) : 15149000, 15149000
. : milestone, 15149000,
|
tonyredondo
approved these changes
Oct 23, 2024
romainkomorndatadog
approved these changes
Oct 23, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/android-code-coverage
branch
October 23, 2024 08:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fixes code coverage percentage reporting for Android Gradle projects.
Motivation
Gradle projects for Android have a different structure, so calculating source sets (folders for code sources and compiled classes) has to be done differently for them.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-979