-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower log level for duplicate repo index keys warning #7814
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/lower-log-level-duplicate-source-paths
Oct 23, 2024
Merged
Lower log level for duplicate repo index keys warning #7814
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/lower-log-level-duplicate-source-paths
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
the
comp: ci visibility
Continuous Integration Visibility
label
Oct 21, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~5fd0377579, baseline=1.42.0-SNAPSHOT~f687c2d038
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077655
Total [baseline] (8.543 s) : 0, 8542649
Agent [candidate] (1.082 s) : 0, 1082055
Total [candidate] (8.545 s) : 0, 8544629
section iast
Agent [baseline] (1.221 s) : 0, 1221228
Total [baseline] (9.164 s) : 0, 9163762
Agent [candidate] (1.215 s) : 0, 1214710
Total [candidate] (9.148 s) : 0, 9147633
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.205 s) : 0, 1204928
Total [baseline] (9.075 s) : 0, 9075436
Agent [candidate] (1.2 s) : 0, 1200054
Total [candidate] (9.075 s) : 0, 9074896
section iast_TELEMETRY_OFF
Agent [baseline] (1.195 s) : 0, 1194797
Total [baseline] (9.088 s) : 0, 9087536
Agent [candidate] (1.194 s) : 0, 1193718
Total [candidate] (9.059 s) : 0, 9059497
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~5fd0377579, baseline=1.42.0-SNAPSHOT~f687c2d038
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.267 ms) : 0, 685267
BytebuddyAgent [candidate] (689.643 ms) : 0, 689643
GlobalTracer [baseline] (312.18 ms) : 0, 312180
GlobalTracer [candidate] (314.222 ms) : 0, 314222
AppSec [baseline] (53.534 ms) : 0, 53534
AppSec [candidate] (54.243 ms) : 0, 54243
Remote Config [baseline] (664.443 µs) : 0, 664
Remote Config [candidate] (669.086 µs) : 0, 669
Telemetry [baseline] (12.385 ms) : 0, 12385
Telemetry [candidate] (9.57 ms) : 0, 9570
section iast
BytebuddyAgent [baseline] (815.356 ms) : 0, 815356
BytebuddyAgent [candidate] (809.946 ms) : 0, 809946
GlobalTracer [baseline] (305.727 ms) : 0, 305727
GlobalTracer [candidate] (304.648 ms) : 0, 304648
AppSec [baseline] (58.074 ms) : 0, 58074
AppSec [candidate] (57.964 ms) : 0, 57964
Remote Config [baseline] (623.019 µs) : 0, 623
Remote Config [candidate] (618.006 µs) : 0, 618
Telemetry [baseline] (7.081 ms) : 0, 7081
Telemetry [candidate] (7.113 ms) : 0, 7113
IAST [baseline] (20.503 ms) : 0, 20503
IAST [candidate] (20.582 ms) : 0, 20582
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (802.782 ms) : 0, 802782
BytebuddyAgent [candidate] (799.209 ms) : 0, 799209
GlobalTracer [baseline] (302.748 ms) : 0, 302748
GlobalTracer [candidate] (301.508 ms) : 0, 301508
AppSec [baseline] (57.474 ms) : 0, 57474
AppSec [candidate] (56.129 ms) : 0, 56129
Remote Config [baseline] (598.361 µs) : 0, 598
Remote Config [candidate] (596.488 µs) : 0, 596
Telemetry [baseline] (7.127 ms) : 0, 7127
Telemetry [candidate] (7.854 ms) : 0, 7854
IAST [baseline] (20.466 ms) : 0, 20466
IAST [candidate] (21.118 ms) : 0, 21118
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (794.8 ms) : 0, 794800
BytebuddyAgent [candidate] (794.096 ms) : 0, 794096
GlobalTracer [baseline] (301.343 ms) : 0, 301343
GlobalTracer [candidate] (301.114 ms) : 0, 301114
AppSec [baseline] (56.053 ms) : 0, 56053
AppSec [candidate] (56.772 ms) : 0, 56772
Remote Config [baseline] (593.535 µs) : 0, 594
Remote Config [candidate] (608.071 µs) : 0, 608
Telemetry [baseline] (7.77 ms) : 0, 7770
Telemetry [candidate] (6.898 ms) : 0, 6898
IAST [baseline] (20.653 ms) : 0, 20653
IAST [candidate] (20.635 ms) : 0, 20635
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~5fd0377579, baseline=1.42.0-SNAPSHOT~f687c2d038
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083782
Total [baseline] (10.386 s) : 0, 10385990
Agent [candidate] (1.075 s) : 0, 1075042
Total [candidate] (10.381 s) : 0, 10380709
section appsec
Agent [baseline] (1.211 s) : 0, 1211472
Total [baseline] (10.646 s) : 0, 10646328
Agent [candidate] (1.205 s) : 0, 1205017
Total [candidate] (10.582 s) : 0, 10581639
section iast
Agent [baseline] (1.21 s) : 0, 1209982
Total [baseline] (10.831 s) : 0, 10830711
Agent [candidate] (1.203 s) : 0, 1202696
Total [candidate] (10.839 s) : 0, 10838681
section profiling
Agent [baseline] (1.284 s) : 0, 1284146
Total [baseline] (10.824 s) : 0, 10824228
Agent [candidate] (1.274 s) : 0, 1273519
Total [candidate] (10.685 s) : 0, 10684831
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~5fd0377579, baseline=1.42.0-SNAPSHOT~f687c2d038
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.944 ms) : 0, 688944
BytebuddyAgent [candidate] (683.883 ms) : 0, 683883
GlobalTracer [baseline] (313.845 ms) : 0, 313845
GlobalTracer [candidate] (311.694 ms) : 0, 311694
AppSec [baseline] (54.166 ms) : 0, 54166
AppSec [candidate] (53.606 ms) : 0, 53606
Remote Config [baseline] (671.158 µs) : 0, 671
Remote Config [candidate] (661.253 µs) : 0, 661
Telemetry [baseline] (12.449 ms) : 0, 12449
Telemetry [candidate] (11.593 ms) : 0, 11593
section appsec
BytebuddyAgent [baseline] (703.377 ms) : 0, 703377
BytebuddyAgent [candidate] (699.612 ms) : 0, 699612
GlobalTracer [baseline] (310.723 ms) : 0, 310723
GlobalTracer [candidate] (309.072 ms) : 0, 309072
AppSec [baseline] (166.507 ms) : 0, 166507
AppSec [candidate] (164.735 ms) : 0, 164735
Remote Config [baseline] (635.075 µs) : 0, 635
Remote Config [candidate] (630.058 µs) : 0, 630
Telemetry [baseline] (7.41 ms) : 0, 7410
Telemetry [candidate] (7.408 ms) : 0, 7408
IAST [baseline] (18.382 ms) : 0, 18382
IAST [candidate] (19.92 ms) : 0, 19920
section iast
BytebuddyAgent [baseline] (807.046 ms) : 0, 807046
BytebuddyAgent [candidate] (800.778 ms) : 0, 800778
GlobalTracer [baseline] (303.533 ms) : 0, 303533
GlobalTracer [candidate] (301.877 ms) : 0, 301877
AppSec [baseline] (57.575 ms) : 0, 57575
AppSec [candidate] (58.136 ms) : 0, 58136
Remote Config [baseline] (597.127 µs) : 0, 597
Remote Config [candidate] (607.748 µs) : 0, 608
Telemetry [baseline] (7.024 ms) : 0, 7024
Telemetry [candidate] (7.094 ms) : 0, 7094
IAST [baseline] (20.471 ms) : 0, 20471
IAST [candidate] (20.525 ms) : 0, 20525
section profiling
BytebuddyAgent [baseline] (686.793 ms) : 0, 686793
BytebuddyAgent [candidate] (679.962 ms) : 0, 679962
GlobalTracer [baseline] (399.241 ms) : 0, 399241
GlobalTracer [candidate] (395.336 ms) : 0, 395336
AppSec [baseline] (54.993 ms) : 0, 54993
AppSec [candidate] (54.372 ms) : 0, 54372
Remote Config [baseline] (659.529 µs) : 0, 660
Remote Config [candidate] (650.672 µs) : 0, 651
Telemetry [baseline] (14.537 ms) : 0, 14537
Telemetry [candidate] (13.804 ms) : 0, 13804
ProfilingAgent [baseline] (88.799 ms) : 0, 88799
ProfilingAgent [candidate] (90.697 ms) : 0, 90697
Profiling [baseline] (88.824 ms) : 0, 88824
Profiling [candidate] (90.721 ms) : 0, 90721
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~5fd0377579, baseline=1.42.0-SNAPSHOT~f687c2d038
dateFormat X
axisFormat %s
section baseline
no_agent (1.339 ms) : 1319, 1359
. : milestone, 1339,
appsec (1.703 ms) : 1680, 1725
. : milestone, 1703,
appsec_no_iast (1.72 ms) : 1696, 1744
. : milestone, 1720,
iast (1.484 ms) : 1462, 1506
. : milestone, 1484,
profiling (1.494 ms) : 1471, 1518
. : milestone, 1494,
tracing (1.464 ms) : 1441, 1488
. : milestone, 1464,
section candidate
no_agent (1.335 ms) : 1315, 1354
. : milestone, 1335,
appsec (1.717 ms) : 1693, 1742
. : milestone, 1717,
appsec_no_iast (1.713 ms) : 1689, 1737
. : milestone, 1713,
iast (1.488 ms) : 1466, 1510
. : milestone, 1488,
profiling (1.467 ms) : 1444, 1489
. : milestone, 1467,
tracing (1.461 ms) : 1438, 1484
. : milestone, 1461,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~5fd0377579, baseline=1.42.0-SNAPSHOT~f687c2d038
dateFormat X
axisFormat %s
section baseline
no_agent (372.91 µs) : 352, 394
. : milestone, 373,
iast (482.385 µs) : 461, 504
. : milestone, 482,
iast_FULL (550.764 µs) : 530, 572
. : milestone, 551,
iast_GLOBAL (497.29 µs) : 476, 518
. : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (480.123 µs) : 459, 501
. : milestone, 480,
iast_INACTIVE (453.466 µs) : 433, 474
. : milestone, 453,
iast_TELEMETRY_OFF (476.937 µs) : 456, 498
. : milestone, 477,
tracing (440.718 µs) : 420, 461
. : milestone, 441,
section candidate
no_agent (372.508 µs) : 353, 392
. : milestone, 373,
iast (476.894 µs) : 456, 498
. : milestone, 477,
iast_FULL (546.057 µs) : 525, 567
. : milestone, 546,
iast_GLOBAL (516.899 µs) : 494, 540
. : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (498.879 µs) : 476, 522
. : milestone, 499,
iast_INACTIVE (437.757 µs) : 417, 458
. : milestone, 438,
iast_TELEMETRY_OFF (469.829 µs) : 449, 491
. : milestone, 470,
tracing (441.659 µs) : 421, 462
. : milestone, 442,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~5fd0377579, baseline=1.42.0-SNAPSHOT~f687c2d038
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1480
. : milestone, 1468,
appsec (2.325 ms) : 2284, 2365
. : milestone, 2325,
iast (2.07 ms) : 2018, 2123
. : milestone, 2070,
iast_GLOBAL (2.11 ms) : 2057, 2162
. : milestone, 2110,
profiling (2.384 ms) : 2136, 2632
. : milestone, 2384,
tracing (1.912 ms) : 1872, 1952
. : milestone, 1912,
section candidate
no_agent (1.465 ms) : 1453, 1476
. : milestone, 1465,
appsec (2.322 ms) : 2281, 2363
. : milestone, 2322,
iast (2.064 ms) : 2013, 2116
. : milestone, 2064,
iast_GLOBAL (2.113 ms) : 2060, 2165
. : milestone, 2113,
profiling (1.931 ms) : 1890, 1972
. : milestone, 1931,
tracing (1.912 ms) : 1873, 1952
. : milestone, 1912,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~5fd0377579, baseline=1.42.0-SNAPSHOT~f687c2d038
dateFormat X
axisFormat %s
section baseline
no_agent (15.656 s) : 15656000, 15656000
. : milestone, 15656000,
appsec (15.097 s) : 15097000, 15097000
. : milestone, 15097000,
iast (19.248 s) : 19248000, 19248000
. : milestone, 19248000,
iast_GLOBAL (18.283 s) : 18283000, 18283000
. : milestone, 18283000,
profiling (15.967 s) : 15967000, 15967000
. : milestone, 15967000,
tracing (15.201 s) : 15201000, 15201000
. : milestone, 15201000,
section candidate
no_agent (15.129 s) : 15129000, 15129000
. : milestone, 15129000,
appsec (15.438 s) : 15438000, 15438000
. : milestone, 15438000,
iast (18.545 s) : 18545000, 18545000
. : milestone, 18545000,
iast_GLOBAL (17.825 s) : 17825000, 17825000
. : milestone, 17825000,
profiling (14.902 s) : 14902000, 14902000
. : milestone, 14902000,
tracing (15.339 s) : 15339000, 15339000
. : milestone, 15339000,
|
tonyredondo
approved these changes
Oct 23, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/lower-log-level-duplicate-source-paths
branch
October 23, 2024 08:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Lowers log level (from
WARN
toDEBUG
) of the warning message that lists duplicate repo index keys.Motivation
To not spam the customer's logs.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]