Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid metadata access in driver connect advice for Oracle sharded connections #7812

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Avoid metadata access in driver connect advice for Oracle sharded connections #7812

merged 1 commit into from
Oct 21, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Oct 20, 2024 •
edited
Loading

What Does This Do

Looks for the oracle.jdbc.useShardingDriverConnection connection property.

If this is set to "true" then avoid accessing DatabaseMetaData methods during the Driver.connect advice.

Motivation

Accessing sharded metadata at this point could loop back into the pool, leading to starvation.

Contributor Checklist

Jira ticket: APMS-13516

@mcculls
Avoid metadata access in driver connect advice for Oracle sharded con…
694bef3 
…nections

Accessing sharded metadata at this point could loop back into the pool, leading to starvation.
@mcculls mcculls added the inst: jdbc JDBC instrumentation label Oct 20, 2024
@mcculls mcculls marked this pull request as ready for review October 20, 2024 22:12
@mcculls mcculls requested a review from a team as a code owner October 20, 2024 22:12
@pr-commenter
Copy link

pr-commenter bot commented Oct 20, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/avoid-metadata-access-during-oracle-sharded-connect
git_commit_date 1729257196 1729460442
git_commit_sha 00856e0 694bef3
release_version 1.42.0-SNAPSHOT~00856e02d3 1.42.0-SNAPSHOT~694bef35d2
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729463072 1729463072
ci_job_id 677847104 677847104
ci_pipeline_id 47002402 47002402
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~694bef35d2, baseline=1.42.0-SNAPSHOT~00856e02d3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076261
Total [baseline] (10.349 s) : 0, 10348627
Agent [candidate] (1.08 s) : 0, 1079850
Total [candidate] (10.377 s) : 0, 10377101
section appsec
Agent [baseline] (1.211 s) : 0, 1211140
Total [baseline] (10.613 s) : 0, 10612614
Agent [candidate] (1.211 s) : 0, 1211440
Total [candidate] (10.593 s) : 0, 10592945
section iast
Agent [baseline] (1.201 s) : 0, 1200681
Total [baseline] (10.912 s) : 0, 10911521
Agent [candidate] (1.198 s) : 0, 1198224
Total [candidate] (10.815 s) : 0, 10814682
section profiling
Agent [baseline] (1.273 s) : 0, 1272800
Total [baseline] (10.626 s) : 0, 10625754
Agent [candidate] (1.269 s) : 0, 1269127
Total [candidate] (10.635 s) : 0, 10635264
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.211 s 134.88 ms (12.5%)
Agent iast 1.201 s 124.42 ms (11.6%)
Agent profiling 1.273 s 196.539 ms (18.3%)
Total tracing 10.349 s -
Total appsec 10.613 s 263.987 ms (2.6%)
Total iast 10.912 s 562.894 ms (5.4%)
Total profiling 10.626 s 277.127 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.211 s 131.59 ms (12.2%)
Agent iast 1.198 s 118.374 ms (11.0%)
Agent profiling 1.269 s 189.277 ms (17.5%)
Total tracing 10.377 s -
Total appsec 10.593 s 215.845 ms (2.1%)
Total iast 10.815 s 437.581 ms (4.2%)
Total profiling 10.635 s 258.164 ms (2.5%) 
gantt
    title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~694bef35d2, baseline=1.42.0-SNAPSHOT~00856e02d3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.83 ms) : 0, 684830
BytebuddyAgent [candidate] (687.101 ms) : 0, 687101
GlobalTracer [baseline] (312.275 ms) : 0, 312275
GlobalTracer [candidate] (314.014 ms) : 0, 314014
AppSec [baseline] (53.965 ms) : 0, 53965
AppSec [candidate] (54.125 ms) : 0, 54125
Remote Config [baseline] (672.852 µs) : 0, 673
Remote Config [candidate] (674.792 µs) : 0, 675
Telemetry [baseline] (10.919 ms) : 0, 10919
Telemetry [candidate] (10.295 ms) : 0, 10295
section appsec
BytebuddyAgent [baseline] (703.606 ms) : 0, 703606
BytebuddyAgent [candidate] (703.723 ms) : 0, 703723
GlobalTracer [baseline] (310.176 ms) : 0, 310176
GlobalTracer [candidate] (310.323 ms) : 0, 310323
AppSec [baseline] (164.491 ms) : 0, 164491
AppSec [candidate] (165.185 ms) : 0, 165185
Remote Config [baseline] (630.188 µs) : 0, 630
Remote Config [candidate] (624.337 µs) : 0, 624
Telemetry [baseline] (7.754 ms) : 0, 7754
Telemetry [candidate] (8.386 ms) : 0, 8386
IAST [baseline] (21.736 ms) : 0, 21736
IAST [candidate] (19.091 ms) : 0, 19091
section iast
BytebuddyAgent [baseline] (800.962 ms) : 0, 800962
BytebuddyAgent [candidate] (799.031 ms) : 0, 799031
GlobalTracer [baseline] (301.027 ms) : 0, 301027
GlobalTracer [candidate] (300.193 ms) : 0, 300193
AppSec [baseline] (57.378 ms) : 0, 57378
AppSec [candidate] (56.369 ms) : 0, 56369
Remote Config [baseline] (588.565 µs) : 0, 589
Remote Config [candidate] (611.083 µs) : 0, 611
Telemetry [baseline] (7.003 ms) : 0, 7003
Telemetry [candidate] (7.886 ms) : 0, 7886
IAST [baseline] (20.104 ms) : 0, 20104
IAST [candidate] (20.52 ms) : 0, 20520
section profiling
BytebuddyAgent [baseline] (680.066 ms) : 0, 680066
BytebuddyAgent [candidate] (677.932 ms) : 0, 677932
GlobalTracer [baseline] (395.638 ms) : 0, 395638
GlobalTracer [candidate] (394.215 ms) : 0, 394215
AppSec [baseline] (54.3 ms) : 0, 54300
AppSec [candidate] (54.405 ms) : 0, 54405
Remote Config [baseline] (650.739 µs) : 0, 651
Remote Config [candidate] (650.039 µs) : 0, 650
Telemetry [baseline] (13.76 ms) : 0, 13760
Telemetry [candidate] (14.559 ms) : 0, 14559
ProfilingAgent [baseline] (89.764 ms) : 0, 89764
ProfilingAgent [candidate] (88.722 ms) : 0, 88722
Profiling [baseline] (89.789 ms) : 0, 89789
Profiling [candidate] (88.746 ms) : 0, 88746
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~694bef35d2, baseline=1.42.0-SNAPSHOT~00856e02d3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078108
Total [baseline] (8.596 s) : 0, 8596342
Agent [candidate] (1.073 s) : 0, 1073474
Total [candidate] (8.532 s) : 0, 8531911
section iast
Agent [baseline] (1.204 s) : 0, 1203817
Total [baseline] (9.129 s) : 0, 9128649
Agent [candidate] (1.209 s) : 0, 1209128
Total [candidate] (9.118 s) : 0, 9117910
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.199 s) : 0, 1199447
Total [baseline] (9.074 s) : 0, 9074186
Agent [candidate] (1.203 s) : 0, 1203388
Total [candidate] (9.078 s) : 0, 9077995
section iast_TELEMETRY_OFF
Agent [baseline] (1.203 s) : 0, 1203077
Total [baseline] (9.121 s) : 0, 9120698
Agent [candidate] (1.207 s) : 0, 1207365
Total [candidate] (9.088 s) : 0, 9087656
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent iast 1.204 s 125.709 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.199 s 121.339 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.203 s 124.969 ms (11.6%)
Total tracing 8.596 s -
Total iast 9.129 s 532.307 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.074 s 477.844 ms (5.6%)
Total iast_TELEMETRY_OFF 9.121 s 524.356 ms (6.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent iast 1.209 s 135.655 ms (12.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.203 s 129.915 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.207 s 133.891 ms (12.5%)
Total tracing 8.532 s -
Total iast 9.118 s 585.999 ms (6.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.078 s 546.085 ms (6.4%)
Total iast_TELEMETRY_OFF 9.088 s 555.745 ms (6.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~694bef35d2, baseline=1.42.0-SNAPSHOT~00856e02d3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.303 ms) : 0, 687303
BytebuddyAgent [candidate] (684.308 ms) : 0, 684308
GlobalTracer [baseline] (312.646 ms) : 0, 312646
GlobalTracer [candidate] (311.9 ms) : 0, 311900
AppSec [baseline] (54.341 ms) : 0, 54341
AppSec [candidate] (53.454 ms) : 0, 53454
Remote Config [baseline] (669.053 µs) : 0, 669
Remote Config [candidate] (666.85 µs) : 0, 667
Telemetry [baseline] (9.476 ms) : 0, 9476
Telemetry [candidate] (9.527 ms) : 0, 9527
section iast
BytebuddyAgent [baseline] (804.402 ms) : 0, 804402
BytebuddyAgent [candidate] (806.959 ms) : 0, 806959
GlobalTracer [baseline] (300.643 ms) : 0, 300643
GlobalTracer [candidate] (303.018 ms) : 0, 303018
AppSec [baseline] (57.042 ms) : 0, 57042
AppSec [candidate] (57.37 ms) : 0, 57370
IAST [baseline] (20.366 ms) : 0, 20366
IAST [candidate] (20.385 ms) : 0, 20385
Remote Config [baseline] (614.232 µs) : 0, 614
Remote Config [candidate] (604.373 µs) : 0, 604
Telemetry [baseline] (7.044 ms) : 0, 7044
Telemetry [candidate] (7.065 ms) : 0, 7065
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (799.721 ms) : 0, 799721
BytebuddyAgent [candidate] (802.13 ms) : 0, 802130
GlobalTracer [baseline] (301.262 ms) : 0, 301262
GlobalTracer [candidate] (301.485 ms) : 0, 301485
AppSec [baseline] (56.315 ms) : 0, 56315
AppSec [candidate] (56.376 ms) : 0, 56376
IAST [baseline] (20.158 ms) : 0, 20158
IAST [candidate] (22.085 ms) : 0, 22085
Remote Config [baseline] (589.044 µs) : 0, 589
Remote Config [candidate] (605.733 µs) : 0, 606
Telemetry [baseline] (7.811 ms) : 0, 7811
Telemetry [candidate] (7.07 ms) : 0, 7070
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (802.455 ms) : 0, 802455
BytebuddyAgent [candidate] (804.808 ms) : 0, 804808
GlobalTracer [baseline] (302.294 ms) : 0, 302294
GlobalTracer [candidate] (302.775 ms) : 0, 302775
AppSec [baseline] (57.202 ms) : 0, 57202
AppSec [candidate] (57.398 ms) : 0, 57398
IAST [baseline] (19.863 ms) : 0, 19863
IAST [candidate] (21.025 ms) : 0, 21025
Remote Config [baseline] (594.402 µs) : 0, 594
Remote Config [candidate] (614.594 µs) : 0, 615
Telemetry [baseline] (6.991 ms) : 0, 6991
Telemetry [candidate] (7.011 ms) : 0, 7011
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-20T21:55:04 2024-10-20T22:01:54
git_branch master mcculls/avoid-metadata-access-during-oracle-sharded-connect
git_commit_date 1729257196 1729460442
git_commit_sha 00856e0 694bef3
release_version 1.42.0-SNAPSHOT~00856e02d3 1.42.0-SNAPSHOT~694bef35d2
start_time 2024-10-20T21:54:51 2024-10-20T22:01:40
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729462058 1729462058
ci_job_id 677847105 677847105
ci_pipeline_id 47002402 47002402
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~694bef35d2, baseline=1.42.0-SNAPSHOT~00856e02d3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.342 ms) : 1323, 1361
.   : milestone, 1342,
appsec (1.708 ms) : 1684, 1732
.   : milestone, 1708,
appsec_no_iast (1.73 ms) : 1707, 1754
.   : milestone, 1730,
iast (1.449 ms) : 1426, 1472
.   : milestone, 1449,
profiling (1.469 ms) : 1446, 1492
.   : milestone, 1469,
tracing (1.461 ms) : 1436, 1485
.   : milestone, 1461,
section candidate
no_agent (1.327 ms) : 1307, 1347
.   : milestone, 1327,
appsec (1.716 ms) : 1691, 1740
.   : milestone, 1716,
appsec_no_iast (1.706 ms) : 1682, 1731
.   : milestone, 1706,
iast (1.461 ms) : 1438, 1483
.   : milestone, 1461,
profiling (1.468 ms) : 1446, 1490
.   : milestone, 1468,
tracing (1.454 ms) : 1429, 1478
.   : milestone, 1454,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.323 ms, 1.361 ms] -
appsec 1.708 ms [1.684 ms, 1.732 ms] 366.368 µs (27.3%)
appsec_no_iast 1.73 ms [1.707 ms, 1.754 ms] 388.215 µs (28.9%)
iast 1.449 ms [1.426 ms, 1.472 ms] 107.116 µs (8.0%)
profiling 1.469 ms [1.446 ms, 1.492 ms] 126.792 µs (9.4%)
tracing 1.461 ms [1.436 ms, 1.485 ms] 118.51 µs (8.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.327 ms [1.307 ms, 1.347 ms] -
appsec 1.716 ms [1.691 ms, 1.74 ms] 388.229 µs (29.2%)
appsec_no_iast 1.706 ms [1.682 ms, 1.731 ms] 378.674 µs (28.5%)
iast 1.461 ms [1.438 ms, 1.483 ms] 133.1 µs (10.0%)
profiling 1.468 ms [1.446 ms, 1.49 ms] 140.774 µs (10.6%)
tracing 1.454 ms [1.429 ms, 1.478 ms] 126.174 µs (9.5%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~694bef35d2, baseline=1.42.0-SNAPSHOT~00856e02d3
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.359 µs) : 345, 385
.   : milestone, 365,
iast (474.108 µs) : 453, 495
.   : milestone, 474,
iast_FULL (548.566 µs) : 528, 570
.   : milestone, 549,
iast_GLOBAL (506.534 µs) : 485, 528
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (475.022 µs) : 454, 496
.   : milestone, 475,
iast_INACTIVE (447.088 µs) : 426, 469
.   : milestone, 447,
iast_TELEMETRY_OFF (466.72 µs) : 445, 488
.   : milestone, 467,
tracing (447.571 µs) : 426, 470
.   : milestone, 448,
section candidate
no_agent (361.348 µs) : 342, 381
.   : milestone, 361,
iast (486.448 µs) : 465, 508
.   : milestone, 486,
iast_FULL (548.623 µs) : 527, 570
.   : milestone, 549,
iast_GLOBAL (515.372 µs) : 492, 538
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (479.574 µs) : 458, 501
.   : milestone, 480,
iast_INACTIVE (440.533 µs) : 420, 461
.   : milestone, 441,
iast_TELEMETRY_OFF (468.321 µs) : 447, 490
.   : milestone, 468,
tracing (445.757 µs) : 425, 466
.   : milestone, 446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.359 µs [345.481 µs, 385.236 µs] -
iast 474.108 µs [453.059 µs, 495.156 µs] 108.749 µs (29.8%)
iast_FULL 548.566 µs [527.546 µs, 569.586 µs] 183.207 µs (50.1%)
iast_GLOBAL 506.534 µs [485.088 µs, 527.98 µs] 141.175 µs (38.6%)
iast_HARDCODED_SECRET_DISABLED 475.022 µs [454.021 µs, 496.023 µs] 109.664 µs (30.0%)
iast_INACTIVE 447.088 µs [425.595 µs, 468.582 µs] 81.73 µs (22.4%)
iast_TELEMETRY_OFF 466.72 µs [445.448 µs, 487.993 µs] 101.362 µs (27.7%)
tracing 447.571 µs [425.555 µs, 469.588 µs] 82.213 µs (22.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 361.348 µs [341.79 µs, 380.906 µs] -
iast 486.448 µs [465.044 µs, 507.853 µs] 125.1 µs (34.6%)
iast_FULL 548.623 µs [527.327 µs, 569.92 µs] 187.275 µs (51.8%)
iast_GLOBAL 515.372 µs [492.341 µs, 538.403 µs] 154.023 µs (42.6%)
iast_HARDCODED_SECRET_DISABLED 479.574 µs [458.334 µs, 500.813 µs] 118.225 µs (32.7%)
iast_INACTIVE 440.533 µs [419.79 µs, 461.277 µs] 79.185 µs (21.9%)
iast_TELEMETRY_OFF 468.321 µs [447.014 µs, 489.627 µs] 106.973 µs (29.6%)
tracing 445.757 µs [425.487 µs, 466.027 µs] 84.409 µs (23.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/avoid-metadata-access-during-oracle-sharded-connect
git_commit_date 1729257196 1729460442
git_commit_sha 00856e0 694bef3
release_version 1.42.0-SNAPSHOT~00856e02d3 1.42.0-SNAPSHOT~694bef35d2
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1729462605 1729462605
ci_job_id 677847106 677847106
ci_pipeline_id 47002402 47002402
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~694bef35d2, baseline=1.42.0-SNAPSHOT~00856e02d3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.329 ms) : 2289, 2370
.   : milestone, 2329,
iast (2.075 ms) : 2024, 2127
.   : milestone, 2075,
iast_GLOBAL (2.118 ms) : 2066, 2170
.   : milestone, 2118,
profiling (1.937 ms) : 1895, 1979
.   : milestone, 1937,
tracing (1.92 ms) : 1881, 1958
.   : milestone, 1920,
section candidate
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.328 ms) : 2286, 2369
.   : milestone, 2328,
iast (2.07 ms) : 2019, 2121
.   : milestone, 2070,
iast_GLOBAL (2.108 ms) : 2056, 2159
.   : milestone, 2108,
profiling (2.427 ms) : 2238, 2616
.   : milestone, 2427,
tracing (1.927 ms) : 1887, 1967
.   : milestone, 1927,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.459 ms, 1.482 ms] -
appsec 2.329 ms [2.289 ms, 2.37 ms] 858.95 µs (58.4%)
iast 2.075 ms [2.024 ms, 2.127 ms] 604.576 µs (41.1%)
iast_GLOBAL 2.118 ms [2.066 ms, 2.17 ms] 647.203 µs (44.0%)
profiling 1.937 ms [1.895 ms, 1.979 ms] 466.585 µs (31.7%)
tracing 1.92 ms [1.881 ms, 1.958 ms] 448.999 µs (30.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.328 ms [2.286 ms, 2.369 ms] 860.725 µs (58.7%)
iast 2.07 ms [2.019 ms, 2.121 ms] 603.419 µs (41.1%)
iast_GLOBAL 2.108 ms [2.056 ms, 2.159 ms] 641.016 µs (43.7%)
profiling 2.427 ms [2.238 ms, 2.616 ms] 960.407 µs (65.5%)
tracing 1.927 ms [1.887 ms, 1.967 ms] 459.889 µs (31.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~694bef35d2, baseline=1.42.0-SNAPSHOT~00856e02d3
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.073 s) : 15073000, 15073000
.   : milestone, 15073000,
appsec (15.235 s) : 15235000, 15235000
.   : milestone, 15235000,
iast (19.017 s) : 19017000, 19017000
.   : milestone, 19017000,
iast_GLOBAL (17.906 s) : 17906000, 17906000
.   : milestone, 17906000,
profiling (15.001 s) : 15001000, 15001000
.   : milestone, 15001000,
tracing (15.084 s) : 15084000, 15084000
.   : milestone, 15084000,
section candidate
no_agent (15.284 s) : 15284000, 15284000
.   : milestone, 15284000,
appsec (15.108 s) : 15108000, 15108000
.   : milestone, 15108000,
iast (18.984 s) : 18984000, 18984000
.   : milestone, 18984000,
iast_GLOBAL (17.86 s) : 17860000, 17860000
.   : milestone, 17860000,
profiling (15.172 s) : 15172000, 15172000
.   : milestone, 15172000,
tracing (14.941 s) : 14941000, 14941000
.   : milestone, 14941000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.073 s [15.073 s, 15.073 s] -
appsec 15.235 s [15.235 s, 15.235 s] 162.0 ms (1.1%)
iast 19.017 s [19.017 s, 19.017 s] 3.944 s (26.2%)
iast_GLOBAL 17.906 s [17.906 s, 17.906 s] 2.833 s (18.8%)
profiling 15.001 s [15.001 s, 15.001 s] -72.0 ms (-0.5%)
tracing 15.084 s [15.084 s, 15.084 s] 11.0 ms (0.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.284 s [15.284 s, 15.284 s] -
appsec 15.108 s [15.108 s, 15.108 s] -176.0 ms (-1.2%)
iast 18.984 s [18.984 s, 18.984 s] 3.7 s (24.2%)
iast_GLOBAL 17.86 s [17.86 s, 17.86 s] 2.576 s (16.9%)
profiling 15.172 s [15.172 s, 15.172 s] -112.0 ms (-0.7%)
tracing 14.941 s [14.941 s, 14.941 s] -343.0 ms (-2.2%)

@mcculls mcculls merged commit 40b899d into master Oct 21, 2024
106 checks passed
@mcculls mcculls deleted the mcculls/avoid-metadata-access-during-oracle-sharded-connect branch October 21, 2024 09:14
@github-actions github-actions bot added this to the 1.42.0 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

Assignees
No one assigned
Labels
inst: jdbc JDBC instrumentation type: bug
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @amarziali