Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widen catch blocks to make agent discovery more tolerant #7796

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Widen catch blocks to make agent discovery more tolerant #7796

merged 1 commit into from
Oct 21, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Oct 17, 2024 •
edited
Loading

What Does This Do

Widen catch blocks to make agent discovery more tolerant of underlying errors, like UnsatisfiedLinkError

Motivation

Otherwise if an underlying transport throws an non I/O related error, such as JFFI throwing UnsatisfiedLinkError when it fails to load native components, then the exception will bubble up and installation of the tracer will be cancelled.

Contributor Checklist

Jira ticket: APMS-13480

@mcculls mcculls added the comp: core Tracer core label Oct 17, 2024
@mcculls mcculls marked this pull request as ready for review October 17, 2024 20:02
@mcculls mcculls requested a review from a team as a code owner October 17, 2024 20:02
@pr-commenter
Copy link

pr-commenter bot commented Oct 17, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/make-agent-discovery-more-tolerant
git_commit_date 1729190976 1729195043
git_commit_sha 9320a05 58ab6ef
release_version 1.42.0-SNAPSHOT~9320a05d02 1.42.0-SNAPSHOT~58ab6ef562
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729197509 1729197509
ci_job_id 676121644 676121644
ci_pipeline_id 46862852 46862852
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~58ab6ef562, baseline=1.42.0-SNAPSHOT~9320a05d02

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1077442
Total [baseline] (10.385 s) : 0, 10385096
Agent [candidate] (1.079 s) : 0, 1079213
Total [candidate] (10.347 s) : 0, 10347270
section appsec
Agent [baseline] (1.212 s) : 0, 1212334
Total [baseline] (10.559 s) : 0, 10559170
Agent [candidate] (1.215 s) : 0, 1214546
Total [candidate] (10.575 s) : 0, 10574684
section iast
Agent [baseline] (1.207 s) : 0, 1207001
Total [baseline] (10.846 s) : 0, 10846364
Agent [candidate] (1.198 s) : 0, 1198331
Total [candidate] (10.865 s) : 0, 10865325
section profiling
Agent [baseline] (1.267 s) : 0, 1267301
Total [baseline] (10.654 s) : 0, 10654069
Agent [candidate] (1.272 s) : 0, 1271541
Total [candidate] (10.76 s) : 0, 10759946
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent appsec 1.212 s 134.891 ms (12.5%)
Agent iast 1.207 s 129.558 ms (12.0%)
Agent profiling 1.267 s 189.858 ms (17.6%)
Total tracing 10.385 s -
Total appsec 10.559 s 174.074 ms (1.7%)
Total iast 10.846 s 461.268 ms (4.4%)
Total profiling 10.654 s 268.973 ms (2.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.215 s 135.333 ms (12.5%)
Agent iast 1.198 s 119.118 ms (11.0%)
Agent profiling 1.272 s 192.328 ms (17.8%)
Total tracing 10.347 s -
Total appsec 10.575 s 227.413 ms (2.2%)
Total iast 10.865 s 518.055 ms (5.0%)
Total profiling 10.76 s 412.676 ms (4.0%) 
gantt
    title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~58ab6ef562, baseline=1.42.0-SNAPSHOT~9320a05d02

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.807 ms) : 0, 685807
BytebuddyAgent [candidate] (685.802 ms) : 0, 685802
GlobalTracer [baseline] (312.485 ms) : 0, 312485
GlobalTracer [candidate] (313.53 ms) : 0, 313530
AppSec [baseline] (53.864 ms) : 0, 53864
AppSec [candidate] (53.779 ms) : 0, 53779
Remote Config [baseline] (681.292 µs) : 0, 681
Remote Config [candidate] (664.71 µs) : 0, 665
Telemetry [baseline] (11.006 ms) : 0, 11006
Telemetry [candidate] (11.786 ms) : 0, 11786
section appsec
BytebuddyAgent [baseline] (703.279 ms) : 0, 703279
BytebuddyAgent [candidate] (704.28 ms) : 0, 704280
GlobalTracer [baseline] (311.03 ms) : 0, 311030
GlobalTracer [candidate] (312.279 ms) : 0, 312279
AppSec [baseline] (166.598 ms) : 0, 166598
AppSec [candidate] (165.397 ms) : 0, 165397
Remote Config [baseline] (632.925 µs) : 0, 633
Remote Config [candidate] (635.92 µs) : 0, 636
Telemetry [baseline] (7.066 ms) : 0, 7066
Telemetry [candidate] (7.471 ms) : 0, 7471
IAST [baseline] (20.143 ms) : 0, 20143
IAST [candidate] (21.603 ms) : 0, 21603
section iast
BytebuddyAgent [baseline] (805.19 ms) : 0, 805190
BytebuddyAgent [candidate] (798.225 ms) : 0, 798225
GlobalTracer [baseline] (302.666 ms) : 0, 302666
GlobalTracer [candidate] (300.782 ms) : 0, 300782
AppSec [baseline] (57.563 ms) : 0, 57563
AppSec [candidate] (56.85 ms) : 0, 56850
Remote Config [baseline] (594.317 µs) : 0, 594
Remote Config [candidate] (608.471 µs) : 0, 608
Telemetry [baseline] (7.066 ms) : 0, 7066
Telemetry [candidate] (7.064 ms) : 0, 7064
IAST [baseline] (20.185 ms) : 0, 20185
IAST [candidate] (21.188 ms) : 0, 21188
section profiling
BytebuddyAgent [baseline] (676.127 ms) : 0, 676127
BytebuddyAgent [candidate] (678.708 ms) : 0, 678708
GlobalTracer [baseline] (394.394 ms) : 0, 394394
GlobalTracer [candidate] (395.42 ms) : 0, 395420
AppSec [baseline] (54.165 ms) : 0, 54165
AppSec [candidate] (54.523 ms) : 0, 54523
Remote Config [baseline] (648.824 µs) : 0, 649
Remote Config [candidate] (647.431 µs) : 0, 647
Telemetry [baseline] (14.354 ms) : 0, 14354
Telemetry [candidate] (14.423 ms) : 0, 14423
ProfilingAgent [baseline] (89.053 ms) : 0, 89053
ProfilingAgent [candidate] (89.143 ms) : 0, 89143
Profiling [baseline] (89.076 ms) : 0, 89076
Profiling [candidate] (89.166 ms) : 0, 89166
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~58ab6ef562, baseline=1.42.0-SNAPSHOT~9320a05d02

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1077072
Total [baseline] (8.562 s) : 0, 8562127
Agent [candidate] (1.074 s) : 0, 1073792
Total [candidate] (8.559 s) : 0, 8558712
section iast
Agent [baseline] (1.21 s) : 0, 1209504
Total [baseline] (9.087 s) : 0, 9087186
Agent [candidate] (1.197 s) : 0, 1197179
Total [candidate] (9.082 s) : 0, 9081592
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.199 s) : 0, 1198644
Total [baseline] (9.063 s) : 0, 9062976
Agent [candidate] (1.197 s) : 0, 1196645
Total [candidate] (9.083 s) : 0, 9082580
section iast_TELEMETRY_OFF
Agent [baseline] (1.194 s) : 0, 1194347
Total [baseline] (9.068 s) : 0, 9068356
Agent [candidate] (1.197 s) : 0, 1197402
Total [candidate] (9.097 s) : 0, 9096924
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent iast 1.21 s 132.432 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.199 s 121.571 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.194 s 117.275 ms (10.9%)
Total tracing 8.562 s -
Total iast 9.087 s 525.059 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.063 s 500.849 ms (5.8%)
Total iast_TELEMETRY_OFF 9.068 s 506.229 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent iast 1.197 s 123.387 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.197 s 122.853 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.197 s 123.61 ms (11.5%)
Total tracing 8.559 s -
Total iast 9.082 s 522.88 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.083 s 523.868 ms (6.1%)
Total iast_TELEMETRY_OFF 9.097 s 538.212 ms (6.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~58ab6ef562, baseline=1.42.0-SNAPSHOT~9320a05d02

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.991 ms) : 0, 686991
BytebuddyAgent [candidate] (682.029 ms) : 0, 682029
GlobalTracer [baseline] (313.033 ms) : 0, 313033
GlobalTracer [candidate] (311.841 ms) : 0, 311841
AppSec [baseline] (53.916 ms) : 0, 53916
AppSec [candidate] (53.413 ms) : 0, 53413
Remote Config [baseline] (657.61 µs) : 0, 658
Remote Config [candidate] (662.851 µs) : 0, 663
Telemetry [baseline] (8.827 ms) : 0, 8827
Telemetry [candidate] (12.269 ms) : 0, 12269
section iast
BytebuddyAgent [baseline] (806.537 ms) : 0, 806537
BytebuddyAgent [candidate] (797.581 ms) : 0, 797581
GlobalTracer [baseline] (303.782 ms) : 0, 303782
GlobalTracer [candidate] (300.694 ms) : 0, 300694
AppSec [baseline] (56.8 ms) : 0, 56800
AppSec [candidate] (56.523 ms) : 0, 56523
Remote Config [baseline] (614.448 µs) : 0, 614
Remote Config [candidate] (622.034 µs) : 0, 622
Telemetry [baseline] (7.044 ms) : 0, 7044
Telemetry [candidate] (7.054 ms) : 0, 7054
IAST [baseline] (20.996 ms) : 0, 20996
IAST [candidate] (21.073 ms) : 0, 21073
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.204 ms) : 0, 798204
BytebuddyAgent [candidate] (796.586 ms) : 0, 796586
GlobalTracer [baseline] (301.071 ms) : 0, 301071
GlobalTracer [candidate] (300.996 ms) : 0, 300996
AppSec [baseline] (56.854 ms) : 0, 56854
AppSec [candidate] (57.79 ms) : 0, 57790
Remote Config [baseline] (605.409 µs) : 0, 605
Remote Config [candidate] (587.059 µs) : 0, 587
Telemetry [baseline] (7.067 ms) : 0, 7067
Telemetry [candidate] (7.024 ms) : 0, 7024
IAST [baseline] (21.225 ms) : 0, 21225
IAST [candidate] (20.072 ms) : 0, 20072
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (794.925 ms) : 0, 794925
BytebuddyAgent [candidate] (796.841 ms) : 0, 796841
GlobalTracer [baseline] (300.955 ms) : 0, 300955
GlobalTracer [candidate] (301.983 ms) : 0, 301983
AppSec [baseline] (56.568 ms) : 0, 56568
AppSec [candidate] (57.499 ms) : 0, 57499
Remote Config [baseline] (604.433 µs) : 0, 604
Remote Config [candidate] (595.703 µs) : 0, 596
Telemetry [baseline] (7.729 ms) : 0, 7729
Telemetry [candidate] (6.943 ms) : 0, 6943
IAST [baseline] (19.962 ms) : 0, 19962
IAST [candidate] (19.9 ms) : 0, 19900
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-17T20:09:01 2024-10-17T20:15:55
git_branch master mcculls/make-agent-discovery-more-tolerant
git_commit_date 1729190976 1729195043
git_commit_sha 9320a05 58ab6ef
release_version 1.42.0-SNAPSHOT~9320a05d02 1.42.0-SNAPSHOT~58ab6ef562
start_time 2024-10-17T20:08:47 2024-10-17T20:15:41
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729196504 1729196504
ci_job_id 676121645 676121645
ci_pipeline_id 46862852 46862852
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~58ab6ef562, baseline=1.42.0-SNAPSHOT~9320a05d02
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.362 ms) : 1343, 1381
.   : milestone, 1362,
appsec (1.71 ms) : 1686, 1735
.   : milestone, 1710,
appsec_no_iast (1.733 ms) : 1709, 1757
.   : milestone, 1733,
iast (1.494 ms) : 1471, 1516
.   : milestone, 1494,
profiling (1.549 ms) : 1526, 1573
.   : milestone, 1549,
tracing (1.482 ms) : 1458, 1505
.   : milestone, 1482,
section candidate
no_agent (1.331 ms) : 1311, 1350
.   : milestone, 1331,
appsec (1.724 ms) : 1699, 1748
.   : milestone, 1724,
appsec_no_iast (1.732 ms) : 1708, 1756
.   : milestone, 1732,
iast (1.478 ms) : 1455, 1501
.   : milestone, 1478,
profiling (1.505 ms) : 1483, 1528
.   : milestone, 1505,
tracing (1.488 ms) : 1464, 1513
.   : milestone, 1488,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.343 ms, 1.381 ms] -
appsec 1.71 ms [1.686 ms, 1.735 ms] 348.267 µs (25.6%)
appsec_no_iast 1.733 ms [1.709 ms, 1.757 ms] 371.084 µs (27.3%)
iast 1.494 ms [1.471 ms, 1.516 ms] 131.839 µs (9.7%)
profiling 1.549 ms [1.526 ms, 1.573 ms] 187.489 µs (13.8%)
tracing 1.482 ms [1.458 ms, 1.505 ms] 119.76 µs (8.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.331 ms [1.311 ms, 1.35 ms] -
appsec 1.724 ms [1.699 ms, 1.748 ms] 393.055 µs (29.5%)
appsec_no_iast 1.732 ms [1.708 ms, 1.756 ms] 401.026 µs (30.1%)
iast 1.478 ms [1.455 ms, 1.501 ms] 147.481 µs (11.1%)
profiling 1.505 ms [1.483 ms, 1.528 ms] 174.749 µs (13.1%)
tracing 1.488 ms [1.464 ms, 1.513 ms] 157.598 µs (11.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~58ab6ef562, baseline=1.42.0-SNAPSHOT~9320a05d02
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.148 µs) : 347, 385
.   : milestone, 366,
iast (488.285 µs) : 467, 510
.   : milestone, 488,
iast_FULL (565.378 µs) : 544, 587
.   : milestone, 565,
iast_GLOBAL (502.377 µs) : 481, 524
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (488.44 µs) : 467, 510
.   : milestone, 488,
iast_INACTIVE (449.233 µs) : 429, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (470.398 µs) : 450, 491
.   : milestone, 470,
tracing (449.172 µs) : 427, 471
.   : milestone, 449,
section candidate
no_agent (371.019 µs) : 352, 390
.   : milestone, 371,
iast (486.686 µs) : 466, 508
.   : milestone, 487,
iast_FULL (556.167 µs) : 535, 578
.   : milestone, 556,
iast_GLOBAL (523.313 µs) : 500, 547
.   : milestone, 523,
iast_HARDCODED_SECRET_DISABLED (487.689 µs) : 466, 509
.   : milestone, 488,
iast_INACTIVE (457.074 µs) : 436, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (481.959 µs) : 460, 504
.   : milestone, 482,
tracing (449.941 µs) : 429, 471
.   : milestone, 450,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.148 µs [346.911 µs, 385.385 µs] -
iast 488.285 µs [467.032 µs, 509.538 µs] 122.137 µs (33.4%)
iast_FULL 565.378 µs [543.816 µs, 586.941 µs] 199.23 µs (54.4%)
iast_GLOBAL 502.377 µs [481.187 µs, 523.567 µs] 136.229 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED 488.44 µs [467.229 µs, 509.651 µs] 122.292 µs (33.4%)
iast_INACTIVE 449.233 µs [428.748 µs, 469.718 µs] 83.085 µs (22.7%)
iast_TELEMETRY_OFF 470.398 µs [449.514 µs, 491.281 µs] 104.25 µs (28.5%)
tracing 449.172 µs [427.365 µs, 470.979 µs] 83.024 µs (22.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.019 µs [351.603 µs, 390.435 µs] -
iast 486.686 µs [465.538 µs, 507.834 µs] 115.667 µs (31.2%)
iast_FULL 556.167 µs [534.741 µs, 577.593 µs] 185.148 µs (49.9%)
iast_GLOBAL 523.313 µs [499.901 µs, 546.726 µs] 152.294 µs (41.0%)
iast_HARDCODED_SECRET_DISABLED 487.689 µs [466.093 µs, 509.284 µs] 116.67 µs (31.4%)
iast_INACTIVE 457.074 µs [436.003 µs, 478.144 µs] 86.055 µs (23.2%)
iast_TELEMETRY_OFF 481.959 µs [459.913 µs, 504.006 µs] 110.94 µs (29.9%)
tracing 449.941 µs [429.026 µs, 470.855 µs] 78.922 µs (21.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/make-agent-discovery-more-tolerant
git_commit_date 1729190976 1729195043
git_commit_sha 9320a05 58ab6ef
release_version 1.42.0-SNAPSHOT~9320a05d02 1.42.0-SNAPSHOT~58ab6ef562
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1729196902 1729196902
ci_job_id 676121646 676121646
ci_pipeline_id 46862852 46862852
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~58ab6ef562, baseline=1.42.0-SNAPSHOT~9320a05d02
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (2.35 ms) : 2308, 2392
.   : milestone, 2350,
iast (2.084 ms) : 2032, 2136
.   : milestone, 2084,
iast_GLOBAL (2.133 ms) : 2080, 2187
.   : milestone, 2133,
profiling (1.952 ms) : 1910, 1993
.   : milestone, 1952,
tracing (1.93 ms) : 1890, 1970
.   : milestone, 1930,
section candidate
no_agent (1.481 ms) : 1470, 1493
.   : milestone, 1481,
appsec (2.347 ms) : 2305, 2388
.   : milestone, 2347,
iast (2.101 ms) : 2049, 2153
.   : milestone, 2101,
iast_GLOBAL (2.145 ms) : 2092, 2198
.   : milestone, 2145,
profiling (1.956 ms) : 1914, 1999
.   : milestone, 1956,
tracing (1.932 ms) : 1892, 1973
.   : milestone, 1932,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.461 ms, 1.484 ms] -
appsec 2.35 ms [2.308 ms, 2.392 ms] 877.233 µs (59.6%)
iast 2.084 ms [2.032 ms, 2.136 ms] 611.44 µs (41.5%)
iast_GLOBAL 2.133 ms [2.08 ms, 2.187 ms] 660.444 µs (44.8%)
profiling 1.952 ms [1.91 ms, 1.993 ms] 478.627 µs (32.5%)
tracing 1.93 ms [1.89 ms, 1.97 ms] 457.017 µs (31.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.481 ms [1.47 ms, 1.493 ms] -
appsec 2.347 ms [2.305 ms, 2.388 ms] 865.14 µs (58.4%)
iast 2.101 ms [2.049 ms, 2.153 ms] 619.912 µs (41.8%)
iast_GLOBAL 2.145 ms [2.092 ms, 2.198 ms] 663.666 µs (44.8%)
profiling 1.956 ms [1.914 ms, 1.999 ms] 475.033 µs (32.1%)
tracing 1.932 ms [1.892 ms, 1.973 ms] 451.025 µs (30.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~58ab6ef562, baseline=1.42.0-SNAPSHOT~9320a05d02
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.142 s) : 15142000, 15142000
.   : milestone, 15142000,
appsec (15.344 s) : 15344000, 15344000
.   : milestone, 15344000,
iast (18.92 s) : 18920000, 18920000
.   : milestone, 18920000,
iast_GLOBAL (17.882 s) : 17882000, 17882000
.   : milestone, 17882000,
profiling (15.119 s) : 15119000, 15119000
.   : milestone, 15119000,
tracing (14.895 s) : 14895000, 14895000
.   : milestone, 14895000,
section candidate
no_agent (15.454 s) : 15454000, 15454000
.   : milestone, 15454000,
appsec (15.222 s) : 15222000, 15222000
.   : milestone, 15222000,
iast (19.205 s) : 19205000, 19205000
.   : milestone, 19205000,
iast_GLOBAL (18.129 s) : 18129000, 18129000
.   : milestone, 18129000,
profiling (15.168 s) : 15168000, 15168000
.   : milestone, 15168000,
tracing (15.185 s) : 15185000, 15185000
.   : milestone, 15185000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.142 s [15.142 s, 15.142 s] -
appsec 15.344 s [15.344 s, 15.344 s] 202.0 ms (1.3%)
iast 18.92 s [18.92 s, 18.92 s] 3.778 s (25.0%)
iast_GLOBAL 17.882 s [17.882 s, 17.882 s] 2.74 s (18.1%)
profiling 15.119 s [15.119 s, 15.119 s] -23.0 ms (-0.2%)
tracing 14.895 s [14.895 s, 14.895 s] -247.0 ms (-1.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.454 s [15.454 s, 15.454 s] -
appsec 15.222 s [15.222 s, 15.222 s] -232.0 ms (-1.5%)
iast 19.205 s [19.205 s, 19.205 s] 3.751 s (24.3%)
iast_GLOBAL 18.129 s [18.129 s, 18.129 s] 2.675 s (17.3%)
profiling 15.168 s [15.168 s, 15.168 s] -286.0 ms (-1.9%)
tracing 15.185 s [15.185 s, 15.185 s] -269.0 ms (-1.7%)

@mcculls mcculls merged commit f687c2d into master Oct 21, 2024
106 checks passed
@mcculls mcculls deleted the mcculls/make-agent-discovery-more-tolerant branch October 21, 2024 09:16
@github-actions github-actions bot added this to the 1.42.0 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

@dougqh dougqh Awaiting requested review from dougqh

Assignees
No one assigned
Labels
comp: core Tracer core
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @amarziali