Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall back to ports when we cannot use auto-discovered unix domain sockets #7794

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fall back to ports when we cannot use auto-discovered unix domain sockets #7794

merged 1 commit into from
Oct 21, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Oct 17, 2024 •
edited
Loading

What Does This Do

When using the agent defaults and a unix domain socket is auto-discovered, fall back to using ports if we cannot use the socket. Reasons we might not be able to use the socket include issues linking the JFFI library and permission problems.

Likewise, if the user has explicitly configured unix domain sockets then respect that decision and don't fall back to ports.

Motivation

Helps provide a fall back when the tracer auto-discovers unix domain sockets but is then unable to use them for reasons only apparent when we try to open the socket.

Additional Notes

We don't want to try opening the socket at configuration time because it might be a blocking operation.

Contributor Checklist

Jira ticket: APMS-13480

@mcculls mcculls added the comp: core Tracer core label Oct 17, 2024
@mcculls mcculls marked this pull request as ready for review October 17, 2024 18:24
@mcculls mcculls requested a review from a team as a code owner October 17, 2024 18:24
@mcculls mcculls requested review from ygree and dougqh October 17, 2024 18:24
@pr-commenter
Copy link

pr-commenter bot commented Oct 17, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/fallback-from-uds-to-port
git_commit_date 1729515503 1729515524
git_commit_sha 5ba267f 1461ca5
release_version 1.42.0-SNAPSHOT~5ba267f941 1.42.0-SNAPSHOT~1461ca588d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729517946 1729517946
ci_job_id 678303073 678303073
ci_pipeline_id 47033883 47033883
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~1461ca588d, baseline=1.42.0-SNAPSHOT~5ba267f941

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078555
Total [baseline] (8.585 s) : 0, 8584623
Agent [candidate] (1.083 s) : 0, 1083415
Total [candidate] (8.586 s) : 0, 8586208
section iast
Agent [baseline] (1.202 s) : 0, 1202026
Total [baseline] (9.11 s) : 0, 9110279
Agent [candidate] (1.206 s) : 0, 1205566
Total [candidate] (9.145 s) : 0, 9145182
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.216 s) : 0, 1216051
Total [baseline] (9.117 s) : 0, 9116570
Agent [candidate] (1.208 s) : 0, 1208028
Total [candidate] (9.102 s) : 0, 9101742
section iast_TELEMETRY_OFF
Agent [baseline] (1.202 s) : 0, 1201779
Total [baseline] (9.121 s) : 0, 9121432
Agent [candidate] (1.202 s) : 0, 1201699
Total [candidate] (9.122 s) : 0, 9121978
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent iast 1.202 s 123.47 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.216 s 137.495 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.202 s 123.224 ms (11.4%)
Total tracing 8.585 s -
Total iast 9.11 s 525.655 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.117 s 531.947 ms (6.2%)
Total iast_TELEMETRY_OFF 9.121 s 536.809 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent iast 1.206 s 122.151 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.208 s 124.613 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.202 s 118.284 ms (10.9%)
Total tracing 8.586 s -
Total iast 9.145 s 558.974 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.102 s 515.534 ms (6.0%)
Total iast_TELEMETRY_OFF 9.122 s 535.77 ms (6.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~1461ca588d, baseline=1.42.0-SNAPSHOT~5ba267f941

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.1 ms) : 0, 688100
BytebuddyAgent [candidate] (688.606 ms) : 0, 688606
GlobalTracer [baseline] (313.701 ms) : 0, 313701
GlobalTracer [candidate] (316.113 ms) : 0, 316113
AppSec [baseline] (54.061 ms) : 0, 54061
AppSec [candidate] (54.517 ms) : 0, 54517
Remote Config [baseline] (675.234 µs) : 0, 675
Remote Config [candidate] (673.661 µs) : 0, 674
Telemetry [baseline] (8.225 ms) : 0, 8225
Telemetry [candidate] (9.724 ms) : 0, 9724
section iast
BytebuddyAgent [baseline] (800.336 ms) : 0, 800336
BytebuddyAgent [candidate] (802.221 ms) : 0, 802221
GlobalTracer [baseline] (302.481 ms) : 0, 302481
GlobalTracer [candidate] (303.453 ms) : 0, 303453
AppSec [baseline] (57.641 ms) : 0, 57641
AppSec [candidate] (56.31 ms) : 0, 56310
Remote Config [baseline] (594.413 µs) : 0, 594
Remote Config [candidate] (612.523 µs) : 0, 613
Telemetry [baseline] (7.021 ms) : 0, 7021
Telemetry [candidate] (7.092 ms) : 0, 7092
IAST [baseline] (20.194 ms) : 0, 20194
IAST [candidate] (22.035 ms) : 0, 22035
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (809.832 ms) : 0, 809832
BytebuddyAgent [candidate] (804.177 ms) : 0, 804177
GlobalTracer [baseline] (305.714 ms) : 0, 305714
GlobalTracer [candidate] (303.936 ms) : 0, 303936
AppSec [baseline] (57.561 ms) : 0, 57561
AppSec [candidate] (57.853 ms) : 0, 57853
Remote Config [baseline] (595.948 µs) : 0, 596
Remote Config [candidate] (614.38 µs) : 0, 614
Telemetry [baseline] (7.132 ms) : 0, 7132
Telemetry [candidate] (7.066 ms) : 0, 7066
IAST [baseline] (21.26 ms) : 0, 21260
IAST [candidate] (20.525 ms) : 0, 20525
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.649 ms) : 0, 799649
BytebuddyAgent [candidate] (799.372 ms) : 0, 799372
GlobalTracer [baseline] (302.859 ms) : 0, 302859
GlobalTracer [candidate] (303.475 ms) : 0, 303475
AppSec [baseline] (57.638 ms) : 0, 57638
AppSec [candidate] (56.537 ms) : 0, 56537
Remote Config [baseline] (613.11 µs) : 0, 613
Remote Config [candidate] (606.968 µs) : 0, 607
Telemetry [baseline] (7.024 ms) : 0, 7024
Telemetry [candidate] (7.83 ms) : 0, 7830
IAST [baseline] (20.208 ms) : 0, 20208
IAST [candidate] (20.057 ms) : 0, 20057
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~1461ca588d, baseline=1.42.0-SNAPSHOT~5ba267f941

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088172
Total [baseline] (10.423 s) : 0, 10422971
Agent [candidate] (1.081 s) : 0, 1081054
Total [candidate] (10.411 s) : 0, 10410578
section appsec
Agent [baseline] (1.214 s) : 0, 1213907
Total [baseline] (10.635 s) : 0, 10635099
Agent [candidate] (1.219 s) : 0, 1218910
Total [candidate] (10.595 s) : 0, 10594955
section iast
Agent [baseline] (1.206 s) : 0, 1205758
Total [baseline] (10.922 s) : 0, 10922122
Agent [candidate] (1.227 s) : 0, 1227467
Total [candidate] (10.904 s) : 0, 10904303
section profiling
Agent [baseline] (1.274 s) : 0, 1273967
Total [baseline] (10.687 s) : 0, 10687328
Agent [candidate] (1.277 s) : 0, 1277188
Total [candidate] (10.743 s) : 0, 10743166
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.088 s -
Agent appsec 1.214 s 125.735 ms (11.6%)
Agent iast 1.206 s 117.586 ms (10.8%)
Agent profiling 1.274 s 185.795 ms (17.1%)
Total tracing 10.423 s -
Total appsec 10.635 s 212.128 ms (2.0%)
Total iast 10.922 s 499.151 ms (4.8%)
Total profiling 10.687 s 264.356 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent appsec 1.219 s 137.856 ms (12.8%)
Agent iast 1.227 s 146.413 ms (13.5%)
Agent profiling 1.277 s 196.134 ms (18.1%)
Total tracing 10.411 s -
Total appsec 10.595 s 184.377 ms (1.8%)
Total iast 10.904 s 493.725 ms (4.7%)
Total profiling 10.743 s 332.588 ms (3.2%) 
gantt
    title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~1461ca588d, baseline=1.42.0-SNAPSHOT~5ba267f941

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.135 ms) : 0, 693135
BytebuddyAgent [candidate] (688.565 ms) : 0, 688565
GlobalTracer [baseline] (316.349 ms) : 0, 316349
GlobalTracer [candidate] (315.534 ms) : 0, 315534
AppSec [baseline] (54.395 ms) : 0, 54395
AppSec [candidate] (54.184 ms) : 0, 54184
Remote Config [baseline] (679.884 µs) : 0, 680
Remote Config [candidate] (665.873 µs) : 0, 666
Telemetry [baseline] (9.724 ms) : 0, 9724
Telemetry [candidate] (8.293 ms) : 0, 8293
section appsec
BytebuddyAgent [baseline] (703.99 ms) : 0, 703990
BytebuddyAgent [candidate] (706.767 ms) : 0, 706767
GlobalTracer [baseline] (311.518 ms) : 0, 311518
GlobalTracer [candidate] (313.244 ms) : 0, 313244
AppSec [baseline] (167.788 ms) : 0, 167788
AppSec [candidate] (165.801 ms) : 0, 165801
Remote Config [baseline] (633.151 µs) : 0, 633
Remote Config [candidate] (648.34 µs) : 0, 648
Telemetry [baseline] (7.026 ms) : 0, 7026
Telemetry [candidate] (7.839 ms) : 0, 7839
IAST [baseline] (18.358 ms) : 0, 18358
IAST [candidate] (21.61 ms) : 0, 21610
section iast
BytebuddyAgent [baseline] (802.963 ms) : 0, 802963
BytebuddyAgent [candidate] (817.739 ms) : 0, 817739
GlobalTracer [baseline] (302.853 ms) : 0, 302853
GlobalTracer [candidate] (308.208 ms) : 0, 308208
AppSec [baseline] (56.235 ms) : 0, 56235
AppSec [candidate] (58.013 ms) : 0, 58013
Remote Config [baseline] (607.478 µs) : 0, 607
Remote Config [candidate] (613.263 µs) : 0, 613
Telemetry [baseline] (7.051 ms) : 0, 7051
Telemetry [candidate] (7.232 ms) : 0, 7232
IAST [baseline] (22.25 ms) : 0, 22250
IAST [candidate] (21.626 ms) : 0, 21626
section profiling
BytebuddyAgent [baseline] (678.94 ms) : 0, 678940
BytebuddyAgent [candidate] (681.347 ms) : 0, 681347
GlobalTracer [baseline] (397.943 ms) : 0, 397943
GlobalTracer [candidate] (398.262 ms) : 0, 398262
AppSec [baseline] (54.418 ms) : 0, 54418
AppSec [candidate] (54.651 ms) : 0, 54651
Remote Config [baseline] (657.49 µs) : 0, 657
Remote Config [candidate] (656.654 µs) : 0, 657
Telemetry [baseline] (14.397 ms) : 0, 14397
Telemetry [candidate] (13.662 ms) : 0, 13662
ProfilingAgent [baseline] (88.777 ms) : 0, 88777
ProfilingAgent [candidate] (89.606 ms) : 0, 89606
Profiling [baseline] (88.801 ms) : 0, 88801
Profiling [candidate] (89.629 ms) : 0, 89629
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-21T13:09:37 2024-10-21T13:16:27
git_branch master mcculls/fallback-from-uds-to-port
git_commit_date 1729515503 1729515524
git_commit_sha 5ba267f 1461ca5
release_version 1.42.0-SNAPSHOT~5ba267f941 1.42.0-SNAPSHOT~1461ca588d
start_time 2024-10-21T13:09:23 2024-10-21T13:16:14
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729516935 1729516935
ci_job_id 678303074 678303074
ci_pipeline_id 47033883 47033883
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~1461ca588d, baseline=1.42.0-SNAPSHOT~5ba267f941
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.919 µs) : 344, 384
.   : milestone, 364,
iast (484.252 µs) : 463, 506
.   : milestone, 484,
iast_FULL (550.667 µs) : 530, 572
.   : milestone, 551,
iast_GLOBAL (506.496 µs) : 485, 528
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (481.67 µs) : 461, 503
.   : milestone, 482,
iast_INACTIVE (445.341 µs) : 425, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (473.017 µs) : 452, 494
.   : milestone, 473,
tracing (444.103 µs) : 424, 465
.   : milestone, 444,
section candidate
no_agent (370.885 µs) : 351, 391
.   : milestone, 371,
iast (484.76 µs) : 463, 506
.   : milestone, 485,
iast_FULL (553.792 µs) : 532, 575
.   : milestone, 554,
iast_GLOBAL (514.663 µs) : 493, 537
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (499.429 µs) : 478, 521
.   : milestone, 499,
iast_INACTIVE (447.892 µs) : 427, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (470.524 µs) : 449, 492
.   : milestone, 471,
tracing (446.865 µs) : 425, 468
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.919 µs [344.329 µs, 383.508 µs] -
iast 484.252 µs [462.613 µs, 505.891 µs] 120.333 µs (33.1%)
iast_FULL 550.667 µs [529.506 µs, 571.827 µs] 186.748 µs (51.3%)
iast_GLOBAL 506.496 µs [484.901 µs, 528.092 µs] 142.577 µs (39.2%)
iast_HARDCODED_SECRET_DISABLED 481.67 µs [460.643 µs, 502.697 µs] 117.751 µs (32.4%)
iast_INACTIVE 445.341 µs [424.716 µs, 465.966 µs] 81.422 µs (22.4%)
iast_TELEMETRY_OFF 473.017 µs [451.847 µs, 494.187 µs] 109.098 µs (30.0%)
tracing 444.103 µs [423.614 µs, 464.591 µs] 80.184 µs (22.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.885 µs [351.212 µs, 390.559 µs] -
iast 484.76 µs [463.11 µs, 506.409 µs] 113.875 µs (30.7%)
iast_FULL 553.792 µs [532.39 µs, 575.194 µs] 182.907 µs (49.3%)
iast_GLOBAL 514.663 µs [492.791 µs, 536.534 µs] 143.778 µs (38.8%)
iast_HARDCODED_SECRET_DISABLED 499.429 µs [478.168 µs, 520.689 µs] 128.543 µs (34.7%)
iast_INACTIVE 447.892 µs [427.251 µs, 468.534 µs] 77.007 µs (20.8%)
iast_TELEMETRY_OFF 470.524 µs [449.438 µs, 491.611 µs] 99.639 µs (26.9%)
tracing 446.865 µs [425.417 µs, 468.314 µs] 75.98 µs (20.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~1461ca588d, baseline=1.42.0-SNAPSHOT~5ba267f941
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.346 ms) : 1327, 1365
.   : milestone, 1346,
appsec (1.7 ms) : 1677, 1723
.   : milestone, 1700,
appsec_no_iast (1.705 ms) : 1681, 1730
.   : milestone, 1705,
iast (1.488 ms) : 1466, 1509
.   : milestone, 1488,
profiling (1.485 ms) : 1463, 1508
.   : milestone, 1485,
tracing (1.487 ms) : 1463, 1511
.   : milestone, 1487,
section candidate
no_agent (1.346 ms) : 1327, 1364
.   : milestone, 1346,
appsec (1.723 ms) : 1698, 1748
.   : milestone, 1723,
appsec_no_iast (1.742 ms) : 1717, 1767
.   : milestone, 1742,
iast (1.468 ms) : 1444, 1491
.   : milestone, 1468,
profiling (1.485 ms) : 1460, 1510
.   : milestone, 1485,
tracing (1.488 ms) : 1463, 1512
.   : milestone, 1488,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.327 ms, 1.365 ms] -
appsec 1.7 ms [1.677 ms, 1.723 ms] 354.462 µs (26.3%)
appsec_no_iast 1.705 ms [1.681 ms, 1.73 ms] 359.371 µs (26.7%)
iast 1.488 ms [1.466 ms, 1.509 ms] 142.007 µs (10.6%)
profiling 1.485 ms [1.463 ms, 1.508 ms] 139.248 µs (10.3%)
tracing 1.487 ms [1.463 ms, 1.511 ms] 140.765 µs (10.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.327 ms, 1.364 ms] -
appsec 1.723 ms [1.698 ms, 1.748 ms] 377.434 µs (28.0%)
appsec_no_iast 1.742 ms [1.717 ms, 1.767 ms] 395.952 µs (29.4%)
iast 1.468 ms [1.444 ms, 1.491 ms] 121.863 µs (9.1%)
profiling 1.485 ms [1.46 ms, 1.51 ms] 139.076 µs (10.3%)
tracing 1.488 ms [1.463 ms, 1.512 ms] 142.036 µs (10.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/fallback-from-uds-to-port
git_commit_date 1729515503 1729515524
git_commit_sha 5ba267f 1461ca5
release_version 1.42.0-SNAPSHOT~5ba267f941 1.42.0-SNAPSHOT~1461ca588d
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1729517481 1729517481
ci_job_id 678303075 678303075
ci_pipeline_id 47033883 47033883
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~1461ca588d, baseline=1.42.0-SNAPSHOT~5ba267f941
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.143 s) : 15143000, 15143000
.   : milestone, 15143000,
appsec (15.037 s) : 15037000, 15037000
.   : milestone, 15037000,
iast (18.634 s) : 18634000, 18634000
.   : milestone, 18634000,
iast_GLOBAL (18.061 s) : 18061000, 18061000
.   : milestone, 18061000,
profiling (15.784 s) : 15784000, 15784000
.   : milestone, 15784000,
tracing (15.105 s) : 15105000, 15105000
.   : milestone, 15105000,
section candidate
no_agent (14.993 s) : 14993000, 14993000
.   : milestone, 14993000,
appsec (15.198 s) : 15198000, 15198000
.   : milestone, 15198000,
iast (19.267 s) : 19267000, 19267000
.   : milestone, 19267000,
iast_GLOBAL (17.806 s) : 17806000, 17806000
.   : milestone, 17806000,
profiling (15.029 s) : 15029000, 15029000
.   : milestone, 15029000,
tracing (15.053 s) : 15053000, 15053000
.   : milestone, 15053000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.143 s [15.143 s, 15.143 s] -
appsec 15.037 s [15.037 s, 15.037 s] -106.0 ms (-0.7%)
iast 18.634 s [18.634 s, 18.634 s] 3.491 s (23.1%)
iast_GLOBAL 18.061 s [18.061 s, 18.061 s] 2.918 s (19.3%)
profiling 15.784 s [15.784 s, 15.784 s] 641.0 ms (4.2%)
tracing 15.105 s [15.105 s, 15.105 s] -38.0 ms (-0.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.993 s [14.993 s, 14.993 s] -
appsec 15.198 s [15.198 s, 15.198 s] 205.0 ms (1.4%)
iast 19.267 s [19.267 s, 19.267 s] 4.274 s (28.5%)
iast_GLOBAL 17.806 s [17.806 s, 17.806 s] 2.813 s (18.8%)
profiling 15.029 s [15.029 s, 15.029 s] 36.0 ms (0.2%)
tracing 15.053 s [15.053 s, 15.053 s] 60.0 ms (0.4%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~1461ca588d, baseline=1.42.0-SNAPSHOT~5ba267f941
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.32 ms) : 2279, 2362
.   : milestone, 2320,
iast (2.066 ms) : 2014, 2118
.   : milestone, 2066,
iast_GLOBAL (2.117 ms) : 2064, 2170
.   : milestone, 2117,
profiling (1.934 ms) : 1892, 1976
.   : milestone, 1934,
tracing (1.912 ms) : 1873, 1952
.   : milestone, 1912,
section candidate
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.309 ms) : 2269, 2350
.   : milestone, 2309,
iast (2.071 ms) : 2019, 2122
.   : milestone, 2071,
iast_GLOBAL (2.117 ms) : 2064, 2170
.   : milestone, 2117,
profiling (2.431 ms) : 2243, 2619
.   : milestone, 2431,
tracing (1.91 ms) : 1871, 1950
.   : milestone, 1910,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.459 ms, 1.482 ms] -
appsec 2.32 ms [2.279 ms, 2.362 ms] 850.055 µs (57.8%)
iast 2.066 ms [2.014 ms, 2.118 ms] 595.402 µs (40.5%)
iast_GLOBAL 2.117 ms [2.064 ms, 2.17 ms] 646.715 µs (44.0%)
profiling 1.934 ms [1.892 ms, 1.976 ms] 463.824 µs (31.5%)
tracing 1.912 ms [1.873 ms, 1.952 ms] 442.241 µs (30.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.309 ms [2.269 ms, 2.35 ms] 842.759 µs (57.5%)
iast 2.071 ms [2.019 ms, 2.122 ms] 603.909 µs (41.2%)
iast_GLOBAL 2.117 ms [2.064 ms, 2.17 ms] 650.307 µs (44.3%)
profiling 2.431 ms [2.243 ms, 2.619 ms] 964.438 µs (65.8%)
tracing 1.91 ms [1.871 ms, 1.95 ms] 443.703 µs (30.3%)

@mcculls mcculls force-pushed the mcculls/fallback-from-uds-to-port branch 2 times, most recently from 2729acd to 47683b6 Compare October 21, 2024 09:24
@mcculls
Fall back to ports when we cannot use auto-discovered unix domain soc…
1461ca5 
…kets.

This might be due to issues linking the JFFI library or permission problems.
@mcculls mcculls force-pushed the mcculls/fallback-from-uds-to-port branch from 47683b6 to 1461ca5 Compare October 21, 2024 12:58
@mcculls mcculls merged commit 215c0ac into master Oct 21, 2024
104 checks passed
@mcculls mcculls deleted the mcculls/fallback-from-uds-to-port branch October 21, 2024 15:57
@github-actions github-actions bot added this to the 1.42.0 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

@dougqh dougqh Awaiting requested review from dougqh

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal

Assignees
No one assigned
Labels
comp: core Tracer core
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @amarziali