Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve isolation of embedded JFFI dependency #7789

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Improve isolation of embedded JFFI dependency #7789

merged 1 commit into from
Oct 21, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Oct 17, 2024 •
edited
Loading

What Does This Do

Isolates our embedded JFFI dependency from other versions that might be on the boot or system class-paths.

Motivation

Avoids some obscure linkage exceptions that can happen when multiple versions of JFFI are on the class-path.

Additional Notes

This PR contains two changes:

  • Removing parent delegation when looking up com.kenai.jffi classes from our isolatiing DatadogClassLoader
  • Replacing com.kenai.jffi.Init with a much simpler PatchInit class that loads from the same isolating class-loader

Note we cannot fully shade JFFI (or the related JNR dependency) because it has a native component which would also need to be updated and recompiled for every platform.

Contributor Checklist

Jira ticket: APMS-13480

@mcculls mcculls added the tag: do not merge Do not merge changes label Oct 17, 2024
@mcculls mcculls force-pushed the mcculls/improve-jffi-isolation branch 2 times, most recently from 8717290 to 0740aa1 Compare October 17, 2024 15:34
@pr-commenter
Copy link

pr-commenter bot commented Oct 17, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/improve-jffi-isolation
git_commit_date 1729502178 1729502678
git_commit_sha f687c2d 167dca9
release_version 1.42.0-SNAPSHOT~f687c2d038 1.42.0-SNAPSHOT~167dca9227
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729504986 1729504986
ci_job_id 678049250 678049250
ci_pipeline_id 47019075 47019075
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~167dca9227, baseline=1.42.0-SNAPSHOT~f687c2d038

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1076629
Total [baseline] (8.582 s) : 0, 8581923
Agent [candidate] (1.078 s) : 0, 1078328
Total [candidate] (8.577 s) : 0, 8577063
section iast
Agent [baseline] (1.211 s) : 0, 1211137
Total [baseline] (9.121 s) : 0, 9120953
Agent [candidate] (1.204 s) : 0, 1203732
Total [candidate] (9.133 s) : 0, 9133062
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.209 s) : 0, 1209273
Total [baseline] (9.083 s) : 0, 9083191
Agent [candidate] (1.204 s) : 0, 1203736
Total [candidate] (9.069 s) : 0, 9069241
section iast_TELEMETRY_OFF
Agent [baseline] (1.209 s) : 0, 1208510
Total [baseline] (9.121 s) : 0, 9121155
Agent [candidate] (1.207 s) : 0, 1206969
Total [candidate] (9.08 s) : 0, 9079674
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent iast 1.211 s 134.508 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.209 s 132.644 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.209 s 131.881 ms (12.2%)
Total tracing 8.582 s -
Total iast 9.121 s 539.03 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.083 s 501.268 ms (5.8%)
Total iast_TELEMETRY_OFF 9.121 s 539.232 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent iast 1.204 s 125.404 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.204 s 125.408 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.207 s 128.641 ms (11.9%)
Total tracing 8.577 s -
Total iast 9.133 s 555.999 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.069 s 492.178 ms (5.7%)
Total iast_TELEMETRY_OFF 9.08 s 502.611 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~167dca9227, baseline=1.42.0-SNAPSHOT~f687c2d038

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.762 ms) : 0, 685762
BytebuddyAgent [candidate] (686.953 ms) : 0, 686953
GlobalTracer [baseline] (312.439 ms) : 0, 312439
GlobalTracer [candidate] (312.908 ms) : 0, 312908
AppSec [baseline] (53.864 ms) : 0, 53864
AppSec [candidate] (53.872 ms) : 0, 53872
Remote Config [baseline] (669.542 µs) : 0, 670
Remote Config [candidate] (661.638 µs) : 0, 662
Telemetry [baseline] (10.204 ms) : 0, 10204
Telemetry [candidate] (10.161 ms) : 0, 10161
section iast
BytebuddyAgent [baseline] (807.806 ms) : 0, 807806
BytebuddyAgent [candidate] (802.598 ms) : 0, 802598
GlobalTracer [baseline] (303.827 ms) : 0, 303827
GlobalTracer [candidate] (302.147 ms) : 0, 302147
AppSec [baseline] (56.101 ms) : 0, 56101
AppSec [candidate] (57.09 ms) : 0, 57090
IAST [baseline] (21.097 ms) : 0, 21097
IAST [candidate] (20.398 ms) : 0, 20398
Remote Config [baseline] (607.856 µs) : 0, 608
Remote Config [candidate] (612.381 µs) : 0, 612
Telemetry [baseline] (7.858 ms) : 0, 7858
Telemetry [candidate] (7.091 ms) : 0, 7091
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (806.205 ms) : 0, 806205
BytebuddyAgent [candidate] (802.409 ms) : 0, 802409
GlobalTracer [baseline] (303.918 ms) : 0, 303918
GlobalTracer [candidate] (301.961 ms) : 0, 301961
AppSec [baseline] (57.45 ms) : 0, 57450
AppSec [candidate] (56.675 ms) : 0, 56675
IAST [baseline] (20.216 ms) : 0, 20216
IAST [candidate] (20.444 ms) : 0, 20444
Remote Config [baseline] (591.713 µs) : 0, 592
Remote Config [candidate] (593.296 µs) : 0, 593
Telemetry [baseline] (7.107 ms) : 0, 7107
Telemetry [candidate] (7.884 ms) : 0, 7884
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.919 ms) : 0, 804919
BytebuddyAgent [candidate] (804.364 ms) : 0, 804364
GlobalTracer [baseline] (304.132 ms) : 0, 304132
GlobalTracer [candidate] (303.599 ms) : 0, 303599
AppSec [baseline] (56.459 ms) : 0, 56459
AppSec [candidate] (57.443 ms) : 0, 57443
IAST [baseline] (21.622 ms) : 0, 21622
IAST [candidate] (20.112 ms) : 0, 20112
Remote Config [baseline] (591.893 µs) : 0, 592
Remote Config [candidate] (594.132 µs) : 0, 594
Telemetry [baseline] (6.987 ms) : 0, 6987
Telemetry [candidate] (6.989 ms) : 0, 6989
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~167dca9227, baseline=1.42.0-SNAPSHOT~f687c2d038

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1075904
Total [baseline] (10.437 s) : 0, 10437114
Agent [candidate] (1.092 s) : 0, 1091933
Total [candidate] (10.399 s) : 0, 10398808
section appsec
Agent [baseline] (1.21 s) : 0, 1209986
Total [baseline] (10.593 s) : 0, 10592701
Agent [candidate] (1.213 s) : 0, 1212651
Total [candidate] (10.61 s) : 0, 10610118
section iast
Agent [baseline] (1.209 s) : 0, 1208604
Total [baseline] (10.908 s) : 0, 10907982
Agent [candidate] (1.205 s) : 0, 1204662
Total [candidate] (10.831 s) : 0, 10830680
section profiling
Agent [baseline] (1.277 s) : 0, 1277258
Total [baseline] (10.689 s) : 0, 10688878
Agent [candidate] (1.274 s) : 0, 1273648
Total [candidate] (10.678 s) : 0, 10678362
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.21 s 134.082 ms (12.5%)
Agent iast 1.209 s 132.7 ms (12.3%)
Agent profiling 1.277 s 201.354 ms (18.7%)
Total tracing 10.437 s -
Total appsec 10.593 s 155.586 ms (1.5%)
Total iast 10.908 s 470.868 ms (4.5%)
Total profiling 10.689 s 251.764 ms (2.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent appsec 1.213 s 120.718 ms (11.1%)
Agent iast 1.205 s 112.729 ms (10.3%)
Agent profiling 1.274 s 181.715 ms (16.6%)
Total tracing 10.399 s -
Total appsec 10.61 s 211.31 ms (2.0%)
Total iast 10.831 s 431.873 ms (4.2%)
Total profiling 10.678 s 279.554 ms (2.7%) 
gantt
    title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~167dca9227, baseline=1.42.0-SNAPSHOT~f687c2d038

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.748 ms) : 0, 685748
BytebuddyAgent [candidate] (694.629 ms) : 0, 694629
GlobalTracer [baseline] (312.273 ms) : 0, 312273
GlobalTracer [candidate] (317.096 ms) : 0, 317096
AppSec [baseline] (53.805 ms) : 0, 53805
AppSec [candidate] (54.628 ms) : 0, 54628
Remote Config [baseline] (659.809 µs) : 0, 660
Remote Config [candidate] (674.61 µs) : 0, 675
Telemetry [baseline] (9.731 ms) : 0, 9731
Telemetry [candidate] (11.065 ms) : 0, 11065
section appsec
BytebuddyAgent [baseline] (702.628 ms) : 0, 702628
BytebuddyAgent [candidate] (704.85 ms) : 0, 704850
GlobalTracer [baseline] (309.322 ms) : 0, 309322
GlobalTracer [candidate] (310.495 ms) : 0, 310495
AppSec [baseline] (165.923 ms) : 0, 165923
AppSec [candidate] (165.388 ms) : 0, 165388
Remote Config [baseline] (632.901 µs) : 0, 633
Remote Config [candidate] (635.021 µs) : 0, 635
Telemetry [baseline] (8.172 ms) : 0, 8172
Telemetry [candidate] (7.793 ms) : 0, 7793
IAST [baseline] (19.289 ms) : 0, 19289
IAST [candidate] (19.429 ms) : 0, 19429
section iast
BytebuddyAgent [baseline] (806.153 ms) : 0, 806153
BytebuddyAgent [candidate] (803.413 ms) : 0, 803413
GlobalTracer [baseline] (303.064 ms) : 0, 303064
GlobalTracer [candidate] (302.144 ms) : 0, 302144
AppSec [baseline] (55.346 ms) : 0, 55346
AppSec [candidate] (57.247 ms) : 0, 57247
Remote Config [baseline] (587.123 µs) : 0, 587
Remote Config [candidate] (600.865 µs) : 0, 601
Telemetry [baseline] (6.97 ms) : 0, 6970
Telemetry [candidate] (6.965 ms) : 0, 6965
IAST [baseline] (22.699 ms) : 0, 22699
IAST [candidate] (20.481 ms) : 0, 20481
section profiling
BytebuddyAgent [baseline] (681.411 ms) : 0, 681411
BytebuddyAgent [candidate] (680.388 ms) : 0, 680388
GlobalTracer [baseline] (397.184 ms) : 0, 397184
GlobalTracer [candidate] (395.87 ms) : 0, 395870
AppSec [baseline] (54.787 ms) : 0, 54787
AppSec [candidate] (54.38 ms) : 0, 54380
Remote Config [baseline] (653.784 µs) : 0, 654
Remote Config [candidate] (646.194 µs) : 0, 646
Telemetry [baseline] (12.329 ms) : 0, 12329
Telemetry [candidate] (14.418 ms) : 0, 14418
ProfilingAgent [baseline] (92.022 ms) : 0, 92022
ProfilingAgent [candidate] (89.006 ms) : 0, 89006
Profiling [baseline] (92.045 ms) : 0, 92045
Profiling [candidate] (89.03 ms) : 0, 89030
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-21T09:33:36 2024-10-21T09:40:28
git_branch master mcculls/improve-jffi-isolation
git_commit_date 1729502178 1729502678
git_commit_sha f687c2d 167dca9
release_version 1.42.0-SNAPSHOT~f687c2d038 1.42.0-SNAPSHOT~167dca9227
start_time 2024-10-21T09:33:22 2024-10-21T09:40:15
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729503976 1729503976
ci_job_id 678049251 678049251
ci_pipeline_id 47019075 47019075
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~167dca9227, baseline=1.42.0-SNAPSHOT~f687c2d038
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.348 ms) : 1329, 1368
.   : milestone, 1348,
appsec (1.719 ms) : 1693, 1745
.   : milestone, 1719,
appsec_no_iast (1.713 ms) : 1689, 1738
.   : milestone, 1713,
iast (1.487 ms) : 1464, 1510
.   : milestone, 1487,
profiling (1.489 ms) : 1465, 1514
.   : milestone, 1489,
tracing (1.471 ms) : 1446, 1495
.   : milestone, 1471,
section candidate
no_agent (1.356 ms) : 1336, 1375
.   : milestone, 1356,
appsec (1.719 ms) : 1695, 1744
.   : milestone, 1719,
appsec_no_iast (1.724 ms) : 1699, 1748
.   : milestone, 1724,
iast (1.501 ms) : 1478, 1523
.   : milestone, 1501,
profiling (1.492 ms) : 1469, 1516
.   : milestone, 1492,
tracing (1.474 ms) : 1449, 1499
.   : milestone, 1474,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.329 ms, 1.368 ms] -
appsec 1.719 ms [1.693 ms, 1.745 ms] 370.588 µs (27.5%)
appsec_no_iast 1.713 ms [1.689 ms, 1.738 ms] 365.042 µs (27.1%)
iast 1.487 ms [1.464 ms, 1.51 ms] 138.783 µs (10.3%)
profiling 1.489 ms [1.465 ms, 1.514 ms] 141.116 µs (10.5%)
tracing 1.471 ms [1.446 ms, 1.495 ms] 122.441 µs (9.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.356 ms [1.336 ms, 1.375 ms] -
appsec 1.719 ms [1.695 ms, 1.744 ms] 363.284 µs (26.8%)
appsec_no_iast 1.724 ms [1.699 ms, 1.748 ms] 367.801 µs (27.1%)
iast 1.501 ms [1.478 ms, 1.523 ms] 144.846 µs (10.7%)
profiling 1.492 ms [1.469 ms, 1.516 ms] 136.399 µs (10.1%)
tracing 1.474 ms [1.449 ms, 1.499 ms] 118.193 µs (8.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~167dca9227, baseline=1.42.0-SNAPSHOT~f687c2d038
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.272 µs) : 352, 392
.   : milestone, 372,
iast (496.568 µs) : 474, 519
.   : milestone, 497,
iast_FULL (557.234 µs) : 536, 579
.   : milestone, 557,
iast_GLOBAL (514.864 µs) : 493, 537
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (490.871 µs) : 469, 512
.   : milestone, 491,
iast_INACTIVE (455.398 µs) : 435, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (478.866 µs) : 458, 500
.   : milestone, 479,
tracing (447.593 µs) : 427, 468
.   : milestone, 448,
section candidate
no_agent (370.842 µs) : 350, 392
.   : milestone, 371,
iast (491.605 µs) : 470, 513
.   : milestone, 492,
iast_FULL (558.857 µs) : 538, 580
.   : milestone, 559,
iast_GLOBAL (521.769 µs) : 499, 545
.   : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (490.876 µs) : 470, 512
.   : milestone, 491,
iast_INACTIVE (455.474 µs) : 434, 477
.   : milestone, 455,
iast_TELEMETRY_OFF (477.651 µs) : 456, 499
.   : milestone, 478,
tracing (445.459 µs) : 425, 466
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.272 µs [352.112 µs, 392.432 µs] -
iast 496.568 µs [474.386 µs, 518.75 µs] 124.296 µs (33.4%)
iast_FULL 557.234 µs [535.935 µs, 578.533 µs] 184.962 µs (49.7%)
iast_GLOBAL 514.864 µs [493.104 µs, 536.625 µs] 142.592 µs (38.3%)
iast_HARDCODED_SECRET_DISABLED 490.871 µs [469.324 µs, 512.418 µs] 118.599 µs (31.9%)
iast_INACTIVE 455.398 µs [434.531 µs, 476.265 µs] 83.126 µs (22.3%)
iast_TELEMETRY_OFF 478.866 µs [457.577 µs, 500.155 µs] 106.594 µs (28.6%)
tracing 447.593 µs [426.972 µs, 468.214 µs] 75.321 µs (20.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.842 µs [350.131 µs, 391.552 µs] -
iast 491.605 µs [470.139 µs, 513.07 µs] 120.763 µs (32.6%)
iast_FULL 558.857 µs [537.726 µs, 579.987 µs] 188.015 µs (50.7%)
iast_GLOBAL 521.769 µs [498.754 µs, 544.784 µs] 150.927 µs (40.7%)
iast_HARDCODED_SECRET_DISABLED 490.876 µs [469.683 µs, 512.07 µs] 120.035 µs (32.4%)
iast_INACTIVE 455.474 µs [433.809 µs, 477.14 µs] 84.633 µs (22.8%)
iast_TELEMETRY_OFF 477.651 µs [456.057 µs, 499.245 µs] 106.809 µs (28.8%)
tracing 445.459 µs [425.17 µs, 465.749 µs] 74.618 µs (20.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/improve-jffi-isolation
git_commit_date 1729502178 1729502678
git_commit_sha f687c2d 167dca9
release_version 1.42.0-SNAPSHOT~f687c2d038 1.42.0-SNAPSHOT~167dca9227
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1729504551 1729504551
ci_job_id 678049252 678049252
ci_pipeline_id 47019075 47019075
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~167dca9227, baseline=1.42.0-SNAPSHOT~f687c2d038
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1476
.   : milestone, 1465,
appsec (2.329 ms) : 2288, 2371
.   : milestone, 2329,
iast (2.08 ms) : 2028, 2133
.   : milestone, 2080,
iast_GLOBAL (2.123 ms) : 2070, 2176
.   : milestone, 2123,
profiling (1.95 ms) : 1907, 1993
.   : milestone, 1950,
tracing (1.921 ms) : 1882, 1961
.   : milestone, 1921,
section candidate
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.314 ms) : 2273, 2354
.   : milestone, 2314,
iast (2.081 ms) : 2029, 2133
.   : milestone, 2081,
iast_GLOBAL (2.124 ms) : 2072, 2177
.   : milestone, 2124,
profiling (1.944 ms) : 1901, 1987
.   : milestone, 1944,
tracing (1.931 ms) : 1891, 1971
.   : milestone, 1931,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.454 ms, 1.476 ms] -
appsec 2.329 ms [2.288 ms, 2.371 ms] 864.314 µs (59.0%)
iast 2.08 ms [2.028 ms, 2.133 ms] 615.284 µs (42.0%)
iast_GLOBAL 2.123 ms [2.07 ms, 2.176 ms] 658.027 µs (44.9%)
profiling 1.95 ms [1.907 ms, 1.993 ms] 484.924 µs (33.1%)
tracing 1.921 ms [1.882 ms, 1.961 ms] 456.493 µs (31.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.314 ms [2.273 ms, 2.354 ms] 846.962 µs (57.7%)
iast 2.081 ms [2.029 ms, 2.133 ms] 614.659 µs (41.9%)
iast_GLOBAL 2.124 ms [2.072 ms, 2.177 ms] 657.809 µs (44.9%)
profiling 1.944 ms [1.901 ms, 1.987 ms] 477.688 µs (32.6%)
tracing 1.931 ms [1.891 ms, 1.971 ms] 464.076 µs (31.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~167dca9227, baseline=1.42.0-SNAPSHOT~f687c2d038
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.234 s) : 15234000, 15234000
.   : milestone, 15234000,
appsec (15.068 s) : 15068000, 15068000
.   : milestone, 15068000,
iast (19.277 s) : 19277000, 19277000
.   : milestone, 19277000,
iast_GLOBAL (17.854 s) : 17854000, 17854000
.   : milestone, 17854000,
profiling (15.22 s) : 15220000, 15220000
.   : milestone, 15220000,
tracing (15.118 s) : 15118000, 15118000
.   : milestone, 15118000,
section candidate
no_agent (15.323 s) : 15323000, 15323000
.   : milestone, 15323000,
appsec (14.928 s) : 14928000, 14928000
.   : milestone, 14928000,
iast (18.788 s) : 18788000, 18788000
.   : milestone, 18788000,
iast_GLOBAL (17.968 s) : 17968000, 17968000
.   : milestone, 17968000,
profiling (15.428 s) : 15428000, 15428000
.   : milestone, 15428000,
tracing (15.369 s) : 15369000, 15369000
.   : milestone, 15369000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.234 s [15.234 s, 15.234 s] -
appsec 15.068 s [15.068 s, 15.068 s] -166.0 ms (-1.1%)
iast 19.277 s [19.277 s, 19.277 s] 4.043 s (26.5%)
iast_GLOBAL 17.854 s [17.854 s, 17.854 s] 2.62 s (17.2%)
profiling 15.22 s [15.22 s, 15.22 s] -14.0 ms (-0.1%)
tracing 15.118 s [15.118 s, 15.118 s] -116.0 ms (-0.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.323 s [15.323 s, 15.323 s] -
appsec 14.928 s [14.928 s, 14.928 s] -395.0 ms (-2.6%)
iast 18.788 s [18.788 s, 18.788 s] 3.465 s (22.6%)
iast_GLOBAL 17.968 s [17.968 s, 17.968 s] 2.645 s (17.3%)
profiling 15.428 s [15.428 s, 15.428 s] 105.0 ms (0.7%)
tracing 15.369 s [15.369 s, 15.369 s] 46.0 ms (0.3%)

@mcculls mcculls added comp: core Tracer core and removed tag: do not merge Do not merge changes labels Oct 17, 2024
@mcculls mcculls changed the title [WIP] Improve isolation of embedded JFFI dependency Improve isolation of embedded JFFI dependency Oct 17, 2024
@mcculls mcculls marked this pull request as ready for review October 17, 2024 16:32
@mcculls mcculls requested a review from a team as a code owner October 17, 2024 16:32
@mcculls mcculls requested review from smola and dougqh October 17, 2024 16:32
@mcculls mcculls force-pushed the mcculls/improve-jffi-isolation branch 2 times, most recently from 5801dc8 to 495c7fb Compare October 17, 2024 19:57
@mcculls mcculls force-pushed the mcculls/improve-jffi-isolation branch from 495c7fb to 167dca9 Compare October 21, 2024 09:24
@mcculls mcculls merged commit 5ba267f into master Oct 21, 2024
104 checks passed
@mcculls mcculls deleted the mcculls/improve-jffi-isolation branch October 21, 2024 12:58
@github-actions github-actions bot added this to the 1.42.0 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datadog-datadog-prod-us1 datadog-datadog-prod-us1[bot] datadog-datadog-prod-us1[bot] left review comments

@dougqh dougqh dougqh left review comments

@smola smola smola approved these changes

Assignees
No one assigned
Labels
comp: core Tracer core
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mcculls @smola @dougqh