Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grizzly http client: finish spans for all handlers #7772

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Grizzly http client: finish spans for all handlers #7772

merged 2 commits into from
Oct 16, 2024

Conversation

amarziali
Copy link
Collaborator

What Does This Do

In grizzly http client we start a span that we finish when the AsyncCompletionHandler was called. However the general signature of the client executeRequest method is taking the super interfaceAsyncHandler.

If someone is not using explicitly a subclass of AsyncCompletionHandler as it's the case for mulesoft (it uses other things under the hood), the span will never finish.

This PR fixes this corner case

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali added type: bug inst: others All other instrumentations labels Oct 16, 2024
@amarziali amarziali requested a review from a team as a code owner October 16, 2024 10:25
@amarziali amarziali enabled auto-merge (squash) October 16, 2024 10:30
@pr-commenter
Copy link

pr-commenter bot commented Oct 16, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/grizzly-client
git_commit_date 1729072260 1729074149
git_commit_sha e08f541 b166332
release_version 1.41.0-SNAPSHOT~e08f541bb5 1.41.0-SNAPSHOT~b166332a6e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729076489 1729076489
ci_job_id 673722014 673722014
ci_pipeline_id 46700004 46700004
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~b166332a6e, baseline=1.41.0-SNAPSHOT~e08f541bb5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077654
Total [baseline] (8.564 s) : 0, 8563986
Agent [candidate] (1.069 s) : 0, 1068759
Total [candidate] (8.559 s) : 0, 8559088
section iast
Agent [baseline] (1.197 s) : 0, 1196820
Total [baseline] (9.131 s) : 0, 9131072
Agent [candidate] (1.206 s) : 0, 1206399
Total [candidate] (9.137 s) : 0, 9137011
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.205 s) : 0, 1204907
Total [baseline] (9.114 s) : 0, 9114274
Agent [candidate] (1.2 s) : 0, 1200412
Total [candidate] (9.083 s) : 0, 9083413
section iast_TELEMETRY_OFF
Agent [baseline] (1.195 s) : 0, 1194581
Total [baseline] (9.089 s) : 0, 9089188
Agent [candidate] (1.199 s) : 0, 1199190
Total [candidate] (9.137 s) : 0, 9136724
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent iast 1.197 s 119.165 ms (11.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.205 s 127.252 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.195 s 116.926 ms (10.9%)
Total tracing 8.564 s -
Total iast 9.131 s 567.086 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.114 s 550.288 ms (6.4%)
Total iast_TELEMETRY_OFF 9.089 s 525.202 ms (6.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent iast 1.206 s 137.64 ms (12.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.2 s 131.652 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.199 s 130.431 ms (12.2%)
Total tracing 8.559 s -
Total iast 9.137 s 577.924 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.083 s 524.326 ms (6.1%)
Total iast_TELEMETRY_OFF 9.137 s 577.636 ms (6.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~b166332a6e, baseline=1.41.0-SNAPSHOT~e08f541bb5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.138 ms) : 0, 687138
BytebuddyAgent [candidate] (680.595 ms) : 0, 680595
GlobalTracer [baseline] (314.57 ms) : 0, 314570
GlobalTracer [candidate] (312.585 ms) : 0, 312585
AppSec [baseline] (53.96 ms) : 0, 53960
AppSec [candidate] (53.799 ms) : 0, 53799
Remote Config [baseline] (666.266 µs) : 0, 666
Remote Config [candidate] (660.317 µs) : 0, 660
Telemetry [baseline] (7.589 ms) : 0, 7589
Telemetry [candidate] (7.487 ms) : 0, 7487
section iast
BytebuddyAgent [baseline] (796.345 ms) : 0, 796345
BytebuddyAgent [candidate] (802.55 ms) : 0, 802550
GlobalTracer [baseline] (300.556 ms) : 0, 300556
GlobalTracer [candidate] (303.446 ms) : 0, 303446
AppSec [baseline] (56.281 ms) : 0, 56281
AppSec [candidate] (57.474 ms) : 0, 57474
IAST [baseline] (22.243 ms) : 0, 22243
IAST [candidate] (21.417 ms) : 0, 21417
Remote Config [baseline] (608.02 µs) : 0, 608
Remote Config [candidate] (606.825 µs) : 0, 607
Telemetry [baseline] (7.152 ms) : 0, 7152
Telemetry [candidate] (7.139 ms) : 0, 7139
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.911 ms) : 0, 800911
BytebuddyAgent [candidate] (797.795 ms) : 0, 797795
GlobalTracer [baseline] (303.637 ms) : 0, 303637
GlobalTracer [candidate] (302.687 ms) : 0, 302687
AppSec [baseline] (55.941 ms) : 0, 55941
AppSec [candidate] (56.296 ms) : 0, 56296
IAST [baseline] (22.918 ms) : 0, 22918
IAST [candidate] (21.323 ms) : 0, 21323
Remote Config [baseline] (603.853 µs) : 0, 604
Remote Config [candidate] (611.165 µs) : 0, 611
Telemetry [baseline] (7.115 ms) : 0, 7115
Telemetry [candidate] (7.939 ms) : 0, 7939
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (793.689 ms) : 0, 793689
BytebuddyAgent [candidate] (795.182 ms) : 0, 795182
GlobalTracer [baseline] (302.018 ms) : 0, 302018
GlobalTracer [candidate] (304.354 ms) : 0, 304354
AppSec [baseline] (54.507 ms) : 0, 54507
AppSec [candidate] (55.019 ms) : 0, 55019
IAST [baseline] (23.065 ms) : 0, 23065
IAST [candidate] (23.291 ms) : 0, 23291
Remote Config [baseline] (608.13 µs) : 0, 608
Remote Config [candidate] (607.23 µs) : 0, 607
Telemetry [baseline] (6.982 ms) : 0, 6982
Telemetry [candidate] (7.02 ms) : 0, 7020
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~b166332a6e, baseline=1.41.0-SNAPSHOT~e08f541bb5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1071431
Total [baseline] (10.45 s) : 0, 10450221
Agent [candidate] (1.079 s) : 0, 1078580
Total [candidate] (10.424 s) : 0, 10424474
section appsec
Agent [baseline] (1.203 s) : 0, 1203281
Total [baseline] (10.601 s) : 0, 10601293
Agent [candidate] (1.206 s) : 0, 1205827
Total [candidate] (10.619 s) : 0, 10619243
section iast
Agent [baseline] (1.198 s) : 0, 1197906
Total [baseline] (10.922 s) : 0, 10922154
Agent [candidate] (1.199 s) : 0, 1199199
Total [candidate] (10.882 s) : 0, 10882427
section profiling
Agent [baseline] (1.265 s) : 0, 1265484
Total [baseline] (10.716 s) : 0, 10715878
Agent [candidate] (1.277 s) : 0, 1276519
Total [candidate] (10.692 s) : 0, 10692493
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.203 s 131.849 ms (12.3%)
Agent iast 1.198 s 126.475 ms (11.8%)
Agent profiling 1.265 s 194.052 ms (18.1%)
Total tracing 10.45 s -
Total appsec 10.601 s 151.072 ms (1.4%)
Total iast 10.922 s 471.933 ms (4.5%)
Total profiling 10.716 s 265.657 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.206 s 127.247 ms (11.8%)
Agent iast 1.199 s 120.618 ms (11.2%)
Agent profiling 1.277 s 197.939 ms (18.4%)
Total tracing 10.424 s -
Total appsec 10.619 s 194.77 ms (1.9%)
Total iast 10.882 s 457.954 ms (4.4%)
Total profiling 10.692 s 268.019 ms (2.6%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~b166332a6e, baseline=1.41.0-SNAPSHOT~e08f541bb5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.38 ms) : 0, 682380
BytebuddyAgent [candidate] (687.025 ms) : 0, 687025
GlobalTracer [baseline] (313.367 ms) : 0, 313367
GlobalTracer [candidate] (315.453 ms) : 0, 315453
AppSec [baseline] (53.837 ms) : 0, 53837
AppSec [candidate] (54.199 ms) : 0, 54199
Remote Config [baseline] (663.839 µs) : 0, 664
Remote Config [candidate] (666.139 µs) : 0, 666
Telemetry [baseline] (7.551 ms) : 0, 7551
Telemetry [candidate] (7.512 ms) : 0, 7512
section appsec
BytebuddyAgent [baseline] (698.335 ms) : 0, 698335
BytebuddyAgent [candidate] (699.432 ms) : 0, 699432
GlobalTracer [baseline] (309.758 ms) : 0, 309758
GlobalTracer [candidate] (310.686 ms) : 0, 310686
AppSec [baseline] (162.062 ms) : 0, 162062
AppSec [candidate] (163.013 ms) : 0, 163013
IAST [baseline] (21.502 ms) : 0, 21502
IAST [candidate] (20.624 ms) : 0, 20624
Remote Config [baseline] (631.703 µs) : 0, 632
Remote Config [candidate] (632.009 µs) : 0, 632
Telemetry [baseline] (8.098 ms) : 0, 8098
Telemetry [candidate] (8.087 ms) : 0, 8087
section iast
BytebuddyAgent [baseline] (796.639 ms) : 0, 796639
BytebuddyAgent [candidate] (797.366 ms) : 0, 797366
GlobalTracer [baseline] (301.704 ms) : 0, 301704
GlobalTracer [candidate] (301.525 ms) : 0, 301525
AppSec [baseline] (56.979 ms) : 0, 56979
AppSec [candidate] (57.39 ms) : 0, 57390
IAST [baseline] (21.312 ms) : 0, 21312
IAST [candidate] (21.514 ms) : 0, 21514
Remote Config [baseline] (600.421 µs) : 0, 600
Remote Config [candidate] (618.468 µs) : 0, 618
Telemetry [baseline] (7.06 ms) : 0, 7060
Telemetry [candidate] (7.155 ms) : 0, 7155
section profiling
BytebuddyAgent [baseline] (673.53 ms) : 0, 673530
BytebuddyAgent [candidate] (680.21 ms) : 0, 680210
GlobalTracer [baseline] (394.93 ms) : 0, 394930
GlobalTracer [candidate] (398.431 ms) : 0, 398431
AppSec [baseline] (54.532 ms) : 0, 54532
AppSec [candidate] (54.611 ms) : 0, 54611
Remote Config [baseline] (648.281 µs) : 0, 648
Remote Config [candidate] (652.871 µs) : 0, 653
Telemetry [baseline] (7.423 ms) : 0, 7423
Telemetry [candidate] (7.45 ms) : 0, 7450
ProfilingAgent [baseline] (95.859 ms) : 0, 95859
ProfilingAgent [candidate] (96.346 ms) : 0, 96346
Profiling [baseline] (95.883 ms) : 0, 95883
Profiling [candidate] (96.371 ms) : 0, 96371
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-16T10:31:48 2024-10-16T10:38:37
git_branch master andrea.marziali/grizzly-client
git_commit_date 1729072260 1729074149
git_commit_sha e08f541 b166332
release_version 1.41.0-SNAPSHOT~e08f541bb5 1.41.0-SNAPSHOT~b166332a6e
start_time 2024-10-16T10:31:34 2024-10-16T10:38:23
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729075463 1729075463
ci_job_id 673722015 673722015
ci_pipeline_id 46700004 46700004
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+40.529µs; +93.648µs] or [+2.755%; +6.367%]		 unstable
[-600.895op/s; +600.895op/s] or [-19.529%; +19.529%]		 1.538ms 3076.923op/s 1.471ms 3076.923op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~b166332a6e, baseline=1.41.0-SNAPSHOT~e08f541bb5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.342 ms) : 1323, 1361
.   : milestone, 1342,
appsec (1.704 ms) : 1679, 1729
.   : milestone, 1704,
appsec_no_iast (1.715 ms) : 1691, 1739
.   : milestone, 1715,
iast (1.486 ms) : 1463, 1509
.   : milestone, 1486,
profiling (1.471 ms) : 1447, 1495
.   : milestone, 1471,
tracing (1.472 ms) : 1448, 1497
.   : milestone, 1472,
section candidate
no_agent (1.316 ms) : 1296, 1336
.   : milestone, 1316,
appsec (1.707 ms) : 1682, 1731
.   : milestone, 1707,
appsec_no_iast (1.732 ms) : 1708, 1756
.   : milestone, 1732,
iast (1.472 ms) : 1449, 1496
.   : milestone, 1472,
profiling (1.538 ms) : 1513, 1563
.   : milestone, 1538,
tracing (1.464 ms) : 1440, 1489
.   : milestone, 1464,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.323 ms, 1.361 ms] -
appsec 1.704 ms [1.679 ms, 1.729 ms] 362.018 µs (27.0%)
appsec_no_iast 1.715 ms [1.691 ms, 1.739 ms] 373.094 µs (27.8%)
iast 1.486 ms [1.463 ms, 1.509 ms] 143.894 µs (10.7%)
profiling 1.471 ms [1.447 ms, 1.495 ms] 129.054 µs (9.6%)
tracing 1.472 ms [1.448 ms, 1.497 ms] 130.125 µs (9.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.316 ms [1.296 ms, 1.336 ms] -
appsec 1.707 ms [1.682 ms, 1.731 ms] 390.639 µs (29.7%)
appsec_no_iast 1.732 ms [1.708 ms, 1.756 ms] 416.304 µs (31.6%)
iast 1.472 ms [1.449 ms, 1.496 ms] 156.418 µs (11.9%)
profiling 1.538 ms [1.513 ms, 1.563 ms] 222.135 µs (16.9%)
tracing 1.464 ms [1.44 ms, 1.489 ms] 148.591 µs (11.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~b166332a6e, baseline=1.41.0-SNAPSHOT~e08f541bb5
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.147 µs) : 352, 391
.   : milestone, 371,
iast (478.798 µs) : 458, 500
.   : milestone, 479,
iast_FULL (550.465 µs) : 529, 572
.   : milestone, 550,
iast_GLOBAL (507.493 µs) : 487, 528
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (481.833 µs) : 461, 503
.   : milestone, 482,
iast_INACTIVE (439.754 µs) : 419, 460
.   : milestone, 440,
iast_TELEMETRY_OFF (466.74 µs) : 446, 488
.   : milestone, 467,
tracing (443.788 µs) : 423, 465
.   : milestone, 444,
section candidate
no_agent (367.175 µs) : 348, 387
.   : milestone, 367,
iast (478.781 µs) : 458, 500
.   : milestone, 479,
iast_FULL (548.752 µs) : 528, 570
.   : milestone, 549,
iast_GLOBAL (506.999 µs) : 485, 529
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (482.494 µs) : 461, 504
.   : milestone, 482,
iast_INACTIVE (443.403 µs) : 422, 464
.   : milestone, 443,
iast_TELEMETRY_OFF (468.867 µs) : 448, 490
.   : milestone, 469,
tracing (439.382 µs) : 419, 460
.   : milestone, 439,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.147 µs [351.67 µs, 390.624 µs] -
iast 478.798 µs [457.641 µs, 499.956 µs] 107.651 µs (29.0%)
iast_FULL 550.465 µs [528.961 µs, 571.968 µs] 179.318 µs (48.3%)
iast_GLOBAL 507.493 µs [486.613 µs, 528.373 µs] 136.346 µs (36.7%)
iast_HARDCODED_SECRET_DISABLED 481.833 µs [460.603 µs, 503.063 µs] 110.686 µs (29.8%)
iast_INACTIVE 439.754 µs [419.183 µs, 460.326 µs] 68.607 µs (18.5%)
iast_TELEMETRY_OFF 466.74 µs [445.767 µs, 487.713 µs] 95.593 µs (25.8%)
tracing 443.788 µs [422.542 µs, 465.034 µs] 72.64 µs (19.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.175 µs [347.552 µs, 386.798 µs] -
iast 478.781 µs [457.808 µs, 499.753 µs] 111.605 µs (30.4%)
iast_FULL 548.752 µs [527.604 µs, 569.9 µs] 181.577 µs (49.5%)
iast_GLOBAL 506.999 µs [485.409 µs, 528.588 µs] 139.824 µs (38.1%)
iast_HARDCODED_SECRET_DISABLED 482.494 µs [461.259 µs, 503.73 µs] 115.319 µs (31.4%)
iast_INACTIVE 443.403 µs [422.456 µs, 464.349 µs] 76.228 µs (20.8%)
iast_TELEMETRY_OFF 468.867 µs [447.855 µs, 489.878 µs] 101.692 µs (27.7%)
tracing 439.382 µs [419.027 µs, 459.737 µs] 72.207 µs (19.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/grizzly-client
git_commit_date 1729072260 1729074149
git_commit_sha e08f541 b166332
release_version 1.41.0-SNAPSHOT~e08f541bb5 1.41.0-SNAPSHOT~b166332a6e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1729076134 1729076134
ci_job_id 673722016 673722016
ci_pipeline_id 46700004 46700004
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~b166332a6e, baseline=1.41.0-SNAPSHOT~e08f541bb5
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.074 s) : 15074000, 15074000
.   : milestone, 15074000,
appsec (15.345 s) : 15345000, 15345000
.   : milestone, 15345000,
iast (18.95 s) : 18950000, 18950000
.   : milestone, 18950000,
iast_GLOBAL (18.1 s) : 18100000, 18100000
.   : milestone, 18100000,
profiling (15.412 s) : 15412000, 15412000
.   : milestone, 15412000,
tracing (15.414 s) : 15414000, 15414000
.   : milestone, 15414000,
section candidate
no_agent (15.061 s) : 15061000, 15061000
.   : milestone, 15061000,
appsec (15.126 s) : 15126000, 15126000
.   : milestone, 15126000,
iast (18.698 s) : 18698000, 18698000
.   : milestone, 18698000,
iast_GLOBAL (18.011 s) : 18011000, 18011000
.   : milestone, 18011000,
profiling (15.433 s) : 15433000, 15433000
.   : milestone, 15433000,
tracing (15.09 s) : 15090000, 15090000
.   : milestone, 15090000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.074 s [15.074 s, 15.074 s] -
appsec 15.345 s [15.345 s, 15.345 s] 271.0 ms (1.8%)
iast 18.95 s [18.95 s, 18.95 s] 3.876 s (25.7%)
iast_GLOBAL 18.1 s [18.1 s, 18.1 s] 3.026 s (20.1%)
profiling 15.412 s [15.412 s, 15.412 s] 338.0 ms (2.2%)
tracing 15.414 s [15.414 s, 15.414 s] 340.0 ms (2.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.061 s [15.061 s, 15.061 s] -
appsec 15.126 s [15.126 s, 15.126 s] 65.0 ms (0.4%)
iast 18.698 s [18.698 s, 18.698 s] 3.637 s (24.1%)
iast_GLOBAL 18.011 s [18.011 s, 18.011 s] 2.95 s (19.6%)
profiling 15.433 s [15.433 s, 15.433 s] 372.0 ms (2.5%)
tracing 15.09 s [15.09 s, 15.09 s] 29.0 ms (0.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~b166332a6e, baseline=1.41.0-SNAPSHOT~e08f541bb5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.329 ms) : 2288, 2370
.   : milestone, 2329,
iast (2.09 ms) : 2038, 2143
.   : milestone, 2090,
iast_GLOBAL (2.117 ms) : 2065, 2169
.   : milestone, 2117,
profiling (1.945 ms) : 1904, 1986
.   : milestone, 1945,
tracing (1.927 ms) : 1887, 1967
.   : milestone, 1927,
section candidate
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.326 ms) : 2286, 2367
.   : milestone, 2326,
iast (2.076 ms) : 2024, 2128
.   : milestone, 2076,
iast_GLOBAL (2.125 ms) : 2073, 2177
.   : milestone, 2125,
profiling (1.936 ms) : 1895, 1978
.   : milestone, 1936,
tracing (1.916 ms) : 1877, 1955
.   : milestone, 1916,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 2.329 ms [2.288 ms, 2.37 ms] 860.359 µs (58.6%)
iast 2.09 ms [2.038 ms, 2.143 ms] 621.773 µs (42.3%)
iast_GLOBAL 2.117 ms [2.065 ms, 2.169 ms] 648.737 µs (44.2%)
profiling 1.945 ms [1.904 ms, 1.986 ms] 476.543 µs (32.4%)
tracing 1.927 ms [1.887 ms, 1.967 ms] 458.264 µs (31.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.461 ms, 1.484 ms] -
appsec 2.326 ms [2.286 ms, 2.367 ms] 854.185 µs (58.0%)
iast 2.076 ms [2.024 ms, 2.128 ms] 604.065 µs (41.0%)
iast_GLOBAL 2.125 ms [2.073 ms, 2.177 ms] 652.727 µs (44.3%)
profiling 1.936 ms [1.895 ms, 1.978 ms] 464.23 µs (31.5%)
tracing 1.916 ms [1.877 ms, 1.955 ms] 443.75 µs (30.1%)

@amarziali amarziali force-pushed the andrea.marziali/grizzly-client branch from b166332 to b8a0eae Compare October 16, 2024 12:53
@amarziali amarziali merged commit a49a0a1 into master Oct 16, 2024
99 of 101 checks passed
@amarziali amarziali deleted the andrea.marziali/grizzly-client branch October 16, 2024 13:30
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardstartin richardstartin richardstartin approved these changes

Assignees
No one assigned
Labels
inst: others All other instrumentations type: bug
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amarziali @richardstartin