-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🍒 7742] Append comment on MySQL JDB callables #7771
Merged
manuel-alvarez-alvarez
merged 1 commit into
release/v1.40.x
from
malvarez/backport-pr-7742
Oct 16, 2024
Merged
[🍒 7742] Append comment on MySQL JDB callables #7771
manuel-alvarez-alvarez
merged 1 commit into
release/v1.40.x
from
malvarez/backport-pr-7742
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Append comment on MySQL JDB callables (cherry picked from commit b69d348)
amarziali
approved these changes
Oct 16, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~732acf8206, baseline=1.41.0-SNAPSHOT~e08f541bb5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1073102
Total [baseline] (8.583 s) : 0, 8582938
Agent [candidate] (1.067 s) : 0, 1067000
Total [candidate] (8.562 s) : 0, 8561824
section iast
Agent [baseline] (1.207 s) : 0, 1207169
Total [baseline] (9.091 s) : 0, 9091213
Agent [candidate] (1.203 s) : 0, 1202707
Total [candidate] (9.097 s) : 0, 9097463
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.198 s) : 0, 1197931
Total [baseline] (9.091 s) : 0, 9090677
Agent [candidate] (1.197 s) : 0, 1196513
Total [candidate] (9.064 s) : 0, 9063500
section iast_TELEMETRY_OFF
Agent [baseline] (1.194 s) : 0, 1193769
Total [baseline] (9.109 s) : 0, 9109285
Agent [candidate] (1.193 s) : 0, 1193322
Total [candidate] (9.084 s) : 0, 9084367
gantt
title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~732acf8206, baseline=1.41.0-SNAPSHOT~e08f541bb5
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.483 ms) : 0, 682483
BytebuddyAgent [candidate] (680.702 ms) : 0, 680702
GlobalTracer [baseline] (314.829 ms) : 0, 314829
GlobalTracer [candidate] (310.51 ms) : 0, 310510
AppSec [baseline] (53.939 ms) : 0, 53939
AppSec [candidate] (53.813 ms) : 0, 53813
Remote Config [baseline] (669.727 µs) : 0, 670
Remote Config [candidate] (657.432 µs) : 0, 657
Telemetry [baseline] (7.509 ms) : 0, 7509
Telemetry [candidate] (7.677 ms) : 0, 7677
section iast
BytebuddyAgent [baseline] (803.082 ms) : 0, 803082
BytebuddyAgent [candidate] (801.554 ms) : 0, 801554
GlobalTracer [baseline] (303.542 ms) : 0, 303542
GlobalTracer [candidate] (301.934 ms) : 0, 301934
AppSec [baseline] (57.44 ms) : 0, 57440
AppSec [candidate] (53.956 ms) : 0, 53956
IAST [baseline] (21.463 ms) : 0, 21463
IAST [candidate] (23.73 ms) : 0, 23730
Remote Config [baseline] (617.789 µs) : 0, 618
Remote Config [candidate] (625.319 µs) : 0, 625
Telemetry [baseline] (7.208 ms) : 0, 7208
Telemetry [candidate] (7.068 ms) : 0, 7068
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (796.427 ms) : 0, 796427
BytebuddyAgent [candidate] (796.397 ms) : 0, 796397
GlobalTracer [baseline] (302.08 ms) : 0, 302080
GlobalTracer [candidate] (300.601 ms) : 0, 300601
AppSec [baseline] (56.874 ms) : 0, 56874
AppSec [candidate] (55.324 ms) : 0, 55324
IAST [baseline] (21.191 ms) : 0, 21191
IAST [candidate] (22.731 ms) : 0, 22731
Remote Config [baseline] (602.158 µs) : 0, 602
Remote Config [candidate] (626.506 µs) : 0, 627
Telemetry [baseline] (7.075 ms) : 0, 7075
Telemetry [candidate] (7.058 ms) : 0, 7058
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (793.206 ms) : 0, 793206
BytebuddyAgent [candidate] (793.385 ms) : 0, 793385
GlobalTracer [baseline] (301.74 ms) : 0, 301740
GlobalTracer [candidate] (300.925 ms) : 0, 300925
AppSec [baseline] (54.69 ms) : 0, 54690
AppSec [candidate] (56.222 ms) : 0, 56222
IAST [baseline] (22.919 ms) : 0, 22919
IAST [candidate] (21.477 ms) : 0, 21477
Remote Config [baseline] (592.275 µs) : 0, 592
Remote Config [candidate] (641.242 µs) : 0, 641
Telemetry [baseline] (6.947 ms) : 0, 6947
Telemetry [candidate] (6.946 ms) : 0, 6946
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~732acf8206, baseline=1.41.0-SNAPSHOT~e08f541bb5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1074020
Total [baseline] (10.457 s) : 0, 10456873
Agent [candidate] (1.068 s) : 0, 1068055
Total [candidate] (10.372 s) : 0, 10372432
section appsec
Agent [baseline] (1.206 s) : 0, 1206496
Total [baseline] (10.623 s) : 0, 10622822
Agent [candidate] (1.201 s) : 0, 1200931
Total [candidate] (10.618 s) : 0, 10617880
section iast
Agent [baseline] (1.199 s) : 0, 1199252
Total [baseline] (10.844 s) : 0, 10844448
Agent [candidate] (1.203 s) : 0, 1202923
Total [candidate] (10.837 s) : 0, 10836987
section profiling
Agent [baseline] (1.268 s) : 0, 1267870
Total [baseline] (10.653 s) : 0, 10653379
Agent [candidate] (1.271 s) : 0, 1270649
Total [candidate] (10.591 s) : 0, 10590529
gantt
title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~732acf8206, baseline=1.41.0-SNAPSHOT~e08f541bb5
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.196 ms) : 0, 683196
BytebuddyAgent [candidate] (681.111 ms) : 0, 681111
GlobalTracer [baseline] (314.852 ms) : 0, 314852
GlobalTracer [candidate] (311.062 ms) : 0, 311062
AppSec [baseline] (54.117 ms) : 0, 54117
AppSec [candidate] (53.947 ms) : 0, 53947
Remote Config [baseline] (663.453 µs) : 0, 663
Remote Config [candidate] (666.339 µs) : 0, 666
Telemetry [baseline] (7.542 ms) : 0, 7542
Telemetry [candidate] (7.615 ms) : 0, 7615
section appsec
BytebuddyAgent [baseline] (700.217 ms) : 0, 700217
BytebuddyAgent [candidate] (697.791 ms) : 0, 697791
GlobalTracer [baseline] (310.301 ms) : 0, 310301
GlobalTracer [candidate] (307.394 ms) : 0, 307394
AppSec [baseline] (162.72 ms) : 0, 162720
AppSec [candidate] (161.945 ms) : 0, 161945
IAST [baseline] (21.673 ms) : 0, 21673
IAST [candidate] (19.254 ms) : 0, 19254
Remote Config [baseline] (636.866 µs) : 0, 637
Remote Config [candidate] (638.729 µs) : 0, 639
Telemetry [baseline] (8.097 ms) : 0, 8097
Telemetry [candidate] (9.877 ms) : 0, 9877
section iast
BytebuddyAgent [baseline] (798.217 ms) : 0, 798217
BytebuddyAgent [candidate] (801.31 ms) : 0, 801310
GlobalTracer [baseline] (301.627 ms) : 0, 301627
GlobalTracer [candidate] (301.785 ms) : 0, 301785
AppSec [baseline] (56.866 ms) : 0, 56866
AppSec [candidate] (55.357 ms) : 0, 55357
IAST [baseline] (21.192 ms) : 0, 21192
IAST [candidate] (23.003 ms) : 0, 23003
Remote Config [baseline] (601.832 µs) : 0, 602
Remote Config [candidate] (618.184 µs) : 0, 618
Telemetry [baseline] (7.12 ms) : 0, 7120
Telemetry [candidate] (7.08 ms) : 0, 7080
section profiling
BytebuddyAgent [baseline] (675.595 ms) : 0, 675595
BytebuddyAgent [candidate] (679.193 ms) : 0, 679193
GlobalTracer [baseline] (395.6 ms) : 0, 395600
GlobalTracer [candidate] (393.49 ms) : 0, 393490
AppSec [baseline] (54.362 ms) : 0, 54362
AppSec [candidate] (54.497 ms) : 0, 54497
Remote Config [baseline] (659.033 µs) : 0, 659
Remote Config [candidate] (645.477 µs) : 0, 645
Telemetry [baseline] (7.46 ms) : 0, 7460
Telemetry [candidate] (7.427 ms) : 0, 7427
ProfilingAgent [baseline] (95.566 ms) : 0, 95566
ProfilingAgent [candidate] (96.476 ms) : 0, 96476
Profiling [baseline] (95.59 ms) : 0, 95590
Profiling [candidate] (96.5 ms) : 0, 96500
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~732acf8206, baseline=1.41.0-SNAPSHOT~e08f541bb5
dateFormat X
axisFormat %s
section baseline
no_agent (373.978 µs) : 354, 394
. : milestone, 374,
iast (496.84 µs) : 475, 519
. : milestone, 497,
iast_FULL (568.3 µs) : 547, 590
. : milestone, 568,
iast_GLOBAL (512.141 µs) : 491, 533
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (495.34 µs) : 474, 517
. : milestone, 495,
iast_INACTIVE (457.656 µs) : 436, 479
. : milestone, 458,
iast_TELEMETRY_OFF (476.938 µs) : 455, 499
. : milestone, 477,
tracing (450.451 µs) : 429, 472
. : milestone, 450,
section candidate
no_agent (367.556 µs) : 347, 388
. : milestone, 368,
iast (489.171 µs) : 468, 510
. : milestone, 489,
iast_FULL (561.711 µs) : 540, 583
. : milestone, 562,
iast_GLOBAL (511.973 µs) : 491, 533
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (498.166 µs) : 477, 520
. : milestone, 498,
iast_INACTIVE (450.219 µs) : 429, 471
. : milestone, 450,
iast_TELEMETRY_OFF (480.979 µs) : 460, 502
. : milestone, 481,
tracing (446.454 µs) : 426, 467
. : milestone, 446,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~732acf8206, baseline=1.41.0-SNAPSHOT~e08f541bb5
dateFormat X
axisFormat %s
section baseline
no_agent (1.341 ms) : 1322, 1360
. : milestone, 1341,
appsec (1.714 ms) : 1690, 1738
. : milestone, 1714,
appsec_no_iast (1.732 ms) : 1708, 1755
. : milestone, 1732,
iast (1.476 ms) : 1453, 1500
. : milestone, 1476,
profiling (1.482 ms) : 1459, 1505
. : milestone, 1482,
tracing (1.485 ms) : 1461, 1509
. : milestone, 1485,
section candidate
no_agent (1.357 ms) : 1337, 1376
. : milestone, 1357,
appsec (1.72 ms) : 1696, 1744
. : milestone, 1720,
appsec_no_iast (1.728 ms) : 1704, 1752
. : milestone, 1728,
iast (1.49 ms) : 1469, 1512
. : milestone, 1490,
profiling (1.484 ms) : 1459, 1509
. : milestone, 1484,
tracing (1.488 ms) : 1464, 1512
. : milestone, 1488,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~732acf8206, baseline=1.41.0-SNAPSHOT~e08f541bb5
dateFormat X
axisFormat %s
section baseline
no_agent (15.082 s) : 15082000, 15082000
. : milestone, 15082000,
appsec (15.236 s) : 15236000, 15236000
. : milestone, 15236000,
iast (18.547 s) : 18547000, 18547000
. : milestone, 18547000,
iast_GLOBAL (18.118 s) : 18118000, 18118000
. : milestone, 18118000,
profiling (15.599 s) : 15599000, 15599000
. : milestone, 15599000,
tracing (15.366 s) : 15366000, 15366000
. : milestone, 15366000,
section candidate
no_agent (15.654 s) : 15654000, 15654000
. : milestone, 15654000,
appsec (15.335 s) : 15335000, 15335000
. : milestone, 15335000,
iast (18.749 s) : 18749000, 18749000
. : milestone, 18749000,
iast_GLOBAL (17.898 s) : 17898000, 17898000
. : milestone, 17898000,
profiling (15.408 s) : 15408000, 15408000
. : milestone, 15408000,
tracing (15.283 s) : 15283000, 15283000
. : milestone, 15283000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~732acf8206, baseline=1.41.0-SNAPSHOT~e08f541bb5
dateFormat X
axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1471
. : milestone, 1460,
appsec (2.328 ms) : 2287, 2369
. : milestone, 2328,
iast (2.073 ms) : 2021, 2126
. : milestone, 2073,
iast_GLOBAL (2.122 ms) : 2067, 2176
. : milestone, 2122,
profiling (1.943 ms) : 1900, 1986
. : milestone, 1943,
tracing (1.911 ms) : 1871, 1950
. : milestone, 1911,
section candidate
no_agent (1.461 ms) : 1450, 1472
. : milestone, 1461,
appsec (2.306 ms) : 2265, 2347
. : milestone, 2306,
iast (2.066 ms) : 2014, 2119
. : milestone, 2066,
iast_GLOBAL (2.095 ms) : 2044, 2147
. : milestone, 2095,
profiling (1.93 ms) : 1888, 1973
. : milestone, 1930,
tracing (1.908 ms) : 1869, 1947
. : milestone, 1908,
|
manuel-alvarez-alvarez
merged commit Oct 16, 2024
f3516e0
into
release/v1.40.x
92 of 98 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #7742 to release/v1.40.x