Update Gradle dependencies and support micronaut 4.7.0 #7759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
tag: no release notes
github-actions
bot
requested review from
cimi,
juan-fernandez and
manuel-alvarez-alvarez
and removed request for
a team
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (299.196 µs) : 265, 334
. : milestone, 299,
basic (294.71 µs) : 284, 305
. : milestone, 295,
loop (10.379 ms) : 10345, 10413
. : milestone, 10379,
section candidate
noprobe (297.807 µs) : 278, 318
. : milestone, 298,
basic (304.107 µs) : 295, 314
. : milestone, 304,
loop (10.353 ms) : 10322, 10384
. : milestone, 10353,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~36e920ddfc, baseline=1.41.0-SNAPSHOT~e10da91b8c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1072374
Total [baseline] (10.428 s) : 0, 10428324
Agent [candidate] (1.072 s) : 0, 1071574
Total [candidate] (10.409 s) : 0, 10409296
section appsec
Agent [baseline] (1.207 s) : 0, 1207375
Total [baseline] (10.629 s) : 0, 10629425
Agent [candidate] (1.203 s) : 0, 1202684
Total [candidate] (10.599 s) : 0, 10599437
section iast
Agent [baseline] (1.203 s) : 0, 1203098
Total [baseline] (10.864 s) : 0, 10863841
Agent [candidate] (1.218 s) : 0, 1218355
Total [candidate] (10.954 s) : 0, 10953939
section profiling
Agent [baseline] (1.273 s) : 0, 1273117
Total [baseline] (10.615 s) : 0, 10615428
Agent [candidate] (1.271 s) : 0, 1271155
Total [candidate] (10.586 s) : 0, 10586233
gantt
title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~36e920ddfc, baseline=1.41.0-SNAPSHOT~e10da91b8c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.833 ms) : 0, 684833
BytebuddyAgent [candidate] (683.585 ms) : 0, 683585
GlobalTracer [baseline] (311.662 ms) : 0, 311662
GlobalTracer [candidate] (311.835 ms) : 0, 311835
AppSec [baseline] (53.934 ms) : 0, 53934
AppSec [candidate] (53.983 ms) : 0, 53983
Remote Config [baseline] (662.162 µs) : 0, 662
Remote Config [candidate] (669.987 µs) : 0, 670
Telemetry [baseline] (7.514 ms) : 0, 7514
Telemetry [candidate] (7.711 ms) : 0, 7711
section appsec
BytebuddyAgent [baseline] (702.135 ms) : 0, 702135
BytebuddyAgent [candidate] (699.351 ms) : 0, 699351
GlobalTracer [baseline] (308.9 ms) : 0, 308900
GlobalTracer [candidate] (307.79 ms) : 0, 307790
AppSec [baseline] (162.79 ms) : 0, 162790
AppSec [candidate] (160.974 ms) : 0, 160974
IAST [baseline] (21.122 ms) : 0, 21122
IAST [candidate] (21.782 ms) : 0, 21782
Remote Config [baseline] (643.532 µs) : 0, 644
Remote Config [candidate] (640.374 µs) : 0, 640
Telemetry [baseline] (8.571 ms) : 0, 8571
Telemetry [candidate] (9.295 ms) : 0, 9295
section iast
BytebuddyAgent [baseline] (801.877 ms) : 0, 801877
BytebuddyAgent [candidate] (811.835 ms) : 0, 811835
GlobalTracer [baseline] (300.847 ms) : 0, 300847
GlobalTracer [candidate] (304.845 ms) : 0, 304845
AppSec [baseline] (55.808 ms) : 0, 55808
AppSec [candidate] (54.986 ms) : 0, 54986
IAST [baseline] (23.035 ms) : 0, 23035
IAST [candidate] (24.871 ms) : 0, 24871
Remote Config [baseline] (612.331 µs) : 0, 612
Remote Config [candidate] (619.733 µs) : 0, 620
Telemetry [baseline] (7.14 ms) : 0, 7140
Telemetry [candidate] (7.196 ms) : 0, 7196
section profiling
BytebuddyAgent [baseline] (678.825 ms) : 0, 678825
BytebuddyAgent [candidate] (677.977 ms) : 0, 677977
GlobalTracer [baseline] (395.316 ms) : 0, 395316
GlobalTracer [candidate] (394.162 ms) : 0, 394162
AppSec [baseline] (54.935 ms) : 0, 54935
AppSec [candidate] (54.838 ms) : 0, 54838
Remote Config [baseline] (653.832 µs) : 0, 654
Remote Config [candidate] (661.626 µs) : 0, 662
Telemetry [baseline] (7.481 ms) : 0, 7481
Telemetry [candidate] (7.533 ms) : 0, 7533
ProfilingAgent [baseline] (97.021 ms) : 0, 97021
ProfilingAgent [candidate] (97.008 ms) : 0, 97008
Profiling [baseline] (97.044 ms) : 0, 97044
Profiling [candidate] (97.032 ms) : 0, 97032
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~36e920ddfc, baseline=1.41.0-SNAPSHOT~e10da91b8c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1074544
Total [baseline] (8.607 s) : 0, 8607157
Agent [candidate] (1.071 s) : 0, 1071453
Total [candidate] (8.561 s) : 0, 8561151
section iast
Agent [baseline] (1.207 s) : 0, 1206557
Total [baseline] (9.11 s) : 0, 9110368
Agent [candidate] (1.197 s) : 0, 1197353
Total [candidate] (9.088 s) : 0, 9088459
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.201 s) : 0, 1200560
Total [baseline] (9.077 s) : 0, 9076889
Agent [candidate] (1.202 s) : 0, 1201875
Total [candidate] (9.074 s) : 0, 9074261
section iast_TELEMETRY_OFF
Agent [baseline] (1.196 s) : 0, 1195679
Total [baseline] (9.076 s) : 0, 9076247
Agent [candidate] (1.196 s) : 0, 1195764
Total [candidate] (9.099 s) : 0, 9098951
gantt
title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~36e920ddfc, baseline=1.41.0-SNAPSHOT~e10da91b8c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.622 ms) : 0, 686622
BytebuddyAgent [candidate] (683.966 ms) : 0, 683966
GlobalTracer [baseline] (311.711 ms) : 0, 311711
GlobalTracer [candidate] (311.301 ms) : 0, 311301
AppSec [baseline] (54.12 ms) : 0, 54120
AppSec [candidate] (54.076 ms) : 0, 54076
Remote Config [baseline] (672.461 µs) : 0, 672
Remote Config [candidate] (662.707 µs) : 0, 663
Telemetry [baseline] (7.578 ms) : 0, 7578
Telemetry [candidate] (7.651 ms) : 0, 7651
section iast
BytebuddyAgent [baseline] (806.014 ms) : 0, 806014
BytebuddyAgent [candidate] (797.71 ms) : 0, 797710
GlobalTracer [baseline] (300.276 ms) : 0, 300276
GlobalTracer [candidate] (299.638 ms) : 0, 299638
AppSec [baseline] (55.753 ms) : 0, 55753
AppSec [candidate] (54.017 ms) : 0, 54017
IAST [baseline] (22.869 ms) : 0, 22869
IAST [candidate] (24.544 ms) : 0, 24544
Remote Config [baseline] (609.652 µs) : 0, 610
Remote Config [candidate] (605.235 µs) : 0, 605
Telemetry [baseline] (7.14 ms) : 0, 7140
Telemetry [candidate] (7.049 ms) : 0, 7049
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (799.603 ms) : 0, 799603
BytebuddyAgent [candidate] (800.028 ms) : 0, 800028
GlobalTracer [baseline] (300.427 ms) : 0, 300427
GlobalTracer [candidate] (301.104 ms) : 0, 301104
AppSec [baseline] (53.56 ms) : 0, 53560
AppSec [candidate] (53.695 ms) : 0, 53695
IAST [baseline] (25.404 ms) : 0, 25404
IAST [candidate] (25.482 ms) : 0, 25482
Remote Config [baseline] (609.085 µs) : 0, 609
Remote Config [candidate] (602.433 µs) : 0, 602
Telemetry [baseline] (7.088 ms) : 0, 7088
Telemetry [candidate] (7.066 ms) : 0, 7066
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.059 ms) : 0, 796059
BytebuddyAgent [candidate] (795.686 ms) : 0, 795686
GlobalTracer [baseline] (300.044 ms) : 0, 300044
GlobalTracer [candidate] (300.239 ms) : 0, 300239
AppSec [baseline] (54.087 ms) : 0, 54087
AppSec [candidate] (55.882 ms) : 0, 55882
IAST [baseline] (24.158 ms) : 0, 24158
IAST [candidate] (22.527 ms) : 0, 22527
Remote Config [baseline] (618.595 µs) : 0, 619
Remote Config [candidate] (607.111 µs) : 0, 607
Telemetry [baseline] (6.901 ms) : 0, 6901
Telemetry [candidate] (7.001 ms) : 0, 7001
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~36e920ddfc, baseline=1.41.0-SNAPSHOT~e10da91b8c
dateFormat X
axisFormat %s
section baseline
no_agent (366.096 µs) : 347, 385
. : milestone, 366,
iast (482.034 µs) : 460, 504
. : milestone, 482,
iast_FULL (554.22 µs) : 533, 576
. : milestone, 554,
iast_GLOBAL (506.249 µs) : 485, 528
. : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (479.158 µs) : 458, 500
. : milestone, 479,
iast_INACTIVE (440.955 µs) : 420, 462
. : milestone, 441,
iast_TELEMETRY_OFF (469.632 µs) : 449, 491
. : milestone, 470,
tracing (438.848 µs) : 418, 459
. : milestone, 439,
section candidate
no_agent (371.433 µs) : 351, 392
. : milestone, 371,
iast (476.0 µs) : 455, 497
. : milestone, 476,
iast_FULL (548.619 µs) : 527, 570
. : milestone, 549,
iast_GLOBAL (502.747 µs) : 482, 524
. : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (484.139 µs) : 463, 505
. : milestone, 484,
iast_INACTIVE (448.181 µs) : 427, 469
. : milestone, 448,
iast_TELEMETRY_OFF (471.882 µs) : 451, 493
. : milestone, 472,
tracing (444.767 µs) : 423, 466
. : milestone, 445,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~36e920ddfc, baseline=1.41.0-SNAPSHOT~e10da91b8c
dateFormat X
axisFormat %s
section baseline
no_agent (1.34 ms) : 1320, 1359
. : milestone, 1340,
appsec (1.738 ms) : 1714, 1761
. : milestone, 1738,
appsec_no_iast (1.722 ms) : 1698, 1747
. : milestone, 1722,
iast (1.465 ms) : 1443, 1488
. : milestone, 1465,
profiling (1.531 ms) : 1506, 1556
. : milestone, 1531,
tracing (1.481 ms) : 1453, 1508
. : milestone, 1481,
section candidate
no_agent (1.341 ms) : 1322, 1361
. : milestone, 1341,
appsec (1.709 ms) : 1684, 1733
. : milestone, 1709,
appsec_no_iast (1.7 ms) : 1675, 1724
. : milestone, 1700,
iast (1.464 ms) : 1442, 1487
. : milestone, 1464,
profiling (1.473 ms) : 1449, 1497
. : milestone, 1473,
tracing (1.478 ms) : 1454, 1502
. : milestone, 1478,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~36e920ddfc, baseline=1.41.0-SNAPSHOT~e10da91b8c
dateFormat X
axisFormat %s
section baseline
no_agent (14.897 s) : 14897000, 14897000
. : milestone, 14897000,
appsec (15.394 s) : 15394000, 15394000
. : milestone, 15394000,
iast (18.822 s) : 18822000, 18822000
. : milestone, 18822000,
iast_GLOBAL (17.872 s) : 17872000, 17872000
. : milestone, 17872000,
profiling (15.497 s) : 15497000, 15497000
. : milestone, 15497000,
tracing (15.52 s) : 15520000, 15520000
. : milestone, 15520000,
section candidate
no_agent (15.019 s) : 15019000, 15019000
. : milestone, 15019000,
appsec (14.913 s) : 14913000, 14913000
. : milestone, 14913000,
iast (18.782 s) : 18782000, 18782000
. : milestone, 18782000,
iast_GLOBAL (18.218 s) : 18218000, 18218000
. : milestone, 18218000,
profiling (15.776 s) : 15776000, 15776000
. : milestone, 15776000,
tracing (15.246 s) : 15246000, 15246000
. : milestone, 15246000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~36e920ddfc, baseline=1.41.0-SNAPSHOT~e10da91b8c
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.33 ms) : 2289, 2371
. : milestone, 2330,
iast (2.058 ms) : 2007, 2109
. : milestone, 2058,
iast_GLOBAL (2.119 ms) : 2067, 2172
. : milestone, 2119,
profiling (1.946 ms) : 1903, 1988
. : milestone, 1946,
tracing (1.917 ms) : 1878, 1957
. : milestone, 1917,
section candidate
no_agent (1.462 ms) : 1451, 1474
. : milestone, 1462,
appsec (2.321 ms) : 2280, 2361
. : milestone, 2321,
iast (2.073 ms) : 2022, 2124
. : milestone, 2073,
iast_GLOBAL (2.12 ms) : 2068, 2173
. : milestone, 2120,
profiling (1.948 ms) : 1906, 1991
. : milestone, 1948,
tracing (1.905 ms) : 1866, 1944
. : milestone, 1905,
|
smola
reviewed
Oct 14, 2024
| @@ -64,6 +64,12 @@ public void methodAdvice(MethodTransformer transformer) { | |||
| "io.micronaut.http.MutableHttpResponse", | |||
| "io.micronaut.http.HttpResponse"))), | |||
| packageName + ".EncodeHttpResponseAdvice"); | |||
| transformer.applyAdvice( | |||
There was a problem hiding this comment.
@amarziali I'd suggest getting this to a standalone PR that will show up in release notes.
There was a problem hiding this comment.
hmm, interesting take. So far, we've always fixed issues like this directly in the "update dependencies" PR, but it's true that it doesn't show up in the release notes. In case customers have trouble with a particular integration version, they can't know when support was added.
However, it's more convenient, because if we want to have the CI safety harness, we need to cherry-pick the update to a separate PR, and I don't know if there is a way to not do it manually.
Maybe we can just edit the PR title to something like "Update Gradle dependencies, add support for libXXX vX.Y.Z" ?
amarziali
changed the title
amarziali
added
inst: micronaut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Gradle dependencies.⚠️ Don't forget to squash commits before merging. ⚠️