Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hoisting local vars for Kotlin code #7758

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix hoisting local vars for Kotlin code #7758

merged 1 commit into from
Oct 11, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Oct 11, 2024 •
edited by jira bot
Loading

What Does This Do

javac begins the range of a local var in the LocalVariableTable just after the store instruction at the init.
kotlinc is more free to introduce nop/other instructions in-between. need to scan backward from the start of the range to find the last store of this slot to begin the rewrite of the slot needed to hoist correctly local vars.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2974

@jpbempel
Fix hoisting local vars for Kotlin code
96c6f53 
javac begins the range of a local var in the LocalVariableTable just
after the store instruction at the init.
kotlinc is more free to instroduce nop/other instructions in-between.
need to scan backward from the start of the range to find the last
store of this slot to begin the rewrite of the slot needed to hoist
correctly local vars.
@jpbempel jpbempel added type: bug comp: debugger Dynamic Instrumentation labels Oct 11, 2024
@jpbempel jpbempel requested a review from a team as a code owner October 11, 2024 14:44
@jpbempel jpbempel requested review from evanchooly and removed request for a team October 11, 2024 14:44
@pr-commenter
Copy link

pr-commenter bot commented Oct 11, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1728658040 1728658429
end_time 2024-10-11T14:48:35 2024-10-11T14:55:05
git_branch master jpbempel/fix-kotlin-nop
git_commit_sha eadf0cc 96c6f53
start_time 2024-10-11T14:47:21 2024-10-11T14:53:50
See matching parameters
Baseline Candidate
ci_job_id 669937845 669937845
ci_pipeline_id 46395391 46395391
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1728657148 1728657148

Summary

Found 5 performance improvements and 3 performance regressions! Performance is the same for 1 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:basic worse
[+37.093µs; +51.509µs] or [+13.653%; +18.959%]		 worse
[+37.575µs; +53.803µs] or [+12.523%; +17.931%]		 worse
[+36.970µs; +55.551µs] or [+11.878%; +17.848%]		 unstable
[-8.910µs; +83.614µs] or [-1.630%; +15.294%]		 unstable
[-388.864op/s; -88.178op/s] or [-15.166%; -3.439%]
scenario:loop better
[-686.316µs; -660.209µs] or [-6.336%; -6.095%]		 better
[-732.145µs; -653.129µs] or [-6.645%; -5.927%]		 better
[-732.064µs; -614.927µs] or [-6.601%; -5.545%]		 better
[-900.349µs; -527.786µs] or [-7.858%; -4.607%]		 better
[+4.929op/s; +7.086op/s] or [+5.496%; +7.901%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-20.744µs; +30.960µs] or [-7.898%; +11.788%]		 unstable
[-32.659µs; +44.162µs] or [-10.815%; +14.624%]		 unstable
[-43.671µs; +57.197µs] or [-13.810%; +18.087%]		 unstable
[-100.942µs; +97.364µs] or [-16.841%; +16.244%]		 same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (301.993 µs) : 268, 336
.   : milestone, 302,
basic (300.056 µs) : 292, 309
.   : milestone, 300,
loop (11.019 ms) : 10984, 11054
.   : milestone, 11019,
section candidate
noprobe (307.745 µs) : 269, 347
.   : milestone, 308,
basic (345.745 µs) : 338, 353
.   : milestone, 346,
loop (10.326 ms) : 10288, 10364
.   : milestone, 10326,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 301.993 µs [267.924 µs, 336.062 µs]
basic 300.056 µs [291.521 µs, 308.592 µs]
loop 11.019 ms [10.984 ms, 11.054 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 307.745 µs [268.719 µs, 346.77 µs]
basic 345.745 µs [338.491 µs, 353.0 µs]
loop 10.326 ms [10.288 ms, 10.364 ms]

@pr-commenter
Copy link

pr-commenter bot commented Oct 11, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-kotlin-nop
git_commit_date 1728654019 1728657148
git_commit_sha eadf0cc 96c6f53
release_version 1.41.0-SNAPSHOT~eadf0cc0d6 1.41.0-SNAPSHOT~96c6f534f8
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728659760 1728659760
ci_job_id 669937831 669937831
ci_pipeline_id 46395391 46395391
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~96c6f534f8, baseline=1.41.0-SNAPSHOT~eadf0cc0d6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066826
Total [baseline] (8.556 s) : 0, 8555939
Agent [candidate] (1.066 s) : 0, 1066075
Total [candidate] (8.561 s) : 0, 8560673
section iast
Agent [baseline] (1.2 s) : 0, 1199729
Total [baseline] (9.076 s) : 0, 9076314
Agent [candidate] (1.194 s) : 0, 1194380
Total [candidate] (9.079 s) : 0, 9079076
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.198 s) : 0, 1197856
Total [baseline] (9.123 s) : 0, 9123469
Agent [candidate] (1.205 s) : 0, 1204935
Total [candidate] (9.09 s) : 0, 9090352
section iast_TELEMETRY_OFF
Agent [baseline] (1.192 s) : 0, 1191883
Total [baseline] (9.077 s) : 0, 9076867
Agent [candidate] (1.191 s) : 0, 1190516
Total [candidate] (9.048 s) : 0, 9047513
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent iast 1.2 s 132.903 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.198 s 131.029 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.192 s 125.057 ms (11.7%)
Total tracing 8.556 s -
Total iast 9.076 s 520.375 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.123 s 567.529 ms (6.6%)
Total iast_TELEMETRY_OFF 9.077 s 520.928 ms (6.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent iast 1.194 s 128.305 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.205 s 138.86 ms (13.0%)
Agent iast_TELEMETRY_OFF 1.191 s 124.441 ms (11.7%)
Total tracing 8.561 s -
Total iast 9.079 s 518.403 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.09 s 529.679 ms (6.2%)
Total iast_TELEMETRY_OFF 9.048 s 486.84 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~96c6f534f8, baseline=1.41.0-SNAPSHOT~eadf0cc0d6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.631 ms) : 0, 681631
BytebuddyAgent [candidate] (681.0 ms) : 0, 681000
GlobalTracer [baseline] (309.795 ms) : 0, 309795
GlobalTracer [candidate] (309.695 ms) : 0, 309695
AppSec [baseline] (53.479 ms) : 0, 53479
AppSec [candidate] (53.519 ms) : 0, 53519
Remote Config [baseline] (651.259 µs) : 0, 651
Remote Config [candidate] (657.393 µs) : 0, 657
Telemetry [baseline] (7.608 ms) : 0, 7608
Telemetry [candidate] (7.518 ms) : 0, 7518
section iast
BytebuddyAgent [baseline] (801.845 ms) : 0, 801845
BytebuddyAgent [candidate] (796.458 ms) : 0, 796458
GlobalTracer [baseline] (298.5 ms) : 0, 298500
GlobalTracer [candidate] (298.48 ms) : 0, 298480
AppSec [baseline] (54.559 ms) : 0, 54559
AppSec [candidate] (56.844 ms) : 0, 56844
IAST [baseline] (23.484 ms) : 0, 23484
IAST [candidate] (21.214 ms) : 0, 21214
Remote Config [baseline] (608.788 µs) : 0, 609
Remote Config [candidate] (607.275 µs) : 0, 607
Telemetry [baseline] (7.012 ms) : 0, 7012
Telemetry [candidate] (7.074 ms) : 0, 7074
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (797.048 ms) : 0, 797048
BytebuddyAgent [candidate] (803.114 ms) : 0, 803114
GlobalTracer [baseline] (300.643 ms) : 0, 300643
GlobalTracer [candidate] (301.457 ms) : 0, 301457
AppSec [baseline] (54.109 ms) : 0, 54109
AppSec [candidate] (54.957 ms) : 0, 54957
IAST [baseline] (24.648 ms) : 0, 24648
IAST [candidate] (23.842 ms) : 0, 23842
Remote Config [baseline] (606.818 µs) : 0, 607
Remote Config [candidate] (618.893 µs) : 0, 619
Telemetry [baseline] (7.103 ms) : 0, 7103
Telemetry [candidate] (7.129 ms) : 0, 7129
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (793.611 ms) : 0, 793611
BytebuddyAgent [candidate] (792.884 ms) : 0, 792884
GlobalTracer [baseline] (298.959 ms) : 0, 298959
GlobalTracer [candidate] (298.752 ms) : 0, 298752
AppSec [baseline] (56.222 ms) : 0, 56222
AppSec [candidate] (54.436 ms) : 0, 54436
IAST [baseline] (21.774 ms) : 0, 21774
IAST [candidate] (23.172 ms) : 0, 23172
Remote Config [baseline] (618.599 µs) : 0, 619
Remote Config [candidate] (614.958 µs) : 0, 615
Telemetry [baseline] (7.006 ms) : 0, 7006
Telemetry [candidate] (6.959 ms) : 0, 6959
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~96c6f534f8, baseline=1.41.0-SNAPSHOT~eadf0cc0d6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067655
Total [baseline] (10.415 s) : 0, 10415132
Agent [candidate] (1.078 s) : 0, 1077994
Total [candidate] (10.437 s) : 0, 10436772
section appsec
Agent [baseline] (1.208 s) : 0, 1207843
Total [baseline] (10.607 s) : 0, 10606893
Agent [candidate] (1.204 s) : 0, 1203769
Total [candidate] (10.586 s) : 0, 10585705
section iast
Agent [baseline] (1.202 s) : 0, 1202073
Total [baseline] (10.82 s) : 0, 10820070
Agent [candidate] (1.195 s) : 0, 1194625
Total [candidate] (10.836 s) : 0, 10835564
section profiling
Agent [baseline] (1.277 s) : 0, 1276599
Total [baseline] (10.582 s) : 0, 10581588
Agent [candidate] (1.265 s) : 0, 1265205
Total [candidate] (10.604 s) : 0, 10603883
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent appsec 1.208 s 140.187 ms (13.1%)
Agent iast 1.202 s 134.418 ms (12.6%)
Agent profiling 1.277 s 208.943 ms (19.6%)
Total tracing 10.415 s -
Total appsec 10.607 s 191.761 ms (1.8%)
Total iast 10.82 s 404.938 ms (3.9%)
Total profiling 10.582 s 166.456 ms (1.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.204 s 125.775 ms (11.7%)
Agent iast 1.195 s 116.631 ms (10.8%)
Agent profiling 1.265 s 187.211 ms (17.4%)
Total tracing 10.437 s -
Total appsec 10.586 s 148.933 ms (1.4%)
Total iast 10.836 s 398.792 ms (3.8%)
Total profiling 10.604 s 167.111 ms (1.6%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~96c6f534f8, baseline=1.41.0-SNAPSHOT~eadf0cc0d6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.962 ms) : 0, 681962
BytebuddyAgent [candidate] (689.851 ms) : 0, 689851
GlobalTracer [baseline] (309.941 ms) : 0, 309941
GlobalTracer [candidate] (311.968 ms) : 0, 311968
AppSec [baseline] (53.844 ms) : 0, 53844
AppSec [candidate] (54.066 ms) : 0, 54066
Remote Config [baseline] (660.468 µs) : 0, 660
Remote Config [candidate] (661.115 µs) : 0, 661
Telemetry [baseline] (7.603 ms) : 0, 7603
Telemetry [candidate] (7.664 ms) : 0, 7664
section appsec
BytebuddyAgent [baseline] (702.332 ms) : 0, 702332
BytebuddyAgent [candidate] (699.447 ms) : 0, 699447
GlobalTracer [baseline] (308.487 ms) : 0, 308487
GlobalTracer [candidate] (307.43 ms) : 0, 307430
AppSec [baseline] (162.568 ms) : 0, 162568
AppSec [candidate] (162.522 ms) : 0, 162522
IAST [baseline] (21.623 ms) : 0, 21623
IAST [candidate] (20.927 ms) : 0, 20927
Remote Config [baseline] (635.456 µs) : 0, 635
Remote Config [candidate] (643.824 µs) : 0, 644
Telemetry [baseline] (9.307 ms) : 0, 9307
Telemetry [candidate] (9.6 ms) : 0, 9600
section iast
BytebuddyAgent [baseline] (802.072 ms) : 0, 802072
BytebuddyAgent [candidate] (796.492 ms) : 0, 796492
GlobalTracer [baseline] (299.995 ms) : 0, 299995
GlobalTracer [candidate] (298.761 ms) : 0, 298761
AppSec [baseline] (53.958 ms) : 0, 53958
AppSec [candidate] (54.803 ms) : 0, 54803
IAST [baseline] (24.534 ms) : 0, 24534
IAST [candidate] (23.292 ms) : 0, 23292
Remote Config [baseline] (603.675 µs) : 0, 604
Remote Config [candidate] (606.378 µs) : 0, 606
Telemetry [baseline] (7.195 ms) : 0, 7195
Telemetry [candidate] (7.019 ms) : 0, 7019
section profiling
BytebuddyAgent [baseline] (681.645 ms) : 0, 681645
BytebuddyAgent [candidate] (674.848 ms) : 0, 674848
GlobalTracer [baseline] (395.825 ms) : 0, 395825
GlobalTracer [candidate] (392.545 ms) : 0, 392545
AppSec [baseline] (55.15 ms) : 0, 55150
AppSec [candidate] (54.595 ms) : 0, 54595
Remote Config [baseline] (664.597 µs) : 0, 665
Remote Config [candidate] (652.956 µs) : 0, 653
Telemetry [baseline] (7.542 ms) : 0, 7542
Telemetry [candidate] (7.448 ms) : 0, 7448
ProfilingAgent [baseline] (96.713 ms) : 0, 96713
ProfilingAgent [candidate] (96.547 ms) : 0, 96547
Profiling [baseline] (96.737 ms) : 0, 96737
Profiling [candidate] (96.571 ms) : 0, 96571
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-11T14:48:29 2024-10-11T14:55:23
git_branch master jpbempel/fix-kotlin-nop
git_commit_date 1728654019 1728657148
git_commit_sha eadf0cc 96c6f53
release_version 1.41.0-SNAPSHOT~eadf0cc0d6 1.41.0-SNAPSHOT~96c6f534f8
start_time 2024-10-11T14:48:16 2024-10-11T14:55:10
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728658873 1728658873
ci_job_id 669937834 669937834
ci_pipeline_id 46395391 46395391
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 12 metrics, 15 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+60.558µs; +112.258µs] or [+4.055%; +7.516%]		 unstable
[-766.191op/s; +292.117op/s] or [-23.943%; +9.129%]		 1.580ms 2962.963op/s 1.494ms 3200.000op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~96c6f534f8, baseline=1.41.0-SNAPSHOT~eadf0cc0d6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.358 ms) : 1338, 1378
.   : milestone, 1358,
appsec (1.716 ms) : 1693, 1738
.   : milestone, 1716,
appsec_no_iast (1.732 ms) : 1707, 1756
.   : milestone, 1732,
iast (1.502 ms) : 1480, 1524
.   : milestone, 1502,
profiling (1.494 ms) : 1471, 1516
.   : milestone, 1494,
tracing (1.471 ms) : 1446, 1496
.   : milestone, 1471,
section candidate
no_agent (1.354 ms) : 1335, 1374
.   : milestone, 1354,
appsec (1.713 ms) : 1689, 1737
.   : milestone, 1713,
appsec_no_iast (1.726 ms) : 1702, 1750
.   : milestone, 1726,
iast (1.474 ms) : 1451, 1496
.   : milestone, 1474,
profiling (1.58 ms) : 1555, 1605
.   : milestone, 1580,
tracing (1.468 ms) : 1443, 1492
.   : milestone, 1468,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.358 ms [1.338 ms, 1.378 ms] -
appsec 1.716 ms [1.693 ms, 1.738 ms] 358.028 µs (26.4%)
appsec_no_iast 1.732 ms [1.707 ms, 1.756 ms] 373.982 µs (27.5%)
iast 1.502 ms [1.48 ms, 1.524 ms] 144.21 µs (10.6%)
profiling 1.494 ms [1.471 ms, 1.516 ms] 135.958 µs (10.0%)
tracing 1.471 ms [1.446 ms, 1.496 ms] 113.24 µs (8.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.374 ms] -
appsec 1.713 ms [1.689 ms, 1.737 ms] 358.883 µs (26.5%)
appsec_no_iast 1.726 ms [1.702 ms, 1.75 ms] 371.95 µs (27.5%)
iast 1.474 ms [1.451 ms, 1.496 ms] 119.518 µs (8.8%)
profiling 1.58 ms [1.555 ms, 1.605 ms] 225.838 µs (16.7%)
tracing 1.468 ms [1.443 ms, 1.492 ms] 113.68 µs (8.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~96c6f534f8, baseline=1.41.0-SNAPSHOT~eadf0cc0d6
    dateFormat X
    axisFormat %s
section baseline
no_agent (375.03 µs) : 355, 395
.   : milestone, 375,
iast (492.912 µs) : 471, 515
.   : milestone, 493,
iast_FULL (560.581 µs) : 539, 582
.   : milestone, 561,
iast_GLOBAL (511.553 µs) : 489, 534
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (490.639 µs) : 469, 512
.   : milestone, 491,
iast_INACTIVE (456.316 µs) : 435, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (486.661 µs) : 465, 509
.   : milestone, 487,
tracing (451.483 µs) : 431, 472
.   : milestone, 451,
section candidate
no_agent (384.866 µs) : 365, 405
.   : milestone, 385,
iast (491.934 µs) : 470, 513
.   : milestone, 492,
iast_FULL (564.633 µs) : 543, 586
.   : milestone, 565,
iast_GLOBAL (510.934 µs) : 490, 532
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (489.75 µs) : 468, 511
.   : milestone, 490,
iast_INACTIVE (453.359 µs) : 433, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (481.129 µs) : 459, 503
.   : milestone, 481,
tracing (446.745 µs) : 426, 467
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.03 µs [354.756 µs, 395.304 µs] -
iast 492.912 µs [471.25 µs, 514.574 µs] 117.882 µs (31.4%)
iast_FULL 560.581 µs [539.294 µs, 581.868 µs] 185.551 µs (49.5%)
iast_GLOBAL 511.553 µs [489.35 µs, 533.757 µs] 136.523 µs (36.4%)
iast_HARDCODED_SECRET_DISABLED 490.639 µs [469.429 µs, 511.849 µs] 115.609 µs (30.8%)
iast_INACTIVE 456.316 µs [435.321 µs, 477.312 µs] 81.286 µs (21.7%)
iast_TELEMETRY_OFF 486.661 µs [464.608 µs, 508.714 µs] 111.631 µs (29.8%)
tracing 451.483 µs [430.742 µs, 472.224 µs] 76.453 µs (20.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 384.866 µs [364.744 µs, 404.989 µs] -
iast 491.934 µs [470.49 µs, 513.378 µs] 107.067 µs (27.8%)
iast_FULL 564.633 µs [543.083 µs, 586.183 µs] 179.767 µs (46.7%)
iast_GLOBAL 510.934 µs [489.689 µs, 532.179 µs] 126.068 µs (32.8%)
iast_HARDCODED_SECRET_DISABLED 489.75 µs [468.413 µs, 511.087 µs] 104.883 µs (27.3%)
iast_INACTIVE 453.359 µs [432.523 µs, 474.195 µs] 68.492 µs (17.8%)
iast_TELEMETRY_OFF 481.129 µs [459.185 µs, 503.073 µs] 96.263 µs (25.0%)
tracing 446.745 µs [426.025 µs, 467.465 µs] 61.878 µs (16.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-kotlin-nop
git_commit_date 1728654019 1728657148
git_commit_sha eadf0cc 96c6f53
release_version 1.41.0-SNAPSHOT~eadf0cc0d6 1.41.0-SNAPSHOT~96c6f534f8
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1728659393 1728659393
ci_job_id 669937835 669937835
ci_pipeline_id 46395391 46395391
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~96c6f534f8, baseline=1.41.0-SNAPSHOT~eadf0cc0d6
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.194 s) : 15194000, 15194000
.   : milestone, 15194000,
appsec (15.089 s) : 15089000, 15089000
.   : milestone, 15089000,
iast (18.905 s) : 18905000, 18905000
.   : milestone, 18905000,
iast_GLOBAL (18.244 s) : 18244000, 18244000
.   : milestone, 18244000,
profiling (15.106 s) : 15106000, 15106000
.   : milestone, 15106000,
tracing (15.275 s) : 15275000, 15275000
.   : milestone, 15275000,
section candidate
no_agent (15.163 s) : 15163000, 15163000
.   : milestone, 15163000,
appsec (15.249 s) : 15249000, 15249000
.   : milestone, 15249000,
iast (18.771 s) : 18771000, 18771000
.   : milestone, 18771000,
iast_GLOBAL (18.038 s) : 18038000, 18038000
.   : milestone, 18038000,
profiling (14.914 s) : 14914000, 14914000
.   : milestone, 14914000,
tracing (15.286 s) : 15286000, 15286000
.   : milestone, 15286000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.194 s [15.194 s, 15.194 s] -
appsec 15.089 s [15.089 s, 15.089 s] -105.0 ms (-0.7%)
iast 18.905 s [18.905 s, 18.905 s] 3.711 s (24.4%)
iast_GLOBAL 18.244 s [18.244 s, 18.244 s] 3.05 s (20.1%)
profiling 15.106 s [15.106 s, 15.106 s] -88.0 ms (-0.6%)
tracing 15.275 s [15.275 s, 15.275 s] 81.0 ms (0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.163 s [15.163 s, 15.163 s] -
appsec 15.249 s [15.249 s, 15.249 s] 86.0 ms (0.6%)
iast 18.771 s [18.771 s, 18.771 s] 3.608 s (23.8%)
iast_GLOBAL 18.038 s [18.038 s, 18.038 s] 2.875 s (19.0%)
profiling 14.914 s [14.914 s, 14.914 s] -249.0 ms (-1.6%)
tracing 15.286 s [15.286 s, 15.286 s] 123.0 ms (0.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~96c6f534f8, baseline=1.41.0-SNAPSHOT~eadf0cc0d6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.334 ms) : 2293, 2375
.   : milestone, 2334,
iast (2.085 ms) : 2034, 2136
.   : milestone, 2085,
iast_GLOBAL (2.126 ms) : 2074, 2178
.   : milestone, 2126,
profiling (1.947 ms) : 1906, 1989
.   : milestone, 1947,
tracing (1.93 ms) : 1891, 1970
.   : milestone, 1930,
section candidate
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (2.374 ms) : 2332, 2416
.   : milestone, 2374,
iast (2.079 ms) : 2028, 2131
.   : milestone, 2079,
iast_GLOBAL (2.13 ms) : 2078, 2183
.   : milestone, 2130,
profiling (1.963 ms) : 1922, 2004
.   : milestone, 1963,
tracing (1.923 ms) : 1883, 1962
.   : milestone, 1923,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.459 ms, 1.482 ms] -
appsec 2.334 ms [2.293 ms, 2.375 ms] 863.988 µs (58.8%)
iast 2.085 ms [2.034 ms, 2.136 ms] 614.879 µs (41.8%)
iast_GLOBAL 2.126 ms [2.074 ms, 2.178 ms] 655.529 µs (44.6%)
profiling 1.947 ms [1.906 ms, 1.989 ms] 477.04 µs (32.5%)
tracing 1.93 ms [1.891 ms, 1.97 ms] 460.209 µs (31.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.463 ms, 1.486 ms] -
appsec 2.374 ms [2.332 ms, 2.416 ms] 899.914 µs (61.0%)
iast 2.079 ms [2.028 ms, 2.131 ms] 604.676 µs (41.0%)
iast_GLOBAL 2.13 ms [2.078 ms, 2.183 ms] 655.817 µs (44.5%)
profiling 1.963 ms [1.922 ms, 2.004 ms] 488.722 µs (33.1%)
tracing 1.923 ms [1.883 ms, 1.962 ms] 448.087 µs (30.4%)

@jpbempel jpbempel merged commit 8802457 into master Oct 11, 2024
105 of 107 checks passed
@jpbempel jpbempel deleted the jpbempel/fix-kotlin-nop branch October 11, 2024 15:46
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanchooly evanchooly evanchooly approved these changes

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: bug
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @evanchooly