Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mixed local vars for suspend funs in Kotlin #7748

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix mixed local vars for suspend funs in Kotlin #7748

merged 1 commit into from
Oct 10, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Oct 9, 2024 •
edited by jira bot
Loading

What Does This Do

Recent Kotlin compiler generates multiple range for same local vars and mess up our algorithm for adjustment.
Fix this by made a list of unique local vars

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2948

@jpbempel
Fix mixed local vars for suspend funs in Kotlin
9ee2e92 
Recent Kotlin compiler generates multiple range for same local vars
and mess up our algorithm for adjustment.
Fix this by made a list of unique local vars
@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Oct 9, 2024
@jpbempel jpbempel requested a review from a team as a code owner October 9, 2024 16:52
@jpbempel jpbempel requested review from ojung and removed request for a team October 9, 2024 16:52
@pr-commenter
Copy link

pr-commenter bot commented Oct 9, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1728492776 1728493152
end_time 2024-10-09T16:54:12 2024-10-09T17:00:27
git_branch master jpbempel/kotlin-suspend
git_commit_sha 2a9a4b7 9ee2e92
start_time 2024-10-09T16:52:57 2024-10-09T16:59:13
See matching parameters
Baseline Candidate
ci_job_id 667229844 667229844
ci_pipeline_id 46201020 46201020
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1728492115 1728492115

Summary

Found 0 performance improvements and 5 performance regressions! Performance is the same for 3 metrics, 7 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop worse
[+597.000µs; +617.171µs] or [+5.879%; +6.077%]		 worse
[+585.478µs; +653.484µs] or [+5.674%; +6.333%]		 worse
[+500.178µs; +620.741µs] or [+4.793%; +5.949%]		 worse
[+412.621µs; +782.516µs] or [+3.837%; +7.277%]		 worse
[-6.250op/s; -4.142op/s] or [-6.531%; -4.328%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-52.209µs; +24.488µs] or [-18.955%; +8.891%]		 unstable
[-70.043µs; +31.259µs] or [-22.071%; +9.850%]		 unstable
[-83.049µs; +39.356µs] or [-24.961%; +11.829%]		 unstable
[-729.538µs; +237.185µs] or [-87.161%; +28.338%]		 unstable
[-112.599op/s; +182.775op/s] or [-4.279%; +6.945%]
scenario:basic same same same unstable
[-49642.126ns; +50484.819ns] or [-9.198%; +9.354%]		 unstable
[-173.659op/s; +173.659op/s] or [-6.773%; +6.773%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (317.355 µs) : 255, 379
.   : milestone, 317,
basic (308.251 µs) : 294, 322
.   : milestone, 308,
loop (10.318 ms) : 10284, 10353
.   : milestone, 10318,
section candidate
noprobe (297.963 µs) : 269, 327
.   : milestone, 298,
basic (302.963 µs) : 292, 313
.   : milestone, 303,
loop (10.938 ms) : 10909, 10967
.   : milestone, 10938,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 317.355 µs [255.404 µs, 379.305 µs]
basic 308.251 µs [294.253 µs, 322.248 µs]
loop 10.318 ms [10.284 ms, 10.353 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 297.963 µs [269.189 µs, 326.736 µs]
basic 302.963 µs [292.469 µs, 313.457 µs]
loop 10.938 ms [10.909 ms, 10.967 ms]

@pr-commenter
Copy link

pr-commenter bot commented Oct 9, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/kotlin-suspend
git_commit_date 1728427235 1728492115
git_commit_sha 2a9a4b7 9ee2e92
release_version 1.41.0-SNAPSHOT~2a9a4b7782 1.41.0-SNAPSHOT~9ee2e92d8f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728494620 1728494620
ci_job_id 667229831 667229831
ci_pipeline_id 46201020 46201020
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~9ee2e92d8f, baseline=1.41.0-SNAPSHOT~2a9a4b7782

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066096
Total [baseline] (10.32 s) : 0, 10320440
Agent [candidate] (1.075 s) : 0, 1074629
Total [candidate] (10.361 s) : 0, 10360789
section appsec
Agent [baseline] (1.212 s) : 0, 1211781
Total [baseline] (10.678 s) : 0, 10678069
Agent [candidate] (1.202 s) : 0, 1202176
Total [candidate] (10.536 s) : 0, 10535634
section iast
Agent [baseline] (1.197 s) : 0, 1197385
Total [baseline] (10.837 s) : 0, 10836562
Agent [candidate] (1.196 s) : 0, 1196431
Total [candidate] (10.839 s) : 0, 10839050
section profiling
Agent [baseline] (1.275 s) : 0, 1275225
Total [baseline] (10.585 s) : 0, 10585276
Agent [candidate] (1.268 s) : 0, 1268336
Total [candidate] (10.649 s) : 0, 10649021
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent appsec 1.212 s 145.685 ms (13.7%)
Agent iast 1.197 s 131.289 ms (12.3%)
Agent profiling 1.275 s 209.128 ms (19.6%)
Total tracing 10.32 s -
Total appsec 10.678 s 357.629 ms (3.5%)
Total iast 10.837 s 516.122 ms (5.0%)
Total profiling 10.585 s 264.836 ms (2.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent appsec 1.202 s 127.547 ms (11.9%)
Agent iast 1.196 s 121.802 ms (11.3%)
Agent profiling 1.268 s 193.707 ms (18.0%)
Total tracing 10.361 s -
Total appsec 10.536 s 174.846 ms (1.7%)
Total iast 10.839 s 478.261 ms (4.6%)
Total profiling 10.649 s 288.233 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~9ee2e92d8f, baseline=1.41.0-SNAPSHOT~2a9a4b7782

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.3 ms) : 0, 680300
BytebuddyAgent [candidate] (685.99 ms) : 0, 685990
GlobalTracer [baseline] (310.013 ms) : 0, 310013
GlobalTracer [candidate] (312.367 ms) : 0, 312367
AppSec [baseline] (53.926 ms) : 0, 53926
AppSec [candidate] (54.194 ms) : 0, 54194
Remote Config [baseline] (656.106 µs) : 0, 656
Remote Config [candidate] (673.581 µs) : 0, 674
Telemetry [baseline] (7.589 ms) : 0, 7589
Telemetry [candidate] (7.662 ms) : 0, 7662
section appsec
BytebuddyAgent [baseline] (704.817 ms) : 0, 704817
BytebuddyAgent [candidate] (698.712 ms) : 0, 698712
GlobalTracer [baseline] (309.903 ms) : 0, 309903
GlobalTracer [candidate] (307.247 ms) : 0, 307247
AppSec [baseline] (163.1 ms) : 0, 163100
AppSec [candidate] (162.243 ms) : 0, 162243
Remote Config [baseline] (644.522 µs) : 0, 645
Remote Config [candidate] (645.68 µs) : 0, 646
Telemetry [baseline] (7.915 ms) : 0, 7915
Telemetry [candidate] (9.606 ms) : 0, 9606
IAST [baseline] (23.252 ms) : 0, 23252
IAST [candidate] (20.114 ms) : 0, 20114
section iast
BytebuddyAgent [baseline] (797.534 ms) : 0, 797534
BytebuddyAgent [candidate] (797.043 ms) : 0, 797043
GlobalTracer [baseline] (299.698 ms) : 0, 299698
GlobalTracer [candidate] (299.452 ms) : 0, 299452
AppSec [baseline] (53.547 ms) : 0, 53547
AppSec [candidate] (53.966 ms) : 0, 53966
Remote Config [baseline] (604.774 µs) : 0, 605
Remote Config [candidate] (608.097 µs) : 0, 608
Telemetry [baseline] (7.053 ms) : 0, 7053
Telemetry [candidate] (7.118 ms) : 0, 7118
IAST [baseline] (25.221 ms) : 0, 25221
IAST [candidate] (24.545 ms) : 0, 24545
section profiling
BytebuddyAgent [baseline] (680.109 ms) : 0, 680109
BytebuddyAgent [candidate] (676.632 ms) : 0, 676632
GlobalTracer [baseline] (395.319 ms) : 0, 395319
GlobalTracer [candidate] (393.536 ms) : 0, 393536
AppSec [baseline] (55.035 ms) : 0, 55035
AppSec [candidate] (54.918 ms) : 0, 54918
Remote Config [baseline] (660.677 µs) : 0, 661
Remote Config [candidate] (652.042 µs) : 0, 652
Telemetry [baseline] (7.508 ms) : 0, 7508
Telemetry [candidate] (7.486 ms) : 0, 7486
ProfilingAgent [baseline] (97.697 ms) : 0, 97697
ProfilingAgent [candidate] (96.423 ms) : 0, 96423
Profiling [baseline] (97.72 ms) : 0, 97720
Profiling [candidate] (96.448 ms) : 0, 96448
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~9ee2e92d8f, baseline=1.41.0-SNAPSHOT~2a9a4b7782

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076181
Total [baseline] (8.577 s) : 0, 8576552
Agent [candidate] (1.077 s) : 0, 1076559
Total [candidate] (8.595 s) : 0, 8594787
section iast
Agent [baseline] (1.198 s) : 0, 1197577
Total [baseline] (9.123 s) : 0, 9122663
Agent [candidate] (1.194 s) : 0, 1193782
Total [candidate] (9.062 s) : 0, 9061653
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.196 s) : 0, 1195561
Total [baseline] (9.067 s) : 0, 9066538
Agent [candidate] (1.195 s) : 0, 1194743
Total [candidate] (9.044 s) : 0, 9044122
section iast_TELEMETRY_OFF
Agent [baseline] (1.202 s) : 0, 1201818
Total [baseline] (9.105 s) : 0, 9105071
Agent [candidate] (1.197 s) : 0, 1196686
Total [candidate] (9.085 s) : 0, 9085255
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.198 s 121.396 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.196 s 119.38 ms (11.1%)
Agent iast_TELEMETRY_OFF 1.202 s 125.637 ms (11.7%)
Total tracing 8.577 s -
Total iast 9.123 s 546.112 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.067 s 489.986 ms (5.7%)
Total iast_TELEMETRY_OFF 9.105 s 528.519 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent iast 1.194 s 117.223 ms (10.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.195 s 118.184 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.197 s 120.127 ms (11.2%)
Total tracing 8.595 s -
Total iast 9.062 s 466.865 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.044 s 449.334 ms (5.2%)
Total iast_TELEMETRY_OFF 9.085 s 490.468 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~9ee2e92d8f, baseline=1.41.0-SNAPSHOT~2a9a4b7782

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.43 ms) : 0, 687430
BytebuddyAgent [candidate] (687.693 ms) : 0, 687693
GlobalTracer [baseline] (312.898 ms) : 0, 312898
GlobalTracer [candidate] (312.616 ms) : 0, 312616
AppSec [baseline] (53.85 ms) : 0, 53850
AppSec [candidate] (54.113 ms) : 0, 54113
Remote Config [baseline] (662.028 µs) : 0, 662
Remote Config [candidate] (667.712 µs) : 0, 668
Telemetry [baseline] (7.553 ms) : 0, 7553
Telemetry [candidate] (7.633 ms) : 0, 7633
section iast
BytebuddyAgent [baseline] (798.196 ms) : 0, 798196
BytebuddyAgent [candidate] (795.821 ms) : 0, 795821
GlobalTracer [baseline] (298.751 ms) : 0, 298751
GlobalTracer [candidate] (299.159 ms) : 0, 299159
AppSec [baseline] (51.431 ms) : 0, 51431
AppSec [candidate] (53.229 ms) : 0, 53229
IAST [baseline] (27.809 ms) : 0, 27809
IAST [candidate] (24.237 ms) : 0, 24237
Remote Config [baseline] (598.054 µs) : 0, 598
Remote Config [candidate] (595.781 µs) : 0, 596
Telemetry [baseline] (7.033 ms) : 0, 7033
Telemetry [candidate] (7.026 ms) : 0, 7026
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (796.467 ms) : 0, 796467
BytebuddyAgent [candidate] (795.61 ms) : 0, 795610
GlobalTracer [baseline] (299.054 ms) : 0, 299054
GlobalTracer [candidate] (299.057 ms) : 0, 299057
AppSec [baseline] (54.311 ms) : 0, 54311
AppSec [candidate] (54.373 ms) : 0, 54373
IAST [baseline] (24.327 ms) : 0, 24327
IAST [candidate] (24.365 ms) : 0, 24365
Remote Config [baseline] (596.179 µs) : 0, 596
Remote Config [candidate] (609.007 µs) : 0, 609
Telemetry [baseline] (7.063 ms) : 0, 7063
Telemetry [candidate] (6.994 ms) : 0, 6994
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.816 ms) : 0, 800816
BytebuddyAgent [candidate] (795.091 ms) : 0, 795091
GlobalTracer [baseline] (300.725 ms) : 0, 300725
GlobalTracer [candidate] (301.228 ms) : 0, 301228
AppSec [baseline] (55.366 ms) : 0, 55366
AppSec [candidate] (52.833 ms) : 0, 52833
IAST [baseline] (22.691 ms) : 0, 22691
IAST [candidate] (26.268 ms) : 0, 26268
Remote Config [baseline] (619.674 µs) : 0, 620
Remote Config [candidate] (604.93 µs) : 0, 605
Telemetry [baseline] (7.76 ms) : 0, 7760
Telemetry [candidate] (6.916 ms) : 0, 6916
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-09T16:52:32 2024-10-09T17:01:35
git_branch master jpbempel/kotlin-suspend
git_commit_date 1728427235 1728492115
git_commit_sha 2a9a4b7 9ee2e92
release_version 1.41.0-SNAPSHOT~2a9a4b7782 1.41.0-SNAPSHOT~9ee2e92d8f
start_time 2024-10-09T16:52:16 2024-10-09T17:01:19
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728493754 1728493754
ci_job_id 667229834 667229834
ci_pipeline_id 46201020 46201020
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 6 metrics, 21 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+61.946µs; +133.405µs] or [+3.349%; +7.212%]		 unstable
[-575.443op/s; +281.326op/s] or [-23.018%; +11.253%]		 1.947ms 2352.941op/s 1.850ms 2500.000op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~9ee2e92d8f, baseline=1.41.0-SNAPSHOT~2a9a4b7782
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.711 ms) : 1687, 1736
.   : milestone, 1711,
appsec (2.185 ms) : 2155, 2215
.   : milestone, 2185,
appsec_no_iast (2.189 ms) : 2157, 2220
.   : milestone, 2189,
iast (1.863 ms) : 1832, 1895
.   : milestone, 1863,
profiling (1.85 ms) : 1819, 1881
.   : milestone, 1850,
tracing (1.892 ms) : 1861, 1922
.   : milestone, 1892,
section candidate
no_agent (1.699 ms) : 1675, 1724
.   : milestone, 1699,
appsec (2.209 ms) : 2177, 2241
.   : milestone, 2209,
appsec_no_iast (2.199 ms) : 2166, 2232
.   : milestone, 2199,
iast (1.884 ms) : 1854, 1914
.   : milestone, 1884,
profiling (1.947 ms) : 1912, 1983
.   : milestone, 1947,
tracing (1.875 ms) : 1842, 1908
.   : milestone, 1875,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.711 ms [1.687 ms, 1.736 ms] -
appsec 2.185 ms [2.155 ms, 2.215 ms] 473.508 µs (27.7%)
appsec_no_iast 2.189 ms [2.157 ms, 2.22 ms] 477.232 µs (27.9%)
iast 1.863 ms [1.832 ms, 1.895 ms] 152.001 µs (8.9%)
profiling 1.85 ms [1.819 ms, 1.881 ms] 138.239 µs (8.1%)
tracing 1.892 ms [1.861 ms, 1.922 ms] 180.268 µs (10.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.699 ms [1.675 ms, 1.724 ms] -
appsec 2.209 ms [2.177 ms, 2.241 ms] 510.064 µs (30.0%)
appsec_no_iast 2.199 ms [2.166 ms, 2.232 ms] 499.931 µs (29.4%)
iast 1.884 ms [1.854 ms, 1.914 ms] 184.745 µs (10.9%)
profiling 1.947 ms [1.912 ms, 1.983 ms] 248.21 µs (14.6%)
tracing 1.875 ms [1.842 ms, 1.908 ms] 175.707 µs (10.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~9ee2e92d8f, baseline=1.41.0-SNAPSHOT~2a9a4b7782
    dateFormat X
    axisFormat %s
section baseline
no_agent (447.87 µs) : 419, 477
.   : milestone, 448,
iast (587.102 µs) : 555, 620
.   : milestone, 587,
iast_FULL (691.666 µs) : 660, 723
.   : milestone, 692,
iast_GLOBAL (624.036 µs) : 591, 657
.   : milestone, 624,
iast_HARDCODED_SECRET_DISABLED (583.909 µs) : 552, 616
.   : milestone, 584,
iast_INACTIVE (542.919 µs) : 513, 573
.   : milestone, 543,
iast_TELEMETRY_OFF (577.849 µs) : 547, 609
.   : milestone, 578,
tracing (534.158 µs) : 504, 564
.   : milestone, 534,
section candidate
no_agent (445.428 µs) : 417, 474
.   : milestone, 445,
iast (593.081 µs) : 562, 625
.   : milestone, 593,
iast_FULL (680.471 µs) : 649, 712
.   : milestone, 680,
iast_GLOBAL (615.938 µs) : 583, 648
.   : milestone, 616,
iast_HARDCODED_SECRET_DISABLED (598.191 µs) : 565, 631
.   : milestone, 598,
iast_INACTIVE (537.875 µs) : 507, 568
.   : milestone, 538,
iast_TELEMETRY_OFF (573.258 µs) : 542, 604
.   : milestone, 573,
tracing (537.12 µs) : 507, 567
.   : milestone, 537,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 447.87 µs [419.149 µs, 476.592 µs] -
iast 587.102 µs [554.692 µs, 619.512 µs] 139.231 µs (31.1%)
iast_FULL 691.666 µs [660.007 µs, 723.326 µs] 243.796 µs (54.4%)
iast_GLOBAL 624.036 µs [591.488 µs, 656.584 µs] 176.166 µs (39.3%)
iast_HARDCODED_SECRET_DISABLED 583.909 µs [551.67 µs, 616.147 µs] 136.038 µs (30.4%)
iast_INACTIVE 542.919 µs [512.883 µs, 572.956 µs] 95.049 µs (21.2%)
iast_TELEMETRY_OFF 577.849 µs [546.544 µs, 609.154 µs] 129.979 µs (29.0%)
tracing 534.158 µs [504.082 µs, 564.235 µs] 86.288 µs (19.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 445.428 µs [416.561 µs, 474.295 µs] -
iast 593.081 µs [561.613 µs, 624.548 µs] 147.653 µs (33.1%)
iast_FULL 680.471 µs [648.74 µs, 712.202 µs] 235.043 µs (52.8%)
iast_GLOBAL 615.938 µs [583.451 µs, 648.424 µs] 170.51 µs (38.3%)
iast_HARDCODED_SECRET_DISABLED 598.191 µs [565.243 µs, 631.138 µs] 152.763 µs (34.3%)
iast_INACTIVE 537.875 µs [507.383 µs, 568.368 µs] 92.447 µs (20.8%)
iast_TELEMETRY_OFF 573.258 µs [542.146 µs, 604.369 µs] 127.83 µs (28.7%)
tracing 537.12 µs [506.888 µs, 567.352 µs] 91.692 µs (20.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/kotlin-suspend
git_commit_date 1728427235 1728492115
git_commit_sha 2a9a4b7 9ee2e92
release_version 1.41.0-SNAPSHOT~2a9a4b7782 1.41.0-SNAPSHOT~9ee2e92d8f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1728494154 1728494154
ci_job_id 667229836 667229836
ci_pipeline_id 46201020 46201020
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~9ee2e92d8f, baseline=1.41.0-SNAPSHOT~2a9a4b7782
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.478 s) : 15478000, 15478000
.   : milestone, 15478000,
appsec (15.441 s) : 15441000, 15441000
.   : milestone, 15441000,
iast (18.824 s) : 18824000, 18824000
.   : milestone, 18824000,
iast_GLOBAL (18.253 s) : 18253000, 18253000
.   : milestone, 18253000,
profiling (15.303 s) : 15303000, 15303000
.   : milestone, 15303000,
tracing (15.471 s) : 15471000, 15471000
.   : milestone, 15471000,
section candidate
no_agent (15.789 s) : 15789000, 15789000
.   : milestone, 15789000,
appsec (15.175 s) : 15175000, 15175000
.   : milestone, 15175000,
iast (18.947 s) : 18947000, 18947000
.   : milestone, 18947000,
iast_GLOBAL (18.158 s) : 18158000, 18158000
.   : milestone, 18158000,
profiling (14.941 s) : 14941000, 14941000
.   : milestone, 14941000,
tracing (15.345 s) : 15345000, 15345000
.   : milestone, 15345000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.478 s [15.478 s, 15.478 s] -
appsec 15.441 s [15.441 s, 15.441 s] -37.0 ms (-0.2%)
iast 18.824 s [18.824 s, 18.824 s] 3.346 s (21.6%)
iast_GLOBAL 18.253 s [18.253 s, 18.253 s] 2.775 s (17.9%)
profiling 15.303 s [15.303 s, 15.303 s] -175.0 ms (-1.1%)
tracing 15.471 s [15.471 s, 15.471 s] -7.0 ms (-0.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.789 s [15.789 s, 15.789 s] -
appsec 15.175 s [15.175 s, 15.175 s] -614.0 ms (-3.9%)
iast 18.947 s [18.947 s, 18.947 s] 3.158 s (20.0%)
iast_GLOBAL 18.158 s [18.158 s, 18.158 s] 2.369 s (15.0%)
profiling 14.941 s [14.941 s, 14.941 s] -848.0 ms (-5.4%)
tracing 15.345 s [15.345 s, 15.345 s] -444.0 ms (-2.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~9ee2e92d8f, baseline=1.41.0-SNAPSHOT~2a9a4b7782
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.308 ms) : 2268, 2348
.   : milestone, 2308,
iast (2.056 ms) : 2005, 2107
.   : milestone, 2056,
iast_GLOBAL (2.104 ms) : 2053, 2155
.   : milestone, 2104,
profiling (1.932 ms) : 1890, 1973
.   : milestone, 1932,
tracing (1.905 ms) : 1866, 1943
.   : milestone, 1905,
section candidate
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.31 ms) : 2269, 2350
.   : milestone, 2310,
iast (2.087 ms) : 2035, 2139
.   : milestone, 2087,
iast_GLOBAL (2.111 ms) : 2060, 2163
.   : milestone, 2111,
profiling (1.938 ms) : 1896, 1980
.   : milestone, 1938,
tracing (1.918 ms) : 1879, 1958
.   : milestone, 1918,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.308 ms [2.268 ms, 2.348 ms] 841.042 µs (57.3%)
iast 2.056 ms [2.005 ms, 2.107 ms] 589.236 µs (40.2%)
iast_GLOBAL 2.104 ms [2.053 ms, 2.155 ms] 637.067 µs (43.4%)
profiling 1.932 ms [1.89 ms, 1.973 ms] 465.079 µs (31.7%)
tracing 1.905 ms [1.866 ms, 1.943 ms] 437.737 µs (29.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.45 ms, 1.473 ms] -
appsec 2.31 ms [2.269 ms, 2.35 ms] 848.061 µs (58.0%)
iast 2.087 ms [2.035 ms, 2.139 ms] 625.315 µs (42.8%)
iast_GLOBAL 2.111 ms [2.06 ms, 2.163 ms] 649.767 µs (44.5%)
profiling 1.938 ms [1.896 ms, 1.98 ms] 476.547 µs (32.6%)
tracing 1.918 ms [1.879 ms, 1.958 ms] 456.732 µs (31.2%)

ojung
ojung approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@ojung ojung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jpbempel jpbempel merged commit fa2c1af into master Oct 10, 2024
105 of 106 checks passed
@jpbempel jpbempel deleted the jpbempel/kotlin-suspend branch October 10, 2024 16:55
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 10, 2024
sethsamuel pushed a commit that referenced this pull request Oct 11, 2024
@jpbempel @sethsamuel
Fix mixed local vars for suspend funs in Kotlin (#7748)
74e42f1 
Recent Kotlin compiler generates multiple range for same local vars
and mess up our algorithm for adjustment.
Fix this by made a list of unique local vars
jordan-wong pushed a commit that referenced this pull request Oct 11, 2024
@jpbempel @jordan-wong
Fix mixed local vars for suspend funs in Kotlin (#7748)
a9f0eb9 
Recent Kotlin compiler generates multiple range for same local vars
and mess up our algorithm for adjustment.
Fix this by made a list of unique local vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojung ojung ojung approved these changes

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @ojung