Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure test session trace ID and span ID are the same #7747

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Ensure test session trace ID and span ID are the same #7747

merged 1 commit into from
Oct 10, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Oct 9, 2024 •
edited by jira bot
Loading

What Does This Do

Updates the logic that creates test session span to ensure it has the same trace ID and span ID.

Motivation

This is needed because of a quirk of the CI Test Cycle protocol.

According to the protocol test session events do not have trace ID or span ID, they only have test session ID (the protocol mapping logic in the tracer maps trace ID to session ID when serializing the session event).

However, any APM span that is a child of the session has to have both trace ID and parent ID set to test session ID in order to be properly displayed in the flame graph.

Contributor Checklist

Jira ticket: SDTEST-983

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the comp: ci visibility Continuous Integration Visibility label Oct 9, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 9, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/session-trace-span-id
git_commit_date 1728427235 1728486599
git_commit_sha 2a9a4b7 309442d
release_version 1.41.0-SNAPSHOT~2a9a4b7782 1.41.0-SNAPSHOT~309442ddd2
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728489128 1728489128
ci_job_id 667048044 667048044
ci_pipeline_id 46189052 46189052
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~309442ddd2, baseline=1.41.0-SNAPSHOT~2a9a4b7782

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065869
Total [baseline] (10.376 s) : 0, 10375734
Agent [candidate] (1.067 s) : 0, 1066670
Total [candidate] (10.346 s) : 0, 10346295
section appsec
Agent [baseline] (1.201 s) : 0, 1201403
Total [baseline] (10.546 s) : 0, 10545723
Agent [candidate] (1.205 s) : 0, 1205199
Total [candidate] (10.537 s) : 0, 10537432
section iast
Agent [baseline] (1.202 s) : 0, 1201583
Total [baseline] (10.911 s) : 0, 10911437
Agent [candidate] (1.201 s) : 0, 1201297
Total [candidate] (10.806 s) : 0, 10805527
section profiling
Agent [baseline] (1.263 s) : 0, 1263009
Total [baseline] (10.602 s) : 0, 10601519
Agent [candidate] (1.268 s) : 0, 1267601
Total [candidate] (10.563 s) : 0, 10562809
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent appsec 1.201 s 135.534 ms (12.7%)
Agent iast 1.202 s 135.715 ms (12.7%)
Agent profiling 1.263 s 197.14 ms (18.5%)
Total tracing 10.376 s -
Total appsec 10.546 s 169.989 ms (1.6%)
Total iast 10.911 s 535.703 ms (5.2%)
Total profiling 10.602 s 225.785 ms (2.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent appsec 1.205 s 138.529 ms (13.0%)
Agent iast 1.201 s 134.627 ms (12.6%)
Agent profiling 1.268 s 200.931 ms (18.8%)
Total tracing 10.346 s -
Total appsec 10.537 s 191.138 ms (1.8%)
Total iast 10.806 s 459.232 ms (4.4%)
Total profiling 10.563 s 216.514 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~309442ddd2, baseline=1.41.0-SNAPSHOT~2a9a4b7782

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.758 ms) : 0, 680758
BytebuddyAgent [candidate] (680.979 ms) : 0, 680979
GlobalTracer [baseline] (309.628 ms) : 0, 309628
GlobalTracer [candidate] (310.161 ms) : 0, 310161
AppSec [baseline] (53.699 ms) : 0, 53699
AppSec [candidate] (53.707 ms) : 0, 53707
Remote Config [baseline] (654.232 µs) : 0, 654
Remote Config [candidate] (662.694 µs) : 0, 663
Telemetry [baseline] (7.547 ms) : 0, 7547
Telemetry [candidate] (7.525 ms) : 0, 7525
section appsec
BytebuddyAgent [baseline] (698.856 ms) : 0, 698856
BytebuddyAgent [candidate] (700.492 ms) : 0, 700492
GlobalTracer [baseline] (306.917 ms) : 0, 306917
GlobalTracer [candidate] (308.097 ms) : 0, 308097
AppSec [baseline] (162.349 ms) : 0, 162349
AppSec [candidate] (162.979 ms) : 0, 162979
Remote Config [baseline] (633.83 µs) : 0, 634
Remote Config [candidate] (641.755 µs) : 0, 642
Telemetry [baseline] (8.545 ms) : 0, 8545
Telemetry [candidate] (8.487 ms) : 0, 8487
IAST [baseline] (20.945 ms) : 0, 20945
IAST [candidate] (21.714 ms) : 0, 21714
section iast
BytebuddyAgent [baseline] (801.09 ms) : 0, 801090
BytebuddyAgent [candidate] (801.3 ms) : 0, 801300
GlobalTracer [baseline] (300.323 ms) : 0, 300323
GlobalTracer [candidate] (300.476 ms) : 0, 300476
AppSec [baseline] (53.5 ms) : 0, 53500
AppSec [candidate] (54.71 ms) : 0, 54710
Remote Config [baseline] (603.503 µs) : 0, 604
Remote Config [candidate] (602.604 µs) : 0, 603
Telemetry [baseline] (7.033 ms) : 0, 7033
Telemetry [candidate] (7.035 ms) : 0, 7035
IAST [baseline] (25.36 ms) : 0, 25360
IAST [candidate] (23.453 ms) : 0, 23453
section profiling
BytebuddyAgent [baseline] (673.962 ms) : 0, 673962
BytebuddyAgent [candidate] (675.888 ms) : 0, 675888
GlobalTracer [baseline] (391.702 ms) : 0, 391702
GlobalTracer [candidate] (393.173 ms) : 0, 393173
AppSec [baseline] (54.549 ms) : 0, 54549
AppSec [candidate] (54.759 ms) : 0, 54759
Remote Config [baseline] (640.574 µs) : 0, 641
Remote Config [candidate] (648.07 µs) : 0, 648
Telemetry [baseline] (7.376 ms) : 0, 7376
Telemetry [candidate] (7.408 ms) : 0, 7408
ProfilingAgent [baseline] (96.33 ms) : 0, 96330
ProfilingAgent [candidate] (97.186 ms) : 0, 97186
Profiling [baseline] (96.353 ms) : 0, 96353
Profiling [candidate] (97.209 ms) : 0, 97209
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~309442ddd2, baseline=1.41.0-SNAPSHOT~2a9a4b7782

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066702
Total [baseline] (8.569 s) : 0, 8569378
Agent [candidate] (1.073 s) : 0, 1073408
Total [candidate] (8.585 s) : 0, 8584531
section iast
Agent [baseline] (1.204 s) : 0, 1204040
Total [baseline] (9.101 s) : 0, 9100539
Agent [candidate] (1.192 s) : 0, 1192143
Total [candidate] (9.073 s) : 0, 9072764
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.192 s) : 0, 1192172
Total [baseline] (9.033 s) : 0, 9033196
Agent [candidate] (1.203 s) : 0, 1203093
Total [candidate] (9.059 s) : 0, 9058851
section iast_TELEMETRY_OFF
Agent [baseline] (1.201 s) : 0, 1200522
Total [baseline] (9.111 s) : 0, 9110632
Agent [candidate] (1.189 s) : 0, 1189100
Total [candidate] (9.066 s) : 0, 9065696
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent iast 1.204 s 137.337 ms (12.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.192 s 125.469 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.201 s 133.82 ms (12.5%)
Total tracing 8.569 s -
Total iast 9.101 s 531.161 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.033 s 463.818 ms (5.4%)
Total iast_TELEMETRY_OFF 9.111 s 541.254 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent iast 1.192 s 118.735 ms (11.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.203 s 129.685 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.189 s 115.692 ms (10.8%)
Total tracing 8.585 s -
Total iast 9.073 s 488.233 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.059 s 474.32 ms (5.5%)
Total iast_TELEMETRY_OFF 9.066 s 481.165 ms (5.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~309442ddd2, baseline=1.41.0-SNAPSHOT~2a9a4b7782

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.895 ms) : 0, 680895
BytebuddyAgent [candidate] (685.745 ms) : 0, 685745
GlobalTracer [baseline] (310.18 ms) : 0, 310180
GlobalTracer [candidate] (311.61 ms) : 0, 311610
AppSec [baseline] (53.764 ms) : 0, 53764
AppSec [candidate] (54.102 ms) : 0, 54102
Remote Config [baseline] (657.743 µs) : 0, 658
Remote Config [candidate] (662.255 µs) : 0, 662
Telemetry [baseline] (7.544 ms) : 0, 7544
Telemetry [candidate] (7.577 ms) : 0, 7577
section iast
BytebuddyAgent [baseline] (802.949 ms) : 0, 802949
BytebuddyAgent [candidate] (794.333 ms) : 0, 794333
GlobalTracer [baseline] (300.951 ms) : 0, 300951
GlobalTracer [candidate] (298.512 ms) : 0, 298512
AppSec [baseline] (57.217 ms) : 0, 57217
AppSec [candidate] (55.134 ms) : 0, 55134
IAST [baseline] (21.434 ms) : 0, 21434
IAST [candidate] (22.877 ms) : 0, 22877
Remote Config [baseline] (613.561 µs) : 0, 614
Remote Config [candidate] (606.556 µs) : 0, 607
Telemetry [baseline] (7.131 ms) : 0, 7131
Telemetry [candidate] (7.049 ms) : 0, 7049
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (794.199 ms) : 0, 794199
BytebuddyAgent [candidate] (801.809 ms) : 0, 801809
GlobalTracer [baseline] (298.309 ms) : 0, 298309
GlobalTracer [candidate] (301.057 ms) : 0, 301057
AppSec [baseline] (53.329 ms) : 0, 53329
AppSec [candidate] (55.695 ms) : 0, 55695
IAST [baseline] (24.325 ms) : 0, 24325
IAST [candidate] (22.965 ms) : 0, 22965
Remote Config [baseline] (603.56 µs) : 0, 604
Remote Config [candidate] (605.095 µs) : 0, 605
Telemetry [baseline] (7.782 ms) : 0, 7782
Telemetry [candidate] (7.155 ms) : 0, 7155
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.216 ms) : 0, 800216
BytebuddyAgent [candidate] (791.452 ms) : 0, 791452
GlobalTracer [baseline] (301.064 ms) : 0, 301064
GlobalTracer [candidate] (298.499 ms) : 0, 298499
AppSec [baseline] (55.596 ms) : 0, 55596
AppSec [candidate] (53.759 ms) : 0, 53759
IAST [baseline] (22.359 ms) : 0, 22359
IAST [candidate] (23.383 ms) : 0, 23383
Remote Config [baseline] (600.667 µs) : 0, 601
Remote Config [candidate] (606.211 µs) : 0, 606
Telemetry [baseline] (6.914 ms) : 0, 6914
Telemetry [candidate] (7.736 ms) : 0, 7736
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-09T15:22:43 2024-10-09T15:29:36
git_branch master nikita-tkachenko/session-trace-span-id
git_commit_date 1728427235 1728486599
git_commit_sha 2a9a4b7 309442d
release_version 1.41.0-SNAPSHOT~2a9a4b7782 1.41.0-SNAPSHOT~309442ddd2
start_time 2024-10-09T15:22:29 2024-10-09T15:29:23
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728488124 1728488124
ci_job_id 667048045 667048045
ci_pipeline_id 46189052 46189052
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~309442ddd2, baseline=1.41.0-SNAPSHOT~2a9a4b7782
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.333 ms) : 1314, 1352
.   : milestone, 1333,
appsec (1.726 ms) : 1702, 1751
.   : milestone, 1726,
appsec_no_iast (1.747 ms) : 1723, 1771
.   : milestone, 1747,
iast (1.472 ms) : 1449, 1495
.   : milestone, 1472,
profiling (1.552 ms) : 1527, 1577
.   : milestone, 1552,
tracing (1.49 ms) : 1466, 1514
.   : milestone, 1490,
section candidate
no_agent (1.344 ms) : 1324, 1363
.   : milestone, 1344,
appsec (1.739 ms) : 1716, 1763
.   : milestone, 1739,
appsec_no_iast (1.746 ms) : 1722, 1770
.   : milestone, 1746,
iast (1.489 ms) : 1466, 1512
.   : milestone, 1489,
profiling (1.505 ms) : 1481, 1528
.   : milestone, 1505,
tracing (1.488 ms) : 1464, 1512
.   : milestone, 1488,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.333 ms [1.314 ms, 1.352 ms] -
appsec 1.726 ms [1.702 ms, 1.751 ms] 393.502 µs (29.5%)
appsec_no_iast 1.747 ms [1.723 ms, 1.771 ms] 414.005 µs (31.1%)
iast 1.472 ms [1.449 ms, 1.495 ms] 139.191 µs (10.4%)
profiling 1.552 ms [1.527 ms, 1.577 ms] 219.498 µs (16.5%)
tracing 1.49 ms [1.466 ms, 1.514 ms] 157.105 µs (11.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.324 ms, 1.363 ms] -
appsec 1.739 ms [1.716 ms, 1.763 ms] 395.824 µs (29.5%)
appsec_no_iast 1.746 ms [1.722 ms, 1.77 ms] 402.392 µs (29.9%)
iast 1.489 ms [1.466 ms, 1.512 ms] 145.274 µs (10.8%)
profiling 1.505 ms [1.481 ms, 1.528 ms] 161.081 µs (12.0%)
tracing 1.488 ms [1.464 ms, 1.512 ms] 144.314 µs (10.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~309442ddd2, baseline=1.41.0-SNAPSHOT~2a9a4b7782
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.551 µs) : 359, 400
.   : milestone, 380,
iast (484.051 µs) : 463, 505
.   : milestone, 484,
iast_FULL (562.035 µs) : 541, 583
.   : milestone, 562,
iast_GLOBAL (514.441 µs) : 494, 535
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (487.331 µs) : 466, 509
.   : milestone, 487,
iast_INACTIVE (453.917 µs) : 433, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (477.095 µs) : 456, 498
.   : milestone, 477,
tracing (455.442 µs) : 434, 476
.   : milestone, 455,
section candidate
no_agent (371.526 µs) : 351, 392
.   : milestone, 372,
iast (483.967 µs) : 463, 505
.   : milestone, 484,
iast_FULL (555.817 µs) : 535, 577
.   : milestone, 556,
iast_GLOBAL (512.473 µs) : 491, 534
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (491.874 µs) : 471, 513
.   : milestone, 492,
iast_INACTIVE (450.865 µs) : 430, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (480.001 µs) : 459, 501
.   : milestone, 480,
tracing (450.039 µs) : 430, 470
.   : milestone, 450,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.551 µs [359.34 µs, 399.761 µs] -
iast 484.051 µs [463.094 µs, 505.009 µs] 104.501 µs (27.5%)
iast_FULL 562.035 µs [540.829 µs, 583.242 µs] 182.485 µs (48.1%)
iast_GLOBAL 514.441 µs [493.579 µs, 535.303 µs] 134.89 µs (35.5%)
iast_HARDCODED_SECRET_DISABLED 487.331 µs [466.064 µs, 508.599 µs] 107.781 µs (28.4%)
iast_INACTIVE 453.917 µs [432.729 µs, 475.104 µs] 74.366 µs (19.6%)
iast_TELEMETRY_OFF 477.095 µs [456.132 µs, 498.057 µs] 97.544 µs (25.7%)
tracing 455.442 µs [434.4 µs, 476.485 µs] 75.892 µs (20.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.526 µs [350.563 µs, 392.49 µs] -
iast 483.967 µs [462.886 µs, 505.048 µs] 112.441 µs (30.3%)
iast_FULL 555.817 µs [534.657 µs, 576.977 µs] 184.291 µs (49.6%)
iast_GLOBAL 512.473 µs [491.201 µs, 533.744 µs] 140.946 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED 491.874 µs [470.592 µs, 513.156 µs] 120.348 µs (32.4%)
iast_INACTIVE 450.865 µs [430.222 µs, 471.508 µs] 79.339 µs (21.4%)
iast_TELEMETRY_OFF 480.001 µs [458.521 µs, 501.482 µs] 108.475 µs (29.2%)
tracing 450.039 µs [429.689 µs, 470.389 µs] 78.513 µs (21.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/session-trace-span-id
git_commit_date 1728427235 1728486599
git_commit_sha 2a9a4b7 309442d
release_version 1.41.0-SNAPSHOT~2a9a4b7782 1.41.0-SNAPSHOT~309442ddd2
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1728488645 1728488645
ci_job_id 667048046 667048046
ci_pipeline_id 46189052 46189052
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~309442ddd2, baseline=1.41.0-SNAPSHOT~2a9a4b7782
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.201 s) : 15201000, 15201000
.   : milestone, 15201000,
appsec (15.205 s) : 15205000, 15205000
.   : milestone, 15205000,
iast (19.09 s) : 19090000, 19090000
.   : milestone, 19090000,
iast_GLOBAL (18.223 s) : 18223000, 18223000
.   : milestone, 18223000,
profiling (15.279 s) : 15279000, 15279000
.   : milestone, 15279000,
tracing (15.266 s) : 15266000, 15266000
.   : milestone, 15266000,
section candidate
no_agent (14.817 s) : 14817000, 14817000
.   : milestone, 14817000,
appsec (15.225 s) : 15225000, 15225000
.   : milestone, 15225000,
iast (18.697 s) : 18697000, 18697000
.   : milestone, 18697000,
iast_GLOBAL (17.815 s) : 17815000, 17815000
.   : milestone, 17815000,
profiling (15.109 s) : 15109000, 15109000
.   : milestone, 15109000,
tracing (15.059 s) : 15059000, 15059000
.   : milestone, 15059000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.201 s [15.201 s, 15.201 s] -
appsec 15.205 s [15.205 s, 15.205 s] 4.0 ms (0.0%)
iast 19.09 s [19.09 s, 19.09 s] 3.889 s (25.6%)
iast_GLOBAL 18.223 s [18.223 s, 18.223 s] 3.022 s (19.9%)
profiling 15.279 s [15.279 s, 15.279 s] 78.0 ms (0.5%)
tracing 15.266 s [15.266 s, 15.266 s] 65.0 ms (0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.817 s [14.817 s, 14.817 s] -
appsec 15.225 s [15.225 s, 15.225 s] 408.0 ms (2.8%)
iast 18.697 s [18.697 s, 18.697 s] 3.88 s (26.2%)
iast_GLOBAL 17.815 s [17.815 s, 17.815 s] 2.998 s (20.2%)
profiling 15.109 s [15.109 s, 15.109 s] 292.0 ms (2.0%)
tracing 15.059 s [15.059 s, 15.059 s] 242.0 ms (1.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~309442ddd2, baseline=1.41.0-SNAPSHOT~2a9a4b7782
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.312 ms) : 2272, 2353
.   : milestone, 2312,
iast (2.062 ms) : 2011, 2113
.   : milestone, 2062,
iast_GLOBAL (2.12 ms) : 2067, 2172
.   : milestone, 2120,
profiling (1.936 ms) : 1893, 1979
.   : milestone, 1936,
tracing (1.908 ms) : 1869, 1947
.   : milestone, 1908,
section candidate
no_agent (1.464 ms) : 1452, 1475
.   : milestone, 1464,
appsec (2.308 ms) : 2267, 2348
.   : milestone, 2308,
iast (2.057 ms) : 2006, 2108
.   : milestone, 2057,
iast_GLOBAL (2.101 ms) : 2049, 2153
.   : milestone, 2101,
profiling (1.921 ms) : 1880, 1961
.   : milestone, 1921,
tracing (1.903 ms) : 1864, 1942
.   : milestone, 1903,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.459 ms, 1.482 ms] -
appsec 2.312 ms [2.272 ms, 2.353 ms] 842.284 µs (57.3%)
iast 2.062 ms [2.011 ms, 2.113 ms] 591.744 µs (40.3%)
iast_GLOBAL 2.12 ms [2.067 ms, 2.172 ms] 649.474 µs (44.2%)
profiling 1.936 ms [1.893 ms, 1.979 ms] 465.762 µs (31.7%)
tracing 1.908 ms [1.869 ms, 1.947 ms] 437.785 µs (29.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.452 ms, 1.475 ms] -
appsec 2.308 ms [2.267 ms, 2.348 ms] 844.122 µs (57.7%)
iast 2.057 ms [2.006 ms, 2.108 ms] 593.424 µs (40.5%)
iast_GLOBAL 2.101 ms [2.049 ms, 2.153 ms] 637.522 µs (43.6%)
profiling 1.921 ms [1.88 ms, 1.961 ms] 457.079 µs (31.2%)
tracing 1.903 ms [1.864 ms, 1.942 ms] 439.288 µs (30.0%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review October 9, 2024 10:29
PerfectSlayer
PerfectSlayer approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed internally about the way to set the trace ID, by using SpanBuild.asChildOf() with a dedicated SpanContext implementation.

The PR looks good from Platform POV

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 70c9598 into master Oct 10, 2024
102 of 104 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/session-trace-span-id branch October 10, 2024 08:29
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 10, 2024
jordan-wong pushed a commit that referenced this pull request Oct 11, 2024
@nikita-tkachenko-datadog @jordan-wong
Ensure test session trace ID and span ID are the same (#7747)
91361c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainkomorndatadog romainkomorndatadog romainkomorndatadog approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh was automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nikita-tkachenko-datadog @PerfectSlayer @romainkomorndatadog