Fix Where signature

[jpbempel]

What Does This Do

in Where::convertLineToMethod method we are converting a Where with a line to a new Where as a method + signature matching the line However the signature was the JVM descriptor and therefore does not match with the way we are using it for matching instrumentation that expect a java signature

Motivation

Additional Notes

Contributor Checklist

• Format the title according the contribution guidelines
• Assign the type: and (comp: or inst:) labels in addition to any usefull labels
• Squash your commits prior merging or merge using GitHub's Squash and merge
• Don't use close, fix or any linking keywords when referencing an issue.
  Use solves instead, and assign the PR milestone to the issue
• Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

[evanchooly]

❤️

[pr-commenter]

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1728055330	1728055715
end_time	2024-10-04T15:23:25	2024-10-04T15:29:49
git_branch	master	jpbempel/code-origin-fix
git_commit_sha	6306f63	a851f46
start_time	2024-10-04T15:22:11	2024-10-04T15:28:36

See matching parameters

	Baseline	Candidate
ci_job_id	661952739	661952739
ci_pipeline_id	45841819	45841819
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1728054710	1728054710

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:loop	better [-556.257µs; -478.877µs] or [-5.224%; -4.498%]	better [-574.521µs; -478.392µs] or [-5.311%; -4.422%]	better [-561.589µs; -450.629µs] or [-5.162%; -4.142%]	better [-799.351µs; -225.249µs] or [-7.091%; -1.998%]	better [+3.734op/s; +5.087op/s] or [+4.070%; +5.545%]

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-23.154µs; +16.028µs] or [-8.863%; +6.135%]	unstable [-37.400µs; +26.368µs] or [-12.420%; +8.756%]	unstable [-48.759µs; +37.034µs] or [-15.483%; +11.760%]	unstable [-87.678µs; +113.457µs] or [-14.862%; +19.232%]	same
scenario:basic	unsure [+2.293µs; +12.714µs] or [+0.865%; +4.798%]	same	same	unstable [-37.737µs; +45.690µs] or [-6.922%; +8.380%]	unstable [-202.064op/s; +67.111op/s] or [-7.678%; +2.550%]

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (301.129 µs) : 267, 335
.   : milestone, 301,
basic (296.174 µs) : 285, 307
.   : milestone, 296,
loop (10.818 ms) : 10762, 10873
.   : milestone, 10818,
section candidate
noprobe (295.613 µs) : 269, 322
.   : milestone, 296,
basic (304.016 µs) : 296, 312
.   : milestone, 304,
loop (10.291 ms) : 10261, 10321
.   : milestone, 10291,

Loading

• baseline results

Scenario	Request median duration [CI 0.99]
noprobe	301.129 µs [267.469 µs, 334.789 µs]
basic	296.174 µs [284.978 µs, 307.371 µs]
loop	10.818 ms [10.762 ms, 10.873 ms]

• candidate results

Scenario	Request median duration [CI 0.99]
noprobe	295.613 µs [268.829 µs, 322.397 µs]
basic	304.016 µs [296.092 µs, 311.94 µs]
loop	10.291 ms [10.261 ms, 10.321 ms]