Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert HTTP client sharing in CI Vis components #7734

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Revert HTTP client sharing in CI Vis components #7734

merged 1 commit into from
Oct 7, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Oct 4, 2024 •
edited by jira bot
Loading

What Does This Do

Partially reverts the changes done in #7689
Shared HTTP client is replaced with dedicated HTTP clients for events intake, coverage intake, and backend API - the way it was before the changes.

Motivation

Sharing HTTP client results in performance regression in the Java test environment.

Contributor Checklist

Jira ticket: SDTEST-999

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the comp: ci visibility Continuous Integration Visibility label Oct 4, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 4, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/revert-http-client-sharing
git_commit_date 1728049518 1728052214
git_commit_sha e5e5427 a8c16d0
release_version 1.41.0-SNAPSHOT~e5e542705f 1.41.0-SNAPSHOT~a8c16d0184
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728054568 1728054568
ci_job_id 661861483 661861483
ci_pipeline_id 45834804 45834804
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~a8c16d0184, baseline=1.41.0-SNAPSHOT~e5e542705f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080998
Total [baseline] (8.622 s) : 0, 8622192
Agent [candidate] (1.065 s) : 0, 1065058
Total [candidate] (8.533 s) : 0, 8533322
section iast
Agent [baseline] (1.203 s) : 0, 1203282
Total [baseline] (9.079 s) : 0, 9079056
Agent [candidate] (1.197 s) : 0, 1197182
Total [candidate] (9.108 s) : 0, 9107524
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.196 s) : 0, 1196038
Total [baseline] (9.052 s) : 0, 9051792
Agent [candidate] (1.213 s) : 0, 1213237
Total [candidate] (9.089 s) : 0, 9088617
section iast_TELEMETRY_OFF
Agent [baseline] (1.209 s) : 0, 1209499
Total [baseline] (9.073 s) : 0, 9072992
Agent [candidate] (1.192 s) : 0, 1192492
Total [candidate] (9.06 s) : 0, 9060069
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.203 s 122.284 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.196 s 115.04 ms (10.6%)
Agent iast_TELEMETRY_OFF 1.209 s 128.501 ms (11.9%)
Total tracing 8.622 s -
Total iast 9.079 s 456.864 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.052 s 429.6 ms (5.0%)
Total iast_TELEMETRY_OFF 9.073 s 450.8 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.197 s 132.124 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.213 s 148.179 ms (13.9%)
Agent iast_TELEMETRY_OFF 1.192 s 127.435 ms (12.0%)
Total tracing 8.533 s -
Total iast 9.108 s 574.201 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.089 s 555.295 ms (6.5%)
Total iast_TELEMETRY_OFF 9.06 s 526.746 ms (6.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~a8c16d0184, baseline=1.41.0-SNAPSHOT~e5e542705f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.596 ms) : 0, 690596
BytebuddyAgent [candidate] (679.621 ms) : 0, 679621
GlobalTracer [baseline] (314.064 ms) : 0, 314064
GlobalTracer [candidate] (310.205 ms) : 0, 310205
AppSec [baseline] (54.158 ms) : 0, 54158
AppSec [candidate] (53.269 ms) : 0, 53269
Remote Config [baseline] (671.038 µs) : 0, 671
Remote Config [candidate] (667.783 µs) : 0, 668
Telemetry [baseline] (7.67 ms) : 0, 7670
Telemetry [candidate] (7.653 ms) : 0, 7653
section iast
BytebuddyAgent [baseline] (802.048 ms) : 0, 802048
BytebuddyAgent [candidate] (797.589 ms) : 0, 797589
GlobalTracer [baseline] (301.23 ms) : 0, 301230
GlobalTracer [candidate] (300.144 ms) : 0, 300144
AppSec [baseline] (55.517 ms) : 0, 55517
AppSec [candidate] (56.02 ms) : 0, 56020
IAST [baseline] (22.898 ms) : 0, 22898
IAST [candidate] (21.91 ms) : 0, 21910
Remote Config [baseline] (624.924 µs) : 0, 625
Remote Config [candidate] (628.469 µs) : 0, 628
Telemetry [baseline] (7.157 ms) : 0, 7157
Telemetry [candidate] (7.13 ms) : 0, 7130
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (796.164 ms) : 0, 796164
BytebuddyAgent [candidate] (808.058 ms) : 0, 808058
GlobalTracer [baseline] (300.476 ms) : 0, 300476
GlobalTracer [candidate] (304.469 ms) : 0, 304469
AppSec [baseline] (57.656 ms) : 0, 57656
AppSec [candidate] (55.737 ms) : 0, 55737
IAST [baseline] (20.241 ms) : 0, 20241
IAST [candidate] (23.188 ms) : 0, 23188
Remote Config [baseline] (617.13 µs) : 0, 617
Remote Config [candidate] (622.018 µs) : 0, 622
Telemetry [baseline] (7.113 ms) : 0, 7113
Telemetry [candidate] (7.215 ms) : 0, 7215
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.916 ms) : 0, 804916
BytebuddyAgent [candidate] (793.041 ms) : 0, 793041
GlobalTracer [baseline] (303.985 ms) : 0, 303985
GlobalTracer [candidate] (300.233 ms) : 0, 300233
AppSec [baseline] (56.277 ms) : 0, 56277
AppSec [candidate] (53.048 ms) : 0, 53048
IAST [baseline] (22.755 ms) : 0, 22755
IAST [candidate] (24.96 ms) : 0, 24960
Remote Config [baseline] (619.684 µs) : 0, 620
Remote Config [candidate] (585.851 µs) : 0, 586
Telemetry [baseline] (7.03 ms) : 0, 7030
Telemetry [candidate] (6.876 ms) : 0, 6876
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~a8c16d0184, baseline=1.41.0-SNAPSHOT~e5e542705f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069493
Total [baseline] (10.408 s) : 0, 10407752
Agent [candidate] (1.071 s) : 0, 1070904
Total [candidate] (10.366 s) : 0, 10365523
section appsec
Agent [baseline] (1.203 s) : 0, 1202661
Total [baseline] (10.555 s) : 0, 10555387
Agent [candidate] (1.207 s) : 0, 1207170
Total [candidate] (10.595 s) : 0, 10594985
section iast
Agent [baseline] (1.204 s) : 0, 1204105
Total [baseline] (10.875 s) : 0, 10875057
Agent [candidate] (1.204 s) : 0, 1203724
Total [candidate] (10.862 s) : 0, 10861932
section profiling
Agent [baseline] (1.274 s) : 0, 1273863
Total [baseline] (10.619 s) : 0, 10619315
Agent [candidate] (1.273 s) : 0, 1273223
Total [candidate] (10.584 s) : 0, 10584368
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent appsec 1.203 s 133.168 ms (12.5%)
Agent iast 1.204 s 134.612 ms (12.6%)
Agent profiling 1.274 s 204.371 ms (19.1%)
Total tracing 10.408 s -
Total appsec 10.555 s 147.634 ms (1.4%)
Total iast 10.875 s 467.305 ms (4.5%)
Total profiling 10.619 s 211.563 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.207 s 136.266 ms (12.7%)
Agent iast 1.204 s 132.82 ms (12.4%)
Agent profiling 1.273 s 202.319 ms (18.9%)
Total tracing 10.366 s -
Total appsec 10.595 s 229.462 ms (2.2%)
Total iast 10.862 s 496.409 ms (4.8%)
Total profiling 10.584 s 218.845 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~a8c16d0184, baseline=1.41.0-SNAPSHOT~e5e542705f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.941 ms) : 0, 681941
BytebuddyAgent [candidate] (682.887 ms) : 0, 682887
GlobalTracer [baseline] (311.206 ms) : 0, 311206
GlobalTracer [candidate] (312.249 ms) : 0, 312249
AppSec [baseline] (53.819 ms) : 0, 53819
AppSec [candidate] (53.713 ms) : 0, 53713
Remote Config [baseline] (1.245 ms) : 0, 1245
Remote Config [candidate] (662.982 µs) : 0, 663
Telemetry [baseline] (7.634 ms) : 0, 7634
Telemetry [candidate] (7.668 ms) : 0, 7668
section appsec
BytebuddyAgent [baseline] (698.304 ms) : 0, 698304
BytebuddyAgent [candidate] (701.141 ms) : 0, 701141
GlobalTracer [baseline] (307.667 ms) : 0, 307667
GlobalTracer [candidate] (309.318 ms) : 0, 309318
AppSec [baseline] (163.118 ms) : 0, 163118
AppSec [candidate] (164.019 ms) : 0, 164019
Remote Config [baseline] (638.457 µs) : 0, 638
Remote Config [candidate] (651.787 µs) : 0, 652
Telemetry [baseline] (9.211 ms) : 0, 9211
Telemetry [candidate] (7.85 ms) : 0, 7850
IAST [baseline] (20.103 ms) : 0, 20103
IAST [candidate] (20.971 ms) : 0, 20971
section iast
BytebuddyAgent [baseline] (802.561 ms) : 0, 802561
BytebuddyAgent [candidate] (801.684 ms) : 0, 801684
GlobalTracer [baseline] (301.581 ms) : 0, 301581
GlobalTracer [candidate] (301.792 ms) : 0, 301792
AppSec [baseline] (53.943 ms) : 0, 53943
AppSec [candidate] (54.944 ms) : 0, 54944
Remote Config [baseline] (617.254 µs) : 0, 617
Remote Config [candidate] (620.911 µs) : 0, 621
Telemetry [baseline] (7.098 ms) : 0, 7098
Telemetry [candidate] (7.136 ms) : 0, 7136
IAST [baseline] (24.506 ms) : 0, 24506
IAST [candidate] (23.763 ms) : 0, 23763
section profiling
ProfilingAgent [baseline] (97.113 ms) : 0, 97113
ProfilingAgent [candidate] (97.085 ms) : 0, 97085
BytebuddyAgent [baseline] (679.288 ms) : 0, 679288
BytebuddyAgent [candidate] (678.865 ms) : 0, 678865
GlobalTracer [baseline] (395.275 ms) : 0, 395275
GlobalTracer [candidate] (395.488 ms) : 0, 395488
AppSec [baseline] (55.003 ms) : 0, 55003
AppSec [candidate] (54.761 ms) : 0, 54761
Remote Config [baseline] (657.97 µs) : 0, 658
Remote Config [candidate] (661.072 µs) : 0, 661
Telemetry [baseline] (7.567 ms) : 0, 7567
Telemetry [candidate] (7.471 ms) : 0, 7471
Profiling [baseline] (97.137 ms) : 0, 97137
Profiling [candidate] (97.109 ms) : 0, 97109
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-04T14:39:57 2024-10-04T14:46:52
git_branch master nikita-tkachenko/revert-http-client-sharing
git_commit_date 1728049518 1728052214
git_commit_sha e5e5427 a8c16d0
release_version 1.41.0-SNAPSHOT~e5e542705f 1.41.0-SNAPSHOT~a8c16d0184
start_time 2024-10-04T14:39:44 2024-10-04T14:46:38
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728053559 1728053559
ci_job_id 661861484 661861484
ci_pipeline_id 45834804 45834804
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~a8c16d0184, baseline=1.41.0-SNAPSHOT~e5e542705f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.365 ms) : 1345, 1385
.   : milestone, 1365,
appsec (1.757 ms) : 1733, 1781
.   : milestone, 1757,
appsec_no_iast (1.72 ms) : 1695, 1745
.   : milestone, 1720,
iast (1.485 ms) : 1463, 1508
.   : milestone, 1485,
profiling (1.489 ms) : 1465, 1514
.   : milestone, 1489,
tracing (1.471 ms) : 1446, 1495
.   : milestone, 1471,
section candidate
no_agent (1.355 ms) : 1336, 1375
.   : milestone, 1355,
appsec (1.724 ms) : 1701, 1747
.   : milestone, 1724,
appsec_no_iast (1.735 ms) : 1710, 1760
.   : milestone, 1735,
iast (1.468 ms) : 1445, 1490
.   : milestone, 1468,
profiling (1.48 ms) : 1456, 1505
.   : milestone, 1480,
tracing (1.473 ms) : 1448, 1498
.   : milestone, 1473,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.365 ms [1.345 ms, 1.385 ms] -
appsec 1.757 ms [1.733 ms, 1.781 ms] 392.244 µs (28.7%)
appsec_no_iast 1.72 ms [1.695 ms, 1.745 ms] 355.074 µs (26.0%)
iast 1.485 ms [1.463 ms, 1.508 ms] 120.48 µs (8.8%)
profiling 1.489 ms [1.465 ms, 1.514 ms] 124.37 µs (9.1%)
tracing 1.471 ms [1.446 ms, 1.495 ms] 105.731 µs (7.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.336 ms, 1.375 ms] -
appsec 1.724 ms [1.701 ms, 1.747 ms] 368.743 µs (27.2%)
appsec_no_iast 1.735 ms [1.71 ms, 1.76 ms] 379.495 µs (28.0%)
iast 1.468 ms [1.445 ms, 1.49 ms] 112.334 µs (8.3%)
profiling 1.48 ms [1.456 ms, 1.505 ms] 124.907 µs (9.2%)
tracing 1.473 ms [1.448 ms, 1.498 ms] 117.809 µs (8.7%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~a8c16d0184, baseline=1.41.0-SNAPSHOT~e5e542705f
    dateFormat X
    axisFormat %s
section baseline
no_agent (382.452 µs) : 353, 412
.   : milestone, 382,
iast (486.632 µs) : 466, 508
.   : milestone, 487,
iast_FULL (564.939 µs) : 544, 586
.   : milestone, 565,
iast_GLOBAL (521.721 µs) : 499, 544
.   : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (493.731 µs) : 473, 515
.   : milestone, 494,
iast_INACTIVE (454.458 µs) : 434, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (475.412 µs) : 454, 497
.   : milestone, 475,
tracing (452.206 µs) : 431, 473
.   : milestone, 452,
section candidate
no_agent (377.894 µs) : 358, 398
.   : milestone, 378,
iast (497.679 µs) : 476, 519
.   : milestone, 498,
iast_FULL (561.522 µs) : 540, 583
.   : milestone, 562,
iast_GLOBAL (515.511 µs) : 493, 538
.   : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (485.659 µs) : 464, 507
.   : milestone, 486,
iast_INACTIVE (454.196 µs) : 433, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (485.556 µs) : 464, 507
.   : milestone, 486,
tracing (449.102 µs) : 428, 470
.   : milestone, 449,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 382.452 µs [352.555 µs, 412.35 µs] -
iast 486.632 µs [465.533 µs, 507.731 µs] 104.179 µs (27.2%)
iast_FULL 564.939 µs [543.72 µs, 586.158 µs] 182.486 µs (47.7%)
iast_GLOBAL 521.721 µs [499.056 µs, 544.387 µs] 139.269 µs (36.4%)
iast_HARDCODED_SECRET_DISABLED 493.731 µs [472.703 µs, 514.76 µs] 111.279 µs (29.1%)
iast_INACTIVE 454.458 µs [433.561 µs, 475.355 µs] 72.005 µs (18.8%)
iast_TELEMETRY_OFF 475.412 µs [454.229 µs, 496.595 µs] 92.959 µs (24.3%)
tracing 452.206 µs [431.177 µs, 473.235 µs] 69.753 µs (18.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.894 µs [358.222 µs, 397.566 µs] -
iast 497.679 µs [476.208 µs, 519.151 µs] 119.785 µs (31.7%)
iast_FULL 561.522 µs [540.357 µs, 582.686 µs] 183.627 µs (48.6%)
iast_GLOBAL 515.511 µs [493.36 µs, 537.662 µs] 137.617 µs (36.4%)
iast_HARDCODED_SECRET_DISABLED 485.659 µs [464.419 µs, 506.898 µs] 107.764 µs (28.5%)
iast_INACTIVE 454.196 µs [433.104 µs, 475.289 µs] 76.302 µs (20.2%)
iast_TELEMETRY_OFF 485.556 µs [464.091 µs, 507.022 µs] 107.662 µs (28.5%)
tracing 449.102 µs [428.197 µs, 470.008 µs] 71.208 µs (18.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/revert-http-client-sharing
git_commit_date 1728049518 1728052214
git_commit_sha e5e5427 a8c16d0
release_version 1.41.0-SNAPSHOT~e5e542705f 1.41.0-SNAPSHOT~a8c16d0184
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1728054079 1728054079
ci_job_id 661861485 661861485
ci_pipeline_id 45834804 45834804
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~a8c16d0184, baseline=1.41.0-SNAPSHOT~e5e542705f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.445 s) : 15445000, 15445000
.   : milestone, 15445000,
appsec (15.389 s) : 15389000, 15389000
.   : milestone, 15389000,
iast (18.936 s) : 18936000, 18936000
.   : milestone, 18936000,
iast_GLOBAL (18.001 s) : 18001000, 18001000
.   : milestone, 18001000,
profiling (15.015 s) : 15015000, 15015000
.   : milestone, 15015000,
tracing (15.197 s) : 15197000, 15197000
.   : milestone, 15197000,
section candidate
no_agent (14.88 s) : 14880000, 14880000
.   : milestone, 14880000,
appsec (15.332 s) : 15332000, 15332000
.   : milestone, 15332000,
iast (18.722 s) : 18722000, 18722000
.   : milestone, 18722000,
iast_GLOBAL (18.059 s) : 18059000, 18059000
.   : milestone, 18059000,
profiling (15.112 s) : 15112000, 15112000
.   : milestone, 15112000,
tracing (15.293 s) : 15293000, 15293000
.   : milestone, 15293000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.445 s [15.445 s, 15.445 s] -
appsec 15.389 s [15.389 s, 15.389 s] -56.0 ms (-0.4%)
iast 18.936 s [18.936 s, 18.936 s] 3.491 s (22.6%)
iast_GLOBAL 18.001 s [18.001 s, 18.001 s] 2.556 s (16.5%)
profiling 15.015 s [15.015 s, 15.015 s] -430.0 ms (-2.8%)
tracing 15.197 s [15.197 s, 15.197 s] -248.0 ms (-1.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.88 s [14.88 s, 14.88 s] -
appsec 15.332 s [15.332 s, 15.332 s] 452.0 ms (3.0%)
iast 18.722 s [18.722 s, 18.722 s] 3.842 s (25.8%)
iast_GLOBAL 18.059 s [18.059 s, 18.059 s] 3.179 s (21.4%)
profiling 15.112 s [15.112 s, 15.112 s] 232.0 ms (1.6%)
tracing 15.293 s [15.293 s, 15.293 s] 413.0 ms (2.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~a8c16d0184, baseline=1.41.0-SNAPSHOT~e5e542705f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.333 ms) : 2293, 2374
.   : milestone, 2333,
iast (2.083 ms) : 2031, 2135
.   : milestone, 2083,
iast_GLOBAL (2.127 ms) : 2075, 2179
.   : milestone, 2127,
profiling (1.953 ms) : 1912, 1994
.   : milestone, 1953,
tracing (1.917 ms) : 1878, 1956
.   : milestone, 1917,
section candidate
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (2.33 ms) : 2290, 2370
.   : milestone, 2330,
iast (2.094 ms) : 2042, 2145
.   : milestone, 2094,
iast_GLOBAL (2.125 ms) : 2073, 2176
.   : milestone, 2125,
profiling (1.956 ms) : 1916, 1997
.   : milestone, 1956,
tracing (1.923 ms) : 1884, 1962
.   : milestone, 1923,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.461 ms, 1.484 ms] -
appsec 2.333 ms [2.293 ms, 2.374 ms] 860.991 µs (58.5%)
iast 2.083 ms [2.031 ms, 2.135 ms] 610.496 µs (41.5%)
iast_GLOBAL 2.127 ms [2.075 ms, 2.179 ms] 654.782 µs (44.5%)
profiling 1.953 ms [1.912 ms, 1.994 ms] 480.804 µs (32.7%)
tracing 1.917 ms [1.878 ms, 1.956 ms] 444.583 µs (30.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.465 ms, 1.488 ms] -
appsec 2.33 ms [2.29 ms, 2.37 ms] 853.682 µs (57.8%)
iast 2.094 ms [2.042 ms, 2.145 ms] 617.604 µs (41.8%)
iast_GLOBAL 2.125 ms [2.073 ms, 2.176 ms] 648.564 µs (43.9%)
profiling 1.956 ms [1.916 ms, 1.997 ms] 480.132 µs (32.5%)
tracing 1.923 ms [1.884 ms, 1.962 ms] 446.76 µs (30.3%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review October 7, 2024 09:09
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner October 7, 2024 09:09
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 5a70635 into master Oct 7, 2024
106 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/revert-http-client-sharing branch October 7, 2024 15:24
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmarchenko anmarchenko anmarchenko approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nikita-tkachenko-datadog @anmarchenko