Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid emission of endpoint events for client and producer root spans #7732

Merged
merged 1 commit into from
Oct 8, 2024
Merged

avoid emission of endpoint events for client and producer root spans #7732

merged 1 commit into from
Oct 8, 2024

Conversation

richardstartin
Copy link
Member

@richardstartin richardstartin commented Oct 4, 2024 •
edited by jira bot
Loading

What Does This Do

We emit endpoint events for any local root span, but the local root span isn't necessarily associated with an endpoint. If tracing context propagation breaks for some reason, or if instrumented client code is otherwise invoked in the absence of a trace, we can end up with the profiler reporting things like SQL queries as "endpoints." These aren't very useful for analysis, and can also mean using a lot of native memory to store them in a constant pool, so this change explicitly prevents endpoint profiling when the root span is a client or producer span.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: PROF-10666

@richardstartin richardstartin requested a review from a team as a code owner October 4, 2024 11:10
@richardstartin richardstartin force-pushed the rgs/suppress-client-endpoint-events branch from c5c1bd2 to 63319bf Compare October 4, 2024 11:12
@pr-commenter
Copy link

pr-commenter bot commented Oct 4, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/suppress-client-endpoint-events
git_commit_date 1728032175 1728040329
git_commit_sha 9db260f 63319bf
release_version 1.41.0-SNAPSHOT~9db260fd16 1.41.0-SNAPSHOT~63319bfc15
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728042778 1728042778
ci_job_id 661533404 661533404
ci_pipeline_id 45811524 45811524
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~63319bfc15, baseline=1.41.0-SNAPSHOT~9db260fd16

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1070975
Total [baseline] (10.424 s) : 0, 10423551
Agent [candidate] (1.083 s) : 0, 1082737
Total [candidate] (10.446 s) : 0, 10446126
section appsec
Agent [baseline] (1.207 s) : 0, 1207059
Total [baseline] (10.615 s) : 0, 10614992
Agent [candidate] (1.208 s) : 0, 1208120
Total [candidate] (10.715 s) : 0, 10714811
section iast
Agent [baseline] (1.198 s) : 0, 1198420
Total [baseline] (10.919 s) : 0, 10919032
Agent [candidate] (1.205 s) : 0, 1204939
Total [candidate] (10.873 s) : 0, 10872812
section profiling
Agent [baseline] (1.269 s) : 0, 1269265
Total [baseline] (10.621 s) : 0, 10621402
Agent [candidate] (1.27 s) : 0, 1269684
Total [candidate] (10.617 s) : 0, 10616863
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.207 s 136.084 ms (12.7%)
Agent iast 1.198 s 127.445 ms (11.9%)
Agent profiling 1.269 s 198.291 ms (18.5%)
Total tracing 10.424 s -
Total appsec 10.615 s 191.441 ms (1.8%)
Total iast 10.919 s 495.481 ms (4.8%)
Total profiling 10.621 s 197.851 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent appsec 1.208 s 125.383 ms (11.6%)
Agent iast 1.205 s 122.202 ms (11.3%)
Agent profiling 1.27 s 186.947 ms (17.3%)
Total tracing 10.446 s -
Total appsec 10.715 s 268.685 ms (2.6%)
Total iast 10.873 s 426.686 ms (4.1%)
Total profiling 10.617 s 170.738 ms (1.6%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~63319bfc15, baseline=1.41.0-SNAPSHOT~9db260fd16

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.063 ms) : 0, 683063
BytebuddyAgent [candidate] (691.588 ms) : 0, 691588
GlobalTracer [baseline] (311.814 ms) : 0, 311814
GlobalTracer [candidate] (314.512 ms) : 0, 314512
AppSec [baseline] (53.994 ms) : 0, 53994
AppSec [candidate] (54.333 ms) : 0, 54333
Remote Config [baseline] (654.461 µs) : 0, 654
Remote Config [candidate] (659.524 µs) : 0, 660
Telemetry [baseline] (7.683 ms) : 0, 7683
Telemetry [candidate] (7.702 ms) : 0, 7702
section appsec
BytebuddyAgent [baseline] (701.223 ms) : 0, 701223
BytebuddyAgent [candidate] (702.342 ms) : 0, 702342
GlobalTracer [baseline] (309.046 ms) : 0, 309046
GlobalTracer [candidate] (309.302 ms) : 0, 309302
AppSec [baseline] (162.984 ms) : 0, 162984
AppSec [candidate] (162.585 ms) : 0, 162585
Remote Config [baseline] (641.213 µs) : 0, 641
Remote Config [candidate] (647.37 µs) : 0, 647
Telemetry [baseline] (9.633 ms) : 0, 9633
Telemetry [candidate] (8.933 ms) : 0, 8933
IAST [baseline] (19.474 ms) : 0, 19474
IAST [candidate] (20.959 ms) : 0, 20959
section iast
BytebuddyAgent [baseline] (797.272 ms) : 0, 797272
BytebuddyAgent [candidate] (802.417 ms) : 0, 802417
GlobalTracer [baseline] (300.994 ms) : 0, 300994
GlobalTracer [candidate] (302.265 ms) : 0, 302265
AppSec [baseline] (53.385 ms) : 0, 53385
AppSec [candidate] (55.703 ms) : 0, 55703
Remote Config [baseline] (610.435 µs) : 0, 610
Remote Config [candidate] (609.853 µs) : 0, 610
Telemetry [baseline] (7.112 ms) : 0, 7112
Telemetry [candidate] (7.988 ms) : 0, 7988
IAST [baseline] (25.282 ms) : 0, 25282
IAST [candidate] (22.08 ms) : 0, 22080
section profiling
BytebuddyAgent [baseline] (675.329 ms) : 0, 675329
BytebuddyAgent [candidate] (676.601 ms) : 0, 676601
GlobalTracer [baseline] (394.38 ms) : 0, 394380
GlobalTracer [candidate] (394.877 ms) : 0, 394877
AppSec [baseline] (55.193 ms) : 0, 55193
AppSec [candidate] (54.636 ms) : 0, 54636
Remote Config [baseline] (666.574 µs) : 0, 667
Remote Config [candidate] (658.281 µs) : 0, 658
Telemetry [baseline] (7.522 ms) : 0, 7522
Telemetry [candidate] (7.445 ms) : 0, 7445
ProfilingAgent [baseline] (97.488 ms) : 0, 97488
ProfilingAgent [candidate] (96.601 ms) : 0, 96601
Profiling [baseline] (97.512 ms) : 0, 97512
Profiling [candidate] (96.626 ms) : 0, 96626
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~63319bfc15, baseline=1.41.0-SNAPSHOT~9db260fd16

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084355
Total [baseline] (8.593 s) : 0, 8592929
Agent [candidate] (1.071 s) : 0, 1070567
Total [candidate] (8.555 s) : 0, 8555094
section iast
Agent [baseline] (1.205 s) : 0, 1205099
Total [baseline] (9.118 s) : 0, 9117607
Agent [candidate] (1.199 s) : 0, 1198531
Total [candidate] (9.108 s) : 0, 9107965
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.207 s) : 0, 1206848
Total [baseline] (9.096 s) : 0, 9096258
Agent [candidate] (1.198 s) : 0, 1198383
Total [candidate] (9.12 s) : 0, 9120364
section iast_TELEMETRY_OFF
Agent [baseline] (1.203 s) : 0, 1202686
Total [baseline] (9.133 s) : 0, 9133267
Agent [candidate] (1.196 s) : 0, 1195730
Total [candidate] (9.106 s) : 0, 9105976
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent iast 1.205 s 120.744 ms (11.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.207 s 122.493 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.203 s 118.331 ms (10.9%)
Total tracing 8.593 s -
Total iast 9.118 s 524.678 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.096 s 503.329 ms (5.9%)
Total iast_TELEMETRY_OFF 9.133 s 540.338 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent iast 1.199 s 127.964 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.198 s 127.816 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.196 s 125.163 ms (11.7%)
Total tracing 8.555 s -
Total iast 9.108 s 552.871 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.12 s 565.271 ms (6.6%)
Total iast_TELEMETRY_OFF 9.106 s 550.883 ms (6.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~63319bfc15, baseline=1.41.0-SNAPSHOT~9db260fd16

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.204 ms) : 0, 693204
BytebuddyAgent [candidate] (682.459 ms) : 0, 682459
GlobalTracer [baseline] (314.555 ms) : 0, 314555
GlobalTracer [candidate] (311.803 ms) : 0, 311803
AppSec [baseline] (54.173 ms) : 0, 54173
AppSec [candidate] (54.187 ms) : 0, 54187
Remote Config [baseline] (669.852 µs) : 0, 670
Remote Config [candidate] (663.328 µs) : 0, 663
Telemetry [baseline] (7.771 ms) : 0, 7771
Telemetry [candidate] (7.656 ms) : 0, 7656
section iast
BytebuddyAgent [baseline] (802.533 ms) : 0, 802533
BytebuddyAgent [candidate] (797.761 ms) : 0, 797761
GlobalTracer [baseline] (302.554 ms) : 0, 302554
GlobalTracer [candidate] (300.491 ms) : 0, 300491
AppSec [baseline] (54.922 ms) : 0, 54922
AppSec [candidate] (53.493 ms) : 0, 53493
Remote Config [baseline] (597.603 µs) : 0, 598
Remote Config [candidate] (612.982 µs) : 0, 613
Telemetry [baseline] (7.064 ms) : 0, 7064
Telemetry [candidate] (7.083 ms) : 0, 7083
IAST [baseline] (23.529 ms) : 0, 23529
IAST [candidate] (25.222 ms) : 0, 25222
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (803.518 ms) : 0, 803518
BytebuddyAgent [candidate] (797.052 ms) : 0, 797052
GlobalTracer [baseline] (302.418 ms) : 0, 302418
GlobalTracer [candidate] (300.887 ms) : 0, 300887
AppSec [baseline] (56.088 ms) : 0, 56088
AppSec [candidate] (54.968 ms) : 0, 54968
Remote Config [baseline] (613.694 µs) : 0, 614
Remote Config [candidate] (619.397 µs) : 0, 619
Telemetry [baseline] (7.178 ms) : 0, 7178
Telemetry [candidate] (7.109 ms) : 0, 7109
IAST [baseline] (23.077 ms) : 0, 23077
IAST [candidate] (23.868 ms) : 0, 23868
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.941 ms) : 0, 799941
BytebuddyAgent [candidate] (795.297 ms) : 0, 795297
GlobalTracer [baseline] (302.022 ms) : 0, 302022
GlobalTracer [candidate] (300.616 ms) : 0, 300616
AppSec [baseline] (53.746 ms) : 0, 53746
AppSec [candidate] (55.711 ms) : 0, 55711
Remote Config [baseline] (692.646 µs) : 0, 693
Remote Config [candidate] (658.921 µs) : 0, 659
Telemetry [baseline] (7.064 ms) : 0, 7064
Telemetry [candidate] (7.009 ms) : 0, 7009
IAST [baseline] (25.276 ms) : 0, 25276
IAST [candidate] (22.56 ms) : 0, 22560
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-04T11:23:30 2024-10-04T11:30:20
git_branch master rgs/suppress-client-endpoint-events
git_commit_date 1728032175 1728040329
git_commit_sha 9db260f 63319bf
release_version 1.41.0-SNAPSHOT~9db260fd16 1.41.0-SNAPSHOT~63319bfc15
start_time 2024-10-04T11:23:17 2024-10-04T11:30:06
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728041765 1728041765
ci_job_id 661533405 661533405
ci_pipeline_id 45811524 45811524
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~63319bfc15, baseline=1.41.0-SNAPSHOT~9db260fd16
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.32 ms) : 1301, 1339
.   : milestone, 1320,
appsec (1.703 ms) : 1679, 1728
.   : milestone, 1703,
appsec_no_iast (1.711 ms) : 1687, 1735
.   : milestone, 1711,
iast (1.483 ms) : 1461, 1505
.   : milestone, 1483,
profiling (1.469 ms) : 1444, 1493
.   : milestone, 1469,
tracing (1.482 ms) : 1458, 1505
.   : milestone, 1482,
section candidate
no_agent (1.341 ms) : 1321, 1360
.   : milestone, 1341,
appsec (1.716 ms) : 1693, 1739
.   : milestone, 1716,
appsec_no_iast (1.722 ms) : 1697, 1746
.   : milestone, 1722,
iast (1.472 ms) : 1450, 1494
.   : milestone, 1472,
profiling (1.477 ms) : 1453, 1502
.   : milestone, 1477,
tracing (1.476 ms) : 1451, 1500
.   : milestone, 1476,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.32 ms [1.301 ms, 1.339 ms] -
appsec 1.703 ms [1.679 ms, 1.728 ms] 383.438 µs (29.1%)
appsec_no_iast 1.711 ms [1.687 ms, 1.735 ms] 390.988 µs (29.6%)
iast 1.483 ms [1.461 ms, 1.505 ms] 162.969 µs (12.3%)
profiling 1.469 ms [1.444 ms, 1.493 ms] 148.851 µs (11.3%)
tracing 1.482 ms [1.458 ms, 1.505 ms] 162.024 µs (12.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.341 ms [1.321 ms, 1.36 ms] -
appsec 1.716 ms [1.693 ms, 1.739 ms] 375.475 µs (28.0%)
appsec_no_iast 1.722 ms [1.697 ms, 1.746 ms] 380.672 µs (28.4%)
iast 1.472 ms [1.45 ms, 1.494 ms] 130.885 µs (9.8%)
profiling 1.477 ms [1.453 ms, 1.502 ms] 136.379 µs (10.2%)
tracing 1.476 ms [1.451 ms, 1.5 ms] 134.658 µs (10.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~63319bfc15, baseline=1.41.0-SNAPSHOT~9db260fd16
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.888 µs) : 353, 393
.   : milestone, 373,
iast (480.338 µs) : 459, 502
.   : milestone, 480,
iast_FULL (550.644 µs) : 529, 572
.   : milestone, 551,
iast_GLOBAL (506.65 µs) : 486, 528
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (476.127 µs) : 455, 497
.   : milestone, 476,
iast_INACTIVE (455.718 µs) : 434, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (471.749 µs) : 450, 493
.   : milestone, 472,
tracing (444.019 µs) : 423, 465
.   : milestone, 444,
section candidate
no_agent (373.03 µs) : 354, 393
.   : milestone, 373,
iast (479.563 µs) : 458, 501
.   : milestone, 480,
iast_FULL (547.637 µs) : 526, 569
.   : milestone, 548,
iast_GLOBAL (523.493 µs) : 500, 547
.   : milestone, 523,
iast_HARDCODED_SECRET_DISABLED (479.924 µs) : 459, 501
.   : milestone, 480,
iast_INACTIVE (445.508 µs) : 425, 466
.   : milestone, 446,
iast_TELEMETRY_OFF (471.56 µs) : 450, 493
.   : milestone, 472,
tracing (440.357 µs) : 420, 461
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.888 µs [352.96 µs, 392.817 µs] -
iast 480.338 µs [459.097 µs, 501.579 µs] 107.45 µs (28.8%)
iast_FULL 550.644 µs [529.364 µs, 571.923 µs] 177.755 µs (47.7%)
iast_GLOBAL 506.65 µs [485.633 µs, 527.667 µs] 133.762 µs (35.9%)
iast_HARDCODED_SECRET_DISABLED 476.127 µs [454.849 µs, 497.406 µs] 103.239 µs (27.7%)
iast_INACTIVE 455.718 µs [434.099 µs, 477.337 µs] 82.829 µs (22.2%)
iast_TELEMETRY_OFF 471.749 µs [450.212 µs, 493.286 µs] 98.861 µs (26.5%)
tracing 444.019 µs [422.85 µs, 465.188 µs] 71.131 µs (19.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.03 µs [353.533 µs, 392.527 µs] -
iast 479.563 µs [458.354 µs, 500.772 µs] 106.533 µs (28.6%)
iast_FULL 547.637 µs [526.291 µs, 568.984 µs] 174.607 µs (46.8%)
iast_GLOBAL 523.493 µs [499.676 µs, 547.311 µs] 150.463 µs (40.3%)
iast_HARDCODED_SECRET_DISABLED 479.924 µs [458.635 µs, 501.214 µs] 106.894 µs (28.7%)
iast_INACTIVE 445.508 µs [424.734 µs, 466.282 µs] 72.478 µs (19.4%)
iast_TELEMETRY_OFF 471.56 µs [450.312 µs, 492.809 µs] 98.53 µs (26.4%)
tracing 440.357 µs [419.889 µs, 460.825 µs] 67.327 µs (18.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/suppress-client-endpoint-events
git_commit_date 1728032175 1728040329
git_commit_sha 9db260f 63319bf
release_version 1.41.0-SNAPSHOT~9db260fd16 1.41.0-SNAPSHOT~63319bfc15
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1728042313 1728042313
ci_job_id 661533406 661533406
ci_pipeline_id 45811524 45811524
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~63319bfc15, baseline=1.41.0-SNAPSHOT~9db260fd16
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1482
.   : milestone, 1470,
appsec (2.322 ms) : 2282, 2363
.   : milestone, 2322,
iast (2.078 ms) : 2026, 2129
.   : milestone, 2078,
iast_GLOBAL (2.109 ms) : 2058, 2160
.   : milestone, 2109,
profiling (1.95 ms) : 1908, 1992
.   : milestone, 1950,
tracing (1.913 ms) : 1874, 1952
.   : milestone, 1913,
section candidate
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.333 ms) : 2292, 2373
.   : milestone, 2333,
iast (2.067 ms) : 2015, 2118
.   : milestone, 2067,
iast_GLOBAL (2.122 ms) : 2071, 2174
.   : milestone, 2122,
profiling (1.948 ms) : 1907, 1990
.   : milestone, 1948,
tracing (1.917 ms) : 1878, 1957
.   : milestone, 1917,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.458 ms, 1.482 ms] -
appsec 2.322 ms [2.282 ms, 2.363 ms] 852.188 µs (58.0%)
iast 2.078 ms [2.026 ms, 2.129 ms] 607.684 µs (41.3%)
iast_GLOBAL 2.109 ms [2.058 ms, 2.16 ms] 639.001 µs (43.5%)
profiling 1.95 ms [1.908 ms, 1.992 ms] 479.805 µs (32.6%)
tracing 1.913 ms [1.874 ms, 1.952 ms] 442.921 µs (30.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 2.333 ms [2.292 ms, 2.373 ms] 861.101 µs (58.5%)
iast 2.067 ms [2.015 ms, 2.118 ms] 594.836 µs (40.4%)
iast_GLOBAL 2.122 ms [2.071 ms, 2.174 ms] 650.802 µs (44.2%)
profiling 1.948 ms [1.907 ms, 1.99 ms] 476.665 µs (32.4%)
tracing 1.917 ms [1.878 ms, 1.957 ms] 445.666 µs (30.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~63319bfc15, baseline=1.41.0-SNAPSHOT~9db260fd16
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.134 s) : 15134000, 15134000
.   : milestone, 15134000,
appsec (15.398 s) : 15398000, 15398000
.   : milestone, 15398000,
iast (18.673 s) : 18673000, 18673000
.   : milestone, 18673000,
iast_GLOBAL (18.129 s) : 18129000, 18129000
.   : milestone, 18129000,
profiling (15.247 s) : 15247000, 15247000
.   : milestone, 15247000,
tracing (15.275 s) : 15275000, 15275000
.   : milestone, 15275000,
section candidate
no_agent (15.187 s) : 15187000, 15187000
.   : milestone, 15187000,
appsec (15.333 s) : 15333000, 15333000
.   : milestone, 15333000,
iast (18.871 s) : 18871000, 18871000
.   : milestone, 18871000,
iast_GLOBAL (17.805 s) : 17805000, 17805000
.   : milestone, 17805000,
profiling (15.84 s) : 15840000, 15840000
.   : milestone, 15840000,
tracing (15.408 s) : 15408000, 15408000
.   : milestone, 15408000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.134 s [15.134 s, 15.134 s] -
appsec 15.398 s [15.398 s, 15.398 s] 264.0 ms (1.7%)
iast 18.673 s [18.673 s, 18.673 s] 3.539 s (23.4%)
iast_GLOBAL 18.129 s [18.129 s, 18.129 s] 2.995 s (19.8%)
profiling 15.247 s [15.247 s, 15.247 s] 113.0 ms (0.7%)
tracing 15.275 s [15.275 s, 15.275 s] 141.0 ms (0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.187 s [15.187 s, 15.187 s] -
appsec 15.333 s [15.333 s, 15.333 s] 146.0 ms (1.0%)
iast 18.871 s [18.871 s, 18.871 s] 3.684 s (24.3%)
iast_GLOBAL 17.805 s [17.805 s, 17.805 s] 2.618 s (17.2%)
profiling 15.84 s [15.84 s, 15.84 s] 653.0 ms (4.3%)
tracing 15.408 s [15.408 s, 15.408 s] 221.0 ms (1.5%)

manuel-alvarez-alvarez
manuel-alvarez-alvarez approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardstartin richardstartin merged commit d4ec19e into master Oct 8, 2024
103 checks passed
@richardstartin richardstartin deleted the rgs/suppress-client-endpoint-events branch October 8, 2024 16:23
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 8, 2024
@nayeem-kamal nayeem-kamal added the comp: core Tracer core label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

Assignees
No one assigned
Labels
comp: core Tracer core
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
3 participants
@richardstartin @manuel-alvarez-alvarez @nayeem-kamal