Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DD_TRACE_<INTEGRATION>_ENABLED #7718

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Support DD_TRACE_<INTEGRATION>_ENABLED #7718

merged 5 commits into from
Oct 17, 2024

Conversation

mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Oct 2, 2024 •
edited
Loading

What Does This Do

Adds support for disabling integrations via DD_TRACE_<integration-name>_ENABLED envvar. The new trace.<name>.enabled config will take precedence over trace.integration.<name>.enabled and integration.<name>.enabled settings in that order.

Motivation

Config Consistency effort (RFC)

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mtoffl01 mtoffl01 changed the title Support DD_<INTEGRATION>_ENABLED Support DD_TRACE_<INTEGRATION>_ENABLED Oct 3, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 3, 2024 •
edited
Loading

Benchmarks

Startup

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-17T13:57:00 2024-10-17T14:03:53
git_branch master mtoff/dd-integration-enabled
git_commit_date 1729172203 1729172902
git_commit_sha 1624ee2 850259a
release_version 1.41.0-SNAPSHOT~1624ee2bae 1.41.0-SNAPSHOT~850259a249
start_time 2024-10-17T13:56:47 2024-10-17T14:03:39
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729174179 1729174179
ci_job_id 675425058 675425058
ci_pipeline_id 46818184 46818184
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~850259a249, baseline=1.41.0-SNAPSHOT~1624ee2bae
    dateFormat X
    axisFormat %s
section baseline
no_agent (375.76 µs) : 355, 397
.   : milestone, 376,
iast (482.382 µs) : 461, 504
.   : milestone, 482,
iast_FULL (551.08 µs) : 530, 572
.   : milestone, 551,
iast_GLOBAL (519.275 µs) : 497, 542
.   : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (482.151 µs) : 460, 504
.   : milestone, 482,
iast_INACTIVE (446.771 µs) : 426, 467
.   : milestone, 447,
iast_TELEMETRY_OFF (474.99 µs) : 454, 496
.   : milestone, 475,
tracing (442.256 µs) : 422, 463
.   : milestone, 442,
section candidate
no_agent (373.095 µs) : 353, 394
.   : milestone, 373,
iast (487.858 µs) : 466, 510
.   : milestone, 488,
iast_FULL (556.059 µs) : 534, 578
.   : milestone, 556,
iast_GLOBAL (515.164 µs) : 494, 536
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (486.275 µs) : 465, 507
.   : milestone, 486,
iast_INACTIVE (454.486 µs) : 433, 476
.   : milestone, 454,
iast_TELEMETRY_OFF (472.792 µs) : 451, 494
.   : milestone, 473,
tracing (450.446 µs) : 430, 471
.   : milestone, 450,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.76 µs [354.74 µs, 396.78 µs] -
iast 482.382 µs [461.028 µs, 503.736 µs] 106.621 µs (28.4%)
iast_FULL 551.08 µs [529.876 µs, 572.283 µs] 175.32 µs (46.7%)
iast_GLOBAL 519.275 µs [496.989 µs, 541.562 µs] 143.515 µs (38.2%)
iast_HARDCODED_SECRET_DISABLED 482.151 µs [460.436 µs, 503.867 µs] 106.391 µs (28.3%)
iast_INACTIVE 446.771 µs [426.227 µs, 467.315 µs] 71.011 µs (18.9%)
iast_TELEMETRY_OFF 474.99 µs [454.046 µs, 495.934 µs] 99.23 µs (26.4%)
tracing 442.256 µs [421.556 µs, 462.955 µs] 66.495 µs (17.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.095 µs [352.676 µs, 393.514 µs] -
iast 487.858 µs [465.838 µs, 509.879 µs] 114.763 µs (30.8%)
iast_FULL 556.059 µs [533.992 µs, 578.126 µs] 182.964 µs (49.0%)
iast_GLOBAL 515.164 µs [493.851 µs, 536.476 µs] 142.068 µs (38.1%)
iast_HARDCODED_SECRET_DISABLED 486.275 µs [465.081 µs, 507.47 µs] 113.18 µs (30.3%)
iast_INACTIVE 454.486 µs [433.08 µs, 475.893 µs] 81.391 µs (21.8%)
iast_TELEMETRY_OFF 472.792 µs [451.329 µs, 494.256 µs] 99.697 µs (26.7%)
tracing 450.446 µs [429.761 µs, 471.131 µs] 77.351 µs (20.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~850259a249, baseline=1.41.0-SNAPSHOT~1624ee2bae
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.351 ms) : 1331, 1370
.   : milestone, 1351,
appsec (1.724 ms) : 1699, 1749
.   : milestone, 1724,
appsec_no_iast (1.741 ms) : 1717, 1765
.   : milestone, 1741,
iast (1.495 ms) : 1472, 1517
.   : milestone, 1495,
profiling (1.455 ms) : 1432, 1477
.   : milestone, 1455,
tracing (1.484 ms) : 1459, 1509
.   : milestone, 1484,
section candidate
no_agent (1.338 ms) : 1319, 1357
.   : milestone, 1338,
appsec (1.703 ms) : 1680, 1727
.   : milestone, 1703,
appsec_no_iast (1.735 ms) : 1711, 1758
.   : milestone, 1735,
iast (1.482 ms) : 1459, 1505
.   : milestone, 1482,
profiling (1.484 ms) : 1462, 1506
.   : milestone, 1484,
tracing (1.457 ms) : 1433, 1481
.   : milestone, 1457,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.351 ms [1.331 ms, 1.37 ms] -
appsec 1.724 ms [1.699 ms, 1.749 ms] 373.466 µs (27.7%)
appsec_no_iast 1.741 ms [1.717 ms, 1.765 ms] 390.506 µs (28.9%)
iast 1.495 ms [1.472 ms, 1.517 ms] 143.903 µs (10.7%)
profiling 1.455 ms [1.432 ms, 1.477 ms] 104.063 µs (7.7%)
tracing 1.484 ms [1.459 ms, 1.509 ms] 133.84 µs (9.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.338 ms [1.319 ms, 1.357 ms] -
appsec 1.703 ms [1.68 ms, 1.727 ms] 365.208 µs (27.3%)
appsec_no_iast 1.735 ms [1.711 ms, 1.758 ms] 396.624 µs (29.6%)
iast 1.482 ms [1.459 ms, 1.505 ms] 143.41 µs (10.7%)
profiling 1.484 ms [1.462 ms, 1.506 ms] 145.764 µs (10.9%)
tracing 1.457 ms [1.433 ms, 1.481 ms] 118.864 µs (8.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mtoff/dd-integration-enabled
git_commit_date 1729172203 1729172902
git_commit_sha 1624ee2 850259a
release_version 1.41.0-SNAPSHOT~1624ee2bae 1.41.0-SNAPSHOT~850259a249
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1729174710 1729174710
ci_job_id 675425061 675425061
ci_pipeline_id 46818184 46818184
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~850259a249, baseline=1.41.0-SNAPSHOT~1624ee2bae
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.044 s) : 15044000, 15044000
.   : milestone, 15044000,
appsec (15.266 s) : 15266000, 15266000
.   : milestone, 15266000,
iast (18.956 s) : 18956000, 18956000
.   : milestone, 18956000,
iast_GLOBAL (17.804 s) : 17804000, 17804000
.   : milestone, 17804000,
profiling (14.882 s) : 14882000, 14882000
.   : milestone, 14882000,
tracing (15.109 s) : 15109000, 15109000
.   : milestone, 15109000,
section candidate
no_agent (15.244 s) : 15244000, 15244000
.   : milestone, 15244000,
appsec (15.028 s) : 15028000, 15028000
.   : milestone, 15028000,
iast (18.569 s) : 18569000, 18569000
.   : milestone, 18569000,
iast_GLOBAL (18.05 s) : 18050000, 18050000
.   : milestone, 18050000,
profiling (15.733 s) : 15733000, 15733000
.   : milestone, 15733000,
tracing (15.086 s) : 15086000, 15086000
.   : milestone, 15086000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.044 s [15.044 s, 15.044 s] -
appsec 15.266 s [15.266 s, 15.266 s] 222.0 ms (1.5%)
iast 18.956 s [18.956 s, 18.956 s] 3.912 s (26.0%)
iast_GLOBAL 17.804 s [17.804 s, 17.804 s] 2.76 s (18.3%)
profiling 14.882 s [14.882 s, 14.882 s] -162.0 ms (-1.1%)
tracing 15.109 s [15.109 s, 15.109 s] 65.0 ms (0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.244 s [15.244 s, 15.244 s] -
appsec 15.028 s [15.028 s, 15.028 s] -216.0 ms (-1.4%)
iast 18.569 s [18.569 s, 18.569 s] 3.325 s (21.8%)
iast_GLOBAL 18.05 s [18.05 s, 18.05 s] 2.806 s (18.4%)
profiling 15.733 s [15.733 s, 15.733 s] 489.0 ms (3.2%)
tracing 15.086 s [15.086 s, 15.086 s] -158.0 ms (-1.0%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~850259a249, baseline=1.41.0-SNAPSHOT~1624ee2bae
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.457 ms) : 1445, 1468
.   : milestone, 1457,
appsec (2.3 ms) : 2260, 2340
.   : milestone, 2300,
iast (2.061 ms) : 2009, 2113
.   : milestone, 2061,
iast_GLOBAL (2.102 ms) : 2050, 2153
.   : milestone, 2102,
profiling (1.918 ms) : 1876, 1959
.   : milestone, 1918,
tracing (1.902 ms) : 1863, 1942
.   : milestone, 1902,
section candidate
no_agent (1.462 ms) : 1451, 1474
.   : milestone, 1462,
appsec (2.321 ms) : 2280, 2362
.   : milestone, 2321,
iast (2.06 ms) : 2010, 2111
.   : milestone, 2060,
iast_GLOBAL (2.107 ms) : 2055, 2159
.   : milestone, 2107,
profiling (1.919 ms) : 1877, 1961
.   : milestone, 1919,
tracing (1.915 ms) : 1875, 1955
.   : milestone, 1915,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.445 ms, 1.468 ms] -
appsec 2.3 ms [2.26 ms, 2.34 ms] 843.284 µs (57.9%)
iast 2.061 ms [2.009 ms, 2.113 ms] 604.271 µs (41.5%)
iast_GLOBAL 2.102 ms [2.05 ms, 2.153 ms] 644.91 µs (44.3%)
profiling 1.918 ms [1.876 ms, 1.959 ms] 460.942 µs (31.6%)
tracing 1.902 ms [1.863 ms, 1.942 ms] 445.72 µs (30.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.474 ms] -
appsec 2.321 ms [2.28 ms, 2.362 ms] 858.482 µs (58.7%)
iast 2.06 ms [2.01 ms, 2.111 ms] 598.027 µs (40.9%)
iast_GLOBAL 2.107 ms [2.055 ms, 2.159 ms] 644.227 µs (44.1%)
profiling 1.919 ms [1.877 ms, 1.961 ms] 456.661 µs (31.2%)
tracing 1.915 ms [1.875 ms, 1.955 ms] 452.958 µs (31.0%)

@mtoffl01 mtoffl01 marked this pull request as ready for review October 3, 2024 18:50
@mtoffl01 mtoffl01 requested a review from a team as a code owner October 3, 2024 18:50
@mtoffl01 mtoffl01 requested a review from ygree October 3, 2024 18:50
@mtoffl01 mtoffl01 marked this pull request as draft October 4, 2024 15:06
@mtoffl01 mtoffl01 force-pushed the mtoff/dd-integration-enabled branch from 3135dac to ff768b5 Compare October 4, 2024 18:22
@mtoffl01 mtoffl01 marked this pull request as ready for review October 4, 2024 21:06
PerfectSlayer
PerfectSlayer approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice upgrade! There are no doubt left about the expected behavior 👍

@mtoffl01 mtoffl01 merged commit 666f2af into master Oct 17, 2024
104 checks passed
@mtoffl01 mtoffl01 deleted the mtoff/dd-integration-enabled branch October 17, 2024 16:57
@github-actions github-actions bot added this to the 1.42.0 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: core Tracer core type: enhancement
Projects
None yet
Milestone
1.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mtoffl01 @PerfectSlayer