Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for TRACE_HTTP_SERVER_ERROR_STATUSES #7716

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Add support for TRACE_HTTP_SERVER_ERROR_STATUSES #7716

merged 3 commits into from
Oct 4, 2024
+8 −4

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Oct 2, 2024 •
edited by jira bot
Loading

What Does This Do

Add support to handle TRACE_HTTP_SERVER_ERROR_STATUSES tag as well as the original HTTP_CLIENT_ERROR_STATUSES tag in efforts to be more consistent with the tags from other languages.

Motivation

Our goal is to make the implementation of configuration variables consistent for all languages as part of the config consistency effort listed in the following RFC.

Additional Notes

Contributor Checklist

Jira ticket: APMAPI-479

@pr-commenter
Copy link

pr-commenter bot commented Oct 2, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/server_error_statuses
git_commit_date 1727959073 1727964402
git_commit_sha 5a939c0 6732dfa
release_version 1.41.0-SNAPSHOT~5a939c03ae 1.41.0-SNAPSHOT~6732dfa2f9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727966586 1727966586
ci_job_id 660204126 660204126
ci_pipeline_id 45714131 45714131
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~6732dfa2f9, baseline=1.41.0-SNAPSHOT~5a939c03ae

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1072787
Total [baseline] (8.591 s) : 0, 8591365
Agent [candidate] (1.082 s) : 0, 1081730
Total [candidate] (8.601 s) : 0, 8600770
section iast
Agent [baseline] (1.199 s) : 0, 1199053
Total [baseline] (9.102 s) : 0, 9101505
Agent [candidate] (1.198 s) : 0, 1197745
Total [candidate] (9.132 s) : 0, 9131847
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.208 s) : 0, 1208433
Total [baseline] (9.115 s) : 0, 9115108
Agent [candidate] (1.2 s) : 0, 1200036
Total [candidate] (9.105 s) : 0, 9105002
section iast_TELEMETRY_OFF
Agent [baseline] (1.196 s) : 0, 1196470
Total [baseline] (9.096 s) : 0, 9095505
Agent [candidate] (1.198 s) : 0, 1198459
Total [candidate] (9.132 s) : 0, 9131658
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent iast 1.199 s 126.266 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.208 s 135.647 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.196 s 123.683 ms (11.5%)
Total tracing 8.591 s -
Total iast 9.102 s 510.14 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.115 s 523.743 ms (6.1%)
Total iast_TELEMETRY_OFF 9.096 s 504.14 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent iast 1.198 s 116.015 ms (10.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.2 s 118.305 ms (10.9%)
Agent iast_TELEMETRY_OFF 1.198 s 116.728 ms (10.8%)
Total tracing 8.601 s -
Total iast 9.132 s 531.078 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.105 s 504.232 ms (5.9%)
Total iast_TELEMETRY_OFF 9.132 s 530.888 ms (6.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~6732dfa2f9, baseline=1.41.0-SNAPSHOT~5a939c03ae

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.157 ms) : 0, 685157
BytebuddyAgent [candidate] (690.924 ms) : 0, 690924
GlobalTracer [baseline] (311.33 ms) : 0, 311330
GlobalTracer [candidate] (313.88 ms) : 0, 313880
AppSec [baseline] (54.206 ms) : 0, 54206
AppSec [candidate] (54.577 ms) : 0, 54577
Remote Config [baseline] (666.454 µs) : 0, 666
Remote Config [candidate] (671.325 µs) : 0, 671
Telemetry [baseline] (7.672 ms) : 0, 7672
Telemetry [candidate] (7.789 ms) : 0, 7789
section iast
BytebuddyAgent [baseline] (798.582 ms) : 0, 798582
BytebuddyAgent [candidate] (796.976 ms) : 0, 796976
GlobalTracer [baseline] (300.44 ms) : 0, 300440
GlobalTracer [candidate] (300.614 ms) : 0, 300614
AppSec [baseline] (54.685 ms) : 0, 54685
AppSec [candidate] (54.917 ms) : 0, 54917
Remote Config [baseline] (607.653 µs) : 0, 608
Remote Config [candidate] (610.103 µs) : 0, 610
Telemetry [baseline] (7.107 ms) : 0, 7107
Telemetry [candidate] (7.079 ms) : 0, 7079
IAST [baseline] (23.79 ms) : 0, 23790
IAST [candidate] (23.785 ms) : 0, 23785
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (804.737 ms) : 0, 804737
BytebuddyAgent [candidate] (799.141 ms) : 0, 799141
GlobalTracer [baseline] (302.67 ms) : 0, 302670
GlobalTracer [candidate] (300.295 ms) : 0, 300295
AppSec [baseline] (55.992 ms) : 0, 55992
AppSec [candidate] (52.795 ms) : 0, 52795
Remote Config [baseline] (630.82 µs) : 0, 631
Remote Config [candidate] (609.022 µs) : 0, 609
Telemetry [baseline] (7.17 ms) : 0, 7170
Telemetry [candidate] (7.069 ms) : 0, 7069
IAST [baseline] (23.291 ms) : 0, 23291
IAST [candidate] (26.235 ms) : 0, 26235
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.154 ms) : 0, 796154
BytebuddyAgent [candidate] (797.155 ms) : 0, 797155
GlobalTracer [baseline] (300.392 ms) : 0, 300392
GlobalTracer [candidate] (301.119 ms) : 0, 301119
AppSec [baseline] (54.345 ms) : 0, 54345
AppSec [candidate] (55.129 ms) : 0, 55129
Remote Config [baseline] (602.249 µs) : 0, 602
Remote Config [candidate] (677.029 µs) : 0, 677
Telemetry [baseline] (7.663 ms) : 0, 7663
Telemetry [candidate] (7.015 ms) : 0, 7015
IAST [baseline] (23.441 ms) : 0, 23441
IAST [candidate] (23.452 ms) : 0, 23452
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~6732dfa2f9, baseline=1.41.0-SNAPSHOT~5a939c03ae

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071910
Total [baseline] (10.459 s) : 0, 10458736
Agent [candidate] (1.072 s) : 0, 1072293
Total [candidate] (10.387 s) : 0, 10386675
section appsec
Agent [baseline] (1.204 s) : 0, 1204291
Total [baseline] (10.605 s) : 0, 10604846
Agent [candidate] (1.21 s) : 0, 1209600
Total [candidate] (10.656 s) : 0, 10656277
section iast
Agent [baseline] (1.211 s) : 0, 1210914
Total [baseline] (11.022 s) : 0, 11021860
Agent [candidate] (1.206 s) : 0, 1205881
Total [candidate] (10.893 s) : 0, 10892525
section profiling
Agent [baseline] (1.271 s) : 0, 1270847
Total [baseline] (10.672 s) : 0, 10672037
Agent [candidate] (1.27 s) : 0, 1270228
Total [candidate] (10.642 s) : 0, 10641934
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent appsec 1.204 s 132.381 ms (12.4%)
Agent iast 1.211 s 139.004 ms (13.0%)
Agent profiling 1.271 s 198.937 ms (18.6%)
Total tracing 10.459 s -
Total appsec 10.605 s 146.11 ms (1.4%)
Total iast 11.022 s 563.124 ms (5.4%)
Total profiling 10.672 s 213.301 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent appsec 1.21 s 137.307 ms (12.8%)
Agent iast 1.206 s 133.589 ms (12.5%)
Agent profiling 1.27 s 197.936 ms (18.5%)
Total tracing 10.387 s -
Total appsec 10.656 s 269.603 ms (2.6%)
Total iast 10.893 s 505.851 ms (4.9%)
Total profiling 10.642 s 255.259 ms (2.5%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~6732dfa2f9, baseline=1.41.0-SNAPSHOT~5a939c03ae

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.881 ms) : 0, 683881
BytebuddyAgent [candidate] (684.255 ms) : 0, 684255
GlobalTracer [baseline] (311.605 ms) : 0, 311605
GlobalTracer [candidate] (311.905 ms) : 0, 311905
AppSec [baseline] (54.295 ms) : 0, 54295
AppSec [candidate] (53.961 ms) : 0, 53961
Remote Config [baseline] (672.668 µs) : 0, 673
Remote Config [candidate] (681.265 µs) : 0, 681
Telemetry [baseline] (7.735 ms) : 0, 7735
Telemetry [candidate] (7.757 ms) : 0, 7757
section appsec
BytebuddyAgent [baseline] (699.657 ms) : 0, 699657
BytebuddyAgent [candidate] (702.903 ms) : 0, 702903
GlobalTracer [baseline] (307.602 ms) : 0, 307602
GlobalTracer [candidate] (308.745 ms) : 0, 308745
AppSec [baseline] (164.047 ms) : 0, 164047
AppSec [candidate] (164.51 ms) : 0, 164510
Remote Config [baseline] (640.897 µs) : 0, 641
Remote Config [candidate] (647.113 µs) : 0, 647
Telemetry [baseline] (7.84 ms) : 0, 7840
Telemetry [candidate] (8.917 ms) : 0, 8917
IAST [baseline] (21.537 ms) : 0, 21537
IAST [candidate] (20.199 ms) : 0, 20199
section iast
BytebuddyAgent [baseline] (805.889 ms) : 0, 805889
BytebuddyAgent [candidate] (802.937 ms) : 0, 802937
GlobalTracer [baseline] (304.164 ms) : 0, 304164
GlobalTracer [candidate] (302.06 ms) : 0, 302060
AppSec [baseline] (56.951 ms) : 0, 56951
AppSec [candidate] (56.091 ms) : 0, 56091
Remote Config [baseline] (618.14 µs) : 0, 618
Remote Config [candidate] (617.705 µs) : 0, 618
Telemetry [baseline] (7.193 ms) : 0, 7193
Telemetry [candidate] (7.189 ms) : 0, 7189
IAST [baseline] (22.269 ms) : 0, 22269
IAST [candidate] (23.162 ms) : 0, 23162
section profiling
BytebuddyAgent [baseline] (676.446 ms) : 0, 676446
BytebuddyAgent [candidate] (676.989 ms) : 0, 676989
GlobalTracer [baseline] (395.296 ms) : 0, 395296
GlobalTracer [candidate] (394.4 ms) : 0, 394400
AppSec [baseline] (54.902 ms) : 0, 54902
AppSec [candidate] (54.964 ms) : 0, 54964
Remote Config [baseline] (664.488 µs) : 0, 664
Remote Config [candidate] (654.015 µs) : 0, 654
Telemetry [baseline] (7.523 ms) : 0, 7523
Telemetry [candidate] (7.516 ms) : 0, 7516
ProfilingAgent [baseline] (97.192 ms) : 0, 97192
ProfilingAgent [candidate] (96.965 ms) : 0, 96965
Profiling [baseline] (97.216 ms) : 0, 97216
Profiling [candidate] (96.989 ms) : 0, 96989
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-03T14:13:32 2024-10-03T14:20:25
git_branch master mhlidd/server_error_statuses
git_commit_date 1727959073 1727964402
git_commit_sha 5a939c0 6732dfa
release_version 1.41.0-SNAPSHOT~5a939c03ae 1.41.0-SNAPSHOT~6732dfa2f9
start_time 2024-10-03T14:13:19 2024-10-03T14:20:12
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727965572 1727965572
ci_job_id 660204128 660204128
ci_pipeline_id 45714131 45714131
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-98.096µs; -43.921µs] or [-6.333%; -2.836%]		 unstable
[-576.981op/s; +576.981op/s] or [-18.752%; +18.752%]		 1.478ms 3076.923op/s 1.549ms 3076.923op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~6732dfa2f9, baseline=1.41.0-SNAPSHOT~5a939c03ae
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.67 µs) : 348, 387
.   : milestone, 368,
iast (484.343 µs) : 463, 505
.   : milestone, 484,
iast_FULL (551.461 µs) : 530, 573
.   : milestone, 551,
iast_GLOBAL (510.204 µs) : 488, 533
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (485.53 µs) : 464, 507
.   : milestone, 486,
iast_INACTIVE (448.851 µs) : 428, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (473.907 µs) : 453, 495
.   : milestone, 474,
tracing (446.725 µs) : 425, 468
.   : milestone, 447,
section candidate
no_agent (364.838 µs) : 345, 385
.   : milestone, 365,
iast (488.45 µs) : 467, 510
.   : milestone, 488,
iast_FULL (551.422 µs) : 530, 573
.   : milestone, 551,
iast_GLOBAL (502.796 µs) : 481, 524
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (479.206 µs) : 458, 500
.   : milestone, 479,
iast_INACTIVE (448.243 µs) : 428, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (480.836 µs) : 459, 503
.   : milestone, 481,
tracing (440.206 µs) : 420, 461
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.67 µs [348.099 µs, 387.241 µs] -
iast 484.343 µs [463.264 µs, 505.422 µs] 116.674 µs (31.7%)
iast_FULL 551.461 µs [530.278 µs, 572.644 µs] 183.791 µs (50.0%)
iast_GLOBAL 510.204 µs [487.678 µs, 532.729 µs] 142.534 µs (38.8%)
iast_HARDCODED_SECRET_DISABLED 485.53 µs [464.223 µs, 506.837 µs] 117.86 µs (32.1%)
iast_INACTIVE 448.851 µs [427.969 µs, 469.733 µs] 81.181 µs (22.1%)
iast_TELEMETRY_OFF 473.907 µs [452.756 µs, 495.058 µs] 106.237 µs (28.9%)
tracing 446.725 µs [425.359 µs, 468.092 µs] 79.055 µs (21.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.838 µs [344.98 µs, 384.696 µs] -
iast 488.45 µs [466.66 µs, 510.239 µs] 123.611 µs (33.9%)
iast_FULL 551.422 µs [530.153 µs, 572.691 µs] 186.584 µs (51.1%)
iast_GLOBAL 502.796 µs [481.484 µs, 524.108 µs] 137.958 µs (37.8%)
iast_HARDCODED_SECRET_DISABLED 479.206 µs [458.153 µs, 500.259 µs] 114.368 µs (31.3%)
iast_INACTIVE 448.243 µs [427.503 µs, 468.983 µs] 83.405 µs (22.9%)
iast_TELEMETRY_OFF 480.836 µs [458.844 µs, 502.828 µs] 115.998 µs (31.8%)
tracing 440.206 µs [419.786 µs, 460.627 µs] 75.368 µs (20.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~6732dfa2f9, baseline=1.41.0-SNAPSHOT~5a939c03ae
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.329 ms) : 1310, 1349
.   : milestone, 1329,
appsec (1.713 ms) : 1689, 1736
.   : milestone, 1713,
appsec_no_iast (1.73 ms) : 1706, 1753
.   : milestone, 1730,
iast (1.483 ms) : 1460, 1505
.   : milestone, 1483,
profiling (1.549 ms) : 1523, 1575
.   : milestone, 1549,
tracing (1.472 ms) : 1448, 1496
.   : milestone, 1472,
section candidate
no_agent (1.333 ms) : 1312, 1353
.   : milestone, 1333,
appsec (1.708 ms) : 1684, 1731
.   : milestone, 1708,
appsec_no_iast (1.717 ms) : 1693, 1742
.   : milestone, 1717,
iast (1.476 ms) : 1454, 1498
.   : milestone, 1476,
profiling (1.478 ms) : 1453, 1502
.   : milestone, 1478,
tracing (1.458 ms) : 1434, 1483
.   : milestone, 1458,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.329 ms [1.31 ms, 1.349 ms] -
appsec 1.713 ms [1.689 ms, 1.736 ms] 383.185 µs (28.8%)
appsec_no_iast 1.73 ms [1.706 ms, 1.753 ms] 400.343 µs (30.1%)
iast 1.483 ms [1.46 ms, 1.505 ms] 153.457 µs (11.5%)
profiling 1.549 ms [1.523 ms, 1.575 ms] 219.471 µs (16.5%)
tracing 1.472 ms [1.448 ms, 1.496 ms] 142.29 µs (10.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.333 ms [1.312 ms, 1.353 ms] -
appsec 1.708 ms [1.684 ms, 1.731 ms] 375.019 µs (28.1%)
appsec_no_iast 1.717 ms [1.693 ms, 1.742 ms] 384.885 µs (28.9%)
iast 1.476 ms [1.454 ms, 1.498 ms] 143.756 µs (10.8%)
profiling 1.478 ms [1.453 ms, 1.502 ms] 145.297 µs (10.9%)
tracing 1.458 ms [1.434 ms, 1.483 ms] 125.731 µs (9.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/server_error_statuses
git_commit_date 1727959073 1727964402
git_commit_sha 5a939c0 6732dfa
release_version 1.41.0-SNAPSHOT~5a939c03ae 1.41.0-SNAPSHOT~6732dfa2f9
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727966128 1727966128
ci_job_id 660204129 660204129
ci_pipeline_id 45714131 45714131
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~6732dfa2f9, baseline=1.41.0-SNAPSHOT~5a939c03ae
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.194 s) : 15194000, 15194000
.   : milestone, 15194000,
appsec (15.303 s) : 15303000, 15303000
.   : milestone, 15303000,
iast (18.66 s) : 18660000, 18660000
.   : milestone, 18660000,
iast_GLOBAL (17.992 s) : 17992000, 17992000
.   : milestone, 17992000,
profiling (15.074 s) : 15074000, 15074000
.   : milestone, 15074000,
tracing (15.171 s) : 15171000, 15171000
.   : milestone, 15171000,
section candidate
no_agent (15.175 s) : 15175000, 15175000
.   : milestone, 15175000,
appsec (15.18 s) : 15180000, 15180000
.   : milestone, 15180000,
iast (19.018 s) : 19018000, 19018000
.   : milestone, 19018000,
iast_GLOBAL (17.677 s) : 17677000, 17677000
.   : milestone, 17677000,
profiling (14.989 s) : 14989000, 14989000
.   : milestone, 14989000,
tracing (15.075 s) : 15075000, 15075000
.   : milestone, 15075000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.194 s [15.194 s, 15.194 s] -
appsec 15.303 s [15.303 s, 15.303 s] 109.0 ms (0.7%)
iast 18.66 s [18.66 s, 18.66 s] 3.466 s (22.8%)
iast_GLOBAL 17.992 s [17.992 s, 17.992 s] 2.798 s (18.4%)
profiling 15.074 s [15.074 s, 15.074 s] -120.0 ms (-0.8%)
tracing 15.171 s [15.171 s, 15.171 s] -23.0 ms (-0.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.175 s [15.175 s, 15.175 s] -
appsec 15.18 s [15.18 s, 15.18 s] 5.0 ms (0.0%)
iast 19.018 s [19.018 s, 19.018 s] 3.843 s (25.3%)
iast_GLOBAL 17.677 s [17.677 s, 17.677 s] 2.502 s (16.5%)
profiling 14.989 s [14.989 s, 14.989 s] -186.0 ms (-1.2%)
tracing 15.075 s [15.075 s, 15.075 s] -100.0 ms (-0.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~6732dfa2f9, baseline=1.41.0-SNAPSHOT~5a939c03ae
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1477
.   : milestone, 1465,
appsec (2.304 ms) : 2264, 2344
.   : milestone, 2304,
iast (2.065 ms) : 2014, 2116
.   : milestone, 2065,
iast_GLOBAL (2.099 ms) : 2047, 2150
.   : milestone, 2099,
profiling (1.934 ms) : 1892, 1977
.   : milestone, 1934,
tracing (1.906 ms) : 1867, 1946
.   : milestone, 1906,
section candidate
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.324 ms) : 2284, 2365
.   : milestone, 2324,
iast (2.065 ms) : 2013, 2116
.   : milestone, 2065,
iast_GLOBAL (2.102 ms) : 2050, 2153
.   : milestone, 2102,
profiling (1.942 ms) : 1901, 1983
.   : milestone, 1942,
tracing (1.914 ms) : 1875, 1954
.   : milestone, 1914,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.454 ms, 1.477 ms] -
appsec 2.304 ms [2.264 ms, 2.344 ms] 838.843 µs (57.2%)
iast 2.065 ms [2.014 ms, 2.116 ms] 599.439 µs (40.9%)
iast_GLOBAL 2.099 ms [2.047 ms, 2.15 ms] 633.148 µs (43.2%)
profiling 1.934 ms [1.892 ms, 1.977 ms] 469.017 µs (32.0%)
tracing 1.906 ms [1.867 ms, 1.946 ms] 440.888 µs (30.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.324 ms [2.284 ms, 2.365 ms] 857.866 µs (58.5%)
iast 2.065 ms [2.013 ms, 2.116 ms] 598.326 µs (40.8%)
iast_GLOBAL 2.102 ms [2.05 ms, 2.153 ms] 634.979 µs (43.3%)
profiling 1.942 ms [1.901 ms, 1.983 ms] 475.873 µs (32.4%)
tracing 1.914 ms [1.875 ms, 1.954 ms] 447.723 µs (30.5%)

@mhlidd mhlidd marked this pull request as ready for review October 3, 2024 16:59
@mhlidd mhlidd requested a review from a team as a code owner October 3, 2024 16:59
PerfectSlayer
PerfectSlayer approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mhlidd mhlidd merged commit e5e5427 into master Oct 4, 2024
103 checks passed
@mhlidd mhlidd deleted the mhlidd/server_error_statuses branch October 4, 2024 13:45
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

@mtoffl01 mtoffl01 Awaiting requested review from mtoffl01

Assignees
No one assigned
Labels
comp: api Tracer public API type: enhancement
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mhlidd @PerfectSlayer