-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace setup and teardown operations in JUnit 5 #7714
Merged
nikita-tkachenko-datadog
merged 7 commits into
master
from
nikita-tkachenko/junit-5-suite-setup-teardown
Oct 4, 2024
Merged
Trace setup and teardown operations in JUnit 5 #7714
nikita-tkachenko-datadog
merged 7 commits into
master
from
nikita-tkachenko/junit-5-suite-setup-teardown
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
the
comp: ci visibility
Continuous Integration Visibility
label
Oct 2, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 9 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~0bc84dd418, baseline=1.41.0-SNAPSHOT~9db260fd16
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067722
Total [baseline] (8.558 s) : 0, 8557527
Agent [candidate] (1.074 s) : 0, 1073759
Total [candidate] (8.549 s) : 0, 8548713
section iast
Agent [baseline] (1.203 s) : 0, 1202628
Total [baseline] (9.106 s) : 0, 9106437
Agent [candidate] (1.209 s) : 0, 1208513
Total [candidate] (9.079 s) : 0, 9078511
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.192 s) : 0, 1191646
Total [baseline] (9.055 s) : 0, 9055451
Agent [candidate] (1.202 s) : 0, 1201920
Total [candidate] (9.101 s) : 0, 9101015
section iast_TELEMETRY_OFF
Agent [baseline] (1.196 s) : 0, 1196253
Total [baseline] (9.095 s) : 0, 9094720
Agent [candidate] (1.19 s) : 0, 1190365
Total [candidate] (9.058 s) : 0, 9057719
gantt
title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~0bc84dd418, baseline=1.41.0-SNAPSHOT~9db260fd16
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.992 ms) : 0, 681992
BytebuddyAgent [candidate] (685.269 ms) : 0, 685269
GlobalTracer [baseline] (310.122 ms) : 0, 310122
GlobalTracer [candidate] (312.42 ms) : 0, 312420
AppSec [baseline] (53.782 ms) : 0, 53782
AppSec [candidate] (54.007 ms) : 0, 54007
Remote Config [baseline] (656.742 µs) : 0, 657
Remote Config [candidate] (663.576 µs) : 0, 664
Telemetry [baseline] (7.581 ms) : 0, 7581
Telemetry [candidate] (7.662 ms) : 0, 7662
section iast
BytebuddyAgent [baseline] (801.336 ms) : 0, 801336
BytebuddyAgent [candidate] (806.277 ms) : 0, 806277
GlobalTracer [baseline] (301.178 ms) : 0, 301178
GlobalTracer [candidate] (302.021 ms) : 0, 302021
AppSec [baseline] (54.05 ms) : 0, 54050
AppSec [candidate] (52.949 ms) : 0, 52949
IAST [baseline] (24.628 ms) : 0, 24628
IAST [candidate] (25.835 ms) : 0, 25835
Remote Config [baseline] (617.039 µs) : 0, 617
Remote Config [candidate] (609.917 µs) : 0, 610
Telemetry [baseline] (7.122 ms) : 0, 7122
Telemetry [candidate] (7.013 ms) : 0, 7013
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (794.397 ms) : 0, 794397
BytebuddyAgent [candidate] (800.6 ms) : 0, 800600
GlobalTracer [baseline] (298.476 ms) : 0, 298476
GlobalTracer [candidate] (301.151 ms) : 0, 301151
AppSec [baseline] (56.568 ms) : 0, 56568
AppSec [candidate] (55.027 ms) : 0, 55027
IAST [baseline] (20.893 ms) : 0, 20893
IAST [candidate] (23.682 ms) : 0, 23682
Remote Config [baseline] (603.288 µs) : 0, 603
Remote Config [candidate] (628.206 µs) : 0, 628
Telemetry [baseline] (7.066 ms) : 0, 7066
Telemetry [candidate] (7.092 ms) : 0, 7092
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.967 ms) : 0, 796967
BytebuddyAgent [candidate] (792.449 ms) : 0, 792449
GlobalTracer [baseline] (299.654 ms) : 0, 299654
GlobalTracer [candidate] (298.502 ms) : 0, 298502
AppSec [baseline] (54.971 ms) : 0, 54971
AppSec [candidate] (52.377 ms) : 0, 52377
IAST [baseline] (23.312 ms) : 0, 23312
IAST [candidate] (25.902 ms) : 0, 25902
Remote Config [baseline] (613.942 µs) : 0, 614
Remote Config [candidate] (612.126 µs) : 0, 612
Telemetry [baseline] (6.98 ms) : 0, 6980
Telemetry [candidate] (6.863 ms) : 0, 6863
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~0bc84dd418, baseline=1.41.0-SNAPSHOT~9db260fd16
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1069778
Total [baseline] (10.432 s) : 0, 10431862
Agent [candidate] (1.067 s) : 0, 1067077
Total [candidate] (10.392 s) : 0, 10391694
section appsec
Agent [baseline] (1.204 s) : 0, 1203750
Total [baseline] (10.646 s) : 0, 10646421
Agent [candidate] (1.198 s) : 0, 1198252
Total [candidate] (10.549 s) : 0, 10549488
section iast
Agent [baseline] (1.202 s) : 0, 1202041
Total [baseline] (10.818 s) : 0, 10818030
Agent [candidate] (1.197 s) : 0, 1197162
Total [candidate] (10.808 s) : 0, 10808484
section profiling
Agent [baseline] (1.275 s) : 0, 1274672
Total [baseline] (10.62 s) : 0, 10620152
Agent [candidate] (1.263 s) : 0, 1263108
Total [candidate] (10.574 s) : 0, 10573795
gantt
title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~0bc84dd418, baseline=1.41.0-SNAPSHOT~9db260fd16
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.102 ms) : 0, 682102
BytebuddyAgent [candidate] (681.602 ms) : 0, 681602
GlobalTracer [baseline] (311.73 ms) : 0, 311730
GlobalTracer [candidate] (309.703 ms) : 0, 309703
AppSec [baseline] (54.016 ms) : 0, 54016
AppSec [candidate] (53.796 ms) : 0, 53796
Remote Config [baseline] (671.443 µs) : 0, 671
Remote Config [candidate] (664.436 µs) : 0, 664
Telemetry [baseline] (7.662 ms) : 0, 7662
Telemetry [candidate] (7.697 ms) : 0, 7697
section appsec
BytebuddyAgent [baseline] (700.47 ms) : 0, 700470
BytebuddyAgent [candidate] (697.898 ms) : 0, 697898
GlobalTracer [baseline] (307.482 ms) : 0, 307482
GlobalTracer [candidate] (306.683 ms) : 0, 306683
AppSec [baseline] (163.315 ms) : 0, 163315
AppSec [candidate] (161.519 ms) : 0, 161519
Remote Config [baseline] (640.013 µs) : 0, 640
Remote Config [candidate] (641.353 µs) : 0, 641
Telemetry [baseline] (7.82 ms) : 0, 7820
Telemetry [candidate] (7.48 ms) : 0, 7480
IAST [baseline] (20.73 ms) : 0, 20730
IAST [candidate] (20.861 ms) : 0, 20861
section iast
BytebuddyAgent [baseline] (801.52 ms) : 0, 801520
BytebuddyAgent [candidate] (797.327 ms) : 0, 797327
GlobalTracer [baseline] (300.982 ms) : 0, 300982
GlobalTracer [candidate] (299.748 ms) : 0, 299748
AppSec [baseline] (56.658 ms) : 0, 56658
AppSec [candidate] (52.73 ms) : 0, 52730
Remote Config [baseline] (609.808 µs) : 0, 610
Remote Config [candidate] (603.641 µs) : 0, 604
Telemetry [baseline] (7.136 ms) : 0, 7136
Telemetry [candidate] (7.056 ms) : 0, 7056
IAST [baseline] (21.409 ms) : 0, 21409
IAST [candidate] (26.011 ms) : 0, 26011
section profiling
ProfilingAgent [baseline] (96.745 ms) : 0, 96745
ProfilingAgent [candidate] (96.062 ms) : 0, 96062
BytebuddyAgent [baseline] (680.36 ms) : 0, 680360
BytebuddyAgent [candidate] (673.8 ms) : 0, 673800
GlobalTracer [baseline] (395.74 ms) : 0, 395740
GlobalTracer [candidate] (392.324 ms) : 0, 392324
AppSec [baseline] (54.883 ms) : 0, 54883
AppSec [candidate] (54.382 ms) : 0, 54382
Remote Config [baseline] (659.009 µs) : 0, 659
Remote Config [candidate] (645.076 µs) : 0, 645
Telemetry [baseline] (7.427 ms) : 0, 7427
Telemetry [candidate] (7.363 ms) : 0, 7363
Profiling [baseline] (96.769 ms) : 0, 96769
Profiling [candidate] (96.087 ms) : 0, 96087
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~0bc84dd418, baseline=1.41.0-SNAPSHOT~9db260fd16
dateFormat X
axisFormat %s
section baseline
no_agent (1.372 ms) : 1352, 1392
. : milestone, 1372,
appsec (1.737 ms) : 1713, 1762
. : milestone, 1737,
appsec_no_iast (1.729 ms) : 1705, 1753
. : milestone, 1729,
iast (1.473 ms) : 1451, 1495
. : milestone, 1473,
profiling (1.519 ms) : 1494, 1545
. : milestone, 1519,
tracing (1.491 ms) : 1467, 1516
. : milestone, 1491,
section candidate
no_agent (1.351 ms) : 1332, 1371
. : milestone, 1351,
appsec (1.749 ms) : 1725, 1772
. : milestone, 1749,
appsec_no_iast (1.728 ms) : 1703, 1753
. : milestone, 1728,
iast (1.491 ms) : 1468, 1513
. : milestone, 1491,
profiling (1.503 ms) : 1477, 1529
. : milestone, 1503,
tracing (1.46 ms) : 1435, 1485
. : milestone, 1460,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~0bc84dd418, baseline=1.41.0-SNAPSHOT~9db260fd16
dateFormat X
axisFormat %s
section baseline
no_agent (378.126 µs) : 358, 398
. : milestone, 378,
iast (495.742 µs) : 474, 517
. : milestone, 496,
iast_FULL (573.194 µs) : 552, 595
. : milestone, 573,
iast_GLOBAL (519.159 µs) : 497, 541
. : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (493.135 µs) : 472, 514
. : milestone, 493,
iast_INACTIVE (455.062 µs) : 434, 476
. : milestone, 455,
iast_TELEMETRY_OFF (481.094 µs) : 459, 503
. : milestone, 481,
tracing (447.902 µs) : 428, 468
. : milestone, 448,
section candidate
no_agent (377.671 µs) : 358, 397
. : milestone, 378,
iast (489.626 µs) : 469, 511
. : milestone, 490,
iast_FULL (564.691 µs) : 544, 586
. : milestone, 565,
iast_GLOBAL (512.815 µs) : 492, 534
. : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (496.887 µs) : 475, 519
. : milestone, 497,
iast_INACTIVE (449.056 µs) : 428, 470
. : milestone, 449,
iast_TELEMETRY_OFF (482.753 µs) : 462, 504
. : milestone, 483,
tracing (451.79 µs) : 431, 472
. : milestone, 452,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~0bc84dd418, baseline=1.41.0-SNAPSHOT~9db260fd16
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.321 ms) : 2280, 2361
. : milestone, 2321,
iast (2.06 ms) : 2009, 2111
. : milestone, 2060,
iast_GLOBAL (2.103 ms) : 2052, 2155
. : milestone, 2103,
profiling (1.929 ms) : 1889, 1969
. : milestone, 1929,
tracing (1.922 ms) : 1882, 1961
. : milestone, 1922,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.318 ms) : 2278, 2359
. : milestone, 2318,
iast (2.077 ms) : 2026, 2129
. : milestone, 2077,
iast_GLOBAL (2.116 ms) : 2064, 2168
. : milestone, 2116,
profiling (1.936 ms) : 1894, 1978
. : milestone, 1936,
tracing (1.913 ms) : 1874, 1953
. : milestone, 1913,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~0bc84dd418, baseline=1.41.0-SNAPSHOT~9db260fd16
dateFormat X
axisFormat %s
section baseline
no_agent (15.304 s) : 15304000, 15304000
. : milestone, 15304000,
appsec (15.306 s) : 15306000, 15306000
. : milestone, 15306000,
iast (18.924 s) : 18924000, 18924000
. : milestone, 18924000,
iast_GLOBAL (18.052 s) : 18052000, 18052000
. : milestone, 18052000,
profiling (15.211 s) : 15211000, 15211000
. : milestone, 15211000,
tracing (15.375 s) : 15375000, 15375000
. : milestone, 15375000,
section candidate
no_agent (15.118 s) : 15118000, 15118000
. : milestone, 15118000,
appsec (15.075 s) : 15075000, 15075000
. : milestone, 15075000,
iast (18.629 s) : 18629000, 18629000
. : milestone, 18629000,
iast_GLOBAL (18.15 s) : 18150000, 18150000
. : milestone, 18150000,
profiling (15.177 s) : 15177000, 15177000
. : milestone, 15177000,
tracing (15.288 s) : 15288000, 15288000
. : milestone, 15288000,
|
Base automatically changed from
nikita-tkachenko/parent-module-context-propagation
to
master
October 3, 2024 12:37
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/junit-5-suite-setup-teardown
branch
from
October 3, 2024 12:38
b0400e0
to
d2214d7
Compare
juan-fernandez
approved these changes
Oct 4, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/junit-5-suite-setup-teardown
branch
October 4, 2024 12:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds tracing of
@BeforeAll
,@BeforeEach
,@AfterAll
,@AfterEach
operations in JUnit 5 tests.Motivation
A feature requested by Test Visibility customers.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-970