-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSM] Add avro schema object extraction #7712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericfirth
force-pushed
the
eric.firth/add-avro-schema-for-objects
branch
from
October 2, 2024 13:29
58faf50
to
26f86d7
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~d78662996d, baseline=1.41.0-SNAPSHOT~f9c6fbae6a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071756
Total [baseline] (10.353 s) : 0, 10353405
Agent [candidate] (1.065 s) : 0, 1065212
Total [candidate] (10.35 s) : 0, 10350208
section appsec
Agent [baseline] (1.2 s) : 0, 1200487
Total [baseline] (10.582 s) : 0, 10582425
Agent [candidate] (1.199 s) : 0, 1198684
Total [candidate] (10.592 s) : 0, 10591513
section iast
Agent [baseline] (1.2 s) : 0, 1200013
Total [baseline] (10.81 s) : 0, 10810366
Agent [candidate] (1.193 s) : 0, 1192774
Total [candidate] (10.846 s) : 0, 10845858
section profiling
Agent [baseline] (1.275 s) : 0, 1275030
Total [baseline] (10.769 s) : 0, 10768532
Agent [candidate] (1.266 s) : 0, 1265731
Total [candidate] (10.557 s) : 0, 10557293
gantt
title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~d78662996d, baseline=1.41.0-SNAPSHOT~f9c6fbae6a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.092 ms) : 0, 683092
BytebuddyAgent [candidate] (680.31 ms) : 0, 680310
GlobalTracer [baseline] (312.47 ms) : 0, 312470
GlobalTracer [candidate] (309.469 ms) : 0, 309469
AppSec [baseline] (54.317 ms) : 0, 54317
AppSec [candidate] (53.605 ms) : 0, 53605
Remote Config [baseline] (655.088 µs) : 0, 655
Remote Config [candidate] (655.101 µs) : 0, 655
Telemetry [baseline] (7.558 ms) : 0, 7558
Telemetry [candidate] (7.546 ms) : 0, 7546
section appsec
BytebuddyAgent [baseline] (697.487 ms) : 0, 697487
BytebuddyAgent [candidate] (696.975 ms) : 0, 696975
GlobalTracer [baseline] (307.176 ms) : 0, 307176
GlobalTracer [candidate] (306.288 ms) : 0, 306288
AppSec [baseline] (161.495 ms) : 0, 161495
AppSec [candidate] (163.1 ms) : 0, 163100
Remote Config [baseline] (628.879 µs) : 0, 629
Remote Config [candidate] (634.797 µs) : 0, 635
Telemetry [baseline] (9.246 ms) : 0, 9246
Telemetry [candidate] (7.751 ms) : 0, 7751
IAST [baseline] (21.661 ms) : 0, 21661
IAST [candidate] (20.606 ms) : 0, 20606
section iast
BytebuddyAgent [baseline] (800.259 ms) : 0, 800259
BytebuddyAgent [candidate] (794.713 ms) : 0, 794713
GlobalTracer [baseline] (300.103 ms) : 0, 300103
GlobalTracer [candidate] (298.643 ms) : 0, 298643
AppSec [baseline] (54.05 ms) : 0, 54050
AppSec [candidate] (53.831 ms) : 0, 53831
Remote Config [baseline] (599.638 µs) : 0, 600
Remote Config [candidate] (605.886 µs) : 0, 606
Telemetry [baseline] (7.03 ms) : 0, 7030
Telemetry [candidate] (7.047 ms) : 0, 7047
IAST [baseline] (24.235 ms) : 0, 24235
IAST [candidate] (24.276 ms) : 0, 24276
section profiling
ProfilingAgent [baseline] (97.234 ms) : 0, 97234
ProfilingAgent [candidate] (95.888 ms) : 0, 95888
BytebuddyAgent [baseline] (680.582 ms) : 0, 680582
BytebuddyAgent [candidate] (675.766 ms) : 0, 675766
GlobalTracer [baseline] (395.384 ms) : 0, 395384
GlobalTracer [candidate] (392.662 ms) : 0, 392662
AppSec [baseline] (54.834 ms) : 0, 54834
AppSec [candidate] (54.73 ms) : 0, 54730
Remote Config [baseline] (654.623 µs) : 0, 655
Remote Config [candidate] (650.562 µs) : 0, 651
Telemetry [baseline] (7.454 ms) : 0, 7454
Telemetry [candidate] (7.478 ms) : 0, 7478
Profiling [baseline] (97.258 ms) : 0, 97258
Profiling [candidate] (95.912 ms) : 0, 95912
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~d78662996d, baseline=1.41.0-SNAPSHOT~f9c6fbae6a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1073903
Total [baseline] (8.616 s) : 0, 8615632
Agent [candidate] (1.064 s) : 0, 1064209
Total [candidate] (8.53 s) : 0, 8529905
section iast
Agent [baseline] (1.199 s) : 0, 1198944
Total [baseline] (9.15 s) : 0, 9149581
Agent [candidate] (1.214 s) : 0, 1214131
Total [candidate] (9.091 s) : 0, 9090872
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.2 s) : 0, 1200009
Total [baseline] (9.07 s) : 0, 9069517
Agent [candidate] (1.194 s) : 0, 1193748
Total [candidate] (9.093 s) : 0, 9093074
section iast_TELEMETRY_OFF
Agent [baseline] (1.189 s) : 0, 1188525
Total [baseline] (9.029 s) : 0, 9028894
Agent [candidate] (1.194 s) : 0, 1193522
Total [candidate] (9.056 s) : 0, 9056358
gantt
title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~d78662996d, baseline=1.41.0-SNAPSHOT~f9c6fbae6a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.337 ms) : 0, 685337
BytebuddyAgent [candidate] (679.638 ms) : 0, 679638
GlobalTracer [baseline] (312.489 ms) : 0, 312489
GlobalTracer [candidate] (309.219 ms) : 0, 309219
AppSec [baseline] (54.037 ms) : 0, 54037
AppSec [candidate] (53.513 ms) : 0, 53513
Remote Config [baseline] (663.716 µs) : 0, 664
Remote Config [candidate] (660.103 µs) : 0, 660
Telemetry [baseline] (7.633 ms) : 0, 7633
Telemetry [candidate] (7.554 ms) : 0, 7554
section iast
BytebuddyAgent [baseline] (797.728 ms) : 0, 797728
BytebuddyAgent [candidate] (810.655 ms) : 0, 810655
GlobalTracer [baseline] (301.073 ms) : 0, 301073
GlobalTracer [candidate] (303.362 ms) : 0, 303362
AppSec [baseline] (54.52 ms) : 0, 54520
AppSec [candidate] (57.73 ms) : 0, 57730
IAST [baseline] (24.135 ms) : 0, 24135
IAST [candidate] (20.639 ms) : 0, 20639
Remote Config [baseline] (625.418 µs) : 0, 625
Remote Config [candidate] (626.336 µs) : 0, 626
Telemetry [baseline] (7.168 ms) : 0, 7168
Telemetry [candidate] (7.177 ms) : 0, 7177
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.209 ms) : 0, 800209
BytebuddyAgent [candidate] (795.626 ms) : 0, 795626
GlobalTracer [baseline] (300.268 ms) : 0, 300268
GlobalTracer [candidate] (298.744 ms) : 0, 298744
AppSec [baseline] (54.593 ms) : 0, 54593
AppSec [candidate] (55.146 ms) : 0, 55146
IAST [baseline] (23.53 ms) : 0, 23530
IAST [candidate] (22.86 ms) : 0, 22860
Remote Config [baseline] (600.545 µs) : 0, 601
Remote Config [candidate] (603.706 µs) : 0, 604
Telemetry [baseline] (7.07 ms) : 0, 7070
Telemetry [candidate] (7.048 ms) : 0, 7048
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (792.087 ms) : 0, 792087
BytebuddyAgent [candidate] (795.082 ms) : 0, 795082
GlobalTracer [baseline] (298.001 ms) : 0, 298001
GlobalTracer [candidate] (299.347 ms) : 0, 299347
AppSec [baseline] (55.075 ms) : 0, 55075
AppSec [candidate] (55.47 ms) : 0, 55470
IAST [baseline] (22.238 ms) : 0, 22238
IAST [candidate] (22.311 ms) : 0, 22311
Remote Config [baseline] (604.648 µs) : 0, 605
Remote Config [candidate] (612.563 µs) : 0, 613
Telemetry [baseline] (6.885 ms) : 0, 6885
Telemetry [candidate] (6.96 ms) : 0, 6960
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~d78662996d, baseline=1.41.0-SNAPSHOT~f9c6fbae6a
dateFormat X
axisFormat %s
section baseline
no_agent (376.537 µs) : 355, 398
. : milestone, 377,
iast (483.134 µs) : 462, 504
. : milestone, 483,
iast_FULL (552.714 µs) : 532, 574
. : milestone, 553,
iast_GLOBAL (512.919 µs) : 492, 534
. : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (490.272 µs) : 469, 512
. : milestone, 490,
iast_INACTIVE (453.597 µs) : 433, 474
. : milestone, 454,
iast_TELEMETRY_OFF (481.254 µs) : 459, 503
. : milestone, 481,
tracing (439.268 µs) : 419, 459
. : milestone, 439,
section candidate
no_agent (372.12 µs) : 353, 392
. : milestone, 372,
iast (489.785 µs) : 468, 511
. : milestone, 490,
iast_FULL (554.478 µs) : 533, 576
. : milestone, 554,
iast_GLOBAL (527.639 µs) : 504, 551
. : milestone, 528,
iast_HARDCODED_SECRET_DISABLED (491.392 µs) : 470, 513
. : milestone, 491,
iast_INACTIVE (454.452 µs) : 432, 476
. : milestone, 454,
iast_TELEMETRY_OFF (481.13 µs) : 459, 503
. : milestone, 481,
tracing (457.905 µs) : 436, 480
. : milestone, 458,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~d78662996d, baseline=1.41.0-SNAPSHOT~f9c6fbae6a
dateFormat X
axisFormat %s
section baseline
no_agent (1.366 ms) : 1347, 1386
. : milestone, 1366,
appsec (1.721 ms) : 1698, 1745
. : milestone, 1721,
appsec_no_iast (1.75 ms) : 1726, 1773
. : milestone, 1750,
iast (1.477 ms) : 1455, 1499
. : milestone, 1477,
profiling (1.542 ms) : 1517, 1567
. : milestone, 1542,
tracing (1.46 ms) : 1436, 1485
. : milestone, 1460,
section candidate
no_agent (1.338 ms) : 1319, 1357
. : milestone, 1338,
appsec (1.693 ms) : 1668, 1717
. : milestone, 1693,
appsec_no_iast (1.718 ms) : 1693, 1743
. : milestone, 1718,
iast (1.484 ms) : 1462, 1506
. : milestone, 1484,
profiling (1.49 ms) : 1465, 1515
. : milestone, 1490,
tracing (1.467 ms) : 1443, 1490
. : milestone, 1467,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~d78662996d, baseline=1.41.0-SNAPSHOT~f9c6fbae6a
dateFormat X
axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1471
. : milestone, 1460,
appsec (2.31 ms) : 2269, 2351
. : milestone, 2310,
iast (2.06 ms) : 2008, 2112
. : milestone, 2060,
iast_GLOBAL (2.112 ms) : 2059, 2164
. : milestone, 2112,
profiling (1.946 ms) : 1904, 1988
. : milestone, 1946,
tracing (1.915 ms) : 1875, 1955
. : milestone, 1915,
section candidate
no_agent (1.456 ms) : 1444, 1467
. : milestone, 1456,
appsec (2.318 ms) : 2277, 2359
. : milestone, 2318,
iast (2.067 ms) : 2015, 2118
. : milestone, 2067,
iast_GLOBAL (2.119 ms) : 2066, 2171
. : milestone, 2119,
profiling (1.946 ms) : 1904, 1988
. : milestone, 1946,
tracing (1.908 ms) : 1869, 1947
. : milestone, 1908,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~d78662996d, baseline=1.41.0-SNAPSHOT~f9c6fbae6a
dateFormat X
axisFormat %s
section baseline
no_agent (15.032 s) : 15032000, 15032000
. : milestone, 15032000,
appsec (15.149 s) : 15149000, 15149000
. : milestone, 15149000,
iast (18.863 s) : 18863000, 18863000
. : milestone, 18863000,
iast_GLOBAL (17.98 s) : 17980000, 17980000
. : milestone, 17980000,
profiling (15.289 s) : 15289000, 15289000
. : milestone, 15289000,
tracing (15.379 s) : 15379000, 15379000
. : milestone, 15379000,
section candidate
no_agent (15.777 s) : 15777000, 15777000
. : milestone, 15777000,
appsec (15.402 s) : 15402000, 15402000
. : milestone, 15402000,
iast (18.831 s) : 18831000, 18831000
. : milestone, 18831000,
iast_GLOBAL (17.998 s) : 17998000, 17998000
. : milestone, 17998000,
profiling (14.973 s) : 14973000, 14973000
. : milestone, 14973000,
tracing (15.313 s) : 15313000, 15313000
. : milestone, 15313000,
|
ericfirth
force-pushed
the
eric.firth/add-avro-schema-for-objects
branch
3 times, most recently
from
October 7, 2024 17:34
6a04e3e
to
a4fe058
Compare
piochelepiotr
approved these changes
Oct 7, 2024
ericfirth
force-pushed
the
eric.firth/add-avro-schema-for-objects
branch
from
October 7, 2024 19:40
afe965a
to
85d4818
Compare
ericfirth
force-pushed
the
eric.firth/add-avro-schema-for-objects
branch
from
October 7, 2024 20:14
28d57b2
to
25ad48a
Compare
piochelepiotr
approved these changes
Oct 7, 2024
ericfirth
force-pushed
the
eric.firth/add-avro-schema-for-objects
branch
from
October 7, 2024 20:18
25ad48a
to
f9a5bf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Previously we were ignoring nested Avro messages for schema tracking and just going labelling them
object
. This uses the protobuf object expansion as a guide and displays the subschemas of avro messagesMotivation
see the pretty expanded schema
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]