Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate module context from build system process to child JVM processes #7710

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Propagate module context from build system process to child JVM processes #7710

merged 7 commits into from
Oct 3, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Oct 2, 2024 •
edited by jira bot
Loading

What Does This Do

Adds propagation of the context of the build system module span from the parent process (build system) to children processes (JVMs forked to run tests).

Motivation

Adding support for suite setup/teardown tracing.
Any APM span (that is a span that is not a test suite or a test case) started in a child process needs to have test session ID as the trace ID, in order to be displayed properly in Datadog.
The only way to set the trace ID of a span is to provide parent context when creating that span.

Contributor Checklist

Jira ticket: SDTEST-970

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the comp: ci visibility Continuous Integration Visibility label Oct 2, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 2, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/parent-module-context-propagation
git_commit_date 1727942449 1727952433
git_commit_sha 919bf01 73dae75
release_version 1.41.0-SNAPSHOT~919bf01a5f 1.41.0-SNAPSHOT~73dae75284
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727954716 1727954716
ci_job_id 659875759 659875759
ci_pipeline_id 45694124 45694124
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~73dae75284, baseline=1.41.0-SNAPSHOT~919bf01a5f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078335
Total [baseline] (10.431 s) : 0, 10431135
Agent [candidate] (1.072 s) : 0, 1071920
Total [candidate] (10.461 s) : 0, 10460703
section appsec
Agent [baseline] (1.206 s) : 0, 1205511
Total [baseline] (10.66 s) : 0, 10660311
Agent [candidate] (1.21 s) : 0, 1209717
Total [candidate] (10.624 s) : 0, 10624201
section iast
Agent [baseline] (1.208 s) : 0, 1207767
Total [baseline] (10.912 s) : 0, 10912287
Agent [candidate] (1.199 s) : 0, 1199339
Total [candidate] (10.914 s) : 0, 10913663
section profiling
Agent [baseline] (1.273 s) : 0, 1273081
Total [baseline] (10.675 s) : 0, 10675322
Agent [candidate] (1.278 s) : 0, 1278372
Total [candidate] (10.7 s) : 0, 10700109
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.206 s 127.176 ms (11.8%)
Agent iast 1.208 s 129.433 ms (12.0%)
Agent profiling 1.273 s 194.747 ms (18.1%)
Total tracing 10.431 s -
Total appsec 10.66 s 229.176 ms (2.2%)
Total iast 10.912 s 481.152 ms (4.6%)
Total profiling 10.675 s 244.187 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent appsec 1.21 s 137.797 ms (12.9%)
Agent iast 1.199 s 127.419 ms (11.9%)
Agent profiling 1.278 s 206.452 ms (19.3%)
Total tracing 10.461 s -
Total appsec 10.624 s 163.498 ms (1.6%)
Total iast 10.914 s 452.961 ms (4.3%)
Total profiling 10.7 s 239.407 ms (2.3%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~73dae75284, baseline=1.41.0-SNAPSHOT~919bf01a5f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.239 ms) : 0, 688239
BytebuddyAgent [candidate] (683.751 ms) : 0, 683751
GlobalTracer [baseline] (313.412 ms) : 0, 313412
GlobalTracer [candidate] (312.12 ms) : 0, 312120
AppSec [baseline] (54.354 ms) : 0, 54354
AppSec [candidate] (53.904 ms) : 0, 53904
Remote Config [baseline] (669.977 µs) : 0, 670
Remote Config [candidate] (664.228 µs) : 0, 664
Telemetry [baseline] (7.759 ms) : 0, 7759
Telemetry [candidate] (7.695 ms) : 0, 7695
section appsec
BytebuddyAgent [baseline] (700.416 ms) : 0, 700416
BytebuddyAgent [candidate] (702.875 ms) : 0, 702875
GlobalTracer [baseline] (308.525 ms) : 0, 308525
GlobalTracer [candidate] (309.283 ms) : 0, 309283
AppSec [baseline] (162.955 ms) : 0, 162955
AppSec [candidate] (163.862 ms) : 0, 163862
IAST [baseline] (20.529 ms) : 0, 20529
IAST [candidate] (20.566 ms) : 0, 20566
Remote Config [baseline] (637.226 µs) : 0, 637
Remote Config [candidate] (638.058 µs) : 0, 638
Telemetry [baseline] (8.913 ms) : 0, 8913
Telemetry [candidate] (8.916 ms) : 0, 8916
section iast
BytebuddyAgent [baseline] (805.172 ms) : 0, 805172
BytebuddyAgent [candidate] (798.593 ms) : 0, 798593
GlobalTracer [baseline] (302.959 ms) : 0, 302959
GlobalTracer [candidate] (301.08 ms) : 0, 301080
AppSec [baseline] (56.258 ms) : 0, 56258
AppSec [candidate] (54.635 ms) : 0, 54635
IAST [baseline] (21.606 ms) : 0, 21606
IAST [candidate] (23.553 ms) : 0, 23553
Remote Config [baseline] (625.612 µs) : 0, 626
Remote Config [candidate] (611.678 µs) : 0, 612
Telemetry [baseline] (7.266 ms) : 0, 7266
Telemetry [candidate] (7.048 ms) : 0, 7048
section profiling
BytebuddyAgent [baseline] (677.654 ms) : 0, 677654
BytebuddyAgent [candidate] (680.647 ms) : 0, 680647
GlobalTracer [baseline] (395.801 ms) : 0, 395801
GlobalTracer [candidate] (397.952 ms) : 0, 397952
AppSec [baseline] (54.877 ms) : 0, 54877
AppSec [candidate] (54.841 ms) : 0, 54841
Remote Config [baseline] (675.759 µs) : 0, 676
Remote Config [candidate] (654.925 µs) : 0, 655
Telemetry [baseline] (7.494 ms) : 0, 7494
Telemetry [candidate] (7.541 ms) : 0, 7541
ProfilingAgent [baseline] (97.621 ms) : 0, 97621
ProfilingAgent [candidate] (97.541 ms) : 0, 97541
Profiling [baseline] (97.645 ms) : 0, 97645
Profiling [candidate] (97.565 ms) : 0, 97565
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~73dae75284, baseline=1.41.0-SNAPSHOT~919bf01a5f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071855
Total [baseline] (8.575 s) : 0, 8574648
Agent [candidate] (1.07 s) : 0, 1070378
Total [candidate] (8.574 s) : 0, 8573792
section iast
Agent [baseline] (1.2 s) : 0, 1199903
Total [baseline] (9.077 s) : 0, 9076960
Agent [candidate] (1.2 s) : 0, 1200294
Total [candidate] (9.099 s) : 0, 9098568
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.2 s) : 0, 1199746
Total [baseline] (9.096 s) : 0, 9095687
Agent [candidate] (1.203 s) : 0, 1202550
Total [candidate] (9.103 s) : 0, 9102553
section iast_TELEMETRY_OFF
Agent [baseline] (1.199 s) : 0, 1198501
Total [baseline] (9.132 s) : 0, 9132247
Agent [candidate] (1.194 s) : 0, 1194143
Total [candidate] (9.07 s) : 0, 9070435
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent iast 1.2 s 128.048 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.2 s 127.891 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.199 s 126.646 ms (11.8%)
Total tracing 8.575 s -
Total iast 9.077 s 502.312 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.096 s 521.04 ms (6.1%)
Total iast_TELEMETRY_OFF 9.132 s 557.6 ms (6.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent iast 1.2 s 129.916 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.203 s 132.172 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.194 s 123.766 ms (11.6%)
Total tracing 8.574 s -
Total iast 9.099 s 524.776 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.103 s 528.762 ms (6.2%)
Total iast_TELEMETRY_OFF 9.07 s 496.644 ms (5.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~73dae75284, baseline=1.41.0-SNAPSHOT~919bf01a5f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.688 ms) : 0, 684688
BytebuddyAgent [candidate] (682.484 ms) : 0, 682484
GlobalTracer [baseline] (311.363 ms) : 0, 311363
GlobalTracer [candidate] (311.849 ms) : 0, 311849
AppSec [baseline] (53.77 ms) : 0, 53770
AppSec [candidate] (53.931 ms) : 0, 53931
Remote Config [baseline] (653.988 µs) : 0, 654
Remote Config [candidate] (663.019 µs) : 0, 663
Telemetry [baseline] (7.588 ms) : 0, 7588
Telemetry [candidate] (7.676 ms) : 0, 7676
section iast
BytebuddyAgent [baseline] (798.587 ms) : 0, 798587
BytebuddyAgent [candidate] (799.208 ms) : 0, 799208
GlobalTracer [baseline] (301.179 ms) : 0, 301179
GlobalTracer [candidate] (301.237 ms) : 0, 301237
AppSec [baseline] (53.354 ms) : 0, 53354
AppSec [candidate] (54.123 ms) : 0, 54123
IAST [baseline] (24.434 ms) : 0, 24434
IAST [candidate] (24.23 ms) : 0, 24230
Remote Config [baseline] (611.966 µs) : 0, 612
Remote Config [candidate] (596.803 µs) : 0, 597
Telemetry [baseline] (7.907 ms) : 0, 7907
Telemetry [candidate] (7.055 ms) : 0, 7055
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.337 ms) : 0, 798337
BytebuddyAgent [candidate] (800.609 ms) : 0, 800609
GlobalTracer [baseline] (301.21 ms) : 0, 301210
GlobalTracer [candidate] (301.929 ms) : 0, 301929
AppSec [baseline] (54.925 ms) : 0, 54925
AppSec [candidate] (55.541 ms) : 0, 55541
IAST [baseline] (22.86 ms) : 0, 22860
IAST [candidate] (22.875 ms) : 0, 22875
Remote Config [baseline] (613.808 µs) : 0, 614
Remote Config [candidate] (605.277 µs) : 0, 605
Telemetry [baseline] (7.901 ms) : 0, 7901
Telemetry [candidate] (7.072 ms) : 0, 7072
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.524 ms) : 0, 797524
BytebuddyAgent [candidate] (793.772 ms) : 0, 793772
GlobalTracer [baseline] (300.749 ms) : 0, 300749
GlobalTracer [candidate] (300.698 ms) : 0, 300698
AppSec [baseline] (55.843 ms) : 0, 55843
AppSec [candidate] (55.038 ms) : 0, 55038
IAST [baseline] (22.798 ms) : 0, 22798
IAST [candidate] (23.243 ms) : 0, 23243
Remote Config [baseline] (611.905 µs) : 0, 612
Remote Config [candidate] (607.173 µs) : 0, 607
Telemetry [baseline] (7.085 ms) : 0, 7085
Telemetry [candidate] (6.947 ms) : 0, 6947
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-03T10:57:48 2024-10-03T11:04:41
git_branch master nikita-tkachenko/parent-module-context-propagation
git_commit_date 1727942449 1727952433
git_commit_sha 919bf01 73dae75
release_version 1.41.0-SNAPSHOT~919bf01a5f 1.41.0-SNAPSHOT~73dae75284
start_time 2024-10-03T10:57:34 2024-10-03T11:04:27
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727953829 1727953829
ci_job_id 659875760 659875760
ci_pipeline_id 45694124 45694124
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~73dae75284, baseline=1.41.0-SNAPSHOT~919bf01a5f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.375 ms) : 1354, 1395
.   : milestone, 1375,
appsec (1.73 ms) : 1707, 1753
.   : milestone, 1730,
appsec_no_iast (1.738 ms) : 1714, 1762
.   : milestone, 1738,
iast (1.487 ms) : 1464, 1510
.   : milestone, 1487,
profiling (1.483 ms) : 1459, 1507
.   : milestone, 1483,
tracing (1.487 ms) : 1463, 1511
.   : milestone, 1487,
section candidate
no_agent (1.343 ms) : 1324, 1363
.   : milestone, 1343,
appsec (1.725 ms) : 1702, 1748
.   : milestone, 1725,
appsec_no_iast (1.749 ms) : 1725, 1773
.   : milestone, 1749,
iast (1.499 ms) : 1476, 1522
.   : milestone, 1499,
profiling (1.49 ms) : 1465, 1515
.   : milestone, 1490,
tracing (1.463 ms) : 1439, 1488
.   : milestone, 1463,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.375 ms [1.354 ms, 1.395 ms] -
appsec 1.73 ms [1.707 ms, 1.753 ms] 355.466 µs (25.9%)
appsec_no_iast 1.738 ms [1.714 ms, 1.762 ms] 363.517 µs (26.4%)
iast 1.487 ms [1.464 ms, 1.51 ms] 112.224 µs (8.2%)
profiling 1.483 ms [1.459 ms, 1.507 ms] 108.342 µs (7.9%)
tracing 1.487 ms [1.463 ms, 1.511 ms] 112.315 µs (8.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.363 ms] -
appsec 1.725 ms [1.702 ms, 1.748 ms] 381.244 µs (28.4%)
appsec_no_iast 1.749 ms [1.725 ms, 1.773 ms] 405.152 µs (30.2%)
iast 1.499 ms [1.476 ms, 1.522 ms] 155.581 µs (11.6%)
profiling 1.49 ms [1.465 ms, 1.515 ms] 146.533 µs (10.9%)
tracing 1.463 ms [1.439 ms, 1.488 ms] 119.937 µs (8.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~73dae75284, baseline=1.41.0-SNAPSHOT~919bf01a5f
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.229 µs) : 354, 394
.   : milestone, 374,
iast (486.541 µs) : 465, 508
.   : milestone, 487,
iast_FULL (562.977 µs) : 541, 584
.   : milestone, 563,
iast_GLOBAL (518.913 µs) : 497, 541
.   : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (485.071 µs) : 464, 506
.   : milestone, 485,
iast_INACTIVE (452.119 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (480.136 µs) : 458, 502
.   : milestone, 480,
tracing (450.012 µs) : 429, 471
.   : milestone, 450,
section candidate
no_agent (372.876 µs) : 353, 393
.   : milestone, 373,
iast (495.019 µs) : 474, 516
.   : milestone, 495,
iast_FULL (559.708 µs) : 538, 581
.   : milestone, 560,
iast_GLOBAL (511.47 µs) : 490, 533
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (492.879 µs) : 471, 514
.   : milestone, 493,
iast_INACTIVE (451.453 µs) : 431, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (480.839 µs) : 459, 503
.   : milestone, 481,
tracing (440.791 µs) : 421, 461
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.229 µs [354.086 µs, 394.372 µs] -
iast 486.541 µs [465.084 µs, 507.998 µs] 112.312 µs (30.0%)
iast_FULL 562.977 µs [541.461 µs, 584.493 µs] 188.748 µs (50.4%)
iast_GLOBAL 518.913 µs [496.592 µs, 541.233 µs] 144.684 µs (38.7%)
iast_HARDCODED_SECRET_DISABLED 485.071 µs [463.901 µs, 506.241 µs] 110.842 µs (29.6%)
iast_INACTIVE 452.119 µs [431.475 µs, 472.764 µs] 77.891 µs (20.8%)
iast_TELEMETRY_OFF 480.136 µs [458.494 µs, 501.778 µs] 105.907 µs (28.3%)
tracing 450.012 µs [429.37 µs, 470.653 µs] 75.783 µs (20.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.876 µs [352.597 µs, 393.155 µs] -
iast 495.019 µs [473.666 µs, 516.372 µs] 122.143 µs (32.8%)
iast_FULL 559.708 µs [538.432 µs, 580.983 µs] 186.832 µs (50.1%)
iast_GLOBAL 511.47 µs [490.384 µs, 532.556 µs] 138.594 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED 492.879 µs [471.278 µs, 514.48 µs] 120.003 µs (32.2%)
iast_INACTIVE 451.453 µs [430.604 µs, 472.303 µs] 78.577 µs (21.1%)
iast_TELEMETRY_OFF 480.839 µs [458.931 µs, 502.747 µs] 107.963 µs (29.0%)
tracing 440.791 µs [420.751 µs, 460.83 µs] 67.915 µs (18.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/parent-module-context-propagation
git_commit_date 1727942449 1727952433
git_commit_sha 919bf01 73dae75
release_version 1.41.0-SNAPSHOT~919bf01a5f 1.41.0-SNAPSHOT~73dae75284
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727954385 1727954385
ci_job_id 659875761 659875761
ci_pipeline_id 45694124 45694124
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~73dae75284, baseline=1.41.0-SNAPSHOT~919bf01a5f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.487 s) : 15487000, 15487000
.   : milestone, 15487000,
appsec (15.143 s) : 15143000, 15143000
.   : milestone, 15143000,
iast (18.81 s) : 18810000, 18810000
.   : milestone, 18810000,
iast_GLOBAL (17.891 s) : 17891000, 17891000
.   : milestone, 17891000,
profiling (15.125 s) : 15125000, 15125000
.   : milestone, 15125000,
tracing (15.027 s) : 15027000, 15027000
.   : milestone, 15027000,
section candidate
no_agent (15.067 s) : 15067000, 15067000
.   : milestone, 15067000,
appsec (15.084 s) : 15084000, 15084000
.   : milestone, 15084000,
iast (18.81 s) : 18810000, 18810000
.   : milestone, 18810000,
iast_GLOBAL (17.849 s) : 17849000, 17849000
.   : milestone, 17849000,
profiling (15.483 s) : 15483000, 15483000
.   : milestone, 15483000,
tracing (14.988 s) : 14988000, 14988000
.   : milestone, 14988000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.487 s [15.487 s, 15.487 s] -
appsec 15.143 s [15.143 s, 15.143 s] -344.0 ms (-2.2%)
iast 18.81 s [18.81 s, 18.81 s] 3.323 s (21.5%)
iast_GLOBAL 17.891 s [17.891 s, 17.891 s] 2.404 s (15.5%)
profiling 15.125 s [15.125 s, 15.125 s] -362.0 ms (-2.3%)
tracing 15.027 s [15.027 s, 15.027 s] -460.0 ms (-3.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.067 s [15.067 s, 15.067 s] -
appsec 15.084 s [15.084 s, 15.084 s] 17.0 ms (0.1%)
iast 18.81 s [18.81 s, 18.81 s] 3.743 s (24.8%)
iast_GLOBAL 17.849 s [17.849 s, 17.849 s] 2.782 s (18.5%)
profiling 15.483 s [15.483 s, 15.483 s] 416.0 ms (2.8%)
tracing 14.988 s [14.988 s, 14.988 s] -79.0 ms (-0.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~73dae75284, baseline=1.41.0-SNAPSHOT~919bf01a5f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1481
.   : milestone, 1469,
appsec (2.34 ms) : 2299, 2381
.   : milestone, 2340,
iast (2.058 ms) : 2007, 2109
.   : milestone, 2058,
iast_GLOBAL (2.1 ms) : 2049, 2152
.   : milestone, 2100,
profiling (1.933 ms) : 1892, 1975
.   : milestone, 1933,
tracing (1.915 ms) : 1875, 1955
.   : milestone, 1915,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.318 ms) : 2277, 2359
.   : milestone, 2318,
iast (2.085 ms) : 2032, 2138
.   : milestone, 2085,
iast_GLOBAL (2.121 ms) : 2069, 2173
.   : milestone, 2121,
profiling (1.937 ms) : 1895, 1979
.   : milestone, 1937,
tracing (1.897 ms) : 1859, 1936
.   : milestone, 1897,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.481 ms] -
appsec 2.34 ms [2.299 ms, 2.381 ms] 871.219 µs (59.3%)
iast 2.058 ms [2.007 ms, 2.109 ms] 588.594 µs (40.1%)
iast_GLOBAL 2.1 ms [2.049 ms, 2.152 ms] 631.301 µs (43.0%)
profiling 1.933 ms [1.892 ms, 1.975 ms] 464.288 µs (31.6%)
tracing 1.915 ms [1.875 ms, 1.955 ms] 445.878 µs (30.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.459 ms, 1.482 ms] -
appsec 2.318 ms [2.277 ms, 2.359 ms] 847.65 µs (57.6%)
iast 2.085 ms [2.032 ms, 2.138 ms] 614.533 µs (41.8%)
iast_GLOBAL 2.121 ms [2.069 ms, 2.173 ms] 650.339 µs (44.2%)
profiling 1.937 ms [1.895 ms, 1.979 ms] 466.688 µs (31.7%)
tracing 1.897 ms [1.859 ms, 1.936 ms] 426.882 µs (29.0%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review October 2, 2024 14:57
PerfectSlayer
PerfectSlayer reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question: how does this work with 128-bit Trace IDs as you are using span.getTraceId().toLong() which drop the high 64-bit of the TID?

Another think I wonder too is if a propagator getter, based on system property, and setter, based on process builder? or map?, should not be added as part of the propagation API 🤷 -- It could be in a later PR though but I find it helpful and particularly tied to a product

PerfectSlayer
PerfectSlayer approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following internal discussion, LGTM for Platform / Core 👍

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 5a939c0 into master Oct 3, 2024
103 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/parent-module-context-propagation branch October 3, 2024 12:37
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@tonyredondo tonyredondo Awaiting requested review from tonyredondo tonyredondo is a code owner automatically assigned from DataDog/ci-app-libraries-java

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nikita-tkachenko-datadog @PerfectSlayer