Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable grpc client message span by default #7708

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Disable grpc client message span by default #7708

merged 4 commits into from
Oct 3, 2024

Conversation

amarziali
Copy link
Collaborator

@amarziali amarziali commented Oct 2, 2024 •
edited
Loading

What Does This Do

Disable grpc.message span generated by grpc-client (not server) by default. Those spans may add noise to the traces hence we are turning them off.

This will apply for both google grpc client and armeria grpc client.

However they can be enabled back by explicitly:

  • Set the system property -Ddd.integration.grpc-message.enabled=true
  • Set the env var DD_INTEGRATION_GRPC_MESSAGE_ENABLED=true

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali added tag: breaking change Breaking changes inst: grpc gRPC instrumentation labels Oct 2, 2024
@amarziali amarziali requested a review from a team as a code owner October 2, 2024 10:10
@pr-commenter
Copy link

pr-commenter bot commented Oct 2, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/grpc-client-disable-message
git_commit_date 1727883368 1727885683
git_commit_sha 530a3d1 71d5eda
release_version 1.41.0-SNAPSHOT~530a3d1cdf 1.41.0-SNAPSHOT~71d5eda669
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727888028 1727888028
ci_job_id 658980063 658980063
ci_pipeline_id 45628523 45628523
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~71d5eda669, baseline=1.41.0-SNAPSHOT~530a3d1cdf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071685
Total [baseline] (10.573 s) : 0, 10572664
Agent [candidate] (1.073 s) : 0, 1072931
Total [candidate] (10.382 s) : 0, 10381885
section appsec
Agent [baseline] (1.215 s) : 0, 1215345
Total [baseline] (10.651 s) : 0, 10651233
Agent [candidate] (1.206 s) : 0, 1205911
Total [candidate] (10.563 s) : 0, 10562543
section iast
Agent [baseline] (1.214 s) : 0, 1214022
Total [baseline] (10.927 s) : 0, 10926893
Agent [candidate] (1.194 s) : 0, 1193756
Total [candidate] (10.822 s) : 0, 10821849
section profiling
Agent [baseline] (1.269 s) : 0, 1268746
Total [baseline] (10.575 s) : 0, 10575053
Agent [candidate] (1.265 s) : 0, 1265274
Total [candidate] (10.576 s) : 0, 10576332
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent appsec 1.215 s 143.66 ms (13.4%)
Agent iast 1.214 s 142.337 ms (13.3%)
Agent profiling 1.269 s 197.061 ms (18.4%)
Total tracing 10.573 s -
Total appsec 10.651 s 78.569 ms (0.7%)
Total iast 10.927 s 354.23 ms (3.4%)
Total profiling 10.575 s 2.389 ms (0.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent appsec 1.206 s 132.98 ms (12.4%)
Agent iast 1.194 s 120.825 ms (11.3%)
Agent profiling 1.265 s 192.343 ms (17.9%)
Total tracing 10.382 s -
Total appsec 10.563 s 180.659 ms (1.7%)
Total iast 10.822 s 439.965 ms (4.2%)
Total profiling 10.576 s 194.447 ms (1.9%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~71d5eda669, baseline=1.41.0-SNAPSHOT~530a3d1cdf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.575 ms) : 0, 683575
BytebuddyAgent [candidate] (684.404 ms) : 0, 684404
GlobalTracer [baseline] (312.163 ms) : 0, 312163
GlobalTracer [candidate] (312.527 ms) : 0, 312527
AppSec [baseline] (53.977 ms) : 0, 53977
AppSec [candidate] (53.919 ms) : 0, 53919
Remote Config [baseline] (667.483 µs) : 0, 667
Remote Config [candidate] (658.399 µs) : 0, 658
Telemetry [baseline] (7.616 ms) : 0, 7616
Telemetry [candidate] (7.685 ms) : 0, 7685
section appsec
BytebuddyAgent [baseline] (706.913 ms) : 0, 706913
BytebuddyAgent [candidate] (702.008 ms) : 0, 702008
GlobalTracer [baseline] (310.608 ms) : 0, 310608
GlobalTracer [candidate] (307.824 ms) : 0, 307824
AppSec [baseline] (163.521 ms) : 0, 163521
AppSec [candidate] (162.951 ms) : 0, 162951
Remote Config [baseline] (654.351 µs) : 0, 654
Remote Config [candidate] (633.174 µs) : 0, 633
Telemetry [baseline] (9.74 ms) : 0, 9740
Telemetry [candidate] (7.438 ms) : 0, 7438
IAST [baseline] (20.162 ms) : 0, 20162
IAST [candidate] (22.69 ms) : 0, 22690
section iast
BytebuddyAgent [baseline] (810.138 ms) : 0, 810138
BytebuddyAgent [candidate] (794.604 ms) : 0, 794604
GlobalTracer [baseline] (303.676 ms) : 0, 303676
GlobalTracer [candidate] (299.727 ms) : 0, 299727
AppSec [baseline] (55.048 ms) : 0, 55048
AppSec [candidate] (52.975 ms) : 0, 52975
Remote Config [baseline] (608.793 µs) : 0, 609
Remote Config [candidate] (600.199 µs) : 0, 600
Telemetry [baseline] (7.11 ms) : 0, 7110
Telemetry [candidate] (7.018 ms) : 0, 7018
IAST [baseline] (23.552 ms) : 0, 23552
IAST [candidate] (25.209 ms) : 0, 25209
section profiling
BytebuddyAgent [baseline] (675.005 ms) : 0, 675005
BytebuddyAgent [candidate] (674.551 ms) : 0, 674551
GlobalTracer [baseline] (395.308 ms) : 0, 395308
GlobalTracer [candidate] (393.197 ms) : 0, 393197
AppSec [baseline] (54.852 ms) : 0, 54852
AppSec [candidate] (54.437 ms) : 0, 54437
Remote Config [baseline] (667.285 µs) : 0, 667
Remote Config [candidate] (661.149 µs) : 0, 661
Telemetry [baseline] (7.447 ms) : 0, 7447
Telemetry [candidate] (7.435 ms) : 0, 7435
ProfilingAgent [baseline] (96.895 ms) : 0, 96895
ProfilingAgent [candidate] (96.429 ms) : 0, 96429
Profiling [baseline] (96.918 ms) : 0, 96918
Profiling [candidate] (96.452 ms) : 0, 96452
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~71d5eda669, baseline=1.41.0-SNAPSHOT~530a3d1cdf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1073891
Total [baseline] (8.572 s) : 0, 8572232
Agent [candidate] (1.068 s) : 0, 1067717
Total [candidate] (8.56 s) : 0, 8559762
section iast
Agent [baseline] (1.195 s) : 0, 1195279
Total [baseline] (9.113 s) : 0, 9113230
Agent [candidate] (1.198 s) : 0, 1197943
Total [candidate] (9.14 s) : 0, 9140290
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.194 s) : 0, 1194333
Total [baseline] (9.054 s) : 0, 9053861
Agent [candidate] (1.2 s) : 0, 1199735
Total [candidate] (9.1 s) : 0, 9099789
section iast_TELEMETRY_OFF
Agent [baseline] (1.202 s) : 0, 1201670
Total [baseline] (9.136 s) : 0, 9135898
Agent [candidate] (1.193 s) : 0, 1193416
Total [candidate] (9.07 s) : 0, 9069657
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent iast 1.195 s 121.388 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.194 s 120.442 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.202 s 127.779 ms (11.9%)
Total tracing 8.572 s -
Total iast 9.113 s 540.998 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.054 s 481.629 ms (5.6%)
Total iast_TELEMETRY_OFF 9.136 s 563.666 ms (6.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent iast 1.198 s 130.226 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.2 s 132.018 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.193 s 125.699 ms (11.8%)
Total tracing 8.56 s -
Total iast 9.14 s 580.528 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.1 s 540.026 ms (6.3%)
Total iast_TELEMETRY_OFF 9.07 s 509.895 ms (6.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~71d5eda669, baseline=1.41.0-SNAPSHOT~530a3d1cdf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.799 ms) : 0, 685799
BytebuddyAgent [candidate] (681.213 ms) : 0, 681213
GlobalTracer [baseline] (312.189 ms) : 0, 312189
GlobalTracer [candidate] (310.824 ms) : 0, 310824
AppSec [baseline] (53.811 ms) : 0, 53811
AppSec [candidate] (53.763 ms) : 0, 53763
Remote Config [baseline] (668.988 µs) : 0, 669
Remote Config [candidate] (656.766 µs) : 0, 657
Telemetry [baseline] (7.686 ms) : 0, 7686
Telemetry [candidate] (7.623 ms) : 0, 7623
section iast
BytebuddyAgent [baseline] (795.918 ms) : 0, 795918
BytebuddyAgent [candidate] (797.374 ms) : 0, 797374
GlobalTracer [baseline] (299.571 ms) : 0, 299571
GlobalTracer [candidate] (300.418 ms) : 0, 300418
AppSec [baseline] (54.821 ms) : 0, 54821
AppSec [candidate] (55.633 ms) : 0, 55633
IAST [baseline] (23.642 ms) : 0, 23642
IAST [candidate] (22.975 ms) : 0, 22975
Remote Config [baseline] (602.58 µs) : 0, 603
Remote Config [candidate] (618.156 µs) : 0, 618
Telemetry [baseline] (7.046 ms) : 0, 7046
Telemetry [candidate] (7.197 ms) : 0, 7197
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (796.058 ms) : 0, 796058
BytebuddyAgent [candidate] (798.978 ms) : 0, 798978
GlobalTracer [baseline] (299.072 ms) : 0, 299072
GlobalTracer [candidate] (300.665 ms) : 0, 300665
AppSec [baseline] (55.123 ms) : 0, 55123
AppSec [candidate] (54.765 ms) : 0, 54765
IAST [baseline] (22.675 ms) : 0, 22675
IAST [candidate] (23.738 ms) : 0, 23738
Remote Config [baseline] (616.793 µs) : 0, 617
Remote Config [candidate] (611.296 µs) : 0, 611
Telemetry [baseline] (7.051 ms) : 0, 7051
Telemetry [candidate] (7.177 ms) : 0, 7177
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.456 ms) : 0, 800456
BytebuddyAgent [candidate] (794.394 ms) : 0, 794394
GlobalTracer [baseline] (301.595 ms) : 0, 301595
GlobalTracer [candidate] (300.09 ms) : 0, 300090
AppSec [baseline] (56.493 ms) : 0, 56493
AppSec [candidate] (55.33 ms) : 0, 55330
IAST [baseline] (21.636 ms) : 0, 21636
IAST [candidate] (22.287 ms) : 0, 22287
Remote Config [baseline] (621.478 µs) : 0, 621
Remote Config [candidate] (604.338 µs) : 0, 604
Telemetry [baseline] (7.063 ms) : 0, 7063
Telemetry [candidate] (6.966 ms) : 0, 6966
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-02T16:24:16 2024-10-02T16:31:07
git_branch master andrea.marziali/grpc-client-disable-message
git_commit_date 1727883368 1727885683
git_commit_sha 530a3d1 71d5eda
release_version 1.41.0-SNAPSHOT~530a3d1cdf 1.41.0-SNAPSHOT~71d5eda669
start_time 2024-10-02T16:24:02 2024-10-02T16:30:53
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727887014 1727887014
ci_job_id 658980064 658980064
ci_pipeline_id 45628523 45628523
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~71d5eda669, baseline=1.41.0-SNAPSHOT~530a3d1cdf
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.746 µs) : 351, 390
.   : milestone, 371,
iast (488.55 µs) : 468, 510
.   : milestone, 489,
iast_FULL (556.059 µs) : 535, 577
.   : milestone, 556,
iast_GLOBAL (512.045 µs) : 491, 533
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (484.717 µs) : 463, 506
.   : milestone, 485,
iast_INACTIVE (444.054 µs) : 423, 465
.   : milestone, 444,
iast_TELEMETRY_OFF (480.653 µs) : 459, 502
.   : milestone, 481,
tracing (446.186 µs) : 425, 467
.   : milestone, 446,
section candidate
no_agent (373.655 µs) : 353, 394
.   : milestone, 374,
iast (488.358 µs) : 467, 510
.   : milestone, 488,
iast_FULL (550.173 µs) : 529, 571
.   : milestone, 550,
iast_GLOBAL (513.769 µs) : 493, 535
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (484.607 µs) : 464, 506
.   : milestone, 485,
iast_INACTIVE (448.763 µs) : 428, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (479.694 µs) : 458, 501
.   : milestone, 480,
tracing (448.168 µs) : 428, 469
.   : milestone, 448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.746 µs [351.37 µs, 390.121 µs] -
iast 488.55 µs [467.54 µs, 509.56 µs] 117.804 µs (31.8%)
iast_FULL 556.059 µs [534.764 µs, 577.355 µs] 185.313 µs (50.0%)
iast_GLOBAL 512.045 µs [490.887 µs, 533.204 µs] 141.3 µs (38.1%)
iast_HARDCODED_SECRET_DISABLED 484.717 µs [463.48 µs, 505.954 µs] 113.971 µs (30.7%)
iast_INACTIVE 444.054 µs [423.436 µs, 464.672 µs] 73.309 µs (19.8%)
iast_TELEMETRY_OFF 480.653 µs [458.951 µs, 502.356 µs] 109.908 µs (29.6%)
tracing 446.186 µs [425.251 µs, 467.121 µs] 75.441 µs (20.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.655 µs [352.846 µs, 394.465 µs] -
iast 488.358 µs [467.098 µs, 509.618 µs] 114.703 µs (30.7%)
iast_FULL 550.173 µs [528.963 µs, 571.383 µs] 176.518 µs (47.2%)
iast_GLOBAL 513.769 µs [492.618 µs, 534.919 µs] 140.113 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED 484.607 µs [463.603 µs, 505.611 µs] 110.952 µs (29.7%)
iast_INACTIVE 448.763 µs [427.714 µs, 469.812 µs] 75.107 µs (20.1%)
iast_TELEMETRY_OFF 479.694 µs [458.345 µs, 501.043 µs] 106.038 µs (28.4%)
tracing 448.168 µs [427.522 µs, 468.814 µs] 74.512 µs (19.9%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~71d5eda669, baseline=1.41.0-SNAPSHOT~530a3d1cdf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.716 ms) : 1691, 1741
.   : milestone, 1716,
appsec_no_iast (1.71 ms) : 1685, 1735
.   : milestone, 1710,
iast (1.465 ms) : 1443, 1487
.   : milestone, 1465,
profiling (1.477 ms) : 1452, 1501
.   : milestone, 1477,
tracing (1.472 ms) : 1446, 1497
.   : milestone, 1472,
section candidate
no_agent (1.339 ms) : 1319, 1359
.   : milestone, 1339,
appsec (1.719 ms) : 1694, 1744
.   : milestone, 1719,
appsec_no_iast (1.721 ms) : 1697, 1746
.   : milestone, 1721,
iast (1.467 ms) : 1444, 1490
.   : milestone, 1467,
profiling (1.485 ms) : 1460, 1510
.   : milestone, 1485,
tracing (1.468 ms) : 1444, 1492
.   : milestone, 1468,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.362 ms] -
appsec 1.716 ms [1.691 ms, 1.741 ms] 373.349 µs (27.8%)
appsec_no_iast 1.71 ms [1.685 ms, 1.735 ms] 366.811 µs (27.3%)
iast 1.465 ms [1.443 ms, 1.487 ms] 122.427 µs (9.1%)
profiling 1.477 ms [1.452 ms, 1.501 ms] 133.761 µs (10.0%)
tracing 1.472 ms [1.446 ms, 1.497 ms] 128.693 µs (9.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.339 ms [1.319 ms, 1.359 ms] -
appsec 1.719 ms [1.694 ms, 1.744 ms] 380.008 µs (28.4%)
appsec_no_iast 1.721 ms [1.697 ms, 1.746 ms] 382.561 µs (28.6%)
iast 1.467 ms [1.444 ms, 1.49 ms] 128.409 µs (9.6%)
profiling 1.485 ms [1.46 ms, 1.51 ms] 146.006 µs (10.9%)
tracing 1.468 ms [1.444 ms, 1.492 ms] 129.412 µs (9.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/grpc-client-disable-message
git_commit_date 1727883368 1727885683
git_commit_sha 530a3d1 71d5eda
release_version 1.41.0-SNAPSHOT~530a3d1cdf 1.41.0-SNAPSHOT~71d5eda669
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727887575 1727887575
ci_job_id 658980065 658980065
ci_pipeline_id 45628523 45628523
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~71d5eda669, baseline=1.41.0-SNAPSHOT~530a3d1cdf
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.127 s) : 15127000, 15127000
.   : milestone, 15127000,
appsec (15.257 s) : 15257000, 15257000
.   : milestone, 15257000,
iast (19.124 s) : 19124000, 19124000
.   : milestone, 19124000,
iast_GLOBAL (18.085 s) : 18085000, 18085000
.   : milestone, 18085000,
profiling (15.321 s) : 15321000, 15321000
.   : milestone, 15321000,
tracing (15.372 s) : 15372000, 15372000
.   : milestone, 15372000,
section candidate
no_agent (15.511 s) : 15511000, 15511000
.   : milestone, 15511000,
appsec (15.368 s) : 15368000, 15368000
.   : milestone, 15368000,
iast (18.553 s) : 18553000, 18553000
.   : milestone, 18553000,
iast_GLOBAL (17.793 s) : 17793000, 17793000
.   : milestone, 17793000,
profiling (15.603 s) : 15603000, 15603000
.   : milestone, 15603000,
tracing (15.207 s) : 15207000, 15207000
.   : milestone, 15207000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.127 s [15.127 s, 15.127 s] -
appsec 15.257 s [15.257 s, 15.257 s] 130.0 ms (0.9%)
iast 19.124 s [19.124 s, 19.124 s] 3.997 s (26.4%)
iast_GLOBAL 18.085 s [18.085 s, 18.085 s] 2.958 s (19.6%)
profiling 15.321 s [15.321 s, 15.321 s] 194.0 ms (1.3%)
tracing 15.372 s [15.372 s, 15.372 s] 245.0 ms (1.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.511 s [15.511 s, 15.511 s] -
appsec 15.368 s [15.368 s, 15.368 s] -143.0 ms (-0.9%)
iast 18.553 s [18.553 s, 18.553 s] 3.042 s (19.6%)
iast_GLOBAL 17.793 s [17.793 s, 17.793 s] 2.282 s (14.7%)
profiling 15.603 s [15.603 s, 15.603 s] 92.0 ms (0.6%)
tracing 15.207 s [15.207 s, 15.207 s] -304.0 ms (-2.0%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~71d5eda669, baseline=1.41.0-SNAPSHOT~530a3d1cdf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1473
.   : milestone, 1462,
appsec (2.325 ms) : 2284, 2365
.   : milestone, 2325,
iast (2.07 ms) : 2019, 2121
.   : milestone, 2070,
iast_GLOBAL (2.119 ms) : 2067, 2171
.   : milestone, 2119,
profiling (1.942 ms) : 1900, 1983
.   : milestone, 1942,
tracing (1.912 ms) : 1873, 1951
.   : milestone, 1912,
section candidate
no_agent (1.466 ms) : 1454, 1477
.   : milestone, 1466,
appsec (2.317 ms) : 2276, 2359
.   : milestone, 2317,
iast (2.077 ms) : 2025, 2129
.   : milestone, 2077,
iast_GLOBAL (2.112 ms) : 2060, 2164
.   : milestone, 2112,
profiling (1.942 ms) : 1901, 1983
.   : milestone, 1942,
tracing (1.911 ms) : 1872, 1951
.   : milestone, 1911,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.473 ms] -
appsec 2.325 ms [2.284 ms, 2.365 ms] 862.675 µs (59.0%)
iast 2.07 ms [2.019 ms, 2.121 ms] 608.02 µs (41.6%)
iast_GLOBAL 2.119 ms [2.067 ms, 2.171 ms] 657.021 µs (44.9%)
profiling 1.942 ms [1.9 ms, 1.983 ms] 479.595 µs (32.8%)
tracing 1.912 ms [1.873 ms, 1.951 ms] 449.753 µs (30.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.454 ms, 1.477 ms] -
appsec 2.317 ms [2.276 ms, 2.359 ms] 851.772 µs (58.1%)
iast 2.077 ms [2.025 ms, 2.129 ms] 611.649 µs (41.7%)
iast_GLOBAL 2.112 ms [2.06 ms, 2.164 ms] 646.383 µs (44.1%)
profiling 1.942 ms [1.901 ms, 1.983 ms] 476.332 µs (32.5%)
tracing 1.911 ms [1.872 ms, 1.951 ms] 445.805 µs (30.4%)

vandonr
vandonr approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@vandonr vandonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for the code. I'm trying to think of bad things that could happen for clients who will see those span disappear, but I don't think anyone cares too much about those "technical" spans

@amarziali amarziali enabled auto-merge (squash) October 2, 2024 14:13
@amarziali amarziali requested a review from a team as a code owner October 2, 2024 15:44
@amarziali amarziali force-pushed the andrea.marziali/grpc-client-disable-message branch from dd0fd53 to 71d5eda Compare October 2, 2024 16:15
@amarziali amarziali force-pushed the andrea.marziali/grpc-client-disable-message branch from 71d5eda to 6680b9b Compare October 3, 2024 07:36
@amarziali amarziali merged commit 919bf01 into master Oct 3, 2024
93 of 100 checks passed
@amarziali amarziali deleted the andrea.marziali/grpc-client-disable-message branch October 3, 2024 08:00
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardstartin richardstartin richardstartin approved these changes

@vandonr vandonr vandonr approved these changes

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
inst: grpc gRPC instrumentation tag: breaking change Breaking changes type: enhancement
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
3 participants
@amarziali @vandonr @richardstartin