Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add taint propagation to the String indent method #7707

Merged
merged 9 commits into from
Oct 7, 2024
Merged

Add taint propagation to the String indent method #7707

merged 9 commits into from
Oct 7, 2024

Conversation

Mariovido
Copy link
Contributor

@Mariovido Mariovido commented Oct 2, 2024 •
edited
Loading

What Does This Do

This adds the instrumentation to propagate the taint values through the method of String called indent. This method are only available from version 17 of Java.

Motivation

Increase propagation of String methods

Additional Notes

Contributor Checklist

Jira ticket: APPSEC-5758

@Mariovido Mariovido added comp: asm iast Application Security Management (IAST) run-tests: ibm8 Run tests using IBM 8 JDK run-tests: semeru8 Run tests using Semuru 8 JDK run-tests: semeru11 Run tests using Sumuru 11 JDK run-tests: oracle8 Run tests using Oracle 8 JDK run-tests: zulu8 Run tests using Zulu 8 JDK run-tests: zulu11 Run tests using Zulu 11 JDK inst: java Core Java language instrumentation labels Oct 2, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 2, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mario.vidal/taint_tracking_indent
git_commit_date 1727942449 1727945475
git_commit_sha 919bf01 07d7781
release_version 1.41.0-SNAPSHOT~919bf01a5f 1.41.0-SNAPSHOT~07d7781ed1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727947910 1727947910
ci_job_id 659739839 659739839
ci_pipeline_id 45685469 45685469
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~07d7781ed1, baseline=1.41.0-SNAPSHOT~919bf01a5f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080167
Total [baseline] (10.473 s) : 0, 10472778
Agent [candidate] (1.088 s) : 0, 1088448
Total [candidate] (10.521 s) : 0, 10520733
section appsec
Agent [baseline] (1.204 s) : 0, 1204349
Total [baseline] (10.669 s) : 0, 10668557
Agent [candidate] (1.211 s) : 0, 1211093
Total [candidate] (10.645 s) : 0, 10644709
section iast
Agent [baseline] (1.199 s) : 0, 1199264
Total [baseline] (10.886 s) : 0, 10886440
Agent [candidate] (1.2 s) : 0, 1200032
Total [candidate] (10.893 s) : 0, 10892986
section profiling
Agent [baseline] (1.292 s) : 0, 1292031
Total [baseline] (10.829 s) : 0, 10829483
Agent [candidate] (1.281 s) : 0, 1281437
Total [candidate] (10.658 s) : 0, 10658263
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.204 s 124.182 ms (11.5%)
Agent iast 1.199 s 119.097 ms (11.0%)
Agent profiling 1.292 s 211.864 ms (19.6%)
Total tracing 10.473 s -
Total appsec 10.669 s 195.779 ms (1.9%)
Total iast 10.886 s 413.662 ms (3.9%)
Total profiling 10.829 s 356.705 ms (3.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.088 s -
Agent appsec 1.211 s 122.646 ms (11.3%)
Agent iast 1.2 s 111.585 ms (10.3%)
Agent profiling 1.281 s 192.989 ms (17.7%)
Total tracing 10.521 s -
Total appsec 10.645 s 123.976 ms (1.2%)
Total iast 10.893 s 372.253 ms (3.5%)
Total profiling 10.658 s 137.53 ms (1.3%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~07d7781ed1, baseline=1.41.0-SNAPSHOT~919bf01a5f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.306 ms) : 0, 689306
BytebuddyAgent [candidate] (694.464 ms) : 0, 694464
GlobalTracer [baseline] (314.444 ms) : 0, 314444
GlobalTracer [candidate] (316.942 ms) : 0, 316942
AppSec [baseline] (54.119 ms) : 0, 54119
AppSec [candidate] (54.577 ms) : 0, 54577
Remote Config [baseline] (664.492 µs) : 0, 664
Remote Config [candidate] (676.431 µs) : 0, 676
Telemetry [baseline] (7.759 ms) : 0, 7759
Telemetry [candidate] (7.799 ms) : 0, 7799
section appsec
BytebuddyAgent [baseline] (700.379 ms) : 0, 700379
BytebuddyAgent [candidate] (702.727 ms) : 0, 702727
GlobalTracer [baseline] (308.279 ms) : 0, 308279
GlobalTracer [candidate] (310.362 ms) : 0, 310362
AppSec [baseline] (163.354 ms) : 0, 163354
AppSec [candidate] (163.919 ms) : 0, 163919
IAST [baseline] (20.125 ms) : 0, 20125
IAST [candidate] (22.054 ms) : 0, 22054
Remote Config [baseline] (638.143 µs) : 0, 638
Remote Config [candidate] (641.569 µs) : 0, 642
Telemetry [baseline] (7.875 ms) : 0, 7875
Telemetry [candidate] (8.559 ms) : 0, 8559
section iast
BytebuddyAgent [baseline] (798.42 ms) : 0, 798420
BytebuddyAgent [candidate] (798.976 ms) : 0, 798976
GlobalTracer [baseline] (300.989 ms) : 0, 300989
GlobalTracer [candidate] (301.122 ms) : 0, 301122
AppSec [baseline] (54.785 ms) : 0, 54785
AppSec [candidate] (55.348 ms) : 0, 55348
IAST [baseline] (23.521 ms) : 0, 23521
IAST [candidate] (23.084 ms) : 0, 23084
Remote Config [baseline] (619.443 µs) : 0, 619
Remote Config [candidate] (606.284 µs) : 0, 606
Telemetry [baseline] (7.134 ms) : 0, 7134
Telemetry [candidate] (7.08 ms) : 0, 7080
section profiling
BytebuddyAgent [baseline] (687.661 ms) : 0, 687661
BytebuddyAgent [candidate] (683.27 ms) : 0, 683270
GlobalTracer [baseline] (401.834 ms) : 0, 401834
GlobalTracer [candidate] (398.073 ms) : 0, 398073
AppSec [baseline] (55.713 ms) : 0, 55713
AppSec [candidate] (55.037 ms) : 0, 55037
Remote Config [baseline] (665.843 µs) : 0, 666
Remote Config [candidate] (682.575 µs) : 0, 683
Telemetry [baseline] (7.639 ms) : 0, 7639
Telemetry [candidate] (7.562 ms) : 0, 7562
ProfilingAgent [baseline] (99.031 ms) : 0, 99031
ProfilingAgent [candidate] (97.574 ms) : 0, 97574
Profiling [baseline] (99.055 ms) : 0, 99055
Profiling [candidate] (97.598 ms) : 0, 97598
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~07d7781ed1, baseline=1.41.0-SNAPSHOT~919bf01a5f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081274
Total [baseline] (8.592 s) : 0, 8592477
Agent [candidate] (1.086 s) : 0, 1086258
Total [candidate] (8.665 s) : 0, 8665234
section iast
Agent [baseline] (1.202 s) : 0, 1201976
Total [baseline] (9.094 s) : 0, 9094498
Agent [candidate] (1.209 s) : 0, 1209455
Total [candidate] (9.112 s) : 0, 9112342
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.198 s) : 0, 1198479
Total [baseline] (9.106 s) : 0, 9106452
Agent [candidate] (1.202 s) : 0, 1201953
Total [candidate] (9.1 s) : 0, 9099808
section iast_TELEMETRY_OFF
Agent [baseline] (1.194 s) : 0, 1194189
Total [baseline] (9.129 s) : 0, 9128717
Agent [candidate] (1.206 s) : 0, 1205979
Total [candidate] (9.129 s) : 0, 9129338
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.202 s 120.702 ms (11.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.198 s 117.205 ms (10.8%)
Agent iast_TELEMETRY_OFF 1.194 s 112.914 ms (10.4%)
Total tracing 8.592 s -
Total iast 9.094 s 502.02 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.106 s 513.975 ms (6.0%)
Total iast_TELEMETRY_OFF 9.129 s 536.24 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent iast 1.209 s 123.196 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.202 s 115.695 ms (10.7%)
Agent iast_TELEMETRY_OFF 1.206 s 119.721 ms (11.0%)
Total tracing 8.665 s -
Total iast 9.112 s 447.108 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.1 s 434.573 ms (5.0%)
Total iast_TELEMETRY_OFF 9.129 s 464.104 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~07d7781ed1, baseline=1.41.0-SNAPSHOT~919bf01a5f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.678 ms) : 0, 690678
BytebuddyAgent [candidate] (693.736 ms) : 0, 693736
GlobalTracer [baseline] (313.9 ms) : 0, 313900
GlobalTracer [candidate] (315.704 ms) : 0, 315704
AppSec [baseline] (54.376 ms) : 0, 54376
AppSec [candidate] (54.38 ms) : 0, 54380
Remote Config [baseline] (667.957 µs) : 0, 668
Remote Config [candidate] (668.222 µs) : 0, 668
Telemetry [baseline] (7.783 ms) : 0, 7783
Telemetry [candidate] (7.789 ms) : 0, 7789
section iast
BytebuddyAgent [baseline] (800.043 ms) : 0, 800043
BytebuddyAgent [candidate] (805.709 ms) : 0, 805709
GlobalTracer [baseline] (301.692 ms) : 0, 301692
GlobalTracer [candidate] (303.347 ms) : 0, 303347
AppSec [baseline] (53.384 ms) : 0, 53384
AppSec [candidate] (55.015 ms) : 0, 55015
IAST [baseline] (25.34 ms) : 0, 25340
IAST [candidate] (23.707 ms) : 0, 23707
Remote Config [baseline] (603.041 µs) : 0, 603
Remote Config [candidate] (604.639 µs) : 0, 605
Telemetry [baseline] (7.063 ms) : 0, 7063
Telemetry [candidate] (7.146 ms) : 0, 7146
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (797.131 ms) : 0, 797131
BytebuddyAgent [candidate] (800.231 ms) : 0, 800231
GlobalTracer [baseline] (300.875 ms) : 0, 300875
GlobalTracer [candidate] (301.522 ms) : 0, 301522
AppSec [baseline] (55.834 ms) : 0, 55834
AppSec [candidate] (56.419 ms) : 0, 56419
IAST [baseline] (23.042 ms) : 0, 23042
IAST [candidate] (22.147 ms) : 0, 22147
Remote Config [baseline] (614.203 µs) : 0, 614
Remote Config [candidate] (598.609 µs) : 0, 599
Telemetry [baseline] (7.122 ms) : 0, 7122
Telemetry [candidate] (7.096 ms) : 0, 7096
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (794.465 ms) : 0, 794465
BytebuddyAgent [candidate] (802.43 ms) : 0, 802430
GlobalTracer [baseline] (299.993 ms) : 0, 299993
GlobalTracer [candidate] (302.628 ms) : 0, 302628
AppSec [baseline] (57.403 ms) : 0, 57403
AppSec [candidate] (56.32 ms) : 0, 56320
IAST [baseline] (20.798 ms) : 0, 20798
IAST [candidate] (22.935 ms) : 0, 22935
Remote Config [baseline] (624.757 µs) : 0, 625
Remote Config [candidate] (616.25 µs) : 0, 616
Telemetry [baseline] (7.073 ms) : 0, 7073
Telemetry [candidate] (7.084 ms) : 0, 7084
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-03T09:02:17 2024-10-03T09:09:11
git_branch master mario.vidal/taint_tracking_indent
git_commit_date 1727942449 1727945475
git_commit_sha 919bf01 07d7781
release_version 1.41.0-SNAPSHOT~919bf01a5f 1.41.0-SNAPSHOT~07d7781ed1
start_time 2024-10-03T09:02:04 2024-10-03T09:08:58
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727946900 1727946900
ci_job_id 659739842 659739842
ci_pipeline_id 45685469 45685469
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~07d7781ed1, baseline=1.41.0-SNAPSHOT~919bf01a5f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.336 ms) : 1316, 1355
.   : milestone, 1336,
appsec (1.736 ms) : 1712, 1760
.   : milestone, 1736,
appsec_no_iast (1.742 ms) : 1718, 1766
.   : milestone, 1742,
iast (1.487 ms) : 1464, 1509
.   : milestone, 1487,
profiling (1.491 ms) : 1466, 1516
.   : milestone, 1491,
tracing (1.465 ms) : 1441, 1489
.   : milestone, 1465,
section candidate
no_agent (1.344 ms) : 1325, 1363
.   : milestone, 1344,
appsec (1.735 ms) : 1711, 1758
.   : milestone, 1735,
appsec_no_iast (1.719 ms) : 1694, 1743
.   : milestone, 1719,
iast (1.499 ms) : 1477, 1521
.   : milestone, 1499,
profiling (1.51 ms) : 1486, 1534
.   : milestone, 1510,
tracing (1.471 ms) : 1447, 1495
.   : milestone, 1471,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.336 ms [1.316 ms, 1.355 ms] -
appsec 1.736 ms [1.712 ms, 1.76 ms] 400.173 µs (30.0%)
appsec_no_iast 1.742 ms [1.718 ms, 1.766 ms] 406.458 µs (30.4%)
iast 1.487 ms [1.464 ms, 1.509 ms] 151.094 µs (11.3%)
profiling 1.491 ms [1.466 ms, 1.516 ms] 155.798 µs (11.7%)
tracing 1.465 ms [1.441 ms, 1.489 ms] 129.52 µs (9.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.325 ms, 1.363 ms] -
appsec 1.735 ms [1.711 ms, 1.758 ms] 390.68 µs (29.1%)
appsec_no_iast 1.719 ms [1.694 ms, 1.743 ms] 374.668 µs (27.9%)
iast 1.499 ms [1.477 ms, 1.521 ms] 154.984 µs (11.5%)
profiling 1.51 ms [1.486 ms, 1.534 ms] 166.377 µs (12.4%)
tracing 1.471 ms [1.447 ms, 1.495 ms] 126.805 µs (9.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~07d7781ed1, baseline=1.41.0-SNAPSHOT~919bf01a5f
    dateFormat X
    axisFormat %s
section baseline
no_agent (373.968 µs) : 354, 394
.   : milestone, 374,
iast (491.288 µs) : 470, 512
.   : milestone, 491,
iast_FULL (558.537 µs) : 537, 580
.   : milestone, 559,
iast_GLOBAL (514.507 µs) : 493, 536
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (498.838 µs) : 478, 520
.   : milestone, 499,
iast_INACTIVE (454.844 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (481.863 µs) : 461, 503
.   : milestone, 482,
tracing (453.534 µs) : 433, 474
.   : milestone, 454,
section candidate
no_agent (370.77 µs) : 349, 393
.   : milestone, 371,
iast (496.896 µs) : 475, 519
.   : milestone, 497,
iast_FULL (558.267 µs) : 537, 579
.   : milestone, 558,
iast_GLOBAL (513.907 µs) : 492, 536
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (491.903 µs) : 471, 513
.   : milestone, 492,
iast_INACTIVE (457.694 µs) : 437, 479
.   : milestone, 458,
iast_TELEMETRY_OFF (473.795 µs) : 453, 495
.   : milestone, 474,
tracing (454.358 µs) : 434, 475
.   : milestone, 454,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.968 µs [354.084 µs, 393.851 µs] -
iast 491.288 µs [470.092 µs, 512.484 µs] 117.32 µs (31.4%)
iast_FULL 558.537 µs [537.364 µs, 579.709 µs] 184.569 µs (49.4%)
iast_GLOBAL 514.507 µs [493.126 µs, 535.889 µs] 140.54 µs (37.6%)
iast_HARDCODED_SECRET_DISABLED 498.838 µs [477.511 µs, 520.164 µs] 124.87 µs (33.4%)
iast_INACTIVE 454.844 µs [433.905 µs, 475.784 µs] 80.877 µs (21.6%)
iast_TELEMETRY_OFF 481.863 µs [460.728 µs, 502.997 µs] 107.895 µs (28.9%)
tracing 453.534 µs [432.569 µs, 474.498 µs] 79.566 µs (21.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.77 µs [348.716 µs, 392.824 µs] -
iast 496.896 µs [475.007 µs, 518.784 µs] 126.126 µs (34.0%)
iast_FULL 558.267 µs [537.095 µs, 579.44 µs] 187.497 µs (50.6%)
iast_GLOBAL 513.907 µs [491.91 µs, 535.903 µs] 143.137 µs (38.6%)
iast_HARDCODED_SECRET_DISABLED 491.903 µs [470.793 µs, 513.014 µs] 121.133 µs (32.7%)
iast_INACTIVE 457.694 µs [436.504 µs, 478.884 µs] 86.924 µs (23.4%)
iast_TELEMETRY_OFF 473.795 µs [452.731 µs, 494.859 µs] 103.025 µs (27.8%)
tracing 454.358 µs [433.815 µs, 474.901 µs] 83.588 µs (22.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mario.vidal/taint_tracking_indent
git_commit_date 1727942449 1727945475
git_commit_sha 919bf01 07d7781
release_version 1.41.0-SNAPSHOT~919bf01a5f 1.41.0-SNAPSHOT~07d7781ed1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727947306 1727947306
ci_job_id 659739846 659739846
ci_pipeline_id 45685469 45685469
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~07d7781ed1, baseline=1.41.0-SNAPSHOT~919bf01a5f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.846 s) : 15846000, 15846000
.   : milestone, 15846000,
appsec (15.162 s) : 15162000, 15162000
.   : milestone, 15162000,
iast (18.826 s) : 18826000, 18826000
.   : milestone, 18826000,
iast_GLOBAL (18.141 s) : 18141000, 18141000
.   : milestone, 18141000,
profiling (15.369 s) : 15369000, 15369000
.   : milestone, 15369000,
tracing (15.209 s) : 15209000, 15209000
.   : milestone, 15209000,
section candidate
no_agent (15.096 s) : 15096000, 15096000
.   : milestone, 15096000,
appsec (15.013 s) : 15013000, 15013000
.   : milestone, 15013000,
iast (18.71 s) : 18710000, 18710000
.   : milestone, 18710000,
iast_GLOBAL (18.353 s) : 18353000, 18353000
.   : milestone, 18353000,
profiling (15.283 s) : 15283000, 15283000
.   : milestone, 15283000,
tracing (15.454 s) : 15454000, 15454000
.   : milestone, 15454000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.846 s [15.846 s, 15.846 s] -
appsec 15.162 s [15.162 s, 15.162 s] -684.0 ms (-4.3%)
iast 18.826 s [18.826 s, 18.826 s] 2.98 s (18.8%)
iast_GLOBAL 18.141 s [18.141 s, 18.141 s] 2.295 s (14.5%)
profiling 15.369 s [15.369 s, 15.369 s] -477.0 ms (-3.0%)
tracing 15.209 s [15.209 s, 15.209 s] -637.0 ms (-4.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.096 s [15.096 s, 15.096 s] -
appsec 15.013 s [15.013 s, 15.013 s] -83.0 ms (-0.5%)
iast 18.71 s [18.71 s, 18.71 s] 3.614 s (23.9%)
iast_GLOBAL 18.353 s [18.353 s, 18.353 s] 3.257 s (21.6%)
profiling 15.283 s [15.283 s, 15.283 s] 187.0 ms (1.2%)
tracing 15.454 s [15.454 s, 15.454 s] 358.0 ms (2.4%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~07d7781ed1, baseline=1.41.0-SNAPSHOT~919bf01a5f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (2.337 ms) : 2296, 2378
.   : milestone, 2337,
iast (2.077 ms) : 2026, 2128
.   : milestone, 2077,
iast_GLOBAL (2.118 ms) : 2066, 2170
.   : milestone, 2118,
profiling (1.939 ms) : 1896, 1982
.   : milestone, 1939,
tracing (1.931 ms) : 1891, 1971
.   : milestone, 1931,
section candidate
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (2.346 ms) : 2305, 2386
.   : milestone, 2346,
iast (2.087 ms) : 2035, 2139
.   : milestone, 2087,
iast_GLOBAL (2.127 ms) : 2074, 2179
.   : milestone, 2127,
profiling (1.955 ms) : 1913, 1997
.   : milestone, 1955,
tracing (1.927 ms) : 1887, 1966
.   : milestone, 1927,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.486 ms] -
appsec 2.337 ms [2.296 ms, 2.378 ms] 862.28 µs (58.5%)
iast 2.077 ms [2.026 ms, 2.128 ms] 602.787 µs (40.9%)
iast_GLOBAL 2.118 ms [2.066 ms, 2.17 ms] 643.768 µs (43.7%)
profiling 1.939 ms [1.896 ms, 1.982 ms] 464.158 µs (31.5%)
tracing 1.931 ms [1.891 ms, 1.971 ms] 455.995 µs (30.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.486 ms] -
appsec 2.346 ms [2.305 ms, 2.386 ms] 871.143 µs (59.1%)
iast 2.087 ms [2.035 ms, 2.139 ms] 612.649 µs (41.5%)
iast_GLOBAL 2.127 ms [2.074 ms, 2.179 ms] 651.924 µs (44.2%)
profiling 1.955 ms [1.913 ms, 1.997 ms] 480.308 µs (32.6%)
tracing 1.927 ms [1.887 ms, 1.966 ms] 452.244 µs (30.7%)

@Mariovido Mariovido marked this pull request as ready for review October 2, 2024 11:07
@Mariovido Mariovido requested review from a team as code owners October 2, 2024 11:07
@amarziali amarziali removed the request for review from a team October 2, 2024 14:12
manuel-alvarez-alvarez
manuel-alvarez-alvarez approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jandro996
jandro996 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@jandro996 jandro996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Good job!

@Mariovido Mariovido merged commit dda483e into master Oct 7, 2024
144 checks passed
@Mariovido Mariovido deleted the mario.vidal/taint_tracking_indent branch October 7, 2024 07:56
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandro996 jandro996 jandro996 approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST) inst: java Core Java language instrumentation run-tests: ibm8 Run tests using IBM 8 JDK run-tests: oracle8 Run tests using Oracle 8 JDK run-tests: semeru8 Run tests using Semuru 8 JDK run-tests: semeru11 Run tests using Sumuru 11 JDK run-tests: zulu8 Run tests using Zulu 8 JDK run-tests: zulu11 Run tests using Zulu 11 JDK
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Mariovido @manuel-alvarez-alvarez @jandro996