Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure 'attempt to replace context value' logs are set to debug #7698

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Ensure 'attempt to replace context value' logs are set to debug #7698

merged 1 commit into from
Oct 2, 2024

Conversation

manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Oct 1, 2024 •
edited
Loading

What Does This Do

Ensures that duplicate addresses messages are sent only via telemetry and do not popup on customer logs.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: APPSEC-55075

@manuel-alvarez-alvarez manuel-alvarez-alvarez added type: bug comp: asm waf Application Security Management (WAF) labels Oct 1, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner October 1, 2024 11:54
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-noise-with-usr-id branch 2 times, most recently from 5ed443d to 15895b4 Compare October 1, 2024 12:05
@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title Ensure duplicate address messages logs are set to debug Ensure 'attempt to replace context value' messages logs are set to debug Oct 1, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title Ensure 'attempt to replace context value' messages logs are set to debug Ensure 'attempt to replace context value' logs are set to debug Oct 1, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 1, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/waf-noise-with-usr-id
git_commit_date 1727781530 1727784889
git_commit_sha 794ff14 9bd156d
release_version 1.41.0-SNAPSHOT~794ff14344 1.41.0-SNAPSHOT~9bd156df53
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727787426 1727787426
ci_job_id 656929590 656929590
ci_pipeline_id 45506218 45506218
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 11 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast:AppSec better
[-7.372ms; -1.847ms] or [-13.083%; -3.278%]		 51.739ms 56.348ms
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~9bd156df53, baseline=1.41.0-SNAPSHOT~794ff14344

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078378
Total [baseline] (8.591 s) : 0, 8591034
Agent [candidate] (1.076 s) : 0, 1075580
Total [candidate] (8.552 s) : 0, 8551606
section iast
Agent [baseline] (1.211 s) : 0, 1210973
Total [baseline] (9.11 s) : 0, 9110162
Agent [candidate] (1.197 s) : 0, 1196770
Total [candidate] (9.082 s) : 0, 9081679
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.209 s) : 0, 1209491
Total [baseline] (9.114 s) : 0, 9113582
Agent [candidate] (1.198 s) : 0, 1198271
Total [candidate] (9.11 s) : 0, 9109591
section iast_TELEMETRY_OFF
Agent [baseline] (1.201 s) : 0, 1200731
Total [baseline] (9.081 s) : 0, 9080505
Agent [candidate] (1.2 s) : 0, 1200069
Total [candidate] (9.083 s) : 0, 9082601
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent iast 1.211 s 132.595 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.209 s 131.112 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.201 s 122.353 ms (11.3%)
Total tracing 8.591 s -
Total iast 9.11 s 519.128 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.114 s 522.548 ms (6.1%)
Total iast_TELEMETRY_OFF 9.081 s 489.471 ms (5.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.197 s 121.19 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.198 s 122.691 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.2 s 124.489 ms (11.6%)
Total tracing 8.552 s -
Total iast 9.082 s 530.073 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.11 s 557.985 ms (6.5%)
Total iast_TELEMETRY_OFF 9.083 s 530.995 ms (6.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~9bd156df53, baseline=1.41.0-SNAPSHOT~794ff14344

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.87 ms) : 0, 689870
BytebuddyAgent [candidate] (686.852 ms) : 0, 686852
GlobalTracer [baseline] (311.955 ms) : 0, 311955
GlobalTracer [candidate] (312.731 ms) : 0, 312731
AppSec [baseline] (54.265 ms) : 0, 54265
AppSec [candidate] (53.921 ms) : 0, 53921
Remote Config [baseline] (676.471 µs) : 0, 676
Remote Config [candidate] (657.171 µs) : 0, 657
Telemetry [baseline] (7.79 ms) : 0, 7790
Telemetry [candidate] (7.616 ms) : 0, 7616
section iast
BytebuddyAgent [baseline] (807.362 ms) : 0, 807362
BytebuddyAgent [candidate] (796.486 ms) : 0, 796486
GlobalTracer [baseline] (303.322 ms) : 0, 303322
GlobalTracer [candidate] (300.465 ms) : 0, 300465
AppSec [baseline] (56.348 ms) : 0, 56348
AppSec [candidate] (51.739 ms) : 0, 51739
IAST [baseline] (22.275 ms) : 0, 22275
IAST [candidate] (26.786 ms) : 0, 26786
Remote Config [baseline] (623.916 µs) : 0, 624
Remote Config [candidate] (615.1 µs) : 0, 615
Telemetry [baseline] (7.126 ms) : 0, 7126
Telemetry [candidate] (6.921 ms) : 0, 6921
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.511 ms) : 0, 807511
BytebuddyAgent [candidate] (797.066 ms) : 0, 797066
GlobalTracer [baseline] (301.787 ms) : 0, 301787
GlobalTracer [candidate] (300.131 ms) : 0, 300131
AppSec [baseline] (54.689 ms) : 0, 54689
AppSec [candidate] (53.031 ms) : 0, 53031
IAST [baseline] (23.719 ms) : 0, 23719
IAST [candidate] (26.483 ms) : 0, 26483
Remote Config [baseline] (627.96 µs) : 0, 628
Remote Config [candidate] (617.961 µs) : 0, 618
Telemetry [baseline] (7.169 ms) : 0, 7169
Telemetry [candidate] (7.118 ms) : 0, 7118
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.055 ms) : 0, 799055
BytebuddyAgent [candidate] (798.174 ms) : 0, 798174
GlobalTracer [baseline] (302.037 ms) : 0, 302037
GlobalTracer [candidate] (302.029 ms) : 0, 302029
AppSec [baseline] (55.084 ms) : 0, 55084
AppSec [candidate] (55.254 ms) : 0, 55254
IAST [baseline] (23.3 ms) : 0, 23300
IAST [candidate] (23.32 ms) : 0, 23320
Remote Config [baseline] (606.194 µs) : 0, 606
Remote Config [candidate] (619.093 µs) : 0, 619
Telemetry [baseline] (6.852 ms) : 0, 6852
Telemetry [candidate] (6.827 ms) : 0, 6827
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~9bd156df53, baseline=1.41.0-SNAPSHOT~794ff14344

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067450
Total [baseline] (10.379 s) : 0, 10378807
Agent [candidate] (1.07 s) : 0, 1069845
Total [candidate] (10.418 s) : 0, 10417859
section appsec
Agent [baseline] (1.201 s) : 0, 1201377
Total [baseline] (10.592 s) : 0, 10592160
Agent [candidate] (1.205 s) : 0, 1205393
Total [candidate] (10.669 s) : 0, 10668548
section iast
Agent [baseline] (1.206 s) : 0, 1205625
Total [baseline] (10.863 s) : 0, 10862570
Agent [candidate] (1.203 s) : 0, 1203474
Total [candidate] (10.86 s) : 0, 10859740
section profiling
Agent [baseline] (1.264 s) : 0, 1264348
Total [baseline] (10.558 s) : 0, 10558070
Agent [candidate] (1.271 s) : 0, 1271042
Total [candidate] (10.612 s) : 0, 10611718
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent appsec 1.201 s 133.927 ms (12.5%)
Agent iast 1.206 s 138.175 ms (12.9%)
Agent profiling 1.264 s 196.898 ms (18.4%)
Total tracing 10.379 s -
Total appsec 10.592 s 213.353 ms (2.1%)
Total iast 10.863 s 483.762 ms (4.7%)
Total profiling 10.558 s 179.262 ms (1.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent appsec 1.205 s 135.548 ms (12.7%)
Agent iast 1.203 s 133.629 ms (12.5%)
Agent profiling 1.271 s 201.196 ms (18.8%)
Total tracing 10.418 s -
Total appsec 10.669 s 250.69 ms (2.4%)
Total iast 10.86 s 441.881 ms (4.2%)
Total profiling 10.612 s 193.859 ms (1.9%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~9bd156df53, baseline=1.41.0-SNAPSHOT~794ff14344

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.559 ms) : 0, 681559
BytebuddyAgent [candidate] (682.738 ms) : 0, 682738
GlobalTracer [baseline] (310.013 ms) : 0, 310013
GlobalTracer [candidate] (311.05 ms) : 0, 311050
AppSec [baseline] (53.933 ms) : 0, 53933
AppSec [candidate] (54.002 ms) : 0, 54002
Remote Config [baseline] (668.181 µs) : 0, 668
Remote Config [candidate] (687.764 µs) : 0, 688
Telemetry [baseline] (7.643 ms) : 0, 7643
Telemetry [candidate] (7.695 ms) : 0, 7695
section appsec
BytebuddyAgent [baseline] (697.87 ms) : 0, 697870
BytebuddyAgent [candidate] (701.489 ms) : 0, 701489
GlobalTracer [baseline] (307.396 ms) : 0, 307396
GlobalTracer [candidate] (308.295 ms) : 0, 308295
AppSec [baseline] (164.354 ms) : 0, 164354
AppSec [candidate] (161.656 ms) : 0, 161656
IAST [baseline] (18.503 ms) : 0, 18503
IAST [candidate] (22.634 ms) : 0, 22634
Remote Config [baseline] (640.676 µs) : 0, 641
Remote Config [candidate] (646.3 µs) : 0, 646
Telemetry [baseline] (8.209 ms) : 0, 8209
Telemetry [candidate] (8.256 ms) : 0, 8256
section iast
BytebuddyAgent [baseline] (803.827 ms) : 0, 803827
BytebuddyAgent [candidate] (801.369 ms) : 0, 801369
GlobalTracer [baseline] (301.57 ms) : 0, 301570
GlobalTracer [candidate] (301.858 ms) : 0, 301858
AppSec [baseline] (55.668 ms) : 0, 55668
AppSec [candidate] (53.975 ms) : 0, 53975
IAST [baseline] (23.071 ms) : 0, 23071
IAST [candidate] (24.768 ms) : 0, 24768
Remote Config [baseline] (616.339 µs) : 0, 616
Remote Config [candidate] (624.919 µs) : 0, 625
Telemetry [baseline] (7.062 ms) : 0, 7062
Telemetry [candidate] (7.108 ms) : 0, 7108
section profiling
BytebuddyAgent [baseline] (674.704 ms) : 0, 674704
BytebuddyAgent [candidate] (675.806 ms) : 0, 675806
GlobalTracer [baseline] (392.381 ms) : 0, 392381
GlobalTracer [candidate] (395.059 ms) : 0, 395059
AppSec [baseline] (54.446 ms) : 0, 54446
AppSec [candidate] (55.2 ms) : 0, 55200
Remote Config [baseline] (662.335 µs) : 0, 662
Remote Config [candidate] (656.802 µs) : 0, 657
Telemetry [baseline] (7.405 ms) : 0, 7405
Telemetry [candidate] (7.501 ms) : 0, 7501
ProfilingAgent [baseline] (96.156 ms) : 0, 96156
ProfilingAgent [candidate] (98.133 ms) : 0, 98133
Profiling [baseline] (96.18 ms) : 0, 96180
Profiling [candidate] (98.157 ms) : 0, 98157
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-01T12:29:42 2024-10-01T12:36:34
git_branch master malvarez/waf-noise-with-usr-id
git_commit_date 1727781530 1727784889
git_commit_sha 794ff14 9bd156d
release_version 1.41.0-SNAPSHOT~794ff14344 1.41.0-SNAPSHOT~9bd156df53
start_time 2024-10-01T12:29:29 2024-10-01T12:36:21
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727786541 1727786541
ci_job_id 656929591 656929591
ci_pipeline_id 45506218 45506218
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~9bd156df53, baseline=1.41.0-SNAPSHOT~794ff14344
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.801 µs) : 353, 392
.   : milestone, 373,
iast (487.833 µs) : 466, 509
.   : milestone, 488,
iast_FULL (557.767 µs) : 537, 579
.   : milestone, 558,
iast_GLOBAL (507.818 µs) : 486, 529
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (486.154 µs) : 465, 507
.   : milestone, 486,
iast_INACTIVE (453.583 µs) : 432, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (479.602 µs) : 458, 501
.   : milestone, 480,
tracing (448.662 µs) : 427, 470
.   : milestone, 449,
section candidate
no_agent (374.762 µs) : 355, 394
.   : milestone, 375,
iast (484.362 µs) : 463, 505
.   : milestone, 484,
iast_FULL (552.906 µs) : 532, 574
.   : milestone, 553,
iast_GLOBAL (513.23 µs) : 491, 535
.   : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (490.069 µs) : 468, 512
.   : milestone, 490,
iast_INACTIVE (451.891 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (482.351 µs) : 461, 504
.   : milestone, 482,
tracing (451.338 µs) : 430, 472
.   : milestone, 451,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.801 µs [353.422 µs, 392.18 µs] -
iast 487.833 µs [466.361 µs, 509.304 µs] 115.031 µs (30.9%)
iast_FULL 557.767 µs [536.61 µs, 578.924 µs] 184.966 µs (49.6%)
iast_GLOBAL 507.818 µs [486.221 µs, 529.416 µs] 135.017 µs (36.2%)
iast_HARDCODED_SECRET_DISABLED 486.154 µs [465.0 µs, 507.308 µs] 113.353 µs (30.4%)
iast_INACTIVE 453.583 µs [432.196 µs, 474.971 µs] 80.782 µs (21.7%)
iast_TELEMETRY_OFF 479.602 µs [458.462 µs, 500.741 µs] 106.8 µs (28.6%)
tracing 448.662 µs [427.388 µs, 469.937 µs] 75.861 µs (20.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.762 µs [355.298 µs, 394.225 µs] -
iast 484.362 µs [463.3 µs, 505.424 µs] 109.6 µs (29.2%)
iast_FULL 552.906 µs [531.689 µs, 574.124 µs] 178.144 µs (47.5%)
iast_GLOBAL 513.23 µs [491.361 µs, 535.099 µs] 138.468 µs (36.9%)
iast_HARDCODED_SECRET_DISABLED 490.069 µs [468.397 µs, 511.741 µs] 115.307 µs (30.8%)
iast_INACTIVE 451.891 µs [431.019 µs, 472.763 µs] 77.129 µs (20.6%)
iast_TELEMETRY_OFF 482.351 µs [460.8 µs, 503.903 µs] 107.59 µs (28.7%)
tracing 451.338 µs [430.196 µs, 472.479 µs] 76.576 µs (20.4%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~9bd156df53, baseline=1.41.0-SNAPSHOT~794ff14344
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.34 ms) : 1321, 1359
.   : milestone, 1340,
appsec (1.716 ms) : 1692, 1741
.   : milestone, 1716,
appsec_no_iast (1.714 ms) : 1689, 1739
.   : milestone, 1714,
iast (1.481 ms) : 1459, 1504
.   : milestone, 1481,
profiling (1.517 ms) : 1492, 1542
.   : milestone, 1517,
tracing (1.459 ms) : 1434, 1484
.   : milestone, 1459,
section candidate
no_agent (1.327 ms) : 1307, 1347
.   : milestone, 1327,
appsec (1.716 ms) : 1692, 1740
.   : milestone, 1716,
appsec_no_iast (1.689 ms) : 1665, 1713
.   : milestone, 1689,
iast (1.47 ms) : 1447, 1493
.   : milestone, 1470,
profiling (1.508 ms) : 1482, 1533
.   : milestone, 1508,
tracing (1.476 ms) : 1452, 1500
.   : milestone, 1476,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.34 ms [1.321 ms, 1.359 ms] -
appsec 1.716 ms [1.692 ms, 1.741 ms] 376.429 µs (28.1%)
appsec_no_iast 1.714 ms [1.689 ms, 1.739 ms] 374.323 µs (27.9%)
iast 1.481 ms [1.459 ms, 1.504 ms] 141.708 µs (10.6%)
profiling 1.517 ms [1.492 ms, 1.542 ms] 176.916 µs (13.2%)
tracing 1.459 ms [1.434 ms, 1.484 ms] 119.217 µs (8.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.327 ms [1.307 ms, 1.347 ms] -
appsec 1.716 ms [1.692 ms, 1.74 ms] 388.923 µs (29.3%)
appsec_no_iast 1.689 ms [1.665 ms, 1.713 ms] 362.082 µs (27.3%)
iast 1.47 ms [1.447 ms, 1.493 ms] 142.825 µs (10.8%)
profiling 1.508 ms [1.482 ms, 1.533 ms] 180.609 µs (13.6%)
tracing 1.476 ms [1.452 ms, 1.5 ms] 149.346 µs (11.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/waf-noise-with-usr-id
git_commit_date 1727781530 1727784889
git_commit_sha 794ff14 9bd156d
release_version 1.41.0-SNAPSHOT~794ff14344 1.41.0-SNAPSHOT~9bd156df53
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727787111 1727787111
ci_job_id 656929593 656929593
ci_pipeline_id 45506218 45506218
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~9bd156df53, baseline=1.41.0-SNAPSHOT~794ff14344
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.32 ms) : 2280, 2361
.   : milestone, 2320,
iast (2.074 ms) : 2022, 2125
.   : milestone, 2074,
iast_GLOBAL (2.131 ms) : 2078, 2184
.   : milestone, 2131,
profiling (1.94 ms) : 1898, 1982
.   : milestone, 1940,
tracing (1.913 ms) : 1874, 1951
.   : milestone, 1913,
section candidate
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (2.32 ms) : 2280, 2360
.   : milestone, 2320,
iast (2.076 ms) : 2025, 2128
.   : milestone, 2076,
iast_GLOBAL (2.117 ms) : 2065, 2169
.   : milestone, 2117,
profiling (1.945 ms) : 1904, 1987
.   : milestone, 1945,
tracing (1.913 ms) : 1874, 1953
.   : milestone, 1913,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.462 ms, 1.485 ms] -
appsec 2.32 ms [2.28 ms, 2.361 ms] 847.074 µs (57.5%)
iast 2.074 ms [2.022 ms, 2.125 ms] 600.286 µs (40.7%)
iast_GLOBAL 2.131 ms [2.078 ms, 2.184 ms] 657.781 µs (44.6%)
profiling 1.94 ms [1.898 ms, 1.982 ms] 466.854 µs (31.7%)
tracing 1.913 ms [1.874 ms, 1.951 ms] 439.453 µs (29.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.46 ms, 1.483 ms] -
appsec 2.32 ms [2.28 ms, 2.36 ms] 848.606 µs (57.7%)
iast 2.076 ms [2.025 ms, 2.128 ms] 604.798 µs (41.1%)
iast_GLOBAL 2.117 ms [2.065 ms, 2.169 ms] 645.578 µs (43.9%)
profiling 1.945 ms [1.904 ms, 1.987 ms] 473.909 µs (32.2%)
tracing 1.913 ms [1.874 ms, 1.953 ms] 441.971 µs (30.0%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~9bd156df53, baseline=1.41.0-SNAPSHOT~794ff14344
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.997 s) : 14997000, 14997000
.   : milestone, 14997000,
appsec (14.998 s) : 14998000, 14998000
.   : milestone, 14998000,
iast (18.847 s) : 18847000, 18847000
.   : milestone, 18847000,
iast_GLOBAL (17.897 s) : 17897000, 17897000
.   : milestone, 17897000,
profiling (15.845 s) : 15845000, 15845000
.   : milestone, 15845000,
tracing (15.253 s) : 15253000, 15253000
.   : milestone, 15253000,
section candidate
no_agent (15.328 s) : 15328000, 15328000
.   : milestone, 15328000,
appsec (15.137 s) : 15137000, 15137000
.   : milestone, 15137000,
iast (18.905 s) : 18905000, 18905000
.   : milestone, 18905000,
iast_GLOBAL (17.833 s) : 17833000, 17833000
.   : milestone, 17833000,
profiling (15.075 s) : 15075000, 15075000
.   : milestone, 15075000,
tracing (15.431 s) : 15431000, 15431000
.   : milestone, 15431000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.997 s [14.997 s, 14.997 s] -
appsec 14.998 s [14.998 s, 14.998 s] 1.0 ms (0.0%)
iast 18.847 s [18.847 s, 18.847 s] 3.85 s (25.7%)
iast_GLOBAL 17.897 s [17.897 s, 17.897 s] 2.9 s (19.3%)
profiling 15.845 s [15.845 s, 15.845 s] 848.0 ms (5.7%)
tracing 15.253 s [15.253 s, 15.253 s] 256.0 ms (1.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.328 s [15.328 s, 15.328 s] -
appsec 15.137 s [15.137 s, 15.137 s] -191.0 ms (-1.2%)
iast 18.905 s [18.905 s, 18.905 s] 3.577 s (23.3%)
iast_GLOBAL 17.833 s [17.833 s, 17.833 s] 2.505 s (16.3%)
profiling 15.075 s [15.075 s, 15.075 s] -253.0 ms (-1.7%)
tracing 15.431 s [15.431 s, 15.431 s] 103.0 ms (0.7%)

jandro996
jandro996 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@jandro996 jandro996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 0a80d67 into master Oct 2, 2024
101 of 102 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/waf-noise-with-usr-id branch October 2, 2024 08:09
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 2, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandro996 jandro996 jandro996 approved these changes

@ValentinZakharov ValentinZakharov ValentinZakharov approved these changes

@smola smola smola approved these changes

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) type: enhancement
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
4 participants
@manuel-alvarez-alvarez @smola @ValentinZakharov @jandro996