Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the config parameter name to enable code origin #7695

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Update the config parameter name to enable code origin #7695

merged 2 commits into from
Oct 1, 2024

Conversation

evanchooly
Copy link
Contributor

@evanchooly evanchooly commented Sep 30, 2024 •
edited by jira bot
Loading

unify that definition to one constant instead of two

What Does This Do

Updates the flag name to enable code origin for spans to bring it in the alignment with the RFC

Contributor Checklist

Jira ticket: DEBUG-2728

@evanchooly
update the config parameter name to enable code origin
d34c040 
unify that definition to one constant instead of two
@evanchooly evanchooly requested review from a team as code owners September 30, 2024 18:08
@evanchooly evanchooly requested review from shatzi, PerfectSlayer and P403n1x87 and removed request for a team and PerfectSlayer September 30, 2024 18:08
@pr-commenter
Copy link

pr-commenter bot commented Sep 30, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1727720268 1727720643
end_time 2024-09-30T18:19:03 2024-09-30T18:25:18
git_branch master evanchooly/DEBUG-2728
git_commit_sha 70ac474 d34c040
start_time 2024-09-30T18:17:49 2024-09-30T18:24:04
See matching parameters
Baseline Candidate
ci_job_id 656101699 656101699
ci_pipeline_id 45451789 45451789
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1727715281 1727715281

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-34.793µs; +42.108µs] or [-13.012%; +15.748%]		 unstable
[-47.003µs; +58.989µs] or [-15.354%; +19.269%]		 unstable
[-59.376µs; +70.169µs] or [-18.496%; +21.858%]		 unstable
[-155.876µs; +313.652µs] or [-26.262%; +52.844%]		 unstable
[-135.450op/s; +135.450op/s] or [-5.079%; +5.079%]
scenario:basic same same same unstable
[-49.213µs; +65.912µs] or [-9.271%; +12.417%]		 unstable
[-211.094op/s; +211.094op/s] or [-8.233%; +8.233%]
scenario:loop same same same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (306.129 µs) : 263, 349
.   : milestone, 306,
basic (304.918 µs) : 295, 315
.   : milestone, 305,
loop (10.302 ms) : 10276, 10329
.   : milestone, 10302,
section candidate
noprobe (312.122 µs) : 255, 369
.   : milestone, 312,
basic (297.167 µs) : 286, 309
.   : milestone, 297,
loop (10.319 ms) : 10285, 10354
.   : milestone, 10319,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 306.129 µs [263.02 µs, 349.239 µs]
basic 304.918 µs [295.101 µs, 314.735 µs]
loop 10.302 ms [10.276 ms, 10.329 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 312.122 µs [255.093 µs, 369.152 µs]
basic 297.167 µs [285.619 µs, 308.714 µs]
loop 10.319 ms [10.285 ms, 10.354 ms]

@pr-commenter
Copy link

pr-commenter bot commented Sep 30, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/DEBUG-2728
git_commit_date 1727691229 1727720782
git_commit_sha 70ac474 83bdb4e
release_version 1.40.0-SNAPSHOT~70ac474684 1.41.0-SNAPSHOT~83bdb4e2e2
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727723465 1727723465
ci_job_id 656143856 656143856
ci_pipeline_id 45454844 45454844
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~83bdb4e2e2, baseline=1.40.0-SNAPSHOT~70ac474684

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1072067
Total [baseline] (8.565 s) : 0, 8564506
Agent [candidate] (1.065 s) : 0, 1064861
Total [candidate] (8.531 s) : 0, 8531467
section iast
Agent [baseline] (1.203 s) : 0, 1202746
Total [baseline] (9.1 s) : 0, 9099954
Agent [candidate] (1.213 s) : 0, 1213240
Total [candidate] (9.128 s) : 0, 9127578
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.193 s) : 0, 1192824
Total [baseline] (9.057 s) : 0, 9056923
Agent [candidate] (1.201 s) : 0, 1201419
Total [candidate] (9.093 s) : 0, 9093446
section iast_TELEMETRY_OFF
Agent [baseline] (1.19 s) : 0, 1190404
Total [baseline] (9.041 s) : 0, 9040608
Agent [candidate] (1.206 s) : 0, 1205607
Total [candidate] (9.09 s) : 0, 9089964
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent iast 1.203 s 130.679 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.193 s 120.757 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.19 s 118.337 ms (11.0%)
Total tracing 8.565 s -
Total iast 9.1 s 535.448 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.057 s 492.417 ms (5.7%)
Total iast_TELEMETRY_OFF 9.041 s 476.102 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.213 s 148.378 ms (13.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.201 s 136.558 ms (12.8%)
Agent iast_TELEMETRY_OFF 1.206 s 140.746 ms (13.2%)
Total tracing 8.531 s -
Total iast 9.128 s 596.111 ms (7.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.093 s 561.979 ms (6.6%)
Total iast_TELEMETRY_OFF 9.09 s 558.497 ms (6.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~83bdb4e2e2, baseline=1.40.0-SNAPSHOT~70ac474684

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.929 ms) : 0, 683929
BytebuddyAgent [candidate] (680.051 ms) : 0, 680051
GlobalTracer [baseline] (311.627 ms) : 0, 311627
GlobalTracer [candidate] (309.484 ms) : 0, 309484
AppSec [baseline] (54.432 ms) : 0, 54432
AppSec [candidate] (53.377 ms) : 0, 53377
Remote Config [baseline] (668.243 µs) : 0, 668
Remote Config [candidate] (666.676 µs) : 0, 667
Telemetry [baseline] (7.769 ms) : 0, 7769
Telemetry [candidate] (7.639 ms) : 0, 7639
section iast
BytebuddyAgent [baseline] (801.483 ms) : 0, 801483
BytebuddyAgent [candidate] (808.588 ms) : 0, 808588
GlobalTracer [baseline] (301.121 ms) : 0, 301121
GlobalTracer [candidate] (303.355 ms) : 0, 303355
AppSec [baseline] (54.909 ms) : 0, 54909
AppSec [candidate] (53.995 ms) : 0, 53995
Remote Config [baseline] (627.942 µs) : 0, 628
Remote Config [candidate] (624.751 µs) : 0, 625
Telemetry [baseline] (7.054 ms) : 0, 7054
Telemetry [candidate] (7.189 ms) : 0, 7189
IAST [baseline] (23.803 ms) : 0, 23803
IAST [candidate] (25.609 ms) : 0, 25609
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (794.042 ms) : 0, 794042
BytebuddyAgent [candidate] (799.578 ms) : 0, 799578
GlobalTracer [baseline] (298.899 ms) : 0, 298899
GlobalTracer [candidate] (301.231 ms) : 0, 301231
AppSec [baseline] (54.13 ms) : 0, 54130
AppSec [candidate] (55.807 ms) : 0, 55807
Remote Config [baseline] (615.981 µs) : 0, 616
Remote Config [candidate] (638.535 µs) : 0, 639
Telemetry [baseline] (7.05 ms) : 0, 7050
Telemetry [candidate] (7.218 ms) : 0, 7218
IAST [baseline] (24.371 ms) : 0, 24371
IAST [candidate] (23.119 ms) : 0, 23119
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (791.08 ms) : 0, 791080
BytebuddyAgent [candidate] (802.639 ms) : 0, 802639
GlobalTracer [baseline] (299.883 ms) : 0, 299883
GlobalTracer [candidate] (302.774 ms) : 0, 302774
AppSec [baseline] (53.588 ms) : 0, 53588
AppSec [candidate] (55.458 ms) : 0, 55458
Remote Config [baseline] (623.46 µs) : 0, 623
Remote Config [candidate] (627.612 µs) : 0, 628
Telemetry [baseline] (6.806 ms) : 0, 6806
Telemetry [candidate] (6.932 ms) : 0, 6932
IAST [baseline] (24.771 ms) : 0, 24771
IAST [candidate] (23.286 ms) : 0, 23286
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~83bdb4e2e2, baseline=1.40.0-SNAPSHOT~70ac474684

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065440
Total [baseline] (10.373 s) : 0, 10372561
Agent [candidate] (1.066 s) : 0, 1066112
Total [candidate] (10.411 s) : 0, 10411327
section appsec
Agent [baseline] (1.206 s) : 0, 1205767
Total [baseline] (10.583 s) : 0, 10583127
Agent [candidate] (1.199 s) : 0, 1198758
Total [candidate] (10.56 s) : 0, 10560175
section iast
Agent [baseline] (1.195 s) : 0, 1195232
Total [baseline] (10.827 s) : 0, 10826911
Agent [candidate] (1.209 s) : 0, 1209358
Total [candidate] (10.831 s) : 0, 10830829
section profiling
Agent [baseline] (1.265 s) : 0, 1264507
Total [baseline] (10.575 s) : 0, 10575127
Agent [candidate] (1.265 s) : 0, 1264782
Total [candidate] (10.6 s) : 0, 10599903
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent appsec 1.206 s 140.326 ms (13.2%)
Agent iast 1.195 s 129.792 ms (12.2%)
Agent profiling 1.265 s 199.067 ms (18.7%)
Total tracing 10.373 s -
Total appsec 10.583 s 210.567 ms (2.0%)
Total iast 10.827 s 454.35 ms (4.4%)
Total profiling 10.575 s 202.566 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent appsec 1.199 s 132.646 ms (12.4%)
Agent iast 1.209 s 143.246 ms (13.4%)
Agent profiling 1.265 s 198.669 ms (18.6%)
Total tracing 10.411 s -
Total appsec 10.56 s 148.847 ms (1.4%)
Total iast 10.831 s 419.501 ms (4.0%)
Total profiling 10.6 s 188.576 ms (1.8%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~83bdb4e2e2, baseline=1.40.0-SNAPSHOT~70ac474684

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.26 ms) : 0, 680260
BytebuddyAgent [candidate] (679.988 ms) : 0, 679988
GlobalTracer [baseline] (309.663 ms) : 0, 309663
GlobalTracer [candidate] (309.94 ms) : 0, 309940
AppSec [baseline] (53.639 ms) : 0, 53639
AppSec [candidate] (54.176 ms) : 0, 54176
Remote Config [baseline] (666.994 µs) : 0, 667
Remote Config [candidate] (669.851 µs) : 0, 670
Telemetry [baseline] (7.611 ms) : 0, 7611
Telemetry [candidate] (7.735 ms) : 0, 7735
section appsec
BytebuddyAgent [baseline] (701.561 ms) : 0, 701561
BytebuddyAgent [candidate] (697.516 ms) : 0, 697516
GlobalTracer [baseline] (308.198 ms) : 0, 308198
GlobalTracer [candidate] (306.635 ms) : 0, 306635
AppSec [baseline] (162.816 ms) : 0, 162816
AppSec [candidate] (162.484 ms) : 0, 162484
Remote Config [baseline] (634.085 µs) : 0, 634
Remote Config [candidate] (643.293 µs) : 0, 643
Telemetry [baseline] (8.165 ms) : 0, 8165
Telemetry [candidate] (7.857 ms) : 0, 7857
IAST [baseline] (21.454 ms) : 0, 21454
IAST [candidate] (20.039 ms) : 0, 20039
section iast
BytebuddyAgent [baseline] (795.657 ms) : 0, 795657
BytebuddyAgent [candidate] (806.342 ms) : 0, 806342
GlobalTracer [baseline] (299.43 ms) : 0, 299430
GlobalTracer [candidate] (302.498 ms) : 0, 302498
AppSec [baseline] (53.512 ms) : 0, 53512
AppSec [candidate] (56.63 ms) : 0, 56630
Remote Config [baseline] (616.847 µs) : 0, 617
Remote Config [candidate] (638.796 µs) : 0, 639
Telemetry [baseline] (6.955 ms) : 0, 6955
Telemetry [candidate] (7.167 ms) : 0, 7167
IAST [baseline] (25.389 ms) : 0, 25389
IAST [candidate] (22.301 ms) : 0, 22301
section profiling
BytebuddyAgent [baseline] (674.265 ms) : 0, 674265
BytebuddyAgent [candidate] (674.615 ms) : 0, 674615
GlobalTracer [baseline] (392.9 ms) : 0, 392900
GlobalTracer [candidate] (392.761 ms) : 0, 392761
AppSec [baseline] (54.47 ms) : 0, 54470
AppSec [candidate] (54.648 ms) : 0, 54648
Remote Config [baseline] (661.748 µs) : 0, 662
Remote Config [candidate] (656.556 µs) : 0, 657
Telemetry [baseline] (7.41 ms) : 0, 7410
Telemetry [candidate] (7.408 ms) : 0, 7408
ProfilingAgent [baseline] (96.32 ms) : 0, 96320
ProfilingAgent [candidate] (96.177 ms) : 0, 96177
Profiling [baseline] (96.343 ms) : 0, 96343
Profiling [candidate] (96.2 ms) : 0, 96200
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-30T18:41:15 2024-09-30T18:48:07
git_branch master evanchooly/DEBUG-2728
git_commit_date 1727691229 1727720782
git_commit_sha 70ac474 83bdb4e
release_version 1.40.0-SNAPSHOT~70ac474684 1.41.0-SNAPSHOT~83bdb4e2e2
start_time 2024-09-30T18:41:01 2024-09-30T18:47:54
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727722433 1727722433
ci_job_id 656143857 656143857
ci_pipeline_id 45454844 45454844
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~83bdb4e2e2, baseline=1.40.0-SNAPSHOT~70ac474684
    dateFormat X
    axisFormat %s
section baseline
no_agent (375.285 µs) : 356, 395
.   : milestone, 375,
iast (486.114 µs) : 464, 508
.   : milestone, 486,
iast_FULL (547.619 µs) : 526, 569
.   : milestone, 548,
iast_GLOBAL (510.793 µs) : 489, 533
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (488.682 µs) : 467, 510
.   : milestone, 489,
iast_INACTIVE (443.615 µs) : 422, 465
.   : milestone, 444,
iast_TELEMETRY_OFF (466.541 µs) : 446, 488
.   : milestone, 467,
tracing (442.827 µs) : 422, 464
.   : milestone, 443,
section candidate
no_agent (367.342 µs) : 348, 387
.   : milestone, 367,
iast (480.55 µs) : 459, 502
.   : milestone, 481,
iast_FULL (546.183 µs) : 525, 567
.   : milestone, 546,
iast_GLOBAL (501.782 µs) : 481, 523
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (486.839 µs) : 466, 508
.   : milestone, 487,
iast_INACTIVE (444.718 µs) : 424, 465
.   : milestone, 445,
iast_TELEMETRY_OFF (469.56 µs) : 448, 491
.   : milestone, 470,
tracing (440.935 µs) : 420, 462
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.285 µs [355.576 µs, 394.994 µs] -
iast 486.114 µs [463.807 µs, 508.421 µs] 110.829 µs (29.5%)
iast_FULL 547.619 µs [526.083 µs, 569.155 µs] 172.334 µs (45.9%)
iast_GLOBAL 510.793 µs [488.81 µs, 532.777 µs] 135.508 µs (36.1%)
iast_HARDCODED_SECRET_DISABLED 488.682 µs [466.932 µs, 510.433 µs] 113.397 µs (30.2%)
iast_INACTIVE 443.615 µs [422.266 µs, 464.964 µs] 68.33 µs (18.2%)
iast_TELEMETRY_OFF 466.541 µs [445.545 µs, 487.537 µs] 91.256 µs (24.3%)
tracing 442.827 µs [421.987 µs, 463.668 µs] 67.542 µs (18.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.342 µs [347.984 µs, 386.699 µs] -
iast 480.55 µs [459.3 µs, 501.8 µs] 113.209 µs (30.8%)
iast_FULL 546.183 µs [524.943 µs, 567.423 µs] 178.842 µs (48.7%)
iast_GLOBAL 501.782 µs [480.578 µs, 522.985 µs] 134.44 µs (36.6%)
iast_HARDCODED_SECRET_DISABLED 486.839 µs [465.583 µs, 508.094 µs] 119.497 µs (32.5%)
iast_INACTIVE 444.718 µs [424.077 µs, 465.358 µs] 77.376 µs (21.1%)
iast_TELEMETRY_OFF 469.56 µs [448.207 µs, 490.913 µs] 102.218 µs (27.8%)
tracing 440.935 µs [420.169 µs, 461.702 µs] 73.594 µs (20.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~83bdb4e2e2, baseline=1.40.0-SNAPSHOT~70ac474684
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1363
.   : milestone, 1343,
appsec (1.712 ms) : 1688, 1736
.   : milestone, 1712,
appsec_no_iast (1.707 ms) : 1683, 1732
.   : milestone, 1707,
iast (1.475 ms) : 1453, 1497
.   : milestone, 1475,
profiling (1.483 ms) : 1459, 1508
.   : milestone, 1483,
tracing (1.471 ms) : 1447, 1495
.   : milestone, 1471,
section candidate
no_agent (1.34 ms) : 1321, 1359
.   : milestone, 1340,
appsec (1.709 ms) : 1685, 1734
.   : milestone, 1709,
appsec_no_iast (1.695 ms) : 1672, 1719
.   : milestone, 1695,
iast (1.477 ms) : 1455, 1500
.   : milestone, 1477,
profiling (1.511 ms) : 1487, 1535
.   : milestone, 1511,
tracing (1.439 ms) : 1414, 1463
.   : milestone, 1439,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.363 ms] -
appsec 1.712 ms [1.688 ms, 1.736 ms] 368.994 µs (27.5%)
appsec_no_iast 1.707 ms [1.683 ms, 1.732 ms] 364.142 µs (27.1%)
iast 1.475 ms [1.453 ms, 1.497 ms] 131.447 µs (9.8%)
profiling 1.483 ms [1.459 ms, 1.508 ms] 140.128 µs (10.4%)
tracing 1.471 ms [1.447 ms, 1.495 ms] 127.783 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.34 ms [1.321 ms, 1.359 ms] -
appsec 1.709 ms [1.685 ms, 1.734 ms] 369.163 µs (27.5%)
appsec_no_iast 1.695 ms [1.672 ms, 1.719 ms] 355.282 µs (26.5%)
iast 1.477 ms [1.455 ms, 1.5 ms] 137.364 µs (10.3%)
profiling 1.511 ms [1.487 ms, 1.535 ms] 170.833 µs (12.7%)
tracing 1.439 ms [1.414 ms, 1.463 ms] 98.463 µs (7.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/DEBUG-2728
git_commit_date 1727691229 1727720782
git_commit_sha 70ac474 83bdb4e
release_version 1.40.0-SNAPSHOT~70ac474684 1.41.0-SNAPSHOT~83bdb4e2e2
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727722968 1727722968
ci_job_id 656143858 656143858
ci_pipeline_id 45454844 45454844
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~83bdb4e2e2, baseline=1.40.0-SNAPSHOT~70ac474684
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.855 s) : 14855000, 14855000
.   : milestone, 14855000,
appsec (15.163 s) : 15163000, 15163000
.   : milestone, 15163000,
iast (18.9 s) : 18900000, 18900000
.   : milestone, 18900000,
iast_GLOBAL (17.989 s) : 17989000, 17989000
.   : milestone, 17989000,
profiling (15.881 s) : 15881000, 15881000
.   : milestone, 15881000,
tracing (15.203 s) : 15203000, 15203000
.   : milestone, 15203000,
section candidate
no_agent (15.317 s) : 15317000, 15317000
.   : milestone, 15317000,
appsec (15.049 s) : 15049000, 15049000
.   : milestone, 15049000,
iast (18.996 s) : 18996000, 18996000
.   : milestone, 18996000,
iast_GLOBAL (17.798 s) : 17798000, 17798000
.   : milestone, 17798000,
profiling (15.137 s) : 15137000, 15137000
.   : milestone, 15137000,
tracing (14.991 s) : 14991000, 14991000
.   : milestone, 14991000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.855 s [14.855 s, 14.855 s] -
appsec 15.163 s [15.163 s, 15.163 s] 308.0 ms (2.1%)
iast 18.9 s [18.9 s, 18.9 s] 4.045 s (27.2%)
iast_GLOBAL 17.989 s [17.989 s, 17.989 s] 3.134 s (21.1%)
profiling 15.881 s [15.881 s, 15.881 s] 1.026 s (6.9%)
tracing 15.203 s [15.203 s, 15.203 s] 348.0 ms (2.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.317 s [15.317 s, 15.317 s] -
appsec 15.049 s [15.049 s, 15.049 s] -268.0 ms (-1.7%)
iast 18.996 s [18.996 s, 18.996 s] 3.679 s (24.0%)
iast_GLOBAL 17.798 s [17.798 s, 17.798 s] 2.481 s (16.2%)
profiling 15.137 s [15.137 s, 15.137 s] -180.0 ms (-1.2%)
tracing 14.991 s [14.991 s, 14.991 s] -326.0 ms (-2.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~83bdb4e2e2, baseline=1.40.0-SNAPSHOT~70ac474684
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.464 ms) : 1452, 1475
.   : milestone, 1464,
appsec (2.32 ms) : 2279, 2361
.   : milestone, 2320,
iast (2.077 ms) : 2025, 2129
.   : milestone, 2077,
iast_GLOBAL (2.114 ms) : 2062, 2166
.   : milestone, 2114,
profiling (1.953 ms) : 1910, 1996
.   : milestone, 1953,
tracing (1.91 ms) : 1871, 1949
.   : milestone, 1910,
section candidate
no_agent (1.464 ms) : 1453, 1476
.   : milestone, 1464,
appsec (2.311 ms) : 2271, 2351
.   : milestone, 2311,
iast (2.061 ms) : 2010, 2112
.   : milestone, 2061,
iast_GLOBAL (2.104 ms) : 2052, 2155
.   : milestone, 2104,
profiling (1.943 ms) : 1901, 1985
.   : milestone, 1943,
tracing (1.909 ms) : 1870, 1949
.   : milestone, 1909,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.452 ms, 1.475 ms] -
appsec 2.32 ms [2.279 ms, 2.361 ms] 856.334 µs (58.5%)
iast 2.077 ms [2.025 ms, 2.129 ms] 613.427 µs (41.9%)
iast_GLOBAL 2.114 ms [2.062 ms, 2.166 ms] 650.158 µs (44.4%)
profiling 1.953 ms [1.91 ms, 1.996 ms] 489.121 µs (33.4%)
tracing 1.91 ms [1.871 ms, 1.949 ms] 446.087 µs (30.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.453 ms, 1.476 ms] -
appsec 2.311 ms [2.271 ms, 2.351 ms] 846.807 µs (57.8%)
iast 2.061 ms [2.01 ms, 2.112 ms] 596.402 µs (40.7%)
iast_GLOBAL 2.104 ms [2.052 ms, 2.155 ms] 639.411 µs (43.7%)
profiling 1.943 ms [1.901 ms, 1.985 ms] 478.791 µs (32.7%)
tracing 1.909 ms [1.87 ms, 1.949 ms] 445.196 µs (30.4%)

@PerfectSlayer PerfectSlayer added the comp: debugger Dynamic Instrumentation label Oct 1, 2024
@evanchooly evanchooly merged commit 10f0b4e into master Oct 1, 2024
103 checks passed
@evanchooly evanchooly deleted the evanchooly/DEBUG-2728 branch October 1, 2024 14:54
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbempel jpbempel jpbempel approved these changes

@shatzi shatzi Awaiting requested review from shatzi shatzi was automatically assigned from DataDog/debugger-java

@P403n1x87 P403n1x87 Awaiting requested review from P403n1x87

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
3 participants
@evanchooly @jpbempel @PerfectSlayer