Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for TRACE_HTTP_CLIENT_ERROR_STATUSES #7694

Merged
merged 8 commits into from
Oct 9, 2024
Merged

Add support for TRACE_HTTP_CLIENT_ERROR_STATUSES #7694

merged 8 commits into from
Oct 9, 2024

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Sep 30, 2024 •
edited by jira bot
Loading

What Does This Do

Add support to handle TRACE_HTTP_CLIENT_ERROR_STATUSES tag as well as the original HTTP_CLIENT_ERROR_STATUSES tag in efforts to be more consistent with the tags from other languages.

Motivation

Our goal is to make the implementation of configuration variables consistent for all languages as part of the config consistency effort listed in the following RFC.

Additional Notes

Contributor Checklist

Jira ticket: APMAPI-477

@pr-commenter
Copy link

pr-commenter bot commented Sep 30, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/client_error_statuses
git_commit_date 1728493034 1728494232
git_commit_sha 14a45ea a3e22e1
release_version 1.41.0-SNAPSHOT~14a45ea1c3 1.41.0-SNAPSHOT~a3e22e1c06
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728496667 1728496667
ci_job_id 667295748 667295748
ci_pipeline_id 46206914 46206914
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 10 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Remote Config better
[-47.940µs; -14.993µs] or [-7.645%; -2.391%]		 595.626µs 627.092µs
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~a3e22e1c06, baseline=1.41.0-SNAPSHOT~14a45ea1c3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063596
Total [baseline] (10.364 s) : 0, 10363706
Agent [candidate] (1.064 s) : 0, 1063684
Total [candidate] (10.391 s) : 0, 10390814
section appsec
Agent [baseline] (1.204 s) : 0, 1203726
Total [baseline] (10.567 s) : 0, 10566774
Agent [candidate] (1.197 s) : 0, 1197006
Total [candidate] (10.601 s) : 0, 10600696
section iast
Agent [baseline] (1.202 s) : 0, 1201612
Total [baseline] (10.844 s) : 0, 10844244
Agent [candidate] (1.203 s) : 0, 1202721
Total [candidate] (10.896 s) : 0, 10895867
section profiling
Agent [baseline] (1.274 s) : 0, 1273525
Total [baseline] (10.649 s) : 0, 10648995
Agent [candidate] (1.265 s) : 0, 1265419
Total [candidate] (10.621 s) : 0, 10620854
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.204 s 140.13 ms (13.2%)
Agent iast 1.202 s 138.016 ms (13.0%)
Agent profiling 1.274 s 209.929 ms (19.7%)
Total tracing 10.364 s -
Total appsec 10.567 s 203.068 ms (2.0%)
Total iast 10.844 s 480.538 ms (4.6%)
Total profiling 10.649 s 285.29 ms (2.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.197 s 133.322 ms (12.5%)
Agent iast 1.203 s 139.037 ms (13.1%)
Agent profiling 1.265 s 201.735 ms (19.0%)
Total tracing 10.391 s -
Total appsec 10.601 s 209.882 ms (2.0%)
Total iast 10.896 s 505.053 ms (4.9%)
Total profiling 10.621 s 230.041 ms (2.2%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~a3e22e1c06, baseline=1.41.0-SNAPSHOT~14a45ea1c3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.393 ms) : 0, 679393
BytebuddyAgent [candidate] (678.765 ms) : 0, 678765
GlobalTracer [baseline] (309.019 ms) : 0, 309019
GlobalTracer [candidate] (309.234 ms) : 0, 309234
AppSec [baseline] (53.448 ms) : 0, 53448
AppSec [candidate] (53.836 ms) : 0, 53836
Remote Config [baseline] (647.309 µs) : 0, 647
Remote Config [candidate] (649.806 µs) : 0, 650
Telemetry [baseline] (7.485 ms) : 0, 7485
Telemetry [candidate] (7.584 ms) : 0, 7584
section appsec
BytebuddyAgent [baseline] (699.222 ms) : 0, 699222
BytebuddyAgent [candidate] (695.608 ms) : 0, 695608
GlobalTracer [baseline] (308.128 ms) : 0, 308128
GlobalTracer [candidate] (306.273 ms) : 0, 306273
AppSec [baseline] (161.614 ms) : 0, 161614
AppSec [candidate] (161.75 ms) : 0, 161750
Remote Config [baseline] (638.665 µs) : 0, 639
Remote Config [candidate] (635.965 µs) : 0, 636
Telemetry [baseline] (8.879 ms) : 0, 8879
Telemetry [candidate] (7.779 ms) : 0, 7779
IAST [baseline] (23.114 ms) : 0, 23114
IAST [candidate] (22.658 ms) : 0, 22658
section iast
BytebuddyAgent [baseline] (801.052 ms) : 0, 801052
BytebuddyAgent [candidate] (802.271 ms) : 0, 802271
GlobalTracer [baseline] (300.562 ms) : 0, 300562
GlobalTracer [candidate] (300.427 ms) : 0, 300427
AppSec [baseline] (54.064 ms) : 0, 54064
AppSec [candidate] (55.556 ms) : 0, 55556
Remote Config [baseline] (610.253 µs) : 0, 610
Remote Config [candidate] (616.996 µs) : 0, 617
Telemetry [baseline] (7.062 ms) : 0, 7062
Telemetry [candidate] (7.111 ms) : 0, 7111
IAST [baseline] (24.509 ms) : 0, 24509
IAST [candidate] (22.961 ms) : 0, 22961
section profiling
BytebuddyAgent [baseline] (679.694 ms) : 0, 679694
BytebuddyAgent [candidate] (674.426 ms) : 0, 674426
GlobalTracer [baseline] (394.852 ms) : 0, 394852
GlobalTracer [candidate] (392.915 ms) : 0, 392915
AppSec [baseline] (54.902 ms) : 0, 54902
AppSec [candidate] (54.575 ms) : 0, 54575
Remote Config [baseline] (654.471 µs) : 0, 654
Remote Config [candidate] (642.329 µs) : 0, 642
Telemetry [baseline] (7.52 ms) : 0, 7520
Telemetry [candidate] (7.435 ms) : 0, 7435
ProfilingAgent [baseline] (97.008 ms) : 0, 97008
ProfilingAgent [candidate] (96.788 ms) : 0, 96788
Profiling [baseline] (97.032 ms) : 0, 97032
Profiling [candidate] (96.812 ms) : 0, 96812
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~a3e22e1c06, baseline=1.41.0-SNAPSHOT~14a45ea1c3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067917
Total [baseline] (8.588 s) : 0, 8588333
Agent [candidate] (1.071 s) : 0, 1071455
Total [candidate] (8.539 s) : 0, 8538977
section iast
Agent [baseline] (1.196 s) : 0, 1196477
Total [baseline] (9.108 s) : 0, 9107780
Agent [candidate] (1.197 s) : 0, 1196677
Total [candidate] (9.113 s) : 0, 9113200
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.206 s) : 0, 1206210
Total [baseline] (9.072 s) : 0, 9071810
Agent [candidate] (1.191 s) : 0, 1190965
Total [candidate] (9.08 s) : 0, 9079593
section iast_TELEMETRY_OFF
Agent [baseline] (1.19 s) : 0, 1190477
Total [baseline] (9.051 s) : 0, 9050745
Agent [candidate] (1.196 s) : 0, 1195998
Total [candidate] (9.113 s) : 0, 9112636
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent iast 1.196 s 128.56 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.206 s 138.293 ms (12.9%)
Agent iast_TELEMETRY_OFF 1.19 s 122.56 ms (11.5%)
Total tracing 8.588 s -
Total iast 9.108 s 519.447 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.072 s 483.477 ms (5.6%)
Total iast_TELEMETRY_OFF 9.051 s 462.412 ms (5.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent iast 1.197 s 125.222 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.191 s 119.51 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.196 s 124.544 ms (11.6%)
Total tracing 8.539 s -
Total iast 9.113 s 574.223 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.08 s 540.616 ms (6.3%)
Total iast_TELEMETRY_OFF 9.113 s 573.659 ms (6.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~a3e22e1c06, baseline=1.41.0-SNAPSHOT~14a45ea1c3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.099 ms) : 0, 682099
BytebuddyAgent [candidate] (684.268 ms) : 0, 684268
GlobalTracer [baseline] (310.099 ms) : 0, 310099
GlobalTracer [candidate] (311.362 ms) : 0, 311362
AppSec [baseline] (53.76 ms) : 0, 53760
AppSec [candidate] (53.866 ms) : 0, 53866
Remote Config [baseline] (663.653 µs) : 0, 664
Remote Config [candidate] (657.279 µs) : 0, 657
Telemetry [baseline] (7.619 ms) : 0, 7619
Telemetry [candidate] (7.547 ms) : 0, 7547
section iast
BytebuddyAgent [baseline] (798.598 ms) : 0, 798598
BytebuddyAgent [candidate] (796.935 ms) : 0, 796935
GlobalTracer [baseline] (298.541 ms) : 0, 298541
GlobalTracer [candidate] (299.554 ms) : 0, 299554
AppSec [baseline] (55.913 ms) : 0, 55913
AppSec [candidate] (55.844 ms) : 0, 55844
IAST [baseline] (21.282 ms) : 0, 21282
IAST [candidate] (22.875 ms) : 0, 22875
Remote Config [baseline] (613.382 µs) : 0, 613
Remote Config [candidate] (606.624 µs) : 0, 607
Telemetry [baseline] (7.802 ms) : 0, 7802
Telemetry [candidate] (7.12 ms) : 0, 7120
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (805.976 ms) : 0, 805976
BytebuddyAgent [candidate] (792.882 ms) : 0, 792882
GlobalTracer [baseline] (300.495 ms) : 0, 300495
GlobalTracer [candidate] (298.536 ms) : 0, 298536
AppSec [baseline] (56.745 ms) : 0, 56745
AppSec [candidate] (53.911 ms) : 0, 53911
IAST [baseline] (21.34 ms) : 0, 21340
IAST [candidate] (24.319 ms) : 0, 24319
Remote Config [baseline] (614.753 µs) : 0, 615
Remote Config [candidate] (596.642 µs) : 0, 597
Telemetry [baseline] (7.16 ms) : 0, 7160
Telemetry [candidate] (7.035 ms) : 0, 7035
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (793.07 ms) : 0, 793070
BytebuddyAgent [candidate] (796.346 ms) : 0, 796346
GlobalTracer [baseline] (298.672 ms) : 0, 298672
GlobalTracer [candidate] (300.646 ms) : 0, 300646
AppSec [baseline] (55.754 ms) : 0, 55754
AppSec [candidate] (55.513 ms) : 0, 55513
IAST [baseline] (21.657 ms) : 0, 21657
IAST [candidate] (22.262 ms) : 0, 22262
Remote Config [baseline] (627.092 µs) : 0, 627
Remote Config [candidate] (595.626 µs) : 0, 596
Telemetry [baseline] (6.984 ms) : 0, 6984
Telemetry [candidate] (6.866 ms) : 0, 6866
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-09T17:28:13 2024-10-09T17:35:05
git_branch master mhlidd/client_error_statuses
git_commit_date 1728493034 1728494232
git_commit_sha 14a45ea a3e22e1
release_version 1.41.0-SNAPSHOT~14a45ea1c3 1.41.0-SNAPSHOT~a3e22e1c06
start_time 2024-10-09T17:27:59 2024-10-09T17:34:51
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728495653 1728495653
ci_job_id 667295749 667295749
ci_pipeline_id 46206914 46206914
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 12 metrics, 15 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+57.429µs; +110.951µs] or [+3.894%; +7.522%]		 unstable
[-786.437op/s; +312.363op/s] or [-24.576%; +9.761%]		 1.559ms 2962.963op/s 1.475ms 3200.000op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~a3e22e1c06, baseline=1.41.0-SNAPSHOT~14a45ea1c3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.355 ms) : 1336, 1375
.   : milestone, 1355,
appsec (1.723 ms) : 1697, 1748
.   : milestone, 1723,
appsec_no_iast (1.711 ms) : 1686, 1736
.   : milestone, 1711,
iast (1.48 ms) : 1458, 1502
.   : milestone, 1480,
profiling (1.475 ms) : 1451, 1499
.   : milestone, 1475,
tracing (1.483 ms) : 1460, 1507
.   : milestone, 1483,
section candidate
no_agent (1.357 ms) : 1338, 1377
.   : milestone, 1357,
appsec (1.715 ms) : 1691, 1740
.   : milestone, 1715,
appsec_no_iast (1.718 ms) : 1693, 1742
.   : milestone, 1718,
iast (1.5 ms) : 1478, 1521
.   : milestone, 1500,
profiling (1.559 ms) : 1534, 1584
.   : milestone, 1559,
tracing (1.467 ms) : 1442, 1491
.   : milestone, 1467,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.336 ms, 1.375 ms] -
appsec 1.723 ms [1.697 ms, 1.748 ms] 367.283 µs (27.1%)
appsec_no_iast 1.711 ms [1.686 ms, 1.736 ms] 355.922 µs (26.3%)
iast 1.48 ms [1.458 ms, 1.502 ms] 124.411 µs (9.2%)
profiling 1.475 ms [1.451 ms, 1.499 ms] 119.676 µs (8.8%)
tracing 1.483 ms [1.46 ms, 1.507 ms] 128.186 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.357 ms [1.338 ms, 1.377 ms] -
appsec 1.715 ms [1.691 ms, 1.74 ms] 357.773 µs (26.4%)
appsec_no_iast 1.718 ms [1.693 ms, 1.742 ms] 360.325 µs (26.5%)
iast 1.5 ms [1.478 ms, 1.521 ms] 142.22 µs (10.5%)
profiling 1.559 ms [1.534 ms, 1.584 ms] 201.788 µs (14.9%)
tracing 1.467 ms [1.442 ms, 1.491 ms] 109.271 µs (8.1%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~a3e22e1c06, baseline=1.41.0-SNAPSHOT~14a45ea1c3
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.746 µs) : 355, 394
.   : milestone, 375,
iast (490.233 µs) : 469, 512
.   : milestone, 490,
iast_FULL (561.175 µs) : 540, 583
.   : milestone, 561,
iast_GLOBAL (515.131 µs) : 493, 537
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (486.084 µs) : 465, 507
.   : milestone, 486,
iast_INACTIVE (447.956 µs) : 427, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (474.61 µs) : 454, 496
.   : milestone, 475,
tracing (453.502 µs) : 432, 475
.   : milestone, 454,
section candidate
no_agent (372.969 µs) : 354, 392
.   : milestone, 373,
iast (484.032 µs) : 463, 505
.   : milestone, 484,
iast_FULL (557.423 µs) : 536, 579
.   : milestone, 557,
iast_GLOBAL (508.659 µs) : 488, 530
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (496.333 µs) : 474, 518
.   : milestone, 496,
iast_INACTIVE (455.949 µs) : 435, 477
.   : milestone, 456,
iast_TELEMETRY_OFF (477.344 µs) : 456, 499
.   : milestone, 477,
tracing (459.488 µs) : 439, 480
.   : milestone, 459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.746 µs [355.235 µs, 394.257 µs] -
iast 490.233 µs [468.75 µs, 511.715 µs] 115.487 µs (30.8%)
iast_FULL 561.175 µs [539.734 µs, 582.615 µs] 186.429 µs (49.7%)
iast_GLOBAL 515.131 µs [492.991 µs, 537.271 µs] 140.385 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED 486.084 µs [465.152 µs, 507.016 µs] 111.338 µs (29.7%)
iast_INACTIVE 447.956 µs [427.369 µs, 468.543 µs] 73.21 µs (19.5%)
iast_TELEMETRY_OFF 474.61 µs [453.634 µs, 495.585 µs] 99.864 µs (26.6%)
tracing 453.502 µs [432.496 µs, 474.508 µs] 78.756 µs (21.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.969 µs [353.547 µs, 392.391 µs] -
iast 484.032 µs [463.245 µs, 504.818 µs] 111.062 µs (29.8%)
iast_FULL 557.423 µs [536.173 µs, 578.673 µs] 184.454 µs (49.5%)
iast_GLOBAL 508.659 µs [487.592 µs, 529.726 µs] 135.69 µs (36.4%)
iast_HARDCODED_SECRET_DISABLED 496.333 µs [474.389 µs, 518.277 µs] 123.364 µs (33.1%)
iast_INACTIVE 455.949 µs [434.923 µs, 476.976 µs] 82.98 µs (22.2%)
iast_TELEMETRY_OFF 477.344 µs [455.51 µs, 499.179 µs] 104.375 µs (28.0%)
tracing 459.488 µs [438.595 µs, 480.381 µs] 86.519 µs (23.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/client_error_statuses
git_commit_date 1728493034 1728494232
git_commit_sha 14a45ea a3e22e1
release_version 1.41.0-SNAPSHOT~14a45ea1c3 1.41.0-SNAPSHOT~a3e22e1c06
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1728496168 1728496168
ci_job_id 667295750 667295750
ci_pipeline_id 46206914 46206914
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~a3e22e1c06, baseline=1.41.0-SNAPSHOT~14a45ea1c3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1472
.   : milestone, 1460,
appsec (2.31 ms) : 2269, 2350
.   : milestone, 2310,
iast (2.054 ms) : 2003, 2105
.   : milestone, 2054,
iast_GLOBAL (2.108 ms) : 2056, 2160
.   : milestone, 2108,
profiling (1.916 ms) : 1876, 1956
.   : milestone, 1916,
tracing (1.901 ms) : 1861, 1940
.   : milestone, 1901,
section candidate
no_agent (1.462 ms) : 1451, 1474
.   : milestone, 1462,
appsec (2.298 ms) : 2257, 2338
.   : milestone, 2298,
iast (2.061 ms) : 2010, 2113
.   : milestone, 2061,
iast_GLOBAL (2.097 ms) : 2045, 2149
.   : milestone, 2097,
profiling (1.918 ms) : 1878, 1958
.   : milestone, 1918,
tracing (1.895 ms) : 1856, 1934
.   : milestone, 1895,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.472 ms] -
appsec 2.31 ms [2.269 ms, 2.35 ms] 849.55 µs (58.2%)
iast 2.054 ms [2.003 ms, 2.105 ms] 593.353 µs (40.6%)
iast_GLOBAL 2.108 ms [2.056 ms, 2.16 ms] 647.219 µs (44.3%)
profiling 1.916 ms [1.876 ms, 1.956 ms] 455.38 µs (31.2%)
tracing 1.901 ms [1.861 ms, 1.94 ms] 440.591 µs (30.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.474 ms] -
appsec 2.298 ms [2.257 ms, 2.338 ms] 835.439 µs (57.1%)
iast 2.061 ms [2.01 ms, 2.113 ms] 598.91 µs (41.0%)
iast_GLOBAL 2.097 ms [2.045 ms, 2.149 ms] 634.583 µs (43.4%)
profiling 1.918 ms [1.878 ms, 1.958 ms] 455.68 µs (31.2%)
tracing 1.895 ms [1.856 ms, 1.934 ms] 432.501 µs (29.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~a3e22e1c06, baseline=1.41.0-SNAPSHOT~14a45ea1c3
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.221 s) : 15221000, 15221000
.   : milestone, 15221000,
appsec (15.176 s) : 15176000, 15176000
.   : milestone, 15176000,
iast (18.875 s) : 18875000, 18875000
.   : milestone, 18875000,
iast_GLOBAL (18.06 s) : 18060000, 18060000
.   : milestone, 18060000,
profiling (15.636 s) : 15636000, 15636000
.   : milestone, 15636000,
tracing (15.016 s) : 15016000, 15016000
.   : milestone, 15016000,
section candidate
no_agent (15.078 s) : 15078000, 15078000
.   : milestone, 15078000,
appsec (15.192 s) : 15192000, 15192000
.   : milestone, 15192000,
iast (18.754 s) : 18754000, 18754000
.   : milestone, 18754000,
iast_GLOBAL (18.011 s) : 18011000, 18011000
.   : milestone, 18011000,
profiling (14.882 s) : 14882000, 14882000
.   : milestone, 14882000,
tracing (15.114 s) : 15114000, 15114000
.   : milestone, 15114000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.221 s [15.221 s, 15.221 s] -
appsec 15.176 s [15.176 s, 15.176 s] -45.0 ms (-0.3%)
iast 18.875 s [18.875 s, 18.875 s] 3.654 s (24.0%)
iast_GLOBAL 18.06 s [18.06 s, 18.06 s] 2.839 s (18.7%)
profiling 15.636 s [15.636 s, 15.636 s] 415.0 ms (2.7%)
tracing 15.016 s [15.016 s, 15.016 s] -205.0 ms (-1.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.078 s [15.078 s, 15.078 s] -
appsec 15.192 s [15.192 s, 15.192 s] 114.0 ms (0.8%)
iast 18.754 s [18.754 s, 18.754 s] 3.676 s (24.4%)
iast_GLOBAL 18.011 s [18.011 s, 18.011 s] 2.933 s (19.5%)
profiling 14.882 s [14.882 s, 14.882 s] -196.0 ms (-1.3%)
tracing 15.114 s [15.114 s, 15.114 s] 36.0 ms (0.2%)

@mhlidd mhlidd marked this pull request as ready for review September 30, 2024 19:39
@mhlidd mhlidd requested a review from a team as a code owner September 30, 2024 19:39
@PerfectSlayer PerfectSlayer mentioned this pull request Oct 2, 2024
Merged
5 tasks
@PerfectSlayer
Copy link
Contributor

Following our discussion, I made a PR to test config alias priority here: #7706

PerfectSlayer
PerfectSlayer reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mhlidd mhlidd force-pushed the mhlidd/client_error_statuses branch from 6a874cf to bd83253 Compare October 7, 2024 14:39
@mhlidd
Copy link
Contributor Author

mhlidd commented Oct 7, 2024

@PerfectSlayer Can I get the approving review to merge this PR? 🙇‍♂️

@PerfectSlayer
Copy link
Contributor

Looks like I only comment where I meant to approve 😅

@mhlidd mhlidd merged commit 5886196 into master Oct 9, 2024
104 checks passed
@mhlidd mhlidd deleted the mhlidd/client_error_statuses branch October 9, 2024 19:18
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygree ygree ygree approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@mtoffl01 mtoffl01 Awaiting requested review from mtoffl01

Assignees
No one assigned
Labels
comp: core Tracer core type: enhancement
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mhlidd @PerfectSlayer @ygree