Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema tracking for nested messages #7690

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Fix schema tracking for nested messages #7690

merged 6 commits into from
Oct 8, 2024

Conversation

piochelepiotr
Copy link
Contributor

What Does This Do

Adds recursive protection to only get the schema of the top level message.
This was not only causing CPU overhead, but was also producing wrong data (schema name was the name of the most nested message).

I believe we have the same issue with Avro. I will open later for it once I'm able to reproduce the bug in Avro.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@piochelepiotr piochelepiotr requested a review from a team as a code owner September 27, 2024 19:45
piochelepiotr
piochelepiotr commented Sep 27, 2024
View reviewed changes
dd-java-agent/instrumentation/protobuf/src/test/groovy/readme.md Outdated
@@ -0,0 +1,14 @@
To generate the Protobuf message, we need to use an old version of protobuf (3.0.0), because we want to support the protobuf library starting at 3.0.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I struggled with that for a while ... again (I already struggled with it when I added this integration).
So I decided to add a small readme, even if it's just for future me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t we make it part of the build script by creating a custom gradle task for?
I did it in my previous company and worked well. You can even pick the version of protoc you would like to use.

@piochelepiotr piochelepiotr force-pushed the piotr-wolski/fix-bug-schema-tracking branch from d37d9c5 to 0a7e204 Compare September 27, 2024 20:04
@pr-commenter
Copy link

pr-commenter bot commented Sep 27, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master piotr-wolski/fix-bug-schema-tracking
git_commit_date 1728335917 1728340243
git_commit_sha f5b158c b9017dd
release_version 1.41.0-SNAPSHOT~f5b158c64d 1.41.0-SNAPSHOT~b9017ddc0f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728342974 1728342974
ci_job_id 664602678 664602678
ci_pipeline_id 46024762 46024762
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~b9017ddc0f, baseline=1.41.0-SNAPSHOT~f5b158c64d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080403
Total [baseline] (10.494 s) : 0, 10494380
Agent [candidate] (1.076 s) : 0, 1076438
Total [candidate] (10.384 s) : 0, 10383964
section appsec
Agent [baseline] (1.201 s) : 0, 1200948
Total [baseline] (10.567 s) : 0, 10566783
Agent [candidate] (1.199 s) : 0, 1199285
Total [candidate] (10.59 s) : 0, 10590156
section iast
Agent [baseline] (1.202 s) : 0, 1202336
Total [baseline] (10.847 s) : 0, 10846902
Agent [candidate] (1.208 s) : 0, 1208302
Total [candidate] (10.886 s) : 0, 10885957
section profiling
Agent [baseline] (1.266 s) : 0, 1266484
Total [baseline] (10.629 s) : 0, 10629284
Agent [candidate] (1.266 s) : 0, 1266246
Total [candidate] (10.614 s) : 0, 10613549
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.201 s 120.545 ms (11.2%)
Agent iast 1.202 s 121.934 ms (11.3%)
Agent profiling 1.266 s 186.081 ms (17.2%)
Total tracing 10.494 s -
Total appsec 10.567 s 72.403 ms (0.7%)
Total iast 10.847 s 352.521 ms (3.4%)
Total profiling 10.629 s 134.904 ms (1.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.199 s 122.846 ms (11.4%)
Agent iast 1.208 s 131.864 ms (12.3%)
Agent profiling 1.266 s 189.808 ms (17.6%)
Total tracing 10.384 s -
Total appsec 10.59 s 206.192 ms (2.0%)
Total iast 10.886 s 501.993 ms (4.8%)
Total profiling 10.614 s 229.585 ms (2.2%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~b9017ddc0f, baseline=1.41.0-SNAPSHOT~f5b158c64d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.086 ms) : 0, 690086
BytebuddyAgent [candidate] (686.719 ms) : 0, 686719
GlobalTracer [baseline] (313.927 ms) : 0, 313927
GlobalTracer [candidate] (313.504 ms) : 0, 313504
AppSec [baseline] (54.182 ms) : 0, 54182
AppSec [candidate] (54.077 ms) : 0, 54077
Remote Config [baseline] (671.069 µs) : 0, 671
Remote Config [candidate] (667.623 µs) : 0, 668
Telemetry [baseline] (7.709 ms) : 0, 7709
Telemetry [candidate] (7.672 ms) : 0, 7672
section appsec
BytebuddyAgent [baseline] (696.57 ms) : 0, 696570
BytebuddyAgent [candidate] (696.506 ms) : 0, 696506
GlobalTracer [baseline] (307.311 ms) : 0, 307311
GlobalTracer [candidate] (307.833 ms) : 0, 307833
AppSec [baseline] (164.735 ms) : 0, 164735
AppSec [candidate] (161.5 ms) : 0, 161500
IAST [baseline] (19.912 ms) : 0, 19912
IAST [candidate] (21.387 ms) : 0, 21387
Remote Config [baseline] (630.29 µs) : 0, 630
Remote Config [candidate] (643.619 µs) : 0, 644
Telemetry [baseline] (8.126 ms) : 0, 8126
Telemetry [candidate] (8.474 ms) : 0, 8474
section iast
BytebuddyAgent [baseline] (801.738 ms) : 0, 801738
BytebuddyAgent [candidate] (805.329 ms) : 0, 805329
GlobalTracer [baseline] (300.879 ms) : 0, 300879
GlobalTracer [candidate] (302.205 ms) : 0, 302205
AppSec [baseline] (54.568 ms) : 0, 54568
AppSec [candidate] (53.758 ms) : 0, 53758
IAST [baseline] (23.671 ms) : 0, 23671
IAST [candidate] (24.611 ms) : 0, 24611
Remote Config [baseline] (604.847 µs) : 0, 605
Remote Config [candidate] (613.094 µs) : 0, 613
Telemetry [baseline] (7.118 ms) : 0, 7118
Telemetry [candidate] (7.909 ms) : 0, 7909
section profiling
BytebuddyAgent [baseline] (674.786 ms) : 0, 674786
BytebuddyAgent [candidate] (675.774 ms) : 0, 675774
GlobalTracer [baseline] (393.429 ms) : 0, 393429
GlobalTracer [candidate] (393.089 ms) : 0, 393089
AppSec [baseline] (54.737 ms) : 0, 54737
AppSec [candidate] (54.518 ms) : 0, 54518
Remote Config [baseline] (654.589 µs) : 0, 655
Remote Config [candidate] (649.349 µs) : 0, 649
Telemetry [baseline] (7.462 ms) : 0, 7462
Telemetry [candidate] (7.452 ms) : 0, 7452
ProfilingAgent [baseline] (96.833 ms) : 0, 96833
ProfilingAgent [candidate] (96.21 ms) : 0, 96210
Profiling [baseline] (96.856 ms) : 0, 96856
Profiling [candidate] (96.234 ms) : 0, 96234
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~b9017ddc0f, baseline=1.41.0-SNAPSHOT~f5b158c64d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1075893
Total [baseline] (8.559 s) : 0, 8558542
Agent [candidate] (1.065 s) : 0, 1065355
Total [candidate] (8.556 s) : 0, 8555863
section iast
Agent [baseline] (1.193 s) : 0, 1193368
Total [baseline] (9.081 s) : 0, 9080641
Agent [candidate] (1.195 s) : 0, 1194916
Total [candidate] (9.083 s) : 0, 9083175
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.192 s) : 0, 1191801
Total [baseline] (9.04 s) : 0, 9039850
Agent [candidate] (1.205 s) : 0, 1204700
Total [candidate] (9.079 s) : 0, 9079271
section iast_TELEMETRY_OFF
Agent [baseline] (1.189 s) : 0, 1188541
Total [baseline] (9.048 s) : 0, 9048415
Agent [candidate] (1.189 s) : 0, 1188604
Total [candidate] (9.078 s) : 0, 9077690
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.193 s 117.475 ms (10.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.192 s 115.907 ms (10.8%)
Agent iast_TELEMETRY_OFF 1.189 s 112.648 ms (10.5%)
Total tracing 8.559 s -
Total iast 9.081 s 522.099 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.04 s 481.308 ms (5.6%)
Total iast_TELEMETRY_OFF 9.048 s 489.873 ms (5.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.195 s 129.561 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.205 s 139.344 ms (13.1%)
Agent iast_TELEMETRY_OFF 1.189 s 123.248 ms (11.6%)
Total tracing 8.556 s -
Total iast 9.083 s 527.313 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.079 s 523.408 ms (6.1%)
Total iast_TELEMETRY_OFF 9.078 s 521.827 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~b9017ddc0f, baseline=1.41.0-SNAPSHOT~f5b158c64d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.068 ms) : 0, 687068
BytebuddyAgent [candidate] (679.539 ms) : 0, 679539
GlobalTracer [baseline] (312.897 ms) : 0, 312897
GlobalTracer [candidate] (310.272 ms) : 0, 310272
AppSec [baseline] (53.869 ms) : 0, 53869
AppSec [candidate] (53.596 ms) : 0, 53596
Remote Config [baseline] (666.317 µs) : 0, 666
Remote Config [candidate] (667.834 µs) : 0, 668
Telemetry [baseline] (7.659 ms) : 0, 7659
Telemetry [candidate] (7.607 ms) : 0, 7607
section iast
BytebuddyAgent [baseline] (795.01 ms) : 0, 795010
BytebuddyAgent [candidate] (795.99 ms) : 0, 795990
GlobalTracer [baseline] (299.255 ms) : 0, 299255
GlobalTracer [candidate] (299.485 ms) : 0, 299485
AppSec [baseline] (56.026 ms) : 0, 56026
AppSec [candidate] (55.367 ms) : 0, 55367
IAST [baseline] (21.823 ms) : 0, 21823
IAST [candidate] (22.665 ms) : 0, 22665
Remote Config [baseline] (600.244 µs) : 0, 600
Remote Config [candidate] (612.61 µs) : 0, 613
Telemetry [baseline] (7.033 ms) : 0, 7033
Telemetry [candidate] (7.071 ms) : 0, 7071
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (794.096 ms) : 0, 794096
BytebuddyAgent [candidate] (802.989 ms) : 0, 802989
GlobalTracer [baseline] (298.751 ms) : 0, 298751
GlobalTracer [candidate] (302.52 ms) : 0, 302520
AppSec [baseline] (55.114 ms) : 0, 55114
AppSec [candidate] (53.955 ms) : 0, 53955
IAST [baseline] (22.55 ms) : 0, 22550
IAST [candidate] (23.716 ms) : 0, 23716
Remote Config [baseline] (591.341 µs) : 0, 591
Remote Config [candidate] (600.281 µs) : 0, 600
Telemetry [baseline] (7.041 ms) : 0, 7041
Telemetry [candidate] (7.091 ms) : 0, 7091
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (790.98 ms) : 0, 790980
BytebuddyAgent [candidate] (790.505 ms) : 0, 790505
GlobalTracer [baseline] (298.787 ms) : 0, 298787
GlobalTracer [candidate] (299.111 ms) : 0, 299111
AppSec [baseline] (54.596 ms) : 0, 54596
AppSec [candidate] (55.49 ms) : 0, 55490
IAST [baseline] (22.998 ms) : 0, 22998
IAST [candidate] (22.333 ms) : 0, 22333
Remote Config [baseline] (608.141 µs) : 0, 608
Remote Config [candidate] (597.508 µs) : 0, 598
Telemetry [baseline] (6.889 ms) : 0, 6889
Telemetry [candidate] (6.888 ms) : 0, 6888
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-07T22:48:03 2024-10-07T22:57:06
git_branch master piotr-wolski/fix-bug-schema-tracking
git_commit_date 1728335917 1728340243
git_commit_sha f5b158c b9017dd
release_version 1.41.0-SNAPSHOT~f5b158c64d 1.41.0-SNAPSHOT~b9017ddc0f
start_time 2024-10-07T22:47:47 2024-10-07T22:56:49
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728342284 1728342284
ci_job_id 664602679 664602679
ci_pipeline_id 46024762 46024762
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 22 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~b9017ddc0f, baseline=1.41.0-SNAPSHOT~f5b158c64d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.697 ms) : 1673, 1722
.   : milestone, 1697,
appsec (2.157 ms) : 2126, 2188
.   : milestone, 2157,
appsec_no_iast (2.17 ms) : 2138, 2202
.   : milestone, 2170,
iast (1.896 ms) : 1865, 1928
.   : milestone, 1896,
profiling (1.896 ms) : 1863, 1929
.   : milestone, 1896,
tracing (1.858 ms) : 1826, 1890
.   : milestone, 1858,
section candidate
no_agent (1.717 ms) : 1693, 1741
.   : milestone, 1717,
appsec (2.214 ms) : 2184, 2245
.   : milestone, 2214,
appsec_no_iast (2.206 ms) : 2174, 2237
.   : milestone, 2206,
iast (1.87 ms) : 1839, 1902
.   : milestone, 1870,
profiling (1.903 ms) : 1868, 1938
.   : milestone, 1903,
tracing (1.854 ms) : 1822, 1886
.   : milestone, 1854,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.697 ms [1.673 ms, 1.722 ms] -
appsec 2.157 ms [2.126 ms, 2.188 ms] 459.362 µs (27.1%)
appsec_no_iast 2.17 ms [2.138 ms, 2.202 ms] 472.952 µs (27.9%)
iast 1.896 ms [1.865 ms, 1.928 ms] 199.109 µs (11.7%)
profiling 1.896 ms [1.863 ms, 1.929 ms] 198.731 µs (11.7%)
tracing 1.858 ms [1.826 ms, 1.89 ms] 160.445 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.717 ms [1.693 ms, 1.741 ms] -
appsec 2.214 ms [2.184 ms, 2.245 ms] 497.481 µs (29.0%)
appsec_no_iast 2.206 ms [2.174 ms, 2.237 ms] 488.84 µs (28.5%)
iast 1.87 ms [1.839 ms, 1.902 ms] 153.739 µs (9.0%)
profiling 1.903 ms [1.868 ms, 1.938 ms] 186.37 µs (10.9%)
tracing 1.854 ms [1.822 ms, 1.886 ms] 137.027 µs (8.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~b9017ddc0f, baseline=1.41.0-SNAPSHOT~f5b158c64d
    dateFormat X
    axisFormat %s
section baseline
no_agent (456.734 µs) : 427, 486
.   : milestone, 457,
iast (581.429 µs) : 550, 613
.   : milestone, 581,
iast_FULL (686.587 µs) : 654, 719
.   : milestone, 687,
iast_GLOBAL (626.435 µs) : 592, 661
.   : milestone, 626,
iast_HARDCODED_SECRET_DISABLED (582.537 µs) : 551, 614
.   : milestone, 583,
iast_INACTIVE (538.845 µs) : 508, 570
.   : milestone, 539,
iast_TELEMETRY_OFF (571.609 µs) : 539, 605
.   : milestone, 572,
tracing (541.439 µs) : 511, 572
.   : milestone, 541,
section candidate
no_agent (452.119 µs) : 423, 481
.   : milestone, 452,
iast (584.882 µs) : 554, 616
.   : milestone, 585,
iast_FULL (680.879 µs) : 648, 714
.   : milestone, 681,
iast_GLOBAL (616.009 µs) : 583, 649
.   : milestone, 616,
iast_HARDCODED_SECRET_DISABLED (590.809 µs) : 559, 623
.   : milestone, 591,
iast_INACTIVE (551.855 µs) : 522, 582
.   : milestone, 552,
iast_TELEMETRY_OFF (574.121 µs) : 542, 607
.   : milestone, 574,
tracing (538.85 µs) : 509, 569
.   : milestone, 539,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 456.734 µs [427.245 µs, 486.223 µs] -
iast 581.429 µs [549.829 µs, 613.029 µs] 124.694 µs (27.3%)
iast_FULL 686.587 µs [654.269 µs, 718.905 µs] 229.853 µs (50.3%)
iast_GLOBAL 626.435 µs [591.664 µs, 661.207 µs] 169.701 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED 582.537 µs [551.407 µs, 613.667 µs] 125.803 µs (27.5%)
iast_INACTIVE 538.845 µs [508.161 µs, 569.528 µs] 82.11 µs (18.0%)
iast_TELEMETRY_OFF 571.609 µs [538.608 µs, 604.611 µs] 114.875 µs (25.2%)
tracing 541.439 µs [510.725 µs, 572.154 µs] 84.705 µs (18.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 452.119 µs [423.26 µs, 480.979 µs] -
iast 584.882 µs [553.598 µs, 616.167 µs] 132.763 µs (29.4%)
iast_FULL 680.879 µs [647.851 µs, 713.906 µs] 228.759 µs (50.6%)
iast_GLOBAL 616.009 µs [582.679 µs, 649.339 µs] 163.89 µs (36.2%)
iast_HARDCODED_SECRET_DISABLED 590.809 µs [558.625 µs, 622.992 µs] 138.689 µs (30.7%)
iast_INACTIVE 551.855 µs [521.968 µs, 581.742 µs] 99.736 µs (22.1%)
iast_TELEMETRY_OFF 574.121 µs [541.683 µs, 606.559 µs] 122.002 µs (27.0%)
tracing 538.85 µs [508.83 µs, 568.871 µs] 86.731 µs (19.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master piotr-wolski/fix-bug-schema-tracking
git_commit_date 1728335917 1728340243
git_commit_sha f5b158c b9017dd
release_version 1.41.0-SNAPSHOT~f5b158c64d 1.41.0-SNAPSHOT~b9017ddc0f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1728342496 1728342496
ci_job_id 664602680 664602680
ci_pipeline_id 46024762 46024762
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~b9017ddc0f, baseline=1.41.0-SNAPSHOT~f5b158c64d
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.178 s) : 15178000, 15178000
.   : milestone, 15178000,
appsec (15.504 s) : 15504000, 15504000
.   : milestone, 15504000,
iast (19.131 s) : 19131000, 19131000
.   : milestone, 19131000,
iast_GLOBAL (17.908 s) : 17908000, 17908000
.   : milestone, 17908000,
profiling (14.896 s) : 14896000, 14896000
.   : milestone, 14896000,
tracing (14.964 s) : 14964000, 14964000
.   : milestone, 14964000,
section candidate
no_agent (14.884 s) : 14884000, 14884000
.   : milestone, 14884000,
appsec (15.044 s) : 15044000, 15044000
.   : milestone, 15044000,
iast (19.097 s) : 19097000, 19097000
.   : milestone, 19097000,
iast_GLOBAL (17.993 s) : 17993000, 17993000
.   : milestone, 17993000,
profiling (15.304 s) : 15304000, 15304000
.   : milestone, 15304000,
tracing (15.3 s) : 15300000, 15300000
.   : milestone, 15300000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.178 s [15.178 s, 15.178 s] -
appsec 15.504 s [15.504 s, 15.504 s] 326.0 ms (2.1%)
iast 19.131 s [19.131 s, 19.131 s] 3.953 s (26.0%)
iast_GLOBAL 17.908 s [17.908 s, 17.908 s] 2.73 s (18.0%)
profiling 14.896 s [14.896 s, 14.896 s] -282.0 ms (-1.9%)
tracing 14.964 s [14.964 s, 14.964 s] -214.0 ms (-1.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.884 s [14.884 s, 14.884 s] -
appsec 15.044 s [15.044 s, 15.044 s] 160.0 ms (1.1%)
iast 19.097 s [19.097 s, 19.097 s] 4.213 s (28.3%)
iast_GLOBAL 17.993 s [17.993 s, 17.993 s] 3.109 s (20.9%)
profiling 15.304 s [15.304 s, 15.304 s] 420.0 ms (2.8%)
tracing 15.3 s [15.3 s, 15.3 s] 416.0 ms (2.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~b9017ddc0f, baseline=1.41.0-SNAPSHOT~f5b158c64d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1451, 1474
.   : milestone, 1463,
appsec (2.322 ms) : 2281, 2362
.   : milestone, 2322,
iast (2.072 ms) : 2021, 2123
.   : milestone, 2072,
iast_GLOBAL (2.105 ms) : 2053, 2157
.   : milestone, 2105,
profiling (1.933 ms) : 1891, 1975
.   : milestone, 1933,
tracing (1.91 ms) : 1871, 1949
.   : milestone, 1910,
section candidate
no_agent (1.466 ms) : 1455, 1478
.   : milestone, 1466,
appsec (2.318 ms) : 2278, 2358
.   : milestone, 2318,
iast (2.069 ms) : 2018, 2120
.   : milestone, 2069,
iast_GLOBAL (2.102 ms) : 2050, 2153
.   : milestone, 2102,
profiling (1.94 ms) : 1899, 1981
.   : milestone, 1940,
tracing (1.9 ms) : 1861, 1939
.   : milestone, 1900,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.451 ms, 1.474 ms] -
appsec 2.322 ms [2.281 ms, 2.362 ms] 859.042 µs (58.7%)
iast 2.072 ms [2.021 ms, 2.123 ms] 609.254 µs (41.6%)
iast_GLOBAL 2.105 ms [2.053 ms, 2.157 ms] 642.083 µs (43.9%)
profiling 1.933 ms [1.891 ms, 1.975 ms] 469.917 µs (32.1%)
tracing 1.91 ms [1.871 ms, 1.949 ms] 447.455 µs (30.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.478 ms] -
appsec 2.318 ms [2.278 ms, 2.358 ms] 851.682 µs (58.1%)
iast 2.069 ms [2.018 ms, 2.12 ms] 602.748 µs (41.1%)
iast_GLOBAL 2.102 ms [2.05 ms, 2.153 ms] 635.248 µs (43.3%)
profiling 1.94 ms [1.899 ms, 1.981 ms] 474.053 µs (32.3%)
tracing 1.9 ms [1.861 ms, 1.939 ms] 433.684 µs (29.6%)

@piochelepiotr piochelepiotr requested a review from a team as a code owner October 4, 2024 13:44
@piochelepiotr piochelepiotr force-pushed the piotr-wolski/fix-bug-schema-tracking branch 2 times, most recently from 78185bf to 8c16787 Compare October 4, 2024 13:45
PerfectSlayer
PerfectSlayer reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was more thinking of reusing the Gradle plugin issued by Google. That would prevent to re-invent the wheel.

In addition, everything could stay within the instrumentation gradle module, and the generation task should directly be part of the build task.

@piochelepiotr piochelepiotr force-pushed the piotr-wolski/fix-bug-schema-tracking branch from 05e3b4d to 5137764 Compare October 7, 2024 21:42
PerfectSlayer
PerfectSlayer approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from module change / packaging and test.
You might want another pair of eyes from @DataDog/apm-idm-java for the CallDepthThreadLocalMap usage 👀

@piochelepiotr piochelepiotr enabled auto-merge (squash) October 8, 2024 21:25
@piochelepiotr piochelepiotr merged commit 17dca46 into master Oct 8, 2024
93 of 102 checks passed
@piochelepiotr piochelepiotr deleted the piotr-wolski/fix-bug-schema-tracking branch October 8, 2024 21:42
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 8, 2024
@nayeem-kamal nayeem-kamal added the inst: protobuf Protocol Buffer instrumentation label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayeem-kamal nayeem-kamal nayeem-kamal approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls was automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
inst: protobuf Protocol Buffer instrumentation
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
3 participants
@piochelepiotr @PerfectSlayer @nayeem-kamal