Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve context propagation for rxjava1 observables #7686

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Improve context propagation for rxjava1 observables #7686

merged 1 commit into from
Sep 25, 2024

Conversation

amarziali
Copy link
Collaborator

What Does This Do

Avoid capturing continuations on observables but carry spans instead for the parentship.
Using continuations might be not correct here since they can be captured more than once

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali added type: enhancement inst: others All other instrumentations tag: flaky test Flaky tests labels Sep 25, 2024
@amarziali amarziali requested a review from a team as a code owner September 25, 2024 15:12
PerfectSlayer
PerfectSlayer approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Let's see the impact of such change in the other intsrumentations

@pr-commenter
Copy link

pr-commenter bot commented Sep 25, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/rxspan
git_commit_date 1727189655 1727277330
git_commit_sha 043adb2 28869d8
release_version 1.40.0-SNAPSHOT~043adb202c 1.40.0-SNAPSHOT~28869d85ea
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727279675 1727279675
ci_job_id 651442727 651442727
ci_pipeline_id 45129285 45129285
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~28869d85ea, baseline=1.40.0-SNAPSHOT~043adb202c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079939
Total [baseline] (8.597 s) : 0, 8596614
Agent [candidate] (1.067 s) : 0, 1067265
Total [candidate] (8.546 s) : 0, 8546201
section iast
Agent [baseline] (1.192 s) : 0, 1191644
Total [baseline] (9.03 s) : 0, 9030463
Agent [candidate] (1.199 s) : 0, 1198829
Total [candidate] (9.024 s) : 0, 9023815
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.191 s) : 0, 1191218
Total [baseline] (8.981 s) : 0, 8980807
Agent [candidate] (1.193 s) : 0, 1192960
Total [candidate] (8.997 s) : 0, 8997017
section iast_TELEMETRY_OFF
Agent [baseline] (1.199 s) : 0, 1199311
Total [baseline] (9.072 s) : 0, 9071554
Agent [candidate] (1.191 s) : 0, 1191285
Total [candidate] (9.025 s) : 0, 9024786
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.192 s 111.705 ms (10.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.191 s 111.279 ms (10.3%)
Agent iast_TELEMETRY_OFF 1.199 s 119.372 ms (11.1%)
Total tracing 8.597 s -
Total iast 9.03 s 433.849 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.981 s 384.193 ms (4.5%)
Total iast_TELEMETRY_OFF 9.072 s 474.94 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent iast 1.199 s 131.563 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.193 s 125.695 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.191 s 124.019 ms (11.6%)
Total tracing 8.546 s -
Total iast 9.024 s 477.614 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 8.997 s 450.816 ms (5.3%)
Total iast_TELEMETRY_OFF 9.025 s 478.585 ms (5.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~28869d85ea, baseline=1.40.0-SNAPSHOT~043adb202c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.16 ms) : 0, 689160
BytebuddyAgent [candidate] (680.107 ms) : 0, 680107
GlobalTracer [baseline] (313.937 ms) : 0, 313937
GlobalTracer [candidate] (311.068 ms) : 0, 311068
AppSec [baseline] (54.563 ms) : 0, 54563
AppSec [candidate] (54.079 ms) : 0, 54079
Remote Config [baseline] (665.319 µs) : 0, 665
Remote Config [candidate] (658.165 µs) : 0, 658
Telemetry [baseline] (7.735 ms) : 0, 7735
Telemetry [candidate] (7.642 ms) : 0, 7642
section iast
BytebuddyAgent [baseline] (793.042 ms) : 0, 793042
BytebuddyAgent [candidate] (797.648 ms) : 0, 797648
GlobalTracer [baseline] (299.771 ms) : 0, 299771
GlobalTracer [candidate] (301.721 ms) : 0, 301721
AppSec [baseline] (54.497 ms) : 0, 54497
AppSec [candidate] (55.409 ms) : 0, 55409
IAST [baseline] (22.887 ms) : 0, 22887
IAST [candidate] (22.655 ms) : 0, 22655
Remote Config [baseline] (608.702 µs) : 0, 609
Remote Config [candidate] (598.84 µs) : 0, 599
Telemetry [baseline] (7.09 ms) : 0, 7090
Telemetry [candidate] (6.957 ms) : 0, 6957
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (792.02 ms) : 0, 792020
BytebuddyAgent [candidate] (792.921 ms) : 0, 792921
GlobalTracer [baseline] (299.719 ms) : 0, 299719
GlobalTracer [candidate] (300.345 ms) : 0, 300345
AppSec [baseline] (53.516 ms) : 0, 53516
AppSec [candidate] (56.219 ms) : 0, 56219
IAST [baseline] (24.538 ms) : 0, 24538
IAST [candidate] (22.014 ms) : 0, 22014
Remote Config [baseline] (604.947 µs) : 0, 605
Remote Config [candidate] (593.191 µs) : 0, 593
Telemetry [baseline] (7.077 ms) : 0, 7077
Telemetry [candidate] (7.069 ms) : 0, 7069
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.877 ms) : 0, 796877
BytebuddyAgent [candidate] (790.615 ms) : 0, 790615
GlobalTracer [baseline] (302.572 ms) : 0, 302572
GlobalTracer [candidate] (300.803 ms) : 0, 300803
AppSec [baseline] (55.982 ms) : 0, 55982
AppSec [candidate] (57.017 ms) : 0, 57017
IAST [baseline] (20.889 ms) : 0, 20889
IAST [candidate] (21.524 ms) : 0, 21524
Remote Config [baseline] (2.099 ms) : 0, 2099
Remote Config [candidate] (614.156 µs) : 0, 614
Telemetry [baseline] (7.031 ms) : 0, 7031
Telemetry [candidate] (6.93 ms) : 0, 6930
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~28869d85ea, baseline=1.40.0-SNAPSHOT~043adb202c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067298
Total [baseline] (10.398 s) : 0, 10398417
Agent [candidate] (1.07 s) : 0, 1070060
Total [candidate] (10.371 s) : 0, 10371002
section appsec
Agent [baseline] (1.21 s) : 0, 1209948
Total [baseline] (10.651 s) : 0, 10650706
Agent [candidate] (1.208 s) : 0, 1207882
Total [candidate] (10.66 s) : 0, 10660235
section iast
Agent [baseline] (1.192 s) : 0, 1192135
Total [baseline] (10.828 s) : 0, 10828179
Agent [candidate] (1.198 s) : 0, 1197997
Total [candidate] (10.9 s) : 0, 10900273
section profiling
Agent [baseline] (1.274 s) : 0, 1274003
Total [baseline] (10.59 s) : 0, 10589663
Agent [candidate] (1.28 s) : 0, 1279751
Total [candidate] (10.706 s) : 0, 10706004
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent appsec 1.21 s 142.65 ms (13.4%)
Agent iast 1.192 s 124.836 ms (11.7%)
Agent profiling 1.274 s 206.704 ms (19.4%)
Total tracing 10.398 s -
Total appsec 10.651 s 252.289 ms (2.4%)
Total iast 10.828 s 429.762 ms (4.1%)
Total profiling 10.59 s 191.246 ms (1.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent appsec 1.208 s 137.823 ms (12.9%)
Agent iast 1.198 s 127.938 ms (12.0%)
Agent profiling 1.28 s 209.691 ms (19.6%)
Total tracing 10.371 s -
Total appsec 10.66 s 289.233 ms (2.8%)
Total iast 10.9 s 529.27 ms (5.1%)
Total profiling 10.706 s 335.002 ms (3.2%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~28869d85ea, baseline=1.40.0-SNAPSHOT~043adb202c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.053 ms) : 0, 680053
BytebuddyAgent [candidate] (681.947 ms) : 0, 681947
GlobalTracer [baseline] (311.212 ms) : 0, 311212
GlobalTracer [candidate] (311.894 ms) : 0, 311894
AppSec [baseline] (53.921 ms) : 0, 53921
AppSec [candidate] (54.115 ms) : 0, 54115
Remote Config [baseline] (660.018 µs) : 0, 660
Remote Config [candidate] (672.214 µs) : 0, 672
Telemetry [baseline] (7.781 ms) : 0, 7781
Telemetry [candidate] (7.701 ms) : 0, 7701
section appsec
BytebuddyAgent [baseline] (706.578 ms) : 0, 706578
BytebuddyAgent [candidate] (704.886 ms) : 0, 704886
GlobalTracer [baseline] (305.734 ms) : 0, 305734
GlobalTracer [candidate] (305.414 ms) : 0, 305414
AppSec [baseline] (162.943 ms) : 0, 162943
AppSec [candidate] (162.873 ms) : 0, 162873
Remote Config [baseline] (634.114 µs) : 0, 634
Remote Config [candidate] (644.084 µs) : 0, 644
Telemetry [baseline] (8.808 ms) : 0, 8808
Telemetry [candidate] (9.171 ms) : 0, 9171
IAST [baseline] (22.916 ms) : 0, 22916
IAST [candidate] (22.239 ms) : 0, 22239
section iast
BytebuddyAgent [baseline] (793.068 ms) : 0, 793068
BytebuddyAgent [candidate] (795.91 ms) : 0, 795910
GlobalTracer [baseline] (299.349 ms) : 0, 299349
GlobalTracer [candidate] (301.67 ms) : 0, 301670
AppSec [baseline] (56.409 ms) : 0, 56409
AppSec [candidate] (51.894 ms) : 0, 51894
Remote Config [baseline] (597.955 µs) : 0, 598
Remote Config [candidate] (608.543 µs) : 0, 609
Telemetry [baseline] (6.993 ms) : 0, 6993
Telemetry [candidate] (6.951 ms) : 0, 6951
IAST [baseline] (21.961 ms) : 0, 21961
IAST [candidate] (27.221 ms) : 0, 27221
section profiling
ProfilingAgent [baseline] (96.422 ms) : 0, 96422
ProfilingAgent [candidate] (97.373 ms) : 0, 97373
BytebuddyAgent [baseline] (677.841 ms) : 0, 677841
BytebuddyAgent [candidate] (679.75 ms) : 0, 679750
GlobalTracer [baseline] (397.7 ms) : 0, 397700
GlobalTracer [candidate] (399.942 ms) : 0, 399942
AppSec [baseline] (54.884 ms) : 0, 54884
AppSec [candidate] (55.305 ms) : 0, 55305
Remote Config [baseline] (666.577 µs) : 0, 667
Remote Config [candidate] (672.057 µs) : 0, 672
Telemetry [baseline] (7.524 ms) : 0, 7524
Telemetry [candidate] (7.618 ms) : 0, 7618
Profiling [baseline] (96.445 ms) : 0, 96445
Profiling [candidate] (97.397 ms) : 0, 97397
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-25T15:27:17 2024-09-25T15:34:08
git_branch master andrea.marziali/rxspan
git_commit_date 1727189655 1727277330
git_commit_sha 043adb2 28869d8
release_version 1.40.0-SNAPSHOT~043adb202c 1.40.0-SNAPSHOT~28869d85ea
start_time 2024-09-25T15:27:04 2024-09-25T15:33:55
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727278792 1727278792
ci_job_id 651442729 651442729
ci_pipeline_id 45129285 45129285
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 18 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-109.036µs; -54.807µs] or [-7.026%; -3.531%]		 unstable
[-336.457op/s; +810.531op/s] or [-11.355%; +27.355%]		 1.470ms 3200.000op/s 1.552ms 2962.963op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~28869d85ea, baseline=1.40.0-SNAPSHOT~043adb202c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.317 ms) : 1298, 1337
.   : milestone, 1317,
appsec (1.71 ms) : 1685, 1734
.   : milestone, 1710,
appsec_no_iast (1.71 ms) : 1688, 1733
.   : milestone, 1710,
iast (1.479 ms) : 1456, 1502
.   : milestone, 1479,
profiling (1.552 ms) : 1526, 1578
.   : milestone, 1552,
tracing (1.472 ms) : 1449, 1496
.   : milestone, 1472,
section candidate
no_agent (1.346 ms) : 1325, 1366
.   : milestone, 1346,
appsec (1.71 ms) : 1687, 1734
.   : milestone, 1710,
appsec_no_iast (1.725 ms) : 1702, 1749
.   : milestone, 1725,
iast (1.465 ms) : 1442, 1488
.   : milestone, 1465,
profiling (1.47 ms) : 1445, 1495
.   : milestone, 1470,
tracing (1.46 ms) : 1436, 1484
.   : milestone, 1460,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.317 ms [1.298 ms, 1.337 ms] -
appsec 1.71 ms [1.685 ms, 1.734 ms] 392.125 µs (29.8%)
appsec_no_iast 1.71 ms [1.688 ms, 1.733 ms] 393.042 µs (29.8%)
iast 1.479 ms [1.456 ms, 1.502 ms] 161.185 µs (12.2%)
profiling 1.552 ms [1.526 ms, 1.578 ms] 234.495 µs (17.8%)
tracing 1.472 ms [1.449 ms, 1.496 ms] 154.891 µs (11.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.325 ms, 1.366 ms] -
appsec 1.71 ms [1.687 ms, 1.734 ms] 364.934 µs (27.1%)
appsec_no_iast 1.725 ms [1.702 ms, 1.749 ms] 379.823 µs (28.2%)
iast 1.465 ms [1.442 ms, 1.488 ms] 119.283 µs (8.9%)
profiling 1.47 ms [1.445 ms, 1.495 ms] 124.465 µs (9.3%)
tracing 1.46 ms [1.436 ms, 1.484 ms] 114.34 µs (8.5%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~28869d85ea, baseline=1.40.0-SNAPSHOT~043adb202c
    dateFormat X
    axisFormat %s
section baseline
no_agent (373.575 µs) : 352, 395
.   : milestone, 374,
iast (475.998 µs) : 455, 497
.   : milestone, 476,
iast_FULL (555.872 µs) : 535, 577
.   : milestone, 556,
iast_GLOBAL (502.825 µs) : 481, 524
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (483.073 µs) : 462, 504
.   : milestone, 483,
iast_INACTIVE (444.987 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (476.2 µs) : 453, 499
.   : milestone, 476,
tracing (446.949 µs) : 426, 468
.   : milestone, 447,
section candidate
no_agent (363.054 µs) : 343, 383
.   : milestone, 363,
iast (484.864 µs) : 463, 506
.   : milestone, 485,
iast_FULL (555.284 µs) : 534, 576
.   : milestone, 555,
iast_GLOBAL (501.795 µs) : 481, 523
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (480.604 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (440.602 µs) : 420, 461
.   : milestone, 441,
iast_TELEMETRY_OFF (473.644 µs) : 451, 496
.   : milestone, 474,
tracing (442.678 µs) : 422, 463
.   : milestone, 443,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.575 µs [352.302 µs, 394.849 µs] -
iast 475.998 µs [455.082 µs, 496.915 µs] 102.423 µs (27.4%)
iast_FULL 555.872 µs [534.714 µs, 577.03 µs] 182.297 µs (48.8%)
iast_GLOBAL 502.825 µs [481.459 µs, 524.191 µs] 129.25 µs (34.6%)
iast_HARDCODED_SECRET_DISABLED 483.073 µs [461.934 µs, 504.211 µs] 109.497 µs (29.3%)
iast_INACTIVE 444.987 µs [423.945 µs, 466.028 µs] 71.411 µs (19.1%)
iast_TELEMETRY_OFF 476.2 µs [453.421 µs, 498.978 µs] 102.624 µs (27.5%)
tracing 446.949 µs [426.134 µs, 467.764 µs] 73.373 µs (19.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.054 µs [343.405 µs, 382.702 µs] -
iast 484.864 µs [463.247 µs, 506.48 µs] 121.81 µs (33.6%)
iast_FULL 555.284 µs [534.217 µs, 576.351 µs] 192.23 µs (52.9%)
iast_GLOBAL 501.795 µs [480.825 µs, 522.765 µs] 138.741 µs (38.2%)
iast_HARDCODED_SECRET_DISABLED 480.604 µs [459.564 µs, 501.643 µs] 117.55 µs (32.4%)
iast_INACTIVE 440.602 µs [420.252 µs, 460.951 µs] 77.548 µs (21.4%)
iast_TELEMETRY_OFF 473.644 µs [450.96 µs, 496.328 µs] 110.59 µs (30.5%)
tracing 442.678 µs [421.911 µs, 463.446 µs] 79.625 µs (21.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/rxspan
git_commit_date 1727189655 1727277330
git_commit_sha 043adb2 28869d8
release_version 1.40.0-SNAPSHOT~043adb202c 1.40.0-SNAPSHOT~28869d85ea
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727279315 1727279315
ci_job_id 651442730 651442730
ci_pipeline_id 45129285 45129285
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~28869d85ea, baseline=1.40.0-SNAPSHOT~043adb202c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.315 ms) : 2275, 2356
.   : milestone, 2315,
iast (2.066 ms) : 2015, 2116
.   : milestone, 2066,
iast_GLOBAL (2.104 ms) : 2054, 2155
.   : milestone, 2104,
profiling (1.931 ms) : 1891, 1970
.   : milestone, 1931,
tracing (1.91 ms) : 1872, 1948
.   : milestone, 1910,
section candidate
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.315 ms) : 2274, 2355
.   : milestone, 2315,
iast (2.067 ms) : 2017, 2118
.   : milestone, 2067,
iast_GLOBAL (2.093 ms) : 2043, 2143
.   : milestone, 2093,
profiling (1.931 ms) : 1891, 1971
.   : milestone, 1931,
tracing (1.903 ms) : 1865, 1941
.   : milestone, 1903,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 2.315 ms [2.275 ms, 2.356 ms] 847.086 µs (57.7%)
iast 2.066 ms [2.015 ms, 2.116 ms] 597.322 µs (40.7%)
iast_GLOBAL 2.104 ms [2.054 ms, 2.155 ms] 636.207 µs (43.3%)
profiling 1.931 ms [1.891 ms, 1.97 ms] 462.646 µs (31.5%)
tracing 1.91 ms [1.872 ms, 1.948 ms] 441.359 µs (30.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 2.315 ms [2.274 ms, 2.355 ms] 846.443 µs (57.7%)
iast 2.067 ms [2.017 ms, 2.118 ms] 599.204 µs (40.8%)
iast_GLOBAL 2.093 ms [2.043 ms, 2.143 ms] 624.344 µs (42.5%)
profiling 1.931 ms [1.891 ms, 1.971 ms] 462.864 µs (31.5%)
tracing 1.903 ms [1.865 ms, 1.941 ms] 434.971 µs (29.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~28869d85ea, baseline=1.40.0-SNAPSHOT~043adb202c
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.396 s) : 15396000, 15396000
.   : milestone, 15396000,
appsec (15.269 s) : 15269000, 15269000
.   : milestone, 15269000,
iast (18.754 s) : 18754000, 18754000
.   : milestone, 18754000,
iast_GLOBAL (18.192 s) : 18192000, 18192000
.   : milestone, 18192000,
profiling (15.521 s) : 15521000, 15521000
.   : milestone, 15521000,
tracing (15.071 s) : 15071000, 15071000
.   : milestone, 15071000,
section candidate
no_agent (15.439 s) : 15439000, 15439000
.   : milestone, 15439000,
appsec (15.123 s) : 15123000, 15123000
.   : milestone, 15123000,
iast (18.608 s) : 18608000, 18608000
.   : milestone, 18608000,
iast_GLOBAL (17.836 s) : 17836000, 17836000
.   : milestone, 17836000,
profiling (14.973 s) : 14973000, 14973000
.   : milestone, 14973000,
tracing (15.253 s) : 15253000, 15253000
.   : milestone, 15253000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.396 s [15.396 s, 15.396 s] -
appsec 15.269 s [15.269 s, 15.269 s] -127.0 ms (-0.8%)
iast 18.754 s [18.754 s, 18.754 s] 3.358 s (21.8%)
iast_GLOBAL 18.192 s [18.192 s, 18.192 s] 2.796 s (18.2%)
profiling 15.521 s [15.521 s, 15.521 s] 125.0 ms (0.8%)
tracing 15.071 s [15.071 s, 15.071 s] -325.0 ms (-2.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.439 s [15.439 s, 15.439 s] -
appsec 15.123 s [15.123 s, 15.123 s] -316.0 ms (-2.0%)
iast 18.608 s [18.608 s, 18.608 s] 3.169 s (20.5%)
iast_GLOBAL 17.836 s [17.836 s, 17.836 s] 2.397 s (15.5%)
profiling 14.973 s [14.973 s, 14.973 s] -466.0 ms (-3.0%)
tracing 15.253 s [15.253 s, 15.253 s] -186.0 ms (-1.2%)

@amarziali amarziali merged commit 8929ba1 into master Sep 25, 2024
99 of 102 checks passed
@amarziali amarziali deleted the andrea.marziali/rxspan branch September 25, 2024 16:05
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees
No one assigned
Labels
inst: others All other instrumentations tag: flaky test Flaky tests type: enhancement
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amarziali @PerfectSlayer