Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Code Origin span tags #7685

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Update Code Origin span tags #7685

merged 2 commits into from
Sep 26, 2024

Conversation

shatzi
Copy link
Contributor

@shatzi shatzi commented Sep 25, 2024

What Does This Do

Update tags added to span to decorate based on updated Code Origin Spec

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@shatzi shatzi requested review from a team as code owners September 25, 2024 13:40
@shatzi shatzi requested review from jpbempel and smola and removed request for a team September 25, 2024 13:40
@pr-commenter
Copy link

pr-commenter bot commented Sep 25, 2024 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1727296958 1727297334
end_time 2024-09-25T20:43:53 2024-09-25T20:50:09
git_branch master shatzi/fix-code-origin-tags
git_commit_sha c0adef9 0f8251a
start_time 2024-09-25T20:42:39 2024-09-25T20:48:55
See matching parameters
Baseline Candidate
ci_job_id 651944623 651944623
ci_pipeline_id 45164175 45164175
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1727296375 1727296375

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:basic worse
[+3.324µs; +15.824µs] or [+1.240%; +5.905%]		 same same unstable
[-46.035µs; +55.114µs] or [-8.695%; +10.410%]		 unstable
[-202.488op/s; +67.535op/s] or [-7.695%; +2.566%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-25464.419ns; +27288.366ns] or [-9.619%; +10.308%]		 unstable
[-39285.098ns; +40536.498ns] or [-12.901%; +13.312%]		 unstable
[-51749.426ns; +53176.679ns] or [-16.250%; +16.698%]		 unstable
[-112.429µs; +152.008µs] or [-18.467%; +24.967%]		 same
scenario:loop unsure
[+42.198µs; +153.676µs] or [+0.415%; +1.510%]		 unsure
[+36.723µs; +173.624µs] or [+0.355%; +1.677%]		 unsure
[+7.347µs; +178.294µs] or [+0.070%; +1.704%]		 same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (304.519 µs) : 267, 342
.   : milestone, 305,
basic (297.718 µs) : 288, 308
.   : milestone, 298,
loop (10.351 ms) : 10313, 10389
.   : milestone, 10351,
section candidate
noprobe (305.144 µs) : 266, 344
.   : milestone, 305,
basic (306.599 µs) : 297, 316
.   : milestone, 307,
loop (10.456 ms) : 10374, 10537
.   : milestone, 10456,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 304.519 µs [267.178 µs, 341.86 µs]
basic 297.718 µs [287.662 µs, 307.773 µs]
loop 10.351 ms [10.313 ms, 10.389 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 305.144 µs [266.361 µs, 343.928 µs]
basic 306.599 µs [296.984 µs, 316.215 µs]
loop 10.456 ms [10.374 ms, 10.537 ms]

@shatzi shatzi force-pushed the shatzi/fix-code-origin-tags branch from 07df282 to 34e58f3 Compare September 25, 2024 13:57
@pr-commenter
Copy link

pr-commenter bot commented Sep 25, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master shatzi/fix-code-origin-tags
git_commit_date 1727289346 1727296375
git_commit_sha c0adef9 0f8251a
release_version 1.40.0-SNAPSHOT~c0adef9577 1.40.0-SNAPSHOT~0f8251aee9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727298792 1727298792
ci_job_id 651944617 651944617
ci_pipeline_id 45164175 45164175
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~0f8251aee9, baseline=1.40.0-SNAPSHOT~c0adef9577

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067703
Total [baseline] (8.535 s) : 0, 8535465
Agent [candidate] (1.072 s) : 0, 1072155
Total [candidate] (8.567 s) : 0, 8567430
section iast
Agent [baseline] (1.193 s) : 0, 1192743
Total [baseline] (9.028 s) : 0, 9027967
Agent [candidate] (1.187 s) : 0, 1187013
Total [candidate] (9.006 s) : 0, 9005973
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.201 s) : 0, 1200532
Total [baseline] (9.046 s) : 0, 9045501
Agent [candidate] (1.193 s) : 0, 1192545
Total [candidate] (8.989 s) : 0, 8989176
section iast_TELEMETRY_OFF
Agent [baseline] (1.187 s) : 0, 1186932
Total [baseline] (9.012 s) : 0, 9011714
Agent [candidate] (1.19 s) : 0, 1190149
Total [candidate] (9.04 s) : 0, 9039971
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent iast 1.193 s 125.039 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.201 s 132.828 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.187 s 119.228 ms (11.2%)
Total tracing 8.535 s -
Total iast 9.028 s 492.502 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.046 s 510.036 ms (6.0%)
Total iast_TELEMETRY_OFF 9.012 s 476.248 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent iast 1.187 s 114.858 ms (10.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.193 s 120.39 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.19 s 117.994 ms (11.0%)
Total tracing 8.567 s -
Total iast 9.006 s 438.543 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.989 s 421.746 ms (4.9%)
Total iast_TELEMETRY_OFF 9.04 s 472.54 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~0f8251aee9, baseline=1.40.0-SNAPSHOT~c0adef9577

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.839 ms) : 0, 680839
BytebuddyAgent [candidate] (685.573 ms) : 0, 685573
GlobalTracer [baseline] (310.888 ms) : 0, 310888
GlobalTracer [candidate] (310.443 ms) : 0, 310443
AppSec [baseline] (54.074 ms) : 0, 54074
AppSec [candidate] (54.063 ms) : 0, 54063
Remote Config [baseline] (660.069 µs) : 0, 660
Remote Config [candidate] (671.698 µs) : 0, 672
Telemetry [baseline] (7.563 ms) : 0, 7563
Telemetry [candidate] (7.643 ms) : 0, 7643
section iast
BytebuddyAgent [baseline] (793.215 ms) : 0, 793215
BytebuddyAgent [candidate] (790.008 ms) : 0, 790008
GlobalTracer [baseline] (299.448 ms) : 0, 299448
GlobalTracer [candidate] (297.824 ms) : 0, 297824
AppSec [baseline] (56.054 ms) : 0, 56054
AppSec [candidate] (54.999 ms) : 0, 54999
IAST [baseline] (22.715 ms) : 0, 22715
IAST [candidate] (22.829 ms) : 0, 22829
Remote Config [baseline] (608.839 µs) : 0, 609
Remote Config [candidate] (613.87 µs) : 0, 614
Telemetry [baseline] (6.984 ms) : 0, 6984
Telemetry [candidate] (7.024 ms) : 0, 7024
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.942 ms) : 0, 798942
BytebuddyAgent [candidate] (792.986 ms) : 0, 792986
GlobalTracer [baseline] (301.554 ms) : 0, 301554
GlobalTracer [candidate] (299.233 ms) : 0, 299233
AppSec [baseline] (57.006 ms) : 0, 57006
AppSec [candidate] (53.449 ms) : 0, 53449
IAST [baseline] (21.315 ms) : 0, 21315
IAST [candidate] (25.471 ms) : 0, 25471
Remote Config [baseline] (623.122 µs) : 0, 623
Remote Config [candidate] (606.727 µs) : 0, 607
Telemetry [baseline] (7.272 ms) : 0, 7272
Telemetry [candidate] (7.08 ms) : 0, 7080
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (788.261 ms) : 0, 788261
BytebuddyAgent [candidate] (790.77 ms) : 0, 790770
GlobalTracer [baseline] (298.893 ms) : 0, 298893
GlobalTracer [candidate] (299.542 ms) : 0, 299542
AppSec [baseline] (54.384 ms) : 0, 54384
AppSec [candidate] (55.15 ms) : 0, 55150
IAST [baseline] (23.312 ms) : 0, 23312
IAST [candidate] (22.522 ms) : 0, 22522
Remote Config [baseline] (1.421 ms) : 0, 1421
Remote Config [candidate] (684.094 µs) : 0, 684
Telemetry [baseline] (6.984 ms) : 0, 6984
Telemetry [candidate] (7.745 ms) : 0, 7745
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~0f8251aee9, baseline=1.40.0-SNAPSHOT~c0adef9577

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066539
Total [baseline] (10.414 s) : 0, 10414077
Agent [candidate] (1.066 s) : 0, 1065842
Total [candidate] (10.411 s) : 0, 10411036
section appsec
Agent [baseline] (1.204 s) : 0, 1204354
Total [baseline] (10.697 s) : 0, 10697078
Agent [candidate] (1.206 s) : 0, 1206372
Total [candidate] (10.685 s) : 0, 10685281
section iast
Agent [baseline] (1.194 s) : 0, 1193907
Total [baseline] (10.91 s) : 0, 10909753
Agent [candidate] (1.202 s) : 0, 1202393
Total [candidate] (10.893 s) : 0, 10892963
section profiling
Agent [baseline] (1.266 s) : 0, 1266314
Total [baseline] (10.608 s) : 0, 10608022
Agent [candidate] (1.266 s) : 0, 1266246
Total [candidate] (10.564 s) : 0, 10564475
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent appsec 1.204 s 137.815 ms (12.9%)
Agent iast 1.194 s 127.368 ms (11.9%)
Agent profiling 1.266 s 199.774 ms (18.7%)
Total tracing 10.414 s -
Total appsec 10.697 s 283.001 ms (2.7%)
Total iast 10.91 s 495.676 ms (4.8%)
Total profiling 10.608 s 193.945 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent appsec 1.206 s 140.53 ms (13.2%)
Agent iast 1.202 s 136.55 ms (12.8%)
Agent profiling 1.266 s 200.403 ms (18.8%)
Total tracing 10.411 s -
Total appsec 10.685 s 274.245 ms (2.6%)
Total iast 10.893 s 481.927 ms (4.6%)
Total profiling 10.564 s 153.439 ms (1.5%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~0f8251aee9, baseline=1.40.0-SNAPSHOT~c0adef9577

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.501 ms) : 0, 680501
BytebuddyAgent [candidate] (680.181 ms) : 0, 680181
GlobalTracer [baseline] (310.352 ms) : 0, 310352
GlobalTracer [candidate] (309.901 ms) : 0, 309901
AppSec [baseline] (53.779 ms) : 0, 53779
AppSec [candidate] (53.848 ms) : 0, 53848
Remote Config [baseline] (664.876 µs) : 0, 665
Remote Config [candidate] (657.548 µs) : 0, 658
Telemetry [baseline] (7.571 ms) : 0, 7571
Telemetry [candidate] (7.583 ms) : 0, 7583
section appsec
BytebuddyAgent [baseline] (705.331 ms) : 0, 705331
BytebuddyAgent [candidate] (706.276 ms) : 0, 706276
GlobalTracer [baseline] (304.31 ms) : 0, 304310
GlobalTracer [candidate] (304.863 ms) : 0, 304863
AppSec [baseline] (163.179 ms) : 0, 163179
AppSec [candidate] (162.432 ms) : 0, 162432
Remote Config [baseline] (642.377 µs) : 0, 642
Remote Config [candidate] (643.046 µs) : 0, 643
Telemetry [baseline] (7.163 ms) : 0, 7163
Telemetry [candidate] (8.217 ms) : 0, 8217
IAST [baseline] (20.036 ms) : 0, 20036
IAST [candidate] (20.35 ms) : 0, 20350
section iast
BytebuddyAgent [baseline] (794.273 ms) : 0, 794273
BytebuddyAgent [candidate] (800.006 ms) : 0, 800006
GlobalTracer [baseline] (299.277 ms) : 0, 299277
GlobalTracer [candidate] (301.668 ms) : 0, 301668
AppSec [baseline] (51.928 ms) : 0, 51928
AppSec [candidate] (56.072 ms) : 0, 56072
Remote Config [baseline] (625.036 µs) : 0, 625
Remote Config [candidate] (608.35 µs) : 0, 608
Telemetry [baseline] (7.826 ms) : 0, 7826
Telemetry [candidate] (7.108 ms) : 0, 7108
IAST [baseline] (26.217 ms) : 0, 26217
IAST [candidate] (23.088 ms) : 0, 23088
section profiling
BytebuddyAgent [baseline] (673.888 ms) : 0, 673888
BytebuddyAgent [candidate] (674.145 ms) : 0, 674145
GlobalTracer [baseline] (394.249 ms) : 0, 394249
GlobalTracer [candidate] (394.425 ms) : 0, 394425
AppSec [baseline] (54.722 ms) : 0, 54722
AppSec [candidate] (54.528 ms) : 0, 54528
Remote Config [baseline] (650.102 µs) : 0, 650
Remote Config [candidate] (646.943 µs) : 0, 647
Telemetry [baseline] (7.47 ms) : 0, 7470
Telemetry [candidate] (7.47 ms) : 0, 7470
ProfilingAgent [baseline] (96.691 ms) : 0, 96691
ProfilingAgent [candidate] (96.338 ms) : 0, 96338
Profiling [baseline] (96.714 ms) : 0, 96714
Profiling [candidate] (96.361 ms) : 0, 96361
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-25T20:43:44 2024-09-25T20:50:32
git_branch master shatzi/fix-code-origin-tags
git_commit_date 1727289346 1727296375
git_commit_sha c0adef9 0f8251a
release_version 1.40.0-SNAPSHOT~c0adef9577 1.40.0-SNAPSHOT~0f8251aee9
start_time 2024-09-25T20:43:31 2024-09-25T20:50:19
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727297778 1727297778
ci_job_id 651944618 651944618
ci_pipeline_id 45164175 45164175
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~0f8251aee9, baseline=1.40.0-SNAPSHOT~c0adef9577
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.322 ms) : 1302, 1341
.   : milestone, 1322,
appsec (1.704 ms) : 1679, 1729
.   : milestone, 1704,
appsec_no_iast (1.71 ms) : 1686, 1734
.   : milestone, 1710,
iast (1.482 ms) : 1460, 1505
.   : milestone, 1482,
profiling (1.472 ms) : 1448, 1496
.   : milestone, 1472,
tracing (1.479 ms) : 1454, 1503
.   : milestone, 1479,
section candidate
no_agent (1.336 ms) : 1317, 1355
.   : milestone, 1336,
appsec (1.724 ms) : 1700, 1747
.   : milestone, 1724,
appsec_no_iast (1.73 ms) : 1706, 1755
.   : milestone, 1730,
iast (1.481 ms) : 1459, 1504
.   : milestone, 1481,
profiling (1.451 ms) : 1426, 1476
.   : milestone, 1451,
tracing (1.459 ms) : 1435, 1484
.   : milestone, 1459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.322 ms [1.302 ms, 1.341 ms] -
appsec 1.704 ms [1.679 ms, 1.729 ms] 382.721 µs (29.0%)
appsec_no_iast 1.71 ms [1.686 ms, 1.734 ms] 388.502 µs (29.4%)
iast 1.482 ms [1.46 ms, 1.505 ms] 160.721 µs (12.2%)
profiling 1.472 ms [1.448 ms, 1.496 ms] 150.397 µs (11.4%)
tracing 1.479 ms [1.454 ms, 1.503 ms] 157.069 µs (11.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.336 ms [1.317 ms, 1.355 ms] -
appsec 1.724 ms [1.7 ms, 1.747 ms] 387.395 µs (29.0%)
appsec_no_iast 1.73 ms [1.706 ms, 1.755 ms] 394.288 µs (29.5%)
iast 1.481 ms [1.459 ms, 1.504 ms] 145.11 µs (10.9%)
profiling 1.451 ms [1.426 ms, 1.476 ms] 114.985 µs (8.6%)
tracing 1.459 ms [1.435 ms, 1.484 ms] 122.953 µs (9.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~0f8251aee9, baseline=1.40.0-SNAPSHOT~c0adef9577
    dateFormat X
    axisFormat %s
section baseline
no_agent (368.72 µs) : 349, 388
.   : milestone, 369,
iast (478.967 µs) : 458, 500
.   : milestone, 479,
iast_FULL (552.47 µs) : 531, 574
.   : milestone, 552,
iast_GLOBAL (499.542 µs) : 479, 520
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (490.323 µs) : 469, 512
.   : milestone, 490,
iast_INACTIVE (444.393 µs) : 423, 466
.   : milestone, 444,
iast_TELEMETRY_OFF (477.97 µs) : 455, 501
.   : milestone, 478,
tracing (438.802 µs) : 418, 460
.   : milestone, 439,
section candidate
no_agent (367.957 µs) : 349, 387
.   : milestone, 368,
iast (475.144 µs) : 454, 496
.   : milestone, 475,
iast_FULL (552.648 µs) : 531, 574
.   : milestone, 553,
iast_GLOBAL (507.311 µs) : 484, 530
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (480.891 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (446.605 µs) : 426, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (477.643 µs) : 455, 500
.   : milestone, 478,
tracing (439.976 µs) : 419, 460
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.72 µs [349.279 µs, 388.161 µs] -
iast 478.967 µs [458.061 µs, 499.874 µs] 110.248 µs (29.9%)
iast_FULL 552.47 µs [531.221 µs, 573.719 µs] 183.75 µs (49.8%)
iast_GLOBAL 499.542 µs [478.753 µs, 520.332 µs] 130.822 µs (35.5%)
iast_HARDCODED_SECRET_DISABLED 490.323 µs [468.859 µs, 511.787 µs] 121.603 µs (33.0%)
iast_INACTIVE 444.393 µs [423.1 µs, 465.686 µs] 75.673 µs (20.5%)
iast_TELEMETRY_OFF 477.97 µs [455.087 µs, 500.853 µs] 109.251 µs (29.6%)
tracing 438.802 µs [417.981 µs, 459.624 µs] 70.082 µs (19.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.957 µs [348.578 µs, 387.337 µs] -
iast 475.144 µs [454.175 µs, 496.113 µs] 107.187 µs (29.1%)
iast_FULL 552.648 µs [531.335 µs, 573.962 µs] 184.691 µs (50.2%)
iast_GLOBAL 507.311 µs [484.345 µs, 530.276 µs] 139.353 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED 480.891 µs [459.583 µs, 502.199 µs] 112.934 µs (30.7%)
iast_INACTIVE 446.605 µs [425.501 µs, 467.709 µs] 78.648 µs (21.4%)
iast_TELEMETRY_OFF 477.643 µs [454.818 µs, 500.468 µs] 109.686 µs (29.8%)
tracing 439.976 µs [419.485 µs, 460.468 µs] 72.019 µs (19.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master shatzi/fix-code-origin-tags
git_commit_date 1727289346 1727296375
git_commit_sha c0adef9 0f8251a
release_version 1.40.0-SNAPSHOT~c0adef9577 1.40.0-SNAPSHOT~0f8251aee9
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727298301 1727298301
ci_job_id 651944619 651944619
ci_pipeline_id 45164175 45164175
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~0f8251aee9, baseline=1.40.0-SNAPSHOT~c0adef9577
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1474
.   : milestone, 1462,
appsec (2.315 ms) : 2274, 2356
.   : milestone, 2315,
iast (2.036 ms) : 1986, 2086
.   : milestone, 2036,
iast_GLOBAL (2.097 ms) : 2046, 2148
.   : milestone, 2097,
profiling (1.925 ms) : 1885, 1965
.   : milestone, 1925,
tracing (1.901 ms) : 1862, 1939
.   : milestone, 1901,
section candidate
no_agent (1.458 ms) : 1447, 1470
.   : milestone, 1458,
appsec (2.311 ms) : 2270, 2352
.   : milestone, 2311,
iast (2.057 ms) : 2006, 2107
.   : milestone, 2057,
iast_GLOBAL (2.091 ms) : 2040, 2142
.   : milestone, 2091,
profiling (2.423 ms) : 2232, 2614
.   : milestone, 2423,
tracing (1.899 ms) : 1861, 1937
.   : milestone, 1899,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.474 ms] -
appsec 2.315 ms [2.274 ms, 2.356 ms] 852.417 µs (58.3%)
iast 2.036 ms [1.986 ms, 2.086 ms] 573.594 µs (39.2%)
iast_GLOBAL 2.097 ms [2.046 ms, 2.148 ms] 634.66 µs (43.4%)
profiling 1.925 ms [1.885 ms, 1.965 ms] 462.33 µs (31.6%)
tracing 1.901 ms [1.862 ms, 1.939 ms] 438.377 µs (30.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.447 ms, 1.47 ms] -
appsec 2.311 ms [2.27 ms, 2.352 ms] 853.207 µs (58.5%)
iast 2.057 ms [2.006 ms, 2.107 ms] 598.556 µs (41.1%)
iast_GLOBAL 2.091 ms [2.04 ms, 2.142 ms] 633.129 µs (43.4%)
profiling 2.423 ms [2.232 ms, 2.614 ms] 965.037 µs (66.2%)
tracing 1.899 ms [1.861 ms, 1.937 ms] 440.666 µs (30.2%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~0f8251aee9, baseline=1.40.0-SNAPSHOT~c0adef9577
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.942 s) : 14942000, 14942000
.   : milestone, 14942000,
appsec (15.001 s) : 15001000, 15001000
.   : milestone, 15001000,
iast (18.877 s) : 18877000, 18877000
.   : milestone, 18877000,
iast_GLOBAL (17.958 s) : 17958000, 17958000
.   : milestone, 17958000,
profiling (15.267 s) : 15267000, 15267000
.   : milestone, 15267000,
tracing (15.036 s) : 15036000, 15036000
.   : milestone, 15036000,
section candidate
no_agent (15.186 s) : 15186000, 15186000
.   : milestone, 15186000,
appsec (15.252 s) : 15252000, 15252000
.   : milestone, 15252000,
iast (18.788 s) : 18788000, 18788000
.   : milestone, 18788000,
iast_GLOBAL (18.2 s) : 18200000, 18200000
.   : milestone, 18200000,
profiling (15.868 s) : 15868000, 15868000
.   : milestone, 15868000,
tracing (15.213 s) : 15213000, 15213000
.   : milestone, 15213000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.942 s [14.942 s, 14.942 s] -
appsec 15.001 s [15.001 s, 15.001 s] 59.0 ms (0.4%)
iast 18.877 s [18.877 s, 18.877 s] 3.935 s (26.3%)
iast_GLOBAL 17.958 s [17.958 s, 17.958 s] 3.016 s (20.2%)
profiling 15.267 s [15.267 s, 15.267 s] 325.0 ms (2.2%)
tracing 15.036 s [15.036 s, 15.036 s] 94.0 ms (0.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.186 s [15.186 s, 15.186 s] -
appsec 15.252 s [15.252 s, 15.252 s] 66.0 ms (0.4%)
iast 18.788 s [18.788 s, 18.788 s] 3.602 s (23.7%)
iast_GLOBAL 18.2 s [18.2 s, 18.2 s] 3.014 s (19.8%)
profiling 15.868 s [15.868 s, 15.868 s] 682.0 ms (4.5%)
tracing 15.213 s [15.213 s, 15.213 s] 27.0 ms (0.2%)

@PerfectSlayer PerfectSlayer added the comp: debugger Dynamic Instrumentation label Sep 25, 2024
@PerfectSlayer PerfectSlayer changed the title change tags to match Code Origin RFC updated spec Update Code Origin span tags Sep 25, 2024
@shatzi shatzi force-pushed the shatzi/fix-code-origin-tags branch from 61422a5 to 185f0b0 Compare September 25, 2024 20:26
@shatzi shatzi requested review from a team as code owners September 25, 2024 20:26
@shatzi shatzi force-pushed the shatzi/fix-code-origin-tags branch from 185f0b0 to 0f8251a Compare September 25, 2024 20:33
PerfectSlayer
PerfectSlayer approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from platform

@shatzi shatzi merged commit 2048146 into master Sep 26, 2024
103 checks passed
@shatzi shatzi deleted the shatzi/fix-code-origin-tags branch September 26, 2024 20:44
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougqh dougqh dougqh left review comments

@jpbempel jpbempel jpbempel approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shatzi @dougqh @PerfectSlayer @jpbempel