Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicated locals with arguments #7683

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix duplicated locals with arguments #7683

merged 1 commit into from
Sep 26, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Sep 25, 2024 •
edited by jira bot
Loading

What Does This Do

When hoisting local variables remove the locals that could be have the
same name than arguments.
This could happen resulting of the instrumentation by the tracer that reshuffle the local variable table and then reassign dedicated slots to those arguments

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2901

@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Sep 25, 2024
@jpbempel jpbempel requested a review from a team as a code owner September 25, 2024 07:47
@jpbempel jpbempel requested review from evanchooly and removed request for a team September 25, 2024 07:47
@jpbempel jpbempel force-pushed the jpbempel/fix-duplicated-locals branch from 702f5cb to c728c36 Compare September 25, 2024 07:50
@pr-commenter
Copy link

pr-commenter bot commented Sep 25, 2024 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1727337610 1727337985
end_time 2024-09-26T08:01:25 2024-09-26T08:07:40
git_branch master jpbempel/fix-duplicated-locals
git_commit_sha 845dfba c44ac69
start_time 2024-09-26T08:00:11 2024-09-26T08:06:26
See matching parameters
Baseline Candidate
ci_job_id 652236171 652236171
ci_pipeline_id 45188037 45188037
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1727336777 1727336777

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-63.613µs; +29.257µs] or [-22.837%; +10.503%]		 unstable
[-72.817µs; +38.427µs] or [-22.973%; +12.123%]		 unstable
[-94.811µs; +49.991µs] or [-28.197%; +14.868%]		 unstable
[-1106.036µs; +372.706µs] or [-115.084%; +38.780%]		 same
scenario:basic same same unstable
[-26.981µs; +11.984µs] or [-8.487%; +3.770%]		 unstable
[-180.749µs; +90.501µs] or [-30.360%; +15.201%]		 unstable
[-199.067op/s; +199.067op/s] or [-7.764%; +7.764%]
scenario:loop same same same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (316.969 µs) : 248, 386
.   : milestone, 317,
basic (305.335 µs) : 288, 323
.   : milestone, 305,
loop (10.281 ms) : 10221, 10340
.   : milestone, 10281,
section candidate
noprobe (299.774 µs) : 270, 330
.   : milestone, 300,
basic (300.79 µs) : 291, 311
.   : milestone, 301,
loop (10.308 ms) : 10276, 10340
.   : milestone, 10308,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 316.969 µs [248.183 µs, 385.755 µs]
basic 305.335 µs [287.855 µs, 322.816 µs]
loop 10.281 ms [10.221 ms, 10.34 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 299.774 µs [269.802 µs, 329.746 µs]
basic 300.79 µs [290.828 µs, 310.752 µs]
loop 10.308 ms [10.276 ms, 10.34 ms]

@pr-commenter
Copy link

pr-commenter bot commented Sep 25, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-duplicated-locals
git_commit_date 1727336528 1727336777
git_commit_sha 845dfba c44ac69
release_version 1.40.0-SNAPSHOT~845dfba933 1.40.0-SNAPSHOT~c44ac69e4c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727339282 1727339282
ci_job_id 652236165 652236165
ci_pipeline_id 45188037 45188037
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~c44ac69e4c, baseline=1.40.0-SNAPSHOT~845dfba933

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1072311
Total [baseline] (8.605 s) : 0, 8605127
Agent [candidate] (1.083 s) : 0, 1083281
Total [candidate] (8.626 s) : 0, 8626119
section iast
Agent [baseline] (1.203 s) : 0, 1202991
Total [baseline] (9.036 s) : 0, 9036338
Agent [candidate] (1.191 s) : 0, 1190918
Total [candidate] (9.008 s) : 0, 9008064
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.2 s) : 0, 1200050
Total [baseline] (9.041 s) : 0, 9040607
Agent [candidate] (1.2 s) : 0, 1199530
Total [candidate] (9.007 s) : 0, 9006853
section iast_TELEMETRY_OFF
Agent [baseline] (1.192 s) : 0, 1191690
Total [baseline] (9.077 s) : 0, 9077072
Agent [candidate] (1.192 s) : 0, 1192238
Total [candidate] (9.031 s) : 0, 9030645
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent iast 1.203 s 130.68 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.2 s 127.739 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.192 s 119.379 ms (11.1%)
Total tracing 8.605 s -
Total iast 9.036 s 431.211 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.041 s 435.479 ms (5.1%)
Total iast_TELEMETRY_OFF 9.077 s 471.945 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent iast 1.191 s 107.638 ms (9.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.2 s 116.249 ms (10.7%)
Agent iast_TELEMETRY_OFF 1.192 s 108.957 ms (10.1%)
Total tracing 8.626 s -
Total iast 9.008 s 381.945 ms (4.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.007 s 380.734 ms (4.4%)
Total iast_TELEMETRY_OFF 9.031 s 404.526 ms (4.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~c44ac69e4c, baseline=1.40.0-SNAPSHOT~845dfba933

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.15 ms) : 0, 684150
BytebuddyAgent [candidate] (691.645 ms) : 0, 691645
GlobalTracer [baseline] (311.442 ms) : 0, 311442
GlobalTracer [candidate] (314.463 ms) : 0, 314463
AppSec [baseline] (54.6 ms) : 0, 54600
AppSec [candidate] (54.797 ms) : 0, 54797
Remote Config [baseline] (677.575 µs) : 0, 678
Remote Config [candidate] (684.32 µs) : 0, 684
Telemetry [baseline] (7.758 ms) : 0, 7758
Telemetry [candidate] (7.8 ms) : 0, 7800
section iast
BytebuddyAgent [baseline] (800.66 ms) : 0, 800660
BytebuddyAgent [candidate] (791.795 ms) : 0, 791795
GlobalTracer [baseline] (301.831 ms) : 0, 301831
GlobalTracer [candidate] (299.3 ms) : 0, 299300
AppSec [baseline] (55.022 ms) : 0, 55022
AppSec [candidate] (55.706 ms) : 0, 55706
IAST [baseline] (22.369 ms) : 0, 22369
IAST [candidate] (22.762 ms) : 0, 22762
Remote Config [baseline] (624.187 µs) : 0, 624
Remote Config [candidate] (590.216 µs) : 0, 590
Telemetry [baseline] (8.647 ms) : 0, 8647
Telemetry [candidate] (6.99 ms) : 0, 6990
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.7 ms) : 0, 798700
BytebuddyAgent [candidate] (798.454 ms) : 0, 798454
GlobalTracer [baseline] (301.359 ms) : 0, 301359
GlobalTracer [candidate] (301.902 ms) : 0, 301902
AppSec [baseline] (56.195 ms) : 0, 56195
AppSec [candidate] (56.336 ms) : 0, 56336
IAST [baseline] (22.222 ms) : 0, 22222
IAST [candidate] (21.256 ms) : 0, 21256
Remote Config [baseline] (599.282 µs) : 0, 599
Remote Config [candidate] (605.536 µs) : 0, 606
Telemetry [baseline] (7.112 ms) : 0, 7112
Telemetry [candidate] (7.085 ms) : 0, 7085
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (790.851 ms) : 0, 790851
BytebuddyAgent [candidate] (791.799 ms) : 0, 791799
GlobalTracer [baseline] (300.006 ms) : 0, 300006
GlobalTracer [candidate] (300.625 ms) : 0, 300625
AppSec [baseline] (55.542 ms) : 0, 55542
AppSec [candidate] (56.132 ms) : 0, 56132
IAST [baseline] (23.787 ms) : 0, 23787
IAST [candidate] (21.585 ms) : 0, 21585
Remote Config [baseline] (622.425 µs) : 0, 622
Remote Config [candidate] (1.359 ms) : 0, 1359
Telemetry [baseline] (7.086 ms) : 0, 7086
Telemetry [candidate] (6.943 ms) : 0, 6943
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~c44ac69e4c, baseline=1.40.0-SNAPSHOT~845dfba933

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067695
Total [baseline] (10.514 s) : 0, 10513617
Agent [candidate] (1.07 s) : 0, 1070023
Total [candidate] (10.478 s) : 0, 10478011
section appsec
Agent [baseline] (1.202 s) : 0, 1202204
Total [baseline] (10.672 s) : 0, 10672039
Agent [candidate] (1.204 s) : 0, 1203537
Total [candidate] (10.668 s) : 0, 10667658
section iast
Agent [baseline] (1.193 s) : 0, 1192952
Total [baseline] (10.937 s) : 0, 10936701
Agent [candidate] (1.195 s) : 0, 1194916
Total [candidate] (10.827 s) : 0, 10827355
section profiling
Agent [baseline] (1.267 s) : 0, 1266645
Total [baseline] (10.539 s) : 0, 10538730
Agent [candidate] (1.275 s) : 0, 1275383
Total [candidate] (10.616 s) : 0, 10615519
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent appsec 1.202 s 134.509 ms (12.6%)
Agent iast 1.193 s 125.257 ms (11.7%)
Agent profiling 1.267 s 198.95 ms (18.6%)
Total tracing 10.514 s -
Total appsec 10.672 s 158.422 ms (1.5%)
Total iast 10.937 s 423.084 ms (4.0%)
Total profiling 10.539 s 25.113 ms (0.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent appsec 1.204 s 133.515 ms (12.5%)
Agent iast 1.195 s 124.894 ms (11.7%)
Agent profiling 1.275 s 205.361 ms (19.2%)
Total tracing 10.478 s -
Total appsec 10.668 s 189.646 ms (1.8%)
Total iast 10.827 s 349.344 ms (3.3%)
Total profiling 10.616 s 137.507 ms (1.3%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~c44ac69e4c, baseline=1.40.0-SNAPSHOT~845dfba933

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.596 ms) : 0, 681596
BytebuddyAgent [candidate] (683.624 ms) : 0, 683624
GlobalTracer [baseline] (309.996 ms) : 0, 309996
GlobalTracer [candidate] (310.192 ms) : 0, 310192
AppSec [baseline] (54.121 ms) : 0, 54121
AppSec [candidate] (54.167 ms) : 0, 54167
Remote Config [baseline] (661.591 µs) : 0, 662
Remote Config [candidate] (661.67 µs) : 0, 662
Telemetry [baseline] (7.65 ms) : 0, 7650
Telemetry [candidate] (7.629 ms) : 0, 7629
section appsec
BytebuddyAgent [baseline] (702.093 ms) : 0, 702093
BytebuddyAgent [candidate] (703.16 ms) : 0, 703160
GlobalTracer [baseline] (303.8 ms) : 0, 303800
GlobalTracer [candidate] (304.59 ms) : 0, 304590
AppSec [baseline] (162.203 ms) : 0, 162203
AppSec [candidate] (163.315 ms) : 0, 163315
IAST [baseline] (20.418 ms) : 0, 20418
IAST [candidate] (20.572 ms) : 0, 20572
Remote Config [baseline] (650.77 µs) : 0, 651
Remote Config [candidate] (642.808 µs) : 0, 643
Telemetry [baseline] (9.561 ms) : 0, 9561
Telemetry [candidate] (7.844 ms) : 0, 7844
section iast
BytebuddyAgent [baseline] (793.393 ms) : 0, 793393
BytebuddyAgent [candidate] (794.778 ms) : 0, 794778
GlobalTracer [baseline] (299.572 ms) : 0, 299572
GlobalTracer [candidate] (299.8 ms) : 0, 299800
AppSec [baseline] (55.529 ms) : 0, 55529
AppSec [candidate] (53.559 ms) : 0, 53559
IAST [baseline] (23.041 ms) : 0, 23041
IAST [candidate] (24.616 ms) : 0, 24616
Remote Config [baseline] (608.891 µs) : 0, 609
Remote Config [candidate] (611.943 µs) : 0, 612
Telemetry [baseline] (7.081 ms) : 0, 7081
Telemetry [candidate] (7.777 ms) : 0, 7777
section profiling
BytebuddyAgent [baseline] (674.632 ms) : 0, 674632
BytebuddyAgent [candidate] (679.167 ms) : 0, 679167
GlobalTracer [baseline] (394.699 ms) : 0, 394699
GlobalTracer [candidate] (397.471 ms) : 0, 397471
AppSec [baseline] (54.559 ms) : 0, 54559
AppSec [candidate] (54.883 ms) : 0, 54883
Remote Config [baseline] (646.243 µs) : 0, 646
Remote Config [candidate] (657.551 µs) : 0, 658
Telemetry [baseline] (7.441 ms) : 0, 7441
Telemetry [candidate] (7.462 ms) : 0, 7462
ProfilingAgent [baseline] (95.918 ms) : 0, 95918
ProfilingAgent [candidate] (96.796 ms) : 0, 96796
Profiling [baseline] (95.941 ms) : 0, 95941
Profiling [candidate] (96.82 ms) : 0, 96820
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-26T07:58:32 2024-09-26T08:05:23
git_branch master jpbempel/fix-duplicated-locals
git_commit_date 1727336528 1727336777
git_commit_sha 845dfba c44ac69
release_version 1.40.0-SNAPSHOT~845dfba933 1.40.0-SNAPSHOT~c44ac69e4c
start_time 2024-09-26T07:58:19 2024-09-26T08:05:10
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727338270 1727338270
ci_job_id 652236166 652236166
ci_pipeline_id 45188037 45188037
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~c44ac69e4c, baseline=1.40.0-SNAPSHOT~845dfba933
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.023 µs) : 359, 399
.   : milestone, 379,
iast (482.501 µs) : 461, 504
.   : milestone, 483,
iast_FULL (555.125 µs) : 534, 576
.   : milestone, 555,
iast_GLOBAL (516.552 µs) : 495, 539
.   : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (488.09 µs) : 466, 510
.   : milestone, 488,
iast_INACTIVE (454.961 µs) : 433, 477
.   : milestone, 455,
iast_TELEMETRY_OFF (473.733 µs) : 451, 497
.   : milestone, 474,
tracing (458.387 µs) : 437, 480
.   : milestone, 458,
section candidate
no_agent (377.114 µs) : 357, 397
.   : milestone, 377,
iast (488.838 µs) : 468, 510
.   : milestone, 489,
iast_FULL (550.654 µs) : 529, 572
.   : milestone, 551,
iast_GLOBAL (510.972 µs) : 489, 533
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (479.366 µs) : 458, 500
.   : milestone, 479,
iast_INACTIVE (451.972 µs) : 430, 474
.   : milestone, 452,
iast_TELEMETRY_OFF (482.696 µs) : 459, 506
.   : milestone, 483,
tracing (445.074 µs) : 424, 466
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.023 µs [359.111 µs, 398.936 µs] -
iast 482.501 µs [461.191 µs, 503.811 µs] 103.478 µs (27.3%)
iast_FULL 555.125 µs [533.872 µs, 576.379 µs] 176.102 µs (46.5%)
iast_GLOBAL 516.552 µs [494.531 µs, 538.573 µs] 137.528 µs (36.3%)
iast_HARDCODED_SECRET_DISABLED 488.09 µs [466.098 µs, 510.083 µs] 109.067 µs (28.8%)
iast_INACTIVE 454.961 µs [433.359 µs, 476.563 µs] 75.938 µs (20.0%)
iast_TELEMETRY_OFF 473.733 µs [450.837 µs, 496.629 µs] 94.71 µs (25.0%)
tracing 458.387 µs [436.589 µs, 480.184 µs] 79.363 µs (20.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.114 µs [357.016 µs, 397.211 µs] -
iast 488.838 µs [467.714 µs, 509.962 µs] 111.724 µs (29.6%)
iast_FULL 550.654 µs [529.318 µs, 571.99 µs] 173.54 µs (46.0%)
iast_GLOBAL 510.972 µs [488.874 µs, 533.069 µs] 133.858 µs (35.5%)
iast_HARDCODED_SECRET_DISABLED 479.366 µs [458.343 µs, 500.388 µs] 102.252 µs (27.1%)
iast_INACTIVE 451.972 µs [429.752 µs, 474.192 µs] 74.858 µs (19.9%)
iast_TELEMETRY_OFF 482.696 µs [459.45 µs, 505.942 µs] 105.582 µs (28.0%)
tracing 445.074 µs [424.451 µs, 465.696 µs] 67.96 µs (18.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~c44ac69e4c, baseline=1.40.0-SNAPSHOT~845dfba933
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.341 ms) : 1322, 1361
.   : milestone, 1341,
appsec (1.716 ms) : 1692, 1739
.   : milestone, 1716,
appsec_no_iast (1.727 ms) : 1703, 1751
.   : milestone, 1727,
iast (1.477 ms) : 1455, 1499
.   : milestone, 1477,
profiling (1.477 ms) : 1453, 1500
.   : milestone, 1477,
tracing (1.469 ms) : 1445, 1494
.   : milestone, 1469,
section candidate
no_agent (1.339 ms) : 1319, 1358
.   : milestone, 1339,
appsec (1.731 ms) : 1706, 1755
.   : milestone, 1731,
appsec_no_iast (1.727 ms) : 1703, 1750
.   : milestone, 1727,
iast (1.471 ms) : 1448, 1494
.   : milestone, 1471,
profiling (1.509 ms) : 1483, 1535
.   : milestone, 1509,
tracing (1.468 ms) : 1444, 1491
.   : milestone, 1468,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.341 ms [1.322 ms, 1.361 ms] -
appsec 1.716 ms [1.692 ms, 1.739 ms] 374.295 µs (27.9%)
appsec_no_iast 1.727 ms [1.703 ms, 1.751 ms] 385.825 µs (28.8%)
iast 1.477 ms [1.455 ms, 1.499 ms] 135.446 µs (10.1%)
profiling 1.477 ms [1.453 ms, 1.5 ms] 135.237 µs (10.1%)
tracing 1.469 ms [1.445 ms, 1.494 ms] 127.86 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.339 ms [1.319 ms, 1.358 ms] -
appsec 1.731 ms [1.706 ms, 1.755 ms] 392.354 µs (29.3%)
appsec_no_iast 1.727 ms [1.703 ms, 1.75 ms] 388.105 µs (29.0%)
iast 1.471 ms [1.448 ms, 1.494 ms] 132.17 µs (9.9%)
profiling 1.509 ms [1.483 ms, 1.535 ms] 170.754 µs (12.8%)
tracing 1.468 ms [1.444 ms, 1.491 ms] 129.18 µs (9.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-duplicated-locals
git_commit_date 1727336528 1727336777
git_commit_sha 845dfba c44ac69
release_version 1.40.0-SNAPSHOT~845dfba933 1.40.0-SNAPSHOT~c44ac69e4c
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727338797 1727338797
ci_job_id 652236167 652236167
ci_pipeline_id 45188037 45188037
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~c44ac69e4c, baseline=1.40.0-SNAPSHOT~845dfba933
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
.   : milestone, 1480,
appsec (2.348 ms) : 2307, 2388
.   : milestone, 2348,
iast (2.07 ms) : 2019, 2121
.   : milestone, 2070,
iast_GLOBAL (2.115 ms) : 2063, 2166
.   : milestone, 2115,
profiling (1.944 ms) : 1904, 1984
.   : milestone, 1944,
tracing (1.907 ms) : 1869, 1946
.   : milestone, 1907,
section candidate
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (2.333 ms) : 2292, 2373
.   : milestone, 2333,
iast (2.057 ms) : 2008, 2106
.   : milestone, 2057,
iast_GLOBAL (2.113 ms) : 2062, 2164
.   : milestone, 2113,
profiling (1.951 ms) : 1911, 1991
.   : milestone, 1951,
tracing (1.915 ms) : 1877, 1954
.   : milestone, 1915,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.48 ms [1.468 ms, 1.491 ms] -
appsec 2.348 ms [2.307 ms, 2.388 ms] 868.044 µs (58.7%)
iast 2.07 ms [2.019 ms, 2.121 ms] 590.435 µs (39.9%)
iast_GLOBAL 2.115 ms [2.063 ms, 2.166 ms] 635.203 µs (42.9%)
profiling 1.944 ms [1.904 ms, 1.984 ms] 464.506 µs (31.4%)
tracing 1.907 ms [1.869 ms, 1.946 ms] 427.712 µs (28.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.463 ms, 1.486 ms] -
appsec 2.333 ms [2.292 ms, 2.373 ms] 858.377 µs (58.2%)
iast 2.057 ms [2.008 ms, 2.106 ms] 582.84 µs (39.5%)
iast_GLOBAL 2.113 ms [2.062 ms, 2.164 ms] 638.99 µs (43.3%)
profiling 1.951 ms [1.911 ms, 1.991 ms] 476.976 µs (32.4%)
tracing 1.915 ms [1.877 ms, 1.954 ms] 441.314 µs (29.9%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~c44ac69e4c, baseline=1.40.0-SNAPSHOT~845dfba933
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.21 s) : 15210000, 15210000
.   : milestone, 15210000,
appsec (15.317 s) : 15317000, 15317000
.   : milestone, 15317000,
iast (19.173 s) : 19173000, 19173000
.   : milestone, 19173000,
iast_GLOBAL (18.368 s) : 18368000, 18368000
.   : milestone, 18368000,
profiling (15.077 s) : 15077000, 15077000
.   : milestone, 15077000,
tracing (15.201 s) : 15201000, 15201000
.   : milestone, 15201000,
section candidate
no_agent (15.015 s) : 15015000, 15015000
.   : milestone, 15015000,
appsec (15.353 s) : 15353000, 15353000
.   : milestone, 15353000,
iast (19.0 s) : 19000000, 19000000
.   : milestone, 19000000,
iast_GLOBAL (18.146 s) : 18146000, 18146000
.   : milestone, 18146000,
profiling (15.381 s) : 15381000, 15381000
.   : milestone, 15381000,
tracing (14.929 s) : 14929000, 14929000
.   : milestone, 14929000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.21 s [15.21 s, 15.21 s] -
appsec 15.317 s [15.317 s, 15.317 s] 107.0 ms (0.7%)
iast 19.173 s [19.173 s, 19.173 s] 3.963 s (26.1%)
iast_GLOBAL 18.368 s [18.368 s, 18.368 s] 3.158 s (20.8%)
profiling 15.077 s [15.077 s, 15.077 s] -133.0 ms (-0.9%)
tracing 15.201 s [15.201 s, 15.201 s] -9.0 ms (-0.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.015 s [15.015 s, 15.015 s] -
appsec 15.353 s [15.353 s, 15.353 s] 338.0 ms (2.3%)
iast 19.0 s [19.0 s, 19.0 s] 3.985 s (26.5%)
iast_GLOBAL 18.146 s [18.146 s, 18.146 s] 3.131 s (20.9%)
profiling 15.381 s [15.381 s, 15.381 s] 366.0 ms (2.4%)
tracing 14.929 s [14.929 s, 14.929 s] -86.0 ms (-0.6%)

@jpbempel
Fix duplicated locals with arguments
c44ac69 
When hoisting local variables remove the locals that could be have the
 same name than arguments.
This could happen resulting of the instrumentation by the tracer
that reshuffle the local variable table and then reassign dedicated
slots to those arguments
@jpbempel jpbempel force-pushed the jpbempel/fix-duplicated-locals branch from c728c36 to c44ac69 Compare September 26, 2024 07:46
@jpbempel jpbempel merged commit 05e8fd6 into master Sep 26, 2024
103 checks passed
@jpbempel jpbempel deleted the jpbempel/fix-duplicated-locals branch September 26, 2024 20:08
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatzi shatzi shatzi approved these changes

@evanchooly evanchooly Awaiting requested review from evanchooly evanchooly is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @shatzi