Add akka-http client 10.6+ support #7680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarziali
requested review from
manuel-alvarez-alvarez and
ValentinZakharov
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
...tp-10.6/src/main/java11/datadog/trace/instrumentation/akkahttp106/AkkaHttpClientHelpers.java
Show resolved
Hide resolved
amarziali
force-pushed
the
andrea.marziali/akka
branch
from
373f866 to
036bf46
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~e723973e3e, baseline=1.40.0-SNAPSHOT~043adb202c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065004
Total [baseline] (8.543 s) : 0, 8543393
Agent [candidate] (1.065 s) : 0, 1065288
Total [candidate] (8.554 s) : 0, 8553517
section iast
Agent [baseline] (1.194 s) : 0, 1193564
Total [baseline] (9.04 s) : 0, 9039616
Agent [candidate] (1.189 s) : 0, 1189079
Total [candidate] (8.996 s) : 0, 8996280
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.188 s) : 0, 1188104
Total [baseline] (8.984 s) : 0, 8984148
Agent [candidate] (1.189 s) : 0, 1189393
Total [candidate] (9.004 s) : 0, 9003735
section iast_TELEMETRY_OFF
Agent [baseline] (1.195 s) : 0, 1194945
Total [baseline] (9.014 s) : 0, 9013609
Agent [candidate] (1.189 s) : 0, 1188510
Total [candidate] (8.982 s) : 0, 8982061
gantt
title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~e723973e3e, baseline=1.40.0-SNAPSHOT~043adb202c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.502 ms) : 0, 679502
BytebuddyAgent [candidate] (679.378 ms) : 0, 679378
GlobalTracer [baseline] (309.643 ms) : 0, 309643
GlobalTracer [candidate] (310.298 ms) : 0, 310298
AppSec [baseline] (53.934 ms) : 0, 53934
AppSec [candidate] (53.811 ms) : 0, 53811
Remote Config [baseline] (676.243 µs) : 0, 676
Remote Config [candidate] (664.993 µs) : 0, 665
Telemetry [baseline] (7.672 ms) : 0, 7672
Telemetry [candidate] (7.535 ms) : 0, 7535
section iast
BytebuddyAgent [baseline] (795.996 ms) : 0, 795996
BytebuddyAgent [candidate] (791.354 ms) : 0, 791354
GlobalTracer [baseline] (298.114 ms) : 0, 298114
GlobalTracer [candidate] (298.534 ms) : 0, 298534
AppSec [baseline] (53.039 ms) : 0, 53039
AppSec [candidate] (56.13 ms) : 0, 56130
IAST [baseline] (24.357 ms) : 0, 24357
IAST [candidate] (21.829 ms) : 0, 21829
Remote Config [baseline] (646.597 µs) : 0, 647
Remote Config [candidate] (616.914 µs) : 0, 617
Telemetry [baseline] (7.72 ms) : 0, 7720
Telemetry [candidate] (6.959 ms) : 0, 6959
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (790.709 ms) : 0, 790709
BytebuddyAgent [candidate] (791.626 ms) : 0, 791626
GlobalTracer [baseline] (298.14 ms) : 0, 298140
GlobalTracer [candidate] (298.641 ms) : 0, 298641
AppSec [baseline] (53.022 ms) : 0, 53022
AppSec [candidate] (56.948 ms) : 0, 56948
IAST [baseline] (25.076 ms) : 0, 25076
IAST [candidate] (20.933 ms) : 0, 20933
Remote Config [baseline] (596.626 µs) : 0, 597
Remote Config [candidate] (610.595 µs) : 0, 611
Telemetry [baseline] (6.944 ms) : 0, 6944
Telemetry [candidate] (6.985 ms) : 0, 6985
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (794.72 ms) : 0, 794720
BytebuddyAgent [candidate] (790.424 ms) : 0, 790424
GlobalTracer [baseline] (300.825 ms) : 0, 300825
GlobalTracer [candidate] (299.079 ms) : 0, 299079
AppSec [baseline] (55.858 ms) : 0, 55858
AppSec [candidate] (55.738 ms) : 0, 55738
IAST [baseline] (22.304 ms) : 0, 22304
IAST [candidate] (22.194 ms) : 0, 22194
Remote Config [baseline] (604.399 µs) : 0, 604
Remote Config [candidate] (591.549 µs) : 0, 592
Telemetry [baseline] (6.919 ms) : 0, 6919
Telemetry [candidate] (6.829 ms) : 0, 6829
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~e723973e3e, baseline=1.40.0-SNAPSHOT~043adb202c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1070563
Total [baseline] (10.468 s) : 0, 10468497
Agent [candidate] (1.066 s) : 0, 1065626
Total [candidate] (10.493 s) : 0, 10493465
section appsec
Agent [baseline] (1.201 s) : 0, 1201497
Total [baseline] (10.643 s) : 0, 10643191
Agent [candidate] (1.201 s) : 0, 1201023
Total [candidate] (10.684 s) : 0, 10684034
section iast
Agent [baseline] (1.189 s) : 0, 1188522
Total [baseline] (10.785 s) : 0, 10785477
Agent [candidate] (1.199 s) : 0, 1198625
Total [candidate] (10.871 s) : 0, 10871464
section profiling
Agent [baseline] (1.274 s) : 0, 1273833
Total [baseline] (10.661 s) : 0, 10660736
Agent [candidate] (1.265 s) : 0, 1265366
Total [candidate] (10.579 s) : 0, 10579422
gantt
title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~e723973e3e, baseline=1.40.0-SNAPSHOT~043adb202c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.663 ms) : 0, 683663
BytebuddyAgent [candidate] (679.367 ms) : 0, 679367
GlobalTracer [baseline] (310.88 ms) : 0, 310880
GlobalTracer [candidate] (310.761 ms) : 0, 310761
AppSec [baseline] (54.009 ms) : 0, 54009
AppSec [candidate] (53.633 ms) : 0, 53633
Remote Config [baseline] (659.708 µs) : 0, 660
Remote Config [candidate] (662.533 µs) : 0, 663
Telemetry [baseline] (7.707 ms) : 0, 7707
Telemetry [candidate] (7.601 ms) : 0, 7601
section appsec
BytebuddyAgent [baseline] (703.664 ms) : 0, 703664
BytebuddyAgent [candidate] (701.432 ms) : 0, 701432
GlobalTracer [baseline] (304.607 ms) : 0, 304607
GlobalTracer [candidate] (303.539 ms) : 0, 303539
AppSec [baseline] (161.241 ms) : 0, 161241
AppSec [candidate] (162.697 ms) : 0, 162697
IAST [baseline] (19.705 ms) : 0, 19705
IAST [candidate] (21.374 ms) : 0, 21374
Remote Config [baseline] (648.286 µs) : 0, 648
Remote Config [candidate] (644.506 µs) : 0, 645
Telemetry [baseline] (7.874 ms) : 0, 7874
Telemetry [candidate] (8.452 ms) : 0, 8452
section iast
BytebuddyAgent [baseline] (790.856 ms) : 0, 790856
BytebuddyAgent [candidate] (798.023 ms) : 0, 798023
GlobalTracer [baseline] (298.549 ms) : 0, 298549
GlobalTracer [candidate] (300.813 ms) : 0, 300813
AppSec [baseline] (54.409 ms) : 0, 54409
AppSec [candidate] (55.55 ms) : 0, 55550
IAST [baseline] (23.544 ms) : 0, 23544
IAST [candidate] (22.88 ms) : 0, 22880
Remote Config [baseline] (612.633 µs) : 0, 613
Remote Config [candidate] (617.875 µs) : 0, 618
Telemetry [baseline] (6.964 ms) : 0, 6964
Telemetry [candidate] (7.043 ms) : 0, 7043
section profiling
BytebuddyAgent [baseline] (677.998 ms) : 0, 677998
BytebuddyAgent [candidate] (673.554 ms) : 0, 673554
GlobalTracer [baseline] (396.562 ms) : 0, 396562
GlobalTracer [candidate] (393.986 ms) : 0, 393986
AppSec [baseline] (54.998 ms) : 0, 54998
AppSec [candidate] (54.678 ms) : 0, 54678
Remote Config [baseline] (666.74 µs) : 0, 667
Remote Config [candidate] (644.215 µs) : 0, 644
Telemetry [baseline] (7.484 ms) : 0, 7484
Telemetry [candidate] (7.498 ms) : 0, 7498
ProfilingAgent [baseline] (97.36 ms) : 0, 97360
ProfilingAgent [candidate] (96.564 ms) : 0, 96564
Profiling [baseline] (97.383 ms) : 0, 97383
Profiling [candidate] (96.587 ms) : 0, 96587
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~e723973e3e, baseline=1.40.0-SNAPSHOT~043adb202c
dateFormat X
axisFormat %s
section baseline
no_agent (373.049 µs) : 353, 393
. : milestone, 373,
iast (495.766 µs) : 474, 517
. : milestone, 496,
iast_FULL (558.877 µs) : 538, 580
. : milestone, 559,
iast_GLOBAL (507.732 µs) : 487, 529
. : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (491.636 µs) : 470, 513
. : milestone, 492,
iast_INACTIVE (449.416 µs) : 429, 470
. : milestone, 449,
iast_TELEMETRY_OFF (478.943 µs) : 456, 502
. : milestone, 479,
tracing (452.475 µs) : 432, 473
. : milestone, 452,
section candidate
no_agent (369.217 µs) : 350, 389
. : milestone, 369,
iast (486.454 µs) : 465, 508
. : milestone, 486,
iast_FULL (551.075 µs) : 530, 572
. : milestone, 551,
iast_GLOBAL (506.15 µs) : 485, 527
. : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (480.121 µs) : 459, 501
. : milestone, 480,
iast_INACTIVE (457.74 µs) : 437, 478
. : milestone, 458,
iast_TELEMETRY_OFF (479.868 µs) : 457, 502
. : milestone, 480,
tracing (444.599 µs) : 424, 465
. : milestone, 445,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~e723973e3e, baseline=1.40.0-SNAPSHOT~043adb202c
dateFormat X
axisFormat %s
section baseline
no_agent (1.353 ms) : 1334, 1373
. : milestone, 1353,
appsec (1.708 ms) : 1683, 1733
. : milestone, 1708,
appsec_no_iast (1.702 ms) : 1678, 1725
. : milestone, 1702,
iast (1.477 ms) : 1455, 1499
. : milestone, 1477,
profiling (1.48 ms) : 1455, 1505
. : milestone, 1480,
tracing (1.478 ms) : 1454, 1502
. : milestone, 1478,
section candidate
no_agent (1.345 ms) : 1325, 1364
. : milestone, 1345,
appsec (1.717 ms) : 1694, 1741
. : milestone, 1717,
appsec_no_iast (1.748 ms) : 1724, 1772
. : milestone, 1748,
iast (1.491 ms) : 1468, 1514
. : milestone, 1491,
profiling (1.517 ms) : 1492, 1542
. : milestone, 1517,
tracing (1.486 ms) : 1462, 1509
. : milestone, 1486,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~e723973e3e, baseline=1.40.0-SNAPSHOT~043adb202c
dateFormat X
axisFormat %s
section baseline
no_agent (15.045 s) : 15045000, 15045000
. : milestone, 15045000,
appsec (15.264 s) : 15264000, 15264000
. : milestone, 15264000,
iast (19.045 s) : 19045000, 19045000
. : milestone, 19045000,
iast_GLOBAL (18.104 s) : 18104000, 18104000
. : milestone, 18104000,
profiling (14.806 s) : 14806000, 14806000
. : milestone, 14806000,
tracing (15.355 s) : 15355000, 15355000
. : milestone, 15355000,
section candidate
no_agent (15.477 s) : 15477000, 15477000
. : milestone, 15477000,
appsec (15.176 s) : 15176000, 15176000
. : milestone, 15176000,
iast (18.905 s) : 18905000, 18905000
. : milestone, 18905000,
iast_GLOBAL (18.322 s) : 18322000, 18322000
. : milestone, 18322000,
profiling (15.31 s) : 15310000, 15310000
. : milestone, 15310000,
tracing (15.226 s) : 15226000, 15226000
. : milestone, 15226000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~e723973e3e, baseline=1.40.0-SNAPSHOT~043adb202c
dateFormat X
axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1474
. : milestone, 1462,
appsec (2.314 ms) : 2274, 2355
. : milestone, 2314,
iast (2.058 ms) : 2007, 2109
. : milestone, 2058,
iast_GLOBAL (2.078 ms) : 2028, 2128
. : milestone, 2078,
profiling (1.93 ms) : 1888, 1972
. : milestone, 1930,
tracing (1.898 ms) : 1859, 1936
. : milestone, 1898,
section candidate
no_agent (1.461 ms) : 1450, 1473
. : milestone, 1461,
appsec (2.316 ms) : 2276, 2357
. : milestone, 2316,
iast (2.053 ms) : 2003, 2104
. : milestone, 2053,
iast_GLOBAL (2.095 ms) : 2045, 2146
. : milestone, 2095,
profiling (1.92 ms) : 1881, 1960
. : milestone, 1920,
tracing (1.907 ms) : 1869, 1946
. : milestone, 1907,
|
amarziali
force-pushed
the
andrea.marziali/akka
branch
from
036bf46 to
6e56e22
Compare
amarziali
force-pushed
the
andrea.marziali/akka
branch
from
9e4c0ee to
aaffb88
Compare
smola
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add support for akka http client 10.6+ and restore muzzle checks.
Muzzle was not testing 10.6+ because the artifacts are in another repo (not in central) and also because they have a baseline of java 11
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMS-13202