Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version metadata for non DD_SERVICE spans #7661

Merged
merged 7 commits into from
Oct 9, 2024
Merged

Remove version metadata for non DD_SERVICE spans #7661

merged 7 commits into from
Oct 9, 2024

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Sep 20, 2024 •
edited by jira bot
Loading

What Does This Do

Remove the version tag from span metadata when the span's service tag is not the same as the DD_SERVICE set from the configuration.

Motivation

Our goal is to make the implementation of configuration variables consistent for all languages as part of the config consistency effort listed in the following RFC. The expected behavior for the DD_VERSION config is to apply the value to all spans iff the service value of the span is DD_SERVICE.

Additional Notes

Testing for the functionality of this feature is done in the system-tests repository.

Contributor Checklist

Jira ticket: APMAPI-475

@mhlidd mhlidd requested a review from mtoffl01 September 20, 2024 19:58
@pr-commenter
Copy link

pr-commenter bot commented Sep 20, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/DD_VERSION
git_commit_date 1728493034 1728494236
git_commit_sha 14a45ea cc28d89
release_version 1.41.0-SNAPSHOT~14a45ea1c3 1.41.0-SNAPSHOT~cc28d89c23
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728496577 1728496577
ci_job_id 667296028 667296028
ci_pipeline_id 46206923 46206923
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~cc28d89c23, baseline=1.41.0-SNAPSHOT~14a45ea1c3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068617
Total [baseline] (10.384 s) : 0, 10384041
Agent [candidate] (1.069 s) : 0, 1069340
Total [candidate] (10.381 s) : 0, 10380895
section appsec
Agent [baseline] (1.201 s) : 0, 1201269
Total [baseline] (10.557 s) : 0, 10556983
Agent [candidate] (1.213 s) : 0, 1212989
Total [candidate] (10.621 s) : 0, 10621093
section iast
Agent [baseline] (1.204 s) : 0, 1204337
Total [baseline] (10.859 s) : 0, 10859407
Agent [candidate] (1.197 s) : 0, 1197254
Total [candidate] (10.849 s) : 0, 10848787
section profiling
Agent [baseline] (1.269 s) : 0, 1268508
Total [baseline] (10.584 s) : 0, 10583524
Agent [candidate] (1.279 s) : 0, 1279094
Total [candidate] (10.669 s) : 0, 10669150
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent appsec 1.201 s 132.652 ms (12.4%)
Agent iast 1.204 s 135.72 ms (12.7%)
Agent profiling 1.269 s 199.891 ms (18.7%)
Total tracing 10.384 s -
Total appsec 10.557 s 172.942 ms (1.7%)
Total iast 10.859 s 475.366 ms (4.6%)
Total profiling 10.584 s 199.483 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent appsec 1.213 s 143.649 ms (13.4%)
Agent iast 1.197 s 127.914 ms (12.0%)
Agent profiling 1.279 s 209.754 ms (19.6%)
Total tracing 10.381 s -
Total appsec 10.621 s 240.198 ms (2.3%)
Total iast 10.849 s 467.892 ms (4.5%)
Total profiling 10.669 s 288.254 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~cc28d89c23, baseline=1.41.0-SNAPSHOT~14a45ea1c3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.912 ms) : 0, 681912
BytebuddyAgent [candidate] (682.344 ms) : 0, 682344
GlobalTracer [baseline] (310.982 ms) : 0, 310982
GlobalTracer [candidate] (311.299 ms) : 0, 311299
AppSec [baseline] (53.845 ms) : 0, 53845
AppSec [candidate] (53.664 ms) : 0, 53664
Remote Config [baseline] (706.998 µs) : 0, 707
Remote Config [candidate] (663.829 µs) : 0, 664
Telemetry [baseline] (7.519 ms) : 0, 7519
Telemetry [candidate] (7.63 ms) : 0, 7630
section appsec
BytebuddyAgent [baseline] (697.922 ms) : 0, 697922
BytebuddyAgent [candidate] (704.365 ms) : 0, 704365
GlobalTracer [baseline] (307.605 ms) : 0, 307605
GlobalTracer [candidate] (310.46 ms) : 0, 310460
AppSec [baseline] (163.323 ms) : 0, 163323
AppSec [candidate] (164.802 ms) : 0, 164802
IAST [baseline] (20.067 ms) : 0, 20067
IAST [candidate] (21.459 ms) : 0, 21459
Remote Config [baseline] (630.672 µs) : 0, 631
Remote Config [candidate] (640.057 µs) : 0, 640
Telemetry [baseline] (8.102 ms) : 0, 8102
Telemetry [candidate] (8.161 ms) : 0, 8161
section iast
BytebuddyAgent [baseline] (802.78 ms) : 0, 802780
BytebuddyAgent [candidate] (797.451 ms) : 0, 797451
GlobalTracer [baseline] (301.399 ms) : 0, 301399
GlobalTracer [candidate] (299.77 ms) : 0, 299770
AppSec [baseline] (54.856 ms) : 0, 54856
AppSec [candidate] (54.08 ms) : 0, 54080
IAST [baseline] (22.991 ms) : 0, 22991
IAST [candidate] (24.61 ms) : 0, 24610
Remote Config [baseline] (606.255 µs) : 0, 606
Remote Config [candidate] (595.36 µs) : 0, 595
Telemetry [baseline] (7.931 ms) : 0, 7931
Telemetry [candidate] (7.06 ms) : 0, 7060
section profiling
BytebuddyAgent [baseline] (676.669 ms) : 0, 676669
BytebuddyAgent [candidate] (683.857 ms) : 0, 683857
GlobalTracer [baseline] (393.485 ms) : 0, 393485
GlobalTracer [candidate] (395.641 ms) : 0, 395641
AppSec [baseline] (54.676 ms) : 0, 54676
AppSec [candidate] (55.108 ms) : 0, 55108
Remote Config [baseline] (660.378 µs) : 0, 660
Remote Config [candidate] (656.377 µs) : 0, 656
Telemetry [baseline] (7.467 ms) : 0, 7467
Telemetry [candidate] (7.491 ms) : 0, 7491
ProfilingAgent [baseline] (96.878 ms) : 0, 96878
ProfilingAgent [candidate] (97.316 ms) : 0, 97316
Profiling [baseline] (96.902 ms) : 0, 96902
Profiling [candidate] (97.34 ms) : 0, 97340
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~cc28d89c23, baseline=1.41.0-SNAPSHOT~14a45ea1c3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080689
Total [baseline] (8.545 s) : 0, 8545301
Agent [candidate] (1.07 s) : 0, 1070350
Total [candidate] (8.564 s) : 0, 8564456
section iast
Agent [baseline] (1.197 s) : 0, 1196918
Total [baseline] (9.12 s) : 0, 9119788
Agent [candidate] (1.197 s) : 0, 1197103
Total [candidate] (9.084 s) : 0, 9084444
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.196 s) : 0, 1196279
Total [baseline] (9.089 s) : 0, 9088617
Agent [candidate] (1.204 s) : 0, 1203775
Total [candidate] (9.069 s) : 0, 9069096
section iast_TELEMETRY_OFF
Agent [baseline] (1.191 s) : 0, 1191197
Total [baseline] (9.083 s) : 0, 9082760
Agent [candidate] (1.198 s) : 0, 1197877
Total [candidate] (9.056 s) : 0, 9055974
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.197 s 116.229 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.196 s 115.59 ms (10.7%)
Agent iast_TELEMETRY_OFF 1.191 s 110.507 ms (10.2%)
Total tracing 8.545 s -
Total iast 9.12 s 574.487 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.089 s 543.316 ms (6.4%)
Total iast_TELEMETRY_OFF 9.083 s 537.458 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent iast 1.197 s 126.753 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.204 s 133.424 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.198 s 127.527 ms (11.9%)
Total tracing 8.564 s -
Total iast 9.084 s 519.987 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.069 s 504.64 ms (5.9%)
Total iast_TELEMETRY_OFF 9.056 s 491.518 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~cc28d89c23, baseline=1.41.0-SNAPSHOT~14a45ea1c3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.328 ms) : 0, 690328
BytebuddyAgent [candidate] (683.223 ms) : 0, 683223
GlobalTracer [baseline] (313.716 ms) : 0, 313716
GlobalTracer [candidate] (311.345 ms) : 0, 311345
AppSec [baseline] (54.365 ms) : 0, 54365
AppSec [candidate] (53.82 ms) : 0, 53820
Remote Config [baseline] (670.232 µs) : 0, 670
Remote Config [candidate] (649.964 µs) : 0, 650
Telemetry [baseline] (7.757 ms) : 0, 7757
Telemetry [candidate] (7.601 ms) : 0, 7601
section iast
BytebuddyAgent [baseline] (795.479 ms) : 0, 795479
BytebuddyAgent [candidate] (797.65 ms) : 0, 797650
GlobalTracer [baseline] (301.257 ms) : 0, 301257
GlobalTracer [candidate] (299.893 ms) : 0, 299893
AppSec [baseline] (55.633 ms) : 0, 55633
AppSec [candidate] (55.492 ms) : 0, 55492
IAST [baseline] (23.185 ms) : 0, 23185
IAST [candidate] (22.678 ms) : 0, 22678
Remote Config [baseline] (601.517 µs) : 0, 602
Remote Config [candidate] (602.124 µs) : 0, 602
Telemetry [baseline] (7.077 ms) : 0, 7077
Telemetry [candidate] (7.041 ms) : 0, 7041
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (797.103 ms) : 0, 797103
BytebuddyAgent [candidate] (802.927 ms) : 0, 802927
GlobalTracer [baseline] (299.355 ms) : 0, 299355
GlobalTracer [candidate] (301.491 ms) : 0, 301491
AppSec [baseline] (56.248 ms) : 0, 56248
AppSec [candidate] (56.005 ms) : 0, 56005
IAST [baseline] (22.091 ms) : 0, 22091
IAST [candidate] (21.857 ms) : 0, 21857
Remote Config [baseline] (606.172 µs) : 0, 606
Remote Config [candidate] (608.336 µs) : 0, 608
Telemetry [baseline] (7.149 ms) : 0, 7149
Telemetry [candidate] (7.073 ms) : 0, 7073
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (793.446 ms) : 0, 793446
BytebuddyAgent [candidate] (797.956 ms) : 0, 797956
GlobalTracer [baseline] (299.168 ms) : 0, 299168
GlobalTracer [candidate] (300.587 ms) : 0, 300587
AppSec [baseline] (55.188 ms) : 0, 55188
AppSec [candidate] (55.619 ms) : 0, 55619
IAST [baseline] (22.179 ms) : 0, 22179
IAST [candidate] (22.394 ms) : 0, 22394
Remote Config [baseline] (598.68 µs) : 0, 599
Remote Config [candidate] (602.178 µs) : 0, 602
Telemetry [baseline] (6.895 ms) : 0, 6895
Telemetry [candidate] (6.932 ms) : 0, 6932
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-09T17:26:46 2024-10-09T17:33:40
git_branch master mhlidd/DD_VERSION
git_commit_date 1728493034 1728494236
git_commit_sha 14a45ea cc28d89
release_version 1.41.0-SNAPSHOT~14a45ea1c3 1.41.0-SNAPSHOT~cc28d89c23
start_time 2024-10-09T17:26:33 2024-10-09T17:33:27
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728495568 1728495568
ci_job_id 667296029 667296029
ci_pipeline_id 46206923 46206923
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~cc28d89c23, baseline=1.41.0-SNAPSHOT~14a45ea1c3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.35 ms) : 1329, 1370
.   : milestone, 1350,
appsec (1.728 ms) : 1703, 1754
.   : milestone, 1728,
appsec_no_iast (1.736 ms) : 1712, 1760
.   : milestone, 1736,
iast (1.497 ms) : 1474, 1520
.   : milestone, 1497,
profiling (1.491 ms) : 1468, 1514
.   : milestone, 1491,
tracing (1.492 ms) : 1465, 1520
.   : milestone, 1492,
section candidate
no_agent (1.346 ms) : 1328, 1365
.   : milestone, 1346,
appsec (1.725 ms) : 1700, 1750
.   : milestone, 1725,
appsec_no_iast (1.735 ms) : 1711, 1759
.   : milestone, 1735,
iast (1.492 ms) : 1469, 1514
.   : milestone, 1492,
profiling (1.486 ms) : 1461, 1510
.   : milestone, 1486,
tracing (1.481 ms) : 1457, 1505
.   : milestone, 1481,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.329 ms, 1.37 ms] -
appsec 1.728 ms [1.703 ms, 1.754 ms] 378.673 µs (28.1%)
appsec_no_iast 1.736 ms [1.712 ms, 1.76 ms] 386.233 µs (28.6%)
iast 1.497 ms [1.474 ms, 1.52 ms] 147.268 µs (10.9%)
profiling 1.491 ms [1.468 ms, 1.514 ms] 141.191 µs (10.5%)
tracing 1.492 ms [1.465 ms, 1.52 ms] 142.672 µs (10.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.328 ms, 1.365 ms] -
appsec 1.725 ms [1.7 ms, 1.75 ms] 378.694 µs (28.1%)
appsec_no_iast 1.735 ms [1.711 ms, 1.759 ms] 388.586 µs (28.9%)
iast 1.492 ms [1.469 ms, 1.514 ms] 145.435 µs (10.8%)
profiling 1.486 ms [1.461 ms, 1.51 ms] 139.415 µs (10.4%)
tracing 1.481 ms [1.457 ms, 1.505 ms] 135.133 µs (10.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~cc28d89c23, baseline=1.41.0-SNAPSHOT~14a45ea1c3
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.847 µs) : 354, 392
.   : milestone, 373,
iast (491.122 µs) : 470, 512
.   : milestone, 491,
iast_FULL (561.308 µs) : 540, 583
.   : milestone, 561,
iast_GLOBAL (514.941 µs) : 494, 536
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (490.548 µs) : 469, 512
.   : milestone, 491,
iast_INACTIVE (460.646 µs) : 439, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (478.939 µs) : 458, 500
.   : milestone, 479,
tracing (455.547 µs) : 435, 477
.   : milestone, 456,
section candidate
no_agent (373.333 µs) : 353, 393
.   : milestone, 373,
iast (489.298 µs) : 468, 511
.   : milestone, 489,
iast_FULL (560.914 µs) : 540, 582
.   : milestone, 561,
iast_GLOBAL (513.448 µs) : 492, 535
.   : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (491.163 µs) : 470, 513
.   : milestone, 491,
iast_INACTIVE (454.507 µs) : 433, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (474.06 µs) : 453, 495
.   : milestone, 474,
tracing (454.268 µs) : 433, 476
.   : milestone, 454,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.847 µs [353.592 µs, 392.102 µs] -
iast 491.122 µs [470.0 µs, 512.244 µs] 118.275 µs (31.7%)
iast_FULL 561.308 µs [539.978 µs, 582.638 µs] 188.461 µs (50.5%)
iast_GLOBAL 514.941 µs [493.902 µs, 535.98 µs] 142.094 µs (38.1%)
iast_HARDCODED_SECRET_DISABLED 490.548 µs [469.013 µs, 512.083 µs] 117.701 µs (31.6%)
iast_INACTIVE 460.646 µs [438.966 µs, 482.327 µs] 87.799 µs (23.5%)
iast_TELEMETRY_OFF 478.939 µs [457.786 µs, 500.093 µs] 106.092 µs (28.5%)
tracing 455.547 µs [434.507 µs, 476.588 µs] 82.7 µs (22.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.333 µs [353.398 µs, 393.269 µs] -
iast 489.298 µs [467.886 µs, 510.709 µs] 115.964 µs (31.1%)
iast_FULL 560.914 µs [539.638 µs, 582.19 µs] 187.581 µs (50.2%)
iast_GLOBAL 513.448 µs [492.228 µs, 534.668 µs] 140.115 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED 491.163 µs [469.802 µs, 512.524 µs] 117.83 µs (31.6%)
iast_INACTIVE 454.507 µs [433.469 µs, 475.545 µs] 81.174 µs (21.7%)
iast_TELEMETRY_OFF 474.06 µs [453.238 µs, 494.881 µs] 100.726 µs (27.0%)
tracing 454.268 µs [432.98 µs, 475.556 µs] 80.935 µs (21.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/DD_VERSION
git_commit_date 1728493034 1728494236
git_commit_sha 14a45ea cc28d89
release_version 1.41.0-SNAPSHOT~14a45ea1c3 1.41.0-SNAPSHOT~cc28d89c23
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1728496216 1728496216
ci_job_id 667296030 667296030
ci_pipeline_id 46206923 46206923
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~cc28d89c23, baseline=1.41.0-SNAPSHOT~14a45ea1c3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.302 ms) : 2262, 2342
.   : milestone, 2302,
iast (2.059 ms) : 2008, 2110
.   : milestone, 2059,
iast_GLOBAL (2.099 ms) : 2047, 2150
.   : milestone, 2099,
profiling (1.926 ms) : 1886, 1967
.   : milestone, 1926,
tracing (1.903 ms) : 1864, 1942
.   : milestone, 1903,
section candidate
no_agent (1.458 ms) : 1446, 1469
.   : milestone, 1458,
appsec (2.304 ms) : 2263, 2344
.   : milestone, 2304,
iast (2.062 ms) : 2011, 2114
.   : milestone, 2062,
iast_GLOBAL (2.1 ms) : 2049, 2152
.   : milestone, 2100,
profiling (1.919 ms) : 1878, 1960
.   : milestone, 1919,
tracing (1.901 ms) : 1862, 1940
.   : milestone, 1901,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.452 ms, 1.475 ms] -
appsec 2.302 ms [2.262 ms, 2.342 ms] 838.392 µs (57.3%)
iast 2.059 ms [2.008 ms, 2.11 ms] 595.792 µs (40.7%)
iast_GLOBAL 2.099 ms [2.047 ms, 2.15 ms] 635.157 µs (43.4%)
profiling 1.926 ms [1.886 ms, 1.967 ms] 462.977 µs (31.6%)
tracing 1.903 ms [1.864 ms, 1.942 ms] 439.136 µs (30.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.446 ms, 1.469 ms] -
appsec 2.304 ms [2.263 ms, 2.344 ms] 846.217 µs (58.1%)
iast 2.062 ms [2.011 ms, 2.114 ms] 604.86 µs (41.5%)
iast_GLOBAL 2.1 ms [2.049 ms, 2.152 ms] 642.926 µs (44.1%)
profiling 1.919 ms [1.878 ms, 1.96 ms] 461.228 µs (31.6%)
tracing 1.901 ms [1.862 ms, 1.94 ms] 443.135 µs (30.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~cc28d89c23, baseline=1.41.0-SNAPSHOT~14a45ea1c3
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.452 s) : 15452000, 15452000
.   : milestone, 15452000,
appsec (15.208 s) : 15208000, 15208000
.   : milestone, 15208000,
iast (18.878 s) : 18878000, 18878000
.   : milestone, 18878000,
iast_GLOBAL (18.084 s) : 18084000, 18084000
.   : milestone, 18084000,
profiling (15.418 s) : 15418000, 15418000
.   : milestone, 15418000,
tracing (15.005 s) : 15005000, 15005000
.   : milestone, 15005000,
section candidate
no_agent (15.141 s) : 15141000, 15141000
.   : milestone, 15141000,
appsec (15.034 s) : 15034000, 15034000
.   : milestone, 15034000,
iast (18.896 s) : 18896000, 18896000
.   : milestone, 18896000,
iast_GLOBAL (17.961 s) : 17961000, 17961000
.   : milestone, 17961000,
profiling (15.246 s) : 15246000, 15246000
.   : milestone, 15246000,
tracing (15.34 s) : 15340000, 15340000
.   : milestone, 15340000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.452 s [15.452 s, 15.452 s] -
appsec 15.208 s [15.208 s, 15.208 s] -244.0 ms (-1.6%)
iast 18.878 s [18.878 s, 18.878 s] 3.426 s (22.2%)
iast_GLOBAL 18.084 s [18.084 s, 18.084 s] 2.632 s (17.0%)
profiling 15.418 s [15.418 s, 15.418 s] -34.0 ms (-0.2%)
tracing 15.005 s [15.005 s, 15.005 s] -447.0 ms (-2.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.141 s [15.141 s, 15.141 s] -
appsec 15.034 s [15.034 s, 15.034 s] -107.0 ms (-0.7%)
iast 18.896 s [18.896 s, 18.896 s] 3.755 s (24.8%)
iast_GLOBAL 17.961 s [17.961 s, 17.961 s] 2.82 s (18.6%)
profiling 15.246 s [15.246 s, 15.246 s] 105.0 ms (0.7%)
tracing 15.34 s [15.34 s, 15.34 s] 199.0 ms (1.3%)

@mtoffl01
Copy link
Contributor

Can you include a unit test for this (or amend an existing one)? It will prove that the version tag is behaving as we expect, plus it will demonstrate the behavior to any other readers in the future.

@mhlidd mhlidd marked this pull request as ready for review October 2, 2024 17:24
@mhlidd mhlidd requested a review from a team as a code owner October 2, 2024 17:24
@mhlidd mhlidd requested a review from dougqh October 2, 2024 17:24
PerfectSlayer
PerfectSlayer approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo otherwise LGTM

dd-trace-core/src/test/groovy/datadog/trace/core/CoreTracerTest.groovy Outdated
@@ -544,6 +545,32 @@ class CoreTracerTest extends DDCoreSpecification {
"some" | "some"
}

def "test dd_version exists iff service == dd_service"() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def "test dd_version exists iff service == dd_service"() {
def "test dd_version exists only if service == dd_service"() {

@raphaelgavache raphaelgavache mentioned this pull request Oct 7, 2024
Merged
@mhlidd mhlidd merged commit 3ddea41 into master Oct 9, 2024
104 checks passed
@mhlidd mhlidd deleted the mhlidd/DD_VERSION branch October 9, 2024 19:18
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@mtoffl01 mtoffl01 Awaiting requested review from mtoffl01

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: core Tracer core type: enhancement
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mhlidd @mtoffl01 @PerfectSlayer