-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce log level for "WAF object had not been closed" #7657
Conversation
84cfecf
to
66f15fc
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~66f15fc66c, baseline=1.40.0-SNAPSHOT~f6810002f7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080736
Total [baseline] (10.464 s) : 0, 10464130
Agent [candidate] (1.073 s) : 0, 1072654
Total [candidate] (10.406 s) : 0, 10406244
section appsec
Agent [baseline] (1.203 s) : 0, 1203322
Total [baseline] (10.662 s) : 0, 10662201
Agent [candidate] (1.203 s) : 0, 1203435
Total [candidate] (10.654 s) : 0, 10654207
section iast
Agent [baseline] (1.193 s) : 0, 1193486
Total [baseline] (10.904 s) : 0, 10904125
Agent [candidate] (1.202 s) : 0, 1202434
Total [candidate] (10.916 s) : 0, 10916331
section profiling
Agent [baseline] (1.266 s) : 0, 1265895
Total [baseline] (10.593 s) : 0, 10592629
Agent [candidate] (1.269 s) : 0, 1269145
Total [candidate] (10.629 s) : 0, 10628643
gantt
title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~66f15fc66c, baseline=1.40.0-SNAPSHOT~f6810002f7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.764 ms) : 0, 689764
BytebuddyAgent [candidate] (685.656 ms) : 0, 685656
GlobalTracer [baseline] (314.407 ms) : 0, 314407
GlobalTracer [candidate] (310.789 ms) : 0, 310789
AppSec [baseline] (54.215 ms) : 0, 54215
AppSec [candidate] (54.043 ms) : 0, 54043
Remote Config [baseline] (675.299 µs) : 0, 675
Remote Config [candidate] (673.447 µs) : 0, 673
Telemetry [baseline] (7.723 ms) : 0, 7723
Telemetry [candidate] (7.64 ms) : 0, 7640
section appsec
BytebuddyAgent [baseline] (702.099 ms) : 0, 702099
BytebuddyAgent [candidate] (702.981 ms) : 0, 702981
GlobalTracer [baseline] (304.283 ms) : 0, 304283
GlobalTracer [candidate] (303.835 ms) : 0, 303835
AppSec [baseline] (162.623 ms) : 0, 162623
AppSec [candidate] (163.442 ms) : 0, 163442
Remote Config [baseline] (652.918 µs) : 0, 653
Remote Config [candidate] (650.879 µs) : 0, 651
Telemetry [baseline] (9.657 ms) : 0, 9657
Telemetry [candidate] (8.164 ms) : 0, 8164
IAST [baseline] (20.58 ms) : 0, 20580
IAST [candidate] (21.308 ms) : 0, 21308
section iast
BytebuddyAgent [baseline] (793.56 ms) : 0, 793560
BytebuddyAgent [candidate] (799.659 ms) : 0, 799659
GlobalTracer [baseline] (299.056 ms) : 0, 299056
GlobalTracer [candidate] (301.194 ms) : 0, 301194
AppSec [baseline] (55.145 ms) : 0, 55145
AppSec [candidate] (53.805 ms) : 0, 53805
Remote Config [baseline] (613.342 µs) : 0, 613
Remote Config [candidate] (609.076 µs) : 0, 609
Telemetry [baseline] (7.483 ms) : 0, 7483
Telemetry [candidate] (7.535 ms) : 0, 7535
IAST [baseline] (23.897 ms) : 0, 23897
IAST [candidate] (25.757 ms) : 0, 25757
section profiling
ProfilingAgent [baseline] (96.676 ms) : 0, 96676
ProfilingAgent [candidate] (96.325 ms) : 0, 96325
BytebuddyAgent [baseline] (673.52 ms) : 0, 673520
BytebuddyAgent [candidate] (675.496 ms) : 0, 675496
GlobalTracer [baseline] (394.811 ms) : 0, 394811
GlobalTracer [candidate] (396.241 ms) : 0, 396241
AppSec [baseline] (54.664 ms) : 0, 54664
AppSec [candidate] (54.57 ms) : 0, 54570
Remote Config [baseline] (647.993 µs) : 0, 648
Remote Config [candidate] (661.638 µs) : 0, 662
Telemetry [baseline] (7.431 ms) : 0, 7431
Telemetry [candidate] (7.456 ms) : 0, 7456
Profiling [baseline] (96.7 ms) : 0, 96700
Profiling [candidate] (96.349 ms) : 0, 96349
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~66f15fc66c, baseline=1.40.0-SNAPSHOT~f6810002f7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068788
Total [baseline] (8.578 s) : 0, 8578047
Agent [candidate] (1.066 s) : 0, 1066051
Total [candidate] (8.566 s) : 0, 8565796
section iast
Agent [baseline] (1.204 s) : 0, 1203644
Total [baseline] (9.014 s) : 0, 9013858
Agent [candidate] (1.197 s) : 0, 1196706
Total [candidate] (9.054 s) : 0, 9053997
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.192 s) : 0, 1192069
Total [baseline] (9.013 s) : 0, 9013409
Agent [candidate] (1.191 s) : 0, 1191120
Total [candidate] (8.989 s) : 0, 8988694
section iast_TELEMETRY_OFF
Agent [baseline] (1.198 s) : 0, 1197819
Total [baseline] (9.036 s) : 0, 9036145
Agent [candidate] (1.199 s) : 0, 1198524
Total [candidate] (9.018 s) : 0, 9018203
gantt
title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~66f15fc66c, baseline=1.40.0-SNAPSHOT~f6810002f7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.776 ms) : 0, 681776
BytebuddyAgent [candidate] (680.33 ms) : 0, 680330
GlobalTracer [baseline] (310.851 ms) : 0, 310851
GlobalTracer [candidate] (310.022 ms) : 0, 310022
AppSec [baseline] (54.065 ms) : 0, 54065
AppSec [candidate] (53.754 ms) : 0, 53754
Remote Config [baseline] (672.2 µs) : 0, 672
Remote Config [candidate] (667.516 µs) : 0, 668
Telemetry [baseline] (7.639 ms) : 0, 7639
Telemetry [candidate] (7.551 ms) : 0, 7551
section iast
BytebuddyAgent [baseline] (800.718 ms) : 0, 800718
BytebuddyAgent [candidate] (796.115 ms) : 0, 796115
GlobalTracer [baseline] (301.556 ms) : 0, 301556
GlobalTracer [candidate] (300.201 ms) : 0, 300201
AppSec [baseline] (55.876 ms) : 0, 55876
AppSec [candidate] (54.015 ms) : 0, 54015
IAST [baseline] (23.598 ms) : 0, 23598
IAST [candidate] (24.504 ms) : 0, 24504
Remote Config [baseline] (631.605 µs) : 0, 632
Remote Config [candidate] (640.665 µs) : 0, 641
Telemetry [baseline] (7.392 ms) : 0, 7392
Telemetry [candidate] (7.412 ms) : 0, 7412
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (792.268 ms) : 0, 792268
BytebuddyAgent [candidate] (791.981 ms) : 0, 791981
GlobalTracer [baseline] (299.328 ms) : 0, 299328
GlobalTracer [candidate] (299.049 ms) : 0, 299049
AppSec [baseline] (53.356 ms) : 0, 53356
AppSec [candidate] (54.765 ms) : 0, 54765
IAST [baseline] (25.326 ms) : 0, 25326
IAST [candidate] (23.567 ms) : 0, 23567
Remote Config [baseline] (638.94 µs) : 0, 639
Remote Config [candidate] (607.213 µs) : 0, 607
Telemetry [baseline] (7.402 ms) : 0, 7402
Telemetry [candidate] (7.356 ms) : 0, 7356
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.527 ms) : 0, 796527
BytebuddyAgent [candidate] (796.092 ms) : 0, 796092
GlobalTracer [baseline] (301.726 ms) : 0, 301726
GlobalTracer [candidate] (301.914 ms) : 0, 301914
AppSec [baseline] (56.199 ms) : 0, 56199
AppSec [candidate] (56.234 ms) : 0, 56234
IAST [baseline] (21.551 ms) : 0, 21551
IAST [candidate] (22.545 ms) : 0, 22545
Remote Config [baseline] (613.833 µs) : 0, 614
Remote Config [candidate] (600.084 µs) : 0, 600
Telemetry [baseline] (7.304 ms) : 0, 7304
Telemetry [candidate] (7.233 ms) : 0, 7233
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~66f15fc66c, baseline=1.40.0-SNAPSHOT~f6810002f7
dateFormat X
axisFormat %s
section baseline
no_agent (374.668 µs) : 352, 397
. : milestone, 375,
iast (487.316 µs) : 466, 509
. : milestone, 487,
iast_FULL (556.132 µs) : 535, 578
. : milestone, 556,
iast_GLOBAL (513.618 µs) : 492, 535
. : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (487.068 µs) : 466, 508
. : milestone, 487,
iast_INACTIVE (448.205 µs) : 427, 469
. : milestone, 448,
iast_TELEMETRY_OFF (478.437 µs) : 456, 501
. : milestone, 478,
tracing (438.974 µs) : 419, 459
. : milestone, 439,
section candidate
no_agent (373.226 µs) : 353, 393
. : milestone, 373,
iast (486.611 µs) : 465, 508
. : milestone, 487,
iast_FULL (556.304 µs) : 535, 578
. : milestone, 556,
iast_GLOBAL (509.479 µs) : 488, 531
. : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (482.145 µs) : 461, 503
. : milestone, 482,
iast_INACTIVE (453.045 µs) : 432, 474
. : milestone, 453,
iast_TELEMETRY_OFF (475.1 µs) : 453, 498
. : milestone, 475,
tracing (453.628 µs) : 433, 475
. : milestone, 454,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~66f15fc66c, baseline=1.40.0-SNAPSHOT~f6810002f7
dateFormat X
axisFormat %s
section baseline
no_agent (1.351 ms) : 1332, 1370
. : milestone, 1351,
appsec (1.71 ms) : 1685, 1735
. : milestone, 1710,
appsec_no_iast (1.717 ms) : 1694, 1741
. : milestone, 1717,
iast (1.486 ms) : 1463, 1509
. : milestone, 1486,
profiling (1.496 ms) : 1474, 1519
. : milestone, 1496,
tracing (1.486 ms) : 1462, 1509
. : milestone, 1486,
section candidate
no_agent (1.345 ms) : 1324, 1365
. : milestone, 1345,
appsec (1.746 ms) : 1722, 1770
. : milestone, 1746,
appsec_no_iast (1.744 ms) : 1720, 1768
. : milestone, 1744,
iast (1.476 ms) : 1453, 1499
. : milestone, 1476,
profiling (1.482 ms) : 1460, 1505
. : milestone, 1482,
tracing (1.453 ms) : 1428, 1478
. : milestone, 1453,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~66f15fc66c, baseline=1.40.0-SNAPSHOT~f6810002f7
dateFormat X
axisFormat %s
section baseline
no_agent (15.346 s) : 15346000, 15346000
. : milestone, 15346000,
appsec (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
iast (18.977 s) : 18977000, 18977000
. : milestone, 18977000,
iast_GLOBAL (17.698 s) : 17698000, 17698000
. : milestone, 17698000,
profiling (15.14 s) : 15140000, 15140000
. : milestone, 15140000,
tracing (14.939 s) : 14939000, 14939000
. : milestone, 14939000,
section candidate
no_agent (15.863 s) : 15863000, 15863000
. : milestone, 15863000,
appsec (15.063 s) : 15063000, 15063000
. : milestone, 15063000,
iast (18.765 s) : 18765000, 18765000
. : milestone, 18765000,
iast_GLOBAL (17.933 s) : 17933000, 17933000
. : milestone, 17933000,
profiling (15.688 s) : 15688000, 15688000
. : milestone, 15688000,
tracing (14.9 s) : 14900000, 14900000
. : milestone, 14900000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~66f15fc66c, baseline=1.40.0-SNAPSHOT~f6810002f7
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (2.316 ms) : 2275, 2357
. : milestone, 2316,
iast (2.056 ms) : 2005, 2107
. : milestone, 2056,
iast_GLOBAL (2.1 ms) : 2049, 2151
. : milestone, 2100,
profiling (1.921 ms) : 1882, 1961
. : milestone, 1921,
tracing (1.891 ms) : 1852, 1929
. : milestone, 1891,
section candidate
no_agent (1.461 ms) : 1449, 1472
. : milestone, 1461,
appsec (2.308 ms) : 2268, 2349
. : milestone, 2308,
iast (2.052 ms) : 2002, 2103
. : milestone, 2052,
iast_GLOBAL (2.091 ms) : 2040, 2142
. : milestone, 2091,
profiling (2.359 ms) : 2185, 2533
. : milestone, 2359,
tracing (1.898 ms) : 1860, 1936
. : milestone, 1898,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable
(cherry picked from commit 7f040c5)
What Does This Do
For log message
WAF object had not been closed (probably missed request-end event)
:Motivation
These rarely happen, but when they happen, they tend to happen frequently. The insistent logging becomes a problem in itself, and the error is not directly actionable by our customers. Hence the debug level. However, this indicates a bug in the tracer, so we'll force it to telemetry logs (if telemetry logs are enabled) so that we still have info on any regression.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issue[ ] Update the public documentation in case of new configuration flag or behaviorJira ticket: SCRS-1078