Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NullPointerException in RASP metrics #7654

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix NullPointerException in RASP metrics #7654

merged 1 commit into from
Sep 20, 2024

Conversation

smola
Copy link
Member

@smola smola commented Sep 20, 2024 •
edited by jira bot
Loading

What Does This Do

Avoid NullPointerException when incrementing RASP call count after request end.

Motivation

Fixing this exception:

WARN com.datadog.appsec.event.EventDispatcher - AppSec callback exception"
java.lang.NullPointerException: Cannot invoke ""java.util.concurrent.atomic.AtomicInteger.incrementAndGet()"" because the return value of ""com.datadog.appsec.gateway.AppSecRequestContext.getRaspMetricsCounter()"" is null"
at com.datadog.appsec.powerwaf.PowerWAFModule$PowerWAFDataCallback.doRunPowerwaf(PowerWAFModule.java:611)"
at com.datadog.appsec.powerwaf.PowerWAFModule$PowerWAFDataCallback.onDataAvailable(PowerWAFModule.java:439)"
at com.datadog.appsec.event.EventDispatcher.publishDataEvent(EventDispatcher.java:148)"
at com.datadog.appsec.event.ReplaceableEventProducerService.publishDataEvent(ReplaceableEventProducerService.java:29)"
at com.datadog.appsec.gateway.GatewayBridge.onDatabaseSqlQuery(GatewayBridge.java:184)"
at datadog.trace.api.gateway.InstrumentationGateway$14.apply(InstrumentationGateway.java:389)"
at datadog.trace.api.gateway.InstrumentationGateway$14.apply(InstrumentationGateway.java:384)"
at datadog.trace.bootstrap.instrumentation.decorator.DatabaseClientDecorator.onRawStatement(DatabaseClientDecorator.java:130)"
at datadog.trace.instrumentation.jdbc.JDBCDecorator.onStatement(JDBCDecorator.java:216)"
at com.zaxxer.hikari.pool.HikariProxyStatement.executeQuery(HikariProxyStatement.java)"
at org.springframework.jdbc.core.JdbcTemplate$1QueryStatementCallback.doInStatement(JdbcTemplate.java:452)"

This should not be triggered anyway once we prevent WAF calls for Exploit Prevention (RASP) after request end, but we should guard against the NPE just in case.

Additional Notes

Contributor Checklist

Jira ticket: APPSEC-54970

@smola smola added type: bug comp: asm waf Application Security Management (WAF) labels Sep 20, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 20, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/rasp-metrics-npe
git_commit_date 1726823241 1726824711
git_commit_sha 5867971 943f3dd
release_version 1.40.0-SNAPSHOT~58679718b3 1.40.0-SNAPSHOT~943f3dd42c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726827084 1726827084
ci_job_id 646166156 646166156
ci_pipeline_id 44775254 44775254
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~943f3dd42c, baseline=1.40.0-SNAPSHOT~58679718b3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1068492
Total [baseline] (8.566 s) : 0, 8566363
Agent [candidate] (1.068 s) : 0, 1067762
Total [candidate] (8.553 s) : 0, 8552639
section iast
Agent [baseline] (1.196 s) : 0, 1196217
Total [baseline] (9.02 s) : 0, 9020496
Agent [candidate] (1.194 s) : 0, 1193626
Total [candidate] (9.061 s) : 0, 9060993
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.197 s) : 0, 1196777
Total [baseline] (9.06 s) : 0, 9059842
Agent [candidate] (1.195 s) : 0, 1195320
Total [candidate] (9.022 s) : 0, 9021873
section iast_TELEMETRY_OFF
Agent [baseline] (1.201 s) : 0, 1200512
Total [baseline] (9.104 s) : 0, 9103516
Agent [candidate] (1.191 s) : 0, 1191184
Total [candidate] (9.044 s) : 0, 9043686
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent iast 1.196 s 127.725 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.197 s 128.285 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.201 s 132.02 ms (12.4%)
Total tracing 8.566 s -
Total iast 9.02 s 454.132 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.06 s 493.479 ms (5.8%)
Total iast_TELEMETRY_OFF 9.104 s 537.152 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent iast 1.194 s 125.865 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.195 s 127.558 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.191 s 123.422 ms (11.6%)
Total tracing 8.553 s -
Total iast 9.061 s 508.354 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.022 s 469.234 ms (5.5%)
Total iast_TELEMETRY_OFF 9.044 s 491.047 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~943f3dd42c, baseline=1.40.0-SNAPSHOT~58679718b3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.414 ms) : 0, 680414
BytebuddyAgent [candidate] (679.702 ms) : 0, 679702
GlobalTracer [baseline] (312.2 ms) : 0, 312200
GlobalTracer [candidate] (312.067 ms) : 0, 312067
AppSec [baseline] (53.802 ms) : 0, 53802
AppSec [candidate] (53.946 ms) : 0, 53946
Remote Config [baseline] (675.072 µs) : 0, 675
Remote Config [candidate] (673.943 µs) : 0, 674
Telemetry [baseline] (7.611 ms) : 0, 7611
Telemetry [candidate] (7.613 ms) : 0, 7613
section iast
BytebuddyAgent [baseline] (795.369 ms) : 0, 795369
BytebuddyAgent [candidate] (792.941 ms) : 0, 792941
GlobalTracer [baseline] (300.297 ms) : 0, 300297
GlobalTracer [candidate] (299.665 ms) : 0, 299665
AppSec [baseline] (55.801 ms) : 0, 55801
AppSec [candidate] (54.456 ms) : 0, 54456
Remote Config [baseline] (618.968 µs) : 0, 619
Remote Config [candidate] (605.165 µs) : 0, 605
Telemetry [baseline] (7.411 ms) : 0, 7411
Telemetry [candidate] (8.177 ms) : 0, 8177
IAST [baseline] (22.871 ms) : 0, 22871
IAST [candidate] (23.948 ms) : 0, 23948
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (795.167 ms) : 0, 795167
BytebuddyAgent [candidate] (793.977 ms) : 0, 793977
GlobalTracer [baseline] (300.704 ms) : 0, 300704
GlobalTracer [candidate] (300.748 ms) : 0, 300748
AppSec [baseline] (54.039 ms) : 0, 54039
AppSec [candidate] (54.247 ms) : 0, 54247
Remote Config [baseline] (692.536 µs) : 0, 693
Remote Config [candidate] (608.718 µs) : 0, 609
Telemetry [baseline] (7.528 ms) : 0, 7528
Telemetry [candidate] (8.208 ms) : 0, 8208
IAST [baseline] (24.805 ms) : 0, 24805
IAST [candidate] (23.711 ms) : 0, 23711
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.335 ms) : 0, 797335
BytebuddyAgent [candidate] (790.165 ms) : 0, 790165
GlobalTracer [baseline] (302.831 ms) : 0, 302831
GlobalTracer [candidate] (300.834 ms) : 0, 300834
AppSec [baseline] (55.561 ms) : 0, 55561
AppSec [candidate] (54.42 ms) : 0, 54420
Remote Config [baseline] (620.271 µs) : 0, 620
Remote Config [candidate] (1.394 ms) : 0, 1394
Telemetry [baseline] (7.4 ms) : 0, 7400
Telemetry [candidate] (7.197 ms) : 0, 7197
IAST [baseline] (22.847 ms) : 0, 22847
IAST [candidate] (23.383 ms) : 0, 23383
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~943f3dd42c, baseline=1.40.0-SNAPSHOT~58679718b3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1069522
Total [baseline] (10.453 s) : 0, 10452533
Agent [candidate] (1.068 s) : 0, 1067676
Total [candidate] (10.418 s) : 0, 10417879
section appsec
Agent [baseline] (1.209 s) : 0, 1209298
Total [baseline] (10.669 s) : 0, 10668682
Agent [candidate] (1.207 s) : 0, 1207052
Total [candidate] (10.686 s) : 0, 10686240
section iast
Agent [baseline] (1.204 s) : 0, 1203967
Total [baseline] (10.857 s) : 0, 10857124
Agent [candidate] (1.213 s) : 0, 1213063
Total [candidate] (11.002 s) : 0, 11002325
section profiling
Agent [baseline] (1.27 s) : 0, 1270298
Total [baseline] (10.563 s) : 0, 10563304
Agent [candidate] (1.27 s) : 0, 1270383
Total [candidate] (10.665 s) : 0, 10664913
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent appsec 1.209 s 139.776 ms (13.1%)
Agent iast 1.204 s 134.446 ms (12.6%)
Agent profiling 1.27 s 200.776 ms (18.8%)
Total tracing 10.453 s -
Total appsec 10.669 s 216.149 ms (2.1%)
Total iast 10.857 s 404.591 ms (3.9%)
Total profiling 10.563 s 110.771 ms (1.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent appsec 1.207 s 139.375 ms (13.1%)
Agent iast 1.213 s 145.387 ms (13.6%)
Agent profiling 1.27 s 202.706 ms (19.0%)
Total tracing 10.418 s -
Total appsec 10.686 s 268.361 ms (2.6%)
Total iast 11.002 s 584.447 ms (5.6%)
Total profiling 10.665 s 247.034 ms (2.4%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~943f3dd42c, baseline=1.40.0-SNAPSHOT~58679718b3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.386 ms) : 0, 681386
BytebuddyAgent [candidate] (680.087 ms) : 0, 680087
GlobalTracer [baseline] (312.445 ms) : 0, 312445
GlobalTracer [candidate] (311.528 ms) : 0, 311528
AppSec [baseline] (53.554 ms) : 0, 53554
AppSec [candidate] (53.953 ms) : 0, 53953
Remote Config [baseline] (668.727 µs) : 0, 669
Remote Config [candidate] (669.894 µs) : 0, 670
Telemetry [baseline] (7.679 ms) : 0, 7679
Telemetry [candidate] (7.637 ms) : 0, 7637
section appsec
BytebuddyAgent [baseline] (705.216 ms) : 0, 705216
BytebuddyAgent [candidate] (704.177 ms) : 0, 704177
GlobalTracer [baseline] (305.667 ms) : 0, 305667
GlobalTracer [candidate] (305.39 ms) : 0, 305390
AppSec [baseline] (165.599 ms) : 0, 165599
AppSec [candidate] (163.225 ms) : 0, 163225
IAST [baseline] (19.791 ms) : 0, 19791
IAST [candidate] (19.948 ms) : 0, 19948
Remote Config [baseline] (656.847 µs) : 0, 657
Remote Config [candidate] (640.197 µs) : 0, 640
Telemetry [baseline] (8.509 ms) : 0, 8509
Telemetry [candidate] (9.864 ms) : 0, 9864
section iast
BytebuddyAgent [baseline] (800.494 ms) : 0, 800494
BytebuddyAgent [candidate] (806.527 ms) : 0, 806527
GlobalTracer [baseline] (302.719 ms) : 0, 302719
GlobalTracer [candidate] (304.806 ms) : 0, 304806
AppSec [baseline] (55.989 ms) : 0, 55989
AppSec [candidate] (54.767 ms) : 0, 54767
IAST [baseline] (22.803 ms) : 0, 22803
IAST [candidate] (24.816 ms) : 0, 24816
Remote Config [baseline] (631.086 µs) : 0, 631
Remote Config [candidate] (662.287 µs) : 0, 662
Telemetry [baseline] (7.415 ms) : 0, 7415
Telemetry [candidate] (7.486 ms) : 0, 7486
section profiling
BytebuddyAgent [baseline] (674.329 ms) : 0, 674329
BytebuddyAgent [candidate] (675.886 ms) : 0, 675886
GlobalTracer [baseline] (398.155 ms) : 0, 398155
GlobalTracer [candidate] (397.0 ms) : 0, 397000
AppSec [baseline] (54.614 ms) : 0, 54614
AppSec [candidate] (54.832 ms) : 0, 54832
Remote Config [baseline] (658.53 µs) : 0, 659
Remote Config [candidate] (665.511 µs) : 0, 666
Telemetry [baseline] (7.529 ms) : 0, 7529
Telemetry [candidate] (7.527 ms) : 0, 7527
ProfilingAgent [baseline] (96.64 ms) : 0, 96640
ProfilingAgent [candidate] (96.173 ms) : 0, 96173
Profiling [baseline] (96.665 ms) : 0, 96665
Profiling [candidate] (96.196 ms) : 0, 96196
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-20T09:41:51 2024-09-20T09:48:42
git_branch master smola/rasp-metrics-npe
git_commit_date 1726823241 1726824711
git_commit_sha 5867971 943f3dd
release_version 1.40.0-SNAPSHOT~58679718b3 1.40.0-SNAPSHOT~943f3dd42c
start_time 2024-09-20T09:41:38 2024-09-20T09:48:28
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726826071 1726826071
ci_job_id 646166157 646166157
ci_pipeline_id 44775254 44775254
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~943f3dd42c, baseline=1.40.0-SNAPSHOT~58679718b3
    dateFormat X
    axisFormat %s
section baseline
no_agent (375.054 µs) : 354, 396
.   : milestone, 375,
iast (487.429 µs) : 466, 509
.   : milestone, 487,
iast_FULL (557.725 µs) : 537, 579
.   : milestone, 558,
iast_GLOBAL (504.129 µs) : 483, 525
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (480.217 µs) : 459, 501
.   : milestone, 480,
iast_INACTIVE (447.341 µs) : 426, 469
.   : milestone, 447,
iast_TELEMETRY_OFF (474.659 µs) : 452, 497
.   : milestone, 475,
tracing (443.868 µs) : 423, 464
.   : milestone, 444,
section candidate
no_agent (373.043 µs) : 352, 394
.   : milestone, 373,
iast (491.369 µs) : 469, 513
.   : milestone, 491,
iast_FULL (553.856 µs) : 533, 575
.   : milestone, 554,
iast_GLOBAL (503.584 µs) : 483, 525
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (489.558 µs) : 468, 511
.   : milestone, 490,
iast_INACTIVE (451.579 µs) : 430, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (479.294 µs) : 456, 502
.   : milestone, 479,
tracing (449.534 µs) : 429, 470
.   : milestone, 450,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.054 µs [354.207 µs, 395.901 µs] -
iast 487.429 µs [465.728 µs, 509.13 µs] 112.375 µs (30.0%)
iast_FULL 557.725 µs [536.512 µs, 578.937 µs] 182.671 µs (48.7%)
iast_GLOBAL 504.129 µs [482.874 µs, 525.384 µs] 129.075 µs (34.4%)
iast_HARDCODED_SECRET_DISABLED 480.217 µs [459.299 µs, 501.134 µs] 105.163 µs (28.0%)
iast_INACTIVE 447.341 µs [425.995 µs, 468.687 µs] 72.287 µs (19.3%)
iast_TELEMETRY_OFF 474.659 µs [452.412 µs, 496.905 µs] 99.605 µs (26.6%)
tracing 443.868 µs [423.434 µs, 464.301 µs] 68.814 µs (18.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.043 µs [352.1 µs, 393.986 µs] -
iast 491.369 µs [469.367 µs, 513.372 µs] 118.326 µs (31.7%)
iast_FULL 553.856 µs [532.614 µs, 575.098 µs] 180.813 µs (48.5%)
iast_GLOBAL 503.584 µs [482.574 µs, 524.595 µs] 130.541 µs (35.0%)
iast_HARDCODED_SECRET_DISABLED 489.558 µs [468.367 µs, 510.748 µs] 116.515 µs (31.2%)
iast_INACTIVE 451.579 µs [430.496 µs, 472.661 µs] 78.536 µs (21.1%)
iast_TELEMETRY_OFF 479.294 µs [456.241 µs, 502.348 µs] 106.251 µs (28.5%)
tracing 449.534 µs [428.595 µs, 470.474 µs] 76.491 µs (20.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~943f3dd42c, baseline=1.40.0-SNAPSHOT~58679718b3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.347 ms) : 1327, 1366
.   : milestone, 1347,
appsec (1.711 ms) : 1688, 1734
.   : milestone, 1711,
appsec_no_iast (1.723 ms) : 1698, 1747
.   : milestone, 1723,
iast (1.481 ms) : 1458, 1503
.   : milestone, 1481,
profiling (1.522 ms) : 1496, 1548
.   : milestone, 1522,
tracing (1.482 ms) : 1458, 1506
.   : milestone, 1482,
section candidate
no_agent (1.336 ms) : 1316, 1355
.   : milestone, 1336,
appsec (1.728 ms) : 1704, 1752
.   : milestone, 1728,
appsec_no_iast (1.724 ms) : 1700, 1748
.   : milestone, 1724,
iast (1.498 ms) : 1476, 1520
.   : milestone, 1498,
profiling (1.525 ms) : 1501, 1549
.   : milestone, 1525,
tracing (1.467 ms) : 1442, 1492
.   : milestone, 1467,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.327 ms, 1.366 ms] -
appsec 1.711 ms [1.688 ms, 1.734 ms] 363.879 µs (27.0%)
appsec_no_iast 1.723 ms [1.698 ms, 1.747 ms] 375.765 µs (27.9%)
iast 1.481 ms [1.458 ms, 1.503 ms] 134.136 µs (10.0%)
profiling 1.522 ms [1.496 ms, 1.548 ms] 174.947 µs (13.0%)
tracing 1.482 ms [1.458 ms, 1.506 ms] 135.158 µs (10.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.336 ms [1.316 ms, 1.355 ms] -
appsec 1.728 ms [1.704 ms, 1.752 ms] 392.594 µs (29.4%)
appsec_no_iast 1.724 ms [1.7 ms, 1.748 ms] 388.261 µs (29.1%)
iast 1.498 ms [1.476 ms, 1.52 ms] 162.63 µs (12.2%)
profiling 1.525 ms [1.501 ms, 1.549 ms] 189.52 µs (14.2%)
tracing 1.467 ms [1.442 ms, 1.492 ms] 131.413 µs (9.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/rasp-metrics-npe
git_commit_date 1726823241 1726824711
git_commit_sha 5867971 943f3dd
release_version 1.40.0-SNAPSHOT~58679718b3 1.40.0-SNAPSHOT~943f3dd42c
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1726826714 1726826714
ci_job_id 646166158 646166158
ci_pipeline_id 44775254 44775254
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~943f3dd42c, baseline=1.40.0-SNAPSHOT~58679718b3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1484
.   : milestone, 1472,
appsec (2.318 ms) : 2278, 2359
.   : milestone, 2318,
iast (2.054 ms) : 2004, 2105
.   : milestone, 2054,
iast_GLOBAL (2.095 ms) : 2045, 2146
.   : milestone, 2095,
profiling (1.925 ms) : 1884, 1966
.   : milestone, 1925,
tracing (1.898 ms) : 1860, 1937
.   : milestone, 1898,
section candidate
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.309 ms) : 2269, 2349
.   : milestone, 2309,
iast (2.058 ms) : 2007, 2108
.   : milestone, 2058,
iast_GLOBAL (2.093 ms) : 2043, 2143
.   : milestone, 2093,
profiling (1.921 ms) : 1881, 1961
.   : milestone, 1921,
tracing (1.89 ms) : 1852, 1928
.   : milestone, 1890,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.484 ms] -
appsec 2.318 ms [2.278 ms, 2.359 ms] 846.173 µs (57.5%)
iast 2.054 ms [2.004 ms, 2.105 ms] 582.195 µs (39.5%)
iast_GLOBAL 2.095 ms [2.045 ms, 2.146 ms] 623.325 µs (42.3%)
profiling 1.925 ms [1.884 ms, 1.966 ms] 453.012 µs (30.8%)
tracing 1.898 ms [1.86 ms, 1.937 ms] 425.893 µs (28.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 2.309 ms [2.269 ms, 2.349 ms] 840.17 µs (57.2%)
iast 2.058 ms [2.007 ms, 2.108 ms] 588.899 µs (40.1%)
iast_GLOBAL 2.093 ms [2.043 ms, 2.143 ms] 624.104 µs (42.5%)
profiling 1.921 ms [1.881 ms, 1.961 ms] 452.628 µs (30.8%)
tracing 1.89 ms [1.852 ms, 1.928 ms] 421.259 µs (28.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~943f3dd42c, baseline=1.40.0-SNAPSHOT~58679718b3
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.758 s) : 15758000, 15758000
.   : milestone, 15758000,
appsec (15.242 s) : 15242000, 15242000
.   : milestone, 15242000,
iast (18.783 s) : 18783000, 18783000
.   : milestone, 18783000,
iast_GLOBAL (17.834 s) : 17834000, 17834000
.   : milestone, 17834000,
profiling (15.212 s) : 15212000, 15212000
.   : milestone, 15212000,
tracing (15.071 s) : 15071000, 15071000
.   : milestone, 15071000,
section candidate
no_agent (15.414 s) : 15414000, 15414000
.   : milestone, 15414000,
appsec (15.33 s) : 15330000, 15330000
.   : milestone, 15330000,
iast (18.711 s) : 18711000, 18711000
.   : milestone, 18711000,
iast_GLOBAL (17.963 s) : 17963000, 17963000
.   : milestone, 17963000,
profiling (15.228 s) : 15228000, 15228000
.   : milestone, 15228000,
tracing (15.177 s) : 15177000, 15177000
.   : milestone, 15177000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.758 s [15.758 s, 15.758 s] -
appsec 15.242 s [15.242 s, 15.242 s] -516.0 ms (-3.3%)
iast 18.783 s [18.783 s, 18.783 s] 3.025 s (19.2%)
iast_GLOBAL 17.834 s [17.834 s, 17.834 s] 2.076 s (13.2%)
profiling 15.212 s [15.212 s, 15.212 s] -546.0 ms (-3.5%)
tracing 15.071 s [15.071 s, 15.071 s] -687.0 ms (-4.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.414 s [15.414 s, 15.414 s] -
appsec 15.33 s [15.33 s, 15.33 s] -84.0 ms (-0.5%)
iast 18.711 s [18.711 s, 18.711 s] 3.297 s (21.4%)
iast_GLOBAL 17.963 s [17.963 s, 17.963 s] 2.549 s (16.5%)
profiling 15.228 s [15.228 s, 15.228 s] -186.0 ms (-1.2%)
tracing 15.177 s [15.177 s, 15.177 s] -237.0 ms (-1.5%)

@smola smola marked this pull request as ready for review September 20, 2024 13:57
@smola smola requested a review from a team as a code owner September 20, 2024 13:57
@smola smola merged commit 4ef9a80 into master Sep 20, 2024
104 checks passed
@smola smola deleted the smola/rasp-metrics-npe branch September 20, 2024 14:38
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 20, 2024
smola added a commit that referenced this pull request Sep 23, 2024
@smola
Fix NPE in RASP metrics (#7654)
ddb9de2 
(cherry picked from commit 4ef9a80)
@smola smola mentioned this pull request Sep 23, 2024
Merged
5 tasks
smola added a commit that referenced this pull request Sep 23, 2024
@smola
Fix NPE in RASP metrics (#7654) (#7668)
b636a59 
(cherry picked from commit 4ef9a80)
jordan-wong pushed a commit that referenced this pull request Sep 23, 2024
@smola @jordan-wong
Fix NPE in RASP metrics (#7654)
5c484d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValentinZakharov ValentinZakharov ValentinZakharov approved these changes

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) type: bug
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@smola @ValentinZakharov