Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add File and Path as string primitive #7652

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Add File and Path as string primitive #7652

merged 1 commit into from
Sep 20, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Sep 20, 2024 •
edited by jira bot
Loading

What Does This Do

Since jdk 17 it's not possible to do deep reflection. The content of File or Path instances are difficult to see content with deep reflection, though the meaningful value is the toString representation We are adding File and Path instances serialized as string primitive and evaluated in EL as String as well

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2853

@jpbempel
Add File and Path as string primitive
5bf362a 
Since jdk 17 it's not possible to do deep reflection. The content of
File or Path instances are difficult to see content with deep
reflection, though the meaningful value is the toString representation
We are adding File and Path instances serialized as string primitive
and evaluated in EL as String as well
@jpbempel jpbempel added type: enhancement comp: debugger Dynamic Instrumentation labels Sep 20, 2024
@jpbempel jpbempel requested a review from a team as a code owner September 20, 2024 07:55
@jpbempel jpbempel requested review from shatzi and removed request for a team September 20, 2024 07:55
@pr-commenter
Copy link

pr-commenter bot commented Sep 20, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1726819548 1726819923
end_time 2024-09-20T08:07:03 2024-09-20T08:13:18
git_branch master jpbempel/file-path-as-primitive
git_commit_sha 92a664b 5bf362a
start_time 2024-09-20T08:05:49 2024-09-20T08:12:04
See matching parameters
Baseline Candidate
ci_job_id 646038407 646038407
ci_pipeline_id 44767127 44767127
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1726818849 1726818849

Summary

Found 0 performance improvements and 5 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop worse
[+599.744µs; +612.268µs] or [+5.889%; +6.012%]		 worse
[+598.601µs; +650.982µs] or [+5.789%; +6.296%]		 worse
[+559.536µs; +666.021µs] or [+5.363%; +6.384%]		 worse
[+402.843µs; +841.602µs] or [+3.726%; +7.785%]		 worse
[-6.469op/s; -4.738op/s] or [-6.761%; -4.951%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-20.539µs; +50.594µs] or [-7.952%; +19.589%]		 unstable
[-29.019µs; +69.856µs] or [-9.821%; +23.642%]		 unstable
[-37.729µs; +80.486µs] or [-12.208%; +26.042%]		 unstable
[-230.881µs; +525.495µs] or [-37.678%; +85.756%]		 same
scenario:basic same same same unstable
[-70.352µs; +72.739µs] or [-12.168%; +12.581%]		 unstable
[-181.753op/s; +181.753op/s] or [-7.088%; +7.088%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (295.477 µs) : 274, 317
.   : milestone, 295,
basic (302.23 µs) : 295, 310
.   : milestone, 302,
loop (10.34 ms) : 10319, 10361
.   : milestone, 10340,
section candidate
noprobe (315.896 µs) : 253, 379
.   : milestone, 316,
basic (308.804 µs) : 294, 324
.   : milestone, 309,
loop (10.965 ms) : 10937, 10992
.   : milestone, 10965,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 295.477 µs [273.64 µs, 317.314 µs]
basic 302.23 µs [294.532 µs, 309.928 µs]
loop 10.34 ms [10.319 ms, 10.361 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 315.896 µs [252.883 µs, 378.909 µs]
basic 308.804 µs [293.724 µs, 323.884 µs]
loop 10.965 ms [10.937 ms, 10.992 ms]

@pr-commenter
Copy link

pr-commenter bot commented Sep 20, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/file-path-as-primitive
git_commit_date 1726810927 1726818849
git_commit_sha 92a664b 5bf362a
release_version 1.40.0-SNAPSHOT~92a664b5b9 1.40.0-SNAPSHOT~5bf362a964
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726821400 1726821400
ci_job_id 646038401 646038401
ci_pipeline_id 44767127 44767127
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~5bf362a964, baseline=1.40.0-SNAPSHOT~92a664b5b9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063819
Total [baseline] (10.365 s) : 0, 10365104
Agent [candidate] (1.068 s) : 0, 1068408
Total [candidate] (10.399 s) : 0, 10398870
section appsec
Agent [baseline] (1.198 s) : 0, 1197987
Total [baseline] (10.608 s) : 0, 10608323
Agent [candidate] (1.207 s) : 0, 1207357
Total [candidate] (10.642 s) : 0, 10641578
section iast
Agent [baseline] (1.191 s) : 0, 1191171
Total [baseline] (10.862 s) : 0, 10862164
Agent [candidate] (1.201 s) : 0, 1200576
Total [candidate] (10.852 s) : 0, 10852340
section profiling
Agent [baseline] (1.266 s) : 0, 1266320
Total [baseline] (10.609 s) : 0, 10609413
Agent [candidate] (1.274 s) : 0, 1273820
Total [candidate] (10.607 s) : 0, 10606979
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.198 s 134.168 ms (12.6%)
Agent iast 1.191 s 127.352 ms (12.0%)
Agent profiling 1.266 s 202.501 ms (19.0%)
Total tracing 10.365 s -
Total appsec 10.608 s 243.22 ms (2.3%)
Total iast 10.862 s 497.06 ms (4.8%)
Total profiling 10.609 s 244.309 ms (2.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent appsec 1.207 s 138.949 ms (13.0%)
Agent iast 1.201 s 132.167 ms (12.4%)
Agent profiling 1.274 s 205.411 ms (19.2%)
Total tracing 10.399 s -
Total appsec 10.642 s 242.708 ms (2.3%)
Total iast 10.852 s 453.47 ms (4.4%)
Total profiling 10.607 s 208.109 ms (2.0%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~5bf362a964, baseline=1.40.0-SNAPSHOT~92a664b5b9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.23 ms) : 0, 678230
BytebuddyAgent [candidate] (679.494 ms) : 0, 679494
GlobalTracer [baseline] (309.992 ms) : 0, 309992
GlobalTracer [candidate] (312.774 ms) : 0, 312774
AppSec [baseline] (53.736 ms) : 0, 53736
AppSec [candidate] (54.185 ms) : 0, 54185
Remote Config [baseline] (658.136 µs) : 0, 658
Remote Config [candidate] (667.394 µs) : 0, 667
Telemetry [baseline] (7.567 ms) : 0, 7567
Telemetry [candidate] (7.622 ms) : 0, 7622
section appsec
BytebuddyAgent [baseline] (700.012 ms) : 0, 700012
BytebuddyAgent [candidate] (705.675 ms) : 0, 705675
GlobalTracer [baseline] (302.767 ms) : 0, 302767
GlobalTracer [candidate] (305.354 ms) : 0, 305354
AppSec [baseline] (162.408 ms) : 0, 162408
AppSec [candidate] (162.572 ms) : 0, 162572
IAST [baseline] (19.666 ms) : 0, 19666
IAST [candidate] (19.842 ms) : 0, 19842
Remote Config [baseline] (653.668 µs) : 0, 654
Remote Config [candidate] (654.507 µs) : 0, 655
Telemetry [baseline] (8.762 ms) : 0, 8762
Telemetry [candidate] (9.485 ms) : 0, 9485
section iast
BytebuddyAgent [baseline] (791.834 ms) : 0, 791834
BytebuddyAgent [candidate] (798.703 ms) : 0, 798703
GlobalTracer [baseline] (299.281 ms) : 0, 299281
GlobalTracer [candidate] (301.174 ms) : 0, 301174
AppSec [baseline] (54.957 ms) : 0, 54957
AppSec [candidate] (56.17 ms) : 0, 56170
IAST [baseline] (23.485 ms) : 0, 23485
IAST [candidate] (22.774 ms) : 0, 22774
Remote Config [baseline] (629.612 µs) : 0, 630
Remote Config [candidate] (635.206 µs) : 0, 635
Telemetry [baseline] (7.322 ms) : 0, 7322
Telemetry [candidate] (7.394 ms) : 0, 7394
section profiling
BytebuddyAgent [baseline] (675.705 ms) : 0, 675705
BytebuddyAgent [candidate] (677.884 ms) : 0, 677884
GlobalTracer [baseline] (394.161 ms) : 0, 394161
GlobalTracer [candidate] (398.13 ms) : 0, 398130
AppSec [baseline] (54.206 ms) : 0, 54206
AppSec [candidate] (54.718 ms) : 0, 54718
Remote Config [baseline] (672.155 µs) : 0, 672
Remote Config [candidate] (659.094 µs) : 0, 659
Telemetry [baseline] (7.41 ms) : 0, 7410
Telemetry [candidate] (7.46 ms) : 0, 7460
ProfilingAgent [baseline] (95.934 ms) : 0, 95934
ProfilingAgent [candidate] (96.664 ms) : 0, 96664
Profiling [baseline] (95.957 ms) : 0, 95957
Profiling [candidate] (96.688 ms) : 0, 96688
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~5bf362a964, baseline=1.40.0-SNAPSHOT~92a664b5b9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071889
Total [baseline] (8.58 s) : 0, 8580448
Agent [candidate] (1.065 s) : 0, 1064953
Total [candidate] (8.544 s) : 0, 8544435
section iast
Agent [baseline] (1.208 s) : 0, 1207535
Total [baseline] (9.051 s) : 0, 9050716
Agent [candidate] (1.189 s) : 0, 1189381
Total [candidate] (9.006 s) : 0, 9006491
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.189 s) : 0, 1189153
Total [baseline] (8.966 s) : 0, 8966254
Agent [candidate] (1.188 s) : 0, 1187943
Total [candidate] (8.978 s) : 0, 8977665
section iast_TELEMETRY_OFF
Agent [baseline] (1.186 s) : 0, 1186466
Total [baseline] (8.998 s) : 0, 8997865
Agent [candidate] (1.195 s) : 0, 1195433
Total [candidate] (9.002 s) : 0, 9002161
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent iast 1.208 s 135.646 ms (12.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.189 s 117.264 ms (10.9%)
Agent iast_TELEMETRY_OFF 1.186 s 114.577 ms (10.7%)
Total tracing 8.58 s -
Total iast 9.051 s 470.268 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.966 s 385.805 ms (4.5%)
Total iast_TELEMETRY_OFF 8.998 s 417.416 ms (4.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.189 s 124.428 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.188 s 122.99 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.195 s 130.48 ms (12.3%)
Total tracing 8.544 s -
Total iast 9.006 s 462.056 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.978 s 433.229 ms (5.1%)
Total iast_TELEMETRY_OFF 9.002 s 457.726 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~5bf362a964, baseline=1.40.0-SNAPSHOT~92a664b5b9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.641 ms) : 0, 683641
BytebuddyAgent [candidate] (678.5 ms) : 0, 678500
GlobalTracer [baseline] (312.255 ms) : 0, 312255
GlobalTracer [candidate] (310.544 ms) : 0, 310544
AppSec [baseline] (53.974 ms) : 0, 53974
AppSec [candidate] (54.012 ms) : 0, 54012
Remote Config [baseline] (674.2 µs) : 0, 674
Remote Config [candidate] (670.17 µs) : 0, 670
Telemetry [baseline] (7.627 ms) : 0, 7627
Telemetry [candidate] (7.59 ms) : 0, 7590
section iast
BytebuddyAgent [baseline] (803.251 ms) : 0, 803251
BytebuddyAgent [candidate] (790.697 ms) : 0, 790697
GlobalTracer [baseline] (302.881 ms) : 0, 302881
GlobalTracer [candidate] (298.991 ms) : 0, 298991
AppSec [baseline] (54.864 ms) : 0, 54864
AppSec [candidate] (53.811 ms) : 0, 53811
IAST [baseline] (24.672 ms) : 0, 24672
IAST [candidate] (24.284 ms) : 0, 24284
Remote Config [baseline] (643.527 µs) : 0, 644
Remote Config [candidate] (624.872 µs) : 0, 625
Telemetry [baseline] (7.429 ms) : 0, 7429
Telemetry [candidate] (7.293 ms) : 0, 7293
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (791.264 ms) : 0, 791264
BytebuddyAgent [candidate] (789.413 ms) : 0, 789413
GlobalTracer [baseline] (298.583 ms) : 0, 298583
GlobalTracer [candidate] (299.196 ms) : 0, 299196
AppSec [baseline] (55.954 ms) : 0, 55954
AppSec [candidate] (54.109 ms) : 0, 54109
IAST [baseline] (21.719 ms) : 0, 21719
IAST [candidate] (22.828 ms) : 0, 22828
Remote Config [baseline] (609.454 µs) : 0, 609
Remote Config [candidate] (597.983 µs) : 0, 598
Telemetry [baseline] (7.337 ms) : 0, 7337
Telemetry [candidate] (8.132 ms) : 0, 8132
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (787.575 ms) : 0, 787575
BytebuddyAgent [candidate] (794.191 ms) : 0, 794191
GlobalTracer [baseline] (299.211 ms) : 0, 299211
GlobalTracer [candidate] (301.839 ms) : 0, 301839
AppSec [baseline] (55.869 ms) : 0, 55869
AppSec [candidate] (54.59 ms) : 0, 54590
IAST [baseline] (21.455 ms) : 0, 21455
IAST [candidate] (23.199 ms) : 0, 23199
Remote Config [baseline] (1.428 ms) : 0, 1428
Remote Config [candidate] (609.468 µs) : 0, 609
Telemetry [baseline] (7.259 ms) : 0, 7259
Telemetry [candidate] (7.227 ms) : 0, 7227
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-20T08:07:18 2024-09-20T08:14:12
git_branch master jpbempel/file-path-as-primitive
git_commit_date 1726810927 1726818849
git_commit_sha 92a664b 5bf362a
release_version 1.40.0-SNAPSHOT~92a664b5b9 1.40.0-SNAPSHOT~5bf362a964
start_time 2024-09-20T08:07:05 2024-09-20T08:13:58
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1726820398 1726820398
ci_job_id 646038402 646038402
ci_pipeline_id 44767127 44767127
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-87.613µs; -36.090µs] or [-5.668%; -2.335%]		 unstable
[-582.297op/s; +582.297op/s] or [-18.925%; +18.925%]		 1.484ms 3076.923op/s 1.546ms 3076.923op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~5bf362a964, baseline=1.40.0-SNAPSHOT~92a664b5b9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.34 ms) : 1320, 1359
.   : milestone, 1340,
appsec (1.709 ms) : 1684, 1734
.   : milestone, 1709,
appsec_no_iast (1.757 ms) : 1733, 1781
.   : milestone, 1757,
iast (1.493 ms) : 1471, 1515
.   : milestone, 1493,
profiling (1.546 ms) : 1521, 1570
.   : milestone, 1546,
tracing (1.462 ms) : 1438, 1486
.   : milestone, 1462,
section candidate
no_agent (1.349 ms) : 1329, 1368
.   : milestone, 1349,
appsec (1.728 ms) : 1705, 1751
.   : milestone, 1728,
appsec_no_iast (1.719 ms) : 1695, 1744
.   : milestone, 1719,
iast (1.468 ms) : 1445, 1491
.   : milestone, 1468,
profiling (1.484 ms) : 1461, 1507
.   : milestone, 1484,
tracing (1.455 ms) : 1431, 1480
.   : milestone, 1455,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.34 ms [1.32 ms, 1.359 ms] -
appsec 1.709 ms [1.684 ms, 1.734 ms] 369.395 µs (27.6%)
appsec_no_iast 1.757 ms [1.733 ms, 1.781 ms] 417.426 µs (31.2%)
iast 1.493 ms [1.471 ms, 1.515 ms] 153.195 µs (11.4%)
profiling 1.546 ms [1.521 ms, 1.57 ms] 205.833 µs (15.4%)
tracing 1.462 ms [1.438 ms, 1.486 ms] 122.172 µs (9.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.329 ms, 1.368 ms] -
appsec 1.728 ms [1.705 ms, 1.751 ms] 379.253 µs (28.1%)
appsec_no_iast 1.719 ms [1.695 ms, 1.744 ms] 370.374 µs (27.5%)
iast 1.468 ms [1.445 ms, 1.491 ms] 119.532 µs (8.9%)
profiling 1.484 ms [1.461 ms, 1.507 ms] 135.1 µs (10.0%)
tracing 1.455 ms [1.431 ms, 1.48 ms] 106.747 µs (7.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~5bf362a964, baseline=1.40.0-SNAPSHOT~92a664b5b9
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.695 µs) : 346, 385
.   : milestone, 366,
iast (486.911 µs) : 465, 509
.   : milestone, 487,
iast_FULL (556.642 µs) : 535, 578
.   : milestone, 557,
iast_GLOBAL (509.76 µs) : 488, 532
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (485.548 µs) : 464, 507
.   : milestone, 486,
iast_INACTIVE (445.667 µs) : 425, 466
.   : milestone, 446,
iast_TELEMETRY_OFF (484.778 µs) : 462, 508
.   : milestone, 485,
tracing (447.746 µs) : 427, 469
.   : milestone, 448,
section candidate
no_agent (365.643 µs) : 346, 386
.   : milestone, 366,
iast (485.303 µs) : 464, 507
.   : milestone, 485,
iast_FULL (555.942 µs) : 535, 577
.   : milestone, 556,
iast_GLOBAL (521.015 µs) : 498, 544
.   : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (485.551 µs) : 464, 507
.   : milestone, 486,
iast_INACTIVE (452.111 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (478.19 µs) : 455, 501
.   : milestone, 478,
tracing (444.456 µs) : 424, 465
.   : milestone, 444,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.695 µs [345.953 µs, 385.437 µs] -
iast 486.911 µs [465.243 µs, 508.578 µs] 121.215 µs (33.1%)
iast_FULL 556.642 µs [535.039 µs, 578.246 µs] 190.947 µs (52.2%)
iast_GLOBAL 509.76 µs [487.99 µs, 531.531 µs] 144.065 µs (39.4%)
iast_HARDCODED_SECRET_DISABLED 485.548 µs [464.168 µs, 506.929 µs] 119.853 µs (32.8%)
iast_INACTIVE 445.667 µs [424.976 µs, 466.359 µs] 79.972 µs (21.9%)
iast_TELEMETRY_OFF 484.778 µs [461.639 µs, 507.918 µs] 119.083 µs (32.6%)
tracing 447.746 µs [426.884 µs, 468.608 µs] 82.051 µs (22.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.643 µs [345.701 µs, 385.585 µs] -
iast 485.303 µs [463.697 µs, 506.908 µs] 119.66 µs (32.7%)
iast_FULL 555.942 µs [534.575 µs, 577.309 µs] 190.299 µs (52.0%)
iast_GLOBAL 521.015 µs [497.547 µs, 544.483 µs] 155.372 µs (42.5%)
iast_HARDCODED_SECRET_DISABLED 485.551 µs [464.28 µs, 506.822 µs] 119.908 µs (32.8%)
iast_INACTIVE 452.111 µs [430.882 µs, 473.339 µs] 86.468 µs (23.6%)
iast_TELEMETRY_OFF 478.19 µs [455.451 µs, 500.929 µs] 112.547 µs (30.8%)
tracing 444.456 µs [423.718 µs, 465.195 µs] 78.814 µs (21.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/file-path-as-primitive
git_commit_date 1726810927 1726818849
git_commit_sha 92a664b 5bf362a
release_version 1.40.0-SNAPSHOT~92a664b5b9 1.40.0-SNAPSHOT~5bf362a964
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1726821056 1726821056
ci_job_id 646038403 646038403
ci_pipeline_id 44767127 44767127
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~5bf362a964, baseline=1.40.0-SNAPSHOT~92a664b5b9
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.336 s) : 15336000, 15336000
.   : milestone, 15336000,
appsec (15.368 s) : 15368000, 15368000
.   : milestone, 15368000,
iast (18.642 s) : 18642000, 18642000
.   : milestone, 18642000,
iast_GLOBAL (18.194 s) : 18194000, 18194000
.   : milestone, 18194000,
profiling (15.315 s) : 15315000, 15315000
.   : milestone, 15315000,
tracing (15.205 s) : 15205000, 15205000
.   : milestone, 15205000,
section candidate
no_agent (15.06 s) : 15060000, 15060000
.   : milestone, 15060000,
appsec (15.033 s) : 15033000, 15033000
.   : milestone, 15033000,
iast (18.79 s) : 18790000, 18790000
.   : milestone, 18790000,
iast_GLOBAL (18.08 s) : 18080000, 18080000
.   : milestone, 18080000,
profiling (15.384 s) : 15384000, 15384000
.   : milestone, 15384000,
tracing (15.111 s) : 15111000, 15111000
.   : milestone, 15111000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.336 s [15.336 s, 15.336 s] -
appsec 15.368 s [15.368 s, 15.368 s] 32.0 ms (0.2%)
iast 18.642 s [18.642 s, 18.642 s] 3.306 s (21.6%)
iast_GLOBAL 18.194 s [18.194 s, 18.194 s] 2.858 s (18.6%)
profiling 15.315 s [15.315 s, 15.315 s] -21.0 ms (-0.1%)
tracing 15.205 s [15.205 s, 15.205 s] -131.0 ms (-0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.06 s [15.06 s, 15.06 s] -
appsec 15.033 s [15.033 s, 15.033 s] -27.0 ms (-0.2%)
iast 18.79 s [18.79 s, 18.79 s] 3.73 s (24.8%)
iast_GLOBAL 18.08 s [18.08 s, 18.08 s] 3.02 s (20.1%)
profiling 15.384 s [15.384 s, 15.384 s] 324.0 ms (2.2%)
tracing 15.111 s [15.111 s, 15.111 s] 51.0 ms (0.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~5bf362a964, baseline=1.40.0-SNAPSHOT~92a664b5b9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.31 ms) : 2269, 2350
.   : milestone, 2310,
iast (2.038 ms) : 1989, 2086
.   : milestone, 2038,
iast_GLOBAL (2.096 ms) : 2045, 2147
.   : milestone, 2096,
profiling (1.924 ms) : 1884, 1964
.   : milestone, 1924,
tracing (1.904 ms) : 1866, 1943
.   : milestone, 1904,
section candidate
no_agent (1.467 ms) : 1455, 1479
.   : milestone, 1467,
appsec (2.305 ms) : 2265, 2345
.   : milestone, 2305,
iast (2.059 ms) : 2009, 2110
.   : milestone, 2059,
iast_GLOBAL (2.115 ms) : 2063, 2168
.   : milestone, 2115,
profiling (1.922 ms) : 1882, 1962
.   : milestone, 1922,
tracing (1.891 ms) : 1853, 1929
.   : milestone, 1891,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.31 ms [2.269 ms, 2.35 ms] 842.773 µs (57.5%)
iast 2.038 ms [1.989 ms, 2.086 ms] 571.085 µs (38.9%)
iast_GLOBAL 2.096 ms [2.045 ms, 2.147 ms] 629.097 µs (42.9%)
profiling 1.924 ms [1.884 ms, 1.964 ms] 456.985 µs (31.2%)
tracing 1.904 ms [1.866 ms, 1.943 ms] 437.593 µs (29.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.479 ms] -
appsec 2.305 ms [2.265 ms, 2.345 ms] 838.198 µs (57.1%)
iast 2.059 ms [2.009 ms, 2.11 ms] 592.385 µs (40.4%)
iast_GLOBAL 2.115 ms [2.063 ms, 2.168 ms] 648.439 µs (44.2%)
profiling 1.922 ms [1.882 ms, 1.962 ms] 455.007 µs (31.0%)
tracing 1.891 ms [1.853 ms, 1.929 ms] 424.236 µs (28.9%)

shatzi
shatzi approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@shatzi shatzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jpbempel jpbempel merged commit a6bcbc1 into master Sep 20, 2024
105 checks passed
@jpbempel jpbempel deleted the jpbempel/file-path-as-primitive branch September 20, 2024 17:44
@github-actions github-actions bot added this to the 1.40.0 milestone Sep 20, 2024
jordan-wong pushed a commit that referenced this pull request Sep 23, 2024
@jpbempel @jordan-wong
Add File and Path as string primitive (#7652)
a642ebe 
Since jdk 17 it's not possible to do deep reflection. The content of
File or Path instances are difficult to see content with deep
reflection, though the meaningful value is the toString representation
We are adding File and Path instances serialized as string primitive
and evaluated in EL as String as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatzi shatzi shatzi approved these changes

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: enhancement
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @shatzi